Re: [PR] NIFI-12333 MiNiFi property override through env and system variables [nifi]

2023-11-08 Thread via GitHub
briansolo1985 commented on code in PR #7997: URL: https://github.com/apache/nifi/pull/7997#discussion_r1386758472 ## minifi/minifi-commons/minifi-utils/src/main/java/org/apache/nifi/minifi/commons/status/util/PropertyUtil.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache

Re: [PR] NIFI-12313 - Update PutDatabaseRecord.java add property use database table column datatype [nifi]

2023-11-08 Thread via GitHub
mattyb149 commented on PR #7981: URL: https://github.com/apache/nifi/pull/7981#issuecomment-1802883745 > Thanks for the contribution @avasquezkudaw. As this presents an important behavioral change in the Processor, it would be helpful to add a unit test method that verifies the expected

Re: [PR] NIFI-11995 Support multiple output formats for message headers in ConsumeAMQP [nifi]

2023-11-08 Thread via GitHub
codecov-commenter commented on PR #7652: URL: https://github.com/apache/nifi/pull/7652#issuecomment-1802843410 ## [Codecov](https://app.codecov.io/gh/apache/nifi/pull/7652?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report > :exclamation: No

[jira] [Resolved] (NIFI-12336) Update mockito.version to 5.7.0

2023-11-08 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-12336. - Fix Version/s: 2.0.0 Resolution: Fixed > Update mockito.version to 5.7.0 >

[jira] [Updated] (NIFI-12336) Update mockito.version to 5.7.0

2023-11-08 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12336: Priority: Minor (was: Major) > Update mockito.version to 5.7.0 >

[jira] [Commented] (NIFI-12336) Update mockito.version to 5.7.0

2023-11-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784222#comment-17784222 ] ASF subversion and git services commented on NIFI-12336: Commit

[jira] [Updated] (NIFI-12336) Update mockito.version to 5.7.0

2023-11-08 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12336: Affects Version/s: (was: 1.23.2) > Update mockito.version to 5.7.0 >

Re: [PR] NIFI-12336 Update mockito.version to 5.7.0 [nifi]

2023-11-08 Thread via GitHub
exceptionfactory closed pull request #8000: NIFI-12336 Update mockito.version to 5.7.0 URL: https://github.com/apache/nifi/pull/8000 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] NIFI-11129 - adding PutMongoBulk processor to use the bulkWrite API [nifi]

2023-11-08 Thread via GitHub
sebastianrothbucher commented on PR #6918: URL: https://github.com/apache/nifi/pull/6918#issuecomment-1802690448 I don't think it was sth I did, specifically; it's just that Mongo might not yet have committed the deletion of the DB in question. I nonetheless did two things: 1.) use

[jira] [Created] (NIFI-12338) Misspelling of "the" in PutKudu documentation for Operation RecordPath property

2023-11-08 Thread Andrew M. Lim (Jira)
Andrew M. Lim created NIFI-12338: Summary: Misspelling of "the" in PutKudu documentation for Operation RecordPath property Key: NIFI-12338 URL: https://issues.apache.org/jira/browse/NIFI-12338

Re: [PR] NIFI-12336 Update mockito.version to 5.7.0 [nifi]

2023-11-08 Thread via GitHub
mr1716 commented on PR #8000: URL: https://github.com/apache/nifi/pull/8000#issuecomment-1802590124 Workflow succeeded. But integration test didnt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Created] (NIFI-12337) GitHub Action Workflows could better report test results and summaries

2023-11-08 Thread Chris Sampson (Jira)
Chris Sampson created NIFI-12337: Summary: GitHub Action Workflows could better report test results and summaries Key: NIFI-12337 URL: https://issues.apache.org/jira/browse/NIFI-12337 Project: Apache

[jira] [Updated] (NIFI-12192) GitHub Action Workflows should report Code Coverage for CI Unit Tests

2023-11-08 Thread Chris Sampson (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Sampson updated NIFI-12192: - Fix Version/s: 2.0.0 (was: 2.latest) Resolution: Fixed

[jira] [Updated] (NIFI-12192) GitHub Action Workflows should report Code Coverage for CI Unit Tests

2023-11-08 Thread Chris Sampson (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Sampson updated NIFI-12192: - Summary: GitHub Action Workflows should report Code Coverage for CI Unit Tests (was: GitHub

[jira] [Updated] (NIFI-12192) GitHub Action Workflows should report Code Coverage for CI Unit Tests

2023-11-08 Thread Chris Sampson (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Sampson updated NIFI-12192: - Description: Consider adding test coverage reporting, at least for one of the ci-integration

[jira] [Commented] (NIFI-12192) GitHub Action Workflows could better report Tests Results and Summaries

2023-11-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784189#comment-17784189 ] ASF subversion and git services commented on NIFI-12192: Commit

Re: [PR] NIFI-12192 Add Codecov Reporting with JaCoCo [nifi]

2023-11-08 Thread via GitHub
asfgit closed pull request #7995: NIFI-12192 Add Codecov Reporting with JaCoCo URL: https://github.com/apache/nifi/pull/7995 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Assigned] (NIFI-11308) Create an Expression Language function to return NiFi version

2023-11-08 Thread Anna Nys (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anna Nys reassigned NIFI-11308: --- Assignee: Anna Nys > Create an Expression Language function to return NiFi version >

[jira] [Commented] (NIFI-12335) MiNiFi startup failure

2023-11-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784152#comment-17784152 ] ASF subversion and git services commented on NIFI-12335: Commit

Re: [PR] NIFI-12335 Fix MiNiFi startup issue [nifi]

2023-11-08 Thread via GitHub
bejancsaba closed pull request #7998: NIFI-12335 Fix MiNiFi startup issue URL: https://github.com/apache/nifi/pull/7998 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] NIFI-12121 added the ability to modify the output filter in … [nifi]

2023-11-08 Thread via GitHub
mosermw commented on code in PR #7922: URL: https://github.com/apache/nifi/pull/7922#discussion_r1386907257 ## nifi-nar-bundles/nifi-jslt-bundle/nifi-jslt-processors/src/main/java/org/apache/nifi/processors/jslt/JSLTTransformJSON.java: ## @@ -107,6 +110,18 @@ public class

Re: [PR] NIFI-12335 Fix MiNiFi startup issue [nifi]

2023-11-08 Thread via GitHub
bejancsaba commented on PR #7998: URL: https://github.com/apache/nifi/pull/7998#issuecomment-1802233628 Thanks for the details and the changes will merge as soon as the workflows conclude. +1 from my side -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] NIFI-12233 - Parameter context provider for 1Password [nifi]

2023-11-08 Thread via GitHub
exceptionfactory commented on code in PR #7884: URL: https://github.com/apache/nifi/pull/7884#discussion_r1386864555 ## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-parameter-providers/src/main/java/org/apache/nifi/parameter/OnePasswordParameterProvider.java: ## @@ -0,0

[PR] NIFI-12336 Update mockito.version to 5.7.0 [nifi]

2023-11-08 Thread via GitHub
mr1716 opened a new pull request, #8000: URL: https://github.com/apache/nifi/pull/8000 # Summary [NIFI-12336](https://issues.apache.org/jira/browse/NIFI-12336) # Tracking Please complete the following tracking steps

[jira] [Assigned] (NIFI-12336) Update mockito.version to 5.7.0

2023-11-08 Thread Mike R (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike R reassigned NIFI-12336: - Assignee: Mike R > Update mockito.version to 5.7.0 > --- > >

Re: [PR] NIFI-11129 - adding PutMongoBulk processor to use the bulkWrite API [nifi]

2023-11-08 Thread via GitHub
sebastianrothbucher commented on PR #6918: URL: https://github.com/apache/nifi/pull/6918#issuecomment-1802207437 I still have to look. I ran tests before each push - and they just worked. Also from the error messages - it seems like sth gets stuck due to load. Let me get back2u -- This

[jira] [Created] (NIFI-12336) Update mockito.version to 5.7.0

2023-11-08 Thread Mike R (Jira)
Mike R created NIFI-12336: - Summary: Update mockito.version to 5.7.0 Key: NIFI-12336 URL: https://issues.apache.org/jira/browse/NIFI-12336 Project: Apache NiFi Issue Type: Improvement Affects

Re: [PR] NIFI-12334: Implement GCS option for FileResourceService [nifi]

2023-11-08 Thread via GitHub
pvillard31 commented on PR #7999: URL: https://github.com/apache/nifi/pull/7999#issuecomment-1802147126 I think the end goal here is to provide very high performance when it's about moving data from an object store to another without any kind of transformation. Right now support for

Re: [PR] NIFI-12334: Implement GCS option for FileResourceService [nifi]

2023-11-08 Thread via GitHub
mark-bathori commented on PR #7999: URL: https://github.com/apache/nifi/pull/7999#issuecomment-1802124689 Thanks for the question @exceptionfactory. Currently if someone would like to move their data from one storage to another they would need to use a List processor into a Fetch

Re: [PR] NIFI-12335 Fix MiNiFi startup issue [nifi]

2023-11-08 Thread via GitHub
ferencerdei commented on code in PR #7998: URL: https://github.com/apache/nifi/pull/7998#discussion_r1386754850 ## minifi/minifi-commons/minifi-commons-framework/src/main/java/org/apache/nifi/minifi/commons/service/FlowEnrichService.java: ## @@ -103,10 +107,12 @@ public byte[]

[jira] [Commented] (NIFI-11463) Add option for IdentifyMimeType custom mime definitions to be in addition to the default tika definitions

2023-11-08 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784084#comment-17784084 ] David Handermann commented on NIFI-11463: - You're welcome [~Nissim Shiman], thanks again for your

[jira] [Commented] (NIFI-11463) Add option for IdentifyMimeType custom mime definitions to be in addition to the default tika definitions

2023-11-08 Thread Nissim Shiman (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784082#comment-17784082 ] Nissim Shiman commented on NIFI-11463: -- Thank you [~exceptionfactory] for direction in the PR for

Re: [PR] NIFI-12335 Fix MiNiFi startup issue [nifi]

2023-11-08 Thread via GitHub
ferencerdei commented on code in PR #7998: URL: https://github.com/apache/nifi/pull/7998#discussion_r1386728669 ## minifi/minifi-commons/minifi-commons-framework/src/main/java/org/apache/nifi/minifi/commons/service/FlowEnrichService.java: ## @@ -103,10 +107,12 @@ public byte[]

Re: [PR] MINIFICPP-1415 Pass references to onTrigger and onSchedule instead of… [nifi-minifi-cpp]

2023-11-08 Thread via GitHub
adamdebreceni commented on code in PR #1693: URL: https://github.com/apache/nifi-minifi-cpp/pull/1693#discussion_r1386727993 ## extensions/http-curl/processors/InvokeHTTP.cpp: ## @@ -202,15 +186,15 @@ bool InvokeHTTP::appendHeaders(const core::FlowFile& flow_file,

Re: [PR] NIFI-12335 Fix MiNiFi startup issue [nifi]

2023-11-08 Thread via GitHub
ferencerdei commented on code in PR #7998: URL: https://github.com/apache/nifi/pull/7998#discussion_r1386724790 ## minifi/minifi-commons/minifi-commons-framework/src/main/java/org/apache/nifi/minifi/commons/service/FlowEnrichService.java: ## @@ -90,6 +91,9 @@ public byte[]

Re: [PR] NIFI-12335 Fix MiNiFi startup issue [nifi]

2023-11-08 Thread via GitHub
briansolo1985 commented on code in PR #7998: URL: https://github.com/apache/nifi/pull/7998#discussion_r1386715480 ## minifi/minifi-commons/minifi-commons-framework/src/main/java/org/apache/nifi/minifi/commons/service/FlowEnrichService.java: ## @@ -103,10 +107,12 @@ public

Re: [PR] NIFI-12335 Fix MiNiFi startup issue [nifi]

2023-11-08 Thread via GitHub
bejancsaba commented on code in PR #7998: URL: https://github.com/apache/nifi/pull/7998#discussion_r1386713417 ## minifi/minifi-commons/minifi-commons-framework/src/main/java/org/apache/nifi/minifi/commons/service/FlowEnrichService.java: ## @@ -90,6 +91,9 @@ public byte[]

[PR] NIFI-12334: Implement GCS option for FileResourceService [nifi]

2023-11-08 Thread via GitHub
mark-bathori opened a new pull request, #7999: URL: https://github.com/apache/nifi/pull/7999 # Summary [NIFI-12334](https://issues.apache.org/jira/browse/NIFI-12334) # Tracking Please complete the following tracking

[PR] NIFI-12335 Fix MiNiFi startup issue [nifi]

2023-11-08 Thread via GitHub
ferencerdei opened a new pull request, #7998: URL: https://github.com/apache/nifi/pull/7998 # Summary [NIFI-12335](https://issues.apache.org/jira/browse/NIFI-12335) # Tracking Please complete the following tracking

[jira] [Created] (NIFI-12335) MiNiFi startup failure

2023-11-08 Thread Ferenc Erdei (Jira)
Ferenc Erdei created NIFI-12335: --- Summary: MiNiFi startup failure Key: NIFI-12335 URL: https://issues.apache.org/jira/browse/NIFI-12335 Project: Apache NiFi Issue Type: Bug

[jira] [Updated] (NIFI-12334) Implement GCS option for FileResourceService

2023-11-08 Thread Mark Bathori (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Bathori updated NIFI-12334: Description: Add GCS based implementation for the FileResourceService interface to be able to

[jira] [Created] (NIFI-12334) Implement GCS option for FileResourceService

2023-11-08 Thread Mark Bathori (Jira)
Mark Bathori created NIFI-12334: --- Summary: Implement GCS option for FileResourceService Key: NIFI-12334 URL: https://issues.apache.org/jira/browse/NIFI-12334 Project: Apache NiFi Issue Type:

[jira] [Updated] (NIFI-12261) Refactor Schema Access Strategy and Remove Hortonworks Properties

2023-11-08 Thread Bryan Bende (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende updated NIFI-12261: --- Fix Version/s: 2.0.0 (was: 2.latest) Resolution: Fixed

[jira] [Commented] (NIFI-12261) Refactor Schema Access Strategy and Remove Hortonworks Properties

2023-11-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784058#comment-17784058 ] ASF subversion and git services commented on NIFI-12261: Commit

Re: [PR] NIFI-12261 Add Schema Reference Reader and Writer Services [nifi]

2023-11-08 Thread via GitHub
bbende merged PR #7991: URL: https://github.com/apache/nifi/pull/7991 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] NIFI-12192 Add Codecov Reporting with JaCoCo [nifi]

2023-11-08 Thread via GitHub
exceptionfactory commented on PR #7995: URL: https://github.com/apache/nifi/pull/7995#issuecomment-1801898174 > As discussed elsewhere, would it be sensible to update the `integration-tests-ci` profile to skip all `ITRedisDistributedMapCacheClientService` ITs as part of this PR - more of

Re: [PR] NIFI-12192 Add Codecov Reporting with JaCoCo [nifi]

2023-11-08 Thread via GitHub
exceptionfactory commented on code in PR #7995: URL: https://github.com/apache/nifi/pull/7995#discussion_r1386624819 ## .github/workflows/ci-workflow.yml: ## @@ -160,22 +159,19 @@ jobs: ${{ env.MAVEN_COMPILE_COMMAND }} - name: Maven Verify env: -

Re: [PR] NIFI-12192 Add Codecov Reporting with JaCoCo [nifi]

2023-11-08 Thread via GitHub
exceptionfactory commented on code in PR #7995: URL: https://github.com/apache/nifi/pull/7995#discussion_r1386620132 ## pom.xml: ## @@ -29,6 +29,7 @@ nifi-framework-api nifi-server-api nifi-bootstrap +nifi-code-coverage Review Comment:

[jira] [Commented] (NIFI-12333) Env and System variable overrides for MiNiFi and MiNiFi bootstrap properties

2023-11-08 Thread Ferenc Erdei (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784008#comment-17784008 ] Ferenc Erdei commented on NIFI-12333: - PR: https://github.com/apache/nifi/pull/7997 > Env and System

[PR] NIFI-12333 MiNiFi property override through env and system variables [nifi]

2023-11-08 Thread via GitHub
ferencerdei opened a new pull request, #7997: URL: https://github.com/apache/nifi/pull/7997 # Summary [NIFI-12333](https://issues.apache.org/jira/browse/NIFI-12333) # Tracking Please complete the following tracking

Re: [PR] MINIFICPP-1415 Pass references to onTrigger and onSchedule instead of… [nifi-minifi-cpp]

2023-11-08 Thread via GitHub
adamdebreceni commented on code in PR #1693: URL: https://github.com/apache/nifi-minifi-cpp/pull/1693#discussion_r1386514328 ## extensions/http-curl/processors/InvokeHTTP.cpp: ## @@ -93,6 +64,9 @@ void setupClientTransferEncoding(extensions::curl::HTTPClient& client, bool use_

Re: [PR] MINIFICPP-1415 Pass references to onTrigger and onSchedule instead of… [nifi-minifi-cpp]

2023-11-08 Thread via GitHub
adamdebreceni commented on code in PR #1693: URL: https://github.com/apache/nifi-minifi-cpp/pull/1693#discussion_r1386506918 ## extensions/http-curl/processors/InvokeHTTP.cpp: ## @@ -93,6 +64,9 @@ void setupClientTransferEncoding(extensions::curl::HTTPClient& client, bool use_

[jira] [Commented] (NIFI-11439) Add Storage API URL to GCS Processors

2023-11-08 Thread mayki (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784000#comment-17784000 ] mayki commented on NIFI-11439: -- Hello, For the parameter Storage-api-url, it seems neither 

Re: [PR] MINIFICPP-2217 - Implement jolt processor shift operation [nifi-minifi-cpp]

2023-11-08 Thread via GitHub
adamdebreceni commented on code in PR #1692: URL: https://github.com/apache/nifi-minifi-cpp/pull/1692#discussion_r1386425162 ## extensions/standard-processors/processors/JoltTransformJSON.h: ## @@ -0,0 +1,104 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] NIFI-12192 Add Codecov Reporting with JaCoCo [nifi]

2023-11-08 Thread via GitHub
ChrisSamo632 commented on PR #7995: URL: https://github.com/apache/nifi/pull/7995#issuecomment-1801443699 @exceptionfactory thanks for the update, the code coverage will help improve confidence in the code base going forward. I've suggeted a couple of options to think about for

Re: [PR] NIFI-12192 Add Codecov Reporting with JaCoCo [nifi]

2023-11-08 Thread via GitHub
ChrisSamo632 commented on code in PR #7995: URL: https://github.com/apache/nifi/pull/7995#discussion_r1386290226 ## pom.xml: ## @@ -29,6 +29,7 @@ nifi-framework-api nifi-server-api nifi-bootstrap +nifi-code-coverage Review Comment: I think

Re: [PR] NIFI-12192 Add Codecov Reporting with JaCoCo [nifi]

2023-11-08 Thread via GitHub
ChrisSamo632 commented on code in PR #7995: URL: https://github.com/apache/nifi/pull/7995#discussion_r1386277971 ## .github/workflows/ci-workflow.yml: ## @@ -160,22 +159,19 @@ jobs: ${{ env.MAVEN_COMPILE_COMMAND }} - name: Maven Verify env: -

[jira] [Created] (NIFI-12333) Env and System variable overrides for MiNiFi and MiNiFi bootstrap properties

2023-11-08 Thread Ferenc Erdei (Jira)
Ferenc Erdei created NIFI-12333: --- Summary: Env and System variable overrides for MiNiFi and MiNiFi bootstrap properties Key: NIFI-12333 URL: https://issues.apache.org/jira/browse/NIFI-12333 Project: