[jira] [Commented] (PHOENIX-7059) De-duplicate HBase string contants in Phoenix

2023-12-01 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792322#comment-17792322 ] Istvan Toth commented on PHOENIX-7059: -- [https://github.com/apache/phoenix/blob/b2

[jira] [Commented] (PHOENIX-4555) Only mark view as updatable if rows cannot overlap with other updatable views

2023-12-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792285#comment-17792285 ] ASF GitHub Bot commented on PHOENIX-4555: - virajjasani commented on PR #1704: U

Re: [PR] PHOENIX-4555 Only mark view as updatable if rows cannot overlap with other updatable views [phoenix]

2023-12-01 Thread via GitHub
virajjasani commented on PR #1704: URL: https://github.com/apache/phoenix/pull/1704#issuecomment-1836989580 We are really close now :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (PHOENIX-7040) Support TTL for views using the new column TTL in SYSTEM.CATALOG

2023-12-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792283#comment-17792283 ] ASF GitHub Bot commented on PHOENIX-7040: - jpisaac merged PR #1710: URL: https:

Re: [PR] PHOENIX-7040 : Support TTL for views using the new column TTL in SYSTEM.CATALOG [phoenix]

2023-12-01 Thread via GitHub
jpisaac merged PR #1710: URL: https://github.com/apache/phoenix/pull/1710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apa

[jira] [Commented] (PHOENIX-7059) De-duplicate HBase string contants in Phoenix

2023-12-01 Thread Jing Yu (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792239#comment-17792239 ] Jing Yu commented on PHOENIX-7059: -- [~stoty]  What kind of string contants do we mean

[jira] [Commented] (PHOENIX-7040) Support TTL for views using the new column TTL in SYSTEM.CATALOG

2023-12-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792236#comment-17792236 ] ASF GitHub Bot commented on PHOENIX-7040: - jpisaac commented on code in PR #171

Re: [PR] PHOENIX-7040 : Support TTL for views using the new column TTL in SYSTEM.CATALOG [phoenix]

2023-12-01 Thread via GitHub
jpisaac commented on code in PR #1710: URL: https://github.com/apache/phoenix/pull/1710#discussion_r1412637207 ## phoenix-core/src/main/java/org/apache/phoenix/util/ViewUtil.java: ## @@ -132,20 +134,35 @@ public static Pair, List> findAllDescendantViews( List legitimat

[jira] [Commented] (PHOENIX-7041) Populate ROW_KEY_PREFIX column when creating views

2023-12-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792207#comment-17792207 ] ASF GitHub Bot commented on PHOENIX-7041: - jpisaac merged PR #1733: URL: https:

Re: [PR] PHOENIX-7041 Populate ROW_KEY_PREFIX column when creating views [phoenix]

2023-12-01 Thread via GitHub
jpisaac merged PR #1733: URL: https://github.com/apache/phoenix/pull/1733 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apa

[jira] [Commented] (PHOENIX-6909) Create client/server metrics for phoenix Paging feature.

2023-12-01 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792143#comment-17792143 ] Istvan Toth commented on PHOENIX-6909: -- Do we need this ticket open, [~tkhurana] 

[jira] [Commented] (PHOENIX-6053) Use shaded hadoop-client and hbase-shaded-client in phoenix-client

2023-12-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792082#comment-17792082 ] ASF GitHub Bot commented on PHOENIX-6053: - Aarchy commented on code in PR #1690

Re: [PR] PHOENIX-6053 Use shaded hadoop-client and hbase-shaded-client in phoenix-client [phoenix]

2023-12-01 Thread via GitHub
Aarchy commented on code in PR #1690: URL: https://github.com/apache/phoenix/pull/1690#discussion_r1412174495 ## phoenix-coprocessors/src/main/java/org/apache/phoenix/coprocessor/UncoveredIndexRegionScanner.java: ## @@ -321,10 +324,12 @@ private boolean getNextCoveredIndexRow(Li

[jira] [Commented] (PHOENIX-6053) Use shaded hadoop-client and hbase-shaded-client in phoenix-client

2023-12-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792077#comment-17792077 ] ASF GitHub Bot commented on PHOENIX-6053: - richardantal commented on code in PR

Re: [PR] PHOENIX-6053 Use shaded hadoop-client and hbase-shaded-client in phoenix-client [phoenix]

2023-12-01 Thread via GitHub
richardantal commented on code in PR #1690: URL: https://github.com/apache/phoenix/pull/1690#discussion_r1412158994 ## phoenix-coprocessors/src/main/java/org/apache/phoenix/coprocessor/UncoveredIndexRegionScanner.java: ## @@ -321,10 +324,12 @@ private boolean getNextCoveredIndex

[jira] [Commented] (PHOENIX-6053) Use shaded hadoop-client and hbase-shaded-client in phoenix-client

2023-12-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792075#comment-17792075 ] ASF GitHub Bot commented on PHOENIX-6053: - richardantal commented on code in PR

Re: [PR] PHOENIX-6053 Use shaded hadoop-client and hbase-shaded-client in phoenix-client [phoenix]

2023-12-01 Thread via GitHub
richardantal commented on code in PR #1690: URL: https://github.com/apache/phoenix/pull/1690#discussion_r141215 ## phoenix-tests/pom.xml: ## @@ -0,0 +1,423 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; +

[jira] [Commented] (PHOENIX-6053) Use shaded hadoop-client and hbase-shaded-client in phoenix-client

2023-12-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792069#comment-17792069 ] ASF GitHub Bot commented on PHOENIX-6053: - Aarchy commented on PR #1690: URL: h

Re: [PR] PHOENIX-6053 Use shaded hadoop-client and hbase-shaded-client in phoenix-client [phoenix]

2023-12-01 Thread via GitHub
Aarchy commented on PR #1690: URL: https://github.com/apache/phoenix/pull/1690#issuecomment-1836180370 @richardantal updated the PR based on your comments. Thank you for taking time to review this huge patch, really appreciate the feedback! -- This is an automated message from the Apac

Re: [PR] PHOENIX-6053 Use shaded hadoop-client and hbase-shaded-client in phoenix-client [phoenix]

2023-12-01 Thread via GitHub
Aarchy commented on code in PR #1690: URL: https://github.com/apache/phoenix/pull/1690#discussion_r1412139181 ## phoenix-tests/pom.xml: ## @@ -0,0 +1,423 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:sc

[jira] [Commented] (PHOENIX-6053) Use shaded hadoop-client and hbase-shaded-client in phoenix-client

2023-12-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792067#comment-17792067 ] ASF GitHub Bot commented on PHOENIX-6053: - Aarchy commented on code in PR #1690

[jira] [Commented] (PHOENIX-6053) Use shaded hadoop-client and hbase-shaded-client in phoenix-client

2023-12-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792039#comment-17792039 ] ASF GitHub Bot commented on PHOENIX-6053: - Aarchy commented on code in PR #1690

Re: [PR] PHOENIX-6053 Use shaded hadoop-client and hbase-shaded-client in phoenix-client [phoenix]

2023-12-01 Thread via GitHub
Aarchy commented on code in PR #1690: URL: https://github.com/apache/phoenix/pull/1690#discussion_r1412066252 ## phoenix-tests/src/test/java/org/apache/phoenix/util/ServerUtilTest.java: ## @@ -45,13 +45,13 @@ public class ServerUtilTest { @Test public void testIsHbaseN

[jira] [Commented] (PHOENIX-7129) Use Newer Maven for Connectors ASF CI

2023-12-01 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792022#comment-17792022 ] Istvan Toth commented on PHOENIX-7129: -- We should really just upgrade Yetus, but t

[jira] [Commented] (PHOENIX-6053) Use shaded hadoop-client and hbase-shaded-client in phoenix-client

2023-12-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792018#comment-17792018 ] ASF GitHub Bot commented on PHOENIX-6053: - stoty commented on code in PR #1690:

Re: [PR] PHOENIX-6053 Use shaded hadoop-client and hbase-shaded-client in phoenix-client [phoenix]

2023-12-01 Thread via GitHub
stoty commented on code in PR #1690: URL: https://github.com/apache/phoenix/pull/1690#discussion_r1412016418 ## phoenix-tests/src/test/java/org/apache/phoenix/util/ServerUtilTest.java: ## @@ -45,13 +45,13 @@ public class ServerUtilTest { @Test public void testIsHbaseNa

Re: [PR] PHOENIX-6053 Use shaded hadoop-client and hbase-shaded-client in phoenix-client [phoenix]

2023-12-01 Thread via GitHub
stoty commented on code in PR #1690: URL: https://github.com/apache/phoenix/pull/1690#discussion_r1412014916 ## phoenix-core/src/main/java/org/apache/phoenix/util/MetaDataUtil.java: ## @@ -1078,16 +1031,17 @@ public static int getAutoPartitionColIndex(PTable parentTable) {

[jira] [Commented] (PHOENIX-6053) Use shaded hadoop-client and hbase-shaded-client in phoenix-client

2023-12-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792016#comment-17792016 ] ASF GitHub Bot commented on PHOENIX-6053: - stoty commented on code in PR #1690:

[jira] [Commented] (PHOENIX-7129) Use Newer Maven for Connectors ASF CI

2023-12-01 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792013#comment-17792013 ] Istvan Toth commented on PHOENIX-7129: -- I mixed them up. We don't have ASF CI for

[jira] [Commented] (PHOENIX-6053) Use shaded hadoop-client and hbase-shaded-client in phoenix-client

2023-12-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792004#comment-17792004 ] ASF GitHub Bot commented on PHOENIX-6053: - Aarchy commented on code in PR #1690

Re: [PR] PHOENIX-6053 Use shaded hadoop-client and hbase-shaded-client in phoenix-client [phoenix]

2023-12-01 Thread via GitHub
Aarchy commented on code in PR #1690: URL: https://github.com/apache/phoenix/pull/1690#discussion_r1411943717 ## phoenix-coprocessors/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReaderGenerator.java: ## @@ -210,7 +210,7 @@ public InternalScanner preComp

[jira] [Commented] (PHOENIX-6053) Use shaded hadoop-client and hbase-shaded-client in phoenix-client

2023-12-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792000#comment-17792000 ] ASF GitHub Bot commented on PHOENIX-6053: - Aarchy commented on code in PR #1690

Re: [PR] PHOENIX-6053 Use shaded hadoop-client and hbase-shaded-client in phoenix-client [phoenix]

2023-12-01 Thread via GitHub
Aarchy commented on code in PR #1690: URL: https://github.com/apache/phoenix/pull/1690#discussion_r1411933226 ## phoenix-core/src/main/java/org/apache/phoenix/util/MetaDataUtil.java: ## @@ -1078,16 +1031,17 @@ public static int getAutoPartitionColIndex(PTable parentTable) {

[jira] [Commented] (PHOENIX-6053) Use shaded hadoop-client and hbase-shaded-client in phoenix-client

2023-12-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791998#comment-17791998 ] ASF GitHub Bot commented on PHOENIX-6053: - Aarchy commented on code in PR #1690

Re: [PR] PHOENIX-6053 Use shaded hadoop-client and hbase-shaded-client in phoenix-client [phoenix]

2023-12-01 Thread via GitHub
Aarchy commented on code in PR #1690: URL: https://github.com/apache/phoenix/pull/1690#discussion_r1411929749 ## phoenix-core/src/main/java/org/apache/phoenix/util/MetaDataUtil.java: ## @@ -1078,16 +1031,17 @@ public static int getAutoPartitionColIndex(PTable parentTable) {

[jira] [Commented] (PHOENIX-7133) Update maven plugin versions in connectors

2023-12-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791982#comment-17791982 ] ASF GitHub Bot commented on PHOENIX-7133: - stoty commented on PR #123: URL: ht

Re: [PR] PHOENIX-7133 Update maven plugin versions in connectors [phoenix-connectors]

2023-12-01 Thread via GitHub
stoty commented on PR #123: URL: https://github.com/apache/phoenix-connectors/pull/123#issuecomment-1835809143 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 25s | D

[jira] [Commented] (PHOENIX-7133) Update maven plugin versions in connectors

2023-12-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791981#comment-17791981 ] ASF GitHub Bot commented on PHOENIX-7133: - stoty opened a new pull request, #12

[PR] PHOENIX-7133 Update maven plugin versions in connectors [phoenix-connectors]

2023-12-01 Thread via GitHub
stoty opened a new pull request, #123: URL: https://github.com/apache/phoenix-connectors/pull/123 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[jira] [Commented] (PHOENIX-6053) Use shaded hadoop-client and hbase-shaded-client in phoenix-client

2023-12-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791979#comment-17791979 ] ASF GitHub Bot commented on PHOENIX-6053: - Aarchy commented on code in PR #1690

Re: [PR] PHOENIX-6053 Use shaded hadoop-client and hbase-shaded-client in phoenix-client [phoenix]

2023-12-01 Thread via GitHub
Aarchy commented on code in PR #1690: URL: https://github.com/apache/phoenix/pull/1690#discussion_r1411862826 ## phoenix-core/src/main/java/org/apache/phoenix/coprocessorclient/UngroupedAggregateRegionObserverConstants.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Sof

[jira] [Commented] (PHOENIX-6053) Use shaded hadoop-client and hbase-shaded-client in phoenix-client

2023-12-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791976#comment-17791976 ] ASF GitHub Bot commented on PHOENIX-6053: - Aarchy commented on code in PR #1690

Re: [PR] PHOENIX-6053 Use shaded hadoop-client and hbase-shaded-client in phoenix-client [phoenix]

2023-12-01 Thread via GitHub
Aarchy commented on code in PR #1690: URL: https://github.com/apache/phoenix/pull/1690#discussion_r1411855582 ## phoenix-coprocessors/src/main/java/org/apache/phoenix/coprocessor/UncoveredIndexRegionScanner.java: ## @@ -321,10 +324,12 @@ private boolean getNextCoveredIndexRow(Li

Re: [PR] PHOENIX-6053 Use shaded hadoop-client and hbase-shaded-client in phoenix-client [phoenix]

2023-12-01 Thread via GitHub
richardantal commented on code in PR #1690: URL: https://github.com/apache/phoenix/pull/1690#discussion_r1407653400 ## phoenix-coprocessors/pom.xml: ## @@ -0,0 +1,199 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; +

[jira] [Commented] (PHOENIX-6053) Use shaded hadoop-client and hbase-shaded-client in phoenix-client

2023-12-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791961#comment-17791961 ] ASF GitHub Bot commented on PHOENIX-6053: - richardantal commented on code in PR