rahil-c commented on code in PR #1862:
URL: https://github.com/apache/polaris/pull/1862#discussion_r2181920269
##
plugins/spark/v3.5/integration/build.gradle.kts:
##
@@ -60,12 +60,51 @@ dependencies {
exclude("org.apache.logging.log4j", "log4j-core")
exclude("org.slf4j
rahil-c commented on code in PR #1862:
URL: https://github.com/apache/polaris/pull/1862#discussion_r2181894203
##
plugins/spark/v3.5/integration/build.gradle.kts:
##
@@ -60,12 +60,51 @@ dependencies {
exclude("org.apache.logging.log4j", "log4j-core")
exclude("org.slf4j
ajantha-bhat commented on PR #1984:
URL: https://github.com/apache/polaris/pull/1984#issuecomment-3030866719
> @ajantha-bhat we don't need a ASF infra ticket here. I have permission to
do it 😄
I thought it is a standard workflow as we raised ASF tickets in Apache
Iceberg.
I have
MonkeyCanCode commented on PR #1986:
URL: https://github.com/apache/polaris/pull/1986#issuecomment-3030853669
> @HonahX
>
> > Do we want to add python format check to gradle because we want format
issue stops CI before enterring the real test cases?
>
> I'd like to have the sam
jbonofre commented on code in PR #1984:
URL: https://github.com/apache/polaris/pull/1984#discussion_r2181807898
##
.asf.yaml:
##
@@ -77,6 +77,14 @@ github:
- nssalian
- adnanhemani
- HotSushi
+- rahil-c
Review Comment:
We don't need a ASF infra ticket (I h
jbonofre commented on PR #1984:
URL: https://github.com/apache/polaris/pull/1984#issuecomment-3030841647
@ajantha-bhat we don't need a ASF infra ticket here. I have permission to do
it 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
ajantha-bhat commented on code in PR #1984:
URL: https://github.com/apache/polaris/pull/1984#discussion_r2181758952
##
.asf.yaml:
##
@@ -77,6 +77,14 @@ github:
- nssalian
- adnanhemani
- HotSushi
+- rahil-c
Review Comment:
Sure. I will start the mailing li
eric-maynard closed issue #1866: CLI doc is incorrect for the update subcommand
URL: https://github.com/apache/polaris/issues/1866
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
eric-maynard closed issue #1864: No mention of --repair in CLI docs
URL: https://github.com/apache/polaris/issues/1864
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
eric-maynard merged PR #1993:
URL: https://github.com/apache/polaris/pull/1993
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polari
eric-maynard commented on PR #1986:
URL: https://github.com/apache/polaris/pull/1986#issuecomment-3030383506
@HonahX
> Do we want to add python format check to gradle because we want format
issue stops CI before enterring the real test cases?
I'd like to have the same setup as
rahil-c commented on code in PR #1862:
URL: https://github.com/apache/polaris/pull/1862#discussion_r2180606729
##
plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/SparkCatalog.java:
##
@@ -270,18 +286,24 @@ public Map loadNamespaceMetadata(String[]
namespace)
rahil-c commented on code in PR #1862:
URL: https://github.com/apache/polaris/pull/1862#discussion_r2180905640
##
plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/SparkCatalog.java:
##
@@ -270,18 +286,24 @@ public Map loadNamespaceMetadata(String[]
namespace)
flyrain commented on code in PR #1991:
URL: https://github.com/apache/polaris/pull/1991#discussion_r2181201662
##
plugins/spark/v3.5/spark-bundle/build.gradle.kts:
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor lice
HonahX commented on PR #1986:
URL: https://github.com/apache/polaris/pull/1986#issuecomment-3029755625
Thanks for the example PR! Sorry I missed the discussion earlier, just want
to understand more about the motivation behind this. Do we want to add python
format check to gradle because we
eric-maynard merged PR #1992:
URL: https://github.com/apache/polaris/pull/1992
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polari
eric-maynard commented on PR #1992:
URL: https://github.com/apache/polaris/pull/1992#issuecomment-3029647160
In #1929 it was pointed out that the example in the Polaris docs suggests
that users can provide a client ID during principal creation:
. . .
This PR attempts to fix
eric-maynard merged PR #1994:
URL: https://github.com/apache/polaris/pull/1994
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polari
eric-maynard commented on code in PR #1986:
URL: https://github.com/apache/polaris/pull/1986#discussion_r2181144572
##
build.gradle.kts:
##
@@ -238,3 +239,22 @@ changelog {
)
version.set(provider { project.version.toString() })
}
+
+python {
+ installVirtualenv = true
+
eric-maynard commented on code in PR #1986:
URL: https://github.com/apache/polaris/pull/1986#discussion_r2181145194
##
build.gradle.kts:
##
@@ -238,3 +239,22 @@ changelog {
)
version.set(provider { project.version.toString() })
}
+
+python {
+ installVirtualenv = true
+
poojanilangekar commented on PR #1925:
URL: https://github.com/apache/polaris/pull/1925#issuecomment-3029581970
I've updated the PR by renaming the AuthenticationType to IMPLICIT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
jparkzz commented on PR #1996:
URL: https://github.com/apache/polaris/pull/1996#issuecomment-3029552758
> @jparkzz thanks for the PR. There appear to be a conflict with the test
yaml.
Thank you! This has been resolved.
--
This is an automated message from the Apache Git Service.
To
MonkeyCanCode commented on PR #1996:
URL: https://github.com/apache/polaris/pull/1996#issuecomment-3029498521
@jparkzz thanks for the PR. There appear to be a conflict with the test yaml.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
MonkeyCanCode commented on PR #1954:
URL: https://github.com/apache/polaris/pull/1954#issuecomment-3029482370
> > > @MonkeyCanCode what exactly did you run here btw? I still see
conflicts/changes on #1912 after running `ruff check client/python/cli --fix`
there.
> >
> >
> > For t
jparkzz opened a new pull request, #1996:
URL: https://github.com/apache/polaris/pull/1996
## Description
This PR refactors the configuration approach for deployment and
relationalJdbc settings from Secret to maintain consistency with the existing
storage.secret configuratio
dimas-b commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2181065072
##
runtime/service/src/main/java/org/apache/polaris/service/quarkus/config/QuarkusProducers.java:
##
@@ -170,6 +175,34 @@ public UserSecretsManagerFactory userSecretsMa
rahil-c commented on code in PR #1862:
URL: https://github.com/apache/polaris/pull/1862#discussion_r2181026612
##
plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/utils/HudiCatalogUtils.java:
##
@@ -0,0 +1,220 @@
+/*
+ * Licensed to the Apache Software Foundation
rahil-c commented on code in PR #1862:
URL: https://github.com/apache/polaris/pull/1862#discussion_r2181022029
##
plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/utils/PolarisCatalogUtils.java:
##
@@ -87,6 +119,32 @@ public static Table loadSparkTable(GenericTabl
dimas-b commented on code in PR #1959:
URL: https://github.com/apache/polaris/pull/1959#discussion_r2180992752
##
polaris-core/src/test/java/org/apache/polaris/service/storage/PolarisConfigurationStoreTest.java:
##
@@ -186,4 +185,104 @@ public void testEntityOverrides() {
A
gh-yzou commented on code in PR #1991:
URL: https://github.com/apache/polaris/pull/1991#discussion_r2180983046
##
plugins/spark/v3.5/spark-bundle/build.gradle.kts:
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor lice
gh-yzou commented on code in PR #1991:
URL: https://github.com/apache/polaris/pull/1991#discussion_r2180983046
##
plugins/spark/v3.5/spark-bundle/build.gradle.kts:
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor lice
gh-yzou commented on code in PR #1991:
URL: https://github.com/apache/polaris/pull/1991#discussion_r2180977824
##
plugins/spark/v3.5/spark-bundle/build.gradle.kts:
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor lice
poojanilangekar commented on code in PR #1959:
URL: https://github.com/apache/polaris/pull/1959#discussion_r218097
##
polaris-core/src/test/java/org/apache/polaris/service/storage/PolarisConfigurationStoreTest.java:
##
@@ -186,4 +185,104 @@ public void testEntityOverrides()
gh-yzou commented on code in PR #1991:
URL: https://github.com/apache/polaris/pull/1991#discussion_r2180977824
##
plugins/spark/v3.5/spark-bundle/build.gradle.kts:
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor lice
MonkeyCanCode opened a new pull request, #1995:
URL: https://github.com/apache/polaris/pull/1995
The current `Makefile` and `README.md` is asking users to setup needed
python environment (either virtual or the one installed on the OS) then
installed the needed dependencies. I think it makes
RussellSpitzer commented on code in PR #1991:
URL: https://github.com/apache/polaris/pull/1991#discussion_r2180970326
##
plugins/spark/v3.5/spark-bundle/build.gradle.kts:
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribut
dimas-b commented on PR #1959:
URL: https://github.com/apache/polaris/pull/1959#issuecomment-3029321823
@eric-maynard : since you had previous comments, PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
dimas-b commented on code in PR #1991:
URL: https://github.com/apache/polaris/pull/1991#discussion_r2180967992
##
plugins/spark/v3.5/spark-bundle/build.gradle.kts:
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor lice
dimas-b commented on code in PR #1991:
URL: https://github.com/apache/polaris/pull/1991#discussion_r2180537545
##
plugins/spark/v3.5/spark-bundle/build.gradle.kts:
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor lice
dimas-b commented on code in PR #1991:
URL: https://github.com/apache/polaris/pull/1991#discussion_r2180966589
##
plugins/spark/v3.5/spark-bundle/build.gradle.kts:
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor lice
poojanilangekar commented on code in PR #1959:
URL: https://github.com/apache/polaris/pull/1959#discussion_r2180963673
##
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java:
##
@@ -41,6 +43,7 @@ public abstract class PolarisConfiguration {
p
gh-yzou commented on code in PR #1991:
URL: https://github.com/apache/polaris/pull/1991#discussion_r2180963410
##
plugins/spark/README.md:
##
@@ -66,23 +63,31 @@ bin/spark-shell \
--conf spark.sql.sources.useV1SourceList=''
```
-Assume the path to the built Spark client jar
gh-yzou commented on code in PR #1991:
URL: https://github.com/apache/polaris/pull/1991#discussion_r2180962266
##
plugins/spark/v3.5/spark-bundle/build.gradle.kts:
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor lice
dimas-b commented on code in PR #1959:
URL: https://github.com/apache/polaris/pull/1959#discussion_r2180955338
##
polaris-core/src/test/java/org/apache/polaris/service/storage/PolarisConfigurationStoreTest.java:
##
@@ -186,4 +185,104 @@ public void testEntityOverrides() {
A
flyrain merged PR #1985:
URL: https://github.com/apache/polaris/pull/1985
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apa
rahil-c commented on code in PR #1862:
URL: https://github.com/apache/polaris/pull/1862#discussion_r2180940060
##
plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/utils/PolarisCatalogUtils.java:
##
@@ -64,9 +92,13 @@ public static boolean
isTableWithSparkManagedL
poojanilangekar commented on code in PR #1959:
URL: https://github.com/apache/polaris/pull/1959#discussion_r2180933308
##
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java:
##
@@ -41,6 +43,7 @@ public abstract class PolarisConfiguration {
p
poojanilangekar commented on code in PR #1959:
URL: https://github.com/apache/polaris/pull/1959#discussion_r2180786523
##
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java:
##
@@ -41,6 +43,7 @@ public abstract class PolarisConfiguration {
p
dimas-b commented on issue #1390:
URL: https://github.com/apache/polaris/issues/1390#issuecomment-3029238874
Note: The `POST` verb on the namespace properties
[endpoint](https://github.com/apache/iceberg/blob/8ed1c216503b7193924ca57bd2694025660ac02c/open-api/rest-catalog-open-api.yaml#L448)
flyrain commented on issue #1782:
URL: https://github.com/apache/polaris/issues/1782#issuecomment-3029225373
Closed as it was fixed. Thanks everyone for the contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
flyrain closed issue #1782: Admin Tool commands with Postgres not working as
expected
URL: https://github.com/apache/polaris/issues/1782
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
MonkeyCanCode commented on issue #1866:
URL: https://github.com/apache/polaris/issues/1866#issuecomment-3029219688
PR: https://github.com/apache/polaris/pull/1994
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
MonkeyCanCode opened a new pull request, #1994:
URL: https://github.com/apache/polaris/pull/1994
PR for https://github.com/apache/polaris/issues/1866
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dimas-b commented on code in PR #1989:
URL: https://github.com/apache/polaris/pull/1989#discussion_r2180905497
##
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##
@@ -756,7 +756,7 @@ public boolean removeProperties(Namespace namespa
rahil-c commented on code in PR #1862:
URL: https://github.com/apache/polaris/pull/1862#discussion_r2180905640
##
plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/SparkCatalog.java:
##
@@ -270,18 +286,24 @@ public Map loadNamespaceMetadata(String[]
namespace)
MonkeyCanCode commented on issue #1782:
URL: https://github.com/apache/polaris/issues/1782#issuecomment-3029208072
This is fixed in https://github.com/apache/polaris/pull/1977. Please
validate
@flyrain
--
This is an automated message from the Apache Git Service.
To respond to the
MonkeyCanCode commented on issue #1864:
URL: https://github.com/apache/polaris/issues/1864#issuecomment-3029200379
Sample PR: https://github.com/apache/polaris/pull/1993/files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
MonkeyCanCode opened a new pull request, #1993:
URL: https://github.com/apache/polaris/pull/1993
PR for https://github.com/apache/polaris/issues/1864
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
rahil-c commented on code in PR #1862:
URL: https://github.com/apache/polaris/pull/1862#discussion_r2180872859
##
plugins/spark/v3.5/spark/build.gradle.kts:
##
@@ -46,6 +46,47 @@ dependencies {
// TODO: extract a polaris-rest module as a thin layer for
// client to depend
dimas-b commented on code in PR #1959:
URL: https://github.com/apache/polaris/pull/1959#discussion_r2180866062
##
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java:
##
@@ -41,6 +43,7 @@ public abstract class PolarisConfiguration {
public fi
rahil-c commented on code in PR #1862:
URL: https://github.com/apache/polaris/pull/1862#discussion_r2180781727
##
plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/PolarisSparkCatalog.java:
##
@@ -68,7 +68,7 @@ public Table loadTable(Identifier identifier) throws
poojanilangekar commented on code in PR #1959:
URL: https://github.com/apache/polaris/pull/1959#discussion_r2180786523
##
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java:
##
@@ -41,6 +43,7 @@ public abstract class PolarisConfiguration {
p
rahil-c commented on code in PR #1862:
URL: https://github.com/apache/polaris/pull/1862#discussion_r2180773174
##
plugins/spark/v3.5/integration/src/intTest/java/org/apache/polaris/spark/quarkus/it/SparkHudiIT.java:
##
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Software Fo
poojanilangekar commented on code in PR #1959:
URL: https://github.com/apache/polaris/pull/1959#discussion_r2180748325
##
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java:
##
@@ -41,6 +43,7 @@ public abstract class PolarisConfiguration {
p
travis-bowen commented on PR #1920:
URL: https://github.com/apache/polaris/pull/1920#issuecomment-3028917540
Custom producer worked, so closing this out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
flyrain commented on code in PR #1985:
URL: https://github.com/apache/polaris/pull/1985#discussion_r2180729901
##
integration-tests/src/main/java/org/apache/polaris/service/it/ext/SparkSessionBuilder.java:
##
@@ -0,0 +1,197 @@
+/*
+ * Licensed to the Apache Software Foundation (
gh-yzou commented on code in PR #1985:
URL: https://github.com/apache/polaris/pull/1985#discussion_r2180721471
##
integration-tests/src/main/java/org/apache/polaris/service/it/ext/SparkSessionBuilder.java:
##
@@ -0,0 +1,197 @@
+/*
+ * Licensed to the Apache Software Foundation (
travis-bowen closed pull request #1920: Allow for Customization of Polaris
Authorizer
URL: https://github.com/apache/polaris/pull/1920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
dimas-b commented on code in PR #1959:
URL: https://github.com/apache/polaris/pull/1959#discussion_r218043
##
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java:
##
@@ -41,6 +43,7 @@ public abstract class PolarisConfiguration {
public fi
flyrain commented on code in PR #1984:
URL: https://github.com/apache/polaris/pull/1984#discussion_r2180666086
##
.asf.yaml:
##
@@ -77,6 +77,14 @@ github:
- nssalian
- adnanhemani
- HotSushi
+- rahil-c
Review Comment:
Hi @ajantha-bhat, that's a great idea.
poojanilangekar commented on code in PR #1959:
URL: https://github.com/apache/polaris/pull/1959#discussion_r2180661035
##
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java:
##
@@ -41,6 +43,7 @@ public abstract class PolarisConfiguration {
p
flyrain commented on code in PR #1985:
URL: https://github.com/apache/polaris/pull/1985#discussion_r2180656914
##
integration-tests/src/main/java/org/apache/polaris/service/it/ext/SparkSessionBuilder.java:
##
@@ -0,0 +1,197 @@
+/*
+ * Licensed to the Apache Software Foundation (
flyrain commented on code in PR #1985:
URL: https://github.com/apache/polaris/pull/1985#discussion_r2180657680
##
integration-tests/src/main/java/org/apache/polaris/service/it/ext/SparkSessionBuilder.java:
##
@@ -0,0 +1,293 @@
+/*
+ * Licensed to the Apache Software Foundation (
flyrain commented on code in PR #1985:
URL: https://github.com/apache/polaris/pull/1985#discussion_r2180649265
##
integration-tests/src/main/java/org/apache/polaris/service/it/ext/SparkSessionBuilder.java:
##
@@ -0,0 +1,197 @@
+/*
+ * Licensed to the Apache Software Foundation (
dimas-b merged PR #1987:
URL: https://github.com/apache/polaris/pull/1987
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apa
dimas-b commented on code in PR #1959:
URL: https://github.com/apache/polaris/pull/1959#discussion_r2180644252
##
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java:
##
@@ -41,6 +43,7 @@ public abstract class PolarisConfiguration {
public fi
rahil-c commented on code in PR #1862:
URL: https://github.com/apache/polaris/pull/1862#discussion_r2180607213
##
plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/utils/HudiCatalogUtils.java:
##
@@ -0,0 +1,220 @@
+/*
+ * Licensed to the Apache Software Foundation
rahil-c commented on code in PR #1862:
URL: https://github.com/apache/polaris/pull/1862#discussion_r2180606729
##
plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/SparkCatalog.java:
##
@@ -270,18 +286,24 @@ public Map loadNamespaceMetadata(String[]
namespace)
rahil-c commented on code in PR #1862:
URL: https://github.com/apache/polaris/pull/1862#discussion_r2180589724
##
plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/SparkCatalog.java:
##
@@ -156,15 +160,23 @@ public Table createTable(
throw new UnsupportedO
rahil-c commented on code in PR #1862:
URL: https://github.com/apache/polaris/pull/1862#discussion_r2180581211
##
plugins/spark/v3.5/spark/build.gradle.kts:
##
@@ -46,6 +46,47 @@ dependencies {
// TODO: extract a polaris-rest module as a thin layer for
// client to depend
gh-yzou commented on code in PR #1985:
URL: https://github.com/apache/polaris/pull/1985#discussion_r2180569609
##
integration-tests/src/main/java/org/apache/polaris/service/it/ext/SparkSessionBuilder.java:
##
@@ -0,0 +1,197 @@
+/*
+ * Licensed to the Apache Software Foundation (
eric-maynard commented on issue #1929:
URL: https://github.com/apache/polaris/issues/1929#issuecomment-3028621374
(aside: filed #1992 to improve the example linked above)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
dimas-b commented on issue #1929:
URL: https://github.com/apache/polaris/issues/1929#issuecomment-3028612819
This feels like a discussion of how the Authorization side of Polaris works
(handling Principals managed by Polaris).
The Client ID here basically refers to the Client Credenti
eric-maynard opened a new pull request, #1992:
URL: https://github.com/apache/polaris/pull/1992
In #1929 it was pointed out that the example in the Polaris docs suggests
that users can provide a client ID during principal creation. This PR attempts
to fix this by adding an explicit example
gh-yzou commented on PR #1991:
URL: https://github.com/apache/polaris/pull/1991#issuecomment-3028594358
@snazy it doesn't change the sourceJar, however, it updates the generated
.pom file to only dependent on the bundle jar, and it stop publishes the
original sourceJar, where we only got th
flyrain closed issue #214: [FEATURE REQUEST] Add Support for S3A prefix
URL: https://github.com/apache/polaris/issues/214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
flyrain commented on issue #214:
URL: https://github.com/apache/polaris/issues/214#issuecomment-3028593295
Closed. Thanks everyone for the contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
dimas-b commented on code in PR #1991:
URL: https://github.com/apache/polaris/pull/1991#discussion_r2180532332
##
plugins/spark/v3.5/spark-bundle/build.gradle.kts:
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor lice
eric-maynard commented on issue #1929:
URL: https://github.com/apache/polaris/issues/1929#issuecomment-3028570798
Hey @fivetran-arunsuri, sorry I missed your previous comment.
From the service POV, I'm not sure whether or not creating a principal with
specific _secret_ is something we
rahil-c commented on code in PR #1862:
URL: https://github.com/apache/polaris/pull/1862#discussion_r2180532157
##
plugins/spark/v3.5/spark/build.gradle.kts:
##
@@ -46,6 +46,47 @@ dependencies {
// TODO: extract a polaris-rest module as a thin layer for
// client to depend
rahil-c commented on code in PR #1862:
URL: https://github.com/apache/polaris/pull/1862#discussion_r2180532656
##
plugins/spark/v3.5/spark/build.gradle.kts:
##
@@ -46,6 +46,47 @@ dependencies {
// TODO: extract a polaris-rest module as a thin layer for
// client to depend
snazy commented on PR #1991:
URL: https://github.com/apache/polaris/pull/1991#issuecomment-3028544693
> We were not able to reuse the current shadowJar plugin for maven publish
due to the shadowJar plugin replaces the regular source Jar with the shadowJar
during maven publish.
I doub
dimas-b commented on code in PR #1990:
URL: https://github.com/apache/polaris/pull/1990#discussion_r2180503669
##
polaris-core/src/main/java/org/apache/polaris/core/entity/EntityConverter.java:
##
@@ -0,0 +1,177 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
gh-yzou commented on code in PR #1985:
URL: https://github.com/apache/polaris/pull/1985#discussion_r2180502686
##
integration-tests/src/main/java/org/apache/polaris/service/it/ext/SparkSessionBuilder.java:
##
@@ -0,0 +1,293 @@
+/*
+ * Licensed to the Apache Software Foundation (
gh-yzou opened a new pull request, #1991:
URL: https://github.com/apache/polaris/pull/1991
We were not able to reuse the current shadowJar plugin for maven publish due
to the shadowJar plugin replaces the regular source Jar with the shadowJar
during maven publish.
Here, we added a se
eric-maynard commented on code in PR #1982:
URL: https://github.com/apache/polaris/pull/1982#discussion_r2180479342
##
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/DatasourceOperations.java:
##
@@ -82,45 +82,37 @@ DatabaseType getDatab
dimas-b commented on code in PR #1988:
URL: https://github.com/apache/polaris/pull/1988#discussion_r2180488604
##
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcMetaStoreManagerFactory.java:
##
@@ -100,17 +99,18 @@ private void initi
eric-maynard commented on code in PR #1990:
URL: https://github.com/apache/polaris/pull/1990#discussion_r2180488238
##
service/common/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java:
##
@@ -981,7 +983,7 @@ public PrincipalWithCredentials
createPrincipal(
rahil-c commented on code in PR #1862:
URL: https://github.com/apache/polaris/pull/1862#discussion_r2180486136
##
plugins/spark/v3.5/integration/src/intTest/resources/logback.xml:
##
@@ -32,6 +32,9 @@ out the configuration if you would like ot see all spark
debug log during the
rahil-c commented on code in PR #1862:
URL: https://github.com/apache/polaris/pull/1862#discussion_r2180424419
##
plugins/spark/v3.5/integration/build.gradle.kts:
##
@@ -60,12 +60,51 @@ dependencies {
exclude("org.apache.logging.log4j", "log4j-core")
exclude("org.slf4j
1 - 100 of 124 matches
Mail list logo
