Re: [PR] Add Events for Generic Table APIs [polaris]

2025-09-03 Thread via GitHub
adnanhemani commented on code in PR #2481: URL: https://github.com/apache/polaris/pull/2481#discussion_r2320263473 ## runtime/service/src/main/java/org/apache/polaris/service/catalog/generic/CatalogGenericTableEventServiceDelegator.java: ## @@ -78,7 +108,19 @@ public Response lo

Re: [I] Support MySQL as Metastore [polaris]

2025-09-03 Thread via GitHub
dimas-b commented on issue #2491: URL: https://github.com/apache/polaris/issues/2491#issuecomment-3250870849 EclipseLink + MySQL always required a custom build to pull in the JDBC driver. Current JDBC support provides the driver(s) with Apache Polaris binaries. With that in mind MySQ

Re: [PR] Add Events for Policy Service APIs [polaris]

2025-09-03 Thread via GitHub
adnanhemani commented on code in PR #2479: URL: https://github.com/apache/polaris/pull/2479#discussion_r2320199144 ## runtime/service/src/main/java/org/apache/polaris/service/events/CatalogPolicyServiceEvents.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Service: Add location tests for views [polaris]

2025-09-03 Thread via GitHub
dimas-b commented on code in PR #2496: URL: https://github.com/apache/polaris/pull/2496#discussion_r2320254395 ## runtime/service/src/test/java/org/apache/polaris/service/catalog/iceberg/IcebergAllowedLocationTest.java: ## @@ -131,6 +153,154 @@ private static TestServices getTes

[PR] Update actions/stale digest to 3a9db7e [polaris]

2025-09-03 Thread via GitHub
renovate-bot opened a new pull request, #2499: URL: https://github.com/apache/polaris/pull/2499 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | actions/stale | action | digest | `8f717f0` -> `3a9db7e` | --- > [!WARNIN

[PR] Update docker.io/jaegertracing/all-in-one Docker tag to v1.73.0 [polaris]

2025-09-03 Thread via GitHub
renovate-bot opened a new pull request, #2500: URL: https://github.com/apache/polaris/pull/2500 This PR contains the following updates: | Package | Update | Change | |---|---|---| | docker.io/jaegertracing/all-in-one | minor | `1.72.0` -> `1.73.0` | --- > [!WARNING]

Re: [PR] Fix failing CI [polaris]

2025-09-03 Thread via GitHub
singhpk234 merged PR #2498: URL: https://github.com/apache/polaris/pull/2498 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.

[PR] Fix failing CI [polaris]

2025-09-03 Thread via GitHub
adnanhemani opened a new pull request, #2498: URL: https://github.com/apache/polaris/pull/2498 Consecutive merges, where one class was moved in the first PR but was not reflected in the second PR. -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] AWS CloudWatch Event Sink Implementation [polaris]

2025-09-03 Thread via GitHub
adnanhemani commented on PR #1965: URL: https://github.com/apache/polaris/pull/1965#issuecomment-3250363882 Working on rebase for this - seems like it is now failing in main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Add Polaris Events to Persistence [polaris]

2025-09-03 Thread via GitHub
flyrain merged PR #1844: URL: https://github.com/apache/polaris/pull/1844 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apa

[PR] fix(deps): update dependency org.testcontainers:localstack to v1.21.3 [polaris]

2025-09-03 Thread via GitHub
renovate-bot opened a new pull request, #2497: URL: https://github.com/apache/polaris/pull/2497 This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [org.testcontainers:localstack](https://java.testcontainers.org) ([source](https://

Re: [PR] AWS CloudWatch Event Sink Implementation [polaris]

2025-09-03 Thread via GitHub
singhpk234 merged PR #1965: URL: https://github.com/apache/polaris/pull/1965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.

Re: [PR] Core: Prevent AIOOBE for negative policy codes in PredefinedPolicyType [polaris]

2025-09-03 Thread via GitHub
flyrain commented on code in PR #2486: URL: https://github.com/apache/polaris/pull/2486#discussion_r2319855085 ## polaris-core/src/test/java/org/apache/polaris/core/policy/PolicyTypeTest.java: ## @@ -53,4 +56,14 @@ public void testPredefinedPolicyTypeFromName(int code, String n

Re: [PR] Core: Prevent AIOOBE for negative policy codes in PredefinedPolicyType [polaris]

2025-09-03 Thread via GitHub
singhpk234 commented on code in PR #2486: URL: https://github.com/apache/polaris/pull/2486#discussion_r2319729182 ## polaris-core/src/test/java/org/apache/polaris/core/policy/PolicyTypeTest.java: ## @@ -53,4 +56,14 @@ public void testPredefinedPolicyTypeFromName(int code, Strin

Re: [PR] perf(refactor): optimizing JdbcBasePersistenceImpl.listEntities [polaris]

2025-09-03 Thread via GitHub
dimas-b merged PR #2465: URL: https://github.com/apache/polaris/pull/2465 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apa

Re: [PR] Add location tests for views [polaris]

2025-09-03 Thread via GitHub
Copilot commented on code in PR #2496: URL: https://github.com/apache/polaris/pull/2496#discussion_r2319678474 ## runtime/service/src/test/java/org/apache/polaris/service/catalog/iceberg/IcebergAllowedLocationTest.java: ## @@ -131,6 +153,154 @@ private static TestServices getTes

[PR] Add location tests for views [polaris]

2025-09-03 Thread via GitHub
flyrain opened a new pull request, #2496: URL: https://github.com/apache/polaris/pull/2496 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] AWS CloudWatch Event Sink Implementation [polaris]

2025-09-03 Thread via GitHub
eric-maynard commented on code in PR #1965: URL: https://github.com/apache/polaris/pull/1965#discussion_r2319531405 ## runtime/service/src/main/java/org/apache/polaris/service/events/jsonEventListener/aws/cloudwatch/AwsCloudWatchEventListener.java: ## @@ -0,0 +1,158 @@ +/* + * L

[PR] Update dependency io.netty:netty-codec-http2 to v4.2.5.Final [polaris]

2025-09-03 Thread via GitHub
renovate-bot opened a new pull request, #2495: URL: https://github.com/apache/polaris/pull/2495 This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [io.netty:netty-codec-http2](https://netty.io/) ([source](https://redirect.github.c

Re: [PR] feat(idgen): Start Implementation of NoSQL with the ID Generation Framework [polaris]

2025-09-03 Thread via GitHub
dimas-b merged PR #2131: URL: https://github.com/apache/polaris/pull/2131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apa

Re: [PR] feat(idgen): Start Implementation of NoSQL with the ID Generation Framework [polaris]

2025-09-03 Thread via GitHub
dimas-b commented on code in PR #2131: URL: https://github.com/apache/polaris/pull/2131#discussion_r2319439782 ## persistence/nosql/idgen/spi/build.gradle.kts: ## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[I] Review node ID handling in IdGenerator [polaris]

2025-09-03 Thread via GitHub
dimas-b opened a new issue, #2494: URL: https://github.com/apache/polaris/issues/2494 ### Is your feature request related to a problem? Please describe. Following up on discussions in #2131, the handling of node IDs in the Id Generator SPI and impl. needs to be reviewed. Specif

Re: [PR] feat(idgen): Start Implementation of NoSQL with the ID Generation Framework [polaris]

2025-09-03 Thread via GitHub
dimas-b commented on code in PR #2131: URL: https://github.com/apache/polaris/pull/2131#discussion_r2319418594 ## persistence/nosql/idgen/spi/build.gradle.kts: ## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[I] Support `PASSTHROUGH` as an `authenticationType` for external catalogs [polaris]

2025-09-03 Thread via GitHub
creepysta opened a new issue, #2493: URL: https://github.com/apache/polaris/issues/2493 ### Is your feature request related to a problem? Please describe. Currenly the only types of `authenticationType` supported for `ICEBERG_REST` is - `BEARER` - `OAUTH` The problem is

Re: [PR] Add subtype-check to PolarisEntity subclass ctors [polaris]

2025-09-03 Thread via GitHub
adutra commented on code in PR #2492: URL: https://github.com/apache/polaris/pull/2492#discussion_r2318391343 ## runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java: ## @@ -2412,9 +2417,9 @@ private boolean sendNotificationForTableLike(

Re: [PR] Add subtype-check to PolarisEntity subclass ctors [polaris]

2025-09-03 Thread via GitHub
XN137 commented on code in PR #2492: URL: https://github.com/apache/polaris/pull/2492#discussion_r2318358984 ## runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java: ## @@ -2412,9 +2417,9 @@ private boolean sendNotificationForTableLike(

Re: [PR] Add subtype-check to PolarisEntity subclass ctors [polaris]

2025-09-03 Thread via GitHub
adutra commented on code in PR #2492: URL: https://github.com/apache/polaris/pull/2492#discussion_r2318333106 ## runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java: ## @@ -2412,9 +2417,9 @@ private boolean sendNotificationForTableLike(

[PR] Core: Prevent AIOOBE for negative codes in PolarisEntityType, PolarisPrivilege, ReturnStatus [polaris]

2025-09-03 Thread via GitHub
HonahX opened a new pull request, #2490: URL: https://github.com/apache/polaris/pull/2490 In https://github.com/apache/polaris/pull/2486, we add the correct index boundary check for PredefinedPolicyType, this PR fix the similar issue for `PolarisPrivilege`, `ReturnStatus` and `PolarisEn

Re: [I] Unstructured data support in Apache Polaris [polaris]

2025-09-03 Thread via GitHub
jbonofre commented on issue #586: URL: https://github.com/apache/polaris/issues/586#issuecomment-3240835953 This is part of the Polaris Table Source proposal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] AWS CloudWatch Event Sink Implementation [polaris]

2025-09-03 Thread via GitHub
adnanhemani commented on code in PR #1965: URL: https://github.com/apache/polaris/pull/1965#discussion_r2317524583 ## site/content/in-dev/unreleased/configuration.md: ## @@ -78,46 +78,51 @@ read-only mode, as Polaris only reads the configuration file once, at startup. ## Pol

Re: [PR] Add Events for Iceberg REST APIs [polaris]

2025-09-03 Thread via GitHub
adutra commented on code in PR #2480: URL: https://github.com/apache/polaris/pull/2480#discussion_r2318253912 ## runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogAdapter.java: ## @@ -777,8 +777,8 @@ public Response sendNotification(

Re: [PR] Add Events for Iceberg REST APIs [polaris]

2025-09-03 Thread via GitHub
adutra commented on code in PR #2480: URL: https://github.com/apache/polaris/pull/2480#discussion_r2318196871 ## runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergRestCatalogEventServiceDelegator.java: ## @@ -307,7 +519,18 @@ public Response sendNot

Re: [PR] Add Events for Policy Service APIs [polaris]

2025-09-03 Thread via GitHub
adutra commented on code in PR #2479: URL: https://github.com/apache/polaris/pull/2479#discussion_r2318169836 ## runtime/service/src/main/java/org/apache/polaris/service/events/CatalogPolicyServiceEvents.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] Add Events for Generic Table APIs [polaris]

2025-09-03 Thread via GitHub
adutra commented on code in PR #2481: URL: https://github.com/apache/polaris/pull/2481#discussion_r2318180283 ## runtime/service/src/main/java/org/apache/polaris/service/catalog/generic/CatalogGenericTableEventServiceDelegator.java: ## @@ -78,7 +108,19 @@ public Response loadGen

Re: [PR] Add Events for Policy Service APIs [polaris]

2025-09-03 Thread via GitHub
adutra commented on code in PR #2479: URL: https://github.com/apache/polaris/pull/2479#discussion_r2318169836 ## runtime/service/src/main/java/org/apache/polaris/service/events/CatalogPolicyServiceEvents.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] Add Polaris Events to Persistence [polaris]

2025-09-03 Thread via GitHub
flyrain commented on code in PR #1844: URL: https://github.com/apache/polaris/pull/1844#discussion_r2316632142 ## runtime/service/src/main/java/org/apache/polaris/service/events/listeners/InMemoryBufferPolarisPersistenceEventListener.java: ## @@ -0,0 +1,195 @@ +/* + * Licensed t

Re: [PR] Add Events for PolarisServiceImpl APIs [polaris]

2025-09-03 Thread via GitHub
adutra commented on code in PR #2482: URL: https://github.com/apache/polaris/pull/2482#discussion_r2318124540 ## runtime/service/src/main/java/org/apache/polaris/service/admin/PolarisServiceImpl.java: ## @@ -630,6 +635,12 @@ public Response listCatalogRolesForPrincipalRole(

Re: [PR] Add Events for PolarisServiceImpl APIs [polaris]

2025-09-03 Thread via GitHub
adutra commented on code in PR #2482: URL: https://github.com/apache/polaris/pull/2482#discussion_r2318110814 ## runtime/service/src/main/java/org/apache/polaris/service/events/CatalogsServiceEvents.java: ## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] perf(refactor): optimizing JdbcBasePersistenceImpl.listEntities [polaris]

2025-09-03 Thread via GitHub
binarycat0 commented on code in PR #2465: URL: https://github.com/apache/polaris/pull/2465#discussion_r2314017635 ## persistence/relational-jdbc/src/main/resources/h2/schema-v2.sql: ## @@ -63,6 +63,7 @@ CREATE INDEX IF NOT EXISTS idx_locations ON entities(realm_id, catalog_id,

Re: [PR] AWS CloudWatch Event Sink Implementation [polaris]

2025-09-03 Thread via GitHub
singhpk234 commented on code in PR #1965: URL: https://github.com/apache/polaris/pull/1965#discussion_r2316552637 ## runtime/service/src/main/java/org/apache/polaris/service/events/jsonEventListener/aws/cloudwatch/AwsCloudWatchEventListener.java: ## @@ -0,0 +1,158 @@ +/* + * Lic

Re: [PR] Use INT4 type alias for CockroachDB JDBC compatibility [polaris]

2025-09-03 Thread via GitHub
dimas-b commented on PR #2485: URL: https://github.com/apache/polaris/pull/2485#issuecomment-324656 If we do not add tests in this PR, let's keep #2464 open until we have end-to-end tests. -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] perf(refactor): optimizing JdbcBasePersistenceImpl.listEntities [polaris]

2025-09-03 Thread via GitHub
dimas-b commented on PR #2465: URL: https://github.com/apache/polaris/pull/2465#issuecomment-3245776381 Thanks for the perf. update @binarycat0 ! However, the execution times are too small and the sample size is small too (I'm afraid) so the perf. numbers are not decisive, IMHO :sweat_smile

Re: [PR] perf(refactor): optimizing JdbcBasePersistenceImpl.listEntities [polaris]

2025-09-03 Thread via GitHub
binarycat0 commented on code in PR #2465: URL: https://github.com/apache/polaris/pull/2465#discussion_r2316339759 ## persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/models/EntityNameLookupRecordConverter.java: ## @@ -0,0 +1,46 @@ +/* + *

[PR] Add subtype-check to PolarisEntity subclass ctors [polaris]

2025-09-03 Thread via GitHub
XN137 opened a new pull request, #2492: URL: https://github.com/apache/polaris/pull/2492 this is a follow-up to ac31963c9eef12b2e1a1c7615d950939caf3b200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] AWS CloudWatch Event Sink Implementation [polaris]

2025-09-03 Thread via GitHub
singhpk234 commented on code in PR #1965: URL: https://github.com/apache/polaris/pull/1965#discussion_r2316557508 ## runtime/service/src/main/java/org/apache/polaris/service/events/jsonEventListener/aws/cloudwatch/AwsCloudWatchEventListener.java: ## @@ -0,0 +1,158 @@ +/* + * Lic

Re: [PR] Core: Prevent AIOOBE for negative policy codes in PredefinedPolicyType [polaris]

2025-09-03 Thread via GitHub
adutra commented on code in PR #2486: URL: https://github.com/apache/polaris/pull/2486#discussion_r2315391400 ## polaris-core/src/test/java/org/apache/polaris/core/policy/PredefinedPolicyTypesTest.java: ## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Add Events for Iceberg REST APIs [polaris]

2025-09-03 Thread via GitHub
adnanhemani commented on code in PR #2480: URL: https://github.com/apache/polaris/pull/2480#discussion_r2317632595 ## runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogAdapter.java: ## @@ -777,8 +777,8 @@ public Response sendNotification(

Re: [PR] Add subtype-check to PolarisEntity subclass ctors [polaris]

2025-09-02 Thread via GitHub
XN137 commented on code in PR #2492: URL: https://github.com/apache/polaris/pull/2492#discussion_r2317960806 ## runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java: ## @@ -1182,8 +1184,11 @@ private void validateNoLocationO

Re: [PR] Add subtype-check to PolarisEntity subclass ctors [polaris]

2025-09-02 Thread via GitHub
XN137 commented on code in PR #2492: URL: https://github.com/apache/polaris/pull/2492#discussion_r2317959516 ## runtime/service/src/main/java/org/apache/polaris/service/catalog/generic/PolarisGenericTableCatalog.java: ## @@ -95,9 +95,7 @@ public GenericTableEntity createGenericT

Re: [PR] Add type-check to PolarisEntity subclass ctors [polaris]

2025-09-02 Thread via GitHub
dimas-b merged PR #2302: URL: https://github.com/apache/polaris/pull/2302 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apa

[I] Support MySQL as Metastore [polaris]

2025-09-02 Thread via GitHub
Y-Wakuta opened a new issue, #2491: URL: https://github.com/apache/polaris/issues/2491 ### Is your feature request related to a problem? Please describe. Currently, Polaris only supports PostgreSQL and H2 databases for its relational JDBC persistence layer. Many organizations have exi

Re: [PR] Add Polaris Events to Persistence [polaris]

2025-09-02 Thread via GitHub
flyrain commented on code in PR #1844: URL: https://github.com/apache/polaris/pull/1844#discussion_r2316566538 ## runtime/service/src/main/java/org/apache/polaris/service/events/listeners/InMemoryBufferPolarisPersistenceEventListener.java: ## @@ -0,0 +1,195 @@ +/* + * Licensed t

Re: [PR] AWS CloudWatch Event Sink Implementation [polaris]

2025-09-02 Thread via GitHub
singhpk234 commented on code in PR #1965: URL: https://github.com/apache/polaris/pull/1965#discussion_r2316566596 ## runtime/service/src/main/java/org/apache/polaris/service/quarkus/events/jsonEventListener/aws/cloudwatch/QuarkusAwsCloudWatchConfiguration.java: ## @@ -0,0 +1,99

Re: [PR] Core: Prevent AIOOBE for negative codes in PolarisEntityType, PolarisPrivilege, ReturnStatus [polaris]

2025-09-02 Thread via GitHub
flyrain merged PR #2490: URL: https://github.com/apache/polaris/pull/2490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apa

Re: [PR] Add Polaris Delegation Service for Processing DROP TABLE WITH PURGE [polaris]

2025-09-02 Thread via GitHub
github-actions[bot] commented on PR #2193: URL: https://github.com/apache/polaris/pull/2193#issuecomment-3243562619 This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. -- This is an automated message from the

Re: [PR] AWS CloudWatch Event Sink Implementation [polaris]

2025-09-02 Thread via GitHub
adnanhemani commented on code in PR #1965: URL: https://github.com/apache/polaris/pull/1965#discussion_r2317521622 ## runtime/service/src/main/java/org/apache/polaris/service/events/jsonEventListener/aws/cloudwatch/AwsCloudWatchEventListener.java: ## @@ -0,0 +1,185 @@ +/* + * Li

[I] Rethink design of persistence.relational.jdbc.models.Converter [polaris]

2025-09-02 Thread via GitHub
binarycat0 opened a new issue, #2487: URL: https://github.com/apache/polaris/issues/2487 The `Converter` interface is a bit strange indeed. The method above is a pure converter utility, but this one looks like it's meant to convert the object's _internal state_ to some external representati

[PR] Core: Prevent AIOOBE for negative policy codes in PredefinedPolicyType [polaris]

2025-09-02 Thread via GitHub
flyrain opened a new pull request, #2486: URL: https://github.com/apache/polaris/pull/2486 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] Introducing: polaris.readiness.ignore-offending-properties [polaris]

2025-09-02 Thread via GitHub
dimas-b commented on code in PR #2472: URL: https://github.com/apache/polaris/pull/2472#discussion_r2316263598 ## runtime/service/src/main/java/org/apache/polaris/service/config/ProductionReadinessChecks.java: ## @@ -74,7 +74,14 @@ public void warnOnFailedChecks( @Observe

Re: [PR] Add Polaris Events to Persistence [polaris]

2025-09-02 Thread via GitHub
adnanhemani commented on code in PR #1844: URL: https://github.com/apache/polaris/pull/1844#discussion_r2317517543 ## runtime/service/src/main/java/org/apache/polaris/service/events/listeners/InMemoryBufferPolarisPersistenceEventListener.java: ## @@ -0,0 +1,195 @@ +/* + * Licens

Re: [PR] Add Polaris Events to Persistence [polaris]

2025-09-02 Thread via GitHub
adnanhemani commented on PR #1844: URL: https://github.com/apache/polaris/pull/1844#issuecomment-3247446182 Hi @adutra @jbonofre @flyrain - please take a look at this PR again, I've updated it to resolve the merge conflicts as well as minor enhancements requested by Yufei! -- This is an

Re: [PR] AWS CloudWatch Event Sink Implementation [polaris]

2025-09-02 Thread via GitHub
adnanhemani commented on code in PR #1965: URL: https://github.com/apache/polaris/pull/1965#discussion_r2317550009 ## runtime/service/src/main/java/org/apache/polaris/service/events/jsonEventListener/PropertyMapEventListener.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apac

Re: [PR] Fix CI [polaris]

2025-09-02 Thread via GitHub
dimas-b merged PR #2489: URL: https://github.com/apache/polaris/pull/2489 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apa

Re: [PR] AWS CloudWatch Event Sink Implementation [polaris]

2025-09-02 Thread via GitHub
adnanhemani commented on code in PR #1965: URL: https://github.com/apache/polaris/pull/1965#discussion_r2317520750 ## runtime/service/src/main/java/org/apache/polaris/service/events/jsonEventListener/aws/cloudwatch/AwsCloudWatchEventListener.java: ## @@ -0,0 +1,185 @@ +/* + * Li

Re: [PR] AWS CloudWatch Event Sink Implementation [polaris]

2025-09-02 Thread via GitHub
adnanhemani commented on code in PR #1965: URL: https://github.com/apache/polaris/pull/1965#discussion_r2317519853 ## runtime/service/src/main/java/org/apache/polaris/service/events/jsonEventListener/aws/cloudwatch/AwsCloudWatchEventListener.java: ## @@ -0,0 +1,185 @@ +/* + * Li

Re: [PR] Core: Prevent AIOOBE for negative codes in PolarisEntityType, PolarisPrivilege, ReturnStatus [polaris]

2025-09-02 Thread via GitHub
dimas-b commented on PR #2490: URL: https://github.com/apache/polaris/pull/2490#issuecomment-3246773415 This PR probably needs rebasing on top of #2489 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[PR] Use local diagnostics in TransactionWorkspaceMetaStoreManager [polaris]

2025-09-02 Thread via GitHub
dimas-b opened a new pull request, #2489: URL: https://github.com/apache/polaris/pull/2489 Fix undetected merge conflict after #2197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Feature: Expose resetCredentials via a new reset api to allow root user to reset credentials for an existing principal with custom values [polaris]

2025-09-02 Thread via GitHub
dimas-b merged PR #2197: URL: https://github.com/apache/polaris/pull/2197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apa

Re: [PR] Remove PolarisCallContext.getDiagServices [polaris]

2025-09-02 Thread via GitHub
dimas-b merged PR #2415: URL: https://github.com/apache/polaris/pull/2415 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apa

Re: [PR] perf(refactor): optimizing JdbcBasePersistenceImpl.listEntities [polaris]

2025-09-02 Thread via GitHub
dimas-b commented on PR #2465: URL: https://github.com/apache/polaris/pull/2465#issuecomment-3246126674 @binarycat0 : please remove `Database Index Optimization: Covering index enables index-only scans` from the description as the new index is no longer in this PR :sweat_smile: -- This

Re: [PR] perf(refactor): optimizing JdbcBasePersistenceImpl.listEntities [polaris]

2025-09-02 Thread via GitHub
binarycat0 commented on PR #2465: URL: https://github.com/apache/polaris/pull/2465#issuecomment-3244547998 # Test ENV OS: `24.5.0 Darwin Kernel Version 24.5.0: Tue Apr 22 19:53:27 PDT 2025; root:xnu-11417.121.6~2/RELEASE_ARM64_T6041 arm64` Storage: Docker image `postgres:17` Rows in

[I] After `dev` ML discussion need to decide do we need to add an extra Persistance DB Index or not [polaris]

2025-09-02 Thread via GitHub
binarycat0 opened a new issue, #2488: URL: https://github.com/apache/polaris/issues/2488 Thanks for the perf. update @binarycat0 ! However, the execution times are too small and the sample size is small too (I'm afraid) so the perf. numbers are not decisive, IMHO :sweat_smile: At th

Re: [PR] AWS CloudWatch Event Sink Implementation [polaris]

2025-09-02 Thread via GitHub
singhpk234 commented on code in PR #1965: URL: https://github.com/apache/polaris/pull/1965#discussion_r2316585400 ## runtime/service/src/main/java/org/apache/polaris/service/events/jsonEventListener/aws/cloudwatch/AwsCloudWatchEventListener.java: ## @@ -0,0 +1,185 @@ +/* + * Lic

Re: [PR] feat(idgen): Start Implementation of NoSQL with the ID Generation Framework [polaris]

2025-09-02 Thread via GitHub
dimas-b commented on PR #2131: URL: https://github.com/apache/polaris/pull/2131#issuecomment-3245993163 Resolved conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] Core: Prevent AIOOBE for negative policy codes in PredefinedPolicyType [polaris]

2025-09-02 Thread via GitHub
HonahX commented on code in PR #2486: URL: https://github.com/apache/polaris/pull/2486#discussion_r2316244541 ## polaris-core/src/test/java/org/apache/polaris/core/policy/PredefinedPolicyTypesTest.java: ## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] perf(refactor): optimizing JdbcBasePersistenceImpl.listEntities [polaris]

2025-09-02 Thread via GitHub
binarycat0 commented on code in PR #2465: URL: https://github.com/apache/polaris/pull/2465#discussion_r2316068252 ## persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/models/EntityNameLookupRecordConverter.java: ## @@ -0,0 +1,46 @@ +/* + *

Re: [PR] perf(refactor): optimizing JdbcBasePersistenceImpl.listEntities [polaris]

2025-09-02 Thread via GitHub
binarycat0 commented on code in PR #2465: URL: https://github.com/apache/polaris/pull/2465#discussion_r2316161199 ## persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/models/EntityNameLookupRecordConverter.java: ## @@ -0,0 +1,46 @@ +/* + *

Re: [PR] perf(refactor): optimizing JdbcBasePersistenceImpl.listEntities [polaris]

2025-09-02 Thread via GitHub
binarycat0 commented on code in PR #2465: URL: https://github.com/apache/polaris/pull/2465#discussion_r2316003751 ## persistence/relational-jdbc/src/main/resources/h2/schema-v2.sql: ## @@ -63,6 +63,8 @@ CREATE INDEX IF NOT EXISTS idx_locations ON entities(realm_id, catalog_id,

Re: [PR] perf(refactor): optimizing JdbcBasePersistenceImpl.listEntities [polaris]

2025-09-02 Thread via GitHub
adutra commented on code in PR #2465: URL: https://github.com/apache/polaris/pull/2465#discussion_r2315911100 ## persistence/relational-jdbc/src/main/resources/h2/schema-v2.sql: ## @@ -63,6 +63,8 @@ CREATE INDEX IF NOT EXISTS idx_locations ON entities(realm_id, catalog_id, loca

Re: [PR] perf(refactor): optimizing JdbcBasePersistenceImpl.listEntities [polaris]

2025-09-02 Thread via GitHub
binarycat0 commented on code in PR #2465: URL: https://github.com/apache/polaris/pull/2465#discussion_r2315603528 ## persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcBasePersistenceImpl.java: ## @@ -421,38 +422,13 @@ public List looku

Re: [PR] perf(refactor): optimizing JdbcBasePersistenceImpl.listEntities [polaris]

2025-09-02 Thread via GitHub
binarycat0 commented on code in PR #2465: URL: https://github.com/apache/polaris/pull/2465#discussion_r2315534589 ## persistence/relational-jdbc/src/main/resources/postgres/schema-v2.sql: ## @@ -60,6 +60,7 @@ CREATE INDEX IF NOT EXISTS idx_entities ON entities (realm_id, catalo

Re: [PR] perf(refactor): optimizing JdbcBasePersistenceImpl.listEntities [polaris]

2025-09-02 Thread via GitHub
binarycat0 commented on code in PR #2465: URL: https://github.com/apache/polaris/pull/2465#discussion_r2315532492 ## persistence/relational-jdbc/src/main/resources/h2/schema-v2.sql: ## @@ -63,6 +63,9 @@ CREATE INDEX IF NOT EXISTS idx_locations ON entities(realm_id, catalog_id,

Re: [PR] perf(refactor): optimizing JdbcBasePersistenceImpl.listEntities [polaris]

2025-09-02 Thread via GitHub
XN137 commented on code in PR #2465: URL: https://github.com/apache/polaris/pull/2465#discussion_r2315490475 ## persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcBasePersistenceImpl.java: ## @@ -421,38 +422,13 @@ public List lookupEnti

Re: [PR] Use INT4 type alias for CockroachDB JDBC compatibility [polaris]

2025-09-02 Thread via GitHub
sathesuraj commented on code in PR #2485: URL: https://github.com/apache/polaris/pull/2485#discussion_r2315462056 ## persistence/relational-jdbc/src/main/resources/postgres/schema-v1.sql: ## @@ -21,7 +21,7 @@ SET search_path TO POLARIS_SCHEMA; CREATE TABLE IF NOT EXISTS versi

Re: [PR] Introducing: polaris.readiness.ignore-offending-properties [polaris]

2025-09-02 Thread via GitHub
fivetran-kostaszoumpatianos commented on PR #2472: URL: https://github.com/apache/polaris/pull/2472#issuecomment-3244414039 @dimas-b @adutra @eric-maynard could you maybe take a look at this PR? thanks! -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] Use INT4 type alias for CockroachDB JDBC compatibility [polaris]

2025-09-01 Thread via GitHub
singhpk234 commented on code in PR #2485: URL: https://github.com/apache/polaris/pull/2485#discussion_r2314833121 ## persistence/relational-jdbc/src/main/resources/postgres/schema-v1.sql: ## @@ -21,7 +21,7 @@ SET search_path TO POLARIS_SCHEMA; CREATE TABLE IF NOT EXISTS versi

Re: [PR] Support Lance format in generic table [polaris]

2025-09-01 Thread via GitHub
github-actions[bot] commented on PR #2239: URL: https://github.com/apache/polaris/pull/2239#issuecomment-3243562505 This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. -- This is an automated message from the

Re: [PR] add the schema-setup for admin tool [polaris]

2025-09-01 Thread via GitHub
github-actions[bot] commented on PR #2196: URL: https://github.com/apache/polaris/pull/2196#issuecomment-3243562584 This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. -- This is an automated message from the

Re: [PR] Feature: Expose resetCredentials via a new reset api to allow root user to reset credentials for an existing principal with custom values [polaris]

2025-09-01 Thread via GitHub
flyrain commented on PR #2197: URL: https://github.com/apache/polaris/pull/2197#issuecomment-3243331504 Thanks @fivetran-arunsuri! I'm fine with new reset endpoint for the clarity of intent from a client perspective. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Add Events for Iceberg REST APIs [polaris]

2025-09-01 Thread via GitHub
adutra commented on code in PR #2480: URL: https://github.com/apache/polaris/pull/2480#discussion_r2314233501 ## runtime/service/src/main/java/org/apache/polaris/service/events/IcebergRestCatalogEvents.java: ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software Foundation

[PR] Use INT4 type alias for CockroachDB JDBC compatibility [polaris]

2025-09-01 Thread via GitHub
sathesuraj opened a new pull request, #2485: URL: https://github.com/apache/polaris/pull/2485 Explicitly defined integer columns as INT4 in SQL script so that a CockroachDB JDBC driver correctly maps them to Java's Integer type, despite them being stored internally as INT8 in CockroachDB. T

Re: [PR] Remove CATALOG_MANAGE_CONTENT requirement from listing operations [polaris]

2025-09-01 Thread via GitHub
adutra commented on code in PR #2478: URL: https://github.com/apache/polaris/pull/2478#discussion_r2314349814 ## site/content/in-dev/unreleased/getting-started/_index.md: ## @@ -23,3 +23,101 @@ weight: 101 build: render: never --- + +# Getting Started with Apache Polaris Bi

Re: [PR] Feature: Expose resetCredentials via a new reset api to allow root user to reset credentials for an existing principal with custom values [polaris]

2025-09-01 Thread via GitHub
fivetran-arunsuri commented on PR #2197: URL: https://github.com/apache/polaris/pull/2197#issuecomment-3243030488 @flyrain Pasting what we discussed in DM around the reset vs rotate: I see your point about client_id semantics and the flexibility of reusing the rotate endpoint. That

Re: [I] A principal should be able to list the table it has access to [polaris]

2025-09-01 Thread via GitHub
adutra commented on issue #2306: URL: https://github.com/apache/polaris/issues/2306#issuecomment-3242918415 Hi @FredKhayat thanks for reporting this. First off: `CATALOG_MANAGE_CONTENT` is _not_ required for a principal to list namespaces or tables. We have tests for that; for

Re: [PR] perf(refactor): optimizing JdbcBasePersistenceImpl.listEntities [polaris]

2025-09-01 Thread via GitHub
binarycat0 commented on PR #2465: URL: https://github.com/apache/polaris/pull/2465#issuecomment-3242590768 @singhpk234 My colleagues and I conducted several different experiments and we didn't notice significant improvement on the API side. This is most likely primarily dependent on `Entity

Re: [PR] perf(refactor): optimizing JdbcBasePersistenceImpl.listEntities [polaris]

2025-09-01 Thread via GitHub
binarycat0 commented on PR #2465: URL: https://github.com/apache/polaris/pull/2465#issuecomment-3242450416 ## Test ENV Rows in total = 899040. Expected rows result = 25. ``` CREATE INDEX IF NOT EXISTS idx_entities_lookup ON entities (realm_id, catalog_id, parent_id, type_

Re: [PR] Remove commons-codec dependency [polaris]

2025-08-31 Thread via GitHub
jbonofre commented on PR #2474: URL: https://github.com/apache/polaris/pull/2474#issuecomment-3240822501 Yes, as it's still shipped in the distribution, we have to keep in the `LICENSE`. I will open another PR to simplify a bit `LICENSE`. That's not so easy to have automatic script f

[I] Simplify distribution LICENSE/NOTICE [polaris]

2025-08-31 Thread via GitHub
jbonofre opened a new issue, #2484: URL: https://github.com/apache/polaris/issues/2484 ### Is your feature request related to a problem? Please describe. Currently, Polaris distribution LICENSE and NOTICE lists all versions for dependency and put required LICENSE inline. ### De

Re: [I] License Issue - Polaris has dependency on chardet which is LGPL which makes it difficult to use inside enterprise. [polaris]

2025-08-31 Thread via GitHub
jbonofre closed issue #821: License Issue - Polaris has dependency on chardet which is LGPL which makes it difficult to use inside enterprise. URL: https://github.com/apache/polaris/issues/821 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Remove commons-codec dependency [polaris]

2025-08-31 Thread via GitHub
XN137 commented on PR #2474: URL: https://github.com/apache/polaris/pull/2474#issuecomment-3240812603 thanks for the review > I would suggest to update LICENSE to remove commons-codec mention there. i think while this PR removes a direct dependency on the library we still depen

  1   2   3   4   5   6   7   8   9   10   >