[GitHub] [solr-site] MarcusSorealheis commented on pull request #33: Remove the sticky-note that appears on first visit

2021-08-23 Thread GitBox
MarcusSorealheis commented on pull request #33: URL: https://github.com/apache/solr-site/pull/33#issuecomment-904298542 Makes total sense. Thanks for clarifying. On Mon, Aug 23, 2021 at 1:30 AM Uwe Schindler ***@***.***> wrote: > We do not need to give users a chance to opt

[GitHub] [solr] dsmiley commented on a change in pull request #265: SOLR-15590 - Startup and CoreContainer managed by Core Service

2021-08-23 Thread GitBox
dsmiley commented on a change in pull request #265: URL: https://github.com/apache/solr/pull/265#discussion_r694441386 ## File path: solr/core/src/java/org/apache/solr/servlet/CoreService.java ## @@ -0,0 +1,451 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [solr] sonatype-lift[bot] commented on a change in pull request #264: SOLR-10887: Append .xml to managed-schema file

2021-08-23 Thread GitBox
sonatype-lift[bot] commented on a change in pull request #264: URL: https://github.com/apache/solr/pull/264#discussion_r694355510 ## File path: solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java ## @@ -91,6 +95,66 @@ public void init(NamedList args) {

[GitHub] [solr] epugh commented on a change in pull request #264: SOLR-10887: Append .xml to managed-schema file

2021-08-23 Thread GitBox
epugh commented on a change in pull request #264: URL: https://github.com/apache/solr/pull/264#discussion_r694349334 ## File path: solr/core/src/java/org/apache/solr/schema/SchemaManager.java ## @@ -428,17 +428,22 @@ private ManagedIndexSchema getFreshManagedSchema(SolrCore

[GitHub] [solr] sonatype-lift[bot] commented on a change in pull request #264: SOLR-10887: Append .xml to managed-schema file

2021-08-23 Thread GitBox
sonatype-lift[bot] commented on a change in pull request #264: URL: https://github.com/apache/solr/pull/264#discussion_r694349095 ## File path: solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java ## @@ -91,6 +92,66 @@ public void init(NamedList args) {

[GitHub] [solr] dsmiley commented on pull request #264: SOLR-10887: Append .xml to managed-schema file

2021-08-23 Thread GitBox
dsmiley commented on pull request #264: URL: https://github.com/apache/solr/pull/264#issuecomment-904158990 > do y ou think this method lookupZKManagedSchemaPath should actually return a Path class? Wish there was a single way of representing both in ZK and on the local filesystem

[GitHub] [solr] dsmiley commented on a change in pull request #264: SOLR-10887: Append .xml to managed-schema file

2021-08-23 Thread GitBox
dsmiley commented on a change in pull request #264: URL: https://github.com/apache/solr/pull/264#discussion_r694333269 ## File path: solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java ## @@ -74,12 +75,12 @@ public void init(NamedList args) {

[GitHub] [solr] dsmiley commented on a change in pull request #264: SOLR-10887: Append .xml to managed-schema file

2021-08-23 Thread GitBox
dsmiley commented on a change in pull request #264: URL: https://github.com/apache/solr/pull/264#discussion_r694332486 ## File path: solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java ## @@ -195,7 +223,16 @@ private InputStream readSchemaLocally() {

[GitHub] [solr] epugh commented on a change in pull request #264: SOLR-10887: Append .xml to managed-schema file

2021-08-23 Thread GitBox
epugh commented on a change in pull request #264: URL: https://github.com/apache/solr/pull/264#discussion_r694320618 ## File path: solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java ## @@ -91,6 +92,33 @@ public void init(NamedList args) { public

[GitHub] [solr] epugh commented on a change in pull request #264: SOLR-10887: Append .xml to managed-schema file

2021-08-23 Thread GitBox
epugh commented on a change in pull request #264: URL: https://github.com/apache/solr/pull/264#discussion_r694316602 ## File path: solr/core/src/test/org/apache/solr/handler/admin/ShowFileRequestHandlerTest.java ## @@ -84,7 +84,7 @@ public void testDirList() throws

[GitHub] [solr] dsmiley commented on a change in pull request #264: SOLR-10887: Append .xml to managed-schema file

2021-08-23 Thread GitBox
dsmiley commented on a change in pull request #264: URL: https://github.com/apache/solr/pull/264#discussion_r694305186 ## File path: solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java ## @@ -91,6 +92,33 @@ public void init(NamedList args) { public

[GitHub] [solr] dsmiley commented on a change in pull request #264: SOLR-10887: Append .xml to managed-schema file

2021-08-23 Thread GitBox
dsmiley commented on a change in pull request #264: URL: https://github.com/apache/solr/pull/264#discussion_r694311373 ## File path: solr/core/src/test/org/apache/solr/handler/admin/ShowFileRequestHandlerTest.java ## @@ -84,7 +84,7 @@ public void testDirList() throws

[jira] [Commented] (SOLR-12996) ShingleFilterFactory fillerToken parameter is not in Reference Guide

2021-08-23 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17403391#comment-17403391 ] Cassandra Targett commented on SOLR-12996: -- I was working on SOLR-12255 so decided to throw this

[jira] [Assigned] (SOLR-12996) ShingleFilterFactory fillerToken parameter is not in Reference Guide

2021-08-23 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cassandra Targett reassigned SOLR-12996: Assignee: Cassandra Targett (was: Alexandre Rafalovitch) > ShingleFilterFactory

[jira] [Assigned] (SOLR-12255) ref guide updates for new "nori" analyis module for Korean

2021-08-23 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cassandra Targett reassigned SOLR-12255: Assignee: Cassandra Targett > ref guide updates for new "nori" analyis module for

[jira] [Commented] (SOLR-12255) ref guide updates for new "nori" analyis module for Korean

2021-08-23 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17403389#comment-17403389 ] Cassandra Targett commented on SOLR-12255: -- I finally have a PR up for this. [~tomoko], perhaps

[GitHub] [solr] ctargett opened a new pull request #270: SOLR-12255: Add docs for Nori Korean tokenizer

2021-08-23 Thread GitBox
ctargett opened a new pull request #270: URL: https://github.com/apache/solr/pull/270 https://issues.apache.org/jira/browse/SOLR-12255 Adds documentation on the Nori tokenizer finally. It's mostly copied from the related Javadocs. Also fixes SOLR-12996 to add the

[GitHub] [solr-operator] gerlowskija commented on pull request #302: Allow users to take GCS-based backups

2021-08-23 Thread GitBox
gerlowskija commented on pull request #302: URL: https://github.com/apache/solr-operator/pull/302#issuecomment-904077839 Thanks for the review Houston. Just getting back from some time off now; gonna try to address your comments in the next day or two, as well as getting the docs and

[GitHub] [solr-operator] gerlowskija commented on a change in pull request #302: Allow users to take GCS-based backups

2021-08-23 Thread GitBox
gerlowskija commented on a change in pull request #302: URL: https://github.com/apache/solr-operator/pull/302#discussion_r694263848 ## File path: controllers/util/backup_util.go ## @@ -440,3 +483,13 @@ func RunExecForPod(podName string, namespace string, command []string,

[GitHub] [solr] makosten commented on a change in pull request #267: SOLR-15595: Partial results from shard queries needlessly discarded for queries without sort fields

2021-08-23 Thread GitBox
makosten commented on a change in pull request #267: URL: https://github.com/apache/solr/pull/267#discussion_r694264019 ## File path: solr/core/src/java/org/apache/solr/search/SortSpec.java ## @@ -76,6 +76,18 @@ public boolean includesScore() { return includesScore(sort);

[GitHub] [solr-operator] gerlowskija commented on a change in pull request #302: Allow users to take GCS-based backups

2021-08-23 Thread GitBox
gerlowskija commented on a change in pull request #302: URL: https://github.com/apache/solr-operator/pull/302#discussion_r694263848 ## File path: controllers/util/backup_util.go ## @@ -440,3 +483,13 @@ func RunExecForPod(podName string, namespace string, command []string,

[GitHub] [solr] makosten commented on a change in pull request #267: SOLR-15595: Partial results from shard queries needlessly discarded for queries without sort fields

2021-08-23 Thread GitBox
makosten commented on a change in pull request #267: URL: https://github.com/apache/solr/pull/267#discussion_r694263729 ## File path: solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java ## @@ -955,9 +955,12 @@ protected void mergeIds(ResponseBuilder rb,

[GitHub] [solr-operator] gerlowskija commented on a change in pull request #302: Allow users to take GCS-based backups

2021-08-23 Thread GitBox
gerlowskija commented on a change in pull request #302: URL: https://github.com/apache/solr-operator/pull/302#discussion_r694262621 ## File path: api/v1beta1/solrbackup_types.go ## @@ -38,12 +38,16 @@ type SolrBackupSpec struct { // A reference to the SolrCloud to

[GitHub] [solr] makosten commented on a change in pull request #267: SOLR-15595: Partial results from shard queries needlessly discarded for queries without sort fields

2021-08-23 Thread GitBox
makosten commented on a change in pull request #267: URL: https://github.com/apache/solr/pull/267#discussion_r694255590 ## File path: solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java ## @@ -955,9 +955,12 @@ protected void mergeIds(ResponseBuilder rb,

[GitHub] [solr-operator] HoustonPutman opened a new pull request #311: Add ability to specify ZK Config values.

2021-08-23 Thread GitBox
HoustonPutman opened a new pull request #311: URL: https://github.com/apache/solr-operator/pull/311 Resolves #290 This will allow all Config options provided in the current version of the Zookeeper Operator to be specified in the Solr Config. When we upgrade our Zookeeper Operator

[jira] [Commented] (SOLR-15089) Allow backup/restoration to Amazon's S3 blobstore

2021-08-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17403304#comment-17403304 ] ASF subversion and git services commented on SOLR-15089: Commit

[jira] [Commented] (SOLR-15585) Graceful shutdown can cause data loss with PULL replicas

2021-08-23 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17403285#comment-17403285 ] Mike Drob commented on SOLR-15585: -- Can you be more specific on the timeline events? If the PULL replica

[jira] [Commented] (SOLR-12628) Support multiple ranges in a slice

2021-08-23 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17403246#comment-17403246 ] Andrzej Bialecki commented on SOLR-12628: - Correct. However ... after dealing with

[jira] [Comment Edited] (SOLR-12628) Support multiple ranges in a slice

2021-08-23 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17403246#comment-17403246 ] Andrzej Bialecki edited comment on SOLR-12628 at 8/23/21, 3:38 PM: ---

[jira] [Commented] (SOLR-12628) Support multiple ranges in a slice

2021-08-23 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-12628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17403170#comment-17403170 ] Jan Høydahl commented on SOLR-12628: If you put a restriction that the shards to merge must be in

[jira] [Commented] (SOLR-9407) New collection action MERGESHARDS

2021-08-23 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-9407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17403152#comment-17403152 ] Andrzej Bialecki commented on SOLR-9407: [~noble.paul] I don't think there's no longer any strong

[jira] [Resolved] (SOLR-12628) Support multiple ranges in a slice

2021-08-23 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki resolved SOLR-12628. - Assignee: Andrzej Bialecki Resolution: Won't Do Initial investigation shows that

[jira] [Commented] (SOLR-15572) Improve the default Prometheus exporter config performance

2021-08-23 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17403122#comment-17403122 ] Andrzej Bialecki commented on SOLR-15572: - This is a list of tight selection expressions that

[GitHub] [solr-site] uschindler commented on pull request #33: Remove the sticky-note that appears on first visit

2021-08-23 Thread GitBox
uschindler commented on pull request #33: URL: https://github.com/apache/solr-site/pull/33#issuecomment-903555088 > We do not need to give users a chance to opt out if the need to store the cookie and identify them is a legitimate interest of ours. If it is for certain things like

[GitHub] [solr-site] MarcusSorealheis commented on pull request #33: Remove the sticky-note that appears on first visit

2021-08-23 Thread GitBox
MarcusSorealheis commented on pull request #33: URL: https://github.com/apache/solr-site/pull/33#issuecomment-903522247 This all makes sense. My understanding of GDPR was that if there was ever a cookie present on a site that is used to identify a user, not necessarily in the real world