[
https://issues.apache.org/jira/browse/SOLR-15600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17406120#comment-17406120
]
David Smiley commented on SOLR-15600:
-
I suggest a "submit a PR" type of contribution for users to
dsmiley commented on a change in pull request #36:
URL: https://github.com/apache/solr-site/pull/36#discussion_r697805365
##
File path: content/pages/community.md
##
@@ -142,5 +142,34 @@ You may alternatively choose to clone apache's git mirror
at `https://gitbox.apa
##
[
https://issues.apache.org/jira/browse/SOLR-15428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17406054#comment-17406054
]
Mark Robert Miller edited comment on SOLR-15428 at 8/27/21, 10:30 PM:
[
https://issues.apache.org/jira/browse/SOLR-15428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17406054#comment-17406054
]
Mark Robert Miller commented on SOLR-15428:
---
I didn’t look, assumed at least the logger. I just
sonatype-lift[bot] commented on a change in pull request #74:
URL: https://github.com/apache/solr/pull/74#discussion_r697733633
##
File path: solr/core/src/java/org/apache/solr/util/SolrCLI.java
##
@@ -3689,6 +3697,329 @@ public AssertionFailureException(String message) {
[
https://issues.apache.org/jira/browse/SOLR-15604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17406036#comment-17406036
]
Mike Drob commented on SOLR-15604:
--
I think the simplest way to go about this is going to be to lift and
[
https://issues.apache.org/jira/browse/SOLR-15600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17406027#comment-17406027
]
David Eric Pugh commented on SOLR-15600:
Seems like this process is one that other Apache
HoustonPutman commented on pull request #271:
URL: https://github.com/apache/solr/pull/271#issuecomment-907469533
Having some issues with the tests and URI parsing. Will make a fix on
monday, at which point everything should be good to go.
--
This is an automated message from the Apache
[
https://issues.apache.org/jira/browse/SOLR-15600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17406002#comment-17406002
]
Jan Høydahl commented on SOLR-15600:
The PR is moving along nicely and I think it can be committed
[
https://issues.apache.org/jira/browse/SOLR-15599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17406000#comment-17406000
]
Houston Putman commented on SOLR-15599:
---
I just figured out that this requires an upgrade from
janhoy commented on pull request #36:
URL: https://github.com/apache/solr-site/pull/36#issuecomment-907432321
> PR Opened: [cominvent#1](https://github.com/cominvent/solr-site/pull/1)
Thanks Houston. Merged.
--
This is an automated message from the Apache Git Service.
To respond
HoustonPutman commented on pull request #36:
URL: https://github.com/apache/solr-site/pull/36#issuecomment-907430983
PR Opened: https://github.com/cominvent/solr-site/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
dsmiley commented on a change in pull request #264:
URL: https://github.com/apache/solr/pull/264#discussion_r697653753
##
File path: solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java
##
@@ -342,7 +342,7 @@ private Path checkPathIsSafe(Path pathToCheck) throws
janhoy commented on pull request #36:
URL: https://github.com/apache/solr-site/pull/36#issuecomment-907405073
> Are we getting rid of the logos for compliance, or just to make migration
easier?
Main goal is to move the logos/names away from front-page. We are allowed to
use logos
janhoy commented on pull request #36:
URL: https://github.com/apache/solr-site/pull/36#issuecomment-907402932
@HoustonPutman feel free to open a PR against my branch with whatever you
have. I did not see your feedback until I already removed logos and sorted the
list alphabetically. If
dsmiley commented on a change in pull request #255:
URL: https://github.com/apache/solr/pull/255#discussion_r697624329
##
File path: solr/solrj/src/java/org/apache/solr/common/util/JavaBinCodec.java
##
@@ -935,9 +1046,7 @@ private CharSequence _readStr(DataInputInputStream
janhoy commented on a change in pull request #36:
URL: https://github.com/apache/solr-site/pull/36#discussion_r697650085
##
File path: themes/solr/templates/index.html
##
@@ -131,116 +131,13 @@
- Solr powers some of the most heavily-trafficked websites
janhoy commented on a change in pull request #36:
URL: https://github.com/apache/solr-site/pull/36#discussion_r697649241
##
File path: content/pages/community.md
##
@@ -142,5 +142,30 @@ You may alternatively choose to clone apache's git mirror
at `https://gitbox.apa
##
[
https://issues.apache.org/jira/browse/SOLR-15604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17405953#comment-17405953
]
Mike Drob commented on SOLR-15604:
--
This is going to involve package renames I think, which is going to
Mike Drob created SOLR-15604:
Summary: Make sure there are no split packages
Key: SOLR-15604
URL: https://issues.apache.org/jira/browse/SOLR-15604
Project: Solr
Issue Type: Task
Security
HoustonPutman commented on pull request #271:
URL: https://github.com/apache/solr/pull/271#issuecomment-907340886
Doing my end-to-end tests as we type!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
athrog commented on pull request #271:
URL: https://github.com/apache/solr/pull/271#issuecomment-907338957
It looks good to me! I assume you've tested it end to end with s3mock and
real s3?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
HoustonPutman commented on pull request #271:
URL: https://github.com/apache/solr/pull/271#issuecomment-907330441
@athrog Do you see any other issues here or should we be good to commit and
backport?
--
This is an automated message from the Apache Git Service.
To respond to the message,
cpoerschke commented on pull request #36:
URL: https://github.com/apache/solr-site/pull/36#issuecomment-907326269
> > > Could you allow me to push to the PR? It's saying I don't have
permission.
> >
> >
> > Maybe be same as [apache/solr#99
HoustonPutman merged pull request #35:
URL: https://github.com/apache/solr-site/pull/35
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
HoustonPutman commented on pull request #35:
URL: https://github.com/apache/solr-site/pull/35#issuecomment-907324899
So I actually like the new name of the page, since most people won't ever be
"downloading" it really.
I'll go ahead and commit this, and let you carry on.
--
This
HoustonPutman commented on pull request #36:
URL: https://github.com/apache/solr-site/pull/36#issuecomment-907322676
> > Could you allow me to push to the PR? It's saying I don't have
permission.
>
> Maybe be same as [apache/solr#99
epugh commented on a change in pull request #74:
URL: https://github.com/apache/solr/pull/74#discussion_r697560086
##
File path: solr/core/src/java/org/apache/solr/util/SolrCLI.java
##
@@ -411,24 +428,15 @@ else if ("package".equals(toolType))
}
private static void
HoustonPutman commented on a change in pull request #35:
URL: https://github.com/apache/solr-site/pull/35#discussion_r697558113
##
File path: themes/solr/templates/htaccess.template
##
@@ -71,7 +71,7 @@ RedirectMatch Permanent ^/docs/api-(.*) /docs/$1
### Redirects to
HoustonPutman commented on pull request #36:
URL: https://github.com/apache/solr-site/pull/36#issuecomment-907308874
I made changes so that we can merely maintain a list, and the table is
auto-formatted.
The logo slider also works, but I've commented it out until I'm clear
whether
[
https://issues.apache.org/jira/browse/SOLR-15428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17405898#comment-17405898
]
Dawid Weiss commented on SOLR-15428:
Oh... I think I know what changed - I used the logger and you
[
https://issues.apache.org/jira/browse/SOLR-15428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17405897#comment-17405897
]
Dawid Weiss commented on SOLR-15428:
Why? It should be the same string? Works for me at least and I
[
https://issues.apache.org/jira/browse/SOLR-15428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17405895#comment-17405895
]
Mark Robert Miller commented on SOLR-15428:
---
The change to echoCp in the gradle build file
HoustonPutman commented on pull request #36:
URL: https://github.com/apache/solr-site/pull/36#issuecomment-907305385
Are we getting rid of the logos for compliance, or just to make migration
easier?
--
This is an automated message from the Apache Git Service.
To respond to the message,
madrob commented on pull request #273:
URL: https://github.com/apache/solr/pull/273#issuecomment-907296256
Looks good, tests pass.
Can you please add an entry to `solr/CHANGES.txt` under Bug Fixes including
how you would like to be credited? Something like "Fix NPE when no grouping
cpoerschke commented on a change in pull request #36:
URL: https://github.com/apache/solr-site/pull/36#discussion_r697540406
##
File path: themes/solr/templates/index.html
##
@@ -131,116 +131,13 @@
- Solr powers some of the most heavily-trafficked
[
https://issues.apache.org/jira/browse/SOLR-13209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17405884#comment-17405884
]
Mike Drob commented on SOLR-13209:
--
Manually adding the link
> NullPointerException from call in
>
cpoerschke commented on pull request #269:
URL: https://github.com/apache/solr/pull/269#issuecomment-907288205
> Changes entry is your call. It’s more important to add it to major changes
in 9.0 chapter in refguide, but doesn’t hurt with a changes entry either,
perhaps someone actually
cpoerschke opened a new pull request #274:
URL: https://github.com/apache/solr/pull/274
* https://github.com/apache/solr/pull/269 for `solr/main` and
`lucene-solr/branch_8x` to be merged first.
* This PR here then to be merged second, to `solr/main` only.
ctargett commented on a change in pull request #36:
URL: https://github.com/apache/solr-site/pull/36#discussion_r697501097
##
File path: themes/solr/templates/index.html
##
@@ -131,116 +131,13 @@
- Solr powers some of the most heavily-trafficked
[
https://issues.apache.org/jira/browse/SOLR-13209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17405858#comment-17405858
]
David Eric Pugh commented on SOLR-13209:
Guessing because the original PR title was "Solr 13209"
[
https://issues.apache.org/jira/browse/SOLR-13209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob reassigned SOLR-13209:
Assignee: Mike Drob
> NullPointerException from call in
>
[
https://issues.apache.org/jira/browse/SOLR-13209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17405854#comment-17405854
]
Mike Drob commented on SOLR-13209:
--
Do we know why https://github.com/apache/solr/pull/273 didn't get
epugh commented on a change in pull request #36:
URL: https://github.com/apache/solr-site/pull/36#discussion_r697472150
##
File path: content/pages/community.md
##
@@ -142,5 +142,30 @@ You may alternatively choose to clone apache's git mirror
at `https://gitbox.apa
##
[
https://issues.apache.org/jira/browse/SOLR-15600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17405843#comment-17405843
]
Jan Høydahl commented on SOLR-15600:
Ok, compiling new logos etc will be a bigger effort, so I threw
janhoy opened a new pull request #36:
URL: https://github.com/apache/solr-site/pull/36
Also skiping Sears, IBM Websphere Commerce and The Echo Nest due to jira
comments
There is no styling in this 1st step, focus is to get into compliance with
policies and remove known false
epugh edited a comment on pull request #267:
URL: https://github.com/apache/solr/pull/267#issuecomment-907104280
What do we think @madrob @makosten ? Ready for merging? It would be nice
to get this into 8.10! Do we need to update the ref guide?
--
This is an automated message from
epugh commented on pull request #267:
URL: https://github.com/apache/solr/pull/267#issuecomment-907104280
What do we think @madrob @makosten ? Ready for merging?Do we need to
update the ref guide?
--
This is an automated message from the Apache Git Service.
To respond to the
uschindler commented on a change in pull request #35:
URL: https://github.com/apache/solr-site/pull/35#discussion_r697312402
##
File path: themes/solr/templates/htaccess.template
##
@@ -71,7 +71,7 @@ RedirectMatch Permanent ^/docs/api-(.*) /docs/$1
### Redirects to Apache
[
https://issues.apache.org/jira/browse/SOLR-15603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17405714#comment-17405714
]
Dawid Weiss commented on SOLR-15603:
I am really curious which tasks you have in mind and looking
[
https://issues.apache.org/jira/browse/SOLR-15603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss reassigned SOLR-15603:
--
Assignee: Dawid Weiss
> Activate Gradle build cache
> ---
>
>
markrmiller commented on pull request #265:
URL: https://github.com/apache/solr/pull/265#issuecomment-907046278
The core provider is good. Using a listener is a much better approach for
CoreContainer life-cycle. It could use a bit more as well though - shutdown
should actually be two
markrmiller commented on pull request #265:
URL: https://github.com/apache/solr/pull/265#issuecomment-907035777
Also, this is literally littered all over: "The init method must complete
successfully before the filter is asked to do any filtering work." The authors
may not have said it out
markrmiller commented on pull request #265:
URL: https://github.com/apache/solr/pull/265#issuecomment-907034437
> Seems like it should have generated a ticket with Jetty at least since
while the spec doesn't actually state that the call to init() > must have been
completed, that sure
Alexis Tual created SOLR-15603:
--
Summary: Activate Gradle build cache
Key: SOLR-15603
URL: https://issues.apache.org/jira/browse/SOLR-15603
Project: Solr
Issue Type: Improvement
Security
sonatype-lift[bot] commented on a change in pull request #254:
URL: https://github.com/apache/solr/pull/254#discussion_r697185496
##
File path: solr/benchmark/src/java/org/apache/solr/bench/BaseBenchState.java
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software
56 matches
Mail list logo
