ben-manes commented on PR #1198:
URL: https://github.com/apache/solr/pull/1198#issuecomment-1336104642
I believe that the managed dependencies in the pom are Gradle constraints
added to protect the build itself from exploits. It’s noise that doesn’t impact
users, but I’ll look into
ben-manes commented on PR #1198:
URL: https://github.com/apache/solr/pull/1198#issuecomment-1336103785
Caffeine has no required dependencies. It does have optional annotations
that can be excluded (checker, errorprone) that are compile scoped. The managed
dependencies are internal for
sonatype-lift[bot] commented on code in PR #1211:
URL: https://github.com/apache/solr/pull/1211#discussion_r1038659135
##
solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java:
##
@@ -2165,46 +2165,14 @@ protected SolrClient
sonatype-lift[bot] commented on code in PR #1206:
URL: https://github.com/apache/solr/pull/1206#discussion_r1038653818
##
solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java:
##
@@ -917,12 +917,12 @@ protected void updateMappingsFromZk(
[
https://issues.apache.org/jira/browse/SOLR-8975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642755#comment-17642755
]
Eric Pugh commented on SOLR-8975:
-
Heads up that as David Smiley correctly pointed out, the work I had
epugh opened a new pull request, #1211:
URL: https://github.com/apache/solr/pull/1211
https://issues.apache.org/jira/browse/SOLR-8975
Please note, this was originally https://github.com/apache/solr/pull/1158,
however we had a different JIRA open that more accurately reflected this
epugh closed pull request #1158: SOLR-16368: Use Builder Pattern with Solr
Clients
URL: https://github.com/apache/solr/pull/1158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
epugh commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1038648987
##
solr/core/src/test/org/apache/solr/search/TestSmileRequest.java:
##
@@ -91,7 +90,6 @@ public void assertJQ(SolrClient client, SolrParams args,
String... tests)
//
epugh commented on PR #1206:
URL: https://github.com/apache/solr/pull/1206#issuecomment-1335984261
This is starting to appear to be a sisphean task... 106 test files..
admittedly, not everyone needs the constant
--
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/SOLR-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642742#comment-17642742
]
Noble Paul commented on SOLR-16531:
---
{quote} Having it sit on {{main}} without merging to {{branch_9x}}
[
https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642700#comment-17642700
]
Noble Paul edited comment on SOLR-16347 at 12/3/22 12:15 AM:
-
{quote}I really
epugh commented on code in PR #1206:
URL: https://github.com/apache/solr/pull/1206#discussion_r1038638593
##
solr/core/src/test/org/apache/solr/handler/TestReplicationHandler.java:
##
@@ -87,18 +85,18 @@
*
* @since 1.4
*/
-@LuceneTestCase.Nightly
+//
epugh commented on code in PR #1206:
URL: https://github.com/apache/solr/pull/1206#discussion_r1038638593
##
solr/core/src/test/org/apache/solr/handler/TestReplicationHandler.java:
##
@@ -87,18 +85,18 @@
*
* @since 1.4
*/
-@LuceneTestCase.Nightly
+//
epugh commented on code in PR #1206:
URL: https://github.com/apache/solr/pull/1206#discussion_r1038638407
##
solr/core/src/test/org/apache/solr/cloud/TestCloudRecovery.java:
##
@@ -49,7 +49,6 @@
public class TestCloudRecovery extends SolrCloudTestCase {
- private static
epugh commented on code in PR #1206:
URL: https://github.com/apache/solr/pull/1206#discussion_r1038637792
##
solr/core/src/test/org/apache/solr/handler/TestReplicationHandler.java:
##
@@ -87,18 +85,18 @@
*
* @since 1.4
*/
-@LuceneTestCase.Nightly
+//
epugh commented on code in PR #1210:
URL: https://github.com/apache/solr/pull/1210#discussion_r1038634363
##
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##
@@ -297,6 +297,9 @@ && getZkController().getOverseer() != null
public static final long
[
https://issues.apache.org/jira/browse/SOLR-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642731#comment-17642731
]
Eric Pugh commented on SOLR-16567:
--
The films example really is pretty shallow... So lets just merge
[
https://issues.apache.org/jira/browse/SOLR-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642730#comment-17642730
]
Eric Pugh commented on SOLR-16567:
--
So... How about this... Why don't you and I work on a seperate
[
https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642718#comment-17642718
]
Ishan Chattopadhyaya commented on SOLR-16347:
-
bq. This is why I advocated in Slack to keep
[
https://issues.apache.org/jira/browse/SOLR-788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikhail Khludnev updated SOLR-788:
--
Status: Reopened (was: Closed)
> MoreLikeThis should support distributed search
>
[
https://issues.apache.org/jira/browse/SOLR-788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642716#comment-17642716
]
Mikhail Khludnev commented on SOLR-788:
---
I can confirm that
[
https://issues.apache.org/jira/browse/SOLR-788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikhail Khludnev updated SOLR-788:
--
Attachment: mlt=true_component_is_vulnerable_to_coolon_delimited_token.patch
> MoreLikeThis
[
https://issues.apache.org/jira/browse/SOLR-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642715#comment-17642715
]
Houston Putman commented on SOLR-16531:
---
SOLR-16347 was a very big commit. Having it sit on
David Smiley created SOLR-16573:
---
Summary: SolrClientTestRule for EmbeddedSolrServer
Key: SOLR-16573
URL: https://issues.apache.org/jira/browse/SOLR-16573
Project: Solr
Issue Type: Sub-task
[
https://issues.apache.org/jira/browse/SOLR-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642704#comment-17642704
]
Gabriel Magno commented on SOLR-16567:
--
Hey [~epugh] .
I have just created a personal fork of the
[
https://issues.apache.org/jira/browse/SOLR-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642688#comment-17642688
]
Jason Gerlowski edited comment on SOLR-16531 at 12/2/22 9:51 PM:
-
bq.
[
https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642700#comment-17642700
]
Noble Paul commented on SOLR-16347:
---
{quote}I really wish you'd include full context around claims like
[
https://issues.apache.org/jira/browse/SOLR-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642688#comment-17642688
]
Jason Gerlowski commented on SOLR-16531:
bq. disabling v2 has no impact on the perf, you get the
[
https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642687#comment-17642687
]
Jason Gerlowski commented on SOLR-16347:
bq. node startup is 33% slower because of this commit
[
https://issues.apache.org/jira/browse/SOLR-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642684#comment-17642684
]
Eric Pugh commented on SOLR-16567:
--
I like your idea [~gmagno] ! That way we don't have to add more
epugh commented on code in PR #1107:
URL: https://github.com/apache/solr/pull/1107#discussion_r1038473703
##
solr/core/src/java/org/apache/solr/search/QueryResultKey.java:
##
@@ -51,20 +52,28 @@ public QueryResultKey(
Query query, List filters, Sort sort, int nc_flags,
gerlowskija commented on code in PR #1210:
URL: https://github.com/apache/solr/pull/1210#discussion_r1038473291
##
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##
@@ -297,6 +297,9 @@ && getZkController().getOverseer() != null
public static final long
epugh commented on code in PR #1210:
URL: https://github.com/apache/solr/pull/1210#discussion_r1038471896
##
solr/core/src/java/org/apache/solr/core/PluginBag.java:
##
@@ -63,17 +64,20 @@
private final Class klass;
private SolrCore core;
private final
epugh commented on code in PR #1210:
URL: https://github.com/apache/solr/pull/1210#discussion_r1038471290
##
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##
@@ -297,6 +297,9 @@ && getZkController().getOverseer() != null
public static final long
[
https://issues.apache.org/jira/browse/SOLR-16469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642669#comment-17642669
]
Thomas Corthals commented on SOLR-16469:
This seems to do the trick for the admin UI.
{code:js}
gerlowskija opened a new pull request, #1210:
URL: https://github.com/apache/solr/pull/1210
https://issues.apache.org/jira/browse/SOLR-16347
# Description
Solr supports a system-property ('disable.v2.api') that can be used to turn
off the currently experimental v2 API.
kiratraynor opened a new pull request, #1209:
URL: https://github.com/apache/solr/pull/1209
https://issues.apache.org/jira/browse/SOLR-16568
# Description
The com.fasterxml.woodstox:woodstox-core dependency has 4 CVEs associated
with v6.2.8:
[
https://issues.apache.org/jira/browse/SOLR-16572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kira Traynor resolved SOLR-16572.
-
Resolution: Duplicate
> Update FasterXML Woodstox Dependency for CVE-2022-40153
>
Kira Traynor created SOLR-16572:
---
Summary: Update FasterXML Woodstox Dependency for CVE-2022-40153
Key: SOLR-16572
URL: https://issues.apache.org/jira/browse/SOLR-16572
Project: Solr
Issue
sonatype-lift[bot] commented on code in PR #1208:
URL: https://github.com/apache/solr/pull/1208#discussion_r1038444137
##
solr/core/src/java/org/apache/solr/cloud/ZkController.java:
##
@@ -2736,6 +2736,10 @@ private Set getConfDirListeners(final String
confDir) {
return
dsmiley merged PR #1197:
URL: https://github.com/apache/solr/pull/1197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
stillalex commented on code in PR #1107:
URL: https://github.com/apache/solr/pull/1107#discussion_r1038432311
##
solr/core/src/java/org/apache/solr/search/QueryResultKey.java:
##
@@ -33,16 +36,14 @@ public final class QueryResultKey implements Accountable {
final Query
[
https://issues.apache.org/jira/browse/SOLR-15955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642645#comment-17642645
]
ASF subversion and git services commented on SOLR-15955:
Commit
nginthfs opened a new pull request, #1208:
URL: https://github.com/apache/solr/pull/1208
# Description
Solr creates a ZooKeeper watch per-core. On nodes with a lot of cores, this
results in a lot of ZK watches, and thus increased resource consumption. ZK
config watches aren't
Nick Ginther created SOLR-16571:
---
Summary: Add Java system property for ZooKeeper config watch
Key: SOLR-16571
URL: https://issues.apache.org/jira/browse/SOLR-16571
Project: Solr
Issue Type:
nginthfs commented on code in PR #1205:
URL: https://github.com/apache/solr/pull/1205#discussion_r1038399026
##
solr/core/src/java/org/apache/solr/cloud/Overseer.java:
##
@@ -336,8 +337,8 @@ public void run() {
for (Pair head : queue) {
byte[]
[
https://issues.apache.org/jira/browse/SOLR-15955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642630#comment-17642630
]
ASF subversion and git services commented on SOLR-15955:
Commit
HoustonPutman merged PR #1204:
URL: https://github.com/apache/solr/pull/1204
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
HoustonPutman commented on issue #483:
URL: https://github.com/apache/solr-operator/issues/483#issuecomment-1335584926
Can you share your prometheus scraping config? This seems to be a prometheus
issue...
--
This is an automated message from the Apache Git Service.
To respond to the
stillalex commented on code in PR #1107:
URL: https://github.com/apache/solr/pull/1107#discussion_r1038361120
##
solr/core/src/java/org/apache/solr/search/QueryResultKey.java:
##
@@ -51,20 +52,28 @@ public QueryResultKey(
Query query, List filters, Sort sort, int
epugh commented on code in PR #1107:
URL: https://github.com/apache/solr/pull/1107#discussion_r1038361030
##
solr/core/src/java/org/apache/solr/search/QueryResultKey.java:
##
@@ -33,16 +36,14 @@ public final class QueryResultKey implements Accountable {
final Query query;
stillalex commented on PR #1107:
URL: https://github.com/apache/solr/pull/1107#issuecomment-1335542883
offering a review and a 'looks good to me' (even if non binding)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
stillalex commented on code in PR #1107:
URL: https://github.com/apache/solr/pull/1107#discussion_r1038344272
##
solr/core/src/java/org/apache/solr/search/QueryResultKey.java:
##
@@ -33,16 +36,14 @@ public final class QueryResultKey implements Accountable {
final Query
stillalex commented on code in PR #1107:
URL: https://github.com/apache/solr/pull/1107#discussion_r1038341931
##
solr/core/src/java/org/apache/solr/search/QueryResultKey.java:
##
@@ -51,20 +52,28 @@ public QueryResultKey(
Query query, List filters, Sort sort, int
[
https://issues.apache.org/jira/browse/SOLR-16469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642555#comment-17642555
]
Kevin Risden commented on SOLR-16469:
-
There are more details on the solr user list with a new
[
https://issues.apache.org/jira/browse/SOLR-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642538#comment-17642538
]
Gabriel Magno commented on SOLR-16567:
--
I have an idea.
I can create vectors for the "films"
[
https://issues.apache.org/jira/browse/SOLR-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642516#comment-17642516
]
Gabriel Magno commented on SOLR-16567:
--
Hey [~epugh] .
The example entries of the scripts were
koboltmarky commented on issue #483:
URL: https://github.com/apache/solr-operator/issues/483#issuecomment-1335068358
> even after adding pod annotation, prometheus still looking at port 80 on
pod IP in my case. Something is seriously wrong with this.below is my exporter
config.
koboltmarky commented on issue #483:
URL: https://github.com/apache/solr-operator/issues/483#issuecomment-1335065203
> In that screenshot, is the `10.110.6.70` IP address the service ClusterIP
or the pod IP? If it's the service's then there is something wrong with
kubernetes. If its the
59 matches
Mail list logo
