[ 
https://issues.apache.org/jira/browse/SOLR-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642688#comment-17642688
 ] 

Jason Gerlowski edited comment on SOLR-16531 at 12/2/22 9:51 PM:
-----------------------------------------------------------------

bq. disabling v2 has no impact on the perf, you get the exact same numbers

You're right, the feature flag wasn't ever pushed down to PluginBag so there 
was needless work being done both for JAX-RS and for the traditional 
ApiBag-based v2 APIs when v2 was disabled.  Working on a fix for that 
[here|https://github.com/apache/solr/pull/1210].


was (Author: gerlowskija):
bq. disabling v2 has no impact on the perf, you get the exact same numbers

You're right, the feature flag wasn't ever pushed down to PluginBag so there 
was needless work being done both for JAX-RS and for the traditional 
ApiBag-based v2 APIs.  Working on a fix for that 
[here|https://github.com/apache/solr/pull/1210].

> Performance degradation due to introduction of JAX-RS
> -----------------------------------------------------
>
>                 Key: SOLR-16531
>                 URL: https://issues.apache.org/jira/browse/SOLR-16531
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Ishan Chattopadhyaya
>            Priority: Blocker
>             Fix For: 9.2
>
>         Attachments: Screenshot from 2022-11-09 11-20-44.png, 
> results-with-patch.tar.gz
>
>
> During performance benchmarking on branch_9x, I observed a slowdown in 
> restart performance since commits in SOLR-16347. See attached screenshot.
> CC [~gerlowskija].
> http://mostly.cool/cluster-test-with-patch.html
> The benchmark is here: 
> https://github.com/fullstorydev/solr-bench/blob/ishan/repeatable-jenkins/suites/cluster-test.json.
>  This suite was run after retro-actively applying the parallelStream patch 
> from SOLR-16414: 
> https://github.com/apache/solr/commit/b33161d0cdd976fc0c3dc78c4afafceb4db671cf.diff
>  
> Effort to automate these benchmarks is WIP and tracked here: SOLR-16525.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to