noblepaul commented on PR #1350:
URL: https://github.com/apache/solr/pull/1350#issuecomment-1434129742
There are still occasional test failures. I'm investigating
```./gradlew :solr:core:test --tests
"org.apache.solr.cloud.SplitShardWithNodeRoleTest.testSolrClusterWithNodeRoleWithHA"
[
https://issues.apache.org/jira/browse/SOLR-13942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690147#comment-17690147
]
Noble Paul commented on SOLR-13942:
---
{quote}Does deprecation still make sense to folks at this point?
noblepaul commented on code in PR #1363:
URL: https://github.com/apache/solr/pull/1363#discussion_r1109238520
##
solr/core/src/test/org/apache/solr/search/TestCoordinatorRole.java:
##
@@ -338,6 +338,7 @@ public void testNRTRestart() throws Exception {
start = new
noblepaul commented on code in PR #1363:
URL: https://github.com/apache/solr/pull/1363#discussion_r1109237271
##
solr/core/src/test/org/apache/solr/search/TestCoordinatorRole.java:
##
@@ -296,6 +294,8 @@ public void testNRTRestart() throws Exception {
noblepaul commented on code in PR #1363:
URL: https://github.com/apache/solr/pull/1363#discussion_r1109236826
##
solr/core/src/test/org/apache/solr/search/TestCoordinatorRole.java:
##
@@ -389,6 +390,7 @@ private String getHostCoreName(
SolrQuery q = new SolrQuery("*:*");
Jdurham2843 commented on PR #1126:
URL: https://github.com/apache/solr/pull/1126#issuecomment-1433972124
I did some testing and things appeared to be working correctly. I am still
seeing the injection exception. Any thoughts what that might be?
--
This is an automated message from the
Jdurham2843 commented on PR #1126:
URL: https://github.com/apache/solr/pull/1126#issuecomment-1433915434
Hey! I'll start testing the changes you made, and see if the injection
errors are still around. From a first look at the changes, I agree with all of
them. Regarding the near-duplicate
stillalex commented on PR #1364:
URL: https://github.com/apache/solr/pull/1364#issuecomment-1433870845
rebased to fix the changes file conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/SOLR-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690026#comment-17690026
]
ASF subversion and git services commented on SOLR-16665:
Commit
[
https://issues.apache.org/jira/browse/SOLR-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Houston Putman resolved SOLR-16665.
---
Fix Version/s: 9.2
Resolution: Done
> Upgrade OS version for base Docker image to
[
https://issues.apache.org/jira/browse/SOLR-15787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690011#comment-17690011
]
Jason Gerlowski commented on SOLR-15787:
Ah, ok - so FSCSS is used in standalone, it's just that
[
https://issues.apache.org/jira/browse/SOLR-15787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-15787:
Summary: FileSystemConfigSetService, support write operations and more
(was: Implement
[
https://issues.apache.org/jira/browse/SOLR-15787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689987#comment-17689987
]
David Smiley commented on SOLR-15787:
-
FileSystemConfigSetService is used by Solr in standalone mode
mkhludnev commented on PR #1324:
URL: https://github.com/apache/solr/pull/1324#issuecomment-1433670127
Oh.. somehow, I stepped in CHANGES. Colleagues, would you mind approve or
point on some stuff to improve?
--
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/SOLR-15787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689956#comment-17689956
]
Jason Gerlowski commented on SOLR-15787:
bq. [David] What practical effect does this have for
[
https://issues.apache.org/jira/browse/SOLR-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689950#comment-17689950
]
ASF subversion and git services commented on SOLR-16665:
Commit
HoustonPutman merged PR #1365:
URL: https://github.com/apache/solr/pull/1365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/SOLR-16116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689909#comment-17689909
]
Kevin Risden commented on SOLR-16116:
-
> Is the move to Hadoop client libraries easy dependency
risdenk commented on code in PR #1360:
URL: https://github.com/apache/solr/pull/1360#discussion_r1108868836
##
solr/core/src/java/org/apache/solr/update/UpdateLog.java:
##
@@ -1940,7 +1940,12 @@ public void doReplay(TransactionLog translog) {
ThreadLocal
[
https://issues.apache.org/jira/browse/SOLR-15733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689901#comment-17689901
]
Kevin Risden commented on SOLR-15733:
-
Umm not sure [~houston] maybe just CHANGES.txt and
HoustonPutman opened a new pull request, #1365:
URL: https://github.com/apache/solr/pull/1365
https://issues.apache.org/jira/browse/SOLR-16665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
janhoy commented on code in PR #1361:
URL: https://github.com/apache/solr/pull/1361#discussion_r1108816697
##
solr/solr-ref-guide/modules/query-guide/pages/analytics-mapping-functions.adoc:
##
@@ -18,6 +18,8 @@
Mapping functions map values for each Solr Document or
[
https://issues.apache.org/jira/browse/SOLR-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-1:
---
Attachment: SOLR-1-repro.sh
Status: Open (was: Open)
Attaching a script that
sonatype-lift[bot] commented on code in PR #1364:
URL: https://github.com/apache/solr/pull/1364#discussion_r1108789946
##
solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java:
##
@@ -272,18 +272,23 @@ public List getComponents() {
return result;
}
+
Jason Gerlowski created SOLR-1:
--
Summary: /admin/cores?action=REQUESTSTATUS doesn't show response
of completed tasks
Key: SOLR-1
URL: https://issues.apache.org/jira/browse/SOLR-1
sonatype-lift[bot] commented on code in PR #1126:
URL: https://github.com/apache/solr/pull/1126#discussion_r1108778401
##
solr/core/src/java/org/apache/solr/handler/admin/CoreAdminHandler.java:
##
@@ -493,4 +404,133 @@ public interface CoreAdminOp {
*/
void
[
https://issues.apache.org/jira/browse/SOLR-15733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689853#comment-17689853
]
ASF subversion and git services commented on SOLR-15733:
Commit
[
https://issues.apache.org/jira/browse/SOLR-15733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689851#comment-17689851
]
Houston Putman commented on SOLR-15733:
---
I've added publishing of the artifacts, which is easy to
[
https://issues.apache.org/jira/browse/SOLR-15733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689850#comment-17689850
]
ASF subversion and git services commented on SOLR-15733:
Commit
vinayakphegde commented on code in PR #1360:
URL: https://github.com/apache/solr/pull/1360#discussion_r1108757653
##
solr/core/src/java/org/apache/solr/update/UpdateLog.java:
##
@@ -1940,7 +1940,12 @@ public void doReplay(TransactionLog translog) {
ThreadLocal
Houston Putman created SOLR-16665:
-
Summary: Upgrade OS version for base Docker image to jammy (Ubuntu
22)
Key: SOLR-16665
URL: https://issues.apache.org/jira/browse/SOLR-16665
Project: Solr
vinayakphegde commented on code in PR #1360:
URL: https://github.com/apache/solr/pull/1360#discussion_r1108754672
##
solr/core/src/java/org/apache/solr/update/UpdateLog.java:
##
@@ -1940,7 +1940,12 @@ public void doReplay(TransactionLog translog) {
ThreadLocal
HoustonPutman commented on code in PR #1361:
URL: https://github.com/apache/solr/pull/1361#discussion_r1108747250
##
solr/solr-ref-guide/modules/query-guide/pages/analytics-mapping-functions.adoc:
##
@@ -18,6 +18,8 @@
Mapping functions map values for each Solr Document or
andywebb1975 commented on PR #1324:
URL: https://github.com/apache/solr/pull/1324#issuecomment-1433376588
> Hi, @andywebb1975 . I pushed commit replacing switch to closure in doc
scoring loop. Please have a look. WDYT?
Thanks @mkhludnev - yes, that does look cleaner!
--
This is an
stillalex opened a new pull request, #1364:
URL: https://github.com/apache/solr/pull/1364
https://issues.apache.org/jira/browse/SOLR-16656
# Description
Moved isDistrib calculation before the decision to log rid, in order to be
logged correctly.
# Solution
gerlowskija commented on PR #1126:
URL: https://github.com/apache/solr/pull/1126#issuecomment-147997
Morning @Jdurham2843 - I took the liberty of addressing my review comments
as they were all relatively minor. I handled each one as a separate commit, so
if you happen to disagree on
[
https://issues.apache.org/jira/browse/SOLR-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16664:
Status: Patch Available (was: Open)
> TestCoordinatorRole fails docs is null
>
[
https://issues.apache.org/jira/browse/SOLR-15928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689815#comment-17689815
]
Jan Høydahl commented on SOLR-15928:
[~epugh] I made an attempt at greying out the "Add collection"
janhoy commented on PR #1362:
URL: https://github.com/apache/solr/pull/1362#issuecomment-1433313362
I intend to merge this on Wednesday next week (Feb 22nd) unless there are
new concerns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
risdenk opened a new pull request, #1363:
URL: https://github.com/apache/solr/pull/1363
https://issues.apache.org/jira/browse/SOLR-16664
I started to look at `TestCoordinatorRole` and besides just adding the
assertion to make sure docs is not null there are other confusing things in
Kevin Risden created SOLR-16664:
---
Summary: TestCoordinatorRole fails docs is null
Key: SOLR-16664
URL: https://issues.apache.org/jira/browse/SOLR-16664
Project: Solr
Issue Type: Test
[
https://issues.apache.org/jira/browse/SOLR-16660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689811#comment-17689811
]
Jan Høydahl commented on SOLR-16660:
I plan to merge this on Wednesday Feb 22nd, unless there is
[ https://issues.apache.org/jira/browse/SOLR-16660 ]
Jan Høydahl deleted comment on SOLR-16660:
was (Author: jira-bot):
Commit d98b09e6b3b2e00be23871ed86c9f4995921067e in solr's branch
refs/heads/SOLR-16660-deprecate-analytics from Jan Høydahl
risdenk commented on code in PR #1360:
URL: https://github.com/apache/solr/pull/1360#discussion_r1108647898
##
solr/core/src/java/org/apache/solr/update/processor/UpdateRequestProcessorChain.java:
##
@@ -16,6 +16,7 @@
*/
package org.apache.solr.update.processor;
+import
[
https://issues.apache.org/jira/browse/SOLR-15959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689801#comment-17689801
]
Jan Høydahl commented on SOLR-15959:
Is this were I'll advocate for YAML or JSON, and an overall
vinayakphegde commented on PR #1360:
URL: https://github.com/apache/solr/pull/1360#issuecomment-1433204163
Okay, got it.
yeah, if you find any solution, ping me. I will try that out and test it in
my system.
--
This is an automated message from the Apache Git Service.
To respond to
dependabot[bot] closed pull request #521: Bump github.com/containerd/containerd
from 1.6.6 to 1.6.12
URL: https://github.com/apache/solr-operator/pull/521
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
dependabot[bot] commented on PR #521:
URL: https://github.com/apache/solr-operator/pull/521#issuecomment-1433179920
Superseded by #524.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dependabot[bot] opened a new pull request, #524:
URL: https://github.com/apache/solr-operator/pull/524
Bumps
[github.com/containerd/containerd](https://github.com/containerd/containerd)
from 1.6.6 to 1.6.18.
Release notes
Sourced from
gerlowskija commented on code in PR #1126:
URL: https://github.com/apache/solr/pull/1126#discussion_r1108554248
##
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##
@@ -1095,26 +1095,21 @@ protected void configure() {
magibney commented on PR #1360:
URL: https://github.com/apache/solr/pull/1360#issuecomment-1433170936
No, the change results in never consulting the map at all; any caller of
`SlowCompositeReaderWrapper.terms(String field)` will get a freshly-constructed
(uncached) `Terms` instance. The
vinayakphegde commented on PR #1360:
URL: https://github.com/apache/solr/pull/1360#issuecomment-1433165273
even with the new change also we are returning the same `Term` instance,
right?
How does that make the `Term` instance thread-safe?
--
This is an automated message from the
[
https://issues.apache.org/jira/browse/SOLR-16663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689783#comment-17689783
]
Jan Høydahl commented on SOLR-16663:
It was proposed by [~elyograg] over in SOLR-13931 to simply call
[
https://issues.apache.org/jira/browse/SOLR-16663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-16663:
---
Description:
Let's get a proper name for our "JSON request APIs"!
It has bothered me for some time
[
https://issues.apache.org/jira/browse/SOLR-16663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-16663:
---
Attachment: Skjermbilde 2023-02-16 kl. 15.00.58.png
> Re-brand JSON Request APIs
>
[
https://issues.apache.org/jira/browse/SOLR-16282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689780#comment-17689780
]
Jason Gerlowski commented on SOLR-16282:
Trying to understand this feature a bit better, and had
Jan Høydahl created SOLR-16663:
--
Summary: Re-brand JSON Request APIs
Key: SOLR-16663
URL: https://issues.apache.org/jira/browse/SOLR-16663
Project: Solr
Issue Type: Improvement
Security
[
https://issues.apache.org/jira/browse/SOLR-13931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689775#comment-17689775
]
Jan Høydahl commented on SOLR-13931:
Thanks for the pointer Michael. I found SOLR-7296, so let's
[
https://issues.apache.org/jira/browse/SOLR-7296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689773#comment-17689773
]
Jan Høydahl commented on SOLR-7296:
---
Reviving this topic. Much has happended since 2015, and the JSON
[
https://issues.apache.org/jira/browse/SOLR-16619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689760#comment-17689760
]
Colvin Cowie commented on SOLR-16619:
-
Ahh, Jira ruined my formatting. Hopefully it makes sense
[
https://issues.apache.org/jira/browse/SOLR-16619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689758#comment-17689758
]
Colvin Cowie commented on SOLR-16619:
-
I could take a look more closely next week, I've just had a
magibney commented on PR #1360:
URL: https://github.com/apache/solr/pull/1360#issuecomment-1433033954
The map is explicitly designed to lazily cache these `Terms` instances
(accumulating them over time for a given `SolrIndexSearcher`). The returned
`Terms` instances are _not_ safe for
vinayakphegde commented on PR #1360:
URL: https://github.com/apache/solr/pull/1360#issuecomment-1432998084
> Sharing early here (not immediately sure about the _right_ way to fix
this); it looks like there's a problem with `Terms` caching in
`SlowCompositeReaderWrapper`; tests pass (aside
[
https://issues.apache.org/jira/browse/SOLR-15959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689710#comment-17689710
]
Eric Pugh commented on SOLR-15959:
--
After reviewing you PR, I came back to this issue with the intent to
[
https://issues.apache.org/jira/browse/SOLR-9698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689706#comment-17689706
]
Eric Pugh commented on SOLR-9698:
-
I love seeing 4 digit JIRA's get some love...And work on the
[
https://issues.apache.org/jira/browse/SOLR-9698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689652#comment-17689652
]
ASF subversion and git services commented on SOLR-9698:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-9698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689642#comment-17689642
]
ASF subversion and git services commented on SOLR-9698:
---
Commit
colvinco merged PR #1329:
URL: https://github.com/apache/solr/pull/1329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
janhoy opened a new pull request, #1362:
URL: https://github.com/apache/solr/pull/1362
https://issues.apache.org/jira/browse/SOLR-15959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/SOLR-15959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689627#comment-17689627
]
Jan Høydahl commented on SOLR-15959:
Circling back to this topic. On the user list thread
[
https://issues.apache.org/jira/browse/SOLR-15959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl reassigned SOLR-15959:
--
Assignee: Jan Høydahl
> Deprecate loading of solr.xml from ZK
>
[
https://issues.apache.org/jira/browse/SOLR-16660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689612#comment-17689612
]
ASF subversion and git services commented on SOLR-16660:
Commit
72 matches
Mail list logo
