epugh commented on PR #1248:
URL: https://github.com/apache/solr/pull/1248#issuecomment-1368218658
thanks for the comments folks. Running a full test, and waiting for the
jenkins main branch to finish, and then will merge this.
--
This is an automated message from the Apache Git Service.
epugh commented on PR #1248:
URL: https://github.com/apache/solr/pull/1248#issuecomment-1367889316
Okay, any angst to me merging this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
epugh commented on PR #1248:
URL: https://github.com/apache/solr/pull/1248#issuecomment-1367286764
I just fixed the lint problem. While it would be good to think about what
properties should be settable and which should be system properties, I actually
am thinking that is out of scope. I
epugh commented on PR #1248:
URL: https://github.com/apache/solr/pull/1248#issuecomment-1367285064
> > left a few minor comments, overall this looks good.
> > is updating the `objectList` method on the table? I find this code a bit
ugly (bigger change would be to use an array everywhere,
epugh commented on PR #1248:
URL: https://github.com/apache/solr/pull/1248#issuecomment-1366267147
I think I've responded to everythign from @dsmiley and @stillalex.. Only
change I haven't made is to eliminate this property and replace it with a
system variable... That feels like a bit
epugh commented on PR #1248:
URL: https://github.com/apache/solr/pull/1248#issuecomment-1366263569
> left a few minor comments, overall this looks good.
>
> is updating the `objectList` method on the table? I find this code a bit
ugly (bigger change would be to use an array everywhere
epugh commented on PR #1248:
URL: https://github.com/apache/solr/pull/1248#issuecomment-1364110212
So, `setParallelCacheRefreshes` appears to be a odd setting Does
anyone actually change it/use it? Or do we all just use the default of 3?
There don't appear to be any tests for it..
epugh commented on PR #1248:
URL: https://github.com/apache/solr/pull/1248#issuecomment-1364109540
So...I can't get a clean run of tests on any branch of solr on my
laptop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
epugh commented on PR #1248:
URL: https://github.com/apache/solr/pull/1248#issuecomment-1363888032
So, with these changes, a lot of tests fail... For example
"DistributedExpandComponentTest"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
