[GitHub] [solr] laminelam commented on a diff in pull request #857: SOLR-16192: Add ZK credentials injectors support

laminelam commented on code in PR #857: URL: https://github.com/apache/solr/pull/857#discussion_r939581469 ## solr/solr-ref-guide/modules/deployment-guide/pages/zookeeper-access-control.adoc: ## @@ -56,9 +56,37 @@ ACLs describe who is allowed to read, update, delete, create, et

[GitHub] [solr] laminelam commented on a diff in pull request #857: SOLR-16192: Add ZK credentials injectors support

laminelam commented on code in PR #857: URL: https://github.com/apache/solr/pull/857#discussion_r939580999 ## solr/solrj/src/java/org/apache/solr/common/cloud/SolrZkClient.java: ## @@ -256,18 +261,44 @@ protected ZkACLProvider createZkACLProvider() { if (!StringUtils.isEmpt

[GitHub] [solr] laminelam commented on a diff in pull request #857: SOLR-16192: Add ZK credentials injectors support

laminelam commented on code in PR #857: URL: https://github.com/apache/solr/pull/857#discussion_r939580787 ## solr/core/src/java/org/apache/solr/core/CloudConfig.java: ## @@ -227,12 +236,19 @@ public CloudConfigBuilder setLeaderConflictResolveWait(int leaderConflictResolve

[GitHub] [solr] laminelam commented on a diff in pull request #857: SOLR-16192: Add ZK credentials injectors support

laminelam commented on code in PR #857: URL: https://github.com/apache/solr/pull/857#discussion_r939580741 ## solr/solrj/src/java/org/apache/solr/common/cloud/VMParamsZkCredentialsInjector.java: ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [solr] laminelam commented on a diff in pull request #857: SOLR-16192: Add ZK credentials injectors support

laminelam commented on code in PR #857: URL: https://github.com/apache/solr/pull/857#discussion_r939580684 ## solr/solrj/src/java/org/apache/solr/common/cloud/SolrZkClient.java: ## @@ -256,18 +261,44 @@ protected ZkACLProvider createZkACLProvider() { if (!StringUtils.isEmpt

[GitHub] [solr] laminelam commented on a diff in pull request #857: SOLR-16192: Add ZK credentials injectors support

laminelam commented on code in PR #857: URL: https://github.com/apache/solr/pull/857#discussion_r930273716 ## solr/solrj/src/java/org/apache/solr/common/cloud/DigestZkACLProvider.java: ## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

[GitHub] [solr] laminelam commented on a diff in pull request #857: SOLR-16192: Add ZK credentials injectors support

laminelam commented on code in PR #857: URL: https://github.com/apache/solr/pull/857#discussion_r930273100 ## solr/solrj/src/java/org/apache/solr/common/cloud/DigestZkACLProvider.java: ## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

[GitHub] [solr] laminelam commented on a diff in pull request #857: SOLR-16192: Add ZK credentials injectors support

laminelam commented on code in PR #857: URL: https://github.com/apache/solr/pull/857#discussion_r930270525 ## solr/solrj/src/java/org/apache/solr/common/cloud/ZkCredentialsInjector.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [solr] laminelam commented on a diff in pull request #857: SOLR-16192: Add ZK credentials injectors support

laminelam commented on code in PR #857: URL: https://github.com/apache/solr/pull/857#discussion_r916945182 ## solr/solrj/src/java/org/apache/solr/common/cloud/acl/DigestZkCredentialsProvider.java: ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [solr] laminelam commented on a diff in pull request #857: SOLR-16192: Add ZK credentials injectors support

laminelam commented on code in PR #857: URL: https://github.com/apache/solr/pull/857#discussion_r916920876 ## solr/solrj/src/java/org/apache/solr/common/cloud/DigestZkCredentialsProvider.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [solr] laminelam commented on a diff in pull request #857: SOLR-16192: Add ZK credentials injectors support

laminelam commented on code in PR #857: URL: https://github.com/apache/solr/pull/857#discussion_r887940274 ## solr/solrj/src/java/org/apache/solr/common/cloud/SolrZkClient.java: ## @@ -236,8 +240,11 @@ protected ZkCredentialsProvider createZkCredentialsToAddAutomatically() {

[GitHub] [solr] laminelam commented on a diff in pull request #857: SOLR-16192: Add ZK credentials injectors support

laminelam commented on code in PR #857: URL: https://github.com/apache/solr/pull/857#discussion_r887960327 ## solr/core/src/java/org/apache/solr/core/SolrXmlConfig.java: ## @@ -529,6 +529,9 @@ private static CloudConfig fillSolrCloudSection( case "zkCredentialsProvider"

[GitHub] [solr] laminelam commented on a diff in pull request #857: SOLR-16192: Add ZK credentials injectors support

laminelam commented on code in PR #857: URL: https://github.com/apache/solr/pull/857#discussion_r887955841 ## solr/solrj/src/java/org/apache/solr/common/cloud/acl/package-info.java: ## @@ -0,0 +1,19 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [solr] laminelam commented on a diff in pull request #857: SOLR-16192: Add ZK credentials injectors support

laminelam commented on code in PR #857: URL: https://github.com/apache/solr/pull/857#discussion_r887944716 ## solr/solrj/src/java/org/apache/solr/common/cloud/acl/DigestZkCredentialsProvider.java: ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [solr] laminelam commented on a diff in pull request #857: SOLR-16192: Add ZK credentials injectors support

laminelam commented on code in PR #857: URL: https://github.com/apache/solr/pull/857#discussion_r887940274 ## solr/solrj/src/java/org/apache/solr/common/cloud/SolrZkClient.java: ## @@ -236,8 +240,11 @@ protected ZkCredentialsProvider createZkCredentialsToAddAutomatically() {

[GitHub] [solr] laminelam commented on a diff in pull request #857: SOLR-16192: Add ZK credentials injectors support

laminelam commented on code in PR #857: URL: https://github.com/apache/solr/pull/857#discussion_r887940274 ## solr/solrj/src/java/org/apache/solr/common/cloud/SolrZkClient.java: ## @@ -236,8 +240,11 @@ protected ZkCredentialsProvider createZkCredentialsToAddAutomatically() {

[GitHub] [solr] laminelam commented on a diff in pull request #857: SOLR-16192: Add ZK credentials injectors support

laminelam commented on code in PR #857: URL: https://github.com/apache/solr/pull/857#discussion_r872750831 ## solr/solrj/src/java/org/apache/solr/common/cloud/acl/ZkACLProvider.java: ## @@ -14,12 +14,14 @@ * See the License for the specific language governing permissions and

[GitHub] [solr] laminelam commented on a diff in pull request #857: SOLR-16192: Add ZK credentials injectors support

laminelam commented on code in PR #857: URL: https://github.com/apache/solr/pull/857#discussion_r872750831 ## solr/solrj/src/java/org/apache/solr/common/cloud/acl/ZkACLProvider.java: ## @@ -14,12 +14,14 @@ * See the License for the specific language governing permissions and

[GitHub] [solr] laminelam commented on a diff in pull request #857: SOLR-16192: Add ZK credentials injectors support

laminelam commented on code in PR #857: URL: https://github.com/apache/solr/pull/857#discussion_r870833772 ## solr/solrj/src/java/org/apache/solr/common/cloud/acl/ZkCredentialsInjector.java: ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [solr] laminelam commented on a diff in pull request #857: SOLR-16192: Add ZK credentials injectors support

laminelam commented on code in PR #857: URL: https://github.com/apache/solr/pull/857#discussion_r871323696 ## solr/solrj/src/java/org/apache/solr/common/cloud/SolrZkClient.java: ## @@ -256,18 +265,43 @@ protected ZkACLProvider createZkACLProvider() { if (!StringUtils.isEmpt

[GitHub] [solr] laminelam commented on a diff in pull request #857: SOLR-16192: Add ZK credentials injectors support

laminelam commented on code in PR #857: URL: https://github.com/apache/solr/pull/857#discussion_r870833772 ## solr/solrj/src/java/org/apache/solr/common/cloud/acl/ZkCredentialsInjector.java: ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [solr] laminelam commented on a diff in pull request #857: SOLR-16192: Add ZK credentials injectors support

laminelam commented on code in PR #857: URL: https://github.com/apache/solr/pull/857#discussion_r870833772 ## solr/solrj/src/java/org/apache/solr/common/cloud/acl/ZkCredentialsInjector.java: ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [solr] laminelam commented on a diff in pull request #857: SOLR-16192: Add ZK credentials injectors support

laminelam commented on code in PR #857: URL: https://github.com/apache/solr/pull/857#discussion_r870833772 ## solr/solrj/src/java/org/apache/solr/common/cloud/acl/ZkCredentialsInjector.java: ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [solr] laminelam commented on a diff in pull request #857: SOLR-16192: Add ZK credentials injectors support

laminelam commented on code in PR #857: URL: https://github.com/apache/solr/pull/857#discussion_r870827470 ## solr/core/src/java/org/apache/solr/cloud/ZkController.java: ## @@ -323,22 +329,29 @@ public ZkController( ZkClientConnectionStrategy strat = ZkClientConnec

[GitHub] [solr] laminelam commented on a diff in pull request #857: SOLR-16192: Add ZK credentials injectors support

laminelam commented on code in PR #857: URL: https://github.com/apache/solr/pull/857#discussion_r870826774 ## solr/solrj/src/java/org/apache/solr/common/cloud/SolrZkClient.java: ## @@ -236,16 +242,19 @@ protected ZkCredentialsProvider createZkCredentialsToAddAutomatically() {

[GitHub] [solr] laminelam commented on a diff in pull request #857: SOLR-16192: Add ZK credentials injectors support

laminelam commented on code in PR #857: URL: https://github.com/apache/solr/pull/857#discussion_r870826325 ## solr/solrj/src/java/org/apache/solr/common/cloud/SolrZkClient.java: ## @@ -256,18 +265,43 @@ protected ZkACLProvider createZkACLProvider() { if (!StringUtils.isEmpt