gus-asf commented on PR #2493:
URL: https://github.com/apache/solr/pull/2493#issuecomment-2423564458
That's an interesting observation, and it is worth noting that the strategy
here is somewhat different and not necessarily duplicative of SOLR-17158. I did
try to additionally add a short-ci
dsmiley closed pull request #2493: SOLR-17320: Added support for timeAllowed
time out in HttpShardHandler
URL: https://github.com/apache/solr/pull/2493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
dsmiley commented on PR #2493:
URL: https://github.com/apache/solr/pull/2493#issuecomment-2422993777
A warning: A colleague cherry-picked this PR to our environment and we
found that if all distributed requests time out, and if shards.tolerant=true,
that there are NullPointerExceptions. T
hiteshk25 commented on PR #2493:
URL: https://github.com/apache/solr/pull/2493#issuecomment-2310458755
> Now that I have had my head back into 17158 for a bit, I can better
articulate some differences with this PR. This PR presumes that if we hit a
failure we just want to quit as soon as po
mkhludnev commented on code in PR #2493:
URL: https://github.com/apache/solr/pull/2493#discussion_r1730916305
##
solr/core/src/test/org/apache/solr/TestTimeAllowedSearch.java:
##
Review Comment:
fyi
here is an easier approach for testing time limits
https://github.
gus-asf commented on PR #2493:
URL: https://github.com/apache/solr/pull/2493#issuecomment-2308439074
Now that I have had my head back into 17158 for a bit, I can better
articulate some differences with this PR. This PR presumes that if we hit a
failure we just want to quit as soon as possib
psalagnac commented on code in PR #2493:
URL: https://github.com/apache/solr/pull/2493#discussion_r1704360932
##
solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java:
##
@@ -211,23 +216,33 @@ public ShardResponse takeCompletedIncludingErrors() {
*/
@
dsmiley commented on code in PR #2493:
URL: https://github.com/apache/solr/pull/2493#discussion_r1698602604
##
solr/core/src/test/org/apache/solr/TestTimeAllowedSearch.java:
##
@@ -0,0 +1,104 @@
+package org.apache.solr;
+
+import com.carrotsearch.randomizedtesting.generators.Ra
dsmiley commented on PR #2493:
URL: https://github.com/apache/solr/pull/2493#issuecomment-2260631567
FYI a colleague tried this by using 2 solr nodes and hanging one and it
worked fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
gus-asf commented on code in PR #2493:
URL: https://github.com/apache/solr/pull/2493#discussion_r1698484974
##
solr/core/src/test/org/apache/solr/handler/component/TestHttpShardHandlerFactory.java:
##
@@ -154,4 +156,63 @@ public void testLiveNodesToHostUrl() {
assertThat(ho
dsmiley commented on code in PR #2493:
URL: https://github.com/apache/solr/pull/2493#discussion_r1697681291
##
solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java:
##
@@ -382,4 +397,14 @@ private boolean canShortCircuit(
public ShardHandlerFactory getSh
gus-asf commented on PR #2493:
URL: https://github.com/apache/solr/pull/2493#issuecomment-2259434643
On deck for tomorrow, finally, now that my thread safe cpu timing for
SOLR-17298 is sorted
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
12 matches
Mail list logo
