[jira] [Commented] (WW-5065) AbstractMatcher adds values to the map passed into replaceParameters

2020-04-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/WW-5065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093828#comment-17093828 ] ASF subversion and git services commented on WW-5065: - Commit 9b9b3cd264

[jira] [Commented] (WW-5070) JSONResult default root object should be set explicitly, rather than from result of ValueStack.peek()

2020-04-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/WW-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093831#comment-17093831 ] ASF subversion and git services commented on WW-5070: - Commit d960e94820

[jira] [Commented] (WW-5065) AbstractMatcher adds values to the map passed into replaceParameters

2020-04-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/WW-5065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093830#comment-17093830 ] ASF subversion and git services commented on WW-5065: - Commit 3ff0ba78c1

[jira] [Commented] (WW-5065) AbstractMatcher adds values to the map passed into replaceParameters

2020-04-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/WW-5065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093829#comment-17093829 ] ASF subversion and git services commented on WW-5065: - Commit 40c60da5a0

[jira] [Work logged] (WW-5065) AbstractMatcher adds values to the map passed into replaceParameters

2020-04-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5065?focusedWorklogId=427779&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-427779 ] ASF GitHub Bot logged work on WW-5065: -- Author: ASF GitHub Bot

[GitHub] [struts] davelnewton commented on a change in pull request #410: [WW-5065] Defines a new flag to control appending params - cherry-pick

2020-04-27 Thread GitBox
davelnewton commented on a change in pull request #410: URL: https://github.com/apache/struts/pull/410#discussion_r416066319 ## File path: core/src/main/java/com/opensymphony/xwork2/config/providers/XWorkConfigurationProvider.java ## @@ -107,6 +107,7 @@ import com.opensymphon

[jira] [Work logged] (WW-5065) AbstractMatcher adds values to the map passed into replaceParameters

2020-04-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5065?focusedWorklogId=427785&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-427785 ] ASF GitHub Bot logged work on WW-5065: -- Author: ASF GitHub Bot

[GitHub] [struts] coveralls commented on pull request #410: [WW-5065] Defines a new flag to control appending params - cherry-pick

2020-04-27 Thread GitBox
coveralls commented on pull request #410: URL: https://github.com/apache/struts/pull/410#issuecomment-620171962 [![Coverage Status](https://coveralls.io/builds/30379383/badge)](https://coveralls.io/builds/30379383) Coverage increased (+0.01%) to 49.195% when pulling **d960e94820

[GitHub] [struts] davelnewton commented on a change in pull request #410: [WW-5065] Defines a new flag to control appending params - cherry-pick

2020-04-27 Thread GitBox
davelnewton commented on a change in pull request #410: URL: https://github.com/apache/struts/pull/410#discussion_r416071496 ## File path: core/src/main/java/com/opensymphony/xwork2/config/impl/AbstractMatcher.java ## @@ -192,7 +217,7 @@ protected String convertParam(String va

[jira] [Work logged] (WW-5065) AbstractMatcher adds values to the map passed into replaceParameters

2020-04-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5065?focusedWorklogId=427786&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-427786 ] ASF GitHub Bot logged work on WW-5065: -- Author: ASF GitHub Bot

[jira] [Work logged] (WW-5065) AbstractMatcher adds values to the map passed into replaceParameters

2020-04-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5065?focusedWorklogId=427787&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-427787 ] ASF GitHub Bot logged work on WW-5065: -- Author: ASF GitHub Bot

[GitHub] [struts] lukaszlenart commented on a change in pull request #410: [WW-5065] Defines a new flag to control appending params - cherry-pick

2020-04-27 Thread GitBox
lukaszlenart commented on a change in pull request #410: URL: https://github.com/apache/struts/pull/410#discussion_r41680 ## File path: core/src/main/java/com/opensymphony/xwork2/config/providers/XWorkConfigurationProvider.java ## @@ -107,6 +107,7 @@ import com.opensympho

[jira] [Work logged] (WW-5065) AbstractMatcher adds values to the map passed into replaceParameters

2020-04-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5065?focusedWorklogId=427967&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-427967 ] ASF GitHub Bot logged work on WW-5065: -- Author: ASF GitHub Bot

[jira] [Commented] (WW-5070) JSONResult default root object should be set explicitly, rather than from result of ValueStack.peek()

2020-04-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/WW-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094159#comment-17094159 ] ASF subversion and git services commented on WW-5070: - Commit 082d289fa1

[GitHub] [struts] lukaszlenart commented on a change in pull request #410: [WW-5065] Defines a new flag to control appending params - cherry-pick

2020-04-27 Thread GitBox
lukaszlenart commented on a change in pull request #410: URL: https://github.com/apache/struts/pull/410#discussion_r416335442 ## File path: core/src/main/java/com/opensymphony/xwork2/config/impl/AbstractMatcher.java ## @@ -192,7 +217,7 @@ protected String convertParam(String v

[jira] [Work logged] (WW-5065) AbstractMatcher adds values to the map passed into replaceParameters

2020-04-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5065?focusedWorklogId=427969&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-427969 ] ASF GitHub Bot logged work on WW-5065: -- Author: ASF GitHub Bot

[GitHub] [struts] coveralls edited a comment on pull request #410: [WW-5065] Defines a new flag to control appending params - cherry-pick

2020-04-27 Thread GitBox
coveralls edited a comment on pull request #410: URL: https://github.com/apache/struts/pull/410#issuecomment-620171962 [![Coverage Status](https://coveralls.io/builds/30390878/badge)](https://coveralls.io/builds/30390878) Coverage increased (+0.01%) to 49.195% when pulling **082

[jira] [Work logged] (WW-5065) AbstractMatcher adds values to the map passed into replaceParameters

2020-04-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5065?focusedWorklogId=427976&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-427976 ] ASF GitHub Bot logged work on WW-5065: -- Author: ASF GitHub Bot

[jira] [Commented] (WW-4043) Duplicated class TestUtils

2020-04-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/WW-4043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094175#comment-17094175 ] ASF subversion and git services commented on WW-4043: - Commit 1e1443871b

[jira] [Work logged] (WW-4043) Duplicated class TestUtils

2020-04-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-4043?focusedWorklogId=427977&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-427977 ] ASF GitHub Bot logged work on WW-4043: -- Author: ASF GitHub Bot

[GitHub] [struts] lukaszlenart commented on a change in pull request #408: [WW-4043] Moves TestUtils into junit-plugin

2020-04-27 Thread GitBox
lukaszlenart commented on a change in pull request #408: URL: https://github.com/apache/struts/pull/408#discussion_r416344768 ## File path: plugins/junit/src/main/java/org/apache/struts2/util/TestUtils.java ## @@ -85,13 +79,13 @@ public static boolean compare(URL url, String te

[GitHub] [struts] lukaszlenart commented on a change in pull request #397: [WW-4789] [WW-3788] ActionContext refactoring

2020-04-27 Thread GitBox
lukaszlenart commented on a change in pull request #397: URL: https://github.com/apache/struts/pull/397#discussion_r416347889 ## File path: core/src/main/java/org/apache/struts2/ServletActionContext.java ## @@ -26,23 +26,18 @@ import javax.servlet.http.HttpServletRequest; imp

[GitHub] [struts] lukaszlenart commented on a change in pull request #397: [WW-4789] [WW-3788] ActionContext refactoring

2020-04-27 Thread GitBox
lukaszlenart commented on a change in pull request #397: URL: https://github.com/apache/struts/pull/397#discussion_r416348145 ## File path: core/src/main/java/org/apache/struts2/ServletActionContext.java ## @@ -26,23 +26,18 @@ import javax.servlet.http.HttpServletRequest; imp

[jira] [Work logged] (WW-4789) ActionContext should be immutable

2020-04-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-4789?focusedWorklogId=427980&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-427980 ] ASF GitHub Bot logged work on WW-4789: -- Author: ASF GitHub Bot

[jira] [Work logged] (WW-4789) ActionContext should be immutable

2020-04-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-4789?focusedWorklogId=427981&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-427981 ] ASF GitHub Bot logged work on WW-4789: -- Author: ASF GitHub Bot

[GitHub] [struts] lukaszlenart commented on a change in pull request #397: [WW-4789] [WW-3788] ActionContext refactoring

2020-04-27 Thread GitBox
lukaszlenart commented on a change in pull request #397: URL: https://github.com/apache/struts/pull/397#discussion_r416349031 ## File path: core/src/main/java/org/apache/struts2/interceptor/ScopeInterceptor.java ## @@ -262,7 +262,7 @@ static void unlock(Object o) { }

[jira] [Work logged] (WW-4789) ActionContext should be immutable

2020-04-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-4789?focusedWorklogId=427983&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-427983 ] ASF GitHub Bot logged work on WW-4789: -- Author: ASF GitHub Bot

[GitHub] [struts] lukaszlenart commented on a change in pull request #397: [WW-4789] [WW-3788] ActionContext refactoring

2020-04-27 Thread GitBox
lukaszlenart commented on a change in pull request #397: URL: https://github.com/apache/struts/pull/397#discussion_r416350023 ## File path: core/src/main/java/org/apache/struts2/interceptor/ScopeInterceptor.java ## @@ -271,18 +271,18 @@ protected void after(ActionInvocation in

[jira] [Work logged] (WW-4789) ActionContext should be immutable

2020-04-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-4789?focusedWorklogId=427984&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-427984 ] ASF GitHub Bot logged work on WW-4789: -- Author: ASF GitHub Bot

[GitHub] [struts] lukaszlenart commented on a change in pull request #397: [WW-4789] [WW-3788] ActionContext refactoring

2020-04-27 Thread GitBox
lukaszlenart commented on a change in pull request #397: URL: https://github.com/apache/struts/pull/397#discussion_r416350761 ## File path: core/src/main/java/org/apache/struts2/result/PlainTextResult.java ## @@ -47,7 +47,7 @@ * response type (eg. Content-Type=text/plain; ch

[jira] [Work logged] (WW-4789) ActionContext should be immutable

2020-04-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-4789?focusedWorklogId=427985&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-427985 ] ASF GitHub Bot logged work on WW-4789: -- Author: ASF GitHub Bot

[GitHub] [struts] coveralls edited a comment on pull request #408: [WW-4043] Moves TestUtils into junit-plugin

2020-04-27 Thread GitBox
coveralls edited a comment on pull request #408: URL: https://github.com/apache/struts/pull/408#issuecomment-619503812 [![Coverage Status](https://coveralls.io/builds/30391170/badge)](https://coveralls.io/builds/30391170) Coverage decreased (-0.02%) to 49.164% when pulling **1e1

[jira] [Work logged] (WW-4043) Duplicated class TestUtils

2020-04-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-4043?focusedWorklogId=427987&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-427987 ] ASF GitHub Bot logged work on WW-4043: -- Author: ASF GitHub Bot

[GitHub] [struts] lukaszlenart commented on a change in pull request #397: [WW-4789] [WW-3788] ActionContext refactoring

2020-04-27 Thread GitBox
lukaszlenart commented on a change in pull request #397: URL: https://github.com/apache/struts/pull/397#discussion_r416353490 ## File path: core/src/main/resources/struts-default.xml ## @@ -68,7 +68,6 @@ https://github.com/apache/struts/pull/371/files#diff-710b29900cea21e8

[jira] [Work logged] (WW-4789) ActionContext should be immutable

2020-04-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-4789?focusedWorklogId=427990&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-427990 ] ASF GitHub Bot logged work on WW-4789: -- Author: ASF GitHub Bot

[jira] [Commented] (WW-4789) ActionContext should be immutable

2020-04-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/WW-4789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094183#comment-17094183 ] ASF subversion and git services commented on WW-4789: - Commit a504a16eae

[jira] [Commented] (WW-3788) Convert ServletActionContext to be more as ActionContext

2020-04-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/WW-3788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094184#comment-17094184 ] ASF subversion and git services commented on WW-3788: - Commit a504a16eae

[jira] [Commented] (WW-4789) ActionContext should be immutable

2020-04-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/WW-4789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094185#comment-17094185 ] ASF subversion and git services commented on WW-4789: - Commit 6c76275af6

[jira] [Commented] (WW-3788) Convert ServletActionContext to be more as ActionContext

2020-04-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/WW-3788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094186#comment-17094186 ] ASF subversion and git services commented on WW-3788: - Commit 6c76275af6

[jira] [Commented] (WW-4789) ActionContext should be immutable

2020-04-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/WW-4789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094190#comment-17094190 ] ASF subversion and git services commented on WW-4789: - Commit 0cf39a97f0

[jira] [Commented] (WW-3788) Convert ServletActionContext to be more as ActionContext

2020-04-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/WW-3788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094191#comment-17094191 ] ASF subversion and git services commented on WW-3788: - Commit 0cf39a97f0