ows IOException {
act=target;
if (act>last) act=NO_MORE_DOCS;
return doc = act;
}
}
-----
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
_
From: Shai Erera [mailto:ser...@gmail.com]
Sent: Thursday, July 16, 2009 5:04
problem.
If we change the default, keep in mind to reopen SOLR-940, as it assumes to
have constant score mode per default and solr's default precStep is 8 ->
*bang*. Maybe the solr people should fix this and still explicitely set the
mode for all range queries.
-----
Uwe Schindler
H.-H.-Mei
The problem is not the TokenStream API, it is 1644. The tests pass with our
patch from yesterday. Maybe the problem is somehow the auto rewrite method.
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> -Original Message-
>
I have some additional small improvements for 1644, I commit shortly. It is
mainly the numeric range query tests and the default rewrite method for NRQ.
There is also missing a deprecation for MTQ(Term) ctor.
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u
Why do we need this class? There is already a static final empty iterator
available in DocIdSetIterator.EMPTY_DOCIDSET_ITERATOR (or something like
that name)?
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> From: mikemcc...@apache.
Right, and you can simply get an iterator from it.
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> -Original Message-
> From: Robert Muir [mailto:rcm...@gmail.com]
> Sent: Monday, July 27, 2009 12:24 PM
>
I don't understand that. If you need an empty iterator, call:
DocIdSet.EMPTY_DOCIDSET.iterator()
- bingo. This is always empty.
Uwe
-----
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
<http://www.thetaphi.de> http://www.thetaphi.de
eMail: u...@thetaphi.de
__
EmptyDocIdSetIterator.getInstance();
}
};
By the way, this iterator is not conformant to the spec, which says, before
calling nextDoc() it should return -1!
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
_
From: Shai Erera [mailto:ser
(implements the protected readResolve()). Example for serializable
singletons are the default parsers in FieldCache.
Uwe
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> -Original Message-
> From: Chris Hos
test run in test-tag? What can be changed in build.xml to do this?
I have no clover installed locally, so I cannot try this out.
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> -Original Message-
> From: Michael McCandless [mail
correctly related).
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
<http://www.thetaphi.de> http://www.thetaphi.de
eMail: u...@thetaphi.de
_
From: Mark Miller [mailto:markrmil...@gmail.com]
Sent: Wednesday, July 29, 2009 6:24 PM
To: java-dev@lucene.apache.org
Subject: backwa
common-build.xml, it could
be the revision number. So it would check out ./branches/
lucene_2_4_back_compat_tests with the revision given in common-build.
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
<http://www.thetaphi.de> http://www.thetaphi.de
eMail: u...@thetaphi.de
_
> > My suggestion was to write the build script in a way that it checks out
> the
> > branch with the same revision number as the current base dir (trunk).
>
> I think this would work, as long as we always commit top-level and
> back-compat tag in one transaction (commit)?
>
> (And, even if we do
e backwards tests and nothing else. I
install clover locally and try out. I will then open an issue.
Uwe
> On Wed, Jul 29, 2009 at 3:10 AM, Uwe Schindler wrote:
> > This seems to be fixed now. But there is something completely wrong with
> > clover:
> >
> > If you look
> > I found out that clover-setup supports a special advanced tag
> > "":
> > is an Ant fileset which should only be used if Clover's
> > default test detection is not adequate. Clover's default test detection
> > algorithm is used to distinguish test cases if this element is omitted.
>
> That so
> >> > I found out that clover-setup supports a special advanced tag
> >> > "":
> >> > is an Ant fileset which should only be used if Clover's
> >> > default test detection is not adequate. Clover's default test
> detection
> >> > algorithm is used to distinguish test cases if this element is
> om
tly"
target, which is a relict from the time before Hudson and replace by
"package" in the first run and to "ant test" for the clover enabled version.
The build would run two times faster.
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail
Welcome Robert! Good to have you in the team!
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> -Original Message-
> From: Robert Muir [mailto:rcm...@gmail.com]
> Sent: Monday, August 03, 2009 9:51 PM
>
ecial field-specific things like that.
-----
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
_
From: Adriano Crestani [mailto:adrianocrest...@gmail.com]
Sent: Monday, August 03, 2009 10:00 PM
To: java-dev@lucene.apache.org
Subjec
port: 25
Uwe
-----
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
?
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> -Original Message-
> From: Mark Miller [mailto:markrmil...@gmail.com]
> Sent: Thursday, August 06, 2009 4:14 PM
> To: java-dev@lucene.apache.org
> Subject: Issue with Solr Toke
problem at all for the new API. It
would even work with forcefully cloning Tokens inside CachingTokenFilter.
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> -Original Message-
> From: Robert Muir [mailto:rcm...@gmail.com]
> I have seen ur mail, but this bug should not be related to the new Token
> API, it should occur with old API, too.
Maybe the problem is an unrelated change:
https://issues.apache.org/jira/browse/LUCENE-1762
This issue changed the default length of the termBuffer in
Token/TermAttributeImpl. Beca
Thanks, we are always here to help :-)
> Test passes with this patch - thanks a lot Robert ! I was going to ask
> you to create a solr issue, but I see you already have, thanks!
>
> No need to create a test I think - put in the new Lucene jars and it
> fails, so likely thats good enough. Though
By the way: o.a.l.util.ArrayUtil contains a hashCode impl for char arrays.
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> -Original Message-
> From: mikemcc...@apache.org [mailto:mikemcc...@apache.org]
> Sent: Friday,
Yes! We had this problem also with the analyzers contrib missing the stop
word files :-)
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> -Original Message-
> From: Michael McCandless [mailto:luc...@mikemccandless.com]
rce.
DefaultAttributeFactory.getClassForInterface()).
I could do some tests about that and supply a patch. I was thinking about
that but throwed it away (as it needs some synchronization on the cache Map
which may also overweigh).
-----
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail
Also AttributeSource.addAttributeImpl() has such a cache which helped very
much. This isMethodOverridden is the only place, where no cache is used.
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> -Original Message-
> Fro
I already started to prepare a patch... Let's open an issue! You could try
it out with your corpus and post numbers.
There are some additional slowdowns with the new API if you do not reuse
TokenStreams, as the setup of the Attribute maps is an additional small
cost.
-----
Uwe Schindler
I already removed the unmodifiable iterator, so one new instance is removed
(see the JIRA issue). But you are right, the CharTokenizer should only clear
the TermAttribute, as it is only using this attribute.
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u
Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> -Original Message-
> From: Uwe Schindler [mailto:u...@thetaphi.de]
> Sent: Monday, August 10, 2009 6:44 PM
> To: java-dev@lucene.apache.org; yo...@lucidimagination.com
> Subject:
> On Mon, Aug 10, 2009 at 12:44 PM, Uwe Schindler wrote:
> >the CharTokenizer should only clear the TermAttribute, as it is only
> using this attribute.
I changed this in the latest patch for
https://issues.apache.org/jira/browse/LUCENE-1796
> It's certainly not clear
was
speed up a little bit by removing the unmodifiable wrapper). This can be
solved by using an additional ArrayList in AttributeSource that gets all
AttributeImpl instances, but this would bring an additional initialization
cost() on creating the Tokenizer chain.
-
Uwe Schindler
H.-H.-Meier
Hi Grant,
> I have serious doubts about releasing this new API until these
> performance issues are resolved and better proven out from a usability
> standpoint.
I think LUCENE-1796 has fixed the performance problems, which was caused by
a missing reflection-cache needed for bw compatibility. I h
all streams/filters would
implement only the old API, the bw-delegation would only be used for the
incrementToken() calls from DocInverter.
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> -Original Message-
> From: Michael B
).
A lot of code in next()/next(Toke)/incrementToken() default impls uses final
variables, so the delegation can simply be removed by the compiler. :-)
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> -Original Message-
>
> >> I have serious doubts about releasing this new API until these
> >> performance issues are resolved and better proven out from a
> >> usability
> >> standpoint.
> >
> > I think LUCENE-1796 has fixed the performance problems, which was
> > caused by
> > a missing reflection-cache needed for bw
). Readers are
only known to Tokenizers.
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> -Original Message-
> From: ysee...@gmail.com [mailto:ysee...@gmail.com] On Behalf Of Yonik
> Seeley
> Sent: Tuesday, August 11, 2
omplicated that
described here, but it gives a possible usage of the new API: Annotate
tokens with field identifiers to e.g. automatically put the title of a
document in a title field and the authors in another one and so on.
I hope somebody understood, what we are doing here :-)
-
Uwe
> Then how do you notify the other filters that they should reset their
> state?
> TokenStream.reset()? The javadoc specifies that it's actually used
> for something else - but perhaps it can be reused for this purpose?
TokenStream.reset() is always called before the first incrementToken call by
> Just as note related to this discussion:
>
> TokenFilter#reset says:
>
> /** Reset the filter as well as the input TokenStream. */
>
> However, CachingTokenFilter does not reset the input TokenStream.
That's a bug :-) but it is not a problem, as CachingTokenFilter will not
call the input fi
Yes, we should not deprecate the old one!
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> -Original Message-
> From: Grant Ingersoll [mailto:gsing...@apache.org]
> Sent: Tuesday, August 11, 2009 8:32 PM
>
FieldNameAttribute) and the Document/Indexer can automatically
create the fields?
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
_
From: DM Smith [mailto:dmsmith...@gmail.com]
Sent: Tuesday, August 11, 2009 5:54 PM
To: java-dev
> release branch. Here is whats holding us up:
>
> LUCENE-1768 NumericRange support for new query parser
>
> This issue looks troublesome. Anyone know if its likely to be resolved
> soon? I see that Yonik has suggested pushing it till the next release.
> Because the new QueryParser is not yet sla
> 0 issues! Congrats everyone. 2.9 was quite a beast.
>
> So looks like we should get a few things in order.
>
> 1. Anyone dying to be release manager? I think I could do it, but I'm
> kind of pressed for time ...
>
> 2. Lets start crawling all over this release - bugs/javadoc/packaging etc.
>
It would *not* break apps without generics, if the "upper" type is the same
(which is easily fulfilled by my example with the AttributeSource). The
whole 1.5 Java Collection API uses generics and 1.4 programs still run.
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 B
Not really, there is no reason fort hat in my opinion. And Token.copyTo()
does not do this, but should then!
I think, remove it. Strings can always by kept, as they are final and
unmodifiable.
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
Just read the tons of discussions/howtos on the web about the whole type
erasure.
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
_
From: Grant Ingersoll [mailto:gsing...@apache.org]
Sent: Friday, August 21, 2009
ttributeImpl.java
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> -Original Message-
> From: Uwe Schindler [mailto:u...@thetaphi.de]
> Sent: Friday, August 21, 2009 12:46 AM
> To: java-dev@lucene.apache.org
> Subject: RE: TypeAttribu
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
_
From: Tim Smith [mailto:tsm...@attivio.com]
Sent: Monday, August 24, 2009 2:19 PM
To: java-dev@lucene.apache.org
Subject: Re: Finishing Lucene 2.9
Here's my vote on the topic of 2
> You make a great point. If we jump to 3.0, what do we do about the
> deprecation drop?
>
> If we drop them now, it would be quite a fun upgrade experience :)
My nice TokenStream backwards layer will gone? Oh no :-) - Just kidding.
> Tim Smith wrote:
> > Here's my vote on the topic of 2.9 vs 3
Is the nightly target really run by Hudson? From the logs it looks that
Hudson is calling the ant targets directly and not only nightly.
I would do it the following way: reconfigure Hudson to pass a -Dnightly=true
when calling ant.
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http
.
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> -Original Message-
> From: Simon Willnauer [mailto:simon.willna...@googlemail.com]
> Sent: Tuesday, August 25, 2009 10:57 PM
> To: java-dev@lucene.apache.org
> S
a
super of TokenStreams, all TokenStreams know AttributeSource as an inner
class. This is why I left it without. If you want to do it that way, you
have to import AttributeSource everywhere. So just leave {...@link
AttributeFactory}.
Uwe
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
ifferent in Java 1.6, but with 1.5 it works.
> Uwe Schindler wrote:
> > This produces tons of errors now:
> >
> > [javadoc]
> > C:\Projects\lucene\trunk-
> full\src\java\org\apache\lucene\analysis\standard\S
> > tandardTokenizer.java:147: warning - Tag @link: r
o you have this, too. I wanted to commit the in missing LUCENE-1826
AttributeSource/AttributeFactory ctors for NumericTokenStream.
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> -Original Message-
> From: Mark Miller
> > Nevertheless: I get the following error when committing:
> > Server sent unexpected return value (502 Proxy Error) in response to
> > MKACTIVITY
> > request for '/repos/asf/!svn/act/5e1f731c-f7e6-214d-bc2b-00b7b43831ad'
> >
> > Do you have this, too. I wanted to commit the in missing LUCENE-182
Even the old RangeQuery does it. Only the new class TermRangeQuery uses
constant score (and the also deprecated ConstantScoreRangeQuery).
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> -Original Message-
> From: M
So it is possible by editing this script to pass additional options with -D
to some of the ANT commands.
Thanks for the insight, that also helps me very much with the clover update.
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
Javadoc should normally only contain public methods/classes. Ony developers
maybe want to have javadocs with all classes.
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> -Original Message-
> From: Mark Miller [mailto:ma
, if it can reset() (better name would be
rewind) the TokenStream. In this case you could simply provide another
TokenFilter subclass with isCachingTokens=true and random access to the
AttributeSource.States.
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u
> Unless someone objects before then, I'm going to include LUCENE-1871 in
> RC2.
+1
-
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
I missed no commit mails the last days. Maybe they were declared as spam by
your mail filter software?
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> -Original Message-
> From: George Aroush [mailto:geo...@aroush.net]
n the java.lang package (such as String), or other
API you feel would be well-known.
--
The general formatting of class names could be solved by using {...@link ...}
for foreign ones and {...@code ...} for the class name itself.
-----
Uwe Schindler
guide from sun notes), that are somehow pointing to the exact same class the
description is about (in the class description).
I am a real fan of linking everything, so links between methods is very
important!
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u
What to do with LUCENE-1877 ? If it goes into 2.9, we must have another RC.
So you have some more days.
I would do the RM, but I have no key to do signatures.
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> -Original Mess
for it (abstract FSLockFactory as superclass for Simple and
Native)
Uwe
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> -Original Message-
> From: Mark Miller [mailto:markrmil...@gmail.com]
> Sent: Wednesday, September 02,
Hi Shay,
>I was going over and playing with Lucene 2.9 and came around something
> strange that I think might be a bug. In CachingTokenFilter#fillCache it
> seems like captureState is not called on input and instead is called on
> CachingTokenFilter.
This is not a bug and correct behaviour. I
+1
The locking changes are done and seem to work even in production.
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> -Original Message-
> From: Mark Miller [mailto:markrmil...@gmail.com]
> Sent: Friday, September 04, 2
You are right, I will fix it.
The simpliest is to check if (termlength!=o.thermLength) before the
for-loop. The code is then equals to Token.java (I think this was a
copy'n'paste bug).
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@t
I fixed it! Thank you very much!!!
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
_
From: Uwe Schindler [mailto:u...@thetaphi.de]
Sent: Tuesday, September 08, 2009 9:47 PM
To: java-dev@lucene.apache.org
Subject: RE: Lucene 2.9
Why did you remove LUCENE-1901 again? I committed this short time ago.
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> -Original Message-
> From: markrmil...@apache.org [mailto:markrmil...@apache.org]
> Sent: Wednesday,
Yes, but we discussed yesterday, that the involved persons developing the
patches should get some credit... This is why I added this change to the
log.
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> -Original Message-
>
How about that patch, this was my idea yesterday, but I didn't want to start
a new changes.txt format addition like this additional sentence in the
entry?
-----
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> -Original Message
Oh!
I am sorry, that's my fault :-( Hope we can fix it soon, its only one line.
Just copy this ctor from NativeFSLockFactory.
Uwe
-----
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> -Original Message-
> From:
://code.google.com/p/jaql.
Uwe Schindler, Lucene 2.9 Developments: Numeric Search, Per-Segment- and
Near-Real-Time Search, new TokenStream API: Uwe Schindler presents some new
additions to Lucene 2.9. In the first half he will talk about fast numerical
and date range queries (NumericRangeQuery, formerly
Hi again,
By the way, if somebody of the other involved developers want to provide me
some PPT Slides about the other new features in Lucene 2.9 (NRT, future
Flexible Indexing), I would be happy!
Uwe
> Uwe Schindler, Lucene 2.9 Developments: Numeric Search, Per-Segment- and
> Near-Rea
Yes, correct, I will commit!
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> -Original Message-
> From: Robert Muir [mailto:rcm...@gmail.com]
> Sent: Thursday, September 10, 2009 1:58 PM
> To: java-dev@lucene.apache.o
See https://issues.apache.org/jira/browse/LUCENE-1753
In general, if you want to add functionality plug another filter into the
chain. At least the implementations should be final (next/incrementToken).
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u
I forget, this known as "Decorator Pattern":
http://en.wikipedia.org/wiki/Decorator_pattern
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> -Original Message-----
> From: Uwe Schindler [mailto:u...@thetaphi.de]
and we do not need to add additional ctors in subclasses.
As this instanceof check is always done in CharReader.get() why not remove
ctor(CharStream) and reset(CharStream) completely?
Any thoughts?
I would like to fix this somehow before RC4, I', sorry :(
Uwe
-----
Uwe Schindler
H.-H.-
I tested the attached patch, all tests still compile and work as exspected
(as CharStream extends Reader).
I think I should open an issue?
Uwe
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> -Original Message-
> Fro
I do not know, how this could affect Solr, but it could be the case.
Currently most Tokenizers do not use CharStreams at all. After committing
LUCENE-1906, I think there is also some additional work in Solr's custom
Tokenizers needed (changed the correctOffset method).
-----
Uwe Schindler
I am finished win LUCENE-1906!
I also opened an issue for Solr: Maybe there are changes needed for
correctOffset after 2.9RC4. I hope, this time we find possible traps/errors
*before* releasing RC4.
Uwe
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u
> The only thing I can do is add a filter before the LowerCaseFilter that
> would pass all the non-word tokens to the next filter, but it seems really
> complicated for a case where a simple extend would do the job.
This is the way to go!
Uwe
I for myself feel comfortable.
It would be good to drop the JARs into Solr before releasing. I did it and
it seemed to work, but I only ran the tests, no real server.
Uwe
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> -Origi
I think this one should be fixed now? Have you tested?
Uwe
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> -Original Message-
> From: ysee...@gmail.com [mailto:ysee...@gmail.com] On Behalf Of Yonik
> Seeley
>
the number as a
conventional string (the special trie encoding is only used for *indexing*
not *storing*). If you call getField() it returns a standard Field containg
the number as String.
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
conventional Fieldable instance where the numeric values are returned as
Strings (according to toString(value) of the used data type).
(this o.a.l.document.Fieldable is always a o.a.l.document.Field)
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> On Fri, Sep 11, 2009 at 4:45 PM, Uwe Schindler wrote:
> > By the way: This is documented:
> > http://hudson.zones.apache.org/hudson/job/Lucene-
> trunk/javadoc/core/org/apac
> > he/lucene/document/NumericField.html
> >
> > NOTE: This class is only used
+1 for calling a vote. I will commit the jdocs updates in LUCENE-1872 soon.
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
_
From: Doron Cohen [mailto:cdor...@gmail.com]
Sent: Tuesday, September 15, 2009 6:22 AM
To: java-dev
So lets commit the last javadocs updates and create the final artifacts and
vote for them!
Uwe
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> -Original Message-
> From: Mark Miller [mailto:markrmil...@gmail.com]
> Sent
OpenBitSet was the first candidate for this. I reviewed all DocIdSets in
core and contrib for cacheable. There were some of them.
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
<http://www.thetaphi.de> http://www.thetaphi.de
eMail: u...@thetaphi.de
_
From: Paul E
I did not look into it thoroughly, but the lucene-core.jar works for me.
Also changes.txt ad JavaDoc look OK. I will check everything later!
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> -Original Message-
> From: Mark
and I can start with my first Java 5 patch :-)
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> -Original Message-
> From: Mark Miller [mailto:markrmil...@gmail.com]
> Sent: Saturday, September 19, 2009 1:52 AM
>
> I've been reading through CHANGES.txt and had a few questions/comments:
>
> 1. The attribute entry still says Token is deprecated. I can fix, but
> isn't a huge deal.
Another one? +1 for changing.
> 2. L-1658 talks about changing FSDirectory for SimpleDirectory and
> adds a static open() meth
eparate classes:
> @@ -286,10 +282,13 @@
> * LUCENE-1636: Make TokenFilter.input final so it's set only
> once. (Wouter Heijke, Uwe Schindler via Mike McCandless).
Uwe :-)
-
To unsubscribe, e-mail: java-dev-unsu
This was the answer about your first commit (merge FSDir stuff). At the time
I posted the answer, you fixed the deprecated Token thing :-)
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> -Original Message-
> From: Mark
> Oddly though, while all of the Maven hashes are in a file thats 32bytes,
> when I save this hash, its 33bytes.
>
> Any thoughts?
Line feed?
-
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional comma
I thought, we are already in the voting phase?
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> -Original Message-
> From: Mark Miller [mailto:markrmil...@gmail.com]
> Sent: Tuesday, September 22, 2009 1:52 AM
>
201 - 300 of 2499 matches
Mail list logo
