[
https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12845101#action_12845101
]
Uwe Schindler commented on LUCENE-2037:
---
Committed the assertion patch revision: 922
[
https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839191#action_12839191
]
Uwe Schindler commented on LUCENE-2037:
---
Erick,
thats already fixed in trunk with m
[
https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839126#action_12839126
]
Erick Erickson commented on LUCENE-2037:
Uwe:
You were asking about getName in Lu
I won't be able to look at this till tonight, I'll see what I can see.
On Fri, Feb 26, 2010 at 9:02 AM, Uwe Schindler (JIRA) wrote:
>
>[
> https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838872#action_
[
https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838872#action_12838872
]
Uwe Schindler commented on LUCENE-2037:
---
Committed revision: 916685
> Allow Junit4
[
https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838736#action_12838736
]
Uwe Schindler commented on LUCENE-2037:
---
I just committed this.
One quetsion: In JU
[
https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786460#action_12786460
]
Michael McCandless commented on LUCENE-2037:
OK patch looks good, thanks Erick
[
https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786367#action_12786367
]
Michael McCandless commented on LUCENE-2037:
Thanks Kay Kay. Erick, once you'
[
https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785811#action_12785811
]
Kay Kay commented on LUCENE-2037:
-
|Ahh thanks for the reminder - I can take this
I generified the searches/function files in patch 2037. I don't really think
there's a conflict, just commit my patch and have at generifying the rest.
I know, I know. I did two things at once. So sue me. Honest, I'll try not to
do this very often ...
Mike:
You really want to to the generify the
[
https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785479#action_12785479
]
Michael McCandless commented on LUCENE-2037:
bq. but there is another patch -
[
https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785448#action_12785448
]
Kay Kay commented on LUCENE-2037:
-
+1 w.r.t JUnit 4 .
Unrelated to this - but there is an
[
https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785408#action_12785408
]
Michael McCandless commented on LUCENE-2037:
Anyone have any concerns upgradin
[
https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12783442#action_12783442
]
Erick Erickson commented on LUCENE-2037:
Darn it! I'll get the comments right some
[
https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12782916#action_12782916
]
Erick Erickson commented on LUCENE-2037:
Hold off on this patch until I get a chan
[
https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12782823#action_12782823
]
Michael McCandless commented on LUCENE-2037:
Can we, for this issue, focus on
[
https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12780388#action_12780388
]
Robert Muir commented on LUCENE-2037:
-
{quote}
It's a worthwhile question whether we r
[
https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12780368#action_12780368
]
Erick Erickson commented on LUCENE-2037:
Well, last night I changed LocalizedTestC
[
https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779538#action_12779538
]
Robert Muir commented on LUCENE-2037:
-
Uwe, can you elaborate more on how the Version
[
https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779535#action_12779535
]
Uwe Schindler commented on LUCENE-2037:
---
We have a second place (I did not implement
[
https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779530#action_12779530
]
Erick Erickson commented on LUCENE-2037:
{quote}
Yes, I do feel we should keep Loc
[
https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779492#action_12779492
]
Erick Erickson commented on LUCENE-2037:
Frankly, I don't see how that would work
[
https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779491#action_12779491
]
Erick Erickson commented on LUCENE-2037:
I think you're mis-reading this. This is
[
https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779481#action_12779481
]
Robert Muir commented on LUCENE-2037:
-
bq. I already made a propsal for LocalizedTestC
[
https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779465#action_12779465
]
Uwe Schindler commented on LUCENE-2037:
---
I already made a propsal for LocalizedTestC
[
https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779453#action_12779453
]
Robert Muir commented on LUCENE-2037:
-
{quote}
I was thinking more about TestQueryPars
[
https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779449#action_12779449
]
Erick Erickson commented on LUCENE-2037:
I was thinking more about TestQueryParser
[
https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779262#action_12779262
]
Robert Muir commented on LUCENE-2037:
-
{quote}
I don't think it's worth trying to refa
[
https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779251#action_12779251
]
Erick Erickson commented on LUCENE-2037:
Well, it all depend on how you feel about
[
https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778101#action_12778101
]
Robert Muir commented on LUCENE-2037:
-
Is there some way to use Junit4 parameterized t
Good suggestions, it's really helpful to have someone intimately familiar
with the code suggest the next direction. I didn't want to go too far afield
for the proof-of-concept, I mostly wanted to have a place to start.
LuceneTestCaseJ4 should be useful both as a template and a base to build
with. I
[
https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778086#action_12778086
]
Uwe Schindler commented on LUCENE-2037:
---
One thing that would also be good:
We have
32 matches
Mail list logo
