On Thu, 14 Dec 2023 22:17:54 GMT, Alisen Chung wrote:
>> Translation drop for JDK22 RDP1
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> removed quotes around Ablehnen
The java.xml changes look good.
-
Marked
On Thu, 14 Dec 2023 19:01:22 GMT, Joe Wang wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> removed quotes around Ablehnen
>
> src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_de.pr
> Translation drop for JDK22 RDP1
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
removed quotes around Ablehnen
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17096/files
- new: https://git.openjdk.org/jdk/pull/
On Wed, 13 Dec 2023 22:12:48 GMT, Alisen Chung wrote:
> Translation drop for JDK22 RDP1
mach5 looks green
-
PR Comment: https://git.openjdk.org/jdk/pull/17096#issuecomment-1856733375
On Thu, 14 Dec 2023 05:46:01 GMT, David Holmes wrote:
> Updated the version to 23-ea and year to 2024.
>
> This initial generation also picks up the unpublished changes from:
>
> - [JDK-8302233](https://bugs.openjdk.org/browse/JDK-8302233) (keytool &
> jarsigner)
> - [JDK-8290702](https://bugs
On Wed, 13 Dec 2023 22:12:48 GMT, Alisen Chung wrote:
> Translation drop for JDK22 RDP1
Marked as reviewed by asemenyuk (Reviewer).
jpackage changes look good
-
PR Review: https://git.openjdk.org/jdk/pull/17096#pullrequestreview-1782697421
PR Comment: https://git.openjdk.org/jdk/p
On Wed, 13 Dec 2023 22:12:48 GMT, Alisen Chung wrote:
> Translation drop for JDK22 RDP1
All around LGTM. From a skim I don't see any of the typical l10n related file
mode issues, line ending issues, or values that should not be changed (like
_WixLocalization Culture_). Might be worth filing a
On Wed, 13 Dec 2023 22:12:48 GMT, Alisen Chung wrote:
> Translation drop for JDK22 RDP1
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets_ja.properties
line 111:
> 109: doclet.Factory=ファクトリ:
> 110: doclet.UnknownTag=不明なタグ。未登録のカスタム・タグ?
> 111: doclet.UnknownTag
On Wed, 13 Dec 2023 22:12:48 GMT, Alisen Chung wrote:
> Translation drop for JDK22 RDP1
src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_de.properties
line 331:
> 329:
> 330: # Implementation Property DTD
> 331: JDK_DTD_DENY = JAXP00010008: DOCTYPE is
On Mon, 11 Dec 2023 16:36:09 GMT, Hannes Wallnöfer wrote:
> This is a rather big change to update the structural navigation in API
> documentation generated by JavaDoc. It adds a table of contents for the
> current page to module, package, and class documentation, and replaces the
> old sub-na
This is a rather big change to update the structural navigation in API
documentation generated by JavaDoc. It adds a table of contents for the current
page to module, package, and class documentation, and replaces the old
sub-navigation bar with a breadcrumb-style links in those pages. The table
On Mon, 11 Dec 2023 16:36:09 GMT, Hannes Wallnöfer wrote:
> This is a rather big change to update the structural navigation in API
> documentation generated by JavaDoc. It adds a table of contents for the
> current page to module, package, and class documentation, and replaces the
> old sub-na
On Thu, 14 Dec 2023 11:42:39 GMT, Adam Sotona wrote:
> I don't have an access to any environment to test it, so I prefer the same
> solution as already applied in several similar situations across the JDK
> tests.
If you really wanted, you could test it locally, running `jtreg` directly (not
> Updated the version to 23-ea and year to 2024.
>
> This initial generation also picks up the unpublished changes from:
>
> - [JDK-8302233](https://bugs.openjdk.org/browse/JDK-8302233) (keytool &
> jarsigner)
> - [JDK-8290702](https://bugs.openjdk.org/browse/JDK-8290702) (javadoc) (JDK
> 23 ba
On Thu, 14 Dec 2023 09:01:17 GMT, Alan Bateman wrote:
> Initially I wondered if JDK-8309981 should be separated but include keeps
> things in sync so I think okay.
Thanks for the review @AlanBateman .
Yeah I was in two minds there myself. I started fixing
[JDK-8309981](https://bugs.openjdk.or
On Thu, 14 Dec 2023 09:17:05 GMT, Pavel Rappo wrote:
> Thanks for doing this, David. I only note that the changes for JDK-8321384
> were published in [JDK-8308715](https://bugs.openjdk.org/browse/JDK-8308715),
> which was integrated in the mainline before JDK 22 RDP 1. So they are already
> pr
8288989: Make tests not depend on the source code
-
Commit messages:
- Backport 2838a916ab98cb0152f8b1e3f96eccca198af5e9
Changes: https://git.openjdk.org/jdk22/pull/13/files
Webrev: https://webrevs.openjdk.org/?repo=jdk22&pr=13&range=00
Issue: https://bugs.openjdk.org/browse/JDK-
On Wed, 13 Dec 2023 16:54:33 GMT, Jonathan Gibbons wrote:
> > just curious: in what conditions the tests will be executed in a
> > source-less test environment? and in any case isn't it preferable to let
> > the test fail so that the user knows that it failed?
>
> Some external users execute t
On Thu, 2 Nov 2023 09:02:43 GMT, Adam Sotona wrote:
> Two langtool tests depend on the JDK source tree presence.
> This patch skips the tests execution in a source-less test environment.
>
> Please review.
>
> Thanks,
> Adam
This pull request has now been integrated.
Changeset: 2838a916
Auth
On Thu, 2 Nov 2023 09:02:43 GMT, Adam Sotona wrote:
> Two langtool tests depend on the JDK source tree presence.
> This patch skips the tests execution in a source-less test environment.
>
> Please review.
>
> Thanks,
> Adam
retitled as suggested
-
PR Comment: https://git.openjd
On Wed, 13 Dec 2023 22:12:48 GMT, Alisen Chung wrote:
> Translation drop for JDK22 RDP1
Marked as reviewed by cstein (Committer).
German translations read OK.
Nit: some layouts get lost in translated files - it would be great to have
similar usage of `\n` and `` in the translated files.
For
On Thu, 2 Nov 2023 09:02:43 GMT, Adam Sotona wrote:
> Two langtool tests depend on the JDK source tree presence.
> This patch skips the tests execution in a source-less test environment.
>
> Please review.
>
> Thanks,
> Adam
Marked as reviewed by mcimadamore (Reviewer).
-
PR Rev
On Thu, 14 Dec 2023 05:46:01 GMT, David Holmes wrote:
> Updated the version to 23-ea and year to 2024.
>
> This initial generation also picks up the unpublished changes from:
>
> - [JDK-8302233](https://bugs.openjdk.org/browse/JDK-8302233) (keytool &
> jarsigner)
> - [JDK-8290702](https://bugs
On Thu, 14 Dec 2023 05:46:01 GMT, David Holmes wrote:
> Updated the version to 23-ea and year to 2024.
>
> This initial generation also picks up the unpublished changes from:
>
> - [JDK-8302233](https://bugs.openjdk.org/browse/JDK-8302233) (keytool &
> jarsigner)
> - [JDK-8290702](https://bugs
24 matches
Mail list logo
