On Tue, 17 Sep 2024 23:14:16 GMT, Justin Lu wrote:
> Please review this PR which removes occurrences of 'applet' within the
> corelibs specification. Applet has been deprecated since JDK9, and may be a
> confusing term for new Java developers, so it should be removed from t
On Wed, 18 Sep 2024 17:59:40 GMT, Justin Lu wrote:
>> Please review this PR which removes occurrences of 'applet' within the
>> corelibs specification. Applet has been deprecated since JDK9, and may be a
>> confusing term for new Java developers, so i
On Wed, 18 Sep 2024 06:53:27 GMT, Alan Bateman wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> reflect review comments
>
> src/java.base/share/classes/java/nio/charset/spi/CharsetP
On Wed, 18 Sep 2024 06:52:17 GMT, Alan Bateman wrote:
>> `repaint()` could be substituted with another arbitrary method name to
>> highlight some work this thread has to perform.
>>
>> given the thread name `blink`, perhaps we could just use `blink()` in this
>> example.
>
> Don't waste too mu
PI.
>
>
> in _src/java.base/share/classes/java/lang/ThreadGroup.java_.
> Please see the JBS issue comments for further reasoning on why other
> occurrences were not removed.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Please review this PR which removes occurrences of 'applet' within the corelibs
specification. Applet has been deprecated since JDK9, and may be a confusing
term for new Java developers, so it should be removed from the documentation.
Primarily, usages where 'applet' is used interchangeably with
On Fri, 2 Aug 2024 18:20:40 GMT, Damon Nguyen wrote:
> Forwardport for JDK-8337054 from JDK23 of RDP2 L10N, fix applied cleanly.
>
> Forward-porting to add translated files from JDK23 RDP2 into mainline and
> prevent re-translating these files in the next L10N drop.
Marked as reviewed by jlu (
On Wed, 31 Jul 2024 11:02:06 GMT, Damon Nguyen wrote:
>> Localization update for JDK23 RDP2
>>
>> Please view for enhanced diffs on affected files:
>> https://cr.openjdk.org/~dnguyen/output/
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last
On Tue, 30 Jul 2024 22:45:03 GMT, Naoto Sato wrote:
>> Localization update for JDK23 RDP2
>>
>> Please view for enhanced diffs on affected files:
>> https://cr.openjdk.org/~dnguyen/output/
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets_ja.properties
> l
On Tue, 30 Jul 2024 20:17:28 GMT, Damon Nguyen wrote:
> Localization update for JDK23 RDP2
>
> Please view for enhanced diffs on affected files:
> https://cr.openjdk.org/~dnguyen/output/
LGTM
src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler_zh_CN.properties
line 96:
> 94
>
> The commit being backported was authored by Damon Nguyen on 13 Jun 2024 and
> was reviewed by Alisen Chung, Justin Lu, Naoto Sato, Joe Wang, Pavel Rappo,
> Chris Plummer, Alexey Semenyuk and Phil Race.
>
> Thanks!
Clean backport of L10n resource drop required for JDK23
---
On Tue, 11 Jun 2024 19:28:27 GMT, Damon Nguyen wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK. Primarily, the changes between JDK 22
>> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>>
>> The tra
On Tue, 11 Jun 2024 17:15:49 GMT, Naoto Sato wrote:
>> Yeah, I believe you're right. Noted as something else to file against the
>> translation tool.
>
> Just out of curiosity, do we know why `\t` was attached in the first place? I
> don't think it is with the original English properties.
I ca
On Fri, 7 Jun 2024 22:46:44 GMT, Damon Nguyen wrote:
> This issue is responsible for updating the translations of all the
> localize(able) resources in the JDK. Primarily, the changes between JDK 22
> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>
> The translati
On Tue, 6 Feb 2024 16:24:53 GMT, Magnus Ihse Bursie wrote:
>> According to [the
>> specification](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/util/Properties.html#load(java.io.Reader))
>> trailing whitespaces in the values of properties files are (somewhat
>> surprisingly
On Tue, 23 Jan 2024 22:49:04 GMT, Alisen Chung wrote:
> l10n update for jdk22 rdp2
LGTM, changes consistent with the original properties files
-
Marked as reviewed by jlu (Committer).
PR Review: https://git.openjdk.org/jdk/pull/17542#pullrequestreview-1840144150
On Wed, 13 Dec 2023 22:12:48 GMT, Alisen Chung wrote:
> Translation drop for JDK22 RDP1
All around LGTM. From a skim I don't see any of the typical l10n related file
mode issues, line ending issues, or values that should not be changed (like
_WixLocalization Culture_). Might be worth filing a
On Tue, 12 Sep 2023 21:57:31 GMT, Justin Lu wrote:
> JDK .properties files still use ISO-8859-1 encoding with escape sequences. It
> would improve readability to see the native characters instead of escape
> sequences (especially for the L10n process). The majority of files chang
On Wed, 13 Sep 2023 18:12:15 GMT, Naoto Sato wrote:
> Looks good to me, although I did not look at each l10n file, but sampled
> some. Thanks for tackling this conversion.
Thanks for the review; (In addition to testing), I ran a script to verify only
white space escape sequences exist in JDK .
or .properties files need
> to be updated to UTF-8. (IntelliJ IDEA locks .properties files as ISO-8859-1
> unless manually changed).
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Replace InputStreamReader with BufferedReader
---
JDK .properties files still use ISO-8859-1 encoding with escape sequences. It
would improve readability to see the native characters instead of escape
sequences (especially for the L10n process). The majority of files changed are
localized resource files.
This change converts the Unicode escape
On Wed, 2 Aug 2023 17:03:40 GMT, Justin Lu wrote:
> Please review this PR (L10N translation update), which is a backport of
> commit
> [9b55e9a7](https://github.com/openjdk/jdk/commit/9b55e9a706de9893b1a71c7a6a4e23c4b8842f18)
> from the [openjdk/jdk](https://git.openjdk.org/jdk
Please review this PR (L10N translation update), which is a backport of commit
[9b55e9a7](https://github.com/openjdk/jdk/commit/9b55e9a706de9893b1a71c7a6a4e23c4b8842f18)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
This change is required to keep the localized translations up
On Wed, 26 Jul 2023 20:41:36 GMT, Justin Lu wrote:
> Please review this PR which contains the translations for updates to
> localized resources in the JDK since RDP1.
>
> Included in this change are improved translations for certain values, which
> also includes glo
On Thu, 27 Jul 2023 00:16:34 GMT, Damon Nguyen wrote:
>> Please review this PR which contains the translations for updates to
>> localized resources in the JDK since RDP1.
>>
>> Included in this change are improved translations for certain values, which
>> also includes global updates for tran
Please review this PR which contains the IPS translations for updates to
localized resources in the JDK since RDP1.
Included in this change are improved translations for certain values, which
also includes global updates for translations of the words 'annotation' and
'file' for zh_CN.
The foll
On Mon, 12 Jun 2023 21:21:05 GMT, Justin Lu wrote:
> Please review this PR which updates the JDK's localized resources since the
> previous L10n translation drop (1/26).
>
> To help with reviewing the changes, @jonathan-gibbons created a tool which
> displays the localized
in UTF-8
> native. Those files can be viewed [here](https://cr.openjdk.org/~jlu/output/)
>
> For example,
>
> src="https://github.com/openjdk/jdk21/assets/67398801/e68a48a8-916e-4860-afb0-526924c6a3d3";>
>
>
> Please note that the HTML files only apply to .
On Thu, 15 Jun 2023 21:06:32 GMT, Kevin Rushforth wrote:
> Is the patch expected to be the same as in jdk mainline? I see some
> differences between the two patches (which is why Skara didn't mark it as
> "clean")
Hi Kevin, yes it is. I still need to grab the changes from mainline and include
On Mon, 12 Jun 2023 22:00:01 GMT, Justin Lu wrote:
> Please review this PR which updates the JDK's localized resources since the
> previous L10n translation drop (1/26).
>
> To help with reviewing the changes, @jonathan-gibbons created a tool which
> displays the localized
On Tue, 13 Jun 2023 18:50:42 GMT, Justin Lu wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler_de.properties
>> line 140:
>>
>>> 138:
>>> 139: # 0: type, 1: name
>>> 140: compiler.err.annotation.unrecognized.attribute.n
On Tue, 13 Jun 2023 20:56:31 GMT, Weijun Wang wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert 'main.help.opt.any.file' value for _de
>
> Some comments:
>
&g
in UTF-8
> native. Those files can be viewed [here](https://cr.openjdk.org/~jlu/output/)
>
> For example,
>
> src="https://github.com/openjdk/jdk21/assets/67398801/e68a48a8-916e-4860-afb0-526924c6a3d3";>
>
>
> Please note that the HTML files only apply to .
in UTF-8
> native. Those files can be viewed [here](https://cr.openjdk.org/~jlu/output/)
>
> For example,
>
> src="https://github.com/openjdk/jdk21/assets/67398801/e68a48a8-916e-4860-afb0-526924c6a3d3";>
>
>
> Please note that the HTML files only apply to .
On Tue, 13 Jun 2023 19:59:28 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert 'main.help.opt.any.file' value for _de
>
> src/java.deskto
On Tue, 13 Jun 2023 18:13:12 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert 'main.help.opt.any.file' value for _de
>
> src/jdk.compiler/sha
On Mon, 12 Jun 2023 22:17:25 GMT, Eirik Bjorsnos wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert 'main.help.opt.any.file' value for _de
>
> src/jdk.jarto
in UTF-8
> native. Those files can be viewed [here](https://cr.openjdk.org/~jlu/output/)
>
> For example,
>
> src="https://github.com/openjdk/jdk21/assets/67398801/e68a48a8-916e-4860-afb0-526924c6a3d3";>
>
>
> Please note that the HTML files only apply to .
On Mon, 12 Jun 2023 22:00:01 GMT, Justin Lu wrote:
> Please review this PR which updates the JDK's localized resources since the
> previous L10n translation drop (1/26).
>
> To help with reviewing the changes, @jonathan-gibbons created a tool which
> displays the localized
Please review this PR which updates the JDK's localized resources since the
previous L10n translation drop (1/26).
To help with reviewing the changes, @jonathan-gibbons created a tool which
displays the localized changes next to the original file's changes in UTF-8
native. Those files can be vi
On Mon, 12 Jun 2023 21:42:24 GMT, Kevin Rushforth wrote:
>> @prrace @jonathan-gibbons @pavelrappo @lahodaj @wangweij @igraves
>> @AlanBateman @eirbjo could you please review the modules / changes you are
>> familiar with, thank you.
>
> @justin-curtis-lu Unless there is a strong reason to do ot
On Mon, 12 Jun 2023 21:21:05 GMT, Justin Lu wrote:
> Please review this PR which updates the JDK's localized resources since the
> previous L10n translation drop (1/26).
>
> To help with reviewing the changes, @jonathan-gibbons created a tool which
> displays the localized
On Mon, 12 Jun 2023 21:21:05 GMT, Justin Lu wrote:
> Please review this PR which updates the JDK's localized resources since the
> previous L10n translation drop (1/26).
>
> To help with reviewing the changes, @jonathan-gibbons created a tool which
> displays the localized
Please review this PR which updates the JDK's localized resources since the
previous L10n translation drop (1/26).
To help with reviewing the changes, @jonathan-gibbons created a tool which
displays the localized changes next to the original file's changes in UTF-8
native. Those files can be vi
On Thu, 11 May 2023 20:21:57 GMT, Justin Lu wrote:
>> This PR converts Unicode sequences to UTF-8 native in .properties file.
>> (Excluding the Unicode space and tab sequence). The conversion was done
>> using native2ascii.
>>
>> In addition, the build logic is
ing the conversion from .properties file to
> .java ListResourceBundle file.
Justin Lu has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 16 commits:
- Convert the merged master changes to UTF-8
- Merge master and fix conflicts
On Fri, 17 Mar 2023 22:27:48 GMT, Justin Lu wrote:
>> This PR converts Unicode sequences to UTF-8 native in .properties file.
>> (Excluding the Unicode space and tab sequence). The conversion was done
>> using native2ascii.
>>
>> In addition, the build logic is
ing the conversion from .properties file to
> .java ListResourceBundle file.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Close streams when finished loading into props
-
Changes:
- all: https://git.openjdk.org/jdk/pul
ing the conversion from .properties file to
> .java ListResourceBundle file.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Adjust CF test to read in with UTF-8 to fix failing test
-
Changes:
- all: https://git.openj
On Thu, 16 Mar 2023 18:31:23 GMT, Justin Lu wrote:
>> This PR converts Unicode sequences to UTF-8 native in .properties file.
>> (Excluding the Unicode space and tab sequence). The conversion was done
>> using native2ascii.
>>
>> In addition, the build logic is
ing the conversion from .properties file to
> .java ListResourceBundle file.
Justin Lu has updated the pull request incrementally with two additional
commits since the last revision:
- Reconvert CS.properties to UTF-8
- Revert all changes to CurrencySymbols.properties
-
Ch
On Wed, 15 Mar 2023 16:18:44 GMT, Archie L. Cobbs wrote:
>> Justin Lu has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - Bug6204853 should not be converted
>> - Copyright year for CompilePropert
On Wed, 15 Mar 2023 20:19:51 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - Bug6204853 should not be converted
>> - Copyright year for CompileProperties
>>
On Thu, 16 Mar 2023 18:19:29 GMT, Justin Lu wrote:
>> This PR converts Unicode sequences to UTF-8 native in .properties file.
>> (Excluding the Unicode space and tab sequence). The conversion was done
>> using native2ascii.
>>
>> In addition, the build logic is
ing the conversion from .properties file to
> .java ListResourceBundle file.
Justin Lu has updated the pull request incrementally with four additional
commits since the last revision:
- Bug6204853 should not be converted
- Copyright year for CompileProperties
- Redo translation for CS.prope
On Tue, 7 Mar 2023 23:15:14 GMT, Jonathan Gibbons wrote:
>> This PR converts Unicode sequences to UTF-8 native in .properties file.
>> (Excluding the Unicode space and tab sequence). The conversion was done
>> using native2ascii.
>>
>> In addition, the build logic is adjusted to support readin
This PR converts Unicode sequences to UTF-8 native in .properties file.
(Excluding the Unicode space and tab sequence). The conversion was done using
native2ascii.
In addition, the build logic is adjusted to support reading in the .properties
files as UTF-8 during the conversion from .propertie
On Tue, 24 Jan 2023 23:56:23 GMT, Damon Nguyen wrote:
>> Open l10n drop. Files have been updated with translated versions. Whitespace
>> tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revisi
On Tue, 24 Jan 2023 22:33:24 GMT, Damon Nguyen wrote:
>> Open l10n drop. Files have been updated with translated versions. Whitespace
>> tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revisi
On Tue, 24 Jan 2023 22:20:22 GMT, Damon Nguyen wrote:
>> src/jdk.jconsole/share/classes/sun/tools/jconsole/resources/messages_zh_CN.properties
>> line 174:
>>
>>> 172:
>>> MBEANS_TAB_UNSUBSCRIBE_NOTIFICATIONS_BUTTON=\u53D6\u6D88\u8BA2\u9605(&U)
>>> 173:
>>> MBEANS_TAB_UNSUBSCRIBE_NOTIFICATION
On Thu, 15 Dec 2022 00:58:06 GMT, Justin Lu wrote:
>> Open l10n drop
>> All tests passed
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins_zh_CN.properties
> line 188:
>
>> 186: main.plugin.module=\u63D2\u4EF6\u6A21\u5757
>> 187:
>&
On Wed, 14 Dec 2022 23:40:52 GMT, Damon Nguyen wrote:
> Open l10n drop
> All tests passed
src/jdk.jlink/share/classes/jdk/tools/jmod/resources/jmod_de.properties line 26:
> 24: #
> 25:
> 26: jmod.description=JMOD-Dateien erstellen und den Inhalt vorhandener
> JMOD-Dateien auflisten
`jlink.de
On Wed, 14 Dec 2022 23:40:52 GMT, Damon Nguyen wrote:
> Open l10n drop
> All tests passed
src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins_zh_CN.properties
line 188:
> 186: main.plugin.module=\u63D2\u4EF6\u6A21\u5757
> 187:
> 188: main.plugin.category=\u7C7B\u522B
As Naoto poin
On Fri, 2 Dec 2022 16:36:22 GMT, Magnus Ihse Bursie wrote:
> According to [the
> specification](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/util/Properties.html#load(java.io.Reader))
> trailing whitespaces in the values of properties files are (somewhat
> surprisingly) ac
On Fri, 2 Dec 2022 16:36:22 GMT, Magnus Ihse Bursie wrote:
> According to [the
> specification](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/util/Properties.html#load(java.io.Reader))
> trailing whitespaces in the values of properties files are (somewhat
> surprisingly) ac
65 matches
Mail list logo
