Re: ConcurrentModificationException during pipeline serialization (MAX_SURVIVABILITY)

2021-11-17 Thread 'Devin Nusbaum' via Jenkins Developers
> As far as I understood the problem in JENKINS-67145 my step is somehow serialized during the execution in lines 205-215. Kind of, but I was talking about the publishIssues step, not the scanForIssues step. I think the scanForIssues steps in the

Re: ConcurrentModificationException during pipeline serialization (MAX_SURVIVABILITY)

2021-11-16 Thread 'Devin Nusbaum' via Jenkins Developers
The CPS VM thread is responsible for saving the Pipeline's execution state, so if you are using a non-blocking step execution (and it looks like you are

Re: FlowNode.addOrReplaceAction breaks due to java.lang.UnsupportedOperationException

2021-01-08 Thread Devin Nusbaum
I think the problem is the implementation of FlowNode.getActions in workflow-api. The returned list probably needs to override

Re: Issues compiling Jenkins plugins after 2.107 - Maven Enforcer and slf4j

2020-09-24 Thread Devin Nusbaum
Just to make sure we are talking about the same thing, I mean the `` section of your pom.xml, like this (make sure your plugin matches). I would go ahead and update to version 4.7.

Re: Issues compiling Jenkins plugins after 2.107 - Maven Enforcer and slf4j

2020-09-24 Thread Devin Nusbaum
Make sure you are using the latest version of the parent POM (4.7), or at least one of the 4.x versions. The 4.x releases of the parent POM include a BOM that manages the versions of various dependencies that come from Jenkins core to

Re: options timeout does not work with my custom step

2020-07-23 Thread Devin Nusbaum
Nikhil, maybe to make it clearer, what we mean is that instead of using your step like this: ``` runMATLABCommand "disp('TIMEOUT STARTED');disp(datetime('now'));pause(6*60);disp('TIMEOUT ENDED');disp(datetime('now'))" ``` You would implement a

Re: options timeout does not work with my custom step

2020-07-23 Thread Devin Nusbaum
> the reason that possibly causing issue of not abiding timeout block . > > Thanks & Regards > Nikhil > > On Thursday, 23 July 2020 21:59:52 UTC+5:30, Devin Nusbaum wrote: > Although you tried to make your step asynchronous, it is not actually > asynchronous. `execMatlabC

Re: options timeout does not work with my custom step

2020-07-23 Thread Devin Nusbaum
Although you tried to make your step asynchronous, it is not actually asynchronous. `execMatlabCommand` runs during your StepExecution’s `start` method and internally calls `Process.join` to wait for the process to complete, so your `start` method doesn’t return until the process completed.

Re: unable to transition Jira issue(s)

2020-07-06 Thread Devin Nusbaum
In my experience, this happens when someone tries to file a new issue while Jira is having problems. Jira reports that the issue couldn’t be created, so users try to submit the form again, and once the problem with Jira is resolved all of the submissions show up as duplicate issues where the

Re: PR review in workflow-cps-global-lib-plugin

2020-02-10 Thread Devin Nusbaum
Hi Victor, I'll try to take a look through open PRs in the plugin and get a release out in the next few weeks, thanks! On Wednesday, February 5, 2020 at 6:04:18 AM UTC-5, Victor Martinez wrote: > > Hi there, > > Any feedback for >

Re: Jenkins Plugin pom (future of)

2019-12-13 Thread Devin Nusbaum
Some housekeeping in the plugin POM sounds good to me. > for my part we have a lot of properties that are overloaded in profiles > (skipTests is a surefire flag but we abuse it to also skip spotbugs which > when you know how maven works becomes surprising) I was always a bit confused by that

Re: Request access for docker-workflow-plugin

2019-07-29 Thread Devin Nusbaum
Hi Artem! Thanks for your interest - the docker-workflow plugin definitely could use more attention. That said, it's such a critical plugin that I'd like to see a few more PRs and/or reviews on this plugin from you before giving you full access. I'll try to look at some of the open PRs over

Re: Dependencies required for pipeline jobs in hpi:run

2019-07-05 Thread Devin Nusbaum
“pipeline” in a Jenkinsfile comes from Pipeline: Declarative Plugin, groupId is org.jenkinsci.plugins, artifactId is pipeline-model-definition. That has a lot of dependencies, so depending on your use case, it might be preferable to convert your test case to scripted and depend only on

Re: Looking to help maintain credentials plugin

2019-06-24 Thread Devin Nusbaum
Hi Matt, I’m happy to transfer my permissions to you. I originally sought release permissions for this plugin as they were related to my work, but I have since transferred to a new team and do not anticipate working on this plugin. When I originally received release permissions, Stephen asked that

Re: New API in Pipeline: API Plugin 2.34 that allows Pipeline steps to track more detailed status/result information

2019-05-15 Thread Devin Nusbaum
add this information to the "Writing Pipeline > Compatible Plugins > <https://jenkins.io/doc/developer/plugin-development/pipeline-integration/>" > page on jenkins.io <http://jenkins.io/>? It seems like a very useful > addition to the documentation on that page. > >

New API in Pipeline: API Plugin 2.34 that allows Pipeline steps to track more detailed status/result information

2019-05-15 Thread Devin Nusbaum
Pipeline: API 2.34 added a new API called WarningAction that allows steps to report irregular but non-fatal events that

Re: JDK installer for AdoptOpenJDK

2019-05-03 Thread Devin Nusbaum
Interesting! Assuming your approach is robust I’d vote for just putting this directly in jdk-tool (and then very visibly deprecating the existing installer for Oracle Java) and adding you as a maintainer. You might be able to reuse the platform

Re: maven-hpi-plugin ... minimumJavaVersion attribute must be set...

2018-12-13 Thread Devin Nusbaum
d to me like Maven installed a copy of Jenkins below the ../work > directory when running the plug-in dev environments but is there some sort of > possible interaction even though Jenkins is not active? > > Happy to try a few things before I create another Ubuntu image and start from

Re: maven-hpi-plugin ... minimumJavaVersion attribute must be set...

2018-12-13 Thread Devin Nusbaum
> I'm trying to create a plug-in and started from the external-jobs plugin. > Unfortunately this had a very obsolete pom.xml so I've tried updating it > following some help given elsewhere in this group but I'm stuff no this error > when I try to run 'mvn hpi:run' For what it’s worth, there

Re: Plugin Adoption Request

2018-11-28 Thread Devin Nusbaum
If the current owners are ok with it, then you should file a PR directly against https://github.com/jenkins-infra/repository-permissions-updater to update the permissions file for the plugin you care about

Re: Becoming a maintainer of matrix-auth-plugin

2018-10-29 Thread Devin Nusbaum
You should always check repository-permissions-updater when looking for maintainers. Daniel is listed as the maintainer for that plugin: https://github.com/jenkins-infra/repository-permissions-updater/blob/master/permissions/plugin-matrix-auth.yml

Re: Permission to WhiteSource Plugin

2018-10-03 Thread Devin Nusbaum
how can she give me such > permission? > > > On Wednesday, October 3, 2018 at 4:09:23 PM UTC+3, Devin Nusbaum wrote: > The repository is: > https://github.com/jenkins-infra/repository-permissions-updater > <https://github.com/jenkins-infra/repository-permissions-updater>. &

Re: Permission to WhiteSource Plugin

2018-10-03 Thread Devin Nusbaum
The repository is: https://github.com/jenkins-infra/repository-permissions-updater . Instructions on how to request permissions for an existing plugin are in the README here

Re: pubsub-light-plugin maintainer?

2018-09-26 Thread Devin Nusbaum
It looks like there are a few more maintainers listed in repository-permissions-updater , including Vivek Pandey. If you filed a PR against repository-permissions-updater adding

Re: Request to join the Security Team

2018-09-07 Thread Devin Nusbaum
+1 > On Sep 7, 2018, at 10:02, Oleg Nenashev wrote: > > +1 > > On Friday, September 7, 2018 at 9:25:35 AM UTC+2, wfoll...@cloudbees.com > wrote: > +1 to be able to work with us :) > > On Thursday, September 6, 2018 at 9:03:46 PM UTC+2, David Lin wrote: > Hello! > >

Re: Proposal: Modify Plugin Adoption process to use JIRA to track adoption status

2018-08-24 Thread Devin Nusbaum
> Embryonic thought: maybe we could consider > `repository-permissions-updater` to be the source of truth? After all, +1. Since this is what actually changes the permissions, I thinks it makes sense to handle PRs there as formal requests. > (I still maintain that a separate heads-up to the dev

Re: Jenkins Blue Ocean requires perforce.hpi that doesn't exist?

2018-08-20 Thread Devin Nusbaum
Perforce was depublished because of a security advisory: https://jenkins.io/security/advisory/2018-03-26/#SECURITY-536 , so the download links and the associated webpage on the plugins site have been removed. > Is it possible to

Re: github-api and jackson2-api shared libraries hell

2018-08-02 Thread Devin Nusbaum
I agree this is a problem. FWIW, I don’t know of any blockers to updating jackson2-api to 2.9.x, I just haven’t had time to look through changelogs and run the PCT to see what the impact could be. It might be a non-issue. Thanks, Devin > On Aug 2, 2018, at 04:43, Oleg Nenashev wrote: > >

Re: Request Jenkins security team membership for Jeff Thompson

2018-05-15 Thread Devin Nusbaum
+1 > On May 15, 2018, at 04:14, Oleg Nenashev wrote: > > +1 > > On Tuesday, May 15, 2018 at 5:58:03 AM UTC+2, Jeff Thompson wrote: > I’d like to request to join the Jenkins security team to help review and fix > security changes and issues. I’m a software engineer at

Re: Request to join security team

2018-05-14 Thread Devin Nusbaum
+1 > On May 14, 2018, at 11:55, Matt Sicker wrote: > > Hi, I'm interested in joining the security team. I'm a software engineer at > CloudBees who is working on some security-related epics. I've got 2FA enabled > on GitHub (username: jvz), signed the CLA, and am

Re: AtomicFileWriterTest fails

2018-04-16 Thread Devin Nusbaum
AIUI creating symlinks in Windows 10+ requires running as administrator unless developer mode is enabled. Blog post from Microsoft on the changes: https://blogs.windows.com/buildingapps/2016/12/02/symlinks-windows-10/ . I’m

Re: Eh why are we suggesting such a complex reverse proxy configuration?

2018-02-07 Thread Devin Nusbaum
+1, I support editing the pages to focus on a simple config that just changes X-Forwarded headers. I created the HAProxy wiki page while testing the HTTP duplex CLI mode with various reverse proxies, so I am fully to blame :) I had no prior knowledge about HAProxy and pieced together a working

Re: Compatability code

2018-01-16 Thread Devin Nusbaum
Hi Mads, This wiki page explains the right configuration to add to pom.xml in your plugin: https://wiki.jenkins.io/display/JENKINS/Marking+a+new+plugin+version+as+incompatible+with+older+versions

Request to join Jenkins CERT team

2017-09-26 Thread Devin Nusbaum
ername: dwnusbaum <https://github.com/dwnusbaum> IRC Nickname: dnusbaum Jenkins community username: dnusbaum Thanks, Devin Nusbaum -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receivin