hg: jigsaw/jake/nashorn: 8144568: ant clean test fails with jake/nashorn after recent sync with jdk9-dev

Changeset: 22fa52ddaf66 Author:sundar Date: 2015-12-03 13:03 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/22fa52ddaf66 8144568: ant clean test fails with jake/nashorn after recent sync with jdk9-dev ! make/project.properties ! src/jdk.scripting.nashorn/share/class

Re: CFV: New Jigsaw Committer: Jan Lahoda

Vote: yes On 12/3/2015 1:13 AM, Jonathan Gibbons wrote: |I hereby nominate Jan Lahoda to Jigsaw Committer. Jan is already a Reviewer for the JDK 9 project, and has made the following contributions to the jigsaw/jake forest: | http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/ad2566ebc2a6

hg: jigsaw/jake/langtools: javap should generate useful output for module-info in absence of -v

Changeset: 55927a560def Author:jjg Date: 2015-12-02 16:09 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/55927a560def javap should generate useful output for module-info in absence of -v ! src/jdk.jdeps/share/classes/com/sun/tools/classfile/Module_attribute.java !

Re: is ClassLoader.loadClass() supposed to work on module-info classes?

On 12/2/2015 1:34 PM, Paul Benedict wrote: Alex, the primary benefit of annotations (vs. XML) is delivering code and configuration in one bundle. It's unnecessary to deliver configuration separately (i.e., XML) if you have a component that primarily has one way of being configured. That's exactly

Re: no error when module exports non-existing package

On 12/02/2015 02:20 PM, Victor Rudometov wrote: On 02.12.2015 21:09, Jonathan Gibbons wrote: Adding Victor back into the recipients. -- Jon On 12/02/2015 10:08 AM, Jonathan Gibbons wrote: On 12/02/2015 09:41 AM, Victor Rudometov wrote: Hi, Javac does not complain if user exports a packag

Re: no error when module exports non-existing package

On 02.12.2015 21:09, Jonathan Gibbons wrote: Adding Victor back into the recipients. -- Jon On 12/02/2015 10:08 AM, Jonathan Gibbons wrote: On 12/02/2015 09:41 AM, Victor Rudometov wrote: Hi, Javac does not complain if user exports a package that does not exist. If it was not done intentio

Re: is ClassLoader.loadClass() supposed to work on module-info classes?

Alex, the primary benefit of annotations (vs. XML) is delivering code and configuration in one bundle. It's unnecessary to deliver configuration separately (i.e., XML) if you have a component that primarily has one way of being configured. That's exactly why annotations are very valuable in EE deve

Re: Running module jar programatically

The Java 9 support in Eclipse Neon is fairly limited right now. It understands the new layout of the JRE and puts the platform modules on your build classpath. It does not however understand the syntax of module-info.java, so you will get red error markers in these files, and you will need to co

Re: CFV: New Jigsaw Committer: Jan Lahoda

Vote: YES -Chris > On 2 Dec 2015, at 7:43 p.m., Jonathan Gibbons > wrote: > > |I hereby nominate Jan Lahoda to Jigsaw Committer. > > Jan is already a Reviewer for the JDK 9 project, and has made the following > contributions to the jigsaw/jake forest: > | > > http://hg.openjdk.java.net/jigs

Re: Running module jar programatically

On 12/2/15 5:26 PM, Stephane Epardaud wrote: > Of course it does not help that I have to do this all outside of my IDE > as Eclipse doesn't know about Java 9 yet :( See https://marketplace.eclipse.org/content/java-9-support-beta-neon cheers, dalibor topic -- Oracle Dal

Re: is ClassLoader.loadClass() supposed to work on module-info classes?

On 12/2/2015 8:31 AM, Paul Benedict wrote: All that information is locked in binary format but it should be human readable. I should be able to go in myself and do this with a text editor. I shouldn't have to compile a file anymore than I have to compile my MANIFEST.MF or web.xml or application.x

Re: CFV: New Jigsaw Committer: Jan Lahoda

Vote: yes

Re: CFV: New Jigsaw Committer: Jan Lahoda

Vote: yes Harold On 12/2/2015 2:43 PM, Jonathan Gibbons wrote: |I hereby nominate Jan Lahoda to Jigsaw Committer. Jan is already a Reviewer for the JDK 9 project, and has made the following contributions to the jigsaw/jake forest: | http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/ad256

Re: CFV: New Jigsaw Committer: Jan Lahoda

Vote: Yes. -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Kühnehöfe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992

Re: CFV: New Jigsaw Committer: Jan Lahoda

Vote: yes Mandy

Re: is ClassLoader.loadClass() supposed to work on module-info classes?

Thank you for repeating my concerns I raised in September. Stephen Felts wrote: I agree. I would much rather be able to see the information using unzip -p and update it using a text editor or any tool that can write text. -Original Message- From: Paul Benedict [mailto:pbened...@apa

Re: Question about jdk.internal.HotSpotIntrinsicCandidate

On 12/2/2015 2:16 AM, Stephane Epardaud wrote: On 01/12/15 22:04, Alex Buckley wrote: There shouldn't be any surprise here. In Java SE 8, you can declare a package-private annotation type and use it to write annotations on public classes of that package. Going up a level in Java SE 9, you can de

CFV: New Jigsaw Committer: Jan Lahoda

|I hereby nominate Jan Lahoda to Jigsaw Committer. Jan is already a Reviewer for the JDK 9 project, and has made the following contributions to the jigsaw/jake forest: | http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/ad2566ebc2a6dabb7f2bcbd920c23a9b3b4c4d2c http://hg.openjdk.java.net/jigs

hg: jigsaw/jake/jdk: 8144433: Re-examine jimage fix for JDK-8141571 with jake

Changeset: 66677a0b82a9 Author:jlaskey Date: 2015-12-02 15:04 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/66677a0b82a9 8144433: Re-examine jimage fix for JDK-8141571 with jake Reviewed-by: jlaskey Contributed-by: roger.ri...@oracle.com ! src/java.base/share/native/lib

Re: using modules for caching

- Mail original - > De: "Peter Levart" > À: "Jochen Theodorou" , jigsaw-dev@openjdk.java.net > Envoyé: Mercredi 2 Décembre 2015 17:45:59 > Objet: Re: using modules for caching > > > > On 12/02/2015 01:40 PM, Jochen Theodorou wrote: > > Hi, > > > > I was wondering if it will be possibl

Re: no error when module exports non-existing package

Adding Victor back into the recipients. -- Jon On 12/02/2015 10:08 AM, Jonathan Gibbons wrote: On 12/02/2015 09:41 AM, Victor Rudometov wrote: Hi, Javac does not complain if user exports a package that does not exist. If it was not done intentionally, it would be good to report an error, o

Re: no error when module exports non-existing package

On 12/02/2015 09:41 AM, Victor Rudometov wrote: Hi, Javac does not complain if user exports a package that does not exist. If it was not done intentionally, it would be good to report an error, or at least a warning. Today was the third time I saw the code with a typo or just incorrect packa

no error when module exports non-existing package

Hi, Javac does not complain if user exports a package that does not exist. If it was not done intentionally, it would be good to report an error, or at least a warning. Today was the third time I saw the code with a typo or just incorrect package name in module-info's exports statement. Thank

Re: using modules for caching

On 12/02/2015 01:40 PM, Jochen Theodorou wrote: Hi, I was wondering if it will be possible to reuse module information between runs.. Currently I am collecting a lot of reflective information and use it to build a meta class system, which I then need to do method invocations, what fields ar

Re: is ClassLoader.loadClass() supposed to work on module-info classes?

Of course, Stephen. Look, the current manifest has a Class-Path entry to add classes in other JAR files to the classpath when running an applet or application. It's pretty close to what's going on with the Module Descriptor. Developers are simply listing out modules instead of jars. Yes, there is s

Re: Running module jar programatically

On 02/12/2015 15:24, Stephane Epardaud wrote: Hi, I have a modular jar produced by Java 9 EA + Jigsaw, I can run it with "java -mp mlib -m my.module", but how can I run it programmatically in Java? ATM I'm using URLClassLoader to load it and run it, but I _think_ it does not make it "modular" a

Re: Running module jar programatically

I am now looking at http://cr.openjdk.java.net/~mr/jigsaw/spec/api/ and Layer, ModuleClassLoader and Configuration. Once I make sense of this, I suspect it will answer my question. Of course it does not help that I have to do this all outside of my IDE as Eclipse doesn't know about Java 9 yet :( [

RE: is ClassLoader.loadClass() supposed to work on module-info classes?

I agree. I would much rather be able to see the information using unzip -p and update it using a text editor or any tool that can write text. -Original Message- From: Paul Benedict [mailto:pbened...@apache.org] Sent: Wednesday, December 02, 2015 9:53 AM To: Remi Forax Cc: jigsaw-dev@o

Re: is ClassLoader.loadClass() supposed to work on module-info classes?

Being a meta-data container, I don't understand why it's not under META-INF ? Jeff On Wed, Dec 2, 2015 at 4:15 PM, David M. Lloyd wrote: > On 12/02/2015 09:05 AM, Remi Forax wrote: > >> >> >> - Mail original - >> >>> De: "David M. Lloyd" >>> À: jigsaw-dev@openjdk.java.net >>> Envoyé: M

hg: jigsaw/jake/hotspot: Improve module related IAE error messages, add unnamed module identity hash to messages.

Changeset: ec9ad3190695 Author:hseigel Date: 2015-12-02 10:23 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/ec9ad3190695 Improve module related IAE error messages, add unnamed module identity hash to messages. ! src/share/vm/classfile/modules.cpp ! src/share/vm/run

Re: Running module jar programatically

A bit off-topic, but I wanted to clarify something, in case my many questions sound negative: I think you guys have done a tremendous job with Jigsaw, and IMO the hardest is behind you, I can see there was a huge amount of work (well, you started it in Java 7…) to get to his point, and I feel that

Running module jar programatically

Hi, I have a modular jar produced by Java 9 EA + Jigsaw, I can run it with "java -mp mlib -m my.module", but how can I run it programmatically in Java? ATM I'm using URLClassLoader to load it and run it, but I _think_ it does not make it "modular" and the module package visibility checks are turn

Re: RFR: JDK 9: 8143879 jdk/internal/jimage/JImageReadTest.java crashes jvm in msvcr120.dll

On 02/12/2015 15:17, Roger Riggs wrote: Hi Alan, I just pushed it to jdk9, it should merge easily; can you or Jim take care of getting it into Jake. Ideally it would come in when we sync up jake but there are conflicts to sort and I think we might have manually update the native jimage c

Re: RFR: JDK 9: 8143879 jdk/internal/jimage/JImageReadTest.java crashes jvm in msvcr120.dll

I had it in my pending changes, but I’ll isolate and add. > On Dec 2, 2015, at 11:17 AM, Roger Riggs wrote: > > Hi Alan, > > I just pushed it to jdk9, it should merge easily; can you or Jim take care > of getting it into Jake. > > Thanks, Roger > > > On 12/02/2015 10:15 AM, Alan Bateman

Re: RFR: JDK 9: 8143879 jdk/internal/jimage/JImageReadTest.java crashes jvm in msvcr120.dll

Hi Alan, I just pushed it to jdk9, it should merge easily; can you or Jim take care of getting it into Jake. Thanks, Roger On 12/02/2015 10:15 AM, Alan Bateman wrote: On 01/12/2015 23:18, Roger Riggs wrote: Please review a fix for jimage native code to correctly maintain the list of Im

Re: RFR: JDK 9: 8143879 jdk/internal/jimage/JImageReadTest.java crashes jvm in msvcr120.dll

On 01/12/2015 23:18, Roger Riggs wrote: Please review a fix for jimage native code to correctly maintain the list of ImageFileReaders. This looks okay to me too. I assume we'll need to get this into jake too. -Alan

Re: is ClassLoader.loadClass() supposed to work on module-info classes?

On 12/02/2015 09:05 AM, Remi Forax wrote: - Mail original - De: "David M. Lloyd" À: jigsaw-dev@openjdk.java.net Envoyé: Mercredi 2 Décembre 2015 15:52:56 Objet: Re: is ClassLoader.loadClass() supposed to work on module-info classes? On 12/02/2015 08:46 AM, Remi Forax wrote: -

Re: is ClassLoader.loadClass() supposed to work on module-info classes?

On 02/12/2015 14:35, Stephane Epardaud wrote: On 02/12/15 14:56, Alan Bateman wrote: The this_class should be /module-info but in any case, The funny thing is that this module-info.class was created by the Java 9+Jigsaw EA "stock" javac. How it got the ".Test" class mixed up in there is not

Re: is ClassLoader.loadClass() supposed to work on module-info classes?

- Mail original - > De: "David M. Lloyd" > À: jigsaw-dev@openjdk.java.net > Envoyé: Mercredi 2 Décembre 2015 15:52:56 > Objet: Re: is ClassLoader.loadClass() supposed to work on module-info classes? > > On 12/02/2015 08:46 AM, Remi Forax wrote: > > - Mail original - > >> De: "Al

Re: is ClassLoader.loadClass() supposed to work on module-info classes?

- Mail original - > De: "Alan Bateman" > À: "Stephane Epardaud" , jigsaw-dev@openjdk.java.net > Envoyé: Mercredi 2 Décembre 2015 14:56:00 > Objet: Re: is ClassLoader.loadClass() supposed to work on module-info classes? > > On 02/12/2015 11:01, Stephane Epardaud wrote: > > Just tried it an

Re: is ClassLoader.loadClass() supposed to work on module-info classes?

This is probably a good time to (once again) bring up the objection that the Module Descriptor shouldn't be a class file to begin with. I know I am not the only one who has stated this on the mailing list. I doubt this email will gain any traction, but it's something the EG should seriously conside

Re: is ClassLoader.loadClass() supposed to work on module-info classes?

On 12/02/2015 08:46 AM, Remi Forax wrote: - Mail original - De: "Alan Bateman" À: "Stephane Epardaud" , jigsaw-dev@openjdk.java.net Envoyé: Mercredi 2 Décembre 2015 14:56:00 Objet: Re: is ClassLoader.loadClass() supposed to work on module-info classes? On 02/12/2015 11:01, Stephane E

Re: is ClassLoader.loadClass() supposed to work on module-info classes?

On 02/12/15 14:56, Alan Bateman wrote: > The this_class should be /module-info but in any case, The funny thing is that this module-info.class was created by the Java 9+Jigsaw EA "stock" javac. How it got the ".Test" class mixed up in there is not clear to me. Perhaps as a result of me specifyi

Re: is ClassLoader.loadClass() supposed to work on module-info classes?

On 02/12/2015 11:01, Stephane Epardaud wrote: Just tried it and got: Exception in thread "main" java.lang.ClassFormatError: Illegal class name "com.ceylon.java9.Test" in class file module-info at java.lang.ClassLoader.defineClass1(java.base@9.0/Native Method) at java.lang.ClassLoader.d

Re: JVMTI and instrumentation

On 02/12/2015 11:39, Michael Rasmussen wrote: : A further question for JVMTI in this regard: ClassFileLoadHook callback seems to not be called before VMInit anymore? I know the documentation is vague on this point, only specifying that it may be sent in primordial phase; but for previous JDK ve

Re: RFR: JDK 9: 8143879 jdk/internal/jimage/JImageReadTest.java crashes jvm in msvcr120.dll

+1 > On Dec 1, 2015, at 7:18 PM, Roger Riggs wrote: > > Please review a fix for jimage native code to correctly maintain the list of > ImageFileReaders. > > Issue: > https://bugs.openjdk.java.net/browse/JDK-8143879 > > Webrev: > http://cr.openjdk.java.net/~rriggs/webrev-jimage-read-814387

using modules for caching

Hi, I was wondering if it will be possible to reuse module information between runs.. Currently I am collecting a lot of reflective information and use it to build a meta class system, which I then need to do method invocations, what fields are available and other things like that. Since that c

Re: JVMTI and instrumentation

On 2 December 2015 at 11:45, Alan Bateman wrote: > Just to get more context, are you trying to avoid the -Xpatch option and > have everything done by the agent so it's just a -agentlib option? If there > really is a need for this then it might be something for a JVM TI extension > function to add

hg: jigsaw/jake: Generate modulesourcepath for jdk.vm.ci

Changeset: f00cc7909d28 Author:erikj Date: 2015-12-02 12:08 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/f00cc7909d28 Generate modulesourcepath for jdk.vm.ci ! make/CompileJavaModules.gmk

is ClassLoader.loadClass() supposed to work on module-info classes?

Just tried it and got: Exception in thread "main" java.lang.ClassFormatError: Illegal class name "com.ceylon.java9.Test" in class file module-info at java.lang.ClassLoader.defineClass1(java.base@9.0/Native Method) at java.lang.ClassLoader.defineClass(java.base@9.0/ClassLoader.java:854)

Re: Question about jdk.internal.HotSpotIntrinsicCandidate

On 01/12/15 22:04, Alex Buckley wrote: > There shouldn't be any surprise here. In Java SE 8, you can declare a > package-private annotation type and use it to write annotations on > public classes of that package. Going up a level in Java SE 9, you can > declare a module-private annotation type (

Re: JVMTI and instrumentation

On 01/12/2015 22:08, Michael Rasmussen wrote: Are there any plans to support setting -Xpatch from JVMTI in OnLoad phase, or even setting the "jdk.launcher.patchdirs" system property, and have it take effect? (Also applies to the other module -X options) Agent_OnLoad should is still so early in t