Re: Java SE JSR 250 annotations module renamed to java.xml.ws.annotation?

On 02/13/2017 11:30 AM, fo...@univ-mlv.fr wrote: - even as a temporary workaround, it's really weird to have to require a module named java.xml.ws.annotation for that. It does not really make sense from an end user perspective. the module name reflect the fact that it's a part of jax-ws and not

Re: jlink RuntimeException: descriptor returns inconsistent package set

As a postscript to this entire thread, for what it's worth, here's a blog entry which presents a recipe for adding the necessary customization to NetBeans to enable it to automatically build JDK9 runtime images as part of the build process. Automating the Creation of JDK9 Reduced Runtime Image

Re: Confusing error message for inner non-public service provider

Peter, The circumstances of the analysis of service providers are very different to the normal JLS rules regarding visibility and accessibility of named items. I know that we have some cleanup to do, for javac to "catch up" with the latest updates to JLS, especially with regards to the diffe

Re: RFR 8174209: Renumber the compress levels

> On Feb 13, 2017, at 9:03 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8174209/webrev/ for > https://bugs.openjdk.java.net/browse/JDK-8174209 Looks okay. Mandy

Re: RFR 8174209: Renumber the compress levels

+1 > On Feb 13, 2017, at 1:03 PM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8174209/webrev/ for > https://bugs.openjdk.java.net/browse/JDK-8174209 > > Thanks, > -Sundar

Re: RFR 8174209: Renumber the compress levels

+1! /Claes On 2017-02-13 18:03, Sundararajan Athijegannathan wrote: Please review http://cr.openjdk.java.net/~sundar/8174209/webrev/ for https://bugs.openjdk.java.net/browse/JDK-8174209 Thanks, -Sundar

Re: [9] RFR: 8169715: jimage fails with IAE when attempts to inspect an empty file

Looks good > On 13 Feb 2017, at 20:58, Denis Kononenko wrote: > > > Hi, > > Optimized buffer's capacity checks. > > WEBREV: http://cr.openjdk.java.net/~dkononenko/8169715/webrev.02 > > >> >> Could please someone review the fix fo

Re: [9] RFR: 8169715: jimage fails with IAE when attempts to inspect an empty file

+1 > On Feb 13, 2017, at 1:58 PM, Denis Kononenko > wrote: > > > Hi, > > Optimized buffer's capacity checks. > > WEBREV: http://cr.openjdk.java.net/~dkononenko/8169715/webrev.02 > > >> >> Could please someone review the fix for

Re: [9] RFR: 8169715: jimage fails with IAE when attempts to inspect an empty file

Hi, Optimized buffer's capacity checks. WEBREV: http://cr.openjdk.java.net/~dkononenko/8169715/webrev.02 > > Could please someone review the fix for JDK-8169715. > > The problem occurs when jimage tool is attempting to read an empty or > incomplete image. The current implementation

Re: Java SE JSR 250 annotations module renamed to java.xml.ws.annotation?

> > I'm not sure we have to introduce a replacement for @Generated, i maybe > wrong but the retention of this annotation is the source, so it's an > indication for the developer more than anything else, so each framework can > come with its own annotation and in my opinion, it will make the > depen

Re: Compiling classes for multi-release JAR with module-info.java

> the reason you are running into issues is > because the second javac command is essentially compiling a module with > references to types on the class path. Shouldn't this be supported, though? I.e. is the observed behavior a bug and the contents from the given classpath should actually be avai

Re: Java SE JSR 250 annotations module renamed to java.xml.ws.annotation?

> De: "Guillaume Smet" > À: "Remi Forax" > Cc: jigsaw-dev@openjdk.java.net > Envoyé: Lundi 13 Février 2017 16:43:36 > Objet: Re: Java SE JSR 250 annotations module renamed to > java.xml.ws.annotation? > Hi Rémi, > (replied to you but it's more of a general answer to the consensus) > On Mon, F

Re: RFR 8174209: Renumber the compress levels

On 13/02/2017 17:03, Sundararajan Athijegannathan wrote: Please review http://cr.openjdk.java.net/~sundar/8174209/webrev/ for https://bugs.openjdk.java.net/browse/JDK-8174209 This looks okay to me. -Alan

Re: Java SE JSR 250 annotations module renamed to java.xml.ws.annotation?

On Mon, Feb 13, 2017 at 6:10 PM, Alan Bateman wrote: > On 13/02/2017 16:58, Guillaume Smet wrote: > > On Mon, Feb 13, 2017 at 5:12 PM, Alan Bateman > wrote: > >> I agree that @Generated is awkward but I haven't suggested removing it. > > > What do you suggest then? As far as I understood you, yo

Re: Java SE JSR 250 annotations module renamed to java.xml.ws.annotation?

On 13/02/2017 16:58, Guillaume Smet wrote: On Mon, Feb 13, 2017 at 5:12 PM, Alan Bateman > wrote: I agree that @Generated is awkward but I haven't suggested removing it. What do you suggest then? As far as I understood you, you were suggesting removing

Re: Confusing error message for inner non-public service provider

Hi, Just wanted to note that the confusing javac error message is not specific to services and service providers. Take the following example: src/moda/module-info.java: module moda { exports pkga; } src/moda/pkga/Outer.java: package pkga; class Outer { public static class Untouchab

Re: Java SE JSR 250 annotations module renamed to java.xml.ws.annotation?

ACC_SYNTHETIC is a binary annotation/attribute/value, not a source one and synthetic members are not visible from the compiler point of view (think bridges by example). ACC_MANDATED can be used (again only in classfiles) but you have a good chance to be tracked and killed by Alex Buckley :) Ré

Re: Java SE JSR 250 annotations module renamed to java.xml.ws.annotation?

On Mon, Feb 13, 2017 at 5:12 PM, Alan Bateman wrote: > I agree that @Generated is awkward but I haven't suggested removing it. What do you suggest then? As far as I understood you, you were suggesting removing the module in Java 10 so the @Generated annotation would also be gone? Or did I misun

RFR 8174209: Renumber the compress levels

Please review http://cr.openjdk.java.net/~sundar/8174209/webrev/ for https://bugs.openjdk.java.net/browse/JDK-8174209 Thanks, -Sundar

Re: Java SE JSR 250 annotations module renamed to java.xml.ws.annotation?

On 13/02/2017 15:56, Guillaume Smet wrote: So basically, your position is that we should update all the Java tooling out there to remove the usage of the @Generated annotation? Because I don't think introducing a dependency to the JSR 250 API jar everywhere is a good thing. If so, as menti

Re: Java SE JSR 250 annotations module renamed to java.xml.ws.annotation?

Hi Alan, On Mon, Feb 13, 2017 at 4:46 PM, Alan Bateman wrote: > The name is unfortunate, a woeful choice, esp. in the context of Java SE > and JDK where most of annotations are just not relevant. This is what lead > to the defining the subset for JAX-WS. > > Anyway, the proposal is to deprecate

Re: Java SE JSR 250 annotations module renamed to java.xml.ws.annotation?

Hi Rémi, (replied to you but it's more of a general answer to the consensus) On Mon, Feb 13, 2017 at 3:59 PM, Remi Forax wrote: > so there are 3 cases: > - your application is modular, in that case one module defines a > dependency (with requires) on a module* containing the JSR 250 annotation

Re: Java SE JSR 250 annotations module renamed to java.xml.ws.annotation?

On 13/02/2017 15:11, Andrew Haley wrote: On 13/02/17 14:34, Alan Bateman wrote: The small subset of the JSR-250 defined "Common Annotations" that you see in Java SE is part of the web services stack that was added in Java SE 6. If it weren't for JAX-WS then these annotations would have no busin

Re: Java SE JSR 250 annotations module renamed to java.xml.ws.annotation?

Perhaps, it's a problem of communication, what about "As an effort to make Java on diet, Java 10 will not be shipped with modules corba, jaxb or common annnotations, for Java 9, you can use a command line option to have access to those deprecated modules." Rémi - Mail original - > De: "

Re: Java SE JSR 250 annotations module renamed to java.xml.ws.annotation?

On 13/02/17 14:34, Alan Bateman wrote: > The small subset of the JSR-250 defined "Common Annotations" that you > see in Java SE is part of the web services stack that was added in Java > SE 6. If it weren't for JAX-WS then these annotations would have no > business being in Java SE or the JDK.

Re: Java SE JSR 250 annotations module renamed to java.xml.ws.annotation?

On 02/13/2017 08:58 AM, David M. Lloyd wrote: On 02/13/2017 08:49 AM, Alan Bateman wrote: On 13/02/2017 14:32, David M. Lloyd wrote: I think this is an error. It makes more sense to have the javax.annotation package exist in its own module. If the long-idle JSR 250 and specifications like it

Re: Java SE JSR 250 annotations module renamed to java.xml.ws.annotation?

TLDR; we can't. In Java 6, we made the mistake to create what you can call twin packages, a package with few classes in the JDK and the same package with more classes including the classes already present in the JDK. The idea was that you can run an application using the JDK, in that case you h

Re: Java SE JSR 250 annotations module renamed to java.xml.ws.annotation?

On 02/13/2017 08:49 AM, Alan Bateman wrote: On 13/02/2017 14:32, David M. Lloyd wrote: I think this is an error. It makes more sense to have the javax.annotation package exist in its own module. If the long-idle JSR 250 and specifications like it are really a concern, then this module should

Re: Java SE JSR 250 annotations module renamed to java.xml.ws.annotation?

On 13/02/2017 14:32, David M. Lloyd wrote: I think this is an error. It makes more sense to have the javax.annotation package exist in its own module. If the long-idle JSR 250 and specifications like it are really a concern, then this module should follow the pattern of all other such module

Re: Java SE JSR 250 annotations module renamed to java.xml.ws.annotation?

On 13/02/2017 13:34, Guillaume Smet wrote: : This doesn't work anymore as the Java SE JSR 250 annotations (@Generated, @PreDestroy, @PostConstruct, @Resource...) that were previously in a module called java.annotations.common were moved to a module called java.xml.ws.annotation as part of the a

Re: Java SE JSR 250 annotations module renamed to java.xml.ws.annotation?

I think this is an error. It makes more sense to have the javax.annotation package exist in its own module. If the long-idle JSR 250 and specifications like it are really a concern, then this module should follow the pattern of all other such modules and be upgradeable. Note that until #Avoi

Re: Java SE JSR 250 annotations module renamed to java.xml.ws.annotation?

Hi Guillaume, On 02/13/2017 02:34 PM, Guillaume Smet wrote: At the end, I'm wondering if these classes shouldn't be part of the default set of classes exposed without requiring an --add-modules option. one of the main reasons why java.xml.ws.annotations is not resolved by default is that there

Java SE JSR 250 annotations module renamed to java.xml.ws.annotation?

Hi, (Posting this on the list at the request of Rory O'Donnell) This morning I tried to upgrade our Hibernate Validator build and came across this issue: https://bugs.openjdk.java.net/browse/JDK-8173604 . As a lot of projects experimenting with the Early access builds of the JDK 9, we added --ad

Re: JAR searched on the classpath instead of the module path in Build #156

Hi Alexandru, please be aware that Hibernate to support Jigsaw is a work in progress. We had some successful builds (including test runs) some months ago, but we have yet to catch up on recent changes in OpenJDK. Progress for each Hibernate project can be monitored here: - http://ci.hibernate.or

hg: jigsaw/jake/jaxp: 6 new changesets

Changeset: e372795e1b7c Author:fyuan Date: 2017-02-09 16:47 +0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/e372795e1b7c 8173290: 3% regression in SPECjvm2008-XML with b150 Reviewed-by: joehw ! src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/ToHTML

hg: jigsaw/jake/jdk: 48 new changesets

Changeset: c39f051b38d8 Author:bpb Date: 2017-02-07 11:01 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/c39f051b38d8 8173910: (fs) java/nio/file/FileSystem/Basic.java should conditionally check FileStores Summary: On Unix platforms, spawn a 'df' process and skip FileSto

hg: jigsaw/jake/nashorn: 3 new changesets

Changeset: c84e9bd100e9 Author:alanb Date: 2017-02-10 09:06 + URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/c84e9bd100e9 8173393: Module system implementation refresh (2/2017) Reviewed-by: mchung, alanb Contributed-by: alan.bate...@oracle.com, mandy.ch...@oracle.com !

hg: jigsaw/jake/hotspot: 22 new changesets

Changeset: 8c7769a2e1fe Author:alanb Date: 2017-02-10 09:03 + URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/8c7769a2e1fe 8173393: Module system implementation refresh (2/2017) Reviewed-by: lfoltan, acorn, mchung Contributed-by: alan.bate...@oracle.com, george.triantafi

hg: jigsaw/jake/jaxws: 4 new changesets

Changeset: 42993fcbd8f3 Author:lancea Date: 2017-02-07 15:46 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/42993fcbd8f3 8057795: Update of the mimestypes.default for JAF Reviewed-by: bpb ! src/java.activation/share/classes/META-INF/mimetypes.default Changeset: 487620

hg: jigsaw/jake/langtools: 19 new changesets

Changeset: f0bc0f34d2cc Author:jjg Date: 2017-02-07 16:19 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/f0bc0f34d2cc 8174140: Move test files into package hierarchy Reviewed-by: darcy ! test/tools/javac/T4093617/T4093617.java - test/tools/javac/T4093617/java.base/

hg: jigsaw/jake/corba: 4 new changesets

Changeset: 9eada61b403d Author:msheppar Date: 2017-02-09 15:52 + URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/9eada61b403d 8049375: Extend how the org.omg.CORBA.ORB handles the search for orb.properties Reviewed-by: lancea, alanb ! src/java.corba/share/classes/org/omg/

hg: jigsaw/jake: 12 new changesets

Changeset: 7e095c2db6b2 Author:ihse Date: 2017-02-07 11:09 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/7e095c2db6b2 8174064: Tab expansion broken for make Reviewed-by: erikj ! make/Init.gmk Changeset: 98503c50ee77 Author:ihse Date: 2017-02-07 12:17 +0100 URL: