Re: feedback on --permit-illegal-access

2017-04-07 Thread Alan Bateman
On 07/04/2017 00:09, Jochen Theodorou wrote: Hi, so today I found finally _JAVA_OPTIONS to get our gradle build running and of course I used --permit-illegal-access and I thought I give some feedback here. Running a clean test on our build will result in 44531 warning messages. Of which 63

Re: 8177530: Module system implementation refresh (4/2017)

2017-04-07 Thread Doug Simon
In light of https://bugs.openjdk.java.net/browse/JDK-8177845, I think it's fine to apply this webrev as is (wrt JVMCI/Graal changes anyway). I'll then adopt the changes into Graal and will rebase my 8177845 on them. -Doug > On 7 Apr 2017, at 00:40, Igor Veresov wrote: > > Hi Alan, > > The ch

Re: Disallowing the dynamic loading of agents by default (revised)

2017-04-07 Thread Andrew Dinn
On 06/04/17 18:48, Alasdair Nottingham wrote: > I think giving more time to react to the change is good, but I think this just > provides more notice that dynamic attach will go away, it doesn’t ultimately > provide a solution for the problems that are currently solved using dynamic > attach of age

Re: feedback on --permit-illegal-access

2017-04-07 Thread Jochen Theodorou
On 07.04.2017 09:11, Alan Bateman wrote: On 07/04/2017 00:09, Jochen Theodorou wrote: Hi, so today I found finally _JAVA_OPTIONS to get our gradle build running and of course I used --permit-illegal-access and I thought I give some feedback here. Running a clean test on our build will resul

hg: jigsaw/jake/jaxws: 2 new changesets

2017-04-07 Thread alan . bateman
Changeset: e4cd98db3249 Author:alanb Date: 2017-04-07 08:05 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/e4cd98db3249 8177530: Module system implementation refresh (4/2017) Reviewed-by: mchung ! src/java.xml.ws/share/classes/com/sun/xml/internal/ws/addressing/EPRSDD

hg: jigsaw/jake/jaxp: 2 new changesets

2017-04-07 Thread alan . bateman
Changeset: 554196039897 Author:alanb Date: 2017-04-07 08:05 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/554196039897 8177530: Module system implementation refresh (4/2017) Reviewed-by: mchung ! src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compi

hg: jigsaw/jake: 5 new changesets

2017-04-07 Thread alan . bateman
Changeset: 6fafcd0896fc Author:ihse Date: 2017-04-04 10:19 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/6fafcd0896fc 8177955: Add testing documentation Reviewed-by: erikj + common/doc/testing.html + common/doc/testing.md ! make/RunTests.gmk ! make/UpdateBuildDocs.gmk Chan

hg: jigsaw/jake/hotspot: 7 new changesets

2017-04-07 Thread alan . bateman
Changeset: 7587882381ad Author:iveresov Date: 2017-04-03 12:34 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/7587882381ad 8177856: [AOT] EliminateRedundantInitializationPhase is not working Summary: Looks for constants of a correct type Reviewed-by: kvn ! src/jdk.i

hg: jigsaw/jake/jdk: 21 new changesets

2017-04-07 Thread alan . bateman
Changeset: e9325773dd96 Author:bpb Date: 2017-04-03 16:40 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/e9325773dd96 8177526: BufferedReader readLine() javadoc does not match the implementation regarding EOF Summary: Improve the verbiage of the method and return value d

hg: jigsaw/jake/nashorn: 4 new changesets

2017-04-07 Thread alan . bateman
Changeset: 8bf1dab35084 Author:mchung Date: 2017-04-06 18:00 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/8bf1dab35084 8178286: Missing @moduleGraph in javadoc Reviewed-by: lancea ! src/jdk.dynalink/share/classes/module-info.java ! src/jdk.scripting.nashorn/share/c

hg: jigsaw/jake/langtools: 13 new changesets

2017-04-07 Thread alan . bateman
Changeset: f08f6a2f834c Author:ksrini Date: 2017-04-04 11:27 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/f08f6a2f834c 8176901: Internal error running javadoc over jdk internal classes Reviewed-by: jjg ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets

Re: SecurityManager environments

2017-04-07 Thread Alan Bateman
On 07/04/2017 03:54, Robert Muir wrote: : Because of these problems, if you are a server-side app, even if you understand this stuff and want to do the right thing, its really hard to avoid simply granting all kinds of horrible permissions globally to all code. In my experience the worst proble

RE: Disallowing the dynamic loading of agents by default (revised)

2017-04-07 Thread Stephen Felts
I have a problem with the second point. Oracle's application server has "FAST SWAP" functionality similar to JRebel built-in so that a developer can speed up the "edit -> build -> deploy -> test" cycle. It uses an internal agent that attaches to the server so customers don't need to see it, con

Re: Disallowing the dynamic loading of agents by default (revised)

2017-04-07 Thread Martijn Verburg
Hi all, I've come back into this thread late, but for us (jClarity) we're OK with the revised proposal, it will give us the time with slow moving enterprise customers to move to an explicit Java agent approach. Cheers, Martijn On 7 April 2017 at 13:53, Stephen Felts wrote: > I have a problem w

RFR 8178323: Add negative tests for bind services Jlink feature

2017-04-07 Thread Andrey Nazarov
Hi, Please review 3 negative tests for Jlink which tests new bind-services/suggest-providers feature. JBS: https://bugs.openjdk.java.net/browse/JDK-8178323 webrev: http://cr.openjdk.java.net/~anazarov/8178323/webrev.00/webrev/

Re: Review Request JDK-8175819: OS name and arch in JMOD files should match the values as in the bundle name

2017-04-07 Thread Mandy Chung
> On Apr 6, 2017, at 1:09 AM, Magnus Ihse Bursie > wrote: > > > Having though this over real hard, I'd realized I need to make a plea for > sanity and consistency. I thought I should lay low in this discussion, but I > can't. Choosing "amd64" as the name for the 64-bit x86 platform is really

Re: RFR 8178323: Add negative tests for bind services Jlink feature

2017-04-07 Thread Mandy Chung
> On Apr 7, 2017, at 8:40 AM, Andrey Nazarov > wrote: > > Hi, > > Please review 3 negative tests for Jlink which tests new > bind-services/suggest-providers feature. > > JBS: https://bugs.openjdk.java.net/browse/JDK-8178323 > > webrev: http://cr.openjdk.java.net/~anazarov/8178323/webrev.00

Review Request JDK-8177844: Ensure non-upgradeable modules cannot be upgraded even with --patch-module

2017-04-07 Thread Mandy Chung
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8177844/webrev.01/ This fixes -—patch-module to do hash checking on the module being patched so that it will ensure that a non-upgradeable module remains not upgradeable. As Graal has been using —-patch-module option to disable the hash checking to