Re: Review Request: JDK-8167558 Add new JMOD section for header files and man pages

2016-10-18 Thread Mandy Chung
> On Oct 18, 2016, at 9:29 AM, Alan Bateman wrote: > > > > On 17/10/2016 19:24, Mandy Chung wrote: >> Updated webrev: >> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8167558/webrev.01/ >> >> This updates the exclude-jmod-section plugin not to filt

Re: List of removed/internalized classes for Java 9

2016-10-18 Thread Mandy Chung
> On Oct 18, 2016, at 9:03 AM, Alan Bateman wrote: > > On 18/10/2016 15:52, Andrew Guibert wrote: > >> : >> >> So my question is: >> Is there a list of removed/internalized classes for java 9 anywhere? I >> would like to use this list to grep my codebase for soft references. >> >> > I don't

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

2016-10-19 Thread Mandy Chung
> On Oct 19, 2016, at 1:59 PM, Steve Drach wrote: > In JarArchive::entries then you filter out META-INF/MANIFEST.MF and I'm not sure that that is right (think modular JAR on the module path with a manifest, it's just a resource file). >>> I took that out and it still works as ex

Re: [9] RfR: 8165271: Fix use of reflection to gain access to private fields

2016-10-19 Thread Mandy Chung
> On Oct 19, 2016, at 3:50 PM, David DeHaven wrote: > > > Please review the new patch version: > http://cr.openjdk.java.net/~ddehaven/8165271/jdk.1/ > Looks okay but I think the new interface should be named “JavaNetURLClassLoaderAccess” (matching “URLClassLoader") > This was updated for th

Re: JDK-8166896: Static analyzer tool for split packages available?

2016-10-19 Thread Mandy Chung
66896 should be changed to > a JEP. In any case I added some more for that. > > What do you think? > > -Patrick > >> Am 29.09.2016 um 20:07 schrieb Mandy Chung : >> >> >>> On Sep 29, 2016, at 2:44 AM, Patrick Reinhart wrote: >>> >>

Request Review: JDK-6479237 (cl) Add support for classloader names

2016-10-25 Thread Mandy Chung
Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/6479237/webrev.00/ Specdiff: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/6479237/specdiff/overview-summary.html This is a long-standing RFE for adding support for class loader names. It's #ClassLoaderNames on JSR 376 issue li

Re: JDK-8166896: Static analyzer tool for split packages available?

2016-10-26 Thread Mandy Chung
into the existing tools. that > exist, as the the *jdeps“ tool. Now I wonder what I have to do, that a binary > executable to start the actual tool is being created for the different target > platforms. > > -Patrick > > >> Am 20.10.2016 um 01:55 schrieb Mandy C

Re: [9] RfR: 8167187: Exported elements referring to inaccessible types in jdk.jsobject

2016-10-26 Thread Mandy Chung
Looks good. Mandy > On Oct 26, 2016, at 1:05 PM, David DeHaven wrote: > > > Please review these fairly trivial patches for: > https://bugs.openjdk.java.net/browse/JDK-8167187 > > It was decided that since getWindow is deprecated and likely to be removed in > a future release that it's not wo

Re: Request Review: JDK-6479237 (cl) Add support for classloader names

2016-10-26 Thread Mandy Chung
> On Oct 26, 2016, at 4:08 PM, Paul Sandoz wrote: > : > > "; otherwise {@code null} if the class loader is not named.” > > : > “{@code null} if the class loader is not named.” > > : > “… or is not named…" Yup that reads better. I will update them. Thanks. Mandy

Review Request: JDK-8168205: Should not default class path to CWD if -cp is not specified but -m is specified

2016-10-26 Thread Mandy Chung
Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8168205/webrev.00/index.html If -cp is not specified and -m is not specified, the builtin system class loader will default the class path to the current working directory. If -m is specified, no -cp and CLASSPATH environment variable is

Re: Request Review: JDK-6479237 (cl) Add support for classloader names

2016-10-27 Thread Mandy Chung
> On Oct 27, 2016, at 7:30 AM, David M. Lloyd wrote: > > It looks like if you have a class loader name but not a module (i.e. it's > unnamed), you get output that looks like this: > >[...] >at > org.jboss.as.controller//org.jboss.as.controller.AbstractControllerService.boot(Ab

Re: Review Request: JDK-8168205: Should not default class path to CWD if -cp is not specified but -m is specified

2016-10-27 Thread Mandy Chung
> On Oct 27, 2016, at 2:44 AM, Alan Bateman wrote: > > The updated comment in ClassLoaders might be a bit clearer if you drop "if > defined”. > OK, dropped “if defined”. > A minor comment on the test is that it could use ProcessTools.executeTestJava > to avoid needing JAVA_TOOL. ProcessToo

Re: Review Request: JDK-8168205: Should not default class path to CWD if -cp is not specified but -m is specified

2016-10-27 Thread Mandy Chung
> On Oct 27, 2016, at 12:24 PM, Paul Sandoz wrote: > > >> On 26 Oct 2016, at 22:59, Mandy Chung wrote: >> >> Webrev: >> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8168205/webrev.00/index.html >> >> If -cp is not specified and -m is not

Re: 8168789: ModuleReader.list and ModuleFinder.of update

2016-10-27 Thread Mandy Chung
> On Oct 27, 2016, at 4:20 AM, Alan Bateman wrote: > > We have a lot changes in the jake forest. I need to bring some of the changes > that aren't tied to JSR issues into jdk9/dev to unblock others. > > Specifically, I'd like to bring over the changes that are needed to allow > jlink to suppo

Re: Request Review: JDK-6479237 (cl) Add support for classloader names

2016-10-27 Thread Mandy Chung
> On Oct 27, 2016, at 3:28 PM, Brent Christian > wrote: > > Hi, Mandy > > It looks pretty good to me. Just a couple small things: > > * StackTraceElement.java > > 379 ClassLoader loader = cls.getClassLoader0(); > > It looks as if 'loader' isn't used…? Good catch. Leftover cod

Re: Request Review: JDK-6479237 (cl) Add support for classloader names

2016-10-27 Thread Mandy Chung
> On Oct 27, 2016, at 3:01 AM, Alan Bateman wrote: > > One thing to check is getHashedModuleNames where it assumes the boot Layer > exists, I assume this has the potential to NPE if we have any cases where a > stack trace is printed during early startup. > Good catch. It should only call Has

Re: Request Review: JDK-6479237 (cl) Add support for classloader names

2016-10-27 Thread Mandy Chung
> On Oct 27, 2016, at 8:04 AM, David M. Lloyd wrote: > > OK Thanks. I was looking at the StackTraceElement#toString JavaDoc and it > was not very clear if this was the expected output; maybe it's worth pointing > out explicitly. http://cr.openjdk.java.net/~mchung/jdk9/webrevs/6479237/javadoc

Re: Request Review: JDK-6479237 (cl) Add support for classloader names

2016-10-28 Thread Mandy Chung
> On Oct 28, 2016, at 11:11 AM, Brent Christian > wrote: > > Should something be done for STEs returned from > StackFrameInfo.toStackTraceElement() ? Good catch - I missed it. I added package-private static methods in StackTraceElement class for both Throwable and StackFrameInfo to get Sta

Re: Request Review: JDK-6479237 (cl) Add support for classloader names

2016-10-28 Thread Mandy Chung
> On Oct 28, 2016, at 12:06 AM, serguei.spit...@oracle.com wrote: > > Can we give the bootstrap classloader the name "boot" or "bootstrap”? BootClassLoader is not the boostrap class loader but instead it's implementation details. The bootstrap ClassLoader instance is null and so you can’t i

hg: jigsaw/jake/jdk: 2 new changesets

2016-10-28 Thread mandy . chung
Changeset: b27959538721 Author:sdrach Date: 2016-10-28 13:00 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/b27959538721 Port changeset for 8164805: Fail to create a MR modular JAR with a versioned entry of a concealed package Reviewed-by: mchung ! src/jdk.jartool/share

hg: jigsaw/jake/jdk: Update jar tests for revised messages

2016-10-29 Thread mandy . chung
Changeset: 801524d2b608 Author:mchung Date: 2016-10-29 12:21 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/801524d2b608 Update jar tests for revised messages ! test/tools/jar/mmrjar/ConcealedPackage.java ! test/tools/jar/multiRelease/Basic.java

hg: jigsaw/jake/jdk: ResourceBundle.Control::newBundle reverts to call ClassLoader::getResource

2016-10-29 Thread mandy . chung
Changeset: 93346b3345a1 Author:mchung Date: 2016-10-29 19:12 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/93346b3345a1 ResourceBundle.Control::newBundle reverts to call ClassLoader::getResource ! src/java.base/share/classes/java/util/ResourceBundle.java + test/java/ut

hg: jigsaw/jake/jdk: Missing new test file. newBundle has to call ClassLoader::loadClass until a test fix

2016-10-29 Thread mandy . chung
Changeset: 344137ffc4af Author:mchung Date: 2016-10-29 22:00 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/344137ffc4af Missing new test file. newBundle has to call ClassLoader::loadClass until a test fix ! src/java.base/share/classes/java/util/ResourceBundle.java + te

Re: Request Review: JDK-6479237 (cl) Add support for classloader names

2016-10-31 Thread Mandy Chung
> On Oct 28, 2016, at 2:09 PM, David Holmes wrote: > > : > > Given the BootClassLoader instance is not in fact the boot loader at all I > think it would have been clearer and avoid potential confusion to call this > something more representative of its purpose - perhaps BootResourceloader or

hg: jigsaw/jake/corba: 3 new changesets

2016-10-31 Thread mandy . chung
Changeset: 408c9c621938 Author:rriggs Date: 2016-10-24 14:53 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/408c9c621938 8164908: ReflectionFactory support for IIOP and custom serialization Summary: Update IIOP Streams to use ReflectionFactory and Unsafe Reviewed-by: al

hg: jigsaw/jake: 8 new changesets

2016-10-31 Thread mandy . chung
Changeset: fbead0d3c815 Author:mchung Date: 2016-10-18 13:26 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/fbead0d3c815 8167558: Add new JMOD section for header files and man pages Reviewed-by: alanb ! make/CreateJmods.gmk ! make/Images.gmk Changeset: 1c9b94ce045e Author:

hg: jigsaw/jake/hotspot: 11 new changesets

2016-10-31 Thread mandy . chung
Changeset: 4567b6a9e7e9 Author:jiangli Date: 2016-05-12 17:37 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/4567b6a9e7e9 8156794: Extend data sharing Reviewed-by: iklam, hseigel, acorn, mschoene ! src/share/vm/runtime/arguments.cpp Changeset: 601485e5640a Author:

hg: jigsaw/jake/jdk: 63 new changesets

2016-10-31 Thread mandy . chung
Changeset: 4718506277f5 Author:mullan Date: 2016-10-17 15:31 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/4718506277f5 8165712: Grant permission to read specific properties instead of all to the jdk.crypto.ucrypto module Reviewed-by: xuelei ! src/java.base/solaris/lib

hg: jigsaw/jake/jaxp: 3 new changesets

2016-10-31 Thread mandy . chung
Changeset: bdafa0cc34a9 Author:aefimov Date: 2016-10-21 02:53 +0300 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/bdafa0cc34a9 8167179: Make XSL generated namespace prefixes local to transformation process Reviewed-by: joehw ! src/java.xml/share/classes/com/sun/org/apache/x

hg: jigsaw/jake/jaxws: 2 new changesets

2016-10-31 Thread mandy . chung
Changeset: 1c988e708a06 Author:lana Date: 2016-10-27 16:29 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/1c988e708a06 Added tag jdk-9+142 for changeset 59101416d901 ! .hgtags Changeset: 6e956bc711cb Author:mchung Date: 2016-10-31 13:03 -0700 URL: http:

hg: jigsaw/jake/nashorn: 8 new changesets

2016-10-31 Thread mandy . chung
Changeset: 0d5081c856bc Author:sundar Date: 2016-10-19 13:27 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/0d5081c856bc 8071588: The spec for javax.script.ScriptEngineFactory.getProgram() should specify NPEs thrown Reviewed-by: alanb, hannesw ! src/jdk.scripting.n

Re: Request Review: JDK-6479237 (cl) Add support for classloader names

2016-10-31 Thread Mandy Chung
> On Oct 31, 2016, at 6:51 AM, Alan Bateman wrote: >> >> if (VM.isModuleSystemInited() && !HashedModules.contains(m)) { > Looks okay, an alternative would be to move that that check to L439. What do you think about this? http://cr.openjdk.java.net/~mchung/jdk9/webrevs/6479237/webrev.03/ /

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

2016-10-31 Thread Mandy Chung
> On Oct 27, 2016, at 5:22 PM, Steve Drach wrote: > > I’ve put out another webrev, > http://cr.openjdk.java.net/~sdrach/8156499/webrev.05/, that addresses Mandy’s > concerns. In particular I demonstrate that the resultant image is “runnable” > and that a Main class in the image can/cannot fi

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

2016-10-31 Thread Mandy Chung
> On Oct 31, 2016, at 8:26 PM, Mandy Chung wrote: > > >> On Oct 27, 2016, at 5:22 PM, Steve Drach wrote: >> >> I’ve put out another webrev, >> http://cr.openjdk.java.net/~sdrach/8156499/webrev.05/, that addresses >> Mandy’s concerns. In particular I

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

2016-11-01 Thread Mandy Chung
> On Nov 1, 2016, at 2:44 PM, Steve Drach wrote: > > I’ve put out another webrev, http://cr.openjdk.java.net/~sdrach/8156499/webrev.05/, that addresses Mandy’s concerns. In particular I demonstrate that the resultant image is “runnable” and that a Main class in the image

Re: Request Review: JDK-6479237 (cl) Add support for classloader names

2016-11-01 Thread Mandy Chung
Hi Daniel, Here is the updated webrev incorporating your feedback: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/6479237/webrev.03 > On Nov 1, 2016, at 7:04 AM, Daniel Fuchs wrote: > > : > 334 s += declaringClass; > > > but should line 334 instead be > > s = (s.isEmpty() ?

hg: jigsaw/jake/langtools: jdeps support to generate module-info for open module

2016-11-02 Thread mandy . chung
Changeset: dce235fc8345 Author:mchung Date: 2016-11-02 10:34 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/dce235fc8345 jdeps support to generate module-info for open module ! src/jdk.jdeps/share/classes/com/sun/tools/jdeps/JdepsTask.java ! src/jdk.jdeps/share/cla

hg: jigsaw/jake/jdk: jar --print-module-descriptor missed to close the jar file

2016-11-02 Thread mandy . chung
Changeset: 2d63ca46f6db Author:mchung Date: 2016-11-02 10:40 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/2d63ca46f6db jar --print-module-descriptor missed to close the jar file ! src/jdk.jartool/share/classes/sun/tools/jar/Main.java ! test/tools/jar/mmrjar/ConcealedPa

Re: Request Review: JDK-6479237 (cl) Add support for classloader names

2016-11-02 Thread Mandy Chung
> On Nov 2, 2016, at 4:29 AM, Daniel Fuchs wrote: > > I'd suggest passing 'name' to 'checkCreateClassLoader()' and do > this check in checkCreateClassLoader instead - in order to do > the checks before 'this' is created. > Fixed. > That's not exactly what I had in mind. I don't have > any par

hg: jigsaw/jake/jdk: Fix tests that use normal and deep reflective access

2016-11-02 Thread mandy . chung
Changeset: 9ec1c05aaa68 Author:mchung Date: 2016-11-02 14:44 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/9ec1c05aaa68 Fix tests that use normal and deep reflective access ! test/com/sun/corba/serialization/ObjectStreamTest.java ! test/com/sun/crypto/provider/Cipher/PB

hg: jigsaw/jake/langtools: Generate one provides clause for each service interface with one or more providers

2016-11-02 Thread mandy . chung
Changeset: a8962f60d7d0 Author:mchung Date: 2016-11-02 17:15 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/a8962f60d7d0 Generate one provides clause for each service interface with one or more providers ! src/jdk.jdeps/share/classes/com/sun/tools/jdeps/ModuleInfo

hg: jigsaw/jake: Update build-time generated module-info.java for opens and provides directive

2016-11-02 Thread mandy . chung
Changeset: cffb6ba86fb4 Author:mchung Date: 2016-11-02 17:17 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/cffb6ba86fb4 Update build-time generated module-info.java for opens and provides directive ! make/GensrcModuleInfo.gmk

hg: jigsaw/jake/jdk: Update build-time generated module-info.java for opens and provides directive

2016-11-02 Thread mandy . chung
Changeset: c32a29f4613f Author:mchung Date: 2016-11-02 17:17 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/c32a29f4613f Update build-time generated module-info.java for opens and provides directive ! make/src/classes/build/tools/module/GenModuleInfoSource.java

hg: jigsaw/jake/jdk: fix tests for deep reflection access

2016-11-02 Thread mandy . chung
Changeset: 484681b43b87 Author:mchung Date: 2016-11-02 19:40 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/484681b43b87 fix tests for deep reflection access ! test/com/sun/crypto/provider/Cipher/AES/TestGHASH.java ! test/com/sun/crypto/provider/Cipher/PBE/CheckPBEKeySiz

hg: jigsaw/jake/jdk: use new jtreg :+open for normal and deep reflection access

2016-11-02 Thread mandy . chung
Changeset: 96556085b81d Author:mchung Date: 2016-11-02 22:02 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/96556085b81d use new jtreg :+open for normal and deep reflection access ! test/com/sun/corba/serialization/ObjectStreamTest.java ! test/com/sun/crypto/provider/Cip

hg: jigsaw/jake/corba: 2 new changesets

2016-11-05 Thread mandy . chung
Changeset: d4f1dae17409 Author:lana Date: 2016-11-04 17:24 + URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/d4f1dae17409 Added tag jdk-9+143 for changeset 6211236ef15e ! .hgtags Changeset: 48350ae6200f Author:mchung Date: 2016-11-05 12:02 -0700 URL: http:

hg: jigsaw/jake/hotspot: 85 new changesets

2016-11-05 Thread mandy . chung
Changeset: a2f56f1169d4 Author:rprotacio Date: 2016-09-29 13:32 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/a2f56f1169d4 8160064: StackWalker implementation added logging option without using UL Summary: Moved StackWalk logging to Unified Logging framework Reviewed

hg: jigsaw/jake: 19 new changesets

2016-11-05 Thread mandy . chung
Changeset: f5994f5d5041 Author:simonis Date: 2016-10-06 13:41 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/f5994f5d5041 8166800: [s390] Top-level build changes required for Linux/s390x Reviewed-by: erikj ! common/autoconf/flags.m4 ! common/autoconf/generated-configure.sh

hg: jigsaw/jake/jaxp: 4 new changesets

2016-11-05 Thread mandy . chung
Changeset: eb3b5f3ecb9a Author:joehw Date: 2016-10-31 09:29 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/eb3b5f3ecb9a 8069098: StAX produces the wrong event stream Reviewed-by: lancea ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLDocumentSca

hg: jigsaw/jake/jaxws: 2 new changesets

2016-11-05 Thread mandy . chung
Changeset: 92523c51d6a4 Author:lana Date: 2016-11-04 17:24 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/92523c51d6a4 Added tag jdk-9+143 for changeset 1c988e708a06 ! .hgtags Changeset: 76cf5c86865b Author:mchung Date: 2016-11-05 12:02 -0700 URL: http:

hg: jigsaw/jake/jdk: 90 new changesets

2016-11-05 Thread mandy . chung
Changeset: e5ee2bd22f3f Author:mli Date: 2016-10-24 21:44 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/e5ee2bd22f3f 8168505: Remove the intermittent keyword from java/util/Arrays/ParallelPrefix.java Reviewed-by: darcy, amlu ! test/java/util/Arrays/ParallelPrefix.java

hg: jigsaw/jake/nashorn: 5 new changesets

2016-11-05 Thread mandy . chung
Changeset: 96f47313aae7 Author:hannesw Date: 2016-10-28 16:52 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/96f47313aae7 8148924: Inconsistent "this" context in JSAdapter adaptee function calls Reviewed-by: jlaskey ! src/jdk.scripting.nashorn/share/classes/jdk/nash

Re: RFR: 8159393 - jlink should print a warning that a signed modular JAR will be treated as unsigned

2016-11-07 Thread Mandy Chung
> On Nov 7, 2016, at 5:48 AM, Jim Laskey (Oracle) > wrote: > > http://cr.openjdk.java.net/~jlaskey/8159393/webrev/index.html I notice that this webrev has been updated with the new -—ignore-signing-information option, which is fine. The following creates the image with IGNORE_SIGNING_DEFAULT

Re: RFR: JDK-8155756 - Better context for some jlink exceptions

2016-11-07 Thread Mandy Chung
> On Nov 7, 2016, at 9:43 AM, Jim Laskey (Oracle) > wrote: > > Only 2 of 3 examples still present. > > http://cr.openjdk.java.net/~jlaskey/8155756/webrev/index.html Looks okay to me. Mandy

hg: jigsaw/jake/jdk: 2 new changesets

2016-11-07 Thread mandy . chung
Changeset: 133257f8d51f Author:redestad Date: 2016-11-07 00:34 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/133257f8d51f Update SystemModuleDescriptorPlugin to emit provider lists as List.of() Reviewed-by: mchung, alanb ! src/java.base/share/classes/jdk/internal/module

hg: jigsaw/jake/jdk: Add qualified opens from java.desktop to jconsole

2016-11-07 Thread mandy . chung
Changeset: 7c9c0659c6e0 Author:mchung Date: 2016-11-07 13:37 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/7c9c0659c6e0 Add qualified opens from java.desktop to jconsole ! make/launcher/Launcher-jdk.jconsole.gmk ! src/java.desktop/share/classes/module-info.java

hg: jigsaw/jake/langtools: 16 new changesets

2016-11-07 Thread mandy . chung
Changeset: f7187b5fe9e2 Author:rfield Date: 2016-10-24 19:59 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/f7187b5fe9e2 8166649: jshell tool: missing --add-modules and --module-path 8167462: jshell tool: /help /reload is wrong about re-executing commands Reviewed-b

hg: jigsaw/jake/nashorn: Add module javadoc to nashorn modules to workaround build error

2016-11-07 Thread mandy . chung
Changeset: 2c70a0485b7c Author:mchung Date: 2016-11-07 15:21 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/2c70a0485b7c Add module javadoc to nashorn modules to workaround build error ! src/jdk.dynalink/share/classes/module-info.java ! src/jdk.scripting.nashorn.shel

hg: jigsaw/jake/jdk: 2 new changesets

2016-11-07 Thread mandy . chung
Changeset: 2ce9c7477e52 Author:sdrach Date: 2016-10-31 10:08 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/2ce9c7477e52 Add a warning message to jar tool when unexpected entry is found in versioned directory. Reviewed-by: mchung Contributed-by: steve.dr...@oracle.com !

hg: jigsaw/jake/hotspot: Update jake for the fix for JDK-6479237

2016-11-07 Thread mandy . chung
Changeset: 0778dd3211ac Author:mchung Date: 2016-11-07 16:10 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/0778dd3211ac Update jake for the fix for JDK-6479237 ! make/symbols/symbols-unix ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvm.h

hg: jigsaw/jake/jdk: Update GenModuleInfoSource to filter qualified exports/open for known modules

2016-11-08 Thread mandy . chung
Changeset: 8cb1876c41b8 Author:mchung Date: 2016-11-08 11:58 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/8cb1876c41b8 Update GenModuleInfoSource to filter qualified exports/open for known modules ! make/src/classes/build/tools/module/GenModuleInfoSource.java ! src/jd

Re: RFR 8160359: Improve jlink logging for cases when a plugin throws exception

2016-11-08 Thread Mandy Chung
Sundar, Have you considered for plugins to throw different type of exceptions to differentiate if jlink should gracefully exit with no stack trace. For example if it’s an user-error e.g. invalid option or duplicated entries then jlink can simply print the error message. For unexpected error s

hg: jigsaw/jake/jdk: test/sun/security/krb5/tools/KtabZero.java failing

2016-11-08 Thread mandy . chung
Changeset: ad992df4769b Author:mchung Date: 2016-11-08 14:14 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/ad992df4769b test/sun/security/krb5/tools/KtabZero.java failing ! test/sun/security/krb5/tools/KtabZero.java

hg: jigsaw/jake/langtools: Fix test/jdk/jshell/JavadocTest.java failing

2016-11-08 Thread mandy . chung
Changeset: 77b8374f80e8 Author:mchung Date: 2016-11-08 14:18 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/77b8374f80e8 Fix test/jdk/jshell/JavadocTest.java failing ! test/jdk/jshell/JavadocTest.java

hg: jigsaw/jake/jaxws: open classes passed to JAXB context for deep reflection

2016-11-09 Thread mandy . chung
Changeset: 6afd825302f0 Author:mchung Date: 2016-11-09 09:57 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/6afd825302f0 open classes passed to JAXB context for deep reflection ! src/java.xml.ws/share/classes/module-info.java

hg: jigsaw/jake: 7 new changesets

2016-11-10 Thread mandy . chung
Changeset: bf83e4c950e0 Author:rfield Date: 2016-11-02 16:21 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/bf83e4c950e0 8168974: Editor support: include properties file in image Reviewed-by: jlahoda ! make/CompileJavaModules.gmk Changeset: fe1e5f27b071 Author:alexsch D

hg: jigsaw/jake/hotspot: 3 new changesets

2016-11-10 Thread mandy . chung
Changeset: 48fce55afe71 Author:mchung Date: 2016-11-03 18:08 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/48fce55afe71 6479237: (cl) Add support for classloader names Reviewed-by: alanb, bchristi, coleenp, dfuchs, lfoltan, psandoz, sspitsyn ! make/symbols/symbols-u

hg: jigsaw/jake/nashorn: 2 new changesets

2016-11-10 Thread mandy . chung
Changeset: a7f21ee6ed30 Author:hannesw Date: 2016-11-07 14:48 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/a7f21ee6ed30 8156619: Unimplemented ES6 features should result in clear Error being thrown Reviewed-by: sundar, attila ! src/jdk.scripting.nashorn/share/clas

hg: jigsaw/jake/jdk: 40 new changesets

2016-11-10 Thread mandy . chung
Changeset: 0fa4b5647f3e Author:igerasim Date: 2016-11-02 18:45 +0300 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/0fa4b5647f3e 8168923: Use unsigned random long in a temp directory name Reviewed-by: bpb, alanb ! src/java.base/share/classes/java/io/File.java ! src/java.base/s

hg: jigsaw/jake/jaxp: 2 new changesets

2016-11-10 Thread mandy . chung
Changeset: 71558b38bad7 Author:lana Date: 2016-11-11 05:11 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/71558b38bad7 Added tag jdk-9+144 for changeset 99be33734ff6 ! .hgtags Changeset: f4a78af5217d Author:mchung Date: 2016-11-10 22:07 -0800 URL: http:/

hg: jigsaw/jake: 2 new changesets

2016-11-10 Thread mandy . chung
Changeset: 7493bf3d3459 Author:lana Date: 2016-11-11 05:11 + URL: http://hg.openjdk.java.net/jigsaw/jake/rev/7493bf3d3459 Added tag jdk-9+144 for changeset 8d337fd6333e ! .hgtags Changeset: 5e14a784c3e9 Author:mchung Date: 2016-11-10 22:07 -0800 URL: http://hg.o

hg: jigsaw/jake/corba: 2 new changesets

2016-11-10 Thread mandy . chung
Changeset: a44b156ae7f0 Author:lana Date: 2016-11-11 05:11 + URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/a44b156ae7f0 Added tag jdk-9+144 for changeset d4f1dae17409 ! .hgtags Changeset: 78bef2c5feaa Author:mchung Date: 2016-11-10 22:07 -0800 URL: http:

hg: jigsaw/jake/jdk: 2 new changesets

2016-11-10 Thread mandy . chung
Changeset: b1fc95093f8c Author:lana Date: 2016-11-11 05:11 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/b1fc95093f8c Added tag jdk-9+144 for changeset efa71dc820eb ! .hgtags Changeset: 603b55db60a0 Author:mchung Date: 2016-11-10 22:07 -0800 URL: http://

hg: jigsaw/jake/jaxws: 2 new changesets

2016-11-10 Thread mandy . chung
Changeset: 29277a4e7307 Author:lana Date: 2016-11-11 05:11 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/29277a4e7307 Added tag jdk-9+144 for changeset 92523c51d6a4 ! .hgtags Changeset: b00722c934c1 Author:mchung Date: 2016-11-10 22:07 -0800 URL: http:

hg: jigsaw/jake/hotspot: 2 new changesets

2016-11-10 Thread mandy . chung
Changeset: 61e7ea563123 Author:lana Date: 2016-11-11 05:11 + URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/61e7ea563123 Added tag jdk-9+144 for changeset 6187b582d02a ! .hgtags Changeset: 0f9e92e45931 Author:mchung Date: 2016-11-10 22:07 -0800 URL: htt

hg: jigsaw/jake/langtools: 2 new changesets

2016-11-10 Thread mandy . chung
Changeset: 2ce7c1083dcb Author:lana Date: 2016-11-11 05:11 + URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/2ce7c1083dcb Added tag jdk-9+144 for changeset 47871e348144 ! .hgtags Changeset: 1520a026cd3e Author:mchung Date: 2016-11-10 22:07 -0800 URL: h

hg: jigsaw/jake/nashorn: 2 new changesets

2016-11-10 Thread mandy . chung
Changeset: 37ac000ae6b1 Author:lana Date: 2016-11-11 05:11 + URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/37ac000ae6b1 Added tag jdk-9+144 for changeset a7f21ee6ed30 ! .hgtags Changeset: 9438e71128ed Author:mchung Date: 2016-11-10 22:07 -0800 URL: htt

Re: RFR 8153038: The set of jlink plugins enabled by default should be the same via CLI or jlink API

2016-11-16 Thread Mandy Chung
Looks okay. Mandy > On Nov 16, 2016, at 12:30 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8153038/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8153038 > > PS. Pre-existing IntegrationTest.java test already checks the Jlink API c

hg: jigsaw/jake/jdk: Fix tests to use --add-opens

2016-11-16 Thread mandy . chung
Changeset: ad153b3d457d Author:mchung Date: 2016-11-16 11:18 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/ad153b3d457d Fix tests to use --add-opens ! test/java/awt/Toolkit/Headless/WrappedToolkitTest/WrappedToolkitTest.sh ! test/java/util/ResourceBundle/modules/unnamed

hg: jigsaw/jake/jdk: 8169339: Provide internal API to JavaFX to locate JDK fonts

2016-11-16 Thread mandy . chung
Changeset: 21f7c4aaeb68 Author:prr Date: 2016-11-09 10:26 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/21f7c4aaeb68 8169339: Provide internal API to JavaFX to locate JDK fonts Reviewed-by: serb, kcr ! src/java.desktop/share/classes/sun/font/SunFontManager.java + src/ja

Proposal to move src.zip and jrt-fs.zip to the `lib` directory in the run-time image

2016-11-16 Thread Mandy Chung
Several files in a runtime image are intended for external uses and their pathname is a committed interface, including: jrt-fs.jar src.zip lib/javafx-swt.jar lib/ant-javafx.jar The `lib` directory in the runtime image currently defined in JEP 220 is private implementation and for int

hg: jigsaw/jake/langtools: 10 new changesets

2016-11-17 Thread mandy . chung
Changeset: 6cc2220006f2 Author:lana Date: 2016-11-11 05:56 + URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/6cc2220006f2 Merge Changeset: eb48b040fbc2 Author:jlahoda Date: 2016-11-11 12:54 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/re

hg: jigsaw/jake/nashorn: 5 new changesets

2016-11-17 Thread mandy . chung
Changeset: cb625e28d779 Author:attila Date: 2016-11-11 15:50 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/cb625e28d779 8168373: don't emit conversions for symbols outside their lexical scope Reviewed-by: hannesw, sundar ! src/jdk.scripting.nashorn/share/classes/jd

hg: jigsaw/jake/jaxp: 2 new changesets

2016-11-17 Thread mandy . chung
Changeset: 4f68472a3623 Author:lana Date: 2016-11-17 17:50 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/4f68472a3623 Added tag jdk-9+145 for changeset 71558b38bad7 ! .hgtags Changeset: dac05614acb1 Author:mchung Date: 2016-11-17 18:04 -0800 URL: http:/

hg: jigsaw/jake/jdk: 26 new changesets

2016-11-17 Thread mandy . chung
Changeset: 762dad364838 Author:jlaskey Date: 2016-11-07 14:36 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/762dad364838 8155756: Better context for some jlink exceptions Reviewed-by: mchung ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/DirArchive.java ! src/jd

hg: jigsaw/jake: 4 new changesets

2016-11-17 Thread mandy . chung
Changeset: 3b59ad58041d Author:simonis Date: 2016-11-14 11:48 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/3b59ad58041d 8169630: Fix wrong cpu build flag for Linux/ppc64le build Reviewed-by: erikj ! common/autoconf/flags.m4 ! common/autoconf/generated-configure.sh Changes

hg: jigsaw/jake/corba: 2 new changesets

2016-11-17 Thread mandy . chung
Changeset: ecd74b41ab65 Author:lana Date: 2016-11-17 17:50 + URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/ecd74b41ab65 Added tag jdk-9+145 for changeset a44b156ae7f0 ! .hgtags Changeset: be54656af21d Author:mchung Date: 2016-11-17 18:04 -0800 URL: http:

hg: jigsaw/jake/hotspot: 2 new changesets

2016-11-17 Thread mandy . chung
Changeset: 225b91f1b118 Author:lana Date: 2016-11-17 17:50 + URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/225b91f1b118 Added tag jdk-9+145 for changeset 61e7ea563123 ! .hgtags Changeset: 5f1fd16ade77 Author:mchung Date: 2016-11-17 18:04 -0800 URL: htt

hg: jigsaw/jake/jaxws: 2 new changesets

2016-11-17 Thread mandy . chung
Changeset: e997d835cfee Author:lana Date: 2016-11-17 17:50 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/e997d835cfee Added tag jdk-9+145 for changeset 29277a4e7307 ! .hgtags Changeset: 8e8d9cd2f887 Author:mchung Date: 2016-11-17 18:04 -0800 URL: http:

hg: jigsaw/jake/jdk: Merge multiple provides of the same service type

2016-11-17 Thread mandy . chung
Changeset: e2110950087f Author:mchung Date: 2016-11-17 22:06 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/e2110950087f Merge multiple provides of the same service type ! src/java.desktop/share/classes/module-info.java ! src/jdk.jdi/share/classes/module-info.java ! src/

hg: jigsaw/jake/hotspot: Merge multiple provides of the same service type

2016-11-17 Thread mandy . chung
Changeset: 1273e7cc048b Author:mchung Date: 2016-11-17 21:10 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/1273e7cc048b Merge multiple provides of the same service type ! src/jdk.vm.ci/share/classes/module-info.java

hg: jigsaw/jake/jaxws: Merge multiple provides of the same service type

2016-11-17 Thread mandy . chung
Changeset: 77a73360ee6b Author:mchung Date: 2016-11-17 21:09 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/77a73360ee6b Merge multiple provides of the same service type ! src/jdk.xml.bind/share/classes/module-info.java ! src/jdk.xml.ws/share/classes/module-info.java

hg: jigsaw/jake/langtools: 2 new changesets

2016-11-17 Thread mandy . chung
Changeset: e25e195084d7 Author:mchung Date: 2016-11-17 21:09 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/e25e195084d7 Fix test to use requires transitive ! test/tools/javac/modules/InvalidModuleDirective/module-info.java Changeset: 30107007ddc8 Author:mchun

hg: jigsaw/jake/jdk: Revert provides change until javadoc supports it.

2016-11-17 Thread mandy . chung
Changeset: cc82cebf8689 Author:mchung Date: 2016-11-17 22:58 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/cc82cebf8689 Revert provides change until javadoc supports it. ! src/java.desktop/share/classes/module-info.java ! src/jdk.jdi/share/classes/module-info.java ! src

Re: RFR: JDK-8168256 - Plugin alias options in jlink --help output seems to be in an arbitrary order

2016-11-18 Thread Mandy Chung
> On Nov 16, 2016, at 7:00 AM, Jim Laskey (Oracle) > wrote: > > Sorts options by full name > > http://cr.openjdk.java.net/~jlaskey/8168256/webrev/index.html > https://bugs.openjdk.java.net/browse/JDK-8168256 > 113 public Option(boolean hasArg, Processing processing, String name, St

hg: jigsaw/jake/hotspot: Remove --add-exports-private option

2016-11-21 Thread mandy . chung
Changeset: 8f2d918e0619 Author:mchung Date: 2016-11-21 11:07 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/8f2d918e0619 Remove --add-exports-private option ! src/share/vm/runtime/arguments.cpp

hg: jigsaw/jake/jaxp: Fix test that uses deep reflection

2016-11-21 Thread mandy . chung
Changeset: 23e94a1d726d Author:mchung Date: 2016-11-21 11:07 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/23e94a1d726d Fix test that uses deep reflection ! test/javax/xml/jaxp/functional/catalog/DeferFeatureTest.java

hg: jigsaw/jake/jdk: 5 new changesets

2016-11-21 Thread mandy . chung
Changeset: 375b859caf2e Author:mchung Date: 2016-11-21 11:03 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/375b859caf2e Clean up jlink/jmod code ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/

Review Request: JDK-8169816 Move src.zip and jrt-fs.jar under the lib directory

2016-11-22 Thread Mandy Chung
This patch moves src.zip and jrt-fs.jar from the top-level into the `lib` directory in the run-time image as we proposed [1]. Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8169816/webrev.00/ thanks Mandy [1] http://mail.openjdk.java.net/pipermail/jigsaw-dev/2016-November/010128.html

hg: jigsaw/jake/jdk: Minor typo in com.sun.jdi.ModuleReference class spec

2016-11-22 Thread mandy . chung
Changeset: ea07cfe18be3 Author:mchung Date: 2016-11-22 13:23 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/ea07cfe18be3 Minor typo in com.sun.jdi.ModuleReference class spec ! src/jdk.jdi/share/classes/com/sun/jdi/ModuleReference.java

<    1   2   3   4   5   6   7   8   9   10   >