[GitHub] [kafka] guozhangwang commented on a change in pull request #8629: MINOR: Update nodesWithPendingFetchRequests in Fetcher before sending request

2020-05-06 Thread GitBox
guozhangwang commented on a change in pull request #8629: URL: https://github.com/apache/kafka/pull/8629#discussion_r421258033 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -258,12 +258,12 @@ public synchronized int sendFetc

[GitHub] [kafka] guozhangwang commented on pull request #8629: MINOR: Update nodesWithPendingFetchRequests in Fetcher before sending request

2020-05-06 Thread GitBox
guozhangwang commented on pull request #8629: URL: https://github.com/apache/kafka/pull/8629#issuecomment-625046006 @mjsax @hachikuji With #8600, I still get various errors (hanging on global restoration, consumer not getting all records in time, etc) every about 170 runs; with this

[GitHub] [kafka] guozhangwang opened a new pull request #8629: MINOR: Update nodesWithPendingFetchRequests in Fetcher before sending request

2020-05-06 Thread GitBox
guozhangwang opened a new pull request #8629: URL: https://github.com/apache/kafka/pull/8629 It is possible that: 1. caller thread triggers `client.send()` is called with the request, and wakes up the client. 2. heartbeat thread triggers `client.poll()` and gets the response back,

[jira] [Updated] (KAFKA-9967) SASL PLAIN authentication with custom callback handler

2020-05-06 Thread indira (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] indira updated KAFKA-9967: -- Description: I'm trying to add custom handler for SASL PLAN authentication. i have followed kafka document whi

[jira] [Created] (KAFKA-9967) SASL PLAIN authentication with custom callback handler

2020-05-06 Thread indira (Jira)
indira created KAFKA-9967: - Summary: SASL PLAIN authentication with custom callback handler Key: KAFKA-9967 URL: https://issues.apache.org/jira/browse/KAFKA-9967 Project: Kafka Issue Type: Bug

[GitHub] [kafka] cmccabe commented on pull request #8627: MINOR - Increase Trogdor Histogram buckets for latency to 10000ms

2020-05-06 Thread GitBox
cmccabe commented on pull request #8627: URL: https://github.com/apache/kafka/pull/8627#issuecomment-625017914 test failure is not related This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [kafka] showuon commented on pull request #8623: MINOR: Update the documentations

2020-05-06 Thread GitBox
showuon commented on pull request #8623: URL: https://github.com/apache/kafka/pull/8623#issuecomment-625012168 Hi @kkonstantine , could you please review this small PR? Thanks. This is an automated message from the Apache Git

[GitHub] [kafka] showuon commented on pull request #8622: MINOR: Update stream documentation

2020-05-06 Thread GitBox
showuon commented on pull request #8622: URL: https://github.com/apache/kafka/pull/8622#issuecomment-625011283 Hi @bbejeck , could you please review this small PR? Thanks. This is an automated message from the Apache Git Serv

[GitHub] [kafka] feyman2016 commented on pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-06 Thread GitBox
feyman2016 commented on pull request #8589: URL: https://github.com/apache/kafka/pull/8589#issuecomment-625008508 @abbccdda Hey, updated based on comments, and also left some comments there, thanks. This is an automated mes

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-06 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r421216977 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -3612,6 +3611,27 @@ private boolean dependsOnSpecificNode

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-06 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r421216617 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -3612,6 +3611,27 @@ private boolean dependsOnSpecificNode

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-06 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r421216746 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/RemoveMembersFromConsumerGroupOptions.java ## @@ -32,12 +32,23 @@ public class Remov

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-06 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r420824572 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -3612,6 +3611,27 @@ private boolean dependsOnSpecificNode

[jira] [Comment Edited] (KAFKA-9660) KAFKA-1 build a kafka-exporter by java

2020-05-06 Thread HaiyuanZhao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17101334#comment-17101334 ] HaiyuanZhao edited comment on KAFKA-9660 at 5/7/20, 3:04 AM: -

[jira] [Commented] (KAFKA-9660) KAFKA-1 build a kafka-exporter by java

2020-05-06 Thread HaiyuanZhao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17101334#comment-17101334 ] HaiyuanZhao commented on KAFKA-9660: I am interested in this proposal :) > KAFKA-1

[jira] [Commented] (KAFKA-9929) Support reverse iterator on WindowStore

2020-05-06 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17101306#comment-17101306 ] Guozhang Wang commented on KAFKA-9929: -- I looked at the RocksIterator iterator, and

[GitHub] [kafka] kkonstantine commented on pull request #8618: KAFKA-9955: Prevent SinkTask::close from shadowing other exceptions

2020-05-06 Thread GitBox
kkonstantine commented on pull request #8618: URL: https://github.com/apache/kafka/pull/8618#issuecomment-624979305 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] kkonstantine commented on a change in pull request #8618: KAFKA-9955: Prevent SinkTask::close from shadowing other exceptions

2020-05-06 Thread GitBox
kkonstantine commented on a change in pull request #8618: URL: https://github.com/apache/kafka/pull/8618#discussion_r421189122 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java ## @@ -193,13 +194,11 @@ public void transitionTo(Tar

[GitHub] [kafka] kkonstantine commented on a change in pull request #8618: KAFKA-9955: Prevent SinkTask::close from shadowing other exceptions

2020-05-06 Thread GitBox
kkonstantine commented on a change in pull request #8618: URL: https://github.com/apache/kafka/pull/8618#discussion_r421188159 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.java ## @@ -856,6 +858,47 @@ public void run() {

[jira] [Resolved] (KAFKA-9768) rest.advertised.listener configuration is not handled properly by the worker

2020-05-06 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis resolved KAFKA-9768. --- Resolution: Fixed > rest.advertised.listener configuration is not handled pro

[jira] [Updated] (KAFKA-9768) rest.advertised.listener configuration is not handled properly by the worker

2020-05-06 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-9768: -- Fix Version/s: 2.5.1 2.6.0 > rest.advertised.listener config

[jira] [Updated] (KAFKA-9768) rest.advertised.listener configuration is not handled properly by the worker

2020-05-06 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-9768: -- Fix Version/s: 2.4.2 > rest.advertised.listener configuration is not handled pr

[jira] [Commented] (KAFKA-9966) Flaky Test EosBetaUpgradeIntegrationTest#shouldUpgradeFromEosAlphaToEosBeta

2020-05-06 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17101293#comment-17101293 ] Matthias J. Sax commented on KAFKA-9966: Might be related to KAFKA-9831. > Flaky

[jira] [Assigned] (KAFKA-9966) Flaky Test EosBetaUpgradeIntegrationTest#shouldUpgradeFromEosAlphaToEosBeta

2020-05-06 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-9966: -- Assignee: Matthias J. Sax > Flaky Test EosBetaUpgradeIntegrationTest#shouldUpgradeFrom

[jira] [Created] (KAFKA-9966) Flaky Test EosBetaUpgradeIntegrationTest#shouldUpgradeFromEosAlphaToEosBeta

2020-05-06 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-9966: -- Summary: Flaky Test EosBetaUpgradeIntegrationTest#shouldUpgradeFromEosAlphaToEosBeta Key: KAFKA-9966 URL: https://issues.apache.org/jira/browse/KAFKA-9966 Project

[GitHub] [kafka] kkonstantine commented on pull request #8360: KAFKA-9768: Fix handling of rest.advertised.listener config

2020-05-06 Thread GitBox
kkonstantine commented on pull request #8360: URL: https://github.com/apache/kafka/pull/8360#issuecomment-624970463 Only a couple streams integration test failures in every jdk. These are unrelated to this PR, so I'm merging. Thanks for the fix @C0urante ! -

[jira] [Commented] (KAFKA-9949) Flaky Test GlobalKTableIntegrationTest#shouldKStreamGlobalKTableLeftJoin

2020-05-06 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17101291#comment-17101291 ] Matthias J. Sax commented on KAFKA-9949: [https://builds.apache.org/job/kafka-pr-

[GitHub] [kafka] mjsax commented on pull request #8603: MINOR: Fix ProcessorContext JavaDocs

2020-05-06 Thread GitBox
mjsax commented on pull request #8603: URL: https://github.com/apache/kafka/pull/8603#issuecomment-624970217 Java 8: `org.apache.kafka.streams.integration.GlobalKTableEOSIntegrationTest.shouldKStreamGlobalKTableJoin[exactly_once_beta]` Java 11: timed out Java 14: ``` org.apache

[GitHub] [kafka] mjsax commented on pull request #8621: KAFKA-9466: Update Kafka Streams docs for KIP-447

2020-05-06 Thread GitBox
mjsax commented on pull request #8621: URL: https://github.com/apache/kafka/pull/8621#issuecomment-624968745 @abbccdda Updated this PR -- added more details and fixed some links and inconsistencies. This is an automated mess

[GitHub] [kafka] mjsax commented on a change in pull request #8621: KAFKA-9466: Update Kafka Streams docs for KIP-447

2020-05-06 Thread GitBox
mjsax commented on a change in pull request #8621: URL: https://github.com/apache/kafka/pull/8621#discussion_r421167972 ## File path: docs/streams/core-concepts.html ## @@ -206,16 +206,16 @@ Pr to the stream processing pipeline, known as the http://lambda-architecture.

[GitHub] [kafka] mjsax commented on a change in pull request #8621: KAFKA-9466: Update Kafka Streams docs for KIP-447

2020-05-06 Thread GitBox
mjsax commented on a change in pull request #8621: URL: https://github.com/apache/kafka/pull/8621#discussion_r421166821 ## File path: docs/upgrade.html ## @@ -19,6 +19,12 @@

[jira] [Created] (KAFKA-9965) Uneven distribution with RoundRobinPartitioner in AK 2.4+

2020-05-06 Thread Michael Bingham (Jira)
Michael Bingham created KAFKA-9965: -- Summary: Uneven distribution with RoundRobinPartitioner in AK 2.4+ Key: KAFKA-9965 URL: https://issues.apache.org/jira/browse/KAFKA-9965 Project: Kafka I

[jira] [Resolved] (KAFKA-9964) Better description of RoundRobinPartitioner behavior for AK 2.4+

2020-05-06 Thread Michael Bingham (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Bingham resolved KAFKA-9964. Resolution: Invalid > Better description of RoundRobinPartitioner behavior for AK 2.4+ > --

[jira] [Commented] (KAFKA-9964) Better description of RoundRobinPartitioner behavior for AK 2.4+

2020-05-06 Thread Michael Bingham (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17101266#comment-17101266 ] Michael Bingham commented on KAFKA-9964: Closing this out. Turns out the issue is

[GitHub] [kafka] jeffhuang26 commented on a change in pull request #8620: KAFKA-9944: Added supporting customized HTTP response headers for Kafka Connect.

2020-05-06 Thread GitBox
jeffhuang26 commented on a change in pull request #8620: URL: https://github.com/apache/kafka/pull/8620#discussion_r421147218 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/RestServerTest.java ## @@ -392,6 +395,98 @@ public void testDisableAd

[jira] [Updated] (KAFKA-9419) Integer Overflow Possible with CircularIterator

2020-05-06 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-9419: -- Fix Version/s: 2.5.1 2.4.2 2.6.0

[jira] [Resolved] (KAFKA-9419) Integer Overflow Possible with CircularIterator

2020-05-06 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis resolved KAFKA-9419. --- Resolution: Fixed > Integer Overflow Possible with CircularIterator > ---

[GitHub] [kafka] jeffhuang26 commented on a change in pull request #8620: KAFKA-9944: Added supporting customized HTTP response headers for Kafka Connect.

2020-05-06 Thread GitBox
jeffhuang26 commented on a change in pull request #8620: URL: https://github.com/apache/kafka/pull/8620#discussion_r421147218 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/RestServerTest.java ## @@ -392,6 +395,98 @@ public void testDisableAd

[GitHub] [kafka] kkonstantine commented on pull request #7950: KAFKA-9419: Integer Overflow Possible with CircularIterator

2020-05-06 Thread GitBox
kkonstantine commented on pull request #7950: URL: https://github.com/apache/kafka/pull/7950#issuecomment-624933756 jdk 8: stellar jdk 11: 2 streams eos test failures: unrelated jkd 14: 1 more unrelated failure (`kafka.api.TransactionsTest.testBumpTransactionalEpoch`) Given thi

[jira] [Created] (KAFKA-9964) Better description of RoundRobinPartitioner behavior for AK 2.4+

2020-05-06 Thread Michael Bingham (Jira)
Michael Bingham created KAFKA-9964: -- Summary: Better description of RoundRobinPartitioner behavior for AK 2.4+ Key: KAFKA-9964 URL: https://issues.apache.org/jira/browse/KAFKA-9964 Project: Kafka

[jira] [Resolved] (KAFKA-9947) TransactionsBounceTest may leave threads running

2020-05-06 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-9947. Resolution: Fixed > TransactionsBounceTest may leave threads running >

[jira] [Updated] (KAFKA-9963) High CPU during replication of replaced (empty) broker

2020-05-06 Thread Evan Williams (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Evan Williams updated KAFKA-9963: - Description: When replacing a broker, with an empty data dir, and the same broker ID - we are se

[jira] [Updated] (KAFKA-9963) High CPU during replication of replaced (empty) broker

2020-05-06 Thread Evan Williams (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Evan Williams updated KAFKA-9963: - Description: When replacing a broker, with an empty data dir, and the same broker ID - we are se

[jira] [Updated] (KAFKA-9963) High CPU during replication of replaced (empty) broker

2020-05-06 Thread Evan Williams (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Evan Williams updated KAFKA-9963: - Summary: High CPU during replication of replaced (empty) broker (was: High CPU) > High CPU duri

[jira] [Updated] (KAFKA-9963) High CPU

2020-05-06 Thread Evan Williams (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Evan Williams updated KAFKA-9963: - Description: When replacing a broker, with an empty data dir, and the same broker ID - we are se

[jira] [Updated] (KAFKA-9963) High CPU

2020-05-06 Thread Evan Williams (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Evan Williams updated KAFKA-9963: - Description: When replacing a broker, with an empty data dir, and the same broker ID - we are se

[jira] [Updated] (KAFKA-9963) High CPU

2020-05-06 Thread Evan Williams (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Evan Williams updated KAFKA-9963: - Description: When replacing a broker, with an empty data dir, and the same broker ID - we are se

[jira] [Updated] (KAFKA-9963) High CPU

2020-05-06 Thread Evan Williams (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Evan Williams updated KAFKA-9963: - Description: When replacing a broker, with an empty data dir, and the same broker ID - we are se

[jira] [Updated] (KAFKA-9963) High CPU

2020-05-06 Thread Evan Williams (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Evan Williams updated KAFKA-9963: - Description: When replacing a broker, with an empty data dir, and the same broker ID - we are se

[jira] [Updated] (KAFKA-9963) High CPU

2020-05-06 Thread Evan Williams (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Evan Williams updated KAFKA-9963: - Description: When replacing a broker, with an empty data dir, and the same broker ID - we are se

[jira] [Created] (KAFKA-9963) High CPU

2020-05-06 Thread Evan Williams (Jira)
Evan Williams created KAFKA-9963: Summary: High CPU Key: KAFKA-9963 URL: https://issues.apache.org/jira/browse/KAFKA-9963 Project: Kafka Issue Type: Bug Components: core Affects

[jira] [Commented] (KAFKA-9921) Caching is not working properly with WindowStateStore when retaining duplicates

2020-05-06 Thread Georgi Petkov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17101215#comment-17101215 ] Georgi Petkov commented on KAFKA-9921: -- Maybe we can add the same information on the

[GitHub] [kafka] bdbyrne opened a new pull request #8628: KAFKA-9942: Fixes ConfigCommand client quotas w/ default users.

2020-05-06 Thread GitBox
bdbyrne opened a new pull request #8628: URL: https://github.com/apache/kafka/pull/8628 Fixes ConfigCommand client quotas w/ default users when using --bootstrap-servers. Test is expanded to handle all valid (user, client-id) enumerations. ### Committer Checklist (excluded fro

[GitHub] [kafka] rhauch commented on pull request #8379: KAFKA-9780: Deprecate commit records without record metadata

2020-05-06 Thread GitBox
rhauch commented on pull request #8379: URL: https://github.com/apache/kafka/pull/8379#issuecomment-624894538 Still waiting for final approval of https://cwiki.apache.org/confluence/display/KAFKA/KIP-586%3A+Deprecate+commit+records+without+record+metadata -

[GitHub] [kafka] rhauch commented on pull request #2604: KAFKA-4794: Add access to OffsetStorageReader from SourceConnector

2020-05-06 Thread GitBox
rhauch commented on pull request #2604: URL: https://github.com/apache/kafka/pull/2604#issuecomment-624891952 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kafka] C0urante commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-05-06 Thread GitBox
C0urante commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r421091305 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java ## @@ -536,20 +561,37 @@ private void proc

[GitHub] [kafka] C0urante commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-05-06 Thread GitBox
C0urante commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r421091035 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java ## @@ -239,9 +236,10 @@ private synchronized

[GitHub] [kafka] gharris1727 commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-05-06 Thread GitBox
gharris1727 commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r421079889 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java ## @@ -239,9 +236,10 @@ private synchroni

[jira] [Updated] (KAFKA-9780) Deprecate commit records without record metadata

2020-05-06 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-9780: - Fix Version/s: 2.6.0 > Deprecate commit records without record metadata > ---

[GitHub] [kafka] d8tltanc edited a comment on pull request #8610: KAKFA-9942: --entity-default flag is not working for alternating / describing configs in AdminClient

2020-05-06 Thread GitBox
d8tltanc edited a comment on pull request #8610: URL: https://github.com/apache/kafka/pull/8610#issuecomment-624421790 I think `ClientQuotaEntity` is only used in client quota alternation. But the description doesn't use that. Update: I've pushed my latest local changes if that helps. My

[GitHub] [kafka] cmccabe commented on pull request #8627: MINOR - Increase Trogdor Histogram buckets for latency to 10000ms

2020-05-06 Thread GitBox
cmccabe commented on pull request #8627: URL: https://github.com/apache/kafka/pull/8627#issuecomment-624872970 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] scott-hendricks opened a new pull request #8627: MINOR - Increase Trogdor Histogram buckets for latency to 10000ms

2020-05-06 Thread GitBox
scott-hendricks opened a new pull request #8627: URL: https://github.com/apache/kafka/pull/8627 The current latency histograms for ProduceBenchWorker and ConsumeBenchWorker are limited to 5000ms, causing the histograms to truncate and report 5000ms on requests that take longer. This incre

[GitHub] [kafka] d8tltanc edited a comment on pull request #8610: KAKFA-9942: --entity-default flag is not working for alternating / describing configs in AdminClient

2020-05-06 Thread GitBox
d8tltanc edited a comment on pull request #8610: URL: https://github.com/apache/kafka/pull/8610#issuecomment-624421790 I think `ClientQuotaEntity` is only used in client quota alternation. But the description doesn't use that. Update: I've pushed the my latest local changes if that helps

[GitHub] [kafka] d8tltanc edited a comment on pull request #8615: KAFKA-9954: Config command didn't validate the unsupported user config change

2020-05-06 Thread GitBox
d8tltanc edited a comment on pull request #8615: URL: https://github.com/apache/kafka/pull/8615#issuecomment-624857586 Thanks for the review. Since we are adding a unit test, move the argument checking in checkArgs() Edit: Since the existing tests are assuming that alter user entity type

[GitHub] [kafka] ableegoldman commented on pull request #8616: KAFKA-9127: don't create StreamThreads for global-only topology (2.4)

2020-05-06 Thread GitBox
ableegoldman commented on pull request #8616: URL: https://github.com/apache/kafka/pull/8616#issuecomment-624859671 @vvcephei Both Java 11 builds passed, Java 8 failed with flaky `DynamicBrokerReconfigurationTest.testAddRemoveSaslListeners` `BranchedMultiLevelRepartitionConnectedTopo

[GitHub] [kafka] andrewchoi5 commented on pull request #8479: KAFKA-9769: Finish operations for leaderEpoch-updated partitions up to point ZK Exception

2020-05-06 Thread GitBox
andrewchoi5 commented on pull request #8479: URL: https://github.com/apache/kafka/pull/8479#issuecomment-624858200 @mjsax Hi Matthias, would you happen to know if there were any other reviewers available? I don't mind waiting, but was curious what the ETA usually appears to be. -

[GitHub] [kafka] d8tltanc commented on pull request #8615: KAFKA-9954: Config command didn't validate the unsupported user config change

2020-05-06 Thread GitBox
d8tltanc commented on pull request #8615: URL: https://github.com/apache/kafka/pull/8615#issuecomment-624857586 Thanks for the review. Since we are adding a unit test, move the argument checking in checkArgs() This is an aut

[jira] [Commented] (KAFKA-9921) Caching is not working properly with WindowStateStore when retaining duplicates

2020-05-06 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17101130#comment-17101130 ] Sophie Blee-Goldman commented on KAFKA-9921: Thanks for the reminder, just op

[GitHub] [kafka] ableegoldman opened a new pull request #8626: KAFKA-9921: explicit handling of null values with retainDuplicates

2020-05-06 Thread GitBox
ableegoldman opened a new pull request #8626: URL: https://github.com/apache/kafka/pull/8626 In general the behavior of window stores with `retainDuplicates` is not well documented or enforced, so we should attempt to clarify things better in the javadocs and in the code itself. This expli

[GitHub] [kafka] cmccabe commented on pull request #8625: MINOR: Only add 'Data' suffix for generated request/response/header types

2020-05-06 Thread GitBox
cmccabe commented on pull request #8625: URL: https://github.com/apache/kafka/pull/8625#issuecomment-624851509 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Updated] (KAFKA-6342) Remove workaround for JSON parsing of non-escaped strings

2020-05-06 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-6342: --- Summary: Remove workaround for JSON parsing of non-escaped strings (was: Move workaround for

[jira] [Assigned] (KAFKA-6342) Move workaround for JSON parsing of non-escaped strings

2020-05-06 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson reassigned KAFKA-6342: -- Fix Version/s: 2.6.0 Assignee: Viktor Somogyi-Vass (was: Umesh Chaudhary)

[GitHub] [kafka] ijuma commented on pull request #8602: KAFKA-9947; Ensure proper shutdown of components in `TransactionsBounceTest`

2020-05-06 Thread GitBox
ijuma commented on pull request #8602: URL: https://github.com/apache/kafka/pull/8602#issuecomment-624845577 Sounds good. This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] ijuma commented on a change in pull request #8585: KAFKA-9938; Debug consumer should be able to fetch from followers

2020-05-06 Thread GitBox
ijuma commented on a change in pull request #8585: URL: https://github.com/apache/kafka/pull/8585#discussion_r421039469 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -949,8 +949,11 @@ class ReplicaManager(val config: KafkaConfig, else Fet

[jira] [Commented] (KAFKA-9921) Caching is not working properly with WindowStateStore when retaining duplicates

2020-05-06 Thread Georgi Petkov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1710#comment-1710 ] Georgi Petkov commented on KAFKA-9921: -- [~ableegoldman] Did you get to read my last

[GitHub] [kafka] hachikuji commented on pull request #8602: KAFKA-9947; Ensure proper shutdown of components in `TransactionsBounceTest`

2020-05-06 Thread GitBox
hachikuji commented on pull request #8602: URL: https://github.com/apache/kafka/pull/8602#issuecomment-624842318 I changed the patch to set the request timeout the same as the delivery timeout for this test case, which was the old behavior.

[GitHub] [kafka] rhauch commented on pull request #8230: KAFKA-9667: Connect JSON serde strip trailing zeros

2020-05-06 Thread GitBox
rhauch commented on pull request #8230: URL: https://github.com/apache/kafka/pull/8230#issuecomment-624837748 okay to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] hachikuji opened a new pull request #8625: MINOR: Only add 'Data' suffix for generated request/response/header types

2020-05-06 Thread GitBox
hachikuji opened a new pull request #8625: URL: https://github.com/apache/kafka/pull/8625 Currently we add "Data" to all generated classnames in order to avoid naming collisions. Generated classes for other persistent schema definitions (such as those used in `GroupCoordinator` and `Transa

[GitHub] [kafka] hachikuji commented on a change in pull request #8585: KAFKA-9938; Debug consumer should be able to fetch from followers

2020-05-06 Thread GitBox
hachikuji commented on a change in pull request #8585: URL: https://github.com/apache/kafka/pull/8585#discussion_r421026806 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -949,8 +949,11 @@ class ReplicaManager(val config: KafkaConfig, else

[jira] [Resolved] (KAFKA-9112) Combine streams `onAssignment` with `partitionsAssigned` task creation

2020-05-06 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman resolved KAFKA-9112. Fix Version/s: 2.6.0 Assignee: Guozhang Wang Resolution: Fixed Thin

[jira] [Resolved] (KAFKA-6063) StreamsException is thrown after the changing `partitions`

2020-05-06 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman resolved KAFKA-6063. Resolution: Not A Problem > StreamsException is thrown after the changing `partitio

[jira] [Resolved] (KAFKA-8858) Kafka Streams - Failed to Rebalance Error and stream consumer stuck for some reason

2020-05-06 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman resolved KAFKA-8858. Assignee: Guozhang Wang Resolution: Duplicate > Kafka Streams - Failed to Reb

[jira] [Resolved] (KAFKA-8207) StickyPartitionAssignor for KStream

2020-05-06 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman resolved KAFKA-8207. Resolution: Not A Problem Closing this as "Not a Problem" as the partition assignor

[GitHub] [kafka] kkonstantine commented on pull request #8360: KAFKA-9768: Fix handling of rest.advertised.listener config

2020-05-06 Thread GitBox
kkonstantine commented on pull request #8360: URL: https://github.com/apache/kafka/pull/8360#issuecomment-624821936 retest this please This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [kafka] gharris1727 commented on a change in pull request #8618: KAFKA-9955: Prevent SinkTask::close from shadowing other exceptions

2020-05-06 Thread GitBox
gharris1727 commented on a change in pull request #8618: URL: https://github.com/apache/kafka/pull/8618#discussion_r420998369 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.java ## @@ -856,6 +858,47 @@ public void run() {

[jira] [Resolved] (KAFKA-4969) State-store workload-aware StreamsPartitionAssignor

2020-05-06 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman resolved KAFKA-4969. Fix Version/s: (was: 1.1.0) 2.6.0 Resolution: Fixed T

[GitHub] [kafka] gharris1727 commented on a change in pull request #8618: KAFKA-9955: Prevent SinkTask::close from shadowing other exceptions

2020-05-06 Thread GitBox
gharris1727 commented on a change in pull request #8618: URL: https://github.com/apache/kafka/pull/8618#discussion_r421009491 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.java ## @@ -856,6 +858,47 @@ public void run() {

[GitHub] [kafka] kkonstantine commented on a change in pull request #8618: KAFKA-9955: Prevent SinkTask::close from shadowing other exceptions

2020-05-06 Thread GitBox
kkonstantine commented on a change in pull request #8618: URL: https://github.com/apache/kafka/pull/8618#discussion_r421005156 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.java ## @@ -856,6 +858,47 @@ public void run() {

[GitHub] [kafka] nizhikov commented on pull request #8592: KAFKA-3184: Add Checkpoint for In-memory State Store

2020-05-06 Thread GitBox
nizhikov commented on pull request #8592: URL: https://github.com/apache/kafka/pull/8592#issuecomment-624815018 retest this please This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [kafka] gharris1727 commented on a change in pull request #8618: KAFKA-9955: Prevent SinkTask::close from shadowing other exceptions

2020-05-06 Thread GitBox
gharris1727 commented on a change in pull request #8618: URL: https://github.com/apache/kafka/pull/8618#discussion_r420998369 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.java ## @@ -856,6 +858,47 @@ public void run() {

[GitHub] [kafka] kkonstantine commented on pull request #7950: KAFKA-9419: Integer Overflow Possible with CircularIterator

2020-05-06 Thread GitBox
kkonstantine commented on pull request #7950: URL: https://github.com/apache/kafka/pull/7950#issuecomment-624808716 Definitely. It's a nice fix. Thanks for contributing it @belugabehr This is an automated message from the Ap

[GitHub] [kafka] belugabehr commented on pull request #7950: KAFKA-9419: Integer Overflow Possible with CircularIterator

2020-05-06 Thread GitBox
belugabehr commented on pull request #7950: URL: https://github.com/apache/kafka/pull/7950#issuecomment-624803800 @kkonstantine I appreciate your help getting this over the finish line This is an automated message from the Ap

[GitHub] [kafka] kkonstantine commented on pull request #7950: KAFKA-9419: Integer Overflow Possible with CircularIterator

2020-05-06 Thread GitBox
kkonstantine commented on pull request #7950: URL: https://github.com/apache/kafka/pull/7950#issuecomment-624801890 retest this please This is an automated message from the Apache Git Service. To respond to the message, pleas

[jira] [Updated] (KAFKA-9633) ConfigProvider.close() not called

2020-05-06 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-9633: -- Fix Version/s: 2.4.2 2.3.2 > ConfigProvider.close() not call

[GitHub] [kafka] hachikuji commented on a change in pull request #8239: KAFKA-9666: Don't increase transactional epoch when trying to fence if the log append fails

2020-05-06 Thread GitBox
hachikuji commented on a change in pull request #8239: URL: https://github.com/apache/kafka/pull/8239#discussion_r420974886 ## File path: core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala ## @@ -487,6 +487,33 @@ class TransactionCoordinator(brokerI

[GitHub] [kafka] C0urante commented on pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-05-06 Thread GitBox
C0urante commented on pull request #8069: URL: https://github.com/apache/kafka/pull/8069#issuecomment-624788853 Thanks for the review, @gharris1727. I've addressed all of your comments with either changes or responses; let me know what you think. @kkonstantine -- there are a few plac

[jira] [Updated] (KAFKA-9830) DeadLetterQueueReporter leaks KafkaProducer instance

2020-05-06 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-9830: -- Fix Version/s: 2.4.2 2.3.2 > DeadLetterQueueReporter leaks K

[jira] [Updated] (KAFKA-9919) Add logging to KafkaBasedLog

2020-05-06 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-9919: -- Fix Version/s: 2.4.2 2.3.2 > Add logging to KafkaBasedLog >

[GitHub] [kafka] C0urante commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-05-06 Thread GitBox
C0urante commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r420963881 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java ## @@ -191,32 +192,61 @@ public synchronized

[GitHub] [kafka] gharris1727 commented on a change in pull request #8618: KAFKA-9955: Prevent SinkTask::close from shadowing other exceptions

2020-05-06 Thread GitBox
gharris1727 commented on a change in pull request #8618: URL: https://github.com/apache/kafka/pull/8618#discussion_r420950647 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java ## @@ -193,13 +194,11 @@ public void transitionTo(Targ

  1   2   >