badaiaqrandista commented on a change in pull request #8644:
URL: https://github.com/apache/kafka/pull/8644#discussion_r431621469
##
File path: clients/src/main/java/org/apache/kafka/clients/ClientDnsLookup.java
##
@@ -22,7 +22,8 @@
DEFAULT("default"),
USE_ALL_DNS_I
badaiaqrandista commented on a change in pull request #8644:
URL: https://github.com/apache/kafka/pull/8644#discussion_r431622505
##
File path: clients/src/main/java/org/apache/kafka/clients/ClientUtils.java
##
@@ -108,10 +108,11 @@ public static ChannelBuilder
createChannelBu
[
https://issues.apache.org/jira/browse/KAFKA-7791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17118385#comment-17118385
]
Benoit Delbosc commented on KAFKA-7791:
---
Hi,
With Kafka 2.1.1, under load I have e
[
https://issues.apache.org/jira/browse/KAFKA-10052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konstantine Karantasis resolved KAFKA-10052.
Resolution: Fixed
This must have been improved now, but please reopen if y
[
https://issues.apache.org/jira/browse/KAFKA-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17118396#comment-17118396
]
Benoit Delbosc commented on KAFKA-8334:
---
Hi, it looks like a duplicate of KAFKA-779
tombentley commented on a change in pull request #8699:
URL: https://github.com/apache/kafka/pull/8699#discussion_r431652348
##
File path:
connect/transforms/src/test/java/org/apache/kafka/connect/transforms/predicates/HasHeaderKeyTest.java
##
@@ -0,0 +1,99 @@
+/*
+ * Licensed
tombentley commented on a change in pull request #8699:
URL: https://github.com/apache/kafka/pull/8699#discussion_r431653319
##
File path:
connect/transforms/src/test/java/org/apache/kafka/connect/transforms/predicates/HasHeaderKeyTest.java
##
@@ -0,0 +1,99 @@
+/*
+ * Licensed
tombentley commented on pull request #8699:
URL: https://github.com/apache/kafka/pull/8699#issuecomment-635196787
@rhauch @kkonstantine thanks very much for making those fixes for me, I
appreciate the time that must've taken. I've made one more trivial correction
to the integration test.
nizhikov commented on a change in pull request #8695:
URL: https://github.com/apache/kafka/pull/8695#discussion_r431668846
##
File path:
clients/src/test/java/org/apache/kafka/common/network/SslVersionsTransportLayerTest.java
##
@@ -0,0 +1,130 @@
+/*
+ * Licensed to the Apache
[
https://issues.apache.org/jira/browse/KAFKA-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17118453#comment-17118453
]
Pádraig de Buitléar commented on KAFKA-7748:
Any update on this?
> Add wall
nizhikov commented on a change in pull request #8695:
URL: https://github.com/apache/kafka/pull/8695#discussion_r431674950
##
File path: tests/docker/run_tests.sh
##
@@ -30,6 +30,6 @@ if [ "$REBUILD" == "t" ]; then
fi
if ${SCRIPT_DIR}/ducker-ak ssh | grep -q '(none)'; then
nizhikov commented on a change in pull request #8695:
URL: https://github.com/apache/kafka/pull/8695#discussion_r431675317
##
File path: tests/kafkatest/benchmarks/core/benchmark_test.py
##
@@ -236,9 +238,9 @@ def test_producer_and_consumer(self,
compression_type="none", secur
mimaison commented on pull request #8312:
URL: https://github.com/apache/kafka/pull/8312#issuecomment-635205335
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
nizhikov commented on a change in pull request #8695:
URL: https://github.com/apache/kafka/pull/8695#discussion_r431677154
##
File path: tests/kafkatest/services/kafka/kafka.py
##
@@ -52,6 +51,7 @@ def advertised_listener(self, node):
def listener_security_protocol(self):
nizhikov commented on a change in pull request #8695:
URL: https://github.com/apache/kafka/pull/8695#discussion_r431678155
##
File path: tests/kafkatest/services/kafka/kafka.py
##
@@ -352,17 +357,18 @@ def start_cmd(self, node):
KafkaService.STDOUT_STDERR_CAPTU
dima5rr commented on a change in pull request #8706:
URL: https://github.com/apache/kafka/pull/8706#discussion_r431687179
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/QueryableStoreProvider.java
##
@@ -58,9 +58,21 @@ public QueryableStoreProvide
rajinisivaram commented on a change in pull request #8705:
URL: https://github.com/apache/kafka/pull/8705#discussion_r431697371
##
File path: core/src/test/scala/unit/kafka/network/SocketServerTest.scala
##
@@ -1875,6 +1889,14 @@ class SocketServerTest {
cachedComplet
rajinisivaram commented on pull request #8705:
URL: https://github.com/apache/kafka/pull/8705#issuecomment-635224994
@ijuma Thanks for the review, have addressed the comments.
This is an automated message from the Apache Git
rajinisivaram commented on a change in pull request #8705:
URL: https://github.com/apache/kafka/pull/8705#discussion_r431698413
##
File path: core/src/test/scala/unit/kafka/network/SocketServerTest.scala
##
@@ -1807,6 +1817,7 @@ class SocketServerTest {
currentPollVa
[
https://issues.apache.org/jira/browse/KAFKA-10049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17118505#comment-17118505
]
Amit Chauhan commented on KAFKA-10049:
--
I am using JSON Compatible Serde form [This
[
https://issues.apache.org/jira/browse/KAFKA-10049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17118513#comment-17118513
]
Amit Chauhan commented on KAFKA-10049:
--
[~abellemare] Don't know why it is expectin
[
https://issues.apache.org/jira/browse/KAFKA-9181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17118524#comment-17118524
]
Rajini Sivaram commented on KAFKA-9181:
---
[~hai_lin] Thanks for reporting this issue
Rajini Sivaram created KAFKA-10056:
--
Summary: Consumer metadata may use outdated groupSubscription that
doesn't contain newly subscribed topics
Key: KAFKA-10056
URL: https://issues.apache.org/jira/browse/KAFKA-10
[
https://issues.apache.org/jira/browse/KAFKA-10049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17118533#comment-17118533
]
Amit Chauhan commented on KAFKA-10049:
--
worth mentioning here same application work
[
https://issues.apache.org/jira/browse/KAFKA-9982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17118586#comment-17118586
]
Qinghui Xu commented on KAFKA-9982:
---
Hi, [~ChrisEgerton] Sorry for the delay.
> As of
[
https://issues.apache.org/jira/browse/KAFKA-9982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17118591#comment-17118591
]
Qinghui Xu commented on KAFKA-9982:
---
For now as there is no metrics provided in the fra
qianrui created KAFKA-10057:
---
Summary: optimize class ConfigCommand method alterConfig
parameters
Key: KAFKA-10057
URL: https://issues.apache.org/jira/browse/KAFKA-10057
Project: Kafka
Issue Type
[
https://issues.apache.org/jira/browse/KAFKA-9971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Randall Hauch resolved KAFKA-9971.
--
Fix Version/s: 2.6.0
Reviewer: Randall Hauch
Assignee: Aakash Shah
Reso
rhauch commented on pull request #8699:
URL: https://github.com/apache/kafka/pull/8699#issuecomment-635363510
Thanks, @tombentley. Merging with 3 green builds that Jenkins did not tie
back to this PR.
This is an automated me
rhauch merged pull request #8699:
URL: https://github.com/apache/kafka/pull/8699
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-9673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Randall Hauch resolved KAFKA-9673.
--
Fix Version/s: 2.6.0
Reviewer: Konstantine Karantasis
Resolution: Fixed
KIP-585
nizhikov commented on a change in pull request #8695:
URL: https://github.com/apache/kafka/pull/8695#discussion_r431857886
##
File path:
clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java
##
@@ -622,6 +619,81 @@ public void testUnsupportedTLSVersi
rajinisivaram commented on a change in pull request #8705:
URL: https://github.com/apache/kafka/pull/8705#discussion_r431862643
##
File path: core/src/test/scala/unit/kafka/network/SocketServerTest.scala
##
@@ -1807,6 +1817,7 @@ class SocketServerTest {
currentPollVa
rajinisivaram commented on a change in pull request #8705:
URL: https://github.com/apache/kafka/pull/8705#discussion_r431862931
##
File path: core/src/test/scala/unit/kafka/network/SocketServerTest.scala
##
@@ -1861,20 +1872,33 @@ class SocketServerTest {
override def po
vvcephei commented on pull request #8079:
URL: https://github.com/apache/kafka/pull/8079#issuecomment-635380658
Hi @IndeedSi ,
No, as far as I know Jiri's solution was to increase the join window size.
Judging from the investigation, it seemed like there really were out-of-order
rec
Schmidt96u closed pull request #8500:
URL: https://github.com/apache/kafka/pull/8500
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Schmidt96u opened a new pull request #8740:
URL: https://github.com/apache/kafka/pull/8740
# KIP-318: Make Kafka Connect Source idempotent
The main idea here was to add the idempotent configuration to Source. This
pull request is trying to solve this
[KIP](https://cwiki.apache.org/c
vvcephei commented on a change in pull request #8248:
URL: https://github.com/apache/kafka/pull/8248#discussion_r431879314
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java
##
@@ -811,17 +812,41 @@ private void prepareCh
rajinisivaram commented on a change in pull request #8723:
URL: https://github.com/apache/kafka/pull/8723#discussion_r431870218
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -2052,6 +2057,49 @@ void handleFailure(Throwable throw
sasukerui opened a new pull request #8741:
URL: https://github.com/apache/kafka/pull/8741
rebalanceTimeoutMs + 5000 is always greater than rebalanceTimeoutMs
This is an automated message from the Apache Git Service.
To respon
rajinisivaram commented on pull request #8723:
URL: https://github.com/apache/kafka/pull/8723#issuecomment-635390514
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log o
ryannedolan commented on pull request #8740:
URL: https://github.com/apache/kafka/pull/8740#issuecomment-635399009
This is a step in the right direction, but it doesn't really make source
connectors idempotent unless we also fix the offset storage mechanism. If a
task restarts for whatever
sasukerui opened a new pull request #8742:
URL: https://github.com/apache/kafka/pull/8742
I know this parameter will be used in the future, but it is not used here
This is an automated message from the Apache Git Service.
To
vinothchandar commented on a change in pull request #8737:
URL: https://github.com/apache/kafka/pull/8737#discussion_r431916698
##
File path: core/src/main/scala/kafka/admin/TopicCommand.scala
##
@@ -228,7 +228,7 @@ object TopicCommand extends Logging {
if (topic.partiti
SoerenHenning commented on pull request #6824:
URL: https://github.com/apache/kafka/pull/6824#issuecomment-635420007
Thanks for implementing this @pgwhalen and thanks for merging @mjsax
@vvcephei as well. I'm really looking forward to refactoring my code when this
is released!
--
[
https://issues.apache.org/jira/browse/KAFKA-859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17118836#comment-17118836
]
Rajini Sivaram commented on KAFKA-859:
--
We should decide what to do with `Mx4jLoader`
rajinisivaram edited a comment on pull request #7956:
URL: https://github.com/apache/kafka/pull/7956#issuecomment-635429173
Thanks @ijuma , rebased on trunk.
This is an automated message from the Apache Git Service.
To respon
rajinisivaram commented on pull request #7956:
URL: https://github.com/apache/kafka/pull/7956#issuecomment-635429173
Thanks @ijuma , rebased,
This is an automated message from the Apache Git Service.
To respond to the message
[
https://issues.apache.org/jira/browse/KAFKA-9982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17118842#comment-17118842
]
Chris Egerton commented on KAFKA-9982:
--
Hi [~q.xu], although offset commit is asynch
[
https://issues.apache.org/jira/browse/KAFKA-9986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17118850#comment-17118850
]
John Roesler commented on KAFKA-9986:
-
Hi [~nizhikov] ,
Thanks for getting involved
stanislavkozlovski commented on a change in pull request #8737:
URL: https://github.com/apache/kafka/pull/8737#discussion_r431950804
##
File path: core/src/main/scala/kafka/admin/TopicCommand.scala
##
@@ -736,8 +743,8 @@ object TopicCommand extends Logging {
allTopicLe
John Roesler created KAFKA-10058:
Summary: Create Windowing Operations overview documentation
Key: KAFKA-10058
URL: https://issues.apache.org/jira/browse/KAFKA-10058
Project: Kafka
Issue Typ
stanislavkozlovski commented on a change in pull request #8737:
URL: https://github.com/apache/kafka/pull/8737#discussion_r431953983
##
File path: core/src/main/scala/kafka/admin/TopicCommand.scala
##
@@ -247,8 +247,12 @@ object TopicCommand extends Logging {
val creat
[
https://issues.apache.org/jira/browse/KAFKA-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17118858#comment-17118858
]
John Roesler commented on KAFKA-7748:
-
Hi [~pdebuitlear] ,
It seems like [~jonathanp
[
https://issues.apache.org/jira/browse/KAFKA-4493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17118860#comment-17118860
]
John Roesler commented on KAFKA-4493:
-
Hi [~enether] , what's the status on this issu
ryannedolan commented on a change in pull request #8730:
URL: https://github.com/apache/kafka/pull/8730#discussion_r431952123
##
File path:
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java
##
@@ -316,6 +354,23 @@ public void tes
vvcephei opened a new pull request #8743:
URL: https://github.com/apache/kafka/pull/8743
Add a regression test to ensure the task assignor config is always effective.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test
vvcephei commented on pull request #8743:
URL: https://github.com/apache/kafka/pull/8743#issuecomment-635452819
@ableegoldman Can you take a look at this (since you requested it in #8716)?
This is an automated message from th
vvcephei commented on a change in pull request #8738:
URL: https://github.com/apache/kafka/pull/8738#discussion_r431966350
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ClientUtils.java
##
@@ -40,9 +41,14 @@
import org.slf4j.LoggerFactory;
guozhangwang commented on pull request #5940:
URL: https://github.com/apache/kafka/pull/5940#issuecomment-635459068
test this please
This is an automated message from the Apache Git Service.
To respond to the message, please
badaiaqrandista commented on a change in pull request #8644:
URL: https://github.com/apache/kafka/pull/8644#discussion_r431974209
##
File path: clients/src/main/java/org/apache/kafka/clients/ClientUtils.java
##
@@ -108,10 +108,11 @@ public static ChannelBuilder
createChannelBu
ableegoldman commented on a change in pull request #8738:
URL: https://github.com/apache/kafka/pull/8738#discussion_r431974679
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/TaskAssignorIntegrationTest.java
##
@@ -89,7 +89,7 @@ public void shouldPrope
ableegoldman commented on a change in pull request #8738:
URL: https://github.com/apache/kafka/pull/8738#discussion_r431974862
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ClientUtils.java
##
@@ -40,9 +41,14 @@
import org.slf4j.LoggerFactor
ableegoldman commented on a change in pull request #8738:
URL: https://github.com/apache/kafka/pull/8738#discussion_r431976033
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ClientUtils.java
##
@@ -90,24 +96,21 @@ public static String getTaskP
vinothchandar commented on a change in pull request #8737:
URL: https://github.com/apache/kafka/pull/8737#discussion_r431976104
##
File path: core/src/main/scala/kafka/admin/TopicCommand.scala
##
@@ -736,8 +743,8 @@ object TopicCommand extends Logging {
allTopicLevelOp
vinothchandar commented on a change in pull request #8737:
URL: https://github.com/apache/kafka/pull/8737#discussion_r431978052
##
File path: core/src/main/scala/kafka/admin/TopicCommand.scala
##
@@ -247,8 +247,12 @@ object TopicCommand extends Logging {
val createResu
ableegoldman commented on a change in pull request #8738:
URL: https://github.com/apache/kafka/pull/8738#discussion_r431984937
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ClientUtils.java
##
@@ -90,24 +96,21 @@ public static String getTaskP
ableegoldman commented on a change in pull request #8738:
URL: https://github.com/apache/kafka/pull/8738#discussion_r431984817
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -1246,7 +1247,12 @@ public void cleanUp() {
}
vvcephei commented on pull request #8738:
URL: https://github.com/apache/kafka/pull/8738#issuecomment-635473947
Test this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
Bob Barrett created KAFKA-10059:
---
Summary: KafkaAdminClient returns null OffsetAndMetadata value
when there is no committed offset for a partition
Key: KAFKA-10059
URL: https://issues.apache.org/jira/browse/KAFKA-10
ijuma commented on a change in pull request #8644:
URL: https://github.com/apache/kafka/pull/8644#discussion_r431990981
##
File path: clients/src/main/java/org/apache/kafka/clients/ClientDnsLookup.java
##
@@ -22,7 +22,8 @@
DEFAULT("default"),
USE_ALL_DNS_IPS("use_al
[
https://issues.apache.org/jira/browse/KAFKA-806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17118904#comment-17118904
]
Jun Rao commented on KAFKA-806:
---
[~mjsax]: I think this is still an issue.
> Index may not
[
https://issues.apache.org/jira/browse/KAFKA-10059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bob Barrett updated KAFKA-10059:
Description:
When listing consumer group offsets through the admin client, the map that we
return
[
https://issues.apache.org/jira/browse/KAFKA-10059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bob Barrett updated KAFKA-10059:
Description:
When listing consumer group offsets through the admin client, the map that we
return
[
https://issues.apache.org/jira/browse/KAFKA-10059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bob Barrett updated KAFKA-10059:
Description:
When listing consumer group offsets through the admin client, the map that we
return
guozhangwang commented on a change in pull request #8248:
URL: https://github.com/apache/kafka/pull/8248#discussion_r431995079
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextImpl.java
##
@@ -42,48 +41,36 @@
import static
org.
[
https://issues.apache.org/jira/browse/KAFKA-10059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bob Barrett updated KAFKA-10059:
Description:
When listing consumer group offsets through the admin client, the map that we
return
guozhangwang commented on a change in pull request #8248:
URL: https://github.com/apache/kafka/pull/8248#discussion_r432000417
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java
##
@@ -811,17 +812,41 @@ private void prepa
vvcephei commented on a change in pull request #8738:
URL: https://github.com/apache/kafka/pull/8738#discussion_r432006306
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/TaskAssignorIntegrationTest.java
##
@@ -89,7 +89,7 @@ public void shouldProperlyC
rhauch opened a new pull request #8744:
URL: https://github.com/apache/kafka/pull/8744
This should be backported to the `2.5` branch, which currently refers to 2.4.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test c
rhauch opened a new pull request #8745:
URL: https://github.com/apache/kafka/pull/8745
This is based upon #8744 for the 2.5 change.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
-
vvcephei commented on a change in pull request #8738:
URL: https://github.com/apache/kafka/pull/8738#discussion_r432009371
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -551,6 +551,7 @@ void runLoop() {
ableegoldman commented on a change in pull request #8738:
URL: https://github.com/apache/kafka/pull/8738#discussion_r432013319
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -551,6 +551,7 @@ void runLoop() {
[
https://issues.apache.org/jira/browse/KAFKA-10049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17118937#comment-17118937
]
Adam Bellemare commented on KAFKA-10049:
[~amicngh] Okay, I was able to reproduc
rhauch merged pull request #8744:
URL: https://github.com/apache/kafka/pull/8744
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
rhauch merged pull request #8745:
URL: https://github.com/apache/kafka/pull/8745
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
rhauch opened a new pull request #8746:
URL: https://github.com/apache/kafka/pull/8746
The `2.6` branch has been created, so we need to bump trunk to the next
snapshot version, 2.7.0-SNAPSHOT
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementa
vvcephei opened a new pull request #8747:
URL: https://github.com/apache/kafka/pull/8747
Adds the exception in the case of logging the "Coordinator discovery failed"
message.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Ve
Greg Hamilton created KAFKA-10060:
-
Summary: Kafka is logging too verbosely at the INFO level
Key: KAFKA-10060
URL: https://issues.apache.org/jira/browse/KAFKA-10060
Project: Kafka
Issue Type
vvcephei commented on pull request #8747:
URL: https://github.com/apache/kafka/pull/8747#issuecomment-635521481
Hey @hachikuji , Can you take a quick look at this? You were the last to
edit this block.
I was debugging a system test failure, and I see a situation where the
broker app
jsancio commented on pull request #8639:
URL: https://github.com/apache/kafka/pull/8639#issuecomment-635524753
> One observation is, we were not throwing exception in 2.3 and 2.4
releases. This was enforced in #7710 (2.5 release)
Thanks @omkreddy and sorry for the delay response.
hachikuji commented on pull request #8238:
URL: https://github.com/apache/kafka/pull/8238#issuecomment-635532428
@mimaison fyi, if you can get the feedback addressed by tomorrow, I think we
can still get this into 2.6. cc @rhauch
--
[
https://issues.apache.org/jira/browse/KAFKA-10060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17118992#comment-17118992
]
Ismael Juma commented on KAFKA-10060:
-
Thanks for the JIRA. I think the expired offs
[
https://issues.apache.org/jira/browse/KAFKA-10049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17119014#comment-17119014
]
Adam Bellemare commented on KAFKA-10049:
[~vvcephei] Hey John, didn't you fix an
[
https://issues.apache.org/jira/browse/KAFKA-10056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17119015#comment-17119015
]
Hai Lin commented on KAFKA-10056:
-
Thanks for the patch [~rsivaram], are we going to bac
efeg commented on pull request #8579:
URL: https://github.com/apache/kafka/pull/8579#issuecomment-635547747
@ijuma do you think we may be able to iterate on this PR?
This is an automated message from the Apache Git Service.
T
ijuma commented on pull request #8579:
URL: https://github.com/apache/kafka/pull/8579#issuecomment-635553427
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
ijuma commented on a change in pull request #8579:
URL: https://github.com/apache/kafka/pull/8579#discussion_r432073518
##
File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala
##
@@ -382,6 +382,11 @@ abstract class AbstractFetcherThread(name: String,
vvcephei commented on pull request #8738:
URL: https://github.com/apache/kafka/pull/8738#issuecomment-635553612
It looks like all the review comments are addressed, and all the tests
passed, so I'll proceed to merge.
This is
ijuma commented on a change in pull request #8579:
URL: https://github.com/apache/kafka/pull/8579#discussion_r432073518
##
File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala
##
@@ -382,6 +382,11 @@ abstract class AbstractFetcherThread(name: String,
1 - 100 of 199 matches
Mail list logo