[GitHub] [kafka] nym3r0s commented on pull request #9280: KAFKA-10186: Abort transaction with pending data with TransactionAbortedException

2020-10-06 Thread GitBox
nym3r0s commented on pull request #9280: URL: https://github.com/apache/kafka/pull/9280#issuecomment-704718666 ha - thank you đŸ˜„ This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] rite2nikhil commented on a change in pull request #9382: KAFKA-10554; Perform follower truncation based on diverging epochs in Fetch response

2020-10-06 Thread GitBox
rite2nikhil commented on a change in pull request #9382: URL: https://github.com/apache/kafka/pull/9382#discussion_r500743939 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -432,14 +455,22 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] vvcephei commented on a change in pull request #9388: KAFKA-10562: Properly invoke new StateStoreContext init

2020-10-06 Thread GitBox
vvcephei commented on a change in pull request #9388: URL: https://github.com/apache/kafka/pull/9388#discussion_r500715702 ## File path: streams/examples/src/test/java/org/apache/kafka/streams/examples/wordcount/WordCountProcessorTest.java ## @@ -34,6 +34,7 @@ * Demonstrate

[GitHub] [kafka] vvcephei opened a new pull request #9388: KAFKA-10562: Properly invoke new StateStoreContext init

2020-10-06 Thread GitBox
vvcephei opened a new pull request #9388: URL: https://github.com/apache/kafka/pull/9388 * all wrapping stores should pass StateStoreContext init through to the same method on the wrapped store and not translate it to ProcessorContext init * base-level stores should handle StateStore

[jira] [Updated] (KAFKA-10437) KIP-478: Implement test-utils changes

2020-10-06 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10437: - Description: In addition to implementing the KIP, search for and resolve these todos: {color:#0

[jira] [Updated] (KAFKA-10437) KIP-478: Implement test-utils changes

2020-10-06 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10437: - Description: In addition to implementing the KIP, search for and resolve these todos: {color:#0

[GitHub] [kafka] ableegoldman commented on a change in pull request #9273: KAFKA-9331: changes for Streams uncaught exception handler

2020-10-06 Thread GitBox
ableegoldman commented on a change in pull request #9273: URL: https://github.com/apache/kafka/pull/9273#discussion_r500682632 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -364,6 +370,73 @@ public void setUncaughtExceptionHandler(final T

[GitHub] [kafka] ableegoldman commented on a change in pull request #9273: KAFKA-9331: changes for Streams uncaught exception handler

2020-10-06 Thread GitBox
ableegoldman commented on a change in pull request #9273: URL: https://github.com/apache/kafka/pull/9273#discussion_r500682039 ## File path: streams/src/main/java/org/apache/kafka/streams/errors/StreamsUncaughtExceptionHandler.java ## @@ -0,0 +1,49 @@ +/* + * Licensed to the A

[GitHub] [kafka] ableegoldman commented on a change in pull request #9273: KAFKA-9331: changes for Streams uncaught exception handler

2020-10-06 Thread GitBox
ableegoldman commented on a change in pull request #9273: URL: https://github.com/apache/kafka/pull/9273#discussion_r500681912 ## File path: streams/src/main/java/org/apache/kafka/streams/errors/StreamsUncaughtExceptionHandler.java ## @@ -0,0 +1,49 @@ +/* + * Licensed to the A

[GitHub] [kafka] ableegoldman commented on a change in pull request #9273: KAFKA-9331: changes for Streams uncaught exception handler

2020-10-06 Thread GitBox
ableegoldman commented on a change in pull request #9273: URL: https://github.com/apache/kafka/pull/9273#discussion_r500681512 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -364,6 +370,73 @@ public void setUncaughtExceptionHandler(final T

[GitHub] [kafka] ableegoldman commented on a change in pull request #9273: KAFKA-9331: changes for Streams uncaught exception handler

2020-10-06 Thread GitBox
ableegoldman commented on a change in pull request #9273: URL: https://github.com/apache/kafka/pull/9273#discussion_r500681407 ## File path: streams/src/main/java/org/apache/kafka/streams/errors/StreamsUncaughtExceptionHandler.java ## @@ -0,0 +1,49 @@ +/* + * Licensed to the A

[jira] [Assigned] (KAFKA-10578) Convert KTable to a KStream using the previous value

2020-10-06 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-10578: --- Assignee: Javier Freire RiobĂ³ > Convert KTable to a KStream using the previous valu

[jira] [Commented] (KAFKA-10578) Convert KTable to a KStream using the previous value

2020-10-06 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209253#comment-17209253 ] Matthias J. Sax commented on KAFKA-10578: - [~javier.freire] – I added you to the

[jira] [Updated] (KAFKA-10578) Convert KTable to a KStream using the previous value

2020-10-06 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10578: Summary: Convert KTable to a KStream using the previous value (was: KIP-675: Convert KTab

[jira] [Updated] (KAFKA-10578) KIP-675: Convert KTable to a KStream using the previous value

2020-10-06 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10578: Description: Imagine that we have an entity for which we want to emit the difference betwe

[jira] [Updated] (KAFKA-10578) KIP-675: Convert KTable to a KStream using the previous value

2020-10-06 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10578: Labels: kip (was: ) > KIP-675: Convert KTable to a KStream using the previous value > ---

[GitHub] [kafka] ableegoldman commented on a change in pull request #9139: KAFKA-9929: Support backward iterator on SessionStore

2020-10-06 Thread GitBox
ableegoldman commented on a change in pull request #9139: URL: https://github.com/apache/kafka/pull/9139#discussion_r500664927 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/CachingSessionStoreTest.java ## @@ -278,6 +326,23 @@ public void shouldFe

[GitHub] [kafka] guozhangwang commented on pull request #8988: KAFKA-10199: Separate restore threads

2020-10-06 Thread GitBox
guozhangwang commented on pull request #8988: URL: https://github.com/apache/kafka/pull/8988#issuecomment-704615880 test this This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] guozhangwang commented on pull request #8988: KAFKA-10199: Separate restore threads

2020-10-06 Thread GitBox
guozhangwang commented on pull request #8988: URL: https://github.com/apache/kafka/pull/8988#issuecomment-704615342 System test: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4195/ This is an automated me

[GitHub] [kafka] ableegoldman commented on a change in pull request #9139: KAFKA-9929: Support backward iterator on SessionStore

2020-10-06 Thread GitBox
ableegoldman commented on a change in pull request #9139: URL: https://github.com/apache/kafka/pull/9139#discussion_r500658560 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/CachingSessionStore.java ## @@ -270,25 +335,32 @@ public void close() {

[GitHub] [kafka] kowshik commented on pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-10-06 Thread GitBox
kowshik commented on pull request #9001: URL: https://github.com/apache/kafka/pull/9001#issuecomment-704596581 @junrao The test failure in `MirrorConnectorsIntegrationTest.testReplication` does not seem related. I have rebased the PR now against latest AK trunk, I'd like to see if the fail

[jira] [Assigned] (KAFKA-10024) Add dynamic configuration and enforce quota for per-IP connection rate limits

2020-10-06 Thread Anna Povzner (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anna Povzner reassigned KAFKA-10024: Assignee: David Mao (was: Anna Povzner) > Add dynamic configuration and enforce quota fo

[GitHub] [kafka] ableegoldman commented on pull request #9280: KAFKA-10186: Abort transaction with pending data with TransactionAbortedException

2020-10-06 Thread GitBox
ableegoldman commented on pull request #9280: URL: https://github.com/apache/kafka/pull/9280#issuecomment-704587824 I don't think they're fixed on trunk lol đŸ™‚ (besides, I believe Jenkins merges the PR with trunk before running the tests so it's running the most recent code anyways).

[GitHub] [kafka] rgo edited a comment on pull request #2541: KAFKA-4759: Add support for subnet masks in SimpleACLAuthorizer

2020-10-06 Thread GitBox
rgo edited a comment on pull request #2541: URL: https://github.com/apache/kafka/pull/2541#issuecomment-704547984 I've been working on it. I'm going to open a new PR and I'll link it to this one. PR: #9387 This is an

[GitHub] [kafka] rgo opened a new pull request #9387: KAFKA-4759: Acl authorizer subnet support

2020-10-06 Thread GitBox
rgo opened a new pull request #9387: URL: https://github.com/apache/kafka/pull/9387 Add subnet support to ACL authorizer. For IPv4 and IPv6, it supports: - IP address range - Subnet CIDR notation Test strategy has been simple: - Define ranges and set ACLs with IPs include

[GitHub] [kafka] rgo commented on pull request #2541: KAFKA-4759: Add support for subnet masks in SimpleACLAuthorizer

2020-10-06 Thread GitBox
rgo commented on pull request #2541: URL: https://github.com/apache/kafka/pull/2541#issuecomment-704547984 I've been working on it. I'm going to open a new PR and I'll link it to this one. This is an automated message from t

[jira] [Updated] (KAFKA-10550) Update AdminClient and kafka-topics.sh to support topic IDs

2020-10-06 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-10550: --- Description: Change some AdminClient methods to expose and support topic IDs (describe, del

[jira] [Updated] (KAFKA-10550) Update AdminClient and kafka-topics.sh to support topic IDs

2020-10-06 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-10550: --- Summary: Update AdminClient and kafka-topics.sh to support topic IDs (was: Update kafka-top

[jira] [Created] (KAFKA-10580) Add topic ID support to Fetch request

2020-10-06 Thread Justine Olshan (Jira)
Justine Olshan created KAFKA-10580: -- Summary: Add topic ID support to Fetch request Key: KAFKA-10580 URL: https://issues.apache.org/jira/browse/KAFKA-10580 Project: Kafka Issue Type: Sub-tas

[GitHub] [kafka] nym3r0s commented on pull request #9280: KAFKA-10186: Abort transaction with pending data with TransactionAbortedException

2020-10-06 Thread GitBox
nym3r0s commented on pull request #9280: URL: https://github.com/apache/kafka/pull/9280#issuecomment-704543777 @ableegoldman @hachikuji - Should I rebase these changes off of trunk (assuming these tests are fixed on trunk) ?

[jira] [Updated] (KAFKA-10547) Add topic IDs to MetadataResponse, UpdateMetadata

2020-10-06 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-10547: --- Summary: Add topic IDs to MetadataResponse, UpdateMetadata (was: Add topic IDs to MetadataR

[GitHub] [kafka] splett2 opened a new pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits

2020-10-06 Thread GitBox
splett2 opened a new pull request #9386: URL: https://github.com/apache/kafka/pull/9386 This PR implements the part of KIP-612 for adding IP throttling enforcement, and a ZK entity for configuring dynamic IP throttles. I will add `kafka-configs` support as well as `KafkaApi` reconfig

[GitHub] [kafka] mjsax opened a new pull request #9385: KAFKA-9274: fix incorrect default value for `task.timeout.ms` config

2020-10-06 Thread GitBox
mjsax opened a new pull request #9385: URL: https://github.com/apache/kafka/pull/9385 Part of KIP-572. Also add handler method to trigger/reset the timeout on a task. Call for review @vvcephei This

[GitHub] [kafka] mjsax commented on a change in pull request #9384: MINOR: remove explicit passing of AdminClient into StreamsPartitionAssignor

2020-10-06 Thread GitBox
mjsax commented on a change in pull request #9384: URL: https://github.com/apache/kafka/pull/9384#discussion_r500574894 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/HighAvailabilityStreamsPartitionAssignorTest.java ## @@ -203,8 +204,8 @@ pub

[GitHub] [kafka] mjsax commented on a change in pull request #9384: MINOR: remove explicit passing of AdminClient into StreamsPartitionAssignor

2020-10-06 Thread GitBox
mjsax commented on a change in pull request #9384: URL: https://github.com/apache/kafka/pull/9384#discussion_r500574645 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/HighAvailabilityStreamsPartitionAssignorTest.java ## @@ -131,12 +130,13 @@

[GitHub] [kafka] mjsax commented on a change in pull request #9384: MINOR: remove explicit passing of AdminClient into StreamsPartitionAssignor

2020-10-06 Thread GitBox
mjsax commented on a change in pull request #9384: URL: https://github.com/apache/kafka/pull/9384#discussion_r500574127 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfiguration.java ## @@ -291,11 +271,7 @@ public String

[GitHub] [kafka] mjsax opened a new pull request #9384: MINOR: remove explicit passing of AdminClient into StreamsPartitionAssignor

2020-10-06 Thread GitBox
mjsax opened a new pull request #9384: URL: https://github.com/apache/kafka/pull/9384 Currently, we pass `AdminClient` and `TaskManager` into `StreamsPartitionAssignor` and use `TaskManager#mainConsumer()` to get access to the main consumer. However, TM also had a reference to `AdminClient

[GitHub] [kafka] scanterog commented on a change in pull request #9313: [mm2] Fix consumer/producer properties override

2020-10-06 Thread GitBox
scanterog commented on a change in pull request #9313: URL: https://github.com/apache/kafka/pull/9313#discussion_r500569567 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java ## @@ -199,8 +199,8 @@ protected static fina

[GitHub] [kafka] mimaison commented on a change in pull request #9313: [mm2] Fix consumer/producer properties override

2020-10-06 Thread GitBox
mimaison commented on a change in pull request #9313: URL: https://github.com/apache/kafka/pull/9313#discussion_r500568357 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java ## @@ -199,8 +199,8 @@ protected static final

[GitHub] [kafka] scanterog commented on a change in pull request #9313: [mm2] Fix consumer/producer properties override

2020-10-06 Thread GitBox
scanterog commented on a change in pull request #9313: URL: https://github.com/apache/kafka/pull/9313#discussion_r500566839 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java ## @@ -199,8 +199,8 @@ protected static fina

[GitHub] [kafka] mimaison commented on a change in pull request #9313: [mm2] Fix consumer/producer properties override

2020-10-06 Thread GitBox
mimaison commented on a change in pull request #9313: URL: https://github.com/apache/kafka/pull/9313#discussion_r500562684 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java ## @@ -199,8 +199,8 @@ protected static final

[GitHub] [kafka] ijuma merged pull request #9336: MINOR: Don't publish javadocs for raft module

2020-10-06 Thread GitBox
ijuma merged pull request #9336: URL: https://github.com/apache/kafka/pull/9336 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ijuma commented on pull request #9336: MINOR: Don't publish javadocs for raft module

2020-10-06 Thread GitBox
ijuma commented on pull request #9336: URL: https://github.com/apache/kafka/pull/9336#issuecomment-704521581 Sounds good. This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] hachikuji commented on pull request #9336: MINOR: Don't publish javadocs for raft module

2020-10-06 Thread GitBox
hachikuji commented on pull request #9336: URL: https://github.com/apache/kafka/pull/9336#issuecomment-704519950 @ijuma Thanks, LGTM. I think we can consider exposing an API eventually, but for now I'd like to have full flexibility to change it. ---

[GitHub] [kafka] dajac commented on a change in pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-10-06 Thread GitBox
dajac commented on a change in pull request #9318: URL: https://github.com/apache/kafka/pull/9318#discussion_r500544582 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala ## @@ -1321,25 +1106,15 @@ object GroupMetadataManager { */ def r

[GitHub] [kafka] ableegoldman commented on pull request #9280: KAFKA-10186: Abort transaction with pending data with TransactionAbortedException

2020-10-06 Thread GitBox
ableegoldman commented on pull request #9280: URL: https://github.com/apache/kafka/pull/9280#issuecomment-704502487 LGTM! Looks like the builds just failed with some unrelated flaky tests: ``` Build / JDK 8 / org.apache.kafka.connect.integration.InternalTopicsIntegrationTest.te

[jira] [Updated] (KAFKA-10579) Flaky test connect.integration.InternalTopicsIntegrationTest.testStartWhenInternalTopicsCreatedManuallyWithCompactForBrokersDefaultCleanupPolicy

2020-10-06 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-10579: Labels: flaky-test (was: ) > Flaky test > connect.integration.InternalTopicsInte

[jira] [Created] (KAFKA-10579) Flaky test connect.integration.InternalTopicsIntegrationTest.testStartWhenInternalTopicsCreatedManuallyWithCompactForBrokersDefaultCleanupPolicy

2020-10-06 Thread Sophie Blee-Goldman (Jira)
Sophie Blee-Goldman created KAFKA-10579: --- Summary: Flaky test connect.integration.InternalTopicsIntegrationTest.testStartWhenInternalTopicsCreatedManuallyWithCompactForBrokersDefaultCleanupPolicy Key: KAFKA-10579

[GitHub] [kafka] ableegoldman commented on pull request #9373: KAFKA-10564: only process non-empty task directories when internally cleaning obsolete state stores

2020-10-06 Thread GitBox
ableegoldman commented on pull request #9373: URL: https://github.com/apache/kafka/pull/9373#issuecomment-704493219 FYI this should be cherrypicked back to 2.6 once merged This is an automated message from the Apache Git Serv

[GitHub] [kafka] brbrown25 commented on pull request #9057: KAFKA-10299: Implementing Kafka Connect Hash SMT to allow for hashing…

2020-10-06 Thread GitBox
brbrown25 commented on pull request #9057: URL: https://github.com/apache/kafka/pull/9057#issuecomment-704492883 @mimaison I've updated the kip and put out a vote request but not seeing any action. I've gone ahead and updated this pr to be updated with latest trunk as well. -

[jira] [Commented] (KAFKA-9831) Failing test: EosIntegrationTest.shouldNotViolateEosIfOneTaskFailsWithState[exactly_once_beta]

2020-10-06 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209038#comment-17209038 ] Sophie Blee-Goldman commented on KAFKA-9831: [https://ci-builds.apache.org/jo

[GitHub] [kafka] guozhangwang commented on a change in pull request #8988: KAFKA-10199: Separate restore threads

2020-10-06 Thread GitBox
guozhangwang commented on a change in pull request #8988: URL: https://github.com/apache/kafka/pull/8988#discussion_r500521516 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextImpl.java ## @@ -65,10 +65,6 @@ public ProcessorConte

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9273: KAFKA-9331: changes for Streams uncaught exception handler

2020-10-06 Thread GitBox
wcarlson5 commented on a change in pull request #9273: URL: https://github.com/apache/kafka/pull/9273#discussion_r500521571 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -384,9 +390,8 @@ public static StreamThread crea

[GitHub] [kafka] guozhangwang commented on pull request #9020: KAFKA-10271 Performance regression while fetching a key from a single partition

2020-10-06 Thread GitBox
guozhangwang commented on pull request #9020: URL: https://github.com/apache/kafka/pull/9020#issuecomment-704474872 test this This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] guozhangwang closed pull request #9020: KAFKA-10271 Performance regression while fetching a key from a single partition

2020-10-06 Thread GitBox
guozhangwang closed pull request #9020: URL: https://github.com/apache/kafka/pull/9020 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] guozhangwang commented on pull request #9020: KAFKA-10271 Performance regression while fetching a key from a single partition

2020-10-06 Thread GitBox
guozhangwang commented on pull request #9020: URL: https://github.com/apache/kafka/pull/9020#issuecomment-704462953 test this This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] guozhangwang merged pull request #9321: KAFKA-9929: fix: add missing default implementations

2020-10-06 Thread GitBox
guozhangwang merged pull request #9321: URL: https://github.com/apache/kafka/pull/9321 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] guozhangwang commented on pull request #9321: KAFKA-9929: fix: add missing default implementations

2020-10-06 Thread GitBox
guozhangwang commented on pull request #9321: URL: https://github.com/apache/kafka/pull/9321#issuecomment-704461565 LGTM! This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] guozhangwang commented on pull request #9020: KAFKA-10271 Performance regression while fetching a key from a single partition

2020-10-06 Thread GitBox
guozhangwang commented on pull request #9020: URL: https://github.com/apache/kafka/pull/9020#issuecomment-704460681 test this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] rhauch merged pull request #8910: KAFKA-10188: Prevent SinkTask::preCommit from being called after SinkTask::stop

2020-10-06 Thread GitBox
rhauch merged pull request #8910: URL: https://github.com/apache/kafka/pull/8910 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] guozhangwang commented on pull request #9020: KAFKA-10271 Performance regression while fetching a key from a single partition

2020-10-06 Thread GitBox
guozhangwang commented on pull request #9020: URL: https://github.com/apache/kafka/pull/9020#issuecomment-704460234 test this please This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Resolved] (KAFKA-10338) Support PEM format for SSL certificates and private key

2020-10-06 Thread Rajini Sivaram (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram resolved KAFKA-10338. Fix Version/s: 2.7.0 Reviewer: Manikumar Resolution: Fixed > Support PEM f

[GitHub] [kafka] rajinisivaram merged pull request #9345: KAFKA-10338; Support PEM format for SSL key and trust stores (KIP-651)

2020-10-06 Thread GitBox
rajinisivaram merged pull request #9345: URL: https://github.com/apache/kafka/pull/9345 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] rajinisivaram commented on pull request #9345: KAFKA-10338; Support PEM format for SSL key and trust stores (KIP-651)

2020-10-06 Thread GitBox
rajinisivaram commented on pull request #9345: URL: https://github.com/apache/kafka/pull/9345#issuecomment-704456290 @omkreddy Thanks for the review, merging to trunk. This is an automated message from the Apache Git Service.

[jira] [Commented] (KAFKA-5998) /.checkpoint.tmp Not found exception

2020-10-06 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209006#comment-17209006 ] Sophie Blee-Goldman commented on KAFKA-5998: Yeah I think both of those (runn

[jira] [Commented] (KAFKA-10520) InitProducerId may be blocked if least loaded node is not ready to send

2020-10-06 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208995#comment-17208995 ] Sophie Blee-Goldman commented on KAFKA-10520: - Hey [~rsivaram], is this some

[GitHub] [kafka] piotrrzysko commented on pull request #9371: KAFKA-10510: Validate replication factor consistency on reassignment

2020-10-06 Thread GitBox
piotrrzysko commented on pull request #9371: URL: https://github.com/apache/kafka/pull/9371#issuecomment-704430920 Thanks for the review, @stanislavkozlovski. If I understand your point clearly, you are wondering whether this validation will block changing the replication factor for all pa

[jira] [Resolved] (KAFKA-10527) Voters should always initialize as followers

2020-10-06 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-10527. - Resolution: Fixed > Voters should always initialize as followers > -

[GitHub] [kafka] rondagostino commented on a change in pull request #9378: MINOR: ACLs for secured cluster system tests

2020-10-06 Thread GitBox
rondagostino commented on a change in pull request #9378: URL: https://github.com/apache/kafka/pull/9378#discussion_r500465547 ## File path: tests/kafkatest/services/kafka/kafka.py ## @@ -451,7 +451,8 @@ def _kafka_topics_cmd(self, node, force_use_zk_connection): set.

[GitHub] [kafka] scanterog commented on a change in pull request #9313: [mm2] Fix consumer/producer properties override

2020-10-06 Thread GitBox
scanterog commented on a change in pull request #9313: URL: https://github.com/apache/kafka/pull/9313#discussion_r500464804 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java ## @@ -199,8 +199,8 @@ protected static fina

[GitHub] [kafka] rondagostino commented on a change in pull request #9378: MINOR: ACLs for secured cluster system tests

2020-10-06 Thread GitBox
rondagostino commented on a change in pull request #9378: URL: https://github.com/apache/kafka/pull/9378#discussion_r500464258 ## File path: tests/kafkatest/services/kafka/kafka.py ## @@ -983,7 +988,10 @@ def _topic_command_connect_setting(self, node, force_use_zk_connection):

[GitHub] [kafka] hachikuji merged pull request #9348: KAFKA-10527; Voters should not reinitialize as leader in same epoch

2020-10-06 Thread GitBox
hachikuji merged pull request #9348: URL: https://github.com/apache/kafka/pull/9348 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] rondagostino commented on a change in pull request #9378: MINOR: ACLs for secured cluster system tests

2020-10-06 Thread GitBox
rondagostino commented on a change in pull request #9378: URL: https://github.com/apache/kafka/pull/9378#discussion_r500460487 ## File path: tests/kafkatest/services/security/kafka_acls.py ## @@ -93,11 +97,13 @@ def add_cluster_acl(self, kafka, principal, force_use_zk_connecti

[GitHub] [kafka] lct45 commented on pull request #9383: KAFKA-10455: Ensure that probing rebalances always occur

2020-10-06 Thread GitBox
lct45 commented on pull request #9383: URL: https://github.com/apache/kafka/pull/9383#issuecomment-704410260 @ableegoldman ready for initial review This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9378: MINOR: ACLs for secured cluster system tests

2020-10-06 Thread GitBox
rajinisivaram commented on a change in pull request #9378: URL: https://github.com/apache/kafka/pull/9378#discussion_r500429377 ## File path: tests/kafkatest/services/kafka/kafka.py ## @@ -451,7 +451,8 @@ def _kafka_topics_cmd(self, node, force_use_zk_connection): set.

[GitHub] [kafka] junrao commented on pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-10-06 Thread GitBox
junrao commented on pull request #9001: URL: https://github.com/apache/kafka/pull/9001#issuecomment-704393633 @abbccdda : Any more comments from you? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] guozhangwang commented on pull request #9358: MINOR: Refactor unit tests around RocksDBConfigSetter

2020-10-06 Thread GitBox
guozhangwang commented on pull request #9358: URL: https://github.com/apache/kafka/pull/9358#issuecomment-704386882 Thanks @abbccdda for the reviews! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] guozhangwang merged pull request #9358: MINOR: Refactor unit tests around RocksDBConfigSetter

2020-10-06 Thread GitBox
guozhangwang merged pull request #9358: URL: https://github.com/apache/kafka/pull/9358 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Updated] (KAFKA-10578) KIP-675: Convert KTable to a KStream using the previous value

2020-10-06 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-10578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Javier Freire RiobĂ³ updated KAFKA-10578: Issue Type: Improvement (was: Wish) > KIP-675: Convert KTable to a KStream using

[GitHub] [kafka] lct45 opened a new pull request #9383: KAFKA-10455: Ensure that probing rebalances always occur

2020-10-06 Thread GitBox
lct45 opened a new pull request #9383: URL: https://github.com/apache/kafka/pull/9383 Add data to subscriptionUserData to make sure that it's different each time a consumer rejoins ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ]

[GitHub] [kafka] ning2008wisc commented on pull request #9224: KAFKA-10304: refactor MM2 integration tests

2020-10-06 Thread GitBox
ning2008wisc commented on pull request #9224: URL: https://github.com/apache/kafka/pull/9224#issuecomment-704353923 @mimaison I think this pr is ready for initial review. Please take your time when available. Thanks This is

[jira] [Updated] (KAFKA-6733) Support of printing additional ConsumerRecord fields in DefaultMessageFormatter

2020-10-06 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-6733: --- Fix Version/s: 2.7.0 > Support of printing additional ConsumerRecord fields in > DefaultMessageForma

[jira] [Updated] (KAFKA-6733) Support of printing additional ConsumerRecord fields in DefaultMessageFormatter

2020-10-06 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-6733: --- Affects Version/s: 2.7.0 > Support of printing additional ConsumerRecord fields in > DefaultMessageF

[GitHub] [kafka] bbejeck commented on pull request #9237: KAFKA-10454 / Update copartitionSourceGroups when optimization algorithm is triggered

2020-10-06 Thread GitBox
bbejeck commented on pull request #9237: URL: https://github.com/apache/kafka/pull/9237#issuecomment-704347684 Java 8 failed with `kafka.network.ConnectionQuotasTest.testNoConnectionLimitsByDefault` Java 11 failed with `org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.

[GitHub] [kafka] coded9 commented on pull request #8575: KAFKA-8713 KIP-581 Add accept.optional.null to solve optional null

2020-10-06 Thread GitBox
coded9 commented on pull request #8575: URL: https://github.com/apache/kafka/pull/8575#issuecomment-704328653 Any update or possible workaround ? @rhauch This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] chia7712 commented on a change in pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-10-06 Thread GitBox
chia7712 commented on a change in pull request #9318: URL: https://github.com/apache/kafka/pull/9318#discussion_r500361487 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala ## @@ -997,174 +996,7 @@ object GroupMetadataManager { val Metrics

[GitHub] [kafka] rajinisivaram commented on pull request #9345: KAFKA-10338; Support PEM format for SSL key and trust stores (KIP-651)

2020-10-06 Thread GitBox
rajinisivaram commented on pull request #9345: URL: https://github.com/apache/kafka/pull/9345#issuecomment-704327619 @omkreddy Thanks for the review, have addressed the comments. This is an automated message from the Apache G

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9345: KAFKA-10338; Support PEM format for SSL key and trust stores (KIP-651)

2020-10-06 Thread GitBox
rajinisivaram commented on a change in pull request #9345: URL: https://github.com/apache/kafka/pull/9345#discussion_r500360036 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java ## @@ -167,17 +181,12 @@ public void testValidEndpoint

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9345: KAFKA-10338; Support PEM format for SSL key and trust stores (KIP-651)

2020-10-06 Thread GitBox
rajinisivaram commented on a change in pull request #9345: URL: https://github.com/apache/kafka/pull/9345#discussion_r500359056 ## File path: clients/src/test/java/org/apache/kafka/common/network/CertStores.java ## @@ -54,13 +60,30 @@ public CertStores(boolean server, String co

[GitHub] [kafka] bbejeck commented on pull request #9099: KAFKA-6733: Printing additional ConsumerRecord fields in DefaultMessageFormatter

2020-10-06 Thread GitBox
bbejeck commented on pull request #9099: URL: https://github.com/apache/kafka/pull/9099#issuecomment-704322766 Thanks for the contribution @badaiaqrandista! This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] bbejeck commented on pull request #9099: KAFKA-6733: Printing additional ConsumerRecord fields in DefaultMessageFormatter

2020-10-06 Thread GitBox
bbejeck commented on pull request #9099: URL: https://github.com/apache/kafka/pull/9099#issuecomment-704322552 Merged #9099 into trunk This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [kafka] bbejeck merged pull request #9099: KAFKA-6733: Printing additional ConsumerRecord fields in DefaultMessageFormatter

2020-10-06 Thread GitBox
bbejeck merged pull request #9099: URL: https://github.com/apache/kafka/pull/9099 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] chia7712 commented on a change in pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-10-06 Thread GitBox
chia7712 commented on a change in pull request #9318: URL: https://github.com/apache/kafka/pull/9318#discussion_r500352497 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala ## @@ -1257,60 +1059,31 @@ object GroupMetadataManager {

[GitHub] [kafka] dajac commented on a change in pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-10-06 Thread GitBox
dajac commented on a change in pull request #9318: URL: https://github.com/apache/kafka/pull/9318#discussion_r500293553 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala ## @@ -1257,60 +1059,31 @@ object GroupMetadataManager {

[GitHub] [kafka] kkonstantine merged pull request #9379: MINOR: Annotate test BlockingConnectorTest as integration test

2020-10-06 Thread GitBox
kkonstantine merged pull request #9379: URL: https://github.com/apache/kafka/pull/9379 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] kkonstantine commented on pull request #9379: MINOR: Annotate test BlockingConnectorTest as integration test

2020-10-06 Thread GitBox
kkonstantine commented on pull request #9379: URL: https://github.com/apache/kafka/pull/9379#issuecomment-704314583 JDK 15 was green. Rest of the failures are not relevant. This is an automated message from the Apache Git Se

[GitHub] [kafka] stanislavkozlovski commented on pull request #9371: KAFKA-10510: Validate replication factor consistency on reassignment

2020-10-06 Thread GitBox
stanislavkozlovski commented on pull request #9371: URL: https://github.com/apache/kafka/pull/9371#issuecomment-704300915 Thanks for the PR @piotrrzysko. The changes look good although I'm not sure if we're not regressing the ability to change the replication factor of a topic if we're to

[GitHub] [kafka] rajinisivaram opened a new pull request #9382: KAFKA-10554; Perform follower truncation based on diverging epochs in Fetch response

2020-10-06 Thread GitBox
rajinisivaram opened a new pull request #9382: URL: https://github.com/apache/kafka/pull/9382 For IBP 2.7 onwards, fetch responses include diverging epoch and offset in fetch responses if `lastFetchedEpoch` is provided in the fetch request. This PR uses that information for truncation and

[GitHub] [kafka] javierfreire opened a new pull request #9381: KIP-675: Convert KTable to a KStream using the previous value

2020-10-06 Thread GitBox
javierfreire opened a new pull request #9381: URL: https://github.com/apache/kafka/pull/9381 This gives the possibility of converting a table into a stream using a mapper with the new and old values as arguments. [KIP-675](https://cwiki.apache.org/confluence/display/KAFKA/KIP-675%3A

[GitHub] [kafka] omkreddy commented on a change in pull request #9345: KAFKA-10338; Support PEM format for SSL key and trust stores (KIP-651)

2020-10-06 Thread GitBox
omkreddy commented on a change in pull request #9345: URL: https://github.com/apache/kafka/pull/9345#discussion_r500186433 ## File path: clients/src/test/java/org/apache/kafka/test/TestSslUtils.java ## @@ -199,6 +206,156 @@ public static void createKeyStore(String filename,

  1   2   >