showuon commented on pull request #9888:
URL: https://github.com/apache/kafka/pull/9888#issuecomment-760714184
@cadonna , thanks for the comments. I've updated in this commit:
https://github.com/apache/kafka/pull/9888/commits/46898d994bb3c3495aea967ace9a07549f7fc1e5.
Thanks.
showuon commented on a change in pull request #9888:
URL: https://github.com/apache/kafka/pull/9888#discussion_r557960104
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java
##
@@ -90,24 +91,64 @@ public void setup() {
showuon commented on a change in pull request #9888:
URL: https://github.com/apache/kafka/pull/9888#discussion_r557960104
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java
##
@@ -90,24 +91,64 @@ public void setup() {
showuon commented on a change in pull request #9888:
URL: https://github.com/apache/kafka/pull/9888#discussion_r557939529
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java
##
@@ -90,24 +91,64 @@ public void setup() {
showuon commented on a change in pull request #9888:
URL: https://github.com/apache/kafka/pull/9888#discussion_r557937603
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java
##
@@ -119,37 +160,47 @@ public void shouldAddStr
[
https://issues.apache.org/jira/browse/KAFKA-12191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-12191.
Fix Version/s: 2.8.0
Resolution: Fixed
> SslTransportTls12Tls13Test can replace 'as
chia7712 merged pull request #9899:
URL: https://github.com/apache/kafka/pull/9899
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
[
https://issues.apache.org/jira/browse/KAFKA-12189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-12189.
Fix Version/s: 2.8.0
Resolution: Fixed
> ShellTest can replace 'assumeTrue' by (jun
chia7712 merged pull request #9898:
URL: https://github.com/apache/kafka/pull/9898
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
chia7712 commented on a change in pull request #9887:
URL: https://github.com/apache/kafka/pull/9887#discussion_r557882254
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -989,16 +989,20 @@ private StreamThread createAndAddStreamThread(final
[
https://issues.apache.org/jira/browse/KAFKA-12199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17265720#comment-17265720
]
Chia-Ping Tsai commented on KAFKA-12199:
[~ijuma] PowerMock does not yet have na
[
https://issues.apache.org/jira/browse/KAFKA-12203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-12203.
Fix Version/s: 2.8.0
Resolution: Fixed
> Migrate connect:mirror-client module to JU
chia7712 merged pull request #9889:
URL: https://github.com/apache/kafka/pull/9889
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
chia7712 commented on pull request #9889:
URL: https://github.com/apache/kafka/pull/9889#issuecomment-760659526
```
org.apache.kafka.streams.integration.AdjustStreamThreadCountTest.shouldAddAndRemoveStreamThreadsWhileKeepingNamesCorrect
```
It is traced by #9888 and #9887
---
abbccdda commented on a change in pull request #9871:
URL: https://github.com/apache/kafka/pull/9871#discussion_r557858498
##
File path: raft/src/main/java/org/apache/kafka/raft/QuorumState.java
##
@@ -125,9 +125,16 @@ public void initialize(OffsetAndEpoch
logEndOffsetAndEpoch
chia7712 commented on pull request #9890:
URL: https://github.com/apache/kafka/pull/9890#issuecomment-760616110
@dengziming Could you fix the conflicting files? thanks!
This is an automated message from the Apache Git Service
hachikuji commented on a change in pull request #9816:
URL: https://github.com/apache/kafka/pull/9816#discussion_r557828817
##
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##
@@ -963,49 +979,111 @@ private FetchResponseData tryCompleteFetchRequest(
hachikuji commented on a change in pull request #9816:
URL: https://github.com/apache/kafka/pull/9816#discussion_r557829548
##
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##
@@ -2216,7 +2316,7 @@ public void complete() {
// These fields are
hachikuji commented on a change in pull request #9816:
URL: https://github.com/apache/kafka/pull/9816#discussion_r557818816
##
File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
##
@@ -147,18 +221,102 @@ class KafkaMetadataLog(
}
override def createSnapsho
showuon commented on pull request #9888:
URL: https://github.com/apache/kafka/pull/9888#issuecomment-760605267
Test will fail, will work it later. Don't review yet. Thanks.
This is an automated message from the Apache Git Ser
abbccdda commented on a change in pull request #9600:
URL: https://github.com/apache/kafka/pull/9600#discussion_r557825070
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -139,8 +138,11 @@ class KafkaApis(val requestChannel: RequestChannel,
request: Re
showuon commented on pull request #9733:
URL: https://github.com/apache/kafka/pull/9733#issuecomment-760604903
@mjsax , I've reverted my change for the state change. Now, there's only the
exception handler improvement change.
And for the state change fix, after the holidays, I think
hachikuji commented on a change in pull request #9816:
URL: https://github.com/apache/kafka/pull/9816#discussion_r557643619
##
File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
##
@@ -16,28 +16,41 @@
*/
package kafka.raft
+import java.nio.file.Files
import
abbccdda commented on a change in pull request #9600:
URL: https://github.com/apache/kafka/pull/9600#discussion_r557823644
##
File path: core/src/main/scala/kafka/server/ForwardingManager.scala
##
@@ -77,7 +79,7 @@ class ForwardingManagerImpl(
override def forwardRequest(
showuon commented on pull request #9733:
URL: https://github.com/apache/kafka/pull/9733#issuecomment-760597684
OK, working on it now.
This is an automated message from the Apache Git Service.
To respond to the message, please
abbccdda commented on a change in pull request #9600:
URL: https://github.com/apache/kafka/pull/9600#discussion_r557810929
##
File path: clients/src/main/java/org/apache/kafka/clients/NodeApiVersions.java
##
@@ -123,21 +125,25 @@ public short latestUsableVersion(ApiKeys apiKey)
hachikuji commented on a change in pull request #9883:
URL: https://github.com/apache/kafka/pull/9883#discussion_r557807090
##
File path: core/src/main/scala/kafka/server/KafkaRaftServer.scala
##
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
hachikuji merged pull request #9881:
URL: https://github.com/apache/kafka/pull/9881
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
cmccabe commented on a change in pull request #9883:
URL: https://github.com/apache/kafka/pull/9883#discussion_r557799746
##
File path: core/src/main/scala/kafka/server/KafkaRaftServer.scala
##
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
hachikuji commented on a change in pull request #9600:
URL: https://github.com/apache/kafka/pull/9600#discussion_r557783391
##
File path: clients/src/main/java/org/apache/kafka/clients/NodeApiVersions.java
##
@@ -123,21 +125,25 @@ public short latestUsableVersion(ApiKeys apiKey
bob-barrett opened a new pull request #9902:
URL: https://github.com/apache/kafka/pull/9902
This patch changes the NetworkClient behavior to resolve the target node's
hostname after disconnecting from an established connection, rather than
waiting until the previously-resolved addresses ar
ijuma commented on pull request #9889:
URL: https://github.com/apache/kafka/pull/9889#issuecomment-760552078
The failed Streams tests seem unrelated, but they seem to be failing very
often.
This is an automated message from
ijuma merged pull request #9892:
URL: https://github.com/apache/kafka/pull/9892
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-10896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nguyen Cong Hieu resolved KAFKA-10896.
--
Resolution: Not A Bug
> TimeoutException when Producer try to send message to Kafka Br
cmccabe opened a new pull request #9901:
URL: https://github.com/apache/kafka/pull/9901
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
wcarlson5 commented on a change in pull request #9887:
URL: https://github.com/apache/kafka/pull/9887#discussion_r557739729
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -989,16 +989,20 @@ private StreamThread createAndAddStreamThread(fina
Colin McCabe created KAFKA-12209:
Summary: Add the timeline data structures for the KIP-631
controller
Key: KAFKA-12209
URL: https://issues.apache.org/jira/browse/KAFKA-12209
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-12183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe resolved KAFKA-12183.
--
Fix Version/s: 2.8.0
Resolution: Fixed
> Add the KIP-631 metadata record definitions
>
cmccabe opened a new pull request #9900:
URL: https://github.com/apache/kafka/pull/9900
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Colin McCabe created KAFKA-12208:
Summary: Rename AdminManager to ZkAdminManager
Key: KAFKA-12208
URL: https://issues.apache.org/jira/browse/KAFKA-12208
Project: Kafka
Issue Type: Improvement
hachikuji commented on a change in pull request #9871:
URL: https://github.com/apache/kafka/pull/9871#discussion_r557725416
##
File path: raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java
##
@@ -2182,6 +2182,46 @@ public void
testHandleCommitCallbackFiresInCand
hachikuji commented on a change in pull request #9871:
URL: https://github.com/apache/kafka/pull/9871#discussion_r557725206
##
File path: raft/src/main/java/org/apache/kafka/raft/QuorumState.java
##
@@ -125,9 +125,16 @@ public void initialize(OffsetAndEpoch
logEndOffsetAndEpoc
abbccdda commented on a change in pull request #9871:
URL: https://github.com/apache/kafka/pull/9871#discussion_r557722131
##
File path: raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java
##
@@ -2182,6 +2182,46 @@ public void
testHandleCommitCallbackFiresInCandi
ableegoldman commented on pull request #9887:
URL: https://github.com/apache/kafka/pull/9887#issuecomment-760488841
Hey @wcarlson5 can you also take a look at this?
This is an automated message from the Apache Git Service.
To
abbccdda merged pull request #9834:
URL: https://github.com/apache/kafka/pull/9834
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
cadonna commented on a change in pull request #9888:
URL: https://github.com/apache/kafka/pull/9888#discussion_r557647216
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java
##
@@ -119,37 +160,47 @@ public void shouldAddStr
[
https://issues.apache.org/jira/browse/KAFKA-12207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-12207:
Labels: needs-kip (was: )
> Do not maintain list of latest producer append information
>
[
https://issues.apache.org/jira/browse/KAFKA-12207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-12207:
Issue Type: Improvement (was: Bug)
> Do not maintain list of latest producer append infor
Jason Gustafson created KAFKA-12207:
---
Summary: Do not maintain list of latest producer append
information
Key: KAFKA-12207
URL: https://issues.apache.org/jira/browse/KAFKA-12207
Project: Kafka
C0urante commented on pull request #9880:
URL: https://github.com/apache/kafka/pull/9880#issuecomment-760448619
Thanks Randall!
This is an automated message from the Apache Git Service.
To respond to the message, please log o
jsancio commented on a change in pull request #9715:
URL: https://github.com/apache/kafka/pull/9715#discussion_r557669397
##
File path: core/src/main/scala/kafka/server/AuthHelper.scala
##
@@ -0,0 +1,74 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or m
lct45 commented on a change in pull request #9895:
URL: https://github.com/apache/kafka/pull/9895#discussion_r557642098
##
File path: docs/ops.html
##
@@ -2133,6 +2141,137 @@ RocksDB
Properties-based Metrics
+ RocksDB Properties-based Metrics:
+ All of the following properti
mjsax commented on pull request #9733:
URL: https://github.com/apache/kafka/pull/9733#issuecomment-760424092
@showuon Sorry for late response. Pretty busy atm.
We found that the fix for the exception handler contained in this PR is also
blocking https://github.com/apache/kafka/pull/9
jsancio commented on a change in pull request #9816:
URL: https://github.com/apache/kafka/pull/9816#discussion_r557643648
##
File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
##
@@ -29,15 +32,22 @@ import org.apache.kafka.snapshot.FileRawSnapshotReader
import or
aloknnikhil commented on a change in pull request #9881:
URL: https://github.com/apache/kafka/pull/9881#discussion_r557624393
##
File path: raft/src/main/java/org/apache/kafka/raft/RaftConfig.java
##
@@ -129,16 +130,25 @@ public String toString() {
QUORUM_LINGE
hachikuji commented on a change in pull request #9883:
URL: https://github.com/apache/kafka/pull/9883#discussion_r557622659
##
File path: core/src/main/scala/kafka/server/KafkaRaftController.scala
##
@@ -0,0 +1,23 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
hachikuji commented on a change in pull request #9881:
URL: https://github.com/apache/kafka/pull/9881#discussion_r557611820
##
File path: raft/src/main/java/org/apache/kafka/raft/RaftConfig.java
##
@@ -129,16 +130,25 @@ public String toString() {
QUORUM_LINGER_
[
https://issues.apache.org/jira/browse/KAFKA-10792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17265116#comment-17265116
]
Randall Hauch commented on KAFKA-10792:
---
Thanks for the backport PR for the `2.5`
[
https://issues.apache.org/jira/browse/KAFKA-10792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Randall Hauch updated KAFKA-10792:
--
Fix Version/s: 2.5.2
> Source tasks can block herder thread by hanging during stop
> -
rhauch merged pull request #9880:
URL: https://github.com/apache/kafka/pull/9880
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
rhauch commented on pull request #9880:
URL: https://github.com/apache/kafka/pull/9880#issuecomment-760387979
There seem to be environmental build issues; the builds are failing with
"JDK" unknown and "maven" unknown.
I'm going to go ahead and merge this PR to the `2.5` branch.
---
g1geordie opened a new pull request #9899:
URL: https://github.com/apache/kafka/pull/9899
SslTransportTls12Tls13Test can replace 'assumeTrue' by (junit 5) conditional
test
Test in Java8
```
testCiphersSuiteForTls12FailsForTls13()
Disabled on JRE version: 1.8.0_275
1.27 sp
rhauch commented on pull request #9880:
URL: https://github.com/apache/kafka/pull/9880#issuecomment-760385519
I'm trying to get the builds to run properly, but I did pull locally and the
build of that local branch does pass.
chia7712 commented on pull request #9889:
URL: https://github.com/apache/kafka/pull/9889#issuecomment-760384843
> Given the test results for the last build, I think you can merge this,
right?
It produces some failed tests but they pass on my local. I want to check QA
again :)
g1geordie opened a new pull request #9898:
URL: https://github.com/apache/kafka/pull/9898
ShellTest can replace 'assumeTrue' by (junit 5) conditional test
I also test in windows .
```
ShellTest > testEchoHello() SKIPPED
ShellTest > testRunProgramWithErrorReturn() SKIPPED
S
ijuma commented on pull request #9889:
URL: https://github.com/apache/kafka/pull/9889#issuecomment-760378170
@chia7712 Given the test results for the last build, I think you can merge
this, right?
This is an automated messag
ijuma commented on a change in pull request #9876:
URL: https://github.com/apache/kafka/pull/9876#discussion_r557596784
##
File path: build.gradle
##
@@ -1010,6 +1015,53 @@ project(':core') {
}
}
+project(':metadata') {
+ archivesBaseName = "kafka-metadata"
+
+ dependen
ijuma opened a new pull request #9897:
URL: https://github.com/apache/kafka/pull/9897
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
jolshan commented on pull request #9896:
URL: https://github.com/apache/kafka/pull/9896#issuecomment-760375020
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
wcarlson5 commented on pull request #9888:
URL: https://github.com/apache/kafka/pull/9888#issuecomment-760368501
@showuon These changes look good. Thanks for shoring up these tests
This is an automated message from the Apache
cmccabe opened a new pull request #9896:
URL: https://github.com/apache/kafka/pull/9896
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Colin McCabe created KAFKA-12206:
Summary: o.a.k.common.Uuid should implement Comparable
Key: KAFKA-12206
URL: https://issues.apache.org/jira/browse/KAFKA-12206
Project: Kafka
Issue Type: Im
jsancio commented on a change in pull request #9816:
URL: https://github.com/apache/kafka/pull/9816#discussion_r557586528
##
File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
##
@@ -29,15 +32,22 @@ import org.apache.kafka.snapshot.FileRawSnapshotReader
import or
jsancio commented on a change in pull request #9816:
URL: https://github.com/apache/kafka/pull/9816#discussion_r557586344
##
File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
##
@@ -113,6 +145,22 @@ class KafkaMetadataLog(
log.truncateTo(offset)
}
+ ov
cmccabe merged pull request #9876:
URL: https://github.com/apache/kafka/pull/9876
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
jsancio commented on a change in pull request #9816:
URL: https://github.com/apache/kafka/pull/9816#discussion_r557586025
##
File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
##
@@ -131,6 +179,10 @@ class KafkaMetadataLog(
}
}
+ override def highWaterm
[
https://issues.apache.org/jira/browse/KAFKA-12190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17265081#comment-17265081
]
Gary Russell commented on KAFKA-12190:
--
Given that this is a critical bug, and a re
jsancio commented on a change in pull request #9816:
URL: https://github.com/apache/kafka/pull/9816#discussion_r557585643
##
File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
##
@@ -79,13 +94,30 @@ class KafkaMetadataLog(
throw new IllegalArgumentException
jsancio commented on a change in pull request #9816:
URL: https://github.com/apache/kafka/pull/9816#discussion_r557585891
##
File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
##
@@ -147,18 +199,106 @@ class KafkaMetadataLog(
}
override def createSnapshot(
jsancio commented on a change in pull request #9816:
URL: https://github.com/apache/kafka/pull/9816#discussion_r557584847
##
File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
##
@@ -29,15 +32,22 @@ import org.apache.kafka.snapshot.FileRawSnapshotReader
import or
aloknnikhil commented on a change in pull request #9881:
URL: https://github.com/apache/kafka/pull/9881#discussion_r557584646
##
File path: raft/src/main/java/org/apache/kafka/raft/RaftConfig.java
##
@@ -129,16 +133,41 @@ public String toString() {
QUORUM_LINGE
hachikuji commented on a change in pull request #9881:
URL: https://github.com/apache/kafka/pull/9881#discussion_r557584121
##
File path: raft/src/main/java/org/apache/kafka/raft/RaftConfig.java
##
@@ -129,16 +133,41 @@ public String toString() {
QUORUM_LINGER_
cmccabe commented on a change in pull request #9876:
URL: https://github.com/apache/kafka/pull/9876#discussion_r557580624
##
File path: build.gradle
##
@@ -1010,6 +1015,53 @@ project(':core') {
}
}
+project(':metadata') {
+ archivesBaseName = "kafka-metadata"
+
+ depend
cmccabe commented on a change in pull request #9876:
URL: https://github.com/apache/kafka/pull/9876#discussion_r557580302
##
File path: build.gradle
##
@@ -1010,6 +1015,53 @@ project(':core') {
}
}
+project(':metadata') {
+ archivesBaseName = "kafka-metadata"
+
+ depend
dajac commented on a change in pull request #9832:
URL: https://github.com/apache/kafka/pull/9832#discussion_r557576590
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java
##
@@ -598,6 +618,16 @@ synchronized Integer sequence
aloknnikhil commented on a change in pull request #9881:
URL: https://github.com/apache/kafka/pull/9881#discussion_r557575111
##
File path: raft/src/test/java/org/apache/kafka/raft/RaftTestUtil.java
##
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
aloknnikhil commented on a change in pull request #9881:
URL: https://github.com/apache/kafka/pull/9881#discussion_r557574782
##
File path: raft/src/test/java/org/apache/kafka/raft/RaftConfigTest.java
##
@@ -24,6 +24,7 @@
import java.util.HashMap;
import java.util.Properties;
aloknnikhil commented on a change in pull request #9881:
URL: https://github.com/apache/kafka/pull/9881#discussion_r557574380
##
File path: raft/src/main/java/org/apache/kafka/raft/RaftConfig.java
##
@@ -129,16 +133,41 @@ public String toString() {
QUORUM_LINGE
dajac commented on a change in pull request #9832:
URL: https://github.com/apache/kafka/pull/9832#discussion_r557574182
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java
##
@@ -567,8 +571,18 @@ private void bumpIdempotentPr
aloknnikhil commented on a change in pull request #9881:
URL: https://github.com/apache/kafka/pull/9881#discussion_r557573785
##
File path: raft/src/main/java/org/apache/kafka/raft/RaftConfig.java
##
@@ -129,16 +133,41 @@ public String toString() {
QUORUM_LINGE
aloknnikhil commented on a change in pull request #9881:
URL: https://github.com/apache/kafka/pull/9881#discussion_r557571170
##
File path: raft/src/main/java/org/apache/kafka/raft/RaftConfig.java
##
@@ -129,16 +133,41 @@ public String toString() {
QUORUM_LINGE
hachikuji commented on a change in pull request #9881:
URL: https://github.com/apache/kafka/pull/9881#discussion_r557559024
##
File path: raft/src/main/java/org/apache/kafka/raft/RaftConfig.java
##
@@ -129,16 +133,41 @@ public String toString() {
QUORUM_LINGER_
jsancio commented on a change in pull request #9816:
URL: https://github.com/apache/kafka/pull/9816#discussion_r557565077
##
File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
##
@@ -147,18 +199,106 @@ class KafkaMetadataLog(
}
override def createSnapshot(
jsancio commented on a change in pull request #9816:
URL: https://github.com/apache/kafka/pull/9816#discussion_r557563029
##
File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
##
@@ -147,18 +199,106 @@ class KafkaMetadataLog(
}
override def createSnapshot(
cadonna commented on pull request #9895:
URL: https://github.com/apache/kafka/pull/9895#issuecomment-760336972
Call for review: @guozhangwang @ableegoldman @lct45
This is an automated message from the Apache Git Service.
To
cadonna opened a new pull request #9895:
URL: https://github.com/apache/kafka/pull/9895
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade
jsancio commented on a change in pull request #9816:
URL: https://github.com/apache/kafka/pull/9816#discussion_r557557769
##
File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
##
@@ -147,18 +199,106 @@ class KafkaMetadataLog(
}
override def createSnapshot(
jsancio commented on a change in pull request #9816:
URL: https://github.com/apache/kafka/pull/9816#discussion_r557557769
##
File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
##
@@ -147,18 +199,106 @@ class KafkaMetadataLog(
}
override def createSnapshot(
jsancio commented on a change in pull request #9816:
URL: https://github.com/apache/kafka/pull/9816#discussion_r557556584
##
File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
##
@@ -147,18 +199,106 @@ class KafkaMetadataLog(
}
override def createSnapshot(
[
https://issues.apache.org/jira/browse/KAFKA-10877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17265009#comment-17265009
]
Ismael Juma commented on KAFKA-10877:
-
Sounds good.
> Instantiating loggers for eve
1 - 100 of 190 matches
Mail list logo
