[GitHub] [kafka] showuon closed pull request #9791: KAFKA-10873: ignore warning messages if connector/task start failed

showuon closed pull request #9791: URL: https://github.com/apache/kafka/pull/9791 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] showuon commented on pull request #9791: KAFKA-10873: ignore warning messages if connector/task start failed

showuon commented on pull request #9791: URL: https://github.com/apache/kafka/pull/9791#issuecomment-769632410 @kkonstantine , thanks for the comments. Good to me. Close this PR. Thank you. This is an automated message from

[jira] [Assigned] (KAFKA-12246) Remove redundant suppression in KafkaAdminClient

[ https://issues.apache.org/jira/browse/KAFKA-12246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-12246: -- Assignee: YI-CHEN WANG > Remove redundant suppression in KafkaAdminClient >

[GitHub] [kafka] mjsax commented on a change in pull request #10000: KAFKA-9274: handle TimeoutException on task reset

mjsax commented on a change in pull request #1: URL: https://github.com/apache/kafka/pull/1#discussion_r566621619 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -227,6 +230,27 @@ public void initializeIfNeeded()

[GitHub] [kafka] mjsax commented on a change in pull request #10000: KAFKA-9274: handle TimeoutException on task reset

mjsax commented on a change in pull request #1: URL: https://github.com/apache/kafka/pull/1#discussion_r566621365 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -227,6 +230,27 @@ public void initializeIfNeeded()

[GitHub] [kafka] chia7712 commented on pull request #10000: KAFKA-9274: handle TimeoutException on task reset

chia7712 commented on pull request #1: URL: https://github.com/apache/kafka/pull/1#issuecomment-769626443 congratulations on PR 10,000 :) This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] tombentley commented on pull request #9441: KAFKA-10614: Ensure group state (un)load is executed in the submitted order

tombentley commented on pull request #9441: URL: https://github.com/apache/kafka/pull/9441#issuecomment-769621007 Thanks, and no worries about the wait. This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] guozhangwang commented on pull request #9441: KAFKA-10614: Ensure group state (un)load is executed in the submitted order

guozhangwang commented on pull request #9441: URL: https://github.com/apache/kafka/pull/9441#issuecomment-769618984 Yes! I will review it again. Thanks for hanging on there and my apologies... Review has always been a bit overwhelming for me :)

[GitHub] [kafka] guozhangwang commented on pull request #9268: KAFKA-10442; Add transaction admin APIs for KIP-664

guozhangwang commented on pull request #9268: URL: https://github.com/apache/kafka/pull/9268#issuecomment-769618616 Sorry man... This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (KAFKA-10793) Race condition in FindCoordinatorFuture permanently severs connection to group coordinator

[ https://issues.apache.org/jira/browse/KAFKA-10793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17274187#comment-17274187 ] Guozhang Wang commented on KAFKA-10793: --- cc [~hachikuji] [~ijuma] Hopefully we nailed it this

[GitHub] [kafka] hachikuji commented on a change in pull request #10001: MINOR: AbstractCoordinatorTest should close coordinator explicitly

hachikuji commented on a change in pull request #10001: URL: https://github.com/apache/kafka/pull/10001#discussion_r566613107 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinatorTest.java ## @@ -102,6 +104,11 @@ private

[GitHub] [kafka] guozhangwang commented on pull request #9671: KAFKA-10793: move handling of FindCoordinatorFuture to fix race condition

guozhangwang commented on pull request #9671: URL: https://github.com/apache/kafka/pull/9671#issuecomment-769616246 Awesome!! This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] chia7712 opened a new pull request #10001: MINOR: AbstractCoordinatorTest should close coordinator explicitly

chia7712 opened a new pull request #10001: URL: https://github.com/apache/kafka/pull/10001 I noticed this issue when digging into some flaky by JVM profiler. ```AbstractCoordinatorTest``` does not close coordinator so it can cause a lot of idle heartbeat threads in the following tests.

[jira] [Commented] (KAFKA-12169) Consumer can not know paritions change when client leader restart with static membership protocol

[ https://issues.apache.org/jira/browse/KAFKA-12169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17274181#comment-17274181 ] Guozhang Wang commented on KAFKA-12169: --- [~zoushengfu] by "restart with unknown member id", do you

[GitHub] [kafka] mjsax opened a new pull request #10000: KAFKA-9274: handle TimeoutException on task reset

mjsax opened a new pull request #1: URL: https://github.com/apache/kafka/pull/1 - part of KIP-572 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] hachikuji opened a new pull request #9999: MINOR: Ensure `InterBrokerSendThread` closes `NetworkClient`

hachikuji opened a new pull request #: URL: https://github.com/apache/kafka/pull/ We should ensure `NetworkClient` is closed properly when `InterBrokerSendThread` is shutdown. Also use `initiateShutdown` instead of `wakeup()` to alert polling thread. ### Committer Checklist

[jira] [Updated] (KAFKA-12169) Consumer can not know paritions change when client leader restart with static membership protocol

[ https://issues.apache.org/jira/browse/KAFKA-12169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-12169: -- Summary: Consumer can not know paritions change when client leader restart with static

[GitHub] [kafka] kkonstantine commented on pull request #9791: KAFKA-10873: ignore warning messages if connector/task start failed

kkonstantine commented on pull request #9791: URL: https://github.com/apache/kafka/pull/9791#issuecomment-769611695 The former I guess. I don't see a strong case on skipping the messages based on number of occurrences. Seems we can use this information in the log and that it should be

[GitHub] [kafka] guozhangwang commented on pull request #9969: MINOR: updated upgrade and architecture for KIP-663, KIP-696, and KIP-671

guozhangwang commented on pull request #9969: URL: https://github.com/apache/kafka/pull/9969#issuecomment-769608173 LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] g1geordie commented on pull request #9906: KAFKA-10885 Refactor MemoryRecordsBuilderTest/MemoryRecordsTest to avoid a lot of…

g1geordie commented on pull request #9906: URL: https://github.com/apache/kafka/pull/9906#issuecomment-769603195 @chia7712 Thank for your patch . I follow the style and change `MemoryRecordsBuilderTest` Can you help me take a look? :)

[GitHub] [kafka] guozhangwang commented on a change in pull request #9253: KAFKA-10366 & KAFKA-9649: Implement KIP-659 to allow TimeWindowedDeserializer and TimeWindowedSerde to handle window size

guozhangwang commented on a change in pull request #9253: URL: https://github.com/apache/kafka/pull/9253#discussion_r566597020 ## File path: streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/Serdes.scala ## @@ -41,8 +43,19 @@ object Serdes { implicit def

[GitHub] [kafka] hachikuji opened a new pull request #9998: KAFKA-12250; Add metadata record serde for KIP-631

hachikuji opened a new pull request #9998: URL: https://github.com/apache/kafka/pull/9998 This patch adds a `RecordSerde` implementation for the metadata record format expected by KIP-631. ### Committer Checklist (excluded from commit message) - [ ] Verify design and

[jira] [Created] (KAFKA-12250) Add metadata record serde logic for KIP-631

Jason Gustafson created KAFKA-12250: --- Summary: Add metadata record serde logic for KIP-631 Key: KAFKA-12250 URL: https://issues.apache.org/jira/browse/KAFKA-12250 Project: Kafka Issue

[GitHub] [kafka] rohitrmd commented on a change in pull request #9744: KAFKA-10062: Add a method to retrieve the current timestamp as known by the Streams app

rohitrmd commented on a change in pull request #9744: URL: https://github.com/apache/kafka/pull/9744#discussion_r566587951 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractProcessorContext.java ## @@ -45,7 +45,6 @@ private boolean

[GitHub] [kafka] rohitrmd commented on a change in pull request #9744: KAFKA-10062: Add a method to retrieve the current timestamp as known by the Streams app

rohitrmd commented on a change in pull request #9744: URL: https://github.com/apache/kafka/pull/9744#discussion_r566587951 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractProcessorContext.java ## @@ -45,7 +45,6 @@ private boolean

[GitHub] [kafka] rohitrmd commented on a change in pull request #9744: KAFKA-10062: Add a method to retrieve the current timestamp as known by the Streams app

rohitrmd commented on a change in pull request #9744: URL: https://github.com/apache/kafka/pull/9744#discussion_r566587951 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractProcessorContext.java ## @@ -45,7 +45,6 @@ private boolean

[GitHub] [kafka] hachikuji commented on a change in pull request #9967: KAFKA-12236; New meta.properties logic for KIP-500

hachikuji commented on a change in pull request #9967: URL: https://github.com/apache/kafka/pull/9967#discussion_r566587032 ## File path: core/src/main/scala/kafka/server/Server.scala ## @@ -46,6 +46,22 @@ object Server { new Metrics(metricConfig, reporters, time, true,

[GitHub] [kafka] mjsax commented on a change in pull request #9997: KAFKA-9274: Add timeout handling for `StreamPartitioner`

mjsax commented on a change in pull request #9997: URL: https://github.com/apache/kafka/pull/9997#discussion_r566586589 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -714,19 +720,34 @@ public boolean process(final long

[GitHub] [kafka] mjsax commented on a change in pull request #9997: KAFKA-9274: Add timeout handling for `StreamPartitioner`

mjsax commented on a change in pull request #9997: URL: https://github.com/apache/kafka/pull/9997#discussion_r566580878 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -714,19 +720,34 @@ public boolean process(final long

[GitHub] [kafka] mjsax commented on a change in pull request #9997: KAFKA-9274: Add timeout handling for `StreamPartitioner`

mjsax commented on a change in pull request #9997: URL: https://github.com/apache/kafka/pull/9997#discussion_r566580717 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -663,18 +666,21 @@ public boolean isProcessable(final

[GitHub] [kafka] mjsax commented on a change in pull request #9997: KAFKA-9274: Add timeout handling for `StreamPartitioner`

mjsax commented on a change in pull request #9997: URL: https://github.com/apache/kafka/pull/9997#discussion_r566580568 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -99,6 +100,7 @@ private final

[GitHub] [kafka] mjsax opened a new pull request #9997: KAFKA-9274: Add timeout handling for `StreamPartitioner`

mjsax opened a new pull request #9997: URL: https://github.com/apache/kafka/pull/9997 - part of KIP-572 When a custom `StreamPartitioner` is used, we need to get the number of partitions of output topics from the producer. This `partitionFor(topic)` call may through a

[GitHub] [kafka] ableegoldman commented on a change in pull request #9978: KAFKA-10716: persist UUID in state directory for stable processId across restarts

ableegoldman commented on a change in pull request #9978: URL: https://github.com/apache/kafka/pull/9978#discussion_r566576655 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -133,6 +152,72 @@ private void

[GitHub] [kafka] ableegoldman commented on a change in pull request #9978: KAFKA-10716: persist UUID in state directory for stable processId across restarts

ableegoldman commented on a change in pull request #9978: URL: https://github.com/apache/kafka/pull/9978#discussion_r566559281 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -133,6 +152,72 @@ private void

[GitHub] [kafka] tang7526 commented on pull request #9991: MINOR: Reorder the modifiers and Replace Map.get with Map.computeIfAbsent

tang7526 commented on pull request #9991: URL: https://github.com/apache/kafka/pull/9991#issuecomment-769547448 > @tang7526 Could you merge trunk to trigger QA again? Done This is an automated message from the Apache

[GitHub] [kafka] chia7712 commented on pull request #9991: MINOR: Reorder the modifiers and Replace Map.get with Map.computeIfAbsent

chia7712 commented on pull request #9991: URL: https://github.com/apache/kafka/pull/9991#issuecomment-769546117 @tang7526 Could you merge trunk to trigger QA again? This is an automated message from the Apache Git Service.

[GitHub] [kafka] dengziming commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

dengziming commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r566550612 ## File path: core/src/test/scala/unit/kafka/server/KafkaApisTest.scala ## @@ -1879,6 +1879,109 @@ class KafkaApisTest {

[GitHub] [kafka] ableegoldman commented on a change in pull request #9978: KAFKA-10716: persist UUID in state directory for stable processId across restarts

ableegoldman commented on a change in pull request #9978: URL: https://github.com/apache/kafka/pull/9978#discussion_r566550049 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -133,6 +152,72 @@ private void

[GitHub] [kafka] ableegoldman commented on a change in pull request #9978: KAFKA-10716: persist UUID in state directory for stable processId across restarts

ableegoldman commented on a change in pull request #9978: URL: https://github.com/apache/kafka/pull/9978#discussion_r566549210 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -1208,24 +1227,28 @@ private Thread shutdownHelper(final boolean

[GitHub] [kafka] ijuma commented on a change in pull request #9589: KAFKA-10710 - Mirror Maker 2 - Create herders only if source->target.enabled=true

ijuma commented on a change in pull request #9589: URL: https://github.com/apache/kafka/pull/9589#discussion_r566540886 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMakerConfigTest.java ## @@ -256,6 +257,80 @@ public void

[GitHub] [kafka] aloknnikhil opened a new pull request #9996: KAFKA-12249: Add client-side Decommission Broker RPC

aloknnikhil opened a new pull request #9996: URL: https://github.com/apache/kafka/pull/9996 ### Committer Checklist (excluded from commit message) - [x] Verify design and implementation - [x] Verify test coverage and CI build status - [x] Verify documentation (including upgrade

[GitHub] [kafka] aloknnikhil commented on a change in pull request #9589: KAFKA-10710 - Mirror Maker 2 - Create herders only if source->target.enabled=true

aloknnikhil commented on a change in pull request #9589: URL: https://github.com/apache/kafka/pull/9589#discussion_r566536740 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMakerConfigTest.java ## @@ -256,6 +257,80 @@ public void

[GitHub] [kafka] junrao commented on a change in pull request #9901: KAFKA-12209: Add the timeline data structures for the KIP-631 controller

junrao commented on a change in pull request #9901: URL: https://github.com/apache/kafka/pull/9901#discussion_r566532815 ## File path: metadata/src/main/java/org/apache/kafka/timeline/timeline/SnapshottableHashTable.java ## @@ -0,0 +1,410 @@ +/* + * Licensed to the Apache

[jira] [Commented] (KAFKA-10853) Replication protocol deficiencies with workloads requiring high durability guarantees

[ https://issues.apache.org/jira/browse/KAFKA-10853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17274114#comment-17274114 ] Kyle Ambroff-Kao commented on KAFKA-10853: -- I've been discussing this with my team at LinkedIn

[GitHub] [kafka] junrao commented on a change in pull request #9901: KAFKA-12209: Add the timeline data structures for the KIP-631 controller

junrao commented on a change in pull request #9901: URL: https://github.com/apache/kafka/pull/9901#discussion_r566532467 ## File path: metadata/src/main/java/org/apache/kafka/timeline/timeline/SnapshottableHashTable.java ## @@ -0,0 +1,410 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] junrao commented on a change in pull request #9901: KAFKA-12209: Add the timeline data structures for the KIP-631 controller

junrao commented on a change in pull request #9901: URL: https://github.com/apache/kafka/pull/9901#discussion_r566532372 ## File path: metadata/src/main/java/org/apache/kafka/timeline/timeline/TimelineHashMap.java ## @@ -0,0 +1,414 @@ +/* + * Licensed to the Apache Software

[jira] [Created] (KAFKA-12249) KIP-500: Add client-side Decommission Broker RPC

Alok Nikhil created KAFKA-12249: --- Summary: KIP-500: Add client-side Decommission Broker RPC Key: KAFKA-12249 URL: https://issues.apache.org/jira/browse/KAFKA-12249 Project: Kafka Issue Type:

[GitHub] [kafka] aloknnikhil commented on pull request #9994: KAFKA-12248: Add BrokerHeartbeat/BrokerRegistration RPCs for KIP-500

aloknnikhil commented on pull request #9994: URL: https://github.com/apache/kafka/pull/9994#issuecomment-769516430 @hachikuji Fixed it up to merge only the Broker-Controller RPCs (Heartbeat/Registration) This is an

[jira] [Created] (KAFKA-12248) KIP-500: Add broker heartbeat and registration RPCs

Alok Nikhil created KAFKA-12248: --- Summary: KIP-500: Add broker heartbeat and registration RPCs Key: KAFKA-12248 URL: https://issues.apache.org/jira/browse/KAFKA-12248 Project: Kafka Issue

[jira] [Comment Edited] (KAFKA-7263) Container exception java.lang.IllegalStateException: Coordinator selected invalid assignment protocol: null

[ https://issues.apache.org/jira/browse/KAFKA-7263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17274089#comment-17274089 ] Jot Zhao edited comment on KAFKA-7263 at 1/29/21, 1:32 AM: --- [~soodvarun25] this

[jira] [Comment Edited] (KAFKA-7263) Container exception java.lang.IllegalStateException: Coordinator selected invalid assignment protocol: null

[ https://issues.apache.org/jira/browse/KAFKA-7263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17274089#comment-17274089 ] Jot Zhao edited comment on KAFKA-7263 at 1/29/21, 1:32 AM: --- [~soodvarun25] this

[jira] [Commented] (KAFKA-7263) Container exception java.lang.IllegalStateException: Coordinator selected invalid assignment protocol: null

[ https://issues.apache.org/jira/browse/KAFKA-7263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17274089#comment-17274089 ] Jot Zhao commented on KAFKA-7263: - [~soodvarun25] this issues  has fixed by issue

[GitHub] [kafka] hachikuji merged pull request #9985: KAFKA-12237: Support non-routable quorum voter addresses

hachikuji merged pull request #9985: URL: https://github.com/apache/kafka/pull/9985 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] sudoa commented on pull request #9995: Add log about broker info when getting UNKNOWN_TOPIC_OR_PARTITION error

sudoa commented on pull request #9995: URL: https://github.com/apache/kafka/pull/9995#issuecomment-769495037 done by mistake This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] sudoa closed pull request #9995: Add log about broker info when getting UNKNOWN_TOPIC_OR_PARTITION error

sudoa closed pull request #9995: URL: https://github.com/apache/kafka/pull/9995 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] sudoa opened a new pull request #9995: Add log about broker info when getting UNKNOWN_TOPIC_OR_PARTITION error

sudoa opened a new pull request #9995: URL: https://github.com/apache/kafka/pull/9995 Description: This patch adds additional logs in the `NetworkClient` to print metadata info such as leader id and epoch for partitions that fail metadata fetch with UNKNOWN_TOPIC_OR_PARTITION error. This

[GitHub] [kafka] hachikuji commented on pull request #9994: MINOR: Add BrokerHeartbeat/BrokerRegistration/DecommissionBroker RPCs for KIP-500

hachikuji commented on pull request #9994: URL: https://github.com/apache/kafka/pull/9994#issuecomment-769479261 Thanks for the PR. Just to make this a little more manageable, could we split this into two PRs? One for the register/heartbeat controller APIs? And a separate one for

[GitHub] [kafka] aloknnikhil opened a new pull request #9994: MINOR: Add BrokerHeartbeat/BrokerRegistration/DecommissionBroker RPCs for KIP-500

aloknnikhil opened a new pull request #9994: URL: https://github.com/apache/kafka/pull/9994 ### Committer Checklist (excluded from commit message) - [x] Verify design and implementation - [x] Verify test coverage and CI build status - [x] Verify documentation (including upgrade

[GitHub] [kafka] jolshan commented on a change in pull request #9684: KAFKA-10764: Add support for returning topic IDs on create, supplying topic IDs for delete

jolshan commented on a change in pull request #9684: URL: https://github.com/apache/kafka/pull/9684#discussion_r566487288 ## File path: core/src/test/scala/unit/kafka/server/TopicIdWithOldInterBrokerProtocolTest.scala ## @@ -15,12 +15,13 @@ * limitations under the License.

[GitHub] [kafka] ableegoldman commented on pull request #9984: KAFKA-12247: add timeout and static group rebalance to remove thread

ableegoldman commented on pull request #9984: URL: https://github.com/apache/kafka/pull/9984#issuecomment-769472481 FYI ``` 15:42:08 Execution failed for task ':streams:checkstyleMain'. ``` This is an automated

[GitHub] [kafka] cmccabe commented on a change in pull request #9901: KAFKA-12209: Add the timeline data structures for the KIP-631 controller

cmccabe commented on a change in pull request #9901: URL: https://github.com/apache/kafka/pull/9901#discussion_r566481305 ## File path: metadata/src/main/java/org/apache/kafka/timeline/timeline/TimelineHashSet.java ## @@ -0,0 +1,260 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cmccabe commented on a change in pull request #9901: KAFKA-12209: Add the timeline data structures for the KIP-631 controller

cmccabe commented on a change in pull request #9901: URL: https://github.com/apache/kafka/pull/9901#discussion_r566481190 ## File path: metadata/src/main/java/org/apache/kafka/timeline/timeline/TimelineHashMap.java ## @@ -0,0 +1,414 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cmccabe commented on a change in pull request #9901: KAFKA-12209: Add the timeline data structures for the KIP-631 controller

cmccabe commented on a change in pull request #9901: URL: https://github.com/apache/kafka/pull/9901#discussion_r566481017 ## File path: metadata/src/main/java/org/apache/kafka/timeline/timeline/SnapshottableHashTable.java ## @@ -0,0 +1,410 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] ableegoldman commented on a change in pull request #9984: KAFKA-12247: add timeout and static group rebalance to remove thread

ableegoldman commented on a change in pull request #9984: URL: https://github.com/apache/kafka/pull/9984#discussion_r566478398 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -69,6 +73,7 @@ import

[GitHub] [kafka] cmccabe commented on a change in pull request #9901: KAFKA-12209: Add the timeline data structures for the KIP-631 controller

cmccabe commented on a change in pull request #9901: URL: https://github.com/apache/kafka/pull/9901#discussion_r566469662 ## File path: metadata/src/main/java/org/apache/kafka/timeline/timeline/TimelineHashMap.java ## @@ -0,0 +1,414 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cmccabe commented on a change in pull request #9901: KAFKA-12209: Add the timeline data structures for the KIP-631 controller

cmccabe commented on a change in pull request #9901: URL: https://github.com/apache/kafka/pull/9901#discussion_r566469311 ## File path: metadata/src/main/java/org/apache/kafka/timeline/timeline/TimelineHashMap.java ## @@ -0,0 +1,414 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cmccabe commented on a change in pull request #9901: KAFKA-12209: Add the timeline data structures for the KIP-631 controller

cmccabe commented on a change in pull request #9901: URL: https://github.com/apache/kafka/pull/9901#discussion_r566468092 ## File path: metadata/src/main/java/org/apache/kafka/timeline/timeline/SnapshotRegistry.java ## @@ -0,0 +1,153 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cmccabe commented on a change in pull request #9901: KAFKA-12209: Add the timeline data structures for the KIP-631 controller

cmccabe commented on a change in pull request #9901: URL: https://github.com/apache/kafka/pull/9901#discussion_r566468092 ## File path: metadata/src/main/java/org/apache/kafka/timeline/timeline/SnapshotRegistry.java ## @@ -0,0 +1,153 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cmccabe commented on a change in pull request #9901: KAFKA-12209: Add the timeline data structures for the KIP-631 controller

cmccabe commented on a change in pull request #9901: URL: https://github.com/apache/kafka/pull/9901#discussion_r566467584 ## File path: metadata/src/main/java/org/apache/kafka/timeline/timeline/SnapshottableHashTable.java ## @@ -0,0 +1,410 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] jsancio commented on a change in pull request #9816: KAFKA-10761: Kafka Raft update log start offset

jsancio commented on a change in pull request #9816: URL: https://github.com/apache/kafka/pull/9816#discussion_r566463935 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -983,48 +999,88 @@ private FetchResponseData tryCompleteFetchRequest(

[GitHub] [kafka] jsancio commented on a change in pull request #9816: KAFKA-10761: Kafka Raft update log start offset

jsancio commented on a change in pull request #9816: URL: https://github.com/apache/kafka/pull/9816#discussion_r566463607 ## File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala ## @@ -147,18 +223,102 @@ class KafkaMetadataLog( } override def

[GitHub] [kafka] hachikuji merged pull request #9589: KAFKA-10710 - Mirror Maker 2 - Create herders only if source->target.enabled=true

hachikuji merged pull request #9589: URL: https://github.com/apache/kafka/pull/9589 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] jsancio commented on a change in pull request #9816: KAFKA-10761: Kafka Raft update log start offset

jsancio commented on a change in pull request #9816: URL: https://github.com/apache/kafka/pull/9816#discussion_r566460558 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1910,7 +1931,7 @@ class Log(@volatile private var _dir: File, in the header.

[GitHub] [kafka] cmccabe commented on a change in pull request #9901: KAFKA-12209: Add the timeline data structures for the KIP-631 controller

cmccabe commented on a change in pull request #9901: URL: https://github.com/apache/kafka/pull/9901#discussion_r566457016 ## File path: metadata/src/main/java/org/apache/kafka/timeline/timeline/SnapshottableHashTable.java ## @@ -0,0 +1,410 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] cmccabe commented on a change in pull request #9901: KAFKA-12209: Add the timeline data structures for the KIP-631 controller

cmccabe commented on a change in pull request #9901: URL: https://github.com/apache/kafka/pull/9901#discussion_r566454521 ## File path: metadata/src/main/java/org/apache/kafka/timeline/timeline/SnapshottableHashTable.java ## @@ -0,0 +1,410 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] cmccabe commented on a change in pull request #9901: KAFKA-12209: Add the timeline data structures for the KIP-631 controller

cmccabe commented on a change in pull request #9901: URL: https://github.com/apache/kafka/pull/9901#discussion_r566452138 ## File path: metadata/src/main/java/org/apache/kafka/timeline/timeline/SnapshottableHashTable.java ## @@ -0,0 +1,410 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] cmccabe commented on a change in pull request #9901: KAFKA-12209: Add the timeline data structures for the KIP-631 controller

cmccabe commented on a change in pull request #9901: URL: https://github.com/apache/kafka/pull/9901#discussion_r566451017 ## File path: metadata/src/main/java/org/apache/kafka/timeline/timeline/SnapshotRegistry.java ## @@ -0,0 +1,153 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cmccabe commented on a change in pull request #9901: KAFKA-12209: Add the timeline data structures for the KIP-631 controller

cmccabe commented on a change in pull request #9901: URL: https://github.com/apache/kafka/pull/9901#discussion_r566450389 ## File path: metadata/src/main/java/org/apache/kafka/timeline/timeline/SnapshottableHashTable.java ## @@ -0,0 +1,410 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9684: KAFKA-10764: Add support for returning topic IDs on create, supplying topic IDs for delete

rajinisivaram commented on a change in pull request #9684: URL: https://github.com/apache/kafka/pull/9684#discussion_r566442295 ## File path: core/src/test/scala/unit/kafka/server/TopicIdWithOldInterBrokerProtocolTest.scala ## @@ -15,12 +15,13 @@ * limitations under the

[GitHub] [kafka] jsancio commented on a change in pull request #9816: KAFKA-10761: Kafka Raft update log start offset

jsancio commented on a change in pull request #9816: URL: https://github.com/apache/kafka/pull/9816#discussion_r566430269 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -983,48 +999,88 @@ private FetchResponseData tryCompleteFetchRequest(

[GitHub] [kafka] wangwalton opened a new pull request #9993: Schema Exception Interface fix

wangwalton opened a new pull request #9993: URL: https://github.com/apache/kafka/pull/9993 Bug fix. I'm passing in a SchemaBuilder for schema, and this will always throw an exception since it's doing an equals comparison. The reason that I need to pass in a builder is because my schema

[GitHub] [kafka] aloknnikhil commented on a change in pull request #9985: KAFKA-12237: Support non-routable quorum voter addresses

aloknnikhil commented on a change in pull request #9985: URL: https://github.com/apache/kafka/pull/9985#discussion_r566406761 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftConfig.java ## @@ -99,7 +99,7 @@ public final InetSocketAddress address;

[GitHub] [kafka] hachikuji commented on a change in pull request #9985: KAFKA-12237: Support non-routable quorum voter addresses

hachikuji commented on a change in pull request #9985: URL: https://github.com/apache/kafka/pull/9985#discussion_r566405275 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftConfig.java ## @@ -99,7 +99,7 @@ public final InetSocketAddress address;

[GitHub] [kafka] lct45 commented on a change in pull request #9978: KAFKA-10716: persist UUID in state directory for stable processId across restarts

lct45 commented on a change in pull request #9978: URL: https://github.com/apache/kafka/pull/9978#discussion_r566398284 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -133,6 +152,72 @@ private void

[GitHub] [kafka] mumrah commented on pull request #9872: KAFKA-10759: ARM support for Kafka

mumrah commented on pull request #9872: URL: https://github.com/apache/kafka/pull/9872#issuecomment-769382560 Ok, the ARM build compiles at least https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-9992/1/console I'll try running the unit test suite next.

[GitHub] [kafka] aloknnikhil commented on a change in pull request #9985: KAFKA-12237: Support non-routable quorum voter addresses

aloknnikhil commented on a change in pull request #9985: URL: https://github.com/apache/kafka/pull/9985#discussion_r566394059 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftConfig.java ## @@ -99,7 +99,7 @@ public final InetSocketAddress address;

[GitHub] [kafka] hachikuji commented on a change in pull request #9985: KAFKA-12237: Support non-routable quorum voter addresses

hachikuji commented on a change in pull request #9985: URL: https://github.com/apache/kafka/pull/9985#discussion_r566390451 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftConfig.java ## @@ -99,7 +99,7 @@ public final InetSocketAddress address;

[GitHub] [kafka] lct45 commented on a change in pull request #9253: KAFKA-10366 & KAFKA-9649: Implement KIP-659 to allow TimeWindowedDeserializer and TimeWindowedSerde to handle window size

lct45 commented on a change in pull request #9253: URL: https://github.com/apache/kafka/pull/9253#discussion_r564906839 ## File path: streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/SerdesUnitTest.scala ## @@ -0,0 +1,35 @@ +/** + * Licensed to the Apache

[GitHub] [kafka] ableegoldman commented on a change in pull request #9978: KAFKA-10716: persist UUID in state directory for stable processId across restarts

ableegoldman commented on a change in pull request #9978: URL: https://github.com/apache/kafka/pull/9978#discussion_r566379864 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -133,6 +152,72 @@ private void

[GitHub] [kafka] aloknnikhil commented on a change in pull request #9985: KAFKA-12237: Support non-routable quorum voter addresses

aloknnikhil commented on a change in pull request #9985: URL: https://github.com/apache/kafka/pull/9985#discussion_r566379088 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftConfig.java ## @@ -89,8 +92,23 @@ private final int appendLingerMs; private final

[GitHub] [kafka] aloknnikhil commented on a change in pull request #9985: KAFKA-12237: Support non-routable quorum voter addresses

aloknnikhil commented on a change in pull request #9985: URL: https://github.com/apache/kafka/pull/9985#discussion_r566378930 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftConfig.java ## @@ -102,31 +120,23 @@ public boolean equals(Object obj) {

[GitHub] [kafka] aloknnikhil commented on a change in pull request #9985: KAFKA-12237: Support non-routable quorum voter addresses

aloknnikhil commented on a change in pull request #9985: URL: https://github.com/apache/kafka/pull/9985#discussion_r566378383 ## File path: core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala ## @@ -1001,6 +1001,12 @@ class KafkaConfigTest {

[GitHub] [kafka] aloknnikhil commented on a change in pull request #9985: KAFKA-12237: Support non-routable quorum voter addresses

aloknnikhil commented on a change in pull request #9985: URL: https://github.com/apache/kafka/pull/9985#discussion_r566377621 ## File path: core/src/main/scala/kafka/raft/RaftManager.scala ## @@ -126,9 +126,13 @@ class KafkaRaftManager[T]( case spec: InetAddressSpec

[GitHub] [kafka] hachikuji commented on a change in pull request #9985: KAFKA-12237: Support non-routable quorum voter addresses

hachikuji commented on a change in pull request #9985: URL: https://github.com/apache/kafka/pull/9985#discussion_r566373256 ## File path: core/src/main/scala/kafka/raft/RaftManager.scala ## @@ -126,9 +126,13 @@ class KafkaRaftManager[T]( case spec: InetAddressSpec =>

[jira] [Updated] (KAFKA-8940) Flaky Test SmokeTestDriverIntegrationTest.shouldWorkWithRebalance

[ https://issues.apache.org/jira/browse/KAFKA-8940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-8940: -- Description: The test does not properly account for windowing. See this

[jira] [Updated] (KAFKA-8940) Flaky Test SmokeTestDriverIntegrationTest.shouldWorkWithRebalance

[ https://issues.apache.org/jira/browse/KAFKA-8940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-8940: -- Description: The test does not properly account for windowing. See [this

[jira] [Updated] (KAFKA-8940) Flaky Test SmokeTestDriverIntegrationTest.shouldWorkWithRebalance

[ https://issues.apache.org/jira/browse/KAFKA-8940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-8940: -- Description: The test does not properly account for windowing. See (was: I

[jira] [Updated] (KAFKA-8940) Flaky Test SmokeTestDriverIntegrationTest.shouldWorkWithRebalance

[ https://issues.apache.org/jira/browse/KAFKA-8940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-8940: -- Labels: flaky-test newbie++ (was: flaky-test) > Flaky Test

[GitHub] [kafka] mumrah opened a new pull request #9992: KAFKA-10759 Add ARM build stage

mumrah opened a new pull request #9992: URL: https://github.com/apache/kafka/pull/9992 Copy of https://github.com/apache/kafka/pull/9872, but opened by a committer so Jenkins will actually apply the Jenkinsfile changes

[GitHub] [kafka] mumrah commented on pull request #9872: KAFKA-10759: ARM support for Kafka

mumrah commented on pull request #9872: URL: https://github.com/apache/kafka/pull/9872#issuecomment-769342004 I believe we have Jenkins configured so it will only take Jenkinsfile changes in a PR if they are from a committer. I'll open a PR shortly to see if this works. @ijuma

  1   2   >