[GitHub] [kafka] michael-carter-instaclustr commented on pull request #8844: KAFKA-9887 fix failed task or connector count on startup failure

2021-03-31 Thread GitBox
michael-carter-instaclustr commented on pull request #8844: URL: https://github.com/apache/kafka/pull/8844#issuecomment-811661662 Thanks for having a look at this @rhauch . I've updated with the suggested log messages, and reordered the methods and lines in the ConnectorStatusListener.

[jira] [Commented] (KAFKA-12468) Initial offsets are copied from source to target cluster

2021-03-31 Thread Alan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312826#comment-17312826 ] Alan commented on KAFKA-12468: -- Hey Angelos, By limiting to less than 10 partitions per task, I was able

[jira] [Commented] (KAFKA-12594) Self-join produces no ouput, and prevents other streams from producing output

2021-03-31 Thread Jamie Brandon (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312809#comment-17312809 ] Jamie Brandon commented on KAFKA-12594: --- Tried leaving it sitting for 20 minutes to see if it

[jira] [Updated] (KAFKA-12594) Self-join produces no ouput, and prevents other streams from producing output

2021-03-31 Thread Jamie Brandon (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jamie Brandon updated KAFKA-12594: -- Attachment: logs.tar.gz > Self-join produces no ouput, and prevents other streams from

[jira] [Commented] (KAFKA-12594) Self-join produces no ouput, and prevents other streams from producing output

2021-03-31 Thread Jamie Brandon (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312806#comment-17312806 ] Jamie Brandon commented on KAFKA-12594: --- I've tried setting MAX_TASK_IDLE_MS_CONFIG to 500ms and

[jira] [Commented] (KAFKA-12594) Self-join produces no ouput, and prevents other streams from producing output

2021-03-31 Thread Jamie Brandon (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312805#comment-17312805 ] Jamie Brandon commented on KAFKA-12594: --- With the identity and self-join, about 1 in 10 runs does

[jira] [Comment Edited] (KAFKA-12594) Self-join produces no ouput, and prevents other streams from producing output

2021-03-31 Thread Jamie Brandon (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312802#comment-17312802 ] Jamie Brandon edited comment on KAFKA-12594 at 4/1/21, 1:16 AM: I'm also

[jira] [Commented] (KAFKA-12594) Self-join produces no ouput, and prevents other streams from producing output

2021-03-31 Thread Jamie Brandon (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312802#comment-17312802 ] Jamie Brandon commented on KAFKA-12594: --- I'm also noticing that when I just run the identity

[jira] [Commented] (KAFKA-12594) Self-join produces no ouput, and prevents other streams from producing output

2021-03-31 Thread Jamie Brandon (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312797#comment-17312797 ] Jamie Brandon commented on KAFKA-12594: --- Slack discussion -

[GitHub] [kafka] junrao commented on a change in pull request #10405: KAFKA-3968: fsync the parent directory of a segment file when the file is created

2021-03-31 Thread GitBox
junrao commented on a change in pull request #10405: URL: https://github.com/apache/kafka/pull/10405#discussion_r605293308 ## File path: clients/src/main/java/org/apache/kafka/common/record/FileRecords.java ## @@ -195,6 +199,17 @@ public int append(MemoryRecords records)

[jira] [Commented] (KAFKA-12594) Self-join produces no ouput, and prevents other streams from producing output

2021-03-31 Thread Jamie Brandon (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312787#comment-17312787 ] Jamie Brandon commented on KAFKA-12594: --- Same behavior with this example - when the aggregate is

[GitHub] [kafka] junrao merged pull request #10454: MINOR: Rename LogUtils class in tests to LogTestUtils

2021-03-31 Thread GitBox
junrao merged pull request #10454: URL: https://github.com/apache/kafka/pull/10454 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Commented] (KAFKA-12574) Deprecate eos-alpha

2021-03-31 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312782#comment-17312782 ] Guozhang Wang commented on KAFKA-12574: --- Okay, if we are concerned about 4) to be too aggressive,

[jira] [Created] (KAFKA-12595) New Consumer metric for records/bytes committed

2021-03-31 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-12595: -- Summary: New Consumer metric for records/bytes committed Key: KAFKA-12595 URL: https://issues.apache.org/jira/browse/KAFKA-12595 Project: Kafka

[jira] [Created] (KAFKA-12594) Self-join produces no ouput, and prevents other streams from producing output

2021-03-31 Thread Jamie Brandon (Jira)
Jamie Brandon created KAFKA-12594: - Summary: Self-join produces no ouput, and prevents other streams from producing output Key: KAFKA-12594 URL: https://issues.apache.org/jira/browse/KAFKA-12594

[jira] [Resolved] (KAFKA-12575) Eliminate Log.isLogDirOffline boolean attribute

2021-03-31 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-12575. - Fix Version/s: 3.0.0 Resolution: Fixed merged the PR to trunk > Eliminate Log.isLogDirOffline

[GitHub] [kafka] junrao merged pull request #10430: KAFKA-12575: Eliminate Log.isLogDirOffline boolean attribute

2021-03-31 Thread GitBox
junrao merged pull request #10430: URL: https://github.com/apache/kafka/pull/10430 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] cmccabe commented on pull request #10366: KAFKA-12467: Add controller-side snapshot generation

2021-03-31 Thread GitBox
cmccabe commented on pull request #10366: URL: https://github.com/apache/kafka/pull/10366#issuecomment-811503450 I split off parts of this into: https://github.com/apache/kafka/pull/10455 https://github.com/apache/kafka/pull/10456 -- This is an automated message from the Apache Git

[GitHub] [kafka] cmccabe opened a new pull request #10456: MINOR: support ImplicitLinkedHashCollection#sort

2021-03-31 Thread GitBox
cmccabe opened a new pull request #10456: URL: https://github.com/apache/kafka/pull/10456 Implement an O(N log N) merge sort in ImplicitLinkedHashCollection. This is useful sometimes in unit tests for comparing collections. -- This is an automated message from the Apache Git Service.

[GitHub] [kafka] mjsax commented on a change in pull request #10452: KAFKA-12593: Fix Apache License headers

2021-03-31 Thread GitBox
mjsax commented on a change in pull request #10452: URL: https://github.com/apache/kafka/pull/10452#discussion_r605247582 ## File path: NOTICE ## @@ -10,3 +10,7 @@ License. The source code of jersey can be found at https://github.com/jersey/jer This distribution has a binary

[jira] [Commented] (KAFKA-12593) The Streams-Scala contains the wrong license header

2021-03-31 Thread Justin Mclean (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312721#comment-17312721 ] Justin Mclean commented on KAFKA-12593: --- In general: - If the work was done at the ASF it should

[GitHub] [kafka] cmccabe opened a new pull request #10455: MINOR: Support ExponentialBackoff without jitter

2021-03-31 Thread GitBox
cmccabe opened a new pull request #10455: URL: https://github.com/apache/kafka/pull/10455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Commented] (KAFKA-12593) The Streams-Scala contains the wrong license header

2021-03-31 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312716#comment-17312716 ] John Roesler commented on KAFKA-12593: -- Thanks for the reminder, Sophie. I had forgotten to look in

[GitHub] [kafka] kowshik commented on pull request #10454: MINOR: Rename LogUtils class in tests to LogTestUtils

2021-03-31 Thread GitBox
kowshik commented on pull request #10454: URL: https://github.com/apache/kafka/pull/10454#issuecomment-811472106 cc @junrao @dhruvilshah3 -- this PR is ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] kowshik opened a new pull request #10454: MINOR: Rename LogUtils class in tests to LogTestUtils

2021-03-31 Thread GitBox
kowshik opened a new pull request #10454: URL: https://github.com/apache/kafka/pull/10454 This PR is a precursor to the recovery logic refactor work (KAFKA-12553). I've renamed the file: `core/src/test/scala/unit/kafka/log/LogUtils.scala` to

[GitHub] [kafka] mumrah commented on a change in pull request #10085: KAFKA-12154: Snapshot Loading API

2021-03-31 Thread GitBox
mumrah commented on a change in pull request #10085: URL: https://github.com/apache/kafka/pull/10085#discussion_r605171450 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -326,6 +336,14 @@ private void updateListenersProgress(List

[GitHub] [kafka] ewencp commented on a change in pull request #10452: KAFKA-12593: Fix header in streams-scala

2021-03-31 Thread GitBox
ewencp commented on a change in pull request #10452: URL: https://github.com/apache/kafka/pull/10452#discussion_r605201263 ## File path: streams/streams-scala/NOTICE ## @@ -1,3 +0,0 @@ -Kafka Streams Scala -Copyright (C) 2018 Lightbend Inc.

[GitHub] [kafka] ewencp commented on a change in pull request #10452: KAFKA-12593: Fix header in streams-scala

2021-03-31 Thread GitBox
ewencp commented on a change in pull request #10452: URL: https://github.com/apache/kafka/pull/10452#discussion_r605200916 ## File path: NOTICE ## @@ -10,3 +10,7 @@ License. The source code of jersey can be found at https://github.com/jersey/jer This distribution has a

[GitHub] [kafka] jolshan commented on a change in pull request #10282: KAFKA-12426: Missing logic to create partition.metadata files in RaftReplicaManager

2021-03-31 Thread GitBox
jolshan commented on a change in pull request #10282: URL: https://github.com/apache/kafka/pull/10282#discussion_r605182627 ## File path: core/src/test/scala/unit/kafka/cluster/PartitionTest.scala ## @@ -1633,10 +1633,102 @@ class PartitionTest extends AbstractPartitionTest {

[GitHub] [kafka] jolshan commented on a change in pull request #10282: KAFKA-12426: Missing logic to create partition.metadata files in RaftReplicaManager

2021-03-31 Thread GitBox
jolshan commented on a change in pull request #10282: URL: https://github.com/apache/kafka/pull/10282#discussion_r605172888 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -262,6 +266,7 @@ class Log(@volatile private var _dir: File, val

[GitHub] [kafka] jsancio commented on a change in pull request #10085: KAFKA-12154: Snapshot Loading API

2021-03-31 Thread GitBox
jsancio commented on a change in pull request #10085: URL: https://github.com/apache/kafka/pull/10085#discussion_r605167349 ## File path: raft/src/main/java/org/apache/kafka/raft/BatchReader.java ## @@ -60,19 +61,21 @@ @Override void close(); -class Batch { +

[GitHub] [kafka] ableegoldman commented on pull request #10411: KAFKA-7606: Remove deprecated options from StreamsResetter

2021-03-31 Thread GitBox
ableegoldman commented on pull request #10411: URL: https://github.com/apache/kafka/pull/10411#issuecomment-811364280 Unrelated test failure: `streams.integration.StoreQueryIntegrationTest.shouldQuerySpecificActivePartitionStores` -- This is an automated message from the Apache Git

[GitHub] [kafka] omkreddy edited a comment on pull request #10450: KAFKA-12590: Remove deprecated kafka.security.auth.Authorizer, SimpleAclAuthorizer and related classes

2021-03-31 Thread GitBox
omkreddy edited a comment on pull request #10450: URL: https://github.com/apache/kafka/pull/10450#issuecomment-811147963 Sentry project has retired. so no issues i think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] JimGalasyn opened a new pull request #10453: DOCS-7223: Fix left/outer join descriptions in Streams DSL reference topic

2021-03-31 Thread GitBox
JimGalasyn opened a new pull request #10453: URL: https://github.com/apache/kafka/pull/10453 Fixes descriptions of tombstone semantics in KTable-KTable joins, per Slack

[GitHub] [kafka] jolshan commented on a change in pull request #10282: KAFKA-12426: Missing logic to create partition.metadata files in RaftReplicaManager

2021-03-31 Thread GitBox
jolshan commented on a change in pull request #10282: URL: https://github.com/apache/kafka/pull/10282#discussion_r605144053 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -262,6 +266,7 @@ class Log(@volatile private var _dir: File, val

[GitHub] [kafka] jolshan commented on a change in pull request #10282: KAFKA-12426: Missing logic to create partition.metadata files in RaftReplicaManager

2021-03-31 Thread GitBox
jolshan commented on a change in pull request #10282: URL: https://github.com/apache/kafka/pull/10282#discussion_r605143191 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -775,9 +776,10 @@ class LogManager(logDirs: Seq[File], * @param topicPartition The

[GitHub] [kafka] jolshan commented on a change in pull request #10282: KAFKA-12426: Missing logic to create partition.metadata files in RaftReplicaManager

2021-03-31 Thread GitBox
jolshan commented on a change in pull request #10282: URL: https://github.com/apache/kafka/pull/10282#discussion_r605142418 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -1892,8 +1892,9 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog:

[GitHub] [kafka] vvcephei commented on a change in pull request #10452: KAFKA-12593: Fix header in streams-scala

2021-03-31 Thread GitBox
vvcephei commented on a change in pull request #10452: URL: https://github.com/apache/kafka/pull/10452#discussion_r605140307 ## File path: build.gradle ## @@ -46,6 +46,7 @@ spotless { scala { target 'streams/**/*.scala'

[GitHub] [kafka] vvcephei commented on pull request #10452: KAFKA-12593: Fix header in streams-scala

2021-03-31 Thread GitBox
vvcephei commented on pull request #10452: URL: https://github.com/apache/kafka/pull/10452#issuecomment-811337897 Hey @debasishg and @seglo , I hope you've been well. Since you were the original contributors of the streams-scala module

[jira] [Resolved] (KAFKA-8405) Remove deprecated `kafka-preferred-replica-election` command

2021-03-31 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-8405. Reviewer: Ismael Juma Resolution: Fixed > Remove deprecated

[jira] [Updated] (KAFKA-8405) Remove deprecated `kafka-preferred-replica-election` command

2021-03-31 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-8405: --- Summary: Remove deprecated `kafka-preferred-replica-election` command (was: Remove deprecated

[jira] [Assigned] (KAFKA-8405) Remove deprecated preferred leader RPC and Command

2021-03-31 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot reassigned KAFKA-8405: -- Assignee: David Jacot > Remove deprecated preferred leader RPC and Command >

[GitHub] [kafka] dajac merged pull request #10443: KAFKA-8405; Remove deprecated `kafka-preferred-replica-election` command

2021-03-31 Thread GitBox
dajac merged pull request #10443: URL: https://github.com/apache/kafka/pull/10443 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] dajac commented on pull request #10443: KAFKA-8405; Remove deprecated `kafka-preferred-replica-election` command

2021-03-31 Thread GitBox
dajac commented on pull request #10443: URL: https://github.com/apache/kafka/pull/10443#issuecomment-811333762 Failed tests are not related. Merging it to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] hachikuji commented on a change in pull request #10282: KAFKA-12426: Missing logic to create partition.metadata files in RaftReplicaManager

2021-03-31 Thread GitBox
hachikuji commented on a change in pull request #10282: URL: https://github.com/apache/kafka/pull/10282#discussion_r605134985 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -262,6 +266,7 @@ class Log(@volatile private var _dir: File, val

[jira] [Commented] (KAFKA-12593) The Streams-Scala contains the wrong license header

2021-03-31 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312614#comment-17312614 ] A. Sophie Blee-Goldman commented on KAFKA-12593: Hey [~vvcephei], thanks for the PR --

[jira] [Commented] (KAFKA-12593) The Streams-Scala contains the wrong license header

2021-03-31 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312609#comment-17312609 ] John Roesler commented on KAFKA-12593: -- Hi [~jmclean] , I don't know if you will get pinged by

[GitHub] [kafka] hachikuji commented on a change in pull request #10282: KAFKA-12426: Missing logic to create partition.metadata files in RaftReplicaManager

2021-03-31 Thread GitBox
hachikuji commented on a change in pull request #10282: URL: https://github.com/apache/kafka/pull/10282#discussion_r605109950 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -341,9 +341,13 @@ class Partition(val topicPartition: TopicPartition,

[GitHub] [kafka] vvcephei opened a new pull request #10452: KAFKA-12593: Fix header in streams-scala

2021-03-31 Thread GitBox
vvcephei opened a new pull request #10452: URL: https://github.com/apache/kafka/pull/10452 The current headers in the streams-scala module differ from the required headers for this project. * add a header style check for scala files * apply the correct header * move the

[jira] [Created] (KAFKA-12593) The Streams-Scala contains the wrong license header

2021-03-31 Thread John Roesler (Jira)
John Roesler created KAFKA-12593: Summary: The Streams-Scala contains the wrong license header Key: KAFKA-12593 URL: https://issues.apache.org/jira/browse/KAFKA-12593 Project: Kafka Issue

[jira] [Commented] (KAFKA-9897) Flaky Test StoreQueryIntegrationTest#shouldQuerySpecificActivePartitionStores

2021-03-31 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312590#comment-17312590 ] A. Sophie Blee-Goldman commented on KAFKA-9897: --- Failed again: {code:java}

[jira] [Reopened] (KAFKA-9897) Flaky Test StoreQueryIntegrationTest#shouldQuerySpecificActivePartitionStores

2021-03-31 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reopened KAFKA-9897: --- > Flaky Test StoreQueryIntegrationTest#shouldQuerySpecificActivePartitionStores

[GitHub] [kafka] ableegoldman merged pull request #10449: MINOR: Fix docs for end-to-end record latency metrics

2021-03-31 Thread GitBox
ableegoldman merged pull request #10449: URL: https://github.com/apache/kafka/pull/10449 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] ableegoldman commented on pull request #10449: MINOR: Fix docs for end-to-end record latency metrics

2021-03-31 Thread GitBox
ableegoldman commented on pull request #10449: URL: https://github.com/apache/kafka/pull/10449#issuecomment-811294592 Unrelated failures in `kafka.server.RaftClusterTest` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] ableegoldman commented on a change in pull request #10449: MINOR: Fix docs for end-to-end record latency metrics

2021-03-31 Thread GitBox
ableegoldman commented on a change in pull request #10449: URL: https://github.com/apache/kafka/pull/10449#discussion_r605109431 ## File path: docs/ops.html ## @@ -2586,7 +2574,22 @@

[GitHub] [kafka] hachikuji commented on a change in pull request #10142: KAFKA-12294: forward auto topic request within envelope on behalf of clients

2021-03-31 Thread GitBox
hachikuji commented on a change in pull request #10142: URL: https://github.com/apache/kafka/pull/10142#discussion_r605099066 ## File path: core/src/main/scala/kafka/server/AutoTopicCreationManager.scala ## @@ -166,7 +179,32 @@ class DefaultAutoTopicCreationManager(

[GitHub] [kafka] guozhangwang commented on pull request #10331: KAFKA-10847: Add a RocksDBTimeOrderedWindowStore to hold records using their timestamp as key prefix

2021-03-31 Thread GitBox
guozhangwang commented on pull request #10331: URL: https://github.com/apache/kafka/pull/10331#issuecomment-811288141 > @guozhangwang I just replace this PR with only the changes for the `RocksDBTimeOrderedWindowStore`. I will create other PRs with your suggestions. I will continue

[GitHub] [kafka] junrao merged pull request #10424: MINOR Replaced File with Path in LogSegmentData.

2021-03-31 Thread GitBox
junrao merged pull request #10424: URL: https://github.com/apache/kafka/pull/10424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] kowshik commented on pull request #10430: KAFKA-12575: Eliminate Log.isLogDirOffline boolean attribute

2021-03-31 Thread GitBox
kowshik commented on pull request #10430: URL: https://github.com/apache/kafka/pull/10430#issuecomment-811278507 @junrao @dhruvilshah3 @hachikuji the Jenkins tests have finished and the failed ones are not related to this PR. -- This is an automated message from the Apache Git Service.

[jira] [Commented] (KAFKA-12574) Deprecate eos-alpha

2021-03-31 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312563#comment-17312563 ] A. Sophie Blee-Goldman commented on KAFKA-12574: I think maybe we weren't yet confident

[jira] [Commented] (KAFKA-12453) Guidance on whether a topology is eligible for optimisation

2021-03-31 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312523#comment-17312523 ] Matthias J. Sax commented on KAFKA-12453: - {quote}Are we saying that its safe to enable topology

[GitHub] [kafka] omkreddy edited a comment on pull request #10450: KAFKA-12590: Remove deprecated kafka.security.auth.Authorizer, SimpleAclAuthorizer and related classes

2021-03-31 Thread GitBox
omkreddy edited a comment on pull request #10450: URL: https://github.com/apache/kafka/pull/10450#issuecomment-811147963 Sentry project is retired. so no issues i think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] vvcephei commented on pull request #10381: KAFKA-8410: Migrating KStream Stateless operators to new Processor API

2021-03-31 Thread GitBox
vvcephei commented on pull request #10381: URL: https://github.com/apache/kafka/pull/10381#issuecomment-811191968 Looks like the builds failed due to a checkstyle problem. FYI, you can run `./gradlew :streams:testAll` to run all the tests in all the Streams modules, as well as

[GitHub] [kafka] dajac commented on a change in pull request #10443: KAFKA-8405; Remove deprecated `kafka-preferred-replica-election` command

2021-03-31 Thread GitBox
dajac commented on a change in pull request #10443: URL: https://github.com/apache/kafka/pull/10443#discussion_r605010766 ## File path: docs/upgrade.html ## @@ -34,6 +34,7 @@ Notable changes in 3 The deprecated Admin.electedPreferredLeaders() methods were removed. Please

[GitHub] [kafka] ijuma merged pull request #10448: KAFKA-12583: Upgrade netty to 4.1.62.Final

2021-03-31 Thread GitBox
ijuma merged pull request #10448: URL: https://github.com/apache/kafka/pull/10448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] ijuma commented on pull request #10448: KAFKA-12583: Upgrade netty to 4.1.62.Final

2021-03-31 Thread GitBox
ijuma commented on pull request #10448: URL: https://github.com/apache/kafka/pull/10448#issuecomment-811169061 This doesn't affect our project since we don't use http2, still good to merge the upgrade. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] kowshik edited a comment on pull request #10280: KAFKA-12554: Refactor Log layer

2021-03-31 Thread GitBox
kowshik edited a comment on pull request #10280: URL: https://github.com/apache/kafka/pull/10280#issuecomment-808514958 @junrao Just a heads up on the following. I'm working on the changes for the following in separate PRs, these are related with refactoring the recovery logic

[GitHub] [kafka] omkreddy commented on pull request #10450: KAFKA-12590: Remove deprecated kafka.security.auth.Authorizer, SimpleAclAuthorizer and related classes

2021-03-31 Thread GitBox
omkreddy commented on pull request #10450: URL: https://github.com/apache/kafka/pull/10450#issuecomment-811147963 Sentry project is retired. so no worries i think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] ijuma commented on pull request #10450: KAFKA-12590: Remove deprecated kafka.security.auth.Authorizer, SimpleAclAuthorizer and related classes

2021-03-31 Thread GitBox
ijuma commented on pull request #10450: URL: https://github.com/apache/kafka/pull/10450#issuecomment-811142442 @omkreddy Thanks. Maybe we can file a JIRA. Their code would probably be quite a bit simpler by not having to deal with the Scala conversions. -- This is an automated message

[GitHub] [kafka] omkreddy commented on pull request #10450: KAFKA-12590: Remove deprecated kafka.security.auth.Authorizer, SimpleAclAuthorizer and related classes

2021-03-31 Thread GitBox
omkreddy commented on pull request #10450: URL: https://github.com/apache/kafka/pull/10450#issuecomment-811139340 looks like [Apache Ranger](https://github.com/apache/ranger/blob/master/plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java)

[GitHub] [kafka] ijuma commented on pull request #10450: KAFKA-12590: Remove deprecated kafka.security.auth.Authorizer, SimpleAclAuthorizer and related classes

2021-03-31 Thread GitBox
ijuma commented on pull request #10450: URL: https://github.com/apache/kafka/pull/10450#issuecomment-811142776 Also, did Sentry migrate? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Resolved] (KAFKA-12589) There are insufficient bytes available to read assignment from the sync-group response (actual byte size 0) , this is not expected;

2021-03-31 Thread Guido Raimondi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guido Raimondi resolved KAFKA-12589. Resolution: Not A Problem I discovered that the problem is due to my mistake. sorry >

[GitHub] [kafka] ijuma commented on pull request #10451: KAFKA-12952: Remove deprecated LogConfig.Compact

2021-03-31 Thread GitBox
ijuma commented on pull request #10451: URL: https://github.com/apache/kafka/pull/10451#issuecomment-811093222 I didn't add a release note since this is technically not public API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] ijuma opened a new pull request #10451: KAFKA-12952: Remove deprecated LogConfig.Compact

2021-03-31 Thread GitBox
ijuma opened a new pull request #10451: URL: https://github.com/apache/kafka/pull/10451 Deprecated since 1.0.0 for misleading name. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status -

[jira] [Created] (KAFKA-12592) Remove deprecated LogConfig.Compact

2021-03-31 Thread Ismael Juma (Jira)
Ismael Juma created KAFKA-12592: --- Summary: Remove deprecated LogConfig.Compact Key: KAFKA-12592 URL: https://issues.apache.org/jira/browse/KAFKA-12592 Project: Kafka Issue Type: Task

[GitHub] [kafka] ijuma commented on pull request #10450: KAFKA-12590: Remove deprecated kafka.security.auth.Authorizer, SimpleAclAuthorizer and related classes

2021-03-31 Thread GitBox
ijuma commented on pull request #10450: URL: https://github.com/apache/kafka/pull/10450#issuecomment-811090385 @rajinisivaram @omkreddy Thoughts on this? Do you know if third-party implementations have migrated to the new interface? -- This is an automated message from the Apache Git

[GitHub] [kafka] ijuma opened a new pull request #10450: KAFKA-12590: Remove deprecated SimpleAclAuthorizer and related classes

2021-03-31 Thread GitBox
ijuma opened a new pull request #10450: URL: https://github.com/apache/kafka/pull/10450 `SimpleAclAuthorizer` was deprecated in Apache Kafka 2.4 (released in December 2019). `AclAuthorizer` is its replacement. Details on the issues affecting the old Authorizer interface can be

[jira] [Commented] (KAFKA-12574) Deprecate eos-alpha

2021-03-31 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312389#comment-17312389 ] Ismael Juma commented on KAFKA-12574: - To clarify my last comment, I think it would have been less

[jira] [Commented] (KAFKA-12577) Remove deprecated `ConfigEntry` constructor

2021-03-31 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312371#comment-17312371 ] David Jacot commented on KAFKA-12577: - Good idea. Done. > Remove deprecated `ConfigEntry`

[jira] [Resolved] (KAFKA-12582) Remove deprecated `ConfigEntry` constructor

2021-03-31 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-12582. - Resolution: Duplicate > Remove deprecated `ConfigEntry` constructor >

[jira] [Reopened] (KAFKA-12582) Remove deprecated `ConfigEntry` constructor

2021-03-31 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot reopened KAFKA-12582: - > Remove deprecated `ConfigEntry` constructor > --- > >

[jira] [Updated] (KAFKA-12577) Remove deprecated `ConfigEntry` constructor

2021-03-31 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-12577: Description: ConfigEntry's constructor was deprecated in 1.1.0. (was: `quota.producer.default`

[jira] [Assigned] (KAFKA-10538) Convert KStreamImpl maps to new PAPI

2021-03-31 Thread Jorge Esteban Quilcate Otoya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jorge Esteban Quilcate Otoya reassigned KAFKA-10538: Assignee: Jorge Esteban Quilcate Otoya (was: John

[jira] [Updated] (KAFKA-12577) Remove deprecated `ConfigEntry` constructor

2021-03-31 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-12577: Summary: Remove deprecated `ConfigEntry` constructor (was: Remove deprecated

[jira] [Assigned] (KAFKA-10537) Convert KStreamImpl filters to new PAPI

2021-03-31 Thread Jorge Esteban Quilcate Otoya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jorge Esteban Quilcate Otoya reassigned KAFKA-10537: Assignee: Jorge Esteban Quilcate Otoya (was: John

[jira] [Created] (KAFKA-12591) Remove deprecated `quota.producer.default` and `quota.consumer.default` configurations

2021-03-31 Thread David Jacot (Jira)
David Jacot created KAFKA-12591: --- Summary: Remove deprecated `quota.producer.default` and `quota.consumer.default` configurations Key: KAFKA-12591 URL: https://issues.apache.org/jira/browse/KAFKA-12591

[jira] [Commented] (KAFKA-12577) Remove deprecated `quota.producer.default` and `quota.consumer.default` configurations

2021-03-31 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312367#comment-17312367 ] Ismael Juma commented on KAFKA-12577: - Since the other PR is not merged, you could change this Jira

[jira] [Created] (KAFKA-12590) Remove deprecated SimpleAclAuthorizer

2021-03-31 Thread Ismael Juma (Jira)
Ismael Juma created KAFKA-12590: --- Summary: Remove deprecated SimpleAclAuthorizer Key: KAFKA-12590 URL: https://issues.apache.org/jira/browse/KAFKA-12590 Project: Kafka Issue Type: Task

[jira] [Resolved] (KAFKA-12582) Remove deprecated `ConfigEntry` constructor

2021-03-31 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-12582. - Fix Version/s: 3.0.0 Resolution: Fixed > Remove deprecated `ConfigEntry` constructor >

[jira] [Commented] (KAFKA-12582) Remove deprecated `ConfigEntry` constructor

2021-03-31 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312349#comment-17312349 ] David Jacot commented on KAFKA-12582: - This was addressed by

[jira] [Commented] (KAFKA-12577) Remove deprecated `quota.producer.default` and `quota.consumer.default` configurations

2021-03-31 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312347#comment-17312347 ] David Jacot commented on KAFKA-12577: - [~ijuma] Good catch! It seems that I mixed up the Jiras :(.

[GitHub] [kafka] cadonna commented on a change in pull request #10449: MINOR: Fix docs for end-to-end record latency metrics

2021-03-31 Thread GitBox
cadonna commented on a change in pull request #10449: URL: https://github.com/apache/kafka/pull/10449#discussion_r604861687 ## File path: docs/ops.html ## @@ -2586,7 +2574,22 @@

[jira] [Updated] (KAFKA-12588) Remove deprecated --zookeeper in shell commands

2021-03-31 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-12588: Fix Version/s: 3.0.0 > Remove deprecated --zookeeper in shell commands >

[jira] [Commented] (KAFKA-12577) Remove deprecated `quota.producer.default` and `quota.consumer.default` configurations

2021-03-31 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312323#comment-17312323 ] Ismael Juma commented on KAFKA-12577: - [~dajac] Looks like the closed PR should not have been

[jira] [Reopened] (KAFKA-12577) Remove deprecated `quota.producer.default` and `quota.consumer.default` configurations

2021-03-31 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma reopened KAFKA-12577: - > Remove deprecated `quota.producer.default` and `quota.consumer.default` > configurations >

[GitHub] [kafka] cadonna opened a new pull request #10449: MINOR: Fix docs for end-to-end record latency metrics

2021-03-31 Thread GitBox
cadonna opened a new pull request #10449: URL: https://github.com/apache/kafka/pull/10449 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade

[GitHub] [kafka] ijuma commented on a change in pull request #10443: KAFKA-8405; Remove deprecated `kafka-preferred-replica-election` command

2021-03-31 Thread GitBox
ijuma commented on a change in pull request #10443: URL: https://github.com/apache/kafka/pull/10443#discussion_r604859584 ## File path: docs/upgrade.html ## @@ -34,6 +34,7 @@ Notable changes in 3 The deprecated Admin.electedPreferredLeaders() methods were removed. Please

[GitHub] [kafka] ijuma commented on pull request #10443: KAFKA-8405; Remove deprecated `kafka-preferred-replica-election` command

2021-03-31 Thread GitBox
ijuma commented on pull request #10443: URL: https://github.com/apache/kafka/pull/10443#issuecomment-811035284 Thinking about it, people would have to adjust to using the script with bootstrap-server and that was introduced much later, so I'm fine with removing. -- This is an automated

[jira] [Resolved] (KAFKA-12533) Migrate KStream stateless operators to new Processor API

2021-03-31 Thread Jorge Esteban Quilcate Otoya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jorge Esteban Quilcate Otoya resolved KAFKA-12533. -- Resolution: Duplicate > Migrate KStream stateless operators

[GitHub] [kafka] dajac commented on a change in pull request #10446: MINOR: [ConfigEntry.class] add 'type' to 'toString' and 'hashCode'

2021-03-31 Thread GitBox
dajac commented on a change in pull request #10446: URL: https://github.com/apache/kafka/pull/10446#discussion_r604843035 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/ConfigEntry.java ## @@ -188,6 +188,7 @@ public int hashCode() { result = prime

  1   2   >