kowshik edited a comment on pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#issuecomment-808514958
@junrao Just a heads up on the following. I'm working on the changes for the
following in separate PRs, these are related with refactoring the recovery
logic (KAFKA-12553
showuon commented on a change in pull request #10591:
URL: https://github.com/apache/kafka/pull/10591#discussion_r620956779
##
File path: docs/ops.html
##
@@ -78,7 +78,7 @@
auto.leader.rebalance.enable=true
You can also set this to false, but you will then need to m
satishd commented on a change in pull request #10271:
URL: https://github.com/apache/kafka/pull/10271#discussion_r620996380
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java
##
@@ -0,0 +1,103 @@
+/
dajac commented on a change in pull request #10599:
URL: https://github.com/apache/kafka/pull/10599#discussion_r620974574
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/AbortTransactionResult.java
##
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software
daehokimm commented on pull request #9259:
URL: https://github.com/apache/kafka/pull/9259#issuecomment-827442242
please review this :) 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
satishd commented on a change in pull request #10271:
URL: https://github.com/apache/kafka/pull/10271#discussion_r621028610
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java
##
@@ -0,0 +1,103 @@
+/
vitojeng commented on pull request #10597:
URL: https://github.com/apache/kafka/pull/10597#issuecomment-827475511
@ableegoldman Please take a look. :)
If all work in this PR is completed, I will update the KIP and discussion
thread.
--
This is an automated message from the Apache Git
chia7712 commented on pull request #10592:
URL: https://github.com/apache/kafka/pull/10592#issuecomment-827477372
@dengziming nice find and thanks for your patch. Those files are noisy to me
:(
--
This is an automated message from the Apache Git Service.
To respond to the message, please
chia7712 commented on pull request #10446:
URL: https://github.com/apache/kafka/pull/10446#issuecomment-827478300
```
Build / JDK 8 and Scala 2.12 /
org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest.testOneWayReplicationWithAutoOffsetSync()
Build / JDK 11
Nathan22177 commented on a change in pull request #10548:
URL: https://github.com/apache/kafka/pull/10548#discussion_r621061574
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java
##
@@ -234,13 +247,15 @@ public V delete(final
Nathan22177 commented on a change in pull request #10548:
URL: https://github.com/apache/kafka/pull/10548#discussion_r621063125
##
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/MeteredSessionStoreTest.java
##
@@ -472,11 +472,26 @@ public void should
Bui Thanh MInh created KAFKA-12719:
--
Summary: Kafka MirrorMaker 2 can only mirror in one direction in
Active/Active config
Key: KAFKA-12719
URL: https://issues.apache.org/jira/browse/KAFKA-12719
Proj
[
https://issues.apache.org/jira/browse/KAFKA-12719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bui Thanh MInh updated KAFKA-12719:
---
Description:
Config:
_clusters = DC1, DC2_
_NPS.bootstrap.servers = _
_NTL.bootstrap.server
[
https://issues.apache.org/jira/browse/KAFKA-12719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bui Thanh MInh updated KAFKA-12719:
---
Description:
Config:
```
clusters = DC1, DC2
NPS.bootstrap.servers =
NTL.bootstrap.server
satishd commented on a change in pull request #10271:
URL: https://github.com/apache/kafka/pull/10271#discussion_r620996380
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java
##
@@ -0,0 +1,103 @@
+/
dengziming commented on pull request #10598:
URL: https://github.com/apache/kafka/pull/10598#issuecomment-827554412
@showuon Thank you, I also think it's not reasonable to fix it here since
there are also some other occurrence, so I revert the JMap change.
--
This is an automated message
chia7712 commented on a change in pull request #10547:
URL: https://github.com/apache/kafka/pull/10547#discussion_r621167591
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedKafkaCluster.java
##
@@ -337,18 +337,28 @@ public void create
showuon commented on a change in pull request #10547:
URL: https://github.com/apache/kafka/pull/10547#discussion_r621231344
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedKafkaCluster.java
##
@@ -337,18 +337,28 @@ public void createT
Mia-jeong opened a new pull request #10600:
URL: https://github.com/apache/kafka/pull/10600
I think that Util classes are intended for using the static method without
instantiating the class.
So in order to be clear, I add abstract keywords to some Util classes which
have no private con
[
https://issues.apache.org/jira/browse/KAFKA-12719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bui Thanh MInh resolved KAFKA-12719.
Resolution: Auto Closed
Need to restart all mm2 instances
> Kafka MirrorMaker 2 can only
Mia-jeong closed pull request #10600:
URL: https://github.com/apache/kafka/pull/10600
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, plea
satishd commented on pull request #10271:
URL: https://github.com/apache/kafka/pull/10271#issuecomment-827691407
@junrao Thanks for the review comments. Addressed them with the commit
https://github.com/apache/kafka/pull/10271/commits/44cb1f374701cc6eca5d1df19dc9cd7c14497b3e
--
This is a
junrao commented on a change in pull request #10271:
URL: https://github.com/apache/kafka/pull/10271#discussion_r621418419
##
File path:
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataSerdeTest.java
##
@@ -0,0 +1,111 @@
+/*
+ * Licen
ableegoldman commented on a change in pull request #10597:
URL: https://github.com/apache/kafka/pull/10597#discussion_r621436955
##
File path: docs/streams/upgrade-guide.html
##
@@ -94,7 +94,14 @@ Upgrade Guide and API Changes
Streams API changes in 3.0.0
-
satishd commented on a change in pull request #10271:
URL: https://github.com/apache/kafka/pull/10271#discussion_r621474682
##
File path:
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataSerdeTest.java
##
@@ -0,0 +1,111 @@
+/*
+ * Lice
yeralin commented on a change in pull request #6592:
URL: https://github.com/apache/kafka/pull/6592#discussion_r621475071
##
File path:
clients/src/main/java/org/apache/kafka/common/serialization/ListSerializer.java
##
@@ -77,21 +87,39 @@ public void configure(Map configs, boo
hachikuji commented on a change in pull request #10599:
URL: https://github.com/apache/kafka/pull/10599#discussion_r621477651
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/AbortTransactionSpec.java
##
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Softwar
satishd commented on pull request #10271:
URL: https://github.com/apache/kafka/pull/10271#issuecomment-827811882
Thanks @junrao for the comments. Fixed checkstyle in raft module and added a
comment in `RemoteLogMetadataSerde`.
--
This is an automated message from the Apache Git Service
hachikuji commented on a change in pull request #10599:
URL: https://github.com/apache/kafka/pull/10599#discussion_r621484136
##
File path:
clients/src/test/java/org/apache/kafka/clients/admin/internals/AbortTransactionHandlerTest.java
##
@@ -0,0 +1,215 @@
+/*
+ * Licensed to
hachikuji commented on a change in pull request #10599:
URL: https://github.com/apache/kafka/pull/10599#discussion_r621503064
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/AbortTransactionResult.java
##
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Softw
dejan2609 commented on a change in pull request #10466:
URL: https://github.com/apache/kafka/pull/10466#discussion_r621504000
##
File path: build.gradle
##
@@ -1491,13 +1491,14 @@ project(':streams') {
}
tasks.create(name: "copyDependantLibs", type: Copy) {
-from (c
Philippe Cloutier created KAFKA-12720:
-
Summary: Ecosystem wiki page: Kafka Manager renamed CMAK (Cluster
Manager for Apache Kafka)
Key: KAFKA-12720
URL: https://issues.apache.org/jira/browse/KAFKA-12720
dejan2609 commented on pull request #10466:
URL: https://github.com/apache/kafka/pull/10466#issuecomment-827844379
@ijuma previous commits are rebased/squashed and PR branch is force-pushed.
Overall: Gradle build looks ok (on my loptop, that is). Some warnings do
appear (related to s
jeqo commented on pull request #10294:
URL: https://github.com/apache/kafka/pull/10294#issuecomment-827844833
@guozhangwang, it should be ready for review now. thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
ijuma commented on pull request #10466:
URL: https://github.com/apache/kafka/pull/10466#issuecomment-827846345
Can you remove the Gradle version bump from this PR then? We can merge the
other change and see if there's any impact. We can then go straight to Gradle
7.0.1 once it's released.
dejan2609 commented on pull request #10466:
URL: https://github.com/apache/kafka/pull/10466#issuecomment-827849319
Sure, let go step-by-step then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dejan2609 commented on pull request #10466:
URL: https://github.com/apache/kafka/pull/10466#issuecomment-827855369
Done, changes are trimmed down.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
JoelWee commented on a change in pull request #8923:
URL: https://github.com/apache/kafka/pull/8923#discussion_r621537903
##
File path: docs/streams/developer-guide/app-reset-tool.html
##
@@ -78,6 +78,9 @@
Step 1: Run the application reset tool
Invoke
JoelWee commented on a change in pull request #8923:
URL: https://github.com/apache/kafka/pull/8923#discussion_r621538528
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AbstractResetIntegrationTest.java
##
@@ -205,6 +206,34 @@ private void add10InputE
JoelWee commented on a change in pull request #8923:
URL: https://github.com/apache/kafka/pull/8923#discussion_r621542393
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/ResetIntegrationTest.java
##
@@ -151,6 +151,22 @@ public void
shouldNotAllowToRes
hachikuji commented on a change in pull request #10599:
URL: https://github.com/apache/kafka/pull/10599#discussion_r621576098
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/AbortTransactionResult.java
##
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Softw
hachikuji commented on a change in pull request #10599:
URL: https://github.com/apache/kafka/pull/10599#discussion_r621576098
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/AbortTransactionResult.java
##
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Softw
gharris1727 commented on a change in pull request #10475:
URL: https://github.com/apache/kafka/pull/10475#discussion_r621586391
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/TestPlugins.java
##
@@ -98,22 +97,56 @@
* to load intern
[
https://issues.apache.org/jira/browse/KAFKA-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman resolved KAFKA-6435.
---
Resolution: Fixed
> Application Reset Tool might delete incorrect internal to
[
https://issues.apache.org/jira/browse/KAFKA-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-6435:
--
Fix Version/s: 3.0.0
> Application Reset Tool might delete incorrect internal t
A. Sophie Blee-Goldman created KAFKA-12721:
--
Summary: Flaky Test
ResetConsumerGroupOffsetTest.testResetOffsetsAllTopicsAllGroups
Key: KAFKA-12721
URL: https://issues.apache.org/jira/browse/KAFKA-12721
[
https://issues.apache.org/jira/browse/KAFKA-12666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman resolved KAFKA-12666.
Resolution: Duplicate
> Fix flaky
> kafka.server.RaftClusterTest.testCrea
[
https://issues.apache.org/jira/browse/KAFKA-12629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17334174#comment-17334174
]
A. Sophie Blee-Goldman commented on KAFKA-12629:
I'm seeing a lot of tha
Kowshik Prakasam created KAFKA-12722:
Summary: Evaluate moving replaceSegments into LogSegments class
Key: KAFKA-12722
URL: https://issues.apache.org/jira/browse/KAFKA-12722
Project: Kafka
ableegoldman commented on a change in pull request #8923:
URL: https://github.com/apache/kafka/pull/8923#discussion_r621665639
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/ResetIntegrationTest.java
##
@@ -151,6 +151,22 @@ public void
shouldNotAllow
hachikuji commented on a change in pull request #10480:
URL: https://github.com/apache/kafka/pull/10480#discussion_r621603737
##
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##
@@ -2235,6 +2199,7 @@ private Long append(int epoch, List records, boolea
ableegoldman commented on pull request #8923:
URL: https://github.com/apache/kafka/pull/8923#issuecomment-827995691
Oof, there are a LOT of flaky test failures in this build. They're all
unrelated to this PR, mostly in Connect and the RaftClusterTest, so I'll go
ahead and merge, but yikes.
junrao commented on a change in pull request #10564:
URL: https://github.com/apache/kafka/pull/10564#discussion_r621652737
##
File path:
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java
##
@@ -1119,6 +1057,83 @@ void validateManualPartitionAssi
ableegoldman commented on a change in pull request #10509:
URL: https://github.com/apache/kafka/pull/10509#discussion_r621502594
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
##
@@ -163,127 +159,179 @@ private boole
dielhennr commented on a change in pull request #10480:
URL: https://github.com/apache/kafka/pull/10480#discussion_r621630725
##
File path:
raft/src/test/java/org/apache/kafka/raft/internals/BatchAccumulatorTest.java
##
@@ -354,6 +484,7 @@ public void testDrainDoesNotBlockWith
[
https://issues.apache.org/jira/browse/KAFKA-12666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17334205#comment-17334205
]
A. Sophie Blee-Goldman commented on KAFKA-12666:
There are quite a few t
jsancio commented on a change in pull request #10497:
URL: https://github.com/apache/kafka/pull/10497#discussion_r621670833
##
File path:
core/src/test/scala/unit/kafka/server/metadata/BrokerMetadataListenerTest.scala
##
@@ -108,18 +109,29 @@ class BrokerMetadataListenerTest {
cmccabe commented on a change in pull request #10564:
URL: https://github.com/apache/kafka/pull/10564#discussion_r621639045
##
File path:
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java
##
@@ -1119,6 +1057,83 @@ void validateManualPartitionAss
jsancio commented on a change in pull request #10497:
URL: https://github.com/apache/kafka/pull/10497#discussion_r621649450
##
File path: core/src/main/scala/kafka/raft/RaftManager.scala
##
@@ -126,10 +130,10 @@ class KafkaRaftManager[T](
private val dataDir = createDataDir(
ableegoldman commented on a change in pull request #6592:
URL: https://github.com/apache/kafka/pull/6592#discussion_r621676170
##
File path:
clients/src/main/java/org/apache/kafka/common/serialization/ListSerializer.java
##
@@ -77,21 +87,39 @@ public void configure(Map configs
hachikuji commented on a change in pull request #9590:
URL: https://github.com/apache/kafka/pull/9590#discussion_r621734730
##
File path: core/src/test/scala/unit/kafka/log/LogCleanerTest.scala
##
@@ -984,19 +1003,26 @@ class LogCleanerTest {
def distinctValuesBySegment
ableegoldman merged pull request #8923:
URL: https://github.com/apache/kafka/pull/8923
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, ple
hachikuji commented on a change in pull request #9590:
URL: https://github.com/apache/kafka/pull/9590#discussion_r621668165
##
File path:
clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java
##
@@ -340,17 +343,18 @@ private FilterResult(ByteBuffer outputBuff
showuon commented on a change in pull request #10547:
URL: https://github.com/apache/kafka/pull/10547#discussion_r621757453
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedKafkaCluster.java
##
@@ -337,18 +337,28 @@ public void createT
chia7712 commented on a change in pull request #10547:
URL: https://github.com/apache/kafka/pull/10547#discussion_r621784059
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedKafkaCluster.java
##
@@ -337,18 +337,28 @@ public void create
showuon commented on a change in pull request #10547:
URL: https://github.com/apache/kafka/pull/10547#discussion_r621788834
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedKafkaCluster.java
##
@@ -337,18 +337,28 @@ public void createT
vitojeng commented on a change in pull request #10597:
URL: https://github.com/apache/kafka/pull/10597#discussion_r621794196
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -344,7 +345,7 @@ private boolean isRunningOrRebalancing() {
p
showuon commented on pull request #10547:
URL: https://github.com/apache/kafka/pull/10547#issuecomment-828180085
Failed tests are all un-related. (Not in MirrorMakerIntegrationTest)
```
Build / JDK 11 and Scala 2.13 /
kafka.network.ConnectionQuotasTest.testListenerConnectionRateLi
dengziming commented on pull request #10598:
URL: https://github.com/apache/kafka/pull/10598#issuecomment-828185212
> @dengziming nice improvement. LGTM
>
> BTW, line#203
(https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/tools/ConsoleConsumer.scala#L203)
has weir
69 matches
Mail list logo
