showuon commented on a change in pull request #10974:
URL: https://github.com/apache/kafka/pull/10974#discussion_r664276058
##
File path: tools/src/main/java/org/apache/kafka/tools/TransactionsCommand.java
##
@@ -461,6 +471,437 @@ public void execute(Admin admin, Namespace ns,
dengziming commented on a change in pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#discussion_r664306577
##
File path: core/src/main/scala/kafka/api/ApiVersion.scala
##
@@ -116,7 +116,9 @@ object ApiVersion {
// Introduce AllocateProducerIds (KIP-730)
dengziming commented on a change in pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#discussion_r664306898
##
File path: clients/src/main/resources/common/message/MetadataResponse.json
##
@@ -65,7 +66,7 @@
"about": "Each topic in the response.", "fields
dengziming commented on a change in pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#discussion_r664308959
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/MetadataRequest.java
##
@@ -65,6 +65,20 @@ public Builder(List topics, boolean
all
dengziming commented on a change in pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#discussion_r664309847
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/DescribeTopicsResult.java
##
@@ -32,28 +34,87 @@
*/
@InterfaceStability.Evolving
dengziming closed pull request #9662:
URL: https://github.com/apache/kafka/pull/9662
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr
dengziming commented on pull request #9662:
URL: https://github.com/apache/kafka/pull/9662#issuecomment-874535090
We no longer need this since KIP-500 are removing all these code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
YI-CHEN WANG created KAFKA-13036:
Summary: Replace EasyMock and PowerMock with Mockito for
RocksDBMetricsRecorderTest
Key: KAFKA-13036
URL: https://issues.apache.org/jira/browse/KAFKA-13036
Project: K
yws-tracy commented on pull request #10972:
URL: https://github.com/apache/kafka/pull/10972#issuecomment-874559779
it's final so it needs to assign null otherwise compiler can not run
correctly
--
This is an automated message from the Apache Git Service.
To respond to the message, please
wycc opened a new pull request #10976:
URL: https://github.com/apache/kafka/pull/10976
Development of EasyMock and PowerMock has stagnated while Mockito continues
to be actively developed. With the new Java cadence, it's a problem to depend
on libraries that do bytecode generation and
yws-tracy edited a comment on pull request #10972:
URL: https://github.com/apache/kafka/pull/10972#issuecomment-874559779
it's final so it needs to assign null otherwise compiler can not run
correctly, whereas, why this need final? what's the advantages?
--
This is an automated message
showuon commented on a change in pull request #10976:
URL: https://github.com/apache/kafka/pull/10976#discussion_r664368496
##
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/metrics/RocksDBMetricsRecorderTest.java
##
@@ -70,99 +63,91 @@
private
thomaskwscott commented on a change in pull request #10960:
URL: https://github.com/apache/kafka/pull/10960#discussion_r664377980
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -1345,8 +1345,9 @@ class Log(@volatile private var _dir: File,
val latestTimest
wycc commented on a change in pull request #10976:
URL: https://github.com/apache/kafka/pull/10976#discussion_r664391227
##
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/metrics/RocksDBMetricsRecorderTest.java
##
@@ -70,99 +63,91 @@
private
satishd commented on a change in pull request #10579:
URL: https://github.com/apache/kafka/pull/10579#discussion_r664014932
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java
##
@@ -0,0 +1,402 @@
+/*
wuYin opened a new pull request #10977:
URL: https://github.com/apache/kafka/pull/10977
Always use the `hasDefault` method to check if the default value is
specified in `ConfigKey` object
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
dajac commented on a change in pull request #9878:
URL: https://github.com/apache/kafka/pull/9878#discussion_r663902068
##
File path:
clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java
##
@@ -27,217 +28,111 @@
/**
* A flexible future which suppor
chia7712 commented on a change in pull request #9878:
URL: https://github.com/apache/kafka/pull/9878#discussion_r663755587
##
File path:
clients/src/main/java/org/apache/kafka/common/internals/KafkaCompletableFuture.java
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Softw
showuon commented on pull request #10973:
URL: https://github.com/apache/kafka/pull/10973#issuecomment-874065187
@mimaison , thanks for the comments. I've updated the PR. Please take a look
again. Thanks.
Failed tests are unrelated.
```
Build / JDK 8 and Scala 2.12 /
kafka
rajinisivaram commented on pull request #10965:
URL: https://github.com/apache/kafka/pull/10965#issuecomment-874004039
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
dajac commented on a change in pull request #10974:
URL: https://github.com/apache/kafka/pull/10974#discussion_r663770706
##
File path:
tools/src/test/java/org/apache/kafka/tools/TransactionsCommandTest.java
##
@@ -437,6 +442,536 @@ public void
testOldBrokerAbortTransactionWi
rajinisivaram merged pull request #10965:
URL: https://github.com/apache/kafka/pull/10965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-uns
dajac commented on a change in pull request #10955:
URL: https://github.com/apache/kafka/pull/10955#discussion_r663716647
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -3677,7 +3677,8 @@ public ListOffsetsResult listOffsets(Map
rajinisivaram commented on a change in pull request #10962:
URL: https://github.com/apache/kafka/pull/10962#discussion_r663488495
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -1308,29 +1308,31 @@ private OffsetF
ijuma commented on a change in pull request #9878:
URL: https://github.com/apache/kafka/pull/9878#discussion_r663961964
##
File path:
clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java
##
@@ -267,50 +180,82 @@ public T get() throws InterruptedExceptio
tombentley commented on pull request #9878:
URL: https://github.com/apache/kafka/pull/9878#issuecomment-873936999
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
satishd commented on a change in pull request #10579:
URL: https://github.com/apache/kafka/pull/10579#discussion_r663808257
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerManager.java
##
@@ -0,0 +1,130 @@
+/*
+ * Licensed to the
tombentley commented on a change in pull request #9878:
URL: https://github.com/apache/kafka/pull/9878#discussion_r663752257
##
File path:
clients/src/main/java/org/apache/kafka/common/internals/KafkaCompletableFuture.java
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Sof
satishd commented on pull request #10579:
URL: https://github.com/apache/kafka/pull/10579#issuecomment-874000725
Thanks @junrao for your comments. Addressed them with the latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
showuon commented on a change in pull request #10969:
URL: https://github.com/apache/kafka/pull/10969#discussion_r663730489
##
File path: raft/src/main/java/org/apache/kafka/raft/RaftConfig.java
##
@@ -138,14 +139,15 @@ private UnknownAddressSpec() {
}
}
-pu
dajac commented on pull request #10955:
URL: https://github.com/apache/kafka/pull/10955#issuecomment-873889722
@jeffkbkim We could add a `getListOffsetsCalls` method to
`AdminClientTestUtils`, which is in the same package as the `KafkaAdminClient`,
to access the package private method from
dajac commented on a change in pull request #10965:
URL: https://github.com/apache/kafka/pull/10965#discussion_r663739212
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java
##
@@ -1532,9 +1525,10 @@ String coordinatorKey() {
dajac commented on a change in pull request #10960:
URL: https://github.com/apache/kafka/pull/10960#discussion_r663713956
##
File path: core/src/main/scala/kafka/log/LogSegment.scala
##
@@ -99,21 +99,22 @@ class LogSegment private[log] (val log: FileRecords,
// volatile for
thomaskwscott commented on a change in pull request #10960:
URL: https://github.com/apache/kafka/pull/10960#discussion_r663791043
##
File path: core/src/main/scala/kafka/log/LogSegment.scala
##
@@ -99,21 +99,22 @@ class LogSegment private[log] (val log: FileRecords,
// volat
jolshan commented on a change in pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#discussion_r664075804
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/DescribeTopicsResult.java
##
@@ -32,28 +34,87 @@
*/
@InterfaceStability.Evolving
pub
showuon edited a comment on pull request #10973:
URL: https://github.com/apache/kafka/pull/10973#issuecomment-874065187
@mimaison , thanks for the comments. I've updated the
`KafkaAdminClientTest`. Please take a look again. Thanks.
Failed tests are unrelated.
```
Build / JD
dajac commented on pull request #10960:
URL: https://github.com/apache/kafka/pull/10960#issuecomment-874186134
@thomaskwscott Could you also update the description of the PR? It would be
great to explain how it relates to KIP-734 as well.
--
This is an automated message from the Apache
hachikuji commented on a change in pull request #10974:
URL: https://github.com/apache/kafka/pull/10974#discussion_r664154672
##
File path:
tools/src/test/java/org/apache/kafka/tools/TransactionsCommandTest.java
##
@@ -437,6 +442,536 @@ public void
testOldBrokerAbortTransacti
ijuma commented on a change in pull request #10960:
URL: https://github.com/apache/kafka/pull/10960#discussion_r664036719
##
File path: core/src/main/scala/kafka/log/LogSegment.scala
##
@@ -386,15 +385,13 @@ class LogSegment private[log] (val log: FileRecords,
private def lo
tombentley merged pull request #9878:
URL: https://github.com/apache/kafka/pull/9878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr
kpatelatwork commented on pull request #10975:
URL: https://github.com/apache/kafka/pull/10975#issuecomment-874289811
This is how formatting looks locally
--
This is an
showuon commented on a change in pull request #10974:
URL: https://github.com/apache/kafka/pull/10974#discussion_r664276058
##
File path: tools/src/main/java/org/apache/kafka/tools/TransactionsCommand.java
##
@@ -461,6 +471,437 @@ public void execute(Admin admin, Namespace ns,
hachikuji merged pull request #10971:
URL: https://github.com/apache/kafka/pull/10971
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubsc
yws-tracy edited a comment on pull request #10972:
URL: https://github.com/apache/kafka/pull/10972#issuecomment-874559779
it's final so it needs to assign null otherwise compiler can not run
correctly, whereas, why this need final? what's the advantages?
--
This is an automated message
dengziming commented on pull request #9662:
URL: https://github.com/apache/kafka/pull/9662#issuecomment-874535090
We no longer need this since KIP-500 are removing all these code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
dengziming commented on a change in pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#discussion_r664306577
##
File path: core/src/main/scala/kafka/api/ApiVersion.scala
##
@@ -116,7 +116,9 @@ object ApiVersion {
// Introduce AllocateProducerIds (KIP-730)
hachikuji commented on a change in pull request #10560:
URL: https://github.com/apache/kafka/pull/10560#discussion_r664167798
##
File path:
core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala
##
@@ -1349,6 +1357,10 @@ class GroupMetadataManagerTest
yws-tracy commented on pull request #10972:
URL: https://github.com/apache/kafka/pull/10972#issuecomment-874559779
it's final so it needs to assign null otherwise compiler can not run
correctly
--
This is an automated message from the Apache Git Service.
To respond to the message, please
dengziming closed pull request #9662:
URL: https://github.com/apache/kafka/pull/9662
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr
showuon commented on a change in pull request #10976:
URL: https://github.com/apache/kafka/pull/10976#discussion_r664368496
##
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/metrics/RocksDBMetricsRecorderTest.java
##
@@ -70,99 +63,91 @@
private
wycc commented on a change in pull request #10976:
URL: https://github.com/apache/kafka/pull/10976#discussion_r664391227
##
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/metrics/RocksDBMetricsRecorderTest.java
##
@@ -70,99 +63,91 @@
private
dajac commented on a change in pull request #10974:
URL: https://github.com/apache/kafka/pull/10974#discussion_r664469428
##
File path: tools/src/main/java/org/apache/kafka/tools/TransactionsCommand.java
##
@@ -461,6 +471,437 @@ public void execute(Admin admin, Namespace ns,
P
[
https://issues.apache.org/jira/browse/KAFKA-12857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375714#comment-17375714
]
Chris Egerton commented on KAFKA-12857:
---
I believe this is a duplicate of
https:/
John Gray created KAFKA-13037:
-
Summary: "Thread state is already PENDING_SHUTDOWN" log spam
Key: KAFKA-13037
URL: https://issues.apache.org/jira/browse/KAFKA-13037
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-13037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Gray updated KAFKA-13037:
--
Description: KAFKA-12462 introduced a
[change|https://github.com/apache/kafka/commit/4fe4cdc4a61cbac8e
[
https://issues.apache.org/jira/browse/KAFKA-13037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Gray updated KAFKA-13037:
--
Description: KAFKA-12462 introduced a
[change|https://github.com/apache/kafka/commit/4fe4cdc4a61cbac8e
mumrah commented on a change in pull request #10864:
URL: https://github.com/apache/kafka/pull/10864#discussion_r664594269
##
File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
##
@@ -312,28 +311,151 @@ final class KafkaMetadataLog private (
}
}
- overr
wuYin commented on pull request #10977:
URL: https://github.com/apache/kafka/pull/10977#issuecomment-874798625
@showuon Thanks for reply
This small change is mainly to unify the way to determine if the user has
set the default value, both ways are used currently:
-
[ConfigDef.java#L1
mumrah commented on a change in pull request #10864:
URL: https://github.com/apache/kafka/pull/10864#discussion_r664604339
##
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##
@@ -2089,7 +2090,7 @@ private long pollUnattachedAsObserver(UnattachedState
mumrah commented on a change in pull request #10864:
URL: https://github.com/apache/kafka/pull/10864#discussion_r664605539
##
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##
@@ -2153,14 +2154,36 @@ private boolean maybeCompleteShutdown(long
currentT
ccding commented on a change in pull request #10579:
URL: https://github.com/apache/kafka/pull/10579#discussion_r664630725
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java
##
@@ -220,16 +227,16 @@ public boolean isPartit
ccding commented on a change in pull request #10579:
URL: https://github.com/apache/kafka/pull/10579#discussion_r664632598
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java
##
@@ -51,6 +58,7 @@
*/
[
https://issues.apache.org/jira/browse/KAFKA-13038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryanne Dolan updated KAFKA-13038:
-
Issue Type: Task (was: Bug)
> document IdentityReplicationPolicy
>
Ryanne Dolan created KAFKA-13038:
Summary: document IdentityReplicationPolicy
Key: KAFKA-13038
URL: https://issues.apache.org/jira/browse/KAFKA-13038
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-13038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryanne Dolan reassigned KAFKA-13038:
Assignee: Ryanne Dolan
> document IdentityReplicationPolicy
> ---
dajac commented on a change in pull request #10960:
URL: https://github.com/apache/kafka/pull/10960#discussion_r664634309
##
File path: core/src/main/scala/kafka/log/LogSegment.scala
##
@@ -99,21 +99,22 @@ class LogSegment private[log] (val log: FileRecords,
// volatile for
thomaskwscott commented on a change in pull request #10960:
URL: https://github.com/apache/kafka/pull/10960#discussion_r664651068
##
File path: core/src/main/scala/kafka/log/LogSegment.scala
##
@@ -99,21 +99,22 @@ class LogSegment private[log] (val log: FileRecords,
// volat
rhauch commented on a change in pull request #10975:
URL: https://github.com/apache/kafka/pull/10975#discussion_r664659210
##
File path: docs/connect.html
##
@@ -310,7 +310,12 @@ REST
API
GET /connectors/{name}/tasks/{taskid}/status - get
current status of the task,
jolshan commented on pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#issuecomment-874862869
Looks like some deprecated methods should be replaced.
```
/home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-9769/connect/mirror/src/main/java/org/apache/kafka/connect
kpatelatwork commented on a change in pull request #10975:
URL: https://github.com/apache/kafka/pull/10975#discussion_r664677454
##
File path: docs/connect.html
##
@@ -310,7 +310,12 @@ REST
API
GET /connectors/{name}/tasks/{taskid}/status - get
current status of the
rhauch opened a new pull request #10978:
URL: https://github.com/apache/kafka/pull/10978
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsu
kpatelatwork commented on pull request #10975:
URL: https://github.com/apache/kafka/pull/10975#issuecomment-874876791
@rhauch great call about the backward compatibility note, I applied the
suggestions. When you get time, could you please check again if it looks good?
--
This is an autom
skaundinya15 commented on a change in pull request #10962:
URL: https://github.com/apache/kafka/pull/10962#discussion_r664687436
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -1308,29 +1308,31 @@ private OffsetFe
skaundinya15 commented on a change in pull request #10962:
URL: https://github.com/apache/kafka/pull/10962#discussion_r664689037
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -1308,29 +1308,31 @@ private OffsetFe
skaundinya15 commented on a change in pull request #10962:
URL: https://github.com/apache/kafka/pull/10962#discussion_r664699493
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/internals/ListConsumerGroupOffsetsHandler.java
##
@@ -87,12 +87,16 @@ public Stri
skaundinya15 commented on a change in pull request #10962:
URL: https://github.com/apache/kafka/pull/10962#discussion_r664702184
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchRequest.java
##
@@ -174,6 +315,28 @@ public boolean isAllPartitions(
skaundinya15 commented on a change in pull request #10962:
URL: https://github.com/apache/kafka/pull/10962#discussion_r664703667
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchRequest.java
##
@@ -174,6 +315,28 @@ public boolean isAllPartitions(
skaundinya15 commented on a change in pull request #10962:
URL: https://github.com/apache/kafka/pull/10962#discussion_r664705607
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchResponse.java
##
@@ -185,21 +249,46 @@ public boolean hasError() {
hachikuji commented on a change in pull request #10974:
URL: https://github.com/apache/kafka/pull/10974#discussion_r664714525
##
File path: tools/src/main/java/org/apache/kafka/tools/TransactionsCommand.java
##
@@ -461,6 +471,437 @@ public void execute(Admin admin, Namespace ns
skaundinya15 commented on a change in pull request #10962:
URL: https://github.com/apache/kafka/pull/10962#discussion_r664718720
##
File path:
clients/src/test/java/org/apache/kafka/common/requests/OffsetFetchRequestTest.java
##
@@ -44,25 +46,20 @@
private final int parti
vvcephei commented on pull request #10602:
URL: https://github.com/apache/kafka/pull/10602#issuecomment-874917948
Hi @kamalcph , what's the status of this PR? I noticed there are some
unresolved code review comments, and there are some conflicts.
--
This is an automated message from the
kirktrue opened a new pull request #10979:
URL: https://github.com/apache/kafka/pull/10979
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testin
skaundinya15 commented on a change in pull request #10962:
URL: https://github.com/apache/kafka/pull/10962#discussion_r664738871
##
File path:
clients/src/test/java/org/apache/kafka/common/requests/OffsetFetchRequestTest.java
##
@@ -76,62 +73,169 @@ public void testConstructor
hantaoluo created KAFKA-13039:
-
Summary: kafka 0.10.1 gradle build failed
Key: KAFKA-13039
URL: https://issues.apache.org/jira/browse/KAFKA-13039
Project: Kafka
Issue Type: Bug
Componen
dajac merged pull request #10960:
URL: https://github.com/apache/kafka/pull/10960
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...
[
https://issues.apache.org/jira/browse/KAFKA-12981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-12981.
-
Fix Version/s: 3.0.0
Reviewer: David Jacot
Resolution: Fixed
> Ensure LogSegment
[
https://issues.apache.org/jira/browse/KAFKA-13039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375886#comment-17375886
]
hantaoluo commented on KAFKA-13039:
---
please help me thanks
> kafka 0.10.1 gradle bui
[
https://issues.apache.org/jira/browse/KAFKA-13039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hantaoluo updated KAFKA-13039:
--
Priority: Minor (was: Major)
> kafka 0.10.1 gradle build failed
>
>
skaundinya15 commented on a change in pull request #10962:
URL: https://github.com/apache/kafka/pull/10962#discussion_r664751150
##
File path: core/src/test/scala/unit/kafka/server/OffsetFetchRequestTest.scala
##
@@ -0,0 +1,227 @@
+/**
+ * Licensed to the Apache Software Founda
jeffkbkim commented on pull request #10955:
URL: https://github.com/apache/kafka/pull/10955#issuecomment-874952400
@dajac thank you for the review and suggestion! i have addressed your
comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
hachikuji commented on pull request #10974:
URL: https://github.com/apache/kafka/pull/10974#issuecomment-874954633
I will go ahead and merge since the 3.0 branch is about to be cut. I tested
locally.
--
This is an automated message from the Apache Git Service.
To respond to the message,
hachikuji merged pull request #10974:
URL: https://github.com/apache/kafka/pull/10974
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubsc
[
https://issues.apache.org/jira/browse/KAFKA-12979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-12979.
-
Fix Version/s: 3.0.0
Resolution: Fixed
> Implement --find-hanging API in transact
dajac commented on a change in pull request #10955:
URL: https://github.com/apache/kafka/pull/10955#discussion_r664771393
##
File path:
clients/src/test/java/org/apache/kafka/clients/admin/AdminClientTestUtils.java
##
@@ -102,4 +104,15 @@ public static DescribeTopicsResult
de
skaundinya15 commented on a change in pull request #10962:
URL: https://github.com/apache/kafka/pull/10962#discussion_r664772846
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchRequest.java
##
@@ -78,26 +85,107 @@ boolean isAllTopicPartitions()
skaundinya15 commented on a change in pull request #10962:
URL: https://github.com/apache/kafka/pull/10962#discussion_r664702184
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchRequest.java
##
@@ -174,6 +315,28 @@ public boolean isAllPartitions(
rajinisivaram commented on a change in pull request #10962:
URL: https://github.com/apache/kafka/pull/10962#discussion_r664785624
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -1308,29 +1308,31 @@ private OffsetF
rhauch merged pull request #10975:
URL: https://github.com/apache/kafka/pull/10975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr..
[
https://issues.apache.org/jira/browse/KAFKA-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Randall Hauch resolved KAFKA-13035.
---
Fix Version/s: 3.0.0
Reviewer: Randall Hauch
Resolution: Fixed
Merged to `tr
[
https://issues.apache.org/jira/browse/KAFKA-12989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True reassigned KAFKA-12989:
-
Assignee: Kirk True
> MockClient should respect the request matcher passed to
> prepareUnsuppo
1 - 100 of 202 matches
Mail list logo
