niket-goel commented on pull request #11070:
URL: https://github.com/apache/kafka/pull/11070#issuecomment-882782314
This PR ends up failing a bunch of existing unit tests. Taking a look at the
failures. Will update the PR.
List of failed tests
```
ConnectionQuotasTest.
[
https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383513#comment-17383513
]
Josep Prat commented on KAFKA-13010:
To add more to the mystery, I'm running the test until failure
[
https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383504#comment-17383504
]
A. Sophie Blee-Goldman commented on KAFKA-13010:
Yeah it's honestly pretty hard to
ijuma commented on a change in pull request #11067:
URL: https://github.com/apache/kafka/pull/11067#discussion_r672532721
##
File path: core/src/main/scala/kafka/server/BrokerServer.scala
##
@@ -389,6 +389,9 @@ class BrokerServer(
// a potentially lengthy
ijuma commented on a change in pull request #11067:
URL: https://github.com/apache/kafka/pull/11067#discussion_r672525835
##
File path: core/src/main/scala/kafka/server/BrokerServer.scala
##
@@ -389,6 +389,9 @@ class BrokerServer(
// a potentially lengthy
[
https://issues.apache.org/jira/browse/KAFKA-13104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryan Dielhenn reassigned KAFKA-13104:
-
Assignee: Ryan Dielhenn
> Controller should notify the RaftClient when it resigns
>
cmccabe commented on a change in pull request #11067:
URL: https://github.com/apache/kafka/pull/11067#discussion_r672512638
##
File path: core/src/main/scala/kafka/server/BrokerServer.scala
##
@@ -389,6 +389,9 @@ class BrokerServer(
// a potentially lengthy
cmccabe commented on a change in pull request #11067:
URL: https://github.com/apache/kafka/pull/11067#discussion_r672512638
##
File path: core/src/main/scala/kafka/server/BrokerServer.scala
##
@@ -389,6 +389,9 @@ class BrokerServer(
// a potentially lengthy
[
https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383484#comment-17383484
]
Josep Prat commented on KAFKA-13010:
If it happened after KIP-744 probably I introduced the
rhauch commented on pull request #10978:
URL: https://github.com/apache/kafka/pull/10978#issuecomment-882731540
Thanks for the review, folks. @omkreddy, I renamed the new utility method as
you suggested, and updated the JavaDocs as well. Hopefully the purpose and
behavior is more clear.
ccding opened a new pull request #11080:
URL: https://github.com/apache/kafka/pull/11080
This code
https://github.com/apache/kafka/blob/bfc57aa4ddcd719fc4a646c2ac09d4979c076455/clients/src/main/java/org/apache/kafka/common/record/DefaultRecord.java#L294-L296
returns record=null, and
Jose Armando Garcia Sancio created KAFKA-13104:
--
Summary: Controller should notify the RaftClient when it resigns
Key: KAFKA-13104
URL: https://issues.apache.org/jira/browse/KAFKA-13104
ijuma commented on pull request #11078:
URL: https://github.com/apache/kafka/pull/11078#issuecomment-882723123
Test failures are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ijuma merged pull request #11078:
URL: https://github.com/apache/kafka/pull/11078
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383474#comment-17383474
]
Walker Carlson commented on KAFKA-13010:
It is possible. I ran till failure (75 runs). And it
[
https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383474#comment-17383474
]
Walker Carlson edited comment on KAFKA-13010 at 7/19/21, 5:20 PM:
--
It
[
https://issues.apache.org/jira/browse/KAFKA-13100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383453#comment-17383453
]
Jose Armando Garcia Sancio commented on KAFKA-13100:
Here is an example that
[
https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383445#comment-17383445
]
A. Sophie Blee-Goldman commented on KAFKA-13010:
It's worth noting that this test seemed
mjsax commented on a change in pull request #11075:
URL: https://github.com/apache/kafka/pull/11075#discussion_r672448120
##
File path: core/src/main/scala/kafka/tools/StreamsResetter.java
##
@@ -655,7 +655,7 @@ public void doDelete(final List topicsToDelete,
[
https://issues.apache.org/jira/browse/KAFKA-8872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan updated KAFKA-8872:
--
Description:
Kafka currently uniquely identifies a topic by its name. This is generally
[
https://issues.apache.org/jira/browse/KAFKA-13011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan updated KAFKA-13011:
---
Description:
Implement the new deleteTopics apis as described in the KIP.
KIP-516:
[
https://issues.apache.org/jira/browse/KAFKA-13011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan updated KAFKA-13011:
---
Description:
Implement the new deleteTopics apis as described in the KIP.
KIP-516:
jolshan commented on a change in pull request #11075:
URL: https://github.com/apache/kafka/pull/11075#discussion_r672445518
##
File path: core/src/main/scala/kafka/tools/StreamsResetter.java
##
@@ -655,7 +655,7 @@ public void doDelete(final List topicsToDelete,
[
https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Walker Carlson reassigned KAFKA-13010:
--
Assignee: Walker Carlson
> Flaky test
>
[
https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383431#comment-17383431
]
Walker Carlson commented on KAFKA-13010:
This failure should will effect both tests. When it is
[
https://issues.apache.org/jira/browse/KAFKA-13100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-13100:
-
Priority: Blocker (was: Major)
> Controller cannot revert to an in-memory snapshot
>
mjsax commented on a change in pull request #11075:
URL: https://github.com/apache/kafka/pull/11075#discussion_r672438866
##
File path: core/src/main/scala/kafka/tools/StreamsResetter.java
##
@@ -655,7 +655,7 @@ public void doDelete(final List topicsToDelete,
cmccabe merged pull request #11064:
URL: https://github.com/apache/kafka/pull/11064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao resolved KAFKA-9555.
Resolution: Fixed
merged the PR to trunk.
> Topic-based implementation for the RemoteLogMetadataManager
>
junrao merged pull request #10579:
URL: https://github.com/apache/kafka/pull/10579
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mumrah commented on a change in pull request #11070:
URL: https://github.com/apache/kafka/pull/11070#discussion_r672407194
##
File path: core/src/main/scala/kafka/server/ControllerServer.scala
##
@@ -137,8 +137,14 @@ class ControllerServer(
credentialProvider,
dajac opened a new pull request #11079:
URL: https://github.com/apache/kafka/pull/11079
Small refactoring to make the code uniform across the newly introduced admin
group handlers.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
-
jolshan commented on a change in pull request #11075:
URL: https://github.com/apache/kafka/pull/11075#discussion_r672384414
##
File path: core/src/main/scala/kafka/tools/StreamsResetter.java
##
@@ -655,7 +655,7 @@ public void doDelete(final List topicsToDelete,
[
https://issues.apache.org/jira/browse/KAFKA-13058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-13058.
-
Reviewer: Rajini Sivaram
Resolution: Fixed
> `AlterConsumerGroupOffsetsHandler` does not
dajac commented on pull request #11016:
URL: https://github.com/apache/kafka/pull/11016#issuecomment-882610943
Merged to trunk and 3.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dajac merged pull request #11016:
URL: https://github.com/apache/kafka/pull/11016
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dajac commented on pull request #11016:
URL: https://github.com/apache/kafka/pull/11016#issuecomment-882608400
Failed tests are not related:
```
Build / ARM / org.apache.kafka.clients.ClientUtilsTest.testResolveDnsLookup()
Build / ARM /
mumrah commented on pull request #11036:
URL: https://github.com/apache/kafka/pull/11036#issuecomment-882589793
Thanks @ijuma, I don't have any more questions or follow-ups
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
[
https://issues.apache.org/jira/browse/KAFKA-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383368#comment-17383368
]
Moses Nakamura commented on KAFKA-3539:
---
Looks like KafkaProducerTest is the main one that breaks.
ijuma commented on pull request #11064:
URL: https://github.com/apache/kafka/pull/11064#issuecomment-882580369
Thanks for the explanation @rondagostino.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
rondagostino commented on pull request #11064:
URL: https://github.com/apache/kafka/pull/11064#issuecomment-882577262
> `KafkaService` uses the value of `metadata_quorum` to determine what type
of metadata quorum the test should use
On more thing: the code assumes `quorum.ZK` if no
rondagostino commented on pull request #11064:
URL: https://github.com/apache/kafka/pull/11064#issuecomment-882573376
LGTM
> How is `metadata_quorum` used?
`KafkaService` uses the value of `metadata_quorum` to determine what type of
metadata quorum the test should use, and
ijuma commented on pull request #11036:
URL: https://github.com/apache/kafka/pull/11036#issuecomment-882554954
It occurred to me that some system tests may require changes. I'll check the
nightly results and submit a follow-up PR.
--
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/KAFKA-13103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383338#comment-17383338
]
Ismael Juma commented on KAFKA-13103:
-
What would be the justification for
ijuma commented on pull request #11036:
URL: https://github.com/apache/kafka/pull/11036#issuecomment-882544788
Cherry-pick for 3.0: https://github.com/apache/kafka/pull/11078 (no
re-review required, but running the PR build due to conflicts)
--
This is an automated message from the
ijuma commented on pull request #11078:
URL: https://github.com/apache/kafka/pull/11078#issuecomment-882544244
There were a few mechanical conflicts I had to resolve. No re-review
required, but worth running the PR build before merging.
--
This is an automated message from the Apache
ijuma opened a new pull request #11078:
URL: https://github.com/apache/kafka/pull/11078
Also:
* Deprecate `log.message.format.version` and `message.format.version`.
* Log broker warning if the deprecated config values are ignored due to
the inter-broker protocol version.
* Log
[
https://issues.apache.org/jira/browse/KAFKA-13103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-13103:
-
Assignee: Luke Chen
> Should group admin handlers consider REBALANCE_IN_PROGRESS and
>
[
https://issues.apache.org/jira/browse/KAFKA-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexey Kashavkin resolved KAFKA-13055.
--
Resolution: Workaround
I did it like this:
{code:bash}
ijuma merged pull request #11036:
URL: https://github.com/apache/kafka/pull/11036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ijuma commented on pull request #11036:
URL: https://github.com/apache/kafka/pull/11036#issuecomment-882511896
I'll go ahead and merge. If there are further comments from @mumrah or
@hachikuji, I'll address in a follow up.
--
This is an automated message from the Apache Git Service.
To
ijuma commented on a change in pull request #11036:
URL: https://github.com/apache/kafka/pull/11036#discussion_r672255739
##
File path: core/src/main/scala/kafka/log/LogManager.scala
##
@@ -403,27 +411,49 @@ class LogManager(logDirs: Seq[File],
* Start the background
ijuma commented on a change in pull request #11036:
URL: https://github.com/apache/kafka/pull/11036#discussion_r672253775
##
File path: core/src/main/scala/kafka/log/LogManager.scala
##
@@ -403,27 +411,49 @@ class LogManager(logDirs: Seq[File],
* Start the background
dajac commented on a change in pull request #11016:
URL: https://github.com/apache/kafka/pull/11016#discussion_r672252610
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/internals/AlterConsumerGroupOffsetsHandler.java
##
@@ -105,53 +118,96 @@ public String
David Jacot created KAFKA-13103:
---
Summary: Should group admin handlers consider
REBALANCE_IN_PROGRESS and GROUP_AUTHORIZATION_FAILED as retryable errors?
Key: KAFKA-13103
URL:
dajac commented on a change in pull request #11036:
URL: https://github.com/apache/kafka/pull/11036#discussion_r672250729
##
File path: core/src/main/scala/kafka/log/LogManager.scala
##
@@ -403,27 +411,49 @@ class LogManager(logDirs: Seq[File],
* Start the background
dajac commented on a change in pull request #11036:
URL: https://github.com/apache/kafka/pull/11036#discussion_r672245627
##
File path: core/src/main/scala/kafka/log/LogConfig.scala
##
@@ -479,4 +501,31 @@ object LogConfig {
logProps.put(MessageDownConversionEnableProp,
showuon edited a comment on pull request #11057:
URL: https://github.com/apache/kafka/pull/11057#issuecomment-882498141
After test, **I confirmed that this fix can resolve the issue**. Just that
it might be a little more eager than before, to fetch the offset. But, looks
like we need
showuon commented on pull request #11057:
URL: https://github.com/apache/kafka/pull/11057#issuecomment-882498141
After test, **I confirmed that this fix can resolve the issue**. Just that
it might be more eager than before, to fetch the offset. But, looks like we
need those "fetch" to fix
rajinisivaram commented on a change in pull request #11016:
URL: https://github.com/apache/kafka/pull/11016#discussion_r672241651
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/internals/AlterConsumerGroupOffsetsHandler.java
##
@@ -105,53 +118,96 @@ public
dajac commented on pull request #11016:
URL: https://github.com/apache/kafka/pull/11016#issuecomment-882493385
@rajinisivaram Thanks for your comments. I have replied to them add/or
addressed them.
--
This is an automated message from the Apache Git Service.
To respond to the message,
dajac commented on a change in pull request #11016:
URL: https://github.com/apache/kafka/pull/11016#discussion_r672233510
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/internals/AlterConsumerGroupOffsetsHandler.java
##
@@ -105,53 +118,96 @@ public String
jlprat closed pull request #11025:
URL: https://github.com/apache/kafka/pull/11025
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jlprat commented on pull request #11025:
URL: https://github.com/apache/kafka/pull/11025#issuecomment-882487321
I will close this PR as this is not really compiling in Scala3 as Gradle's
scala plugin somehow still attempts to compile in Scala 2.
--
This is an automated message from the
dajac commented on a change in pull request #11016:
URL: https://github.com/apache/kafka/pull/11016#discussion_r672231624
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/internals/AlterConsumerGroupOffsetsHandler.java
##
@@ -105,53 +118,96 @@ public String
showuon commented on pull request #10884:
URL: https://github.com/apache/kafka/pull/10884#issuecomment-882474964
@cadonna , sorry, it turns out the version `LATEST_3_0` cannot be tested
yet. Remove it to make it work. Thank you.
```
SESSION REPORT (ALL TESTS)
ducktape
rajinisivaram commented on a change in pull request #11016:
URL: https://github.com/apache/kafka/pull/11016#discussion_r672176498
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/internals/AlterConsumerGroupOffsetsHandler.java
##
@@ -73,29 +75,40 @@ public
rackom commented on pull request #10824:
URL: https://github.com/apache/kafka/pull/10824#issuecomment-882348752
Hello, is there any way how to fix it in version 2.5.0? Because this is
causing us some issues with very short window + gap combinations (window:
10sec, grace: 5sec). It is not
rajinisivaram commented on a change in pull request #11002:
URL: https://github.com/apache/kafka/pull/11002#discussion_r672047056
##
File path:
clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java
##
@@ -172,6 +172,88 @@ public void
lkokhreidze commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-882283484
Thanks @cadonna for the valuable feedback
I've replied/addressed your comments.
--
This is an automated message from the Apache Git Service.
To respond to the
lkokhreidze commented on a change in pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#discussion_r672023741
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/StandbyTaskAssignorInitializer.java
##
@@ -0,0 +1,33 @@
lkokhreidze commented on a change in pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#discussion_r672023741
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/StandbyTaskAssignorInitializer.java
##
@@ -0,0 +1,33 @@
lkokhreidze commented on a change in pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#discussion_r672023438
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/StandbyTaskAssignor.java
##
@@ -0,0 +1,39 @@
+/*
+ *
lkokhreidze commented on a change in pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#discussion_r672023300
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/HighAvailabilityTaskAssignor.java
##
@@ -51,12 +57,12 @@
101 - 174 of 174 matches
Mail list logo
