[
https://issues.apache.org/jira/browse/KAFKA-13191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17417941#comment-17417941
]
Loïc Monney commented on KAFKA-13191:
-
We were able to reproduce similar scenario in
RivenSun2 commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-923632883
Thanks @guozhangwang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
ccding opened a new pull request #11348:
URL: https://github.com/apache/kafka/pull/11348
DescribeTopic returns
https://github.com/ccding/kafka/blob/79788ca042330faea7dc736f1f6ceb75b3f4d1d9/core/src/main/scala/kafka/server/ConfigHelper.scala#L45
```
config.originals.asScala.filt
cmccabe commented on pull request #11310:
URL: https://github.com/apache/kafka/pull/11310#issuecomment-923546285
> Should we also change the integration test
CreateTopicsRequestWithPolicyTest to support KRaft mode? the change LGTM.
I do want to do this but I think we'll need a separa
junrao commented on a change in pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#discussion_r712488028
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataSnapshotFile.java
##
@@ -0,0 +1,252 @@
+/*
+ * Li
dielhennr commented on pull request #11290:
URL: https://github.com/apache/kafka/pull/11290#issuecomment-923447368
KIP-771 was updated to keep controller metrics on standby controllers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
dielhennr closed pull request #11290:
URL: https://github.com/apache/kafka/pull/11290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubsc
[
https://issues.apache.org/jira/browse/KAFKA-8522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17417849#comment-17417849
]
Dhruvil Shah commented on KAFKA-8522:
-
The related PR is here for reference: https://
ccding commented on pull request #11345:
URL: https://github.com/apache/kafka/pull/11345#issuecomment-923364265
cc @kowshik
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
guozhangwang commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-923363134
Thanks @RivenSun2 , I read through your discussions with @showuon on the
ticket and I think I agree on most of them. I will try to make a pass on the PR
asap.
--
This is
wcarlson5 commented on a change in pull request #11347:
URL: https://github.com/apache/kafka/pull/11347#discussion_r712541150
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -351,6 +351,17 @@ public GroupAssi
wcarlson5 opened a new pull request #11347:
URL: https://github.com/apache/kafka/pull/11347
If for some reason partition revoked did not get called due to some bug it
would be good to log a warning that the previous assignment was not clean. This
could affect eos and it might be good to be
cmccabe commented on a change in pull request #11310:
URL: https://github.com/apache/kafka/pull/11310#discussion_r712527548
##
File path:
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java
##
@@ -465,6 +485,13 @@ private ApiError createTopic(Crea
ijuma commented on a change in pull request #11311:
URL: https://github.com/apache/kafka/pull/11311#discussion_r712521701
##
File path: metadata/src/main/java/org/apache/kafka/image/TopicsImage.java
##
@@ -92,6 +98,148 @@ public int hashCode() {
return Objects.hash(top
ijuma commented on a change in pull request #11311:
URL: https://github.com/apache/kafka/pull/11311#discussion_r712520803
##
File path: metadata/src/main/java/org/apache/kafka/image/TopicsImage.java
##
@@ -92,6 +98,148 @@ public int hashCode() {
return Objects.hash(top
cmccabe commented on a change in pull request #11310:
URL: https://github.com/apache/kafka/pull/11310#discussion_r712517042
##
File path:
clients/src/main/java/org/apache/kafka/server/policy/CreateTopicPolicy.java
##
@@ -104,6 +105,24 @@ public Short replicationFactor() {
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r712495759
##
File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala
##
@@ -761,16 +836,16 @@ class FetchSessionTest {
request2.isFromFollowe
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r712491310
##
File path: core/src/test/scala/unit/kafka/server/FetchRequestMaxBytesTest.scala
##
@@ -20,13 +20,13 @@ package kafka.server
import kafka.log.LogConfig
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r712488389
##
File path: core/src/main/scala/kafka/server/DelayedFetch.scala
##
@@ -92,7 +92,7 @@ class DelayedFetch(delayMs: Long,
val fetchLeaderEpoch = f
3schwartz commented on a change in pull request #11334:
URL: https://github.com/apache/kafka/pull/11334#discussion_r712475960
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/StoreQueryIntegrationTest.java
##
@@ -477,6 +477,7 @@ public void
shouldQuery
cmccabe commented on a change in pull request #11311:
URL: https://github.com/apache/kafka/pull/11311#discussion_r712471886
##
File path: metadata/src/main/java/org/apache/kafka/image/TopicsImage.java
##
@@ -92,6 +98,148 @@ public int hashCode() {
return Objects.hash(t
cmccabe commented on a change in pull request #11311:
URL: https://github.com/apache/kafka/pull/11311#discussion_r712456110
##
File path: metadata/src/main/java/org/apache/kafka/image/TopicsImage.java
##
@@ -92,6 +98,148 @@ public int hashCode() {
return Objects.hash(t
cmccabe merged pull request #11346:
URL: https://github.com/apache/kafka/pull/11346
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr.
ccding opened a new pull request #11345:
URL: https://github.com/apache/kafka/pull/11345
Within a LogSegment, the TimeIndex and OffsetIndex are lazy indices that
don't get created on disk until they are accessed for the first time. However,
Log recovery logic expects the presence of offset
cmccabe commented on a change in pull request #11311:
URL: https://github.com/apache/kafka/pull/11311#discussion_r712456110
##
File path: metadata/src/main/java/org/apache/kafka/image/TopicsImage.java
##
@@ -92,6 +98,148 @@ public int hashCode() {
return Objects.hash(t
ccding commented on pull request #11289:
URL: https://github.com/apache/kafka/pull/11289#issuecomment-923206682
It appears the trunk branch fails to build after merging this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
junrao commented on pull request #11293:
URL: https://github.com/apache/kafka/pull/11293#issuecomment-923147112
Also cherry-picked the PR to 3.0 branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
junrao merged pull request #11293:
URL: https://github.com/apache/kafka/pull/11293
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr..
Jun Rao created KAFKA-13313:
---
Summary: In KRaft mode, CreateTopic should return the topic
configs in the response
Key: KAFKA-13313
URL: https://issues.apache.org/jira/browse/KAFKA-13313
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-13296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sagar Rao reassigned KAFKA-13296:
-
Assignee: Sagar Rao
> Verify old assignment within StreamsPartitionAssignor
> -
[
https://issues.apache.org/jira/browse/KAFKA-13254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-13254.
-
Resolution: Fixed
> Deadlock when expanding ISR
> ---
>
>
hachikuji merged pull request #11289:
URL: https://github.com/apache/kafka/pull/11289
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubsc
ccding commented on pull request #11293:
URL: https://github.com/apache/kafka/pull/11293#issuecomment-923097186
Failed tests passed on my local run
```
Build / JDK 8 and Scala 2.12 / [1] Type=Raft, Name=testTopicPartition,
Security=PLAINTEXT – kafka.admin.LeaderElectionCommandTest
ccding edited a comment on pull request #11293:
URL: https://github.com/apache/kafka/pull/11293#issuecomment-920247203
~~The comment of `defineInternal` says~~
```
* Define a new internal configuration. Internal configuration won't
show up in the docs and aren't
* intende
ccding edited a comment on pull request #11293:
URL: https://github.com/apache/kafka/pull/11293#issuecomment-920247203
~~The comment of `defineInternal` says~~
```
~~ * Define a new internal configuration. Internal configuration won't
show up in the docs and aren't~~
~~ * i
ccding commented on a change in pull request #11293:
URL: https://github.com/apache/kafka/pull/11293#discussion_r712339044
##
File path: core/src/main/scala/kafka/server/ZkAdminManager.scala
##
@@ -118,7 +118,7 @@ class ZkAdminManager(val config: KafkaConfig,
metadataAndCo
junrao commented on a change in pull request #11327:
URL: https://github.com/apache/kafka/pull/11327#discussion_r712335875
##
File path: core/src/main/scala/kafka/log/LogCleanerManager.scala
##
@@ -511,6 +513,27 @@ private[log] class LogCleanerManager(val logDirs:
Seq[File],
junrao commented on a change in pull request #11293:
URL: https://github.com/apache/kafka/pull/11293#discussion_r712319893
##
File path: core/src/main/scala/kafka/server/ZkAdminManager.scala
##
@@ -118,7 +118,7 @@ class ZkAdminManager(val config: KafkaConfig,
metadataAndCo
ramesh-muthusamy commented on pull request #10910:
URL: https://github.com/apache/kafka/pull/10910#issuecomment-923052144
@kkonstantine can you help reviewing the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
chrisbeard commented on pull request #8283:
URL: https://github.com/apache/kafka/pull/8283#issuecomment-922995545
@d8tltanc Nice work on this patch, this would be a nice feature. Any plans
to open a KIP for this? I'd be happy to help out!
--
This is an automated message from the Apache G
[
https://issues.apache.org/jira/browse/KAFKA-13310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17417644#comment-17417644
]
RivenSun edited comment on KAFKA-13310 at 9/20/21, 2:23 PM:
[
https://issues.apache.org/jira/browse/KAFKA-13310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17417644#comment-17417644
]
RivenSun edited comment on KAFKA-13310 at 9/20/21, 2:18 PM:
dajac commented on pull request #11344:
URL: https://github.com/apache/kafka/pull/11344#issuecomment-922924043
Successful run:
http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2021-09-20--001.system-test-kafka-branch-builder--1632143234--dajac--KAFKA-1331
[
https://issues.apache.org/jira/browse/KAFKA-13310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17417644#comment-17417644
]
RivenSun edited comment on KAFKA-13310 at 9/20/21, 1:04 PM:
[
https://issues.apache.org/jira/browse/KAFKA-13310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17417644#comment-17417644
]
RivenSun commented on KAFKA-13310:
--
Hi [~dajac],
The version of Kafka-client used in
[
https://issues.apache.org/jira/browse/KAFKA-10643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eran Levy resolved KAFKA-10643.
---
Resolution: Cannot Reproduce
> Static membership - repetitive PreparingRebalance with updating metad
[
https://issues.apache.org/jira/browse/KAFKA-10643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17417634#comment-17417634
]
Eran Levy edited comment on KAFKA-10643 at 9/20/21, 12:52 PM:
[
https://issues.apache.org/jira/browse/KAFKA-10643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17417634#comment-17417634
]
Eran Levy edited comment on KAFKA-10643 at 9/20/21, 12:52 PM:
[
https://issues.apache.org/jira/browse/KAFKA-10643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17417634#comment-17417634
]
Eran Levy commented on KAFKA-10643:
---
Thanks, for some reason it doesnt happen anymore
[
https://issues.apache.org/jira/browse/KAFKA-13310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17417615#comment-17417615
]
David Jacot commented on KAFKA-13310:
-
[~RivenSun] Thanks for the bug report. The ti
lhunyady commented on a change in pull request #11333:
URL: https://github.com/apache/kafka/pull/11333#discussion_r712103493
##
File path:
connect/api/src/main/java/org/apache/kafka/connect/connector/Connector.java
##
@@ -150,4 +152,15 @@ public Config validate(Map
connectorC
lhunyady commented on a change in pull request #11333:
URL: https://github.com/apache/kafka/pull/11333#discussion_r712087974
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractHerderTest.java
##
@@ -289,6 +290,23 @@ public void testBuildRestar
lhunyady commented on a change in pull request #11333:
URL: https://github.com/apache/kafka/pull/11333#discussion_r712087974
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractHerderTest.java
##
@@ -289,6 +290,23 @@ public void testBuildRestar
[
https://issues.apache.org/jira/browse/KAFKA-13310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17417587#comment-17417587
]
RivenSun edited comment on KAFKA-13310 at 9/20/21, 11:32 AM:
-
dajac opened a new pull request #11344:
URL: https://github.com/apache/kafka/pull/11344
TODO
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upg
[
https://issues.apache.org/jira/browse/KAFKA-13310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17417587#comment-17417587
]
RivenSun commented on KAFKA-13310:
--
Hi [~showuon]
Thank you for your reply, after my
satishd commented on a change in pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#discussion_r712046006
##
File path: checkstyle/import-control.xml
##
@@ -303,6 +303,12 @@
+
+
+
+
Review comment:
Good poi
David Jacot created KAFKA-13312:
---
Summary: 'NetworkDegradeTest#test_rate' should wait until iperf
server is listening
Key: KAFKA-13312
URL: https://issues.apache.org/jira/browse/KAFKA-13312
Project: Kaf
satishd commented on a change in pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#discussion_r712009321
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemotePartitionMetadataStore.java
##
@@ -42,21 +45,36 @@
public
satishd commented on a change in pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#discussion_r712001447
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java
##
@@ -120,6 +174,29 @@ public void run() {
satishd commented on a change in pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#discussion_r711983996
##
File path:
storage/src/main/resources/message/RemoteLogSegmentMetadataRecordSnapshot.json
##
@@ -0,0 +1,92 @@
+// Licensed to the Apache Software Foun
satishd commented on pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#issuecomment-922748027
@junrao : Thanks for the review comments. Sorry about the wrong branch merge
which caused the confusion here. Addressed the comments in the latest commit.
--
This is an a
satishd commented on a change in pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#discussion_r711990585
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemotePartitionMetadataStore.java
##
@@ -91,6 +109,23 @@ public v
satishd commented on a change in pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#discussion_r711989743
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataSnapshotFile.java
##
@@ -0,0 +1,239 @@
+/*
+ * L
satishd commented on a change in pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#discussion_r711989139
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java
##
@@ -81,12 +83,21 @@
satishd commented on a change in pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#discussion_r711987740
##
File path:
storage/src/main/resources/message/RemotePartitionDleteMetadataSnapshot.json
##
@@ -0,0 +1,42 @@
+// Licensed to the Apache Software Founda
satishd commented on a change in pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#discussion_r711987288
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemotePartitionMetadataStore.java
##
@@ -91,6 +109,23 @@ public v
satishd commented on a change in pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#discussion_r711987062
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java
##
@@ -161,53 +162,46 @@ public void
satishd commented on a change in pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#discussion_r711986569
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java
##
@@ -161,53 +162,46 @@ public void
satishd commented on a change in pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#discussion_r711985629
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java
##
@@ -120,6 +174,29 @@ public void run() {
satishd commented on a change in pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#discussion_r711985297
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java
##
@@ -120,6 +174,29 @@ public void run() {
satishd commented on a change in pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#discussion_r711983996
##
File path:
storage/src/main/resources/message/RemoteLogSegmentMetadataRecordSnapshot.json
##
@@ -0,0 +1,92 @@
+// Licensed to the Apache Software Foun
satishd commented on a change in pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#discussion_r711983366
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataSnapshotFile.java
##
@@ -0,0 +1,239 @@
+/*
+ * L
satishd commented on a change in pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#discussion_r711982403
##
File path:
storage/src/main/resources/message/RemoteLogSegmentMetadataRecordSnapshot.json
##
@@ -0,0 +1,92 @@
+// Licensed to the Apache Software Foun
dajac merged pull request #11343:
URL: https://github.com/apache/kafka/pull/11343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...
dajac opened a new pull request #11343:
URL: https://github.com/apache/kafka/pull/11343
Upgrade doc in trunk as per https://github.com/apache/kafka/pull/11318.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test covera
[
https://issues.apache.org/jira/browse/KAFKA-13310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17417509#comment-17417509
]
Luke Chen commented on KAFKA-13310:
---
Before dive into the PR, I'd like to hear comment
dajac merged pull request #11342:
URL: https://github.com/apache/kafka/pull/11342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...
dajac merged pull request #11341:
URL: https://github.com/apache/kafka/pull/11341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...
dajac commented on a change in pull request #11342:
URL: https://github.com/apache/kafka/pull/11342#discussion_r711927241
##
File path: tests/docker/Dockerfile
##
@@ -1,4 +1,4 @@
-# Licensed to the Apache Software Foundation (ASF) under one or more
+ # Licensed to the Apache So
omkreddy commented on a change in pull request #11342:
URL: https://github.com/apache/kafka/pull/11342#discussion_r711919224
##
File path: tests/docker/Dockerfile
##
@@ -1,4 +1,4 @@
-# Licensed to the Apache Software Foundation (ASF) under one or more
+ # Licensed to the Apache
[
https://issues.apache.org/jira/browse/KAFKA-13306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Laszlo Istvan Hunyady reassigned KAFKA-13306:
-
Assignee: Laszlo Istvan Hunyady (was: Andras Katona)
> Null connector
dajac opened a new pull request #11342:
URL: https://github.com/apache/kafka/pull/11342
Bump 2.7/2.8 versions to latest where necessary.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
Daniel Urban created KAFKA-13311:
Summary: MM2 should allow propagating arbitrary global
configurations to the Connector config
Key: KAFKA-13311
URL: https://issues.apache.org/jira/browse/KAFKA-13311
[
https://issues.apache.org/jira/browse/KAFKA-13311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Urban reassigned KAFKA-13311:
Assignee: (was: Daniel Urban)
> MM2 should allow propagating arbitrary global configu
85 matches
Mail list logo
