[GitHub] [kafka] showuon commented on pull request #11467: MINOR: fix java doc in kafkaProducer

showuon commented on pull request #11467: URL: https://github.com/apache/kafka/pull/11467#issuecomment-971313038 @mimaison , thanks for the comments. PR updated, please take a look again. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [kafka] showuon commented on a change in pull request #11467: MINOR: fix java doc in kafkaProducer

showuon commented on a change in pull request #11467: URL: https://github.com/apache/kafka/pull/11467#discussion_r750961137 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java ## @@ -117,15 +115,16 @@ * as well as a background I/O thread

[GitHub] [kafka] guozhangwang commented on a change in pull request #11479: KAFKA-12648: Make changing the named topologies blocking

guozhangwang commented on a change in pull request #11479: URL: https://github.com/apache/kafka/pull/11479#discussion_r750797917 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -908,20 +908,25 @@ private void initializeA

[GitHub] [kafka] guozhangwang commented on pull request #11479: KAFKA-12648: Make changing the named topologies blocking

guozhangwang commented on pull request #11479: URL: https://github.com/apache/kafka/pull/11479#issuecomment-971213962 Hey @wcarlson5 sorry for getting late on this review.. overall it looks good, and I think adding the future makes sense. Just feeling that we can simplify the thread coordi

[GitHub] [kafka] guozhangwang commented on a change in pull request #11479: KAFKA-12648: Make changing the named topologies blocking

guozhangwang commented on a change in pull request #11479: URL: https://github.com/apache/kafka/pull/11479#discussion_r750900571 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/KafkaStreamsNamedTopologyWrapper.java ## @@ -118,40 +

[GitHub] [kafka] RivenSun2 commented on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

RivenSun2 commented on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-971202316 Hi @showuon @guozhangwang please help check this PR when available. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (KAFKA-13437) Broker parameter optimization: security.inter.broker.protocol and num.network.threads

[ https://issues.apache.org/jira/browse/KAFKA-13437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17444942#comment-17444942 ] RivenSun commented on KAFKA-13437: -- Hi [~dajac] [~ableegoldman] , any comments? Thanks.

[GitHub] [kafka] zzccctv commented on pull request #11496: KAFKA-13454: kafka has duplicate configuration information log information printin…

zzccctv commented on pull request #11496: URL: https://github.com/apache/kafka/pull/11496#issuecomment-971120974 @guozhangwang During initialization, DynamicBrokerConfig will call updateDefaultConfig and updateBrrokerConfig, which call updateCurrentConfig respectively,In the updateCurrence

[GitHub] [kafka] showuon commented on pull request #11490: KAFKA-13439: Deprecate eager rebalance protocol in kafka stream

showuon commented on pull request #11490: URL: https://github.com/apache/kafka/pull/11490#issuecomment-971120690 @ableegoldman , thanks for the good suggestion. I added a link at the end to the https://issues.apache.org/jira/browse/KAFKA-8575 (and update the description in KAFKA-8575), to

[jira] [Updated] (KAFKA-8575) Investigate removing EAGER protocol & cleaning up task suspension in Streams rebalancing

[ https://issues.apache.org/jira/browse/KAFKA-8575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-8575: - Description: With KIP-429 the suspend/resume of tasks may have minimal gains while adding a lot of compl

[GitHub] [kafka] jolshan commented on a change in pull request #11004: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name (trunk)

jolshan commented on a change in pull request #11004: URL: https://github.com/apache/kafka/pull/11004#discussion_r750833284 ## File path: clients/src/main/java/org/apache/kafka/clients/Metadata.java ## @@ -218,10 +218,10 @@ public synchronized boolean updateRequested() { }

[GitHub] [kafka] wcarlson5 commented on a change in pull request #11479: KAFKA-12648: Make changing the named topologies blocking

wcarlson5 commented on a change in pull request #11479: URL: https://github.com/apache/kafka/pull/11479#discussion_r750825033 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java ## @@ -83,6 +100,7 @@ public TopologyMetadata(fi

[GitHub] [kafka] hachikuji commented on a change in pull request #11004: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name (trunk)

hachikuji commented on a change in pull request #11004: URL: https://github.com/apache/kafka/pull/11004#discussion_r75082 ## File path: clients/src/main/java/org/apache/kafka/clients/Metadata.java ## @@ -218,10 +218,10 @@ public synchronized boolean updateRequested() {

[GitHub] [kafka] mjsax commented on pull request #11404: MINOR: update Kafka Streams standby task config

mjsax commented on pull request #11404: URL: https://github.com/apache/kafka/pull/11404#issuecomment-971051288 Merged to `trunk` and cherry-picked to `3.1` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [kafka] mjsax merged pull request #11404: MINOR: update Kafka Streams standby task config

mjsax merged pull request #11404: URL: https://github.com/apache/kafka/pull/11404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[jira] [Commented] (KAFKA-13422) Even if the correct username and password are configured, when ClientBroker or KafkaClient tries to establish a SASL connection to ServerBroker, an exception is thrown

[ https://issues.apache.org/jira/browse/KAFKA-13422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17444889#comment-17444889 ] RivenSun commented on KAFKA-13422: -- Hi [~rsivaram]  [~ijuma]  1. In the latest officia

[GitHub] [kafka] ableegoldman commented on a change in pull request #11479: KAFKA-12648: Make changing the named topologies blocking

ableegoldman commented on a change in pull request #11479: URL: https://github.com/apache/kafka/pull/11479#discussion_r750810073 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -908,20 +908,25 @@ private void initializeA

[GitHub] [kafka] mjsax commented on a change in pull request #11455: KAFKA-13423: GlobalThread should not log ERROR on clean shutdown

mjsax commented on a change in pull request #11455: URL: https://github.com/apache/kafka/pull/11455#discussion_r750808720 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -655,10 +656,11 @@ public synchronized void onChange(final Thread threa

[GitHub] [kafka] mjsax commented on a change in pull request #11455: KAFKA-13423: GlobalThread should not log ERROR on clean shutdown

mjsax commented on a change in pull request #11455: URL: https://github.com/apache/kafka/pull/11455#discussion_r750806826 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -655,10 +656,11 @@ public synchronized void onChange(final Thread threa

[GitHub] [kafka] guozhangwang commented on pull request #11211: KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…

guozhangwang commented on pull request #11211: URL: https://github.com/apache/kafka/pull/11211#issuecomment-970972898 @mjsax @ableegoldman could you chime in here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [kafka] guozhangwang commented on a change in pull request #11479: KAFKA-12648: Make changing the named topologies blocking

guozhangwang commented on a change in pull request #11479: URL: https://github.com/apache/kafka/pull/11479#discussion_r750795877 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java ## @@ -121,9 +164,9 @@ public void maybeWaitF

[GitHub] [kafka] hachikuji commented on a change in pull request #11004: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name (trunk)

hachikuji commented on a change in pull request #11004: URL: https://github.com/apache/kafka/pull/11004#discussion_r750784403 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -1206,7 +1205,8 @@ private void validatePositionsOnM

[GitHub] [kafka] rondagostino commented on a change in pull request #11503: KAFKA-13456: controller.listener.names required in KRaft

rondagostino commented on a change in pull request #11503: URL: https://github.com/apache/kafka/pull/11503#discussion_r750751689 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -2007,8 +2007,13 @@ class KafkaConfig private(doLog: Boolean, val props: java

[GitHub] [kafka] hachikuji commented on a change in pull request #11004: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name (trunk)

hachikuji commented on a change in pull request #11004: URL: https://github.com/apache/kafka/pull/11004#discussion_r750733985 ## File path: clients/src/main/java/org/apache/kafka/clients/Metadata.java ## @@ -395,7 +395,7 @@ else if (metadata.error() == Errors.TOPIC_AUTHORIZATI

[GitHub] [kafka] guozhangwang commented on a change in pull request #11451: KAFKA-13419: Only reset generation ID when ILLEGAL_GENERATION error

guozhangwang commented on a change in pull request #11451: URL: https://github.com/apache/kafka/pull/11451#discussion_r750719122 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ## @@ -755,18 +755,17 @@ protected void onJ

[jira] [Commented] (KAFKA-10413) rebalancing leads to unevenly balanced connectors

[ https://issues.apache.org/jira/browse/KAFKA-10413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17444846#comment-17444846 ] Preston Price commented on KAFKA-10413: --- I am experiencing this issue as well, and

[GitHub] [kafka] rondagostino closed pull request #11256: KAFKA-13224: Expose consistent broker.id and node.id in config values/originals maps

rondagostino closed pull request #11256: URL: https://github.com/apache/kafka/pull/11256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsu

[GitHub] [kafka] kirktrue commented on pull request #11486: KAFKA-13444: Fix OAuthCompatibilityTool help and add SSL options

kirktrue commented on pull request #11486: URL: https://github.com/apache/kafka/pull/11486#issuecomment-970697692 Thanks @junrao! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [kafka] C0urante opened a new pull request #11508: KAFKA-9279: Fail producer transactions for asynchronously-reported, synchronously-encountered ApiExceptions

C0urante opened a new pull request #11508: URL: https://github.com/apache/kafka/pull/11508 Some types of exceptions that the producer reports are encountered synchronously during a call to `KafkaProducer::send`, but reported asynchronously via the resulting `Future` instead of being thrown

[jira] [Assigned] (KAFKA-9279) Silent data loss in Kafka producer

[ https://issues.apache.org/jira/browse/KAFKA-9279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton reassigned KAFKA-9279: Assignee: Chris Egerton > Silent data loss in Kafka producer > ---

[GitHub] [kafka] junrao commented on pull request #11486: KAFKA-13444: Fix OAuthCompatibilityTool help and add SSL options

junrao commented on pull request #11486: URL: https://github.com/apache/kafka/pull/11486#issuecomment-970681891 merged the PR to 3.1 branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [kafka] kirktrue commented on pull request #11484: KAFKA-13443: Kafka broker exits when OAuth enabled and certain configuration not specified

kirktrue commented on pull request #11484: URL: https://github.com/apache/kafka/pull/11484#issuecomment-970642489 > > > @kirktrue Should we add or extend tests in KafkaConfigTest to cover them? > > > > > > They're already present on lines 780 and 781 in `KafkaConfigTest.scala`:

[jira] [Resolved] (KAFKA-13071) Deprecate and remove --authorizer option in kafka-acls.sh

[ https://issues.apache.org/jira/browse/KAFKA-13071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-13071. - Fix Version/s: 3.1.0 Resolution: Fixed > Deprecate and remove --authorizer option

[GitHub] [kafka] hachikuji merged pull request #11502: KAFKA-13071; Deprecate support for changing acls through the authorizer

hachikuji merged pull request #11502: URL: https://github.com/apache/kafka/pull/11502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubsc

[GitHub] [kafka] functioner commented on a change in pull request #11504: KAFKA-13457: socketChannel in Acceptor#accept is not closed upon IOException

functioner commented on a change in pull request #11504: URL: https://github.com/apache/kafka/pull/11504#discussion_r750538124 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -734,6 +734,10 @@ private[kafka] class Acceptor(val endPoint: EndPoint,

[GitHub] [kafka] dajac commented on a change in pull request #11504: KAFKA-13457: socketChannel in Acceptor#accept is not closed upon IOException

dajac commented on a change in pull request #11504: URL: https://github.com/apache/kafka/pull/11504#discussion_r750532169 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -734,6 +734,10 @@ private[kafka] class Acceptor(val endPoint: EndPoint, va

[GitHub] [kafka] jolshan commented on a change in pull request #11459: KAFKA-13394: Topic IDs should be removed from PartitionFetchState if they are no longer sent by the controller

jolshan commented on a change in pull request #11459: URL: https://github.com/apache/kafka/pull/11459#discussion_r750520495 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1401,6 +1401,12 @@ class ReplicaManager(val config: KafkaConfig,

[GitHub] [kafka] C0urante commented on pull request #10528: KAFKA-12497: Skip unnecessary source task offset commits

C0urante commented on pull request #10528: URL: https://github.com/apache/kafka/pull/10528#issuecomment-970500563 Thanks for the review @tombentley, and apologies for the delay. I've addressed your comments and moved the `LogCaptureAppender` class to the clients module where it can be used

[GitHub] [kafka] functioner commented on a change in pull request #11504: KAFKA-13457: socketChannel in Acceptor#accept is not closed upon IOException

functioner commented on a change in pull request #11504: URL: https://github.com/apache/kafka/pull/11504#discussion_r750498357 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -734,6 +734,10 @@ private[kafka] class Acceptor(val endPoint: EndPoint,

[GitHub] [kafka] functioner commented on a change in pull request #11504: KAFKA-13457: socketChannel in Acceptor#accept is not closed upon IOException

functioner commented on a change in pull request #11504: URL: https://github.com/apache/kafka/pull/11504#discussion_r750497406 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -734,6 +734,10 @@ private[kafka] class Acceptor(val endPoint: EndPoint,

[GitHub] [kafka] hachikuji commented on a change in pull request #11503: KAFKA-13456: controller.listener.names required in KRaft

hachikuji commented on a change in pull request #11503: URL: https://github.com/apache/kafka/pull/11503#discussion_r750496118 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -2007,8 +2007,13 @@ class KafkaConfig private(doLog: Boolean, val props: java.ut

[jira] [Updated] (KAFKA-13457) socketChannel in Acceptor#accept is not closed upon IOException

[ https://issues.apache.org/jira/browse/KAFKA-13457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haoze Wu updated KAFKA-13457: - Description: When the kafka.network.Acceptor in SocketServer.scala accepts a new connection in the `acc

[GitHub] [kafka] dajac commented on pull request #11486: KAFKA-13444: Fix OAuthCompatibilityTool help and add SSL options

dajac commented on pull request #11486: URL: https://github.com/apache/kafka/pull/11486#issuecomment-970485522 @kirktrue @junrao I am OK with merging this to 3.1 branch as it changes the command line interface in an incompatible way. @junrao Could you cherry-pick it to 3.1? -- This is a

[jira] [Comment Edited] (KAFKA-13370) Offset commit failure percentage metric is not computed correctly (regression)

[ https://issues.apache.org/jira/browse/KAFKA-13370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17444638#comment-17444638 ] Randall Hauch edited comment on KAFKA-13370 at 11/16/21, 5:01 PM:

[GitHub] [kafka] kirktrue commented on pull request #11486: KAFKA-13444: Fix OAuthCompatibilityTool help and add SSL options

kirktrue commented on pull request #11486: URL: https://github.com/apache/kafka/pull/11486#issuecomment-970472487 @dajac - can you merge this into the 3.1 branch as well? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[jira] [Updated] (KAFKA-13426) Add recordMetadata to StateStoreContext

[ https://issues.apache.org/jira/browse/KAFKA-13426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-13426: - Fix Version/s: 3.2.0 > Add recordMetadata to StateStoreContext > ---

[jira] [Resolved] (KAFKA-13426) Add recordMetadata to StateStoreContext

[ https://issues.apache.org/jira/browse/KAFKA-13426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler resolved KAFKA-13426. -- Resolution: Fixed > Add recordMetadata to StateStoreContext >

[GitHub] [kafka] vvcephei merged pull request #11498: Add recordMetadata() to StateStoreContext

vvcephei merged pull request #11498: URL: https://github.com/apache/kafka/pull/11498 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr

[GitHub] [kafka] vvcephei commented on pull request #11498: Add recordMetadata() to StateStoreContext

vvcephei commented on pull request #11498: URL: https://github.com/apache/kafka/pull/11498#issuecomment-970464459 I re-ran the tests locally and they passed. This change also doesn't seem like it could possibly have caused those build failures, and we did also get a passing build on Jenkin

[GitHub] [kafka] jolshan commented on a change in pull request #11459: KAFKA-13394: Topic IDs should be removed from PartitionFetchState if they are no longer sent by the controller

jolshan commented on a change in pull request #11459: URL: https://github.com/apache/kafka/pull/11459#discussion_r750452864 ## File path: core/src/test/scala/integration/kafka/server/FetchRequestTestDowngrade.scala ## @@ -0,0 +1,85 @@ +/** + * Licensed to the Apache Software F

[GitHub] [kafka] jolshan commented on a change in pull request #11459: KAFKA-13394: Topic IDs should be removed from PartitionFetchState if they are no longer sent by the controller

jolshan commented on a change in pull request #11459: URL: https://github.com/apache/kafka/pull/11459#discussion_r750452149 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1401,6 +1401,12 @@ class ReplicaManager(val config: KafkaConfig,

[jira] [Commented] (KAFKA-13370) Offset commit failure percentage metric is not computed correctly (regression)

[ https://issues.apache.org/jira/browse/KAFKA-13370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17444638#comment-17444638 ] Randall Hauch commented on KAFKA-13370: --- I reverted the change (https://github.com

[jira] [Updated] (KAFKA-13370) Offset commit failure percentage metric is not computed correctly (regression)

[ https://issues.apache.org/jira/browse/KAFKA-13370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-13370: -- Fix Version/s: 2.8.2 > Offset commit failure percentage metric is not computed correctly (regr

[jira] [Comment Edited] (KAFKA-13370) Offset commit failure percentage metric is not computed correctly (regression)

[ https://issues.apache.org/jira/browse/KAFKA-13370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17444615#comment-17444615 ] Randall Hauch edited comment on KAFKA-13370 at 11/16/21, 3:47 PM:

[jira] [Commented] (KAFKA-13370) Offset commit failure percentage metric is not computed correctly (regression)

[ https://issues.apache.org/jira/browse/KAFKA-13370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17444615#comment-17444615 ] Randall Hauch commented on KAFKA-13370: --- Thanks, [~showuon], creating the PR that

[GitHub] [kafka] rhauch closed pull request #11413: KAFKA-13370: add errors when commit offsets failed and add tests

rhauch closed pull request #11413: URL: https://github.com/apache/kafka/pull/11413 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr..

[GitHub] [kafka] rhauch commented on pull request #11413: KAFKA-13370: add errors when commit offsets failed and add tests

rhauch commented on pull request #11413: URL: https://github.com/apache/kafka/pull/11413#issuecomment-970395759 @showuon, thanks for trying to fix this issue. But I think the best course of action here is actually to revert #9642, for a few reasons. 1. It was actually useful to have that

[jira] [Commented] (KAFKA-10334) Transactions not working properly

[ https://issues.apache.org/jira/browse/KAFKA-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17444589#comment-17444589 ] Chris Egerton commented on KAFKA-10334: --- It seems like this may be a duplicate of

[GitHub] [kafka] dajac commented on a change in pull request #11452: KAFKA-13412; Ensure initTransactions() safe for retry after timeout

dajac commented on a change in pull request #11452: URL: https://github.com/apache/kafka/pull/11452#discussion_r750335078 ## File path: clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java ## @@ -903,6 +903,47 @@ public void testPartitionsForWithNullT

[GitHub] [kafka] viktorsomogyi commented on pull request #11491: KAFKA-13442: REST API endpoint for fetching a connector's config def

viktorsomogyi commented on pull request #11491: URL: https://github.com/apache/kafka/pull/11491#issuecomment-970328656 ok, sounds good! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [kafka] RivenSun2 commented on pull request #11460: KAFKA-13425: Optimization of KafkaConsumer#pause semantics

RivenSun2 commented on pull request #11460: URL: https://github.com/apache/kafka/pull/11460#issuecomment-970321543 Hi @dajac please help check this PR when available. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kafka] mimaison commented on pull request #11491: KAFKA-13442: REST API endpoint for fetching a connector's config def

mimaison commented on pull request #11491: URL: https://github.com/apache/kafka/pull/11491#issuecomment-970295989 I want to make a few changes to the KIP before restarting the discussion on the mailing list. Hopefully later on this week (or early next!) -- This is an automated message fr

[jira] [Resolved] (KAFKA-13449) Comment optimization for parameter log.cleaner.delete.retention.ms

[ https://issues.apache.org/jira/browse/KAFKA-13449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-13449. - Fix Version/s: 3.2.0 Resolution: Fixed > Comment optimization for parameter log.cleaner.d

[GitHub] [kafka] dajac commented on a change in pull request #11504: KAFKA-13457: socketChannel in Acceptor#accept is not closed upon IOException

dajac commented on a change in pull request #11504: URL: https://github.com/apache/kafka/pull/11504#discussion_r750266430 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -734,6 +734,10 @@ private[kafka] class Acceptor(val endPoint: EndPoint, va

[GitHub] [kafka] dajac merged pull request #11505: KAFKA-13449: Comment optimization for parameter log.cleaner.delete.retention.ms

dajac merged pull request #11505: URL: https://github.com/apache/kafka/pull/11505 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[jira] [Commented] (KAFKA-13422) Even if the correct username and password are configured, when ClientBroker or KafkaClient tries to establish a SASL connection to ServerBroker, an exception is thrown

[ https://issues.apache.org/jira/browse/KAFKA-13422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17444517#comment-17444517 ] Rajini Sivaram commented on KAFKA-13422: Yes, I remember now, we do take the fir

[GitHub] [kafka] yunfeng79 opened a new pull request #11507: Terminating process due to signal SIGTERM

yunfeng79 opened a new pull request #11507: URL: https://github.com/apache/kafka/pull/11507 CentOS 7.9 kafka_2.13-2.7.0 kafka cluster IP:192.168.0.xx 192.168.0.xx 192.168.0.xx Error log: [2021-11-15 11:13:01,762] INFO Terminating process due to signal SIGTERM

[GitHub] [kafka] yunfeng79 opened a new pull request #11506: kafka_2.10-0.10.0.0 shutdown

yunfeng79 opened a new pull request #11506: URL: https://github.com/apache/kafka/pull/11506 kafka_2.10-0.10.0.0 CentOS Linux release 7.9.2009 [2021-11-15 11:03:20,741] INFO [Group Metadata Manager on Broker 0]: Removed 0 expired offsets in 0 milliseconds. (kafka.coordinator.G

[jira] [Commented] (KAFKA-13422) Even if the correct username and password are configured, when ClientBroker or KafkaClient tries to establish a SASL connection to ServerBroker, an exception is thrown

[ https://issues.apache.org/jira/browse/KAFKA-13422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1795#comment-1795 ] RivenSun commented on KAFKA-13422: --   Hi [~rsivaram] , I think it is appropriate to ad

[jira] [Commented] (KAFKA-13422) Even if the correct username and password are configured, when ClientBroker or KafkaClient tries to establish a SASL connection to ServerBroker, an exception is thrown

[ https://issues.apache.org/jira/browse/KAFKA-13422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1738#comment-1738 ] Rajini Sivaram commented on KAFKA-13422: [~RivenSun] We should have probably add

[GitHub] [kafka] dajac commented on a change in pull request #11502: KAFKA-13071; Deprecate support for changing acls through the authorizer

dajac commented on a change in pull request #11502: URL: https://github.com/apache/kafka/pull/11502#discussion_r750109834 ## File path: core/src/main/scala/kafka/admin/AclCommand.scala ## @@ -499,13 +502,17 @@ object AclCommand extends Logging { .describedAs("command-con

[jira] [Commented] (KAFKA-13422) Even if the correct username and password are configured, when ClientBroker or KafkaClient tries to establish a SASL connection to ServerBroker, an exception is thrown

[ https://issues.apache.org/jira/browse/KAFKA-13422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1724#comment-1724 ] RivenSun commented on KAFKA-13422: -- [~rsivaram] At the same time, do you think this PR

[GitHub] [kafka] viktorsomogyi commented on pull request #11491: KAFKA-13442: REST API endpoint for fetching a connector's config def

viktorsomogyi commented on pull request #11491: URL: https://github.com/apache/kafka/pull/11491#issuecomment-970114887 @mimaison hahh, thanks, I tried looking for an existing KIP but couldn't find any. Wanted to publish this KIP yesterday but it seems like you were faster. I'll keep on com

[jira] [Commented] (KAFKA-13422) Even if the correct username and password are configured, when ClientBroker or KafkaClient tries to establish a SASL connection to ServerBroker, an exception is thrown

[ https://issues.apache.org/jira/browse/KAFKA-13422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1718#comment-1718 ] RivenSun commented on KAFKA-13422: -- [~rsivaram]  Well, this is somewhat different from

[GitHub] [kafka] dajac commented on pull request #11484: KAFKA-13443: Kafka broker exits when OAuth enabled and certain configuration not specified

dajac commented on pull request #11484: URL: https://github.com/apache/kafka/pull/11484#issuecomment-970106901 > > @kirktrue Should we add or extend tests in KafkaConfigTest to cover them? > > They're already present on lines 780 and 781 in `KafkaConfigTest.scala`: > > ```scala

[jira] [Commented] (KAFKA-13422) Even if the correct username and password are configured, when ClientBroker or KafkaClient tries to establish a SASL connection to ServerBroker, an exception is thrown

[ https://issues.apache.org/jira/browse/KAFKA-13422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1710#comment-1710 ] Rajini Sivaram commented on KAFKA-13422: [~RivenSun] Producers, consumers and ot

[GitHub] [kafka] cadonna merged pull request #11494: MINOR: Improve KafkaStreamsTest: testInitializesAndDestroysMetricsReporters

cadonna merged pull request #11494: URL: https://github.com/apache/kafka/pull/11494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[jira] [Comment Edited] (KAFKA-13422) Even if the correct username and password are configured, when ClientBroker or KafkaClient tries to establish a SASL connection to ServerBroker, an exception is t

[ https://issues.apache.org/jira/browse/KAFKA-13422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1705#comment-1705 ] RivenSun edited comment on KAFKA-13422 at 11/16/21, 9:48 AM: -

[GitHub] [kafka] cadonna commented on pull request #11494: MINOR: Improve KafkaStreamsTest: testInitializesAndDestroysMetricsReporters

cadonna commented on pull request #11494: URL: https://github.com/apache/kafka/pull/11494#issuecomment-970099509 Test failures are known to be flaky. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (KAFKA-13422) Even if the correct username and password are configured, when ClientBroker or KafkaClient tries to establish a SASL connection to ServerBroker, an exception is thrown

[ https://issues.apache.org/jira/browse/KAFKA-13422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1705#comment-1705 ] RivenSun commented on KAFKA-13422: -- The RC of this problem is that when KafkaClient est

[jira] [Commented] (KAFKA-13422) Even if the correct username and password are configured, when ClientBroker or KafkaClient tries to establish a SASL connection to ServerBroker, an exception is thrown

[ https://issues.apache.org/jira/browse/KAFKA-13422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1703#comment-1703 ] RivenSun commented on KAFKA-13422: -- Hi [~rsivaram]  Thank you for your reply. I underst

[GitHub] [kafka] dajac merged pull request #11501: MINOR: Fix FetchSessionBenchmark

dajac merged pull request #11501: URL: https://github.com/apache/kafka/pull/11501 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] dajac commented on a change in pull request #11459: KAFKA-13394: Topic IDs should be removed from PartitionFetchState if they are no longer sent by the controller

dajac commented on a change in pull request #11459: URL: https://github.com/apache/kafka/pull/11459#discussion_r750071143 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1401,6 +1401,12 @@ class ReplicaManager(val config: KafkaConfig,

[GitHub] [kafka] ableegoldman commented on pull request #11439: KAFKA-13406: skip assignment validation for built-in cooperativeStickyAssignor

ableegoldman commented on pull request #11439: URL: https://github.com/apache/kafka/pull/11439#issuecomment-970083959 Thanks! Pushed to 3.1 as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Commented] (KAFKA-13422) Even if the correct username and password are configured, when ClientBroker or KafkaClient tries to establish a SASL connection to ServerBroker, an exception is thrown

[ https://issues.apache.org/jira/browse/KAFKA-13422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17444396#comment-17444396 ] Rajini Sivaram commented on KAFKA-13422: [~RivenSun] The recommended way for con

[GitHub] [kafka] dajac commented on pull request #11439: KAFKA-13406: skip assignment validation for built-in cooperativeStickyAssignor

dajac commented on pull request #11439: URL: https://github.com/apache/kafka/pull/11439#issuecomment-970044277 @ableegoldman Approved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[jira] [Commented] (KAFKA-13444) Fix OAuthCompatibilityTool help and add SSL options

[ https://issues.apache.org/jira/browse/KAFKA-13444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17444360#comment-17444360 ] David Jacot commented on KAFKA-13444: - [~kirktrue] Yes. It makes sense to include it

[GitHub] [kafka] RivenSun2 commented on pull request #11505: KAFKA-13449: Comment optimization for parameter log.cleaner.delete.retention.ms

RivenSun2 commented on pull request #11505: URL: https://github.com/apache/kafka/pull/11505#issuecomment-970021835 Hi @guozhangwang @hachikuji please help check this PR when available. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, pl