[GitHub] [kafka] showuon commented on pull request #11451: KAFKA-13419: Only reset generation ID when ILLEGAL_GENERATION error

2021-12-01 Thread GitBox
showuon commented on pull request #11451: URL: https://github.com/apache/kafka/pull/11451#issuecomment-984376524 @dajac , please have a 2nd review when available. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] dajac commented on pull request #11456: KAFKA-13351: Add possibility to write kafka headers in Kafka Console Producer

2021-12-01 Thread GitBox
dajac commented on pull request #11456: URL: https://github.com/apache/kafka/pull/11456#issuecomment-984375239 @florin-akermann Sorry for the delay... Your PR is still in my review queue. I've been quite busy with the AK 3.1 release (blockers, validation, and co). -- This is an

[jira] [Commented] (KAFKA-13474) Regression in dynamic update of broker client-side SSL factory

2021-12-01 Thread Igor Shipenkov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17452200#comment-17452200 ] Igor Shipenkov commented on KAFKA-13474: Well, I tried version 3.0.0 and I can reproduce this

[jira] [Updated] (KAFKA-13474) Regression in dynamic update of broker client-side SSL factory

2021-12-01 Thread Igor Shipenkov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Shipenkov updated KAFKA-13474: --- Affects Version/s: 3.0.0 > Regression in dynamic update of broker client-side SSL factory >

[GitHub] [kafka] kowshik commented on a change in pull request #11345: Allow empty last segment to have missing offset index during recovery

2021-12-01 Thread GitBox
kowshik commented on a change in pull request #11345: URL: https://github.com/apache/kafka/pull/11345#discussion_r760752732 ## File path: core/src/main/scala/kafka/log/UnifiedLog.scala ## @@ -1498,28 +1498,44 @@ class UnifiedLog(@volatile var logStartOffset: Long,

[GitHub] [kafka] kowshik commented on a change in pull request #11345: Allow empty last segment to have missing offset index during recovery

2021-12-01 Thread GitBox
kowshik commented on a change in pull request #11345: URL: https://github.com/apache/kafka/pull/11345#discussion_r760752732 ## File path: core/src/main/scala/kafka/log/UnifiedLog.scala ## @@ -1498,28 +1498,44 @@ class UnifiedLog(@volatile var logStartOffset: Long,

[jira] [Updated] (KAFKA-13474) Regression in dynamic update of broker client-side SSL factory

2021-12-01 Thread Igor Shipenkov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Shipenkov updated KAFKA-13474: --- Affects Version/s: 2.8.1 > Regression in dynamic update of broker client-side SSL factory >

[jira] [Commented] (KAFKA-13474) Regression in dynamic update of broker client-side SSL factory

2021-12-01 Thread Igor Shipenkov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17452158#comment-17452158 ] Igor Shipenkov commented on KAFKA-13474: Tried to reproduce problen on kafka 2.8.1. And problem

[jira] [Commented] (KAFKA-13281) Support upgrades with dynamic addition/removal of disjoint "named" topologies

2021-12-01 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17452134#comment-17452134 ] Luke Chen commented on KAFKA-13281: --- [~wcarlson5] , thank you!

[jira] [Commented] (KAFKA-12559) Add a top-level Streams config for bounding off-heap memory

2021-12-01 Thread Aditya Upadhyaya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17452128#comment-17452128 ] Aditya Upadhyaya commented on KAFKA-12559: -- [~ableegoldman]: I have a fair bit of idea on what

[GitHub] [kafka] showuon commented on pull request #8846: KAFKA-9800: [KIP-580] Client Exponential Backoff Implementation

2021-12-01 Thread GitBox
showuon commented on pull request #8846: URL: https://github.com/apache/kafka/pull/8846#issuecomment-984230083 @ctan888, Sorry again, but I'd really like to have this KIP to get implemented in Kafka. I've been waiting for your reply for more than a month (from github and direct email).

[GitHub] [kafka] mjsax commented on a change in pull request #11455: KAFKA-13423: GlobalThread should not log ERROR on clean shutdown

2021-12-01 Thread GitBox
mjsax commented on a change in pull request #11455: URL: https://github.com/apache/kafka/pull/11455#discussion_r760703870 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/GlobalKTableIntegrationTest.java ## @@ -337,7 +341,18 @@ public void

[jira] [Commented] (KAFKA-13458) The Stream is not able to consume from some of the partitions

2021-12-01 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17452111#comment-17452111 ] Matthias J. Sax commented on KAFKA-13458: - [~marathed] You are using the Java consumer directly?

[GitHub] [kafka] HyunSangHan commented on a change in pull request #11418: MINOR: Write log differently according to the size of missingListenerPartitions

2021-12-01 Thread GitBox
HyunSangHan commented on a change in pull request #11418: URL: https://github.com/apache/kafka/pull/11418#discussion_r760666349 ## File path: clients/src/main/java/org/apache/kafka/clients/NetworkClient.java ## @@ -1080,8 +1080,13 @@ public void

[GitHub] [kafka] ccding commented on a change in pull request #11345: Allow empty last segment to have missing offset index during recovery

2021-12-01 Thread GitBox
ccding commented on a change in pull request #11345: URL: https://github.com/apache/kafka/pull/11345#discussion_r760640970 ## File path: core/src/main/scala/kafka/log/UnifiedLog.scala ## @@ -1498,28 +1498,44 @@ class UnifiedLog(@volatile var logStartOffset: Long,

[GitHub] [kafka] hachikuji commented on a change in pull request #11503: KAFKA-13456: Tighten KRaft config checks/constraints

2021-12-01 Thread GitBox
hachikuji commented on a change in pull request #11503: URL: https://github.com/apache/kafka/pull/11503#discussion_r760636630 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -2018,12 +2015,104 @@ class KafkaConfig private(doLog: Boolean, val props:

[GitHub] [kafka] hachikuji commented on a change in pull request #11503: KAFKA-13456: Tighten KRaft config checks/constraints

2021-12-01 Thread GitBox
hachikuji commented on a change in pull request #11503: URL: https://github.com/apache/kafka/pull/11503#discussion_r760634593 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -1960,9 +1962,16 @@ class KafkaConfig private(doLog: Boolean, val props:

[GitHub] [kafka] rondagostino commented on a change in pull request #11503: KAFKA-13456: Tighten KRaft config checks/constraints

2021-12-01 Thread GitBox
rondagostino commented on a change in pull request #11503: URL: https://github.com/apache/kafka/pull/11503#discussion_r760632090 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -1960,9 +1962,16 @@ class KafkaConfig private(doLog: Boolean, val props:

[GitHub] [kafka] cmccabe commented on a change in pull request #11503: KAFKA-13456: Tighten KRaft config checks/constraints

2021-12-01 Thread GitBox
cmccabe commented on a change in pull request #11503: URL: https://github.com/apache/kafka/pull/11503#discussion_r760628258 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -1960,9 +1962,16 @@ class KafkaConfig private(doLog: Boolean, val props:

[GitHub] [kafka] rondagostino commented on a change in pull request #11503: KAFKA-13456: Tighten KRaft config checks/constraints

2021-12-01 Thread GitBox
rondagostino commented on a change in pull request #11503: URL: https://github.com/apache/kafka/pull/11503#discussion_r760626984 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -2018,12 +2015,104 @@ class KafkaConfig private(doLog: Boolean, val props:

[GitHub] [kafka] rondagostino commented on a change in pull request #11503: KAFKA-13456: Tighten KRaft config checks/constraints

2021-12-01 Thread GitBox
rondagostino commented on a change in pull request #11503: URL: https://github.com/apache/kafka/pull/11503#discussion_r760615477 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -1960,9 +1962,16 @@ class KafkaConfig private(doLog: Boolean, val props:

[jira] [Commented] (KAFKA-12377) Flaky Test SaslAuthenticatorTest#testSslClientAuthRequiredForSaslSslListener

2021-12-01 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17452038#comment-17452038 ] Matthias J. Sax commented on KAFKA-12377: - And one more. > Flaky Test

[GitHub] [kafka] hachikuji commented on a change in pull request #11345: Allow empty last segment to have missing offset index during recovery

2021-12-01 Thread GitBox
hachikuji commented on a change in pull request #11345: URL: https://github.com/apache/kafka/pull/11345#discussion_r760521586 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -443,7 +443,7 @@ private void onBecomeLeader(long currentTimeMs) {

[GitHub] [kafka] lkokhreidze commented on pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2021-12-01 Thread GitBox
lkokhreidze commented on pull request #10851: URL: https://github.com/apache/kafka/pull/10851#issuecomment-983959899 Hi @cadonna , Will you have time to look at this PR again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] junrao commented on a change in pull request #11345: Allow empty last segment to have missing offset index during recovery

2021-12-01 Thread GitBox
junrao commented on a change in pull request #11345: URL: https://github.com/apache/kafka/pull/11345#discussion_r760483493 ## File path: core/src/main/scala/kafka/log/UnifiedLog.scala ## @@ -1498,28 +1498,44 @@ class UnifiedLog(@volatile var logStartOffset: Long,

[jira] [Commented] (KAFKA-12377) Flaky Test SaslAuthenticatorTest#testSslClientAuthRequiredForSaslSslListener

2021-12-01 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451962#comment-17451962 ] Matthias J. Sax commented on KAFKA-12377: - And one more (different stack trace)

[jira] [Commented] (KAFKA-12377) Flaky Test SaslAuthenticatorTest#testSslClientAuthRequiredForSaslSslListener

2021-12-01 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451961#comment-17451961 ] Matthias J. Sax commented on KAFKA-12377: - Failed again. > Flaky Test

[jira] [Commented] (KAFKA-13281) Support upgrades with dynamic addition/removal of disjoint "named" topologies

2021-12-01 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451957#comment-17451957 ] Walker Carlson commented on KAFKA-13281: [~showuon] We haven't drafted a KIP yet so I think it

[GitHub] [kafka] vvcephei commented on pull request #11557: KAFKA-13491: IQv2 framework

2021-12-01 Thread GitBox
vvcephei commented on pull request #11557: URL: https://github.com/apache/kafka/pull/11557#issuecomment-983926936 Rebased to resolve conflicts with #11541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Closed] (KAFKA-13498) IQv2: Track Position in remaining stores

2021-12-01 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler closed KAFKA-13498. > IQv2: Track Position in remaining stores > > >

[jira] [Resolved] (KAFKA-13498) IQv2: Track Position in remaining stores

2021-12-01 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler resolved KAFKA-13498. -- Resolution: Fixed > IQv2: Track Position in remaining stores >

[GitHub] [kafka] vvcephei merged pull request #11541: KAFKA-13498: keeping track of latest seen position in different state stores

2021-12-01 Thread GitBox
vvcephei merged pull request #11541: URL: https://github.com/apache/kafka/pull/11541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] vvcephei commented on a change in pull request #11541: KAFKA-13498: keeping track of latest seen position in different state stores

2021-12-01 Thread GitBox
vvcephei commented on a change in pull request #11541: URL: https://github.com/apache/kafka/pull/11541#discussion_r760433645 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractSessionBytesStoreTest.java ## @@ -77,7 +77,7 @@ private

[GitHub] [kafka] vvcephei commented on pull request #11541: KAFKA-13498: keeping track of latest seen position in different state stores

2021-12-01 Thread GitBox
vvcephei commented on pull request #11541: URL: https://github.com/apache/kafka/pull/11541#issuecomment-983881235 The test failures were known-flaky, unrelated tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Assigned] (KAFKA-13498) IQv2: Track Position in remaining stores

2021-12-01 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler reassigned KAFKA-13498: Assignee: Patrick Stuedi > IQv2: Track Position in remaining stores >

[jira] [Created] (KAFKA-13498) IQv2: Track Position in remaining stores

2021-12-01 Thread John Roesler (Jira)
John Roesler created KAFKA-13498: Summary: IQv2: Track Position in remaining stores Key: KAFKA-13498 URL: https://issues.apache.org/jira/browse/KAFKA-13498 Project: Kafka Issue Type:

[GitHub] [kafka] jsancio edited a comment on pull request #11556: MINOR: Pass along compression type to snapshot writer

2021-12-01 Thread GitBox
jsancio edited a comment on pull request #11556: URL: https://github.com/apache/kafka/pull/11556#issuecomment-982933214 This hasn't cause further issues because we haven't fully implemented compression for KRaft. Created https://issues.apache.org/jira/browse/KAFKA-13489 track this and add

[GitHub] [kafka] florin-akermann commented on pull request #11456: KAFKA-13351: Add possibility to write kafka headers in Kafka Console Producer

2021-12-01 Thread GitBox
florin-akermann commented on pull request #11456: URL: https://github.com/apache/kafka/pull/11456#issuecomment-983876161 @dajac i dare to nag :) or shall I nag on d...@kafka.apache.org instead? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] mimaison commented on pull request #11560: KAFKA-7589: Allow configuring network threads per listener

2021-12-01 Thread GitBox
mimaison commented on pull request #11560: URL: https://github.com/apache/kafka/pull/11560#issuecomment-983865906 cc @rajinisivaram @tombentley @dajac -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Assigned] (KAFKA-13496) Add reason to LeaveGroupRequest

2021-12-01 Thread Jeff Kim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Kim reassigned KAFKA-13496: Assignee: Jeff Kim (was: David Jacot) > Add reason to LeaveGroupRequest >

[jira] [Assigned] (KAFKA-13495) Add reason to JoinGroupRequest

2021-12-01 Thread Jeff Kim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Kim reassigned KAFKA-13495: Assignee: Jeff Kim (was: David Jacot) > Add reason to JoinGroupRequest >

[jira] [Assigned] (KAFKA-13451) Add reason to JoinGroupRequest and LeaveGroupRequest

2021-12-01 Thread Jeff Kim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Kim reassigned KAFKA-13451: Assignee: Jeff Kim (was: David Jacot) > Add reason to JoinGroupRequest and LeaveGroupRequest >

[GitHub] [kafka] mimaison opened a new pull request #11560: KAFKA-7589: Allow configuring network threads per listener

2021-12-01 Thread GitBox
mimaison opened a new pull request #11560: URL: https://github.com/apache/kafka/pull/11560 Implements KIP-788. The number of network threads can be set per listener using the following syntax: listener.name..num.network.threads= It's currently a draft PR, there are still a bunch

[GitHub] [kafka] vvcephei commented on a change in pull request #11557: KAFKA-13491: IQv2 framework

2021-12-01 Thread GitBox
vvcephei commented on a change in pull request #11557: URL: https://github.com/apache/kafka/pull/11557#discussion_r760406552 ## File path: streams/src/main/java/org/apache/kafka/streams/query/Position.java ## @@ -0,0 +1,178 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] vvcephei commented on a change in pull request #11557: KAFKA-13491: IQv2 framework

2021-12-01 Thread GitBox
vvcephei commented on a change in pull request #11557: URL: https://github.com/apache/kafka/pull/11557#discussion_r760404989 ## File path: streams/src/main/java/org/apache/kafka/streams/query/Position.java ## @@ -0,0 +1,178 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] vvcephei commented on a change in pull request #11557: KAFKA-13491: IQv2 framework

2021-12-01 Thread GitBox
vvcephei commented on a change in pull request #11557: URL: https://github.com/apache/kafka/pull/11557#discussion_r760395779 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -1716,4 +1725,100 @@ protected void processStreamThread(final

[jira] [Commented] (KAFKA-13435) Group won't consume partitions added after static member restart

2021-12-01 Thread Ryan Leslie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451922#comment-17451922 ] Ryan Leslie commented on KAFKA-13435: - [~dajac] Yes, I was going to suggest something similar to

[GitHub] [kafka] vamossagar12 commented on a change in pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

2021-12-01 Thread GitBox
vamossagar12 commented on a change in pull request #11433: URL: https://github.com/apache/kafka/pull/11433#discussion_r760369366 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -292,12 +327,20 @@ public void

[GitHub] [kafka] vamossagar12 commented on pull request #11211: KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…

2021-12-01 Thread GitBox
vamossagar12 commented on pull request #11211: URL: https://github.com/apache/kafka/pull/11211#issuecomment-983825844 > @mjsax @ableegoldman could you chime in here? > @mjsax @ableegoldman could you chime in here? hi.. bumping this thread again.. -- This is an

[GitHub] [kafka] vamossagar12 commented on a change in pull request #11424: KAFKA-13152: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2021-12-01 Thread GitBox
vamossagar12 commented on a change in pull request #11424: URL: https://github.com/apache/kafka/pull/11424#discussion_r760368431 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/TaskMetrics.java ## @@ -128,6 +131,22 @@ public static

[jira] [Commented] (KAFKA-6995) Make config "internal.leave.group.on.close" public

2021-12-01 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-6995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451907#comment-17451907 ] Jørgen commented on KAFKA-6995: --- Are there any other ways to proactively leave the group when a KS stops

[jira] [Created] (KAFKA-13497) Debug Log RegexRouter transform

2021-12-01 Thread Spencer Carlson (Jira)
Spencer Carlson created KAFKA-13497: --- Summary: Debug Log RegexRouter transform Key: KAFKA-13497 URL: https://issues.apache.org/jira/browse/KAFKA-13497 Project: Kafka Issue Type:

[GitHub] [kafka] dajac commented on pull request #11539: MINOR: Update doc for 3.1

2021-12-01 Thread GitBox
dajac commented on pull request #11539: URL: https://github.com/apache/kafka/pull/11539#issuecomment-983787420 @showuon Thanks, good catch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (KAFKA-13435) Group won't consume partitions added after static member restart

2021-12-01 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451896#comment-17451896 ] David Jacot commented on KAFKA-13435: - I have put a bit more thoughts into this and it seems that we

[jira] [Comment Edited] (KAFKA-12703) Unencrypted PEM files can't be loaded

2021-12-01 Thread Ville Valtonen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451134#comment-17451134 ] Ville Valtonen edited comment on KAFKA-12703 at 12/1/21, 3:44 PM: --

[GitHub] [kafka] C0urante commented on a change in pull request #10910: KAFKA-12965 - Graceful clean up of task error metrics

2021-12-01 Thread GitBox
C0urante commented on a change in pull request #10910: URL: https://github.com/apache/kafka/pull/10910#discussion_r760307980 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java ## @@ -113,6 +113,7 @@ private final ConcurrentMap

[GitHub] [kafka] dajac opened a new pull request #11559: KAFKA-13435; Group won't consume partitions added after static member restart

2021-12-01 Thread GitBox
dajac opened a new pull request #11559: URL: https://github.com/apache/kafka/pull/11559 TODO ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including

[GitHub] [kafka] vpapavas commented on a change in pull request #11557: KAFKA-13491: IQv2 framework

2021-12-01 Thread GitBox
vpapavas commented on a change in pull request #11557: URL: https://github.com/apache/kafka/pull/11557#discussion_r760254988 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/TimestampedKeyValueStoreBuilder.java ## @@ -184,6 +187,20 @@ public

[GitHub] [kafka] vijaykriishna opened a new pull request #11558: KAFKA-13323 Fixed variable name in KafkaConsumer

2021-12-01 Thread GitBox
vijaykriishna opened a new pull request #11558: URL: https://github.com/apache/kafka/pull/11558 KAFKA-13323 Fixed variable name in KafkaConsumer ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI

[GitHub] [kafka] vpapavas commented on a change in pull request #11557: KAFKA-13491: IQv2 framework

2021-12-01 Thread GitBox
vpapavas commented on a change in pull request #11557: URL: https://github.com/apache/kafka/pull/11557#discussion_r760231430 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -1716,4 +1725,100 @@ protected void processStreamThread(final

[GitHub] [kafka] vpapavas commented on a change in pull request #11557: KAFKA-13491: IQv2 framework

2021-12-01 Thread GitBox
vpapavas commented on a change in pull request #11557: URL: https://github.com/apache/kafka/pull/11557#discussion_r760233137 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -1716,4 +1725,100 @@ protected void processStreamThread(final

[GitHub] [kafka] patrickstuedi commented on a change in pull request #11557: KAFKA-13491: IQv2 framework

2021-12-01 Thread GitBox
patrickstuedi commented on a change in pull request #11557: URL: https://github.com/apache/kafka/pull/11557#discussion_r76021 ## File path: streams/src/main/java/org/apache/kafka/streams/query/Position.java ## @@ -0,0 +1,178 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] vpapavas commented on a change in pull request #11557: KAFKA-13491: IQv2 framework

2021-12-01 Thread GitBox
vpapavas commented on a change in pull request #11557: URL: https://github.com/apache/kafka/pull/11557#discussion_r760231430 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -1716,4 +1725,100 @@ protected void processStreamThread(final

[GitHub] [kafka] patrickstuedi commented on a change in pull request #11557: KAFKA-13491: IQv2 framework

2021-12-01 Thread GitBox
patrickstuedi commented on a change in pull request #11557: URL: https://github.com/apache/kafka/pull/11557#discussion_r76021 ## File path: streams/src/main/java/org/apache/kafka/streams/query/Position.java ## @@ -0,0 +1,178 @@ +/* + * Licensed to the Apache Software

[jira] [Created] (KAFKA-13496) Add reason to LeaveGroupRequest

2021-12-01 Thread David Jacot (Jira)
David Jacot created KAFKA-13496: --- Summary: Add reason to LeaveGroupRequest Key: KAFKA-13496 URL: https://issues.apache.org/jira/browse/KAFKA-13496 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-13495) Add reason to JoinGroupRequest

2021-12-01 Thread David Jacot (Jira)
David Jacot created KAFKA-13495: --- Summary: Add reason to JoinGroupRequest Key: KAFKA-13495 URL: https://issues.apache.org/jira/browse/KAFKA-13495 Project: Kafka Issue Type: Sub-task

[jira] [Updated] (KAFKA-13451) Add reason to JoinGroupRequest and LeaveGroupRequest

2021-12-01 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-13451: Summary: Add reason to JoinGroupRequest and LeaveGroupRequest (was: Add reason to

[GitHub] [kafka] vpapavas commented on a change in pull request #11513: feat: Write offset position to changelog

2021-12-01 Thread GitBox
vpapavas commented on a change in pull request #11513: URL: https://github.com/apache/kafka/pull/11513#discussion_r760111821 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/ChangeLoggingSessionBytesStore.java ## @@ -79,15 +94,21 @@ public void

[GitHub] [kafka] vpapavas commented on a change in pull request #11513: feat: Write offset position to changelog

2021-12-01 Thread GitBox
vpapavas commented on a change in pull request #11513: URL: https://github.com/apache/kafka/pull/11513#discussion_r760121526 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/Position.java ## @@ -27,6 +30,8 @@ import java.util.function.BiConsumer;

[GitHub] [kafka] vpapavas commented on a change in pull request #11513: feat: Write offset position to changelog

2021-12-01 Thread GitBox
vpapavas commented on a change in pull request #11513: URL: https://github.com/apache/kafka/pull/11513#discussion_r760111821 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/ChangeLoggingSessionBytesStore.java ## @@ -79,15 +94,21 @@ public void

[GitHub] [kafka] vpapavas commented on a change in pull request #11513: feat: Write offset position to changelog

2021-12-01 Thread GitBox
vpapavas commented on a change in pull request #11513: URL: https://github.com/apache/kafka/pull/11513#discussion_r760111821 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/ChangeLoggingSessionBytesStore.java ## @@ -79,15 +94,21 @@ public void

[GitHub] [kafka] vpapavas commented on a change in pull request #11513: feat: Write offset position to changelog

2021-12-01 Thread GitBox
vpapavas commented on a change in pull request #11513: URL: https://github.com/apache/kafka/pull/11513#discussion_r755099262 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/CachingKeyValueStore.java ## @@ -155,6 +169,11 @@ private void

[GitHub] [kafka] vpapavas commented on a change in pull request #11513: feat: Write offset position to changelog

2021-12-01 Thread GitBox
vpapavas commented on a change in pull request #11513: URL: https://github.com/apache/kafka/pull/11513#discussion_r755096395 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ChangelogRecordDeserializationHelper.java ## @@ -0,0 +1,38 @@ +/* + *

[GitHub] [kafka] vpapavas commented on a change in pull request #11513: feat: Write offset position to changelog

2021-12-01 Thread GitBox
vpapavas commented on a change in pull request #11513: URL: https://github.com/apache/kafka/pull/11513#discussion_r755096395 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ChangelogRecordDeserializationHelper.java ## @@ -0,0 +1,38 @@ +/* + *

[GitHub] [kafka] vpapavas commented on a change in pull request #11513: feat: Write offset position to changelog

2021-12-01 Thread GitBox
vpapavas commented on a change in pull request #11513: URL: https://github.com/apache/kafka/pull/11513#discussion_r760099865 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -947,6 +947,11 @@ // Private API used to control the emit

[jira] [Created] (KAFKA-13494) Session and Window Queries for IQv2

2021-12-01 Thread Patrick Stuedi (Jira)
Patrick Stuedi created KAFKA-13494: -- Summary: Session and Window Queries for IQv2 Key: KAFKA-13494 URL: https://issues.apache.org/jira/browse/KAFKA-13494 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-13493) Session and Window Queries for IQv2

2021-12-01 Thread Patrick Stuedi (Jira)
Patrick Stuedi created KAFKA-13493: -- Summary: Session and Window Queries for IQv2 Key: KAFKA-13493 URL: https://issues.apache.org/jira/browse/KAFKA-13493 Project: Kafka Issue Type:

[GitHub] [kafka] vpapavas commented on a change in pull request #11541: chore: keeping track of latest seen position in different state stores

2021-12-01 Thread GitBox
vpapavas commented on a change in pull request #11541: URL: https://github.com/apache/kafka/pull/11541#discussion_r760015599 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractSessionBytesStoreTest.java ## @@ -77,7 +77,7 @@ private

[GitHub] [kafka] vpapavas commented on a change in pull request #11541: chore: keeping track of latest seen position in different state stores

2021-12-01 Thread GitBox
vpapavas commented on a change in pull request #11541: URL: https://github.com/apache/kafka/pull/11541#discussion_r760015271 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/InMemorySessionStoreTest.java ## @@ -83,4 +88,31 @@ public void

[jira] [Commented] (KAFKA-13435) Group won't consume partitions added after static member restart

2021-12-01 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451661#comment-17451661 ] David Jacot commented on KAFKA-13435: - [~rleslie] I understand your point. Manually restarting

[GitHub] [kafka] kowshik commented on a change in pull request #11345: Allow empty last segment to have missing offset index during recovery

2021-12-01 Thread GitBox
kowshik commented on a change in pull request #11345: URL: https://github.com/apache/kafka/pull/11345#discussion_r759942807 ## File path: core/src/main/scala/kafka/log/UnifiedLog.scala ## @@ -1498,25 +1498,25 @@ class UnifiedLog(@volatile var logStartOffset: Long,