RivenSun2 commented on pull request #11800:
URL: https://github.com/apache/kafka/pull/11800#issuecomment-1051822201
@showuon I totally agree with you now. It was I forgot to modify a code that
caused it to not meet our expectations.
In the methods `AbstractConfig#ignore(String key)` and
RivenSun2 edited a comment on pull request #11800:
URL: https://github.com/apache/kafka/pull/11800#issuecomment-1051822201
@showuon I totally agree with you now. It was I forgot to modify a code that
caused it to not meet our expectations.
In the methods `AbstractConfig#ignore(String key
showuon commented on a change in pull request #11777:
URL: https://github.com/apache/kafka/pull/11777#discussion_r815282192
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/internals/FenceProducersHandler.java
##
@@ -76,6 +75,10 @@ public String apiName() {
RivenSun2 edited a comment on pull request #11800:
URL: https://github.com/apache/kafka/pull/11800#issuecomment-1051822201
@showuon I totally agree with you now. It was I forgot to modify a code that
caused it to not meet our expectations.
In the methods `AbstractConfig#ignore(String key
RivenSun2 commented on pull request #11800:
URL: https://github.com/apache/kafka/pull/11800#issuecomment-1051834698
Or we add an instance variable `AbstractConfig.unknownKeys`, we can complete
the assignment to the variable `unknownKeys` when `AbstractConfig` is
initialized.
`unknownKey
showuon commented on pull request #11800:
URL: https://github.com/apache/kafka/pull/11800#issuecomment-1051835536
> if (!unknown().contains(key)) {
used.add(key);
}
The reason we call `ignore` is because we indeed **use** this config key. In
your logic, it'll make the **use
RivenSun2 commented on pull request #11800:
URL: https://github.com/apache/kafka/pull/11800#issuecomment-1051842848
@showuon
okay, I agree with you. This is probably better than what I said above.
I will resubmit later, thanks for your suggestion.
--
This is an automated message fr
showuon commented on pull request #11800:
URL: https://github.com/apache/kafka/pull/11800#issuecomment-1051843328
> unknownKeys = originals.keySet().removeAll(values.keySet())
unknownKeys should not be changed after AbstractConfig is initialized.
That looks good, but I think that d
RivenSun2 commented on pull request #11800:
URL: https://github.com/apache/kafka/pull/11800#issuecomment-1051847026
@showuon
I agree with you now, thank you for your suggestion.
Thanks again.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
kowshik opened a new pull request #11814:
URL: https://github.com/apache/kafka/pull/11814
**Issue:**
Imagine a scenario where two threads T1 and T2 are inside
`UnifiedLog.flush()` **concurrently**:
* `KafkaScheduler` thread **T1** -> The periodic work calls
`LogManager.flushDirtyLog
kowshik commented on pull request #11814:
URL: https://github.com/apache/kafka/pull/11814#issuecomment-1051910771
cc @junrao @lbradstreet for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kowshik opened a new pull request #11815:
URL: https://github.com/apache/kafka/pull/11815
The `mutable` flag in `FileRecords` doesn't appear to be necessary. I've
removed it in this PR to help simplify the code a bit.
**Tests:**
I'm relying on existing tests.
--
This is an auto
kowshik commented on pull request #11815:
URL: https://github.com/apache/kafka/pull/11815#issuecomment-1051959562
cc @junrao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
showuon commented on pull request #11804:
URL: https://github.com/apache/kafka/pull/11804#issuecomment-1052117060
@lihaosky , Failed tests are flaky and unrelated. Also failed in trunk
sometimes:
```
Build / JDK 11 and Scala 2.13 /
org.apache.kafka.connect.integration.RebalanceSource
showuon commented on pull request #11777:
URL: https://github.com/apache/kafka/pull/11777#issuecomment-1052117206
I'll wait for a while to see if there are other people want to have another
review. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the mes
GauthamM-official opened a new pull request #11816:
URL: https://github.com/apache/kafka/pull/11816
…r windows.
`kafka-storage.sh` was added as part of pull request
[#10043](https://github.com/apache/kafka/pull/10043). But in windows, the
`.bat` file was not included and hence cause
[
https://issues.apache.org/jira/browse/KAFKA-13694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498442#comment-17498442
]
RivenSun commented on KAFKA-13694:
--
Hi [~guozhang]
Sorry, the version of KafkaProduce
[
https://issues.apache.org/jira/browse/KAFKA-13694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498442#comment-17498442
]
RivenSun edited comment on KAFKA-13694 at 2/26/22, 1:09 PM:
[
https://issues.apache.org/jira/browse/KAFKA-13694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498442#comment-17498442
]
RivenSun edited comment on KAFKA-13694 at 2/26/22, 1:11 PM:
wcarlson5 commented on a change in pull request #11813:
URL: https://github.com/apache/kafka/pull/11813#discussion_r815315400
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/KafkaStreamsNamedTopologyWrapper.java
##
@@ -230,53 +233
wcarlson5 commented on a change in pull request #11812:
URL: https://github.com/apache/kafka/pull/11812#discussion_r815316387
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskExecutionMetadata.java
##
@@ -73,11 +73,11 @@ public boolean canPr
hachikuji merged pull request #11807:
URL: https://github.com/apache/kafka/pull/11807
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubsc
[
https://issues.apache.org/jira/browse/KAFKA-13697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-13697.
-
Resolution: Fixed
> KRaft authorizer should handle AclOperation.ALL
> --
[
https://issues.apache.org/jira/browse/KAFKA-13698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-13698.
-
Resolution: Fixed
> KRaft authorizer should check host address instead of name
> ---
[
https://issues.apache.org/jira/browse/KAFKA-13694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498491#comment-17498491
]
Guozhang Wang commented on KAFKA-13694:
---
Thanks [~RivenSun].
It looks like we are
[
https://issues.apache.org/jira/browse/KAFKA-12486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-12486:
--
Labels: new-streams-runtime-should-fix (was: )
> Utilize HighAvailabilityTaskAssignor to avoi
[
https://issues.apache.org/jira/browse/KAFKA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-1:
--
Labels: new-streams-runtime-should-fix (was: )
> Optimize condition for triggering rebalance
guozhangwang commented on a change in pull request #11787:
URL: https://github.com/apache/kafka/pull/11787#discussion_r815372448
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/ErrorHandlingIntegrationTest.java
##
@@ -0,0 +1,165 @@
+/*
+ * Licensed to
[
https://issues.apache.org/jira/browse/KAFKA-13694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498517#comment-17498517
]
RivenSun commented on KAFKA-13694:
--
Hi [~guozhang]
Thanks for your reply, I agree wit
LiamClarkeNZ opened a new pull request #11817:
URL: https://github.com/apache/kafka/pull/11817
(Sub task of KAFKA-7438)
Replace all usages of Powermock and Easymock in connect.runtime.WorkerTest
with Mockito. One bit of Powermock functionality could not be replicated with
Mockito -
showuon commented on a change in pull request #7898:
URL: https://github.com/apache/kafka/pull/7898#discussion_r815384279
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/resources/LoggingResource.java
##
@@ -60,67 +66,60 @@
@GET
@Pat
C0urante commented on a change in pull request #11773:
URL: https://github.com/apache/kafka/pull/11773#discussion_r812440623
##
File path:
connect/api/src/main/java/org/apache/kafka/connect/source/SourceConnector.java
##
@@ -28,4 +30,46 @@
protected SourceConnectorContext
32 matches
Mail list logo
