ableegoldman commented on pull request #11857:
URL: https://github.com/apache/kafka/pull/11857#issuecomment-1061503765
All test failures are unrelated, going to merge this now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/KAFKA-13718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-13718:
--
Description:
Following the quickstart guide[1], when describing the topic just created with
default
[
https://issues.apache.org/jira/browse/KAFKA-13718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-13718:
--
Summary: kafka-topics describe topic with default config will show
`segment.bytes` overridden config
[
https://issues.apache.org/jira/browse/KAFKA-13718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-13718:
--
Description:
Following the quickstart guide[1], when describing the topic just created with
default
[
https://issues.apache.org/jira/browse/KAFKA-13718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-13718:
--
Description:
Following the quickstart guide[1], when describing the topic just created with
default
[
https://issues.apache.org/jira/browse/KAFKA-13718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-13718:
--
Description:
Following the quickstart guide[1], when describing the topic just created with
default
Luke Chen created KAFKA-13718:
-
Summary: kafka-topics create with default config will show
`segment.bytes` overridden config
Key: KAFKA-13718
URL: https://issues.apache.org/jira/browse/KAFKA-13718
showuon merged pull request #11853:
URL: https://github.com/apache/kafka/pull/11853
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dajac commented on a change in pull request #11864:
URL: https://github.com/apache/kafka/pull/11864#discussion_r821354458
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -1003,6 +1003,9 @@ void
lihaosky commented on pull request #11820:
URL: https://github.com/apache/kafka/pull/11820#issuecomment-1061406867
@suhas-satish, I put restoration logic to first PR:
https://github.com/apache/kafka/pull/11802 after refactoring first PR.
--
This is an automated message from the Apache
vincent81jiang opened a new pull request #11864:
URL: https://github.com/apache/kafka/pull/11864
If offsets is empty, no need to lookup coordinator. doCommitOffsetsAsync
call will be completed locally.
Issue description: https://issues.apache.org/jira/browse/KAFKA-13717
Vincent Jiang created KAFKA-13717:
-
Summary: KafkaConsumer.close throws authorization exception even
when commit offsets is empty
Key: KAFKA-13717
URL: https://issues.apache.org/jira/browse/KAFKA-13717
[
https://issues.apache.org/jira/browse/KAFKA-13716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-13716:
--
Summary: add tests for `DeleteRecordsCommand` class (was: add tests for
`DeleteRecordsCommand`)
>
[
https://issues.apache.org/jira/browse/KAFKA-13716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-13716:
--
Labels: Newbie newbie (was: )
> add tests for `DeleteRecordsCommand`
>
Luke Chen created KAFKA-13716:
-
Summary: add tests for `DeleteRecordsCommand`
Key: KAFKA-13716
URL: https://issues.apache.org/jira/browse/KAFKA-13716
Project: Kafka
Issue Type: Test
showuon commented on pull request #11863:
URL: https://github.com/apache/kafka/pull/11863#issuecomment-1061359965
Note: reverting https://github.com/apache/kafka/pull/11800.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
Luke Chen created KAFKA-13715:
-
Summary: Add "generation" field into consumer protocol
Key: KAFKA-13715
URL: https://issues.apache.org/jira/browse/KAFKA-13715
Project: Kafka
Issue Type: New
showuon commented on pull request #11843:
URL: https://github.com/apache/kafka/pull/11843#issuecomment-1061354885
Triggering jenkins build again to check the build results.
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-11843/3/
--
This is an automated message from the
RivenSun2 commented on pull request #11863:
URL: https://github.com/apache/kafka/pull/11863#issuecomment-1061338721
Hi @showuon
Please help to review the PR .
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
RivenSun2 opened a new pull request #11863:
URL: https://github.com/apache/kafka/pull/11863
Because the previous code involves the modification of the public module, a
KIP needs to be provided;
At the same time, the consideration of some scenarios was ignored, so it was
decided to
showuon commented on pull request #11800:
URL: https://github.com/apache/kafka/pull/11800#issuecomment-1061319723
@RivenSun2 , thanks for the help.
> Will the new PR title start with MINOR or still start with
[KAFKA-13689](https://issues.apache.org/jira/browse/KAFKA-13689)?
vvcephei commented on a change in pull request #11848:
URL: https://github.com/apache/kafka/pull/11848#discussion_r821241439
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/ConsistencyVectorIntegrationTest.java
##
@@ -131,67 +129,56 @@ public void
RivenSun2 commented on pull request #11800:
URL: https://github.com/apache/kafka/pull/11800#issuecomment-1061303039
Hi @showuon
I will create a new PR later to revert this code change.
Will the new PR title start with MINOR or still start with KAFKA-13689?
For the configuration of
wcarlson5 opened a new pull request #11862:
URL: https://github.com/apache/kafka/pull/11862
Clean up from topic prefix. updated tests accordingly
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI
C0urante commented on a change in pull request #11778:
URL: https://github.com/apache/kafka/pull/11778#discussion_r821155498
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/storage/ClusterConfigState.java
##
@@ -14,7 +14,7 @@
* See the License for the
vincent81jiang opened a new pull request #11861:
URL: https://github.com/apache/kafka/pull/11861
When a socket is closed, corresponding channel should be retained only if
there is complete buffered requests.
### Committer Checklist (excluded from commit message)
- [ ] Verify
soondenana closed pull request #11860:
URL: https://github.com/apache/kafka/pull/11860
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
soondenana opened a new pull request #11860:
URL: https://github.com/apache/kafka/pull/11860
Conflict in Jenkinsfile from AK commit:
[bbb2dc54a0f45bc5455f22a0671adde206dcfa29](https://github.com/apache/kafka/commit/bbb2dc54a0f4)
from PR:
C0urante commented on a change in pull request #11773:
URL: https://github.com/apache/kafka/pull/11773#discussion_r820917219
##
File path:
connect/api/src/main/java/org/apache/kafka/connect/source/SourceConnector.java
##
@@ -28,4 +30,46 @@
protected
ableegoldman commented on a change in pull request #11857:
URL: https://github.com/apache/kafka/pull/11857#discussion_r821100612
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java
##
@@ -161,35 +161,47 @@ public void
John Roesler created KAFKA-13714:
Summary: Flaky test IQv2StoreIntegrationTest
Key: KAFKA-13714
URL: https://issues.apache.org/jira/browse/KAFKA-13714
Project: Kafka
Issue Type: Bug
ableegoldman commented on a change in pull request #11857:
URL: https://github.com/apache/kafka/pull/11857#discussion_r821099068
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java
##
@@ -84,14 +84,14 @@
public
ableegoldman commented on a change in pull request #11857:
URL: https://github.com/apache/kafka/pull/11857#discussion_r821096763
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java
##
@@ -84,14 +84,14 @@
public
wcarlson5 commented on a change in pull request #11859:
URL: https://github.com/apache/kafka/pull/11859#discussion_r821095982
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java
##
@@ -1351,7 +1351,7 @@ private String
ableegoldman commented on a change in pull request #11859:
URL: https://github.com/apache/kafka/pull/11859#discussion_r821091010
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java
##
@@ -1351,7 +1351,7 @@ private
ableegoldman commented on pull request #11847:
URL: https://github.com/apache/kafka/pull/11847#issuecomment-1061121041
No test failures in NamedTopologyIntegrationTest! Merged to trunk 拾
The integration test should be completely stable now as all known issues and
sources of
wcarlson5 opened a new pull request #11859:
URL: https://github.com/apache/kafka/pull/11859
Clean up from topic prefix. updated tests accordingly
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI
ableegoldman merged pull request #11847:
URL: https://github.com/apache/kafka/pull/11847
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
guozhangwang commented on a change in pull request #11857:
URL: https://github.com/apache/kafka/pull/11857#discussion_r821006143
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java
##
@@ -84,14 +84,14 @@
public
wcarlson5 commented on a change in pull request #11857:
URL: https://github.com/apache/kafka/pull/11857#discussion_r82129
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java
##
@@ -161,35 +161,47 @@ public void
adamkotwasinski commented on a change in pull request #11843:
URL: https://github.com/apache/kafka/pull/11843#discussion_r820997952
##
File path:
clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java
##
@@ -420,7 +420,7 @@ private String
guozhangwang commented on a change in pull request #11857:
URL: https://github.com/apache/kafka/pull/11857#discussion_r820993077
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java
##
@@ -161,35 +161,47 @@ public void
jolshan commented on a change in pull request #11843:
URL: https://github.com/apache/kafka/pull/11843#discussion_r820992064
##
File path:
clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java
##
@@ -420,7 +420,7 @@ private String
adamkotwasinski commented on a change in pull request #11843:
URL: https://github.com/apache/kafka/pull/11843#discussion_r820984291
##
File path:
clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java
##
@@ -454,7 +454,7 @@ String
adamkotwasinski commented on a change in pull request #11843:
URL: https://github.com/apache/kafka/pull/11843#discussion_r820984291
##
File path:
clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java
##
@@ -454,7 +454,7 @@ String
wcarlson5 commented on a change in pull request #11857:
URL: https://github.com/apache/kafka/pull/11857#discussion_r820981114
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java
##
@@ -161,35 +161,47 @@ public void
adamkotwasinski commented on a change in pull request #11843:
URL: https://github.com/apache/kafka/pull/11843#discussion_r820979811
##
File path:
clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java
##
@@ -420,7 +420,7 @@ private String
guozhangwang commented on a change in pull request #11857:
URL: https://github.com/apache/kafka/pull/11857#discussion_r820972381
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java
##
@@ -161,35 +161,47 @@ public void
ijuma commented on pull request #11811:
URL: https://github.com/apache/kafka/pull/11811#issuecomment-1060972154
If that's the case, then we should only have that one public class in this
package. The rest should either be non public or in other packages. Is that how
it is?
--
This is
lihaosky opened a new pull request #11858:
URL: https://github.com/apache/kafka/pull/11858
*More detailed description of your change,
Change window api to add a emit final option for `SlidingWindow`,
`SessionWindow` and `TimedWindow`.
*Summary of testing strategy (including
lihaosky commented on a change in pull request #11802:
URL: https://github.com/apache/kafka/pull/11802#discussion_r820952845
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractDualSchemaRocksDBSegmentedBytesStore.java
##
@@ -0,0 +1,267 @@
+/*
C0urante commented on a change in pull request #11775:
URL: https://github.com/apache/kafka/pull/11775#discussion_r820935451
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedConfig.java
##
@@ -192,6 +197,33 @@
public
C0urante commented on a change in pull request #11775:
URL: https://github.com/apache/kafka/pull/11775#discussion_r820934303
##
File path:
connect/api/src/main/java/org/apache/kafka/connect/source/SourceConnector.java
##
@@ -28,4 +30,46 @@
protected
C0urante commented on a change in pull request #11775:
URL: https://github.com/apache/kafka/pull/11775#discussion_r820931108
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SourceConnectorConfig.java
##
@@ -47,6 +57,57 @@
+ "created
C0urante commented on a change in pull request #11775:
URL: https://github.com/apache/kafka/pull/11775#discussion_r820930471
##
File path:
connect/api/src/main/java/org/apache/kafka/connect/source/SourceTaskContext.java
##
@@ -38,4 +38,29 @@
* Get the
wcarlson5 commented on a change in pull request #11857:
URL: https://github.com/apache/kafka/pull/11857#discussion_r820926850
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java
##
@@ -161,35 +161,47 @@ public void
kirktrue commented on pull request #11811:
URL: https://github.com/apache/kafka/pull/11811#issuecomment-1060929594
Yes.
Users of the OAuth code will not necessarily _code_ against the classes in
this package, but they will need to specify the class names from this package
in their
C0urante commented on a change in pull request #11773:
URL: https://github.com/apache/kafka/pull/11773#discussion_r820917219
##
File path:
connect/api/src/main/java/org/apache/kafka/connect/source/SourceConnector.java
##
@@ -28,4 +30,46 @@
protected
C0urante commented on a change in pull request #11773:
URL: https://github.com/apache/kafka/pull/11773#discussion_r820917219
##
File path:
connect/api/src/main/java/org/apache/kafka/connect/source/SourceConnector.java
##
@@ -28,4 +30,46 @@
protected
jolshan commented on a change in pull request #11843:
URL: https://github.com/apache/kafka/pull/11843#discussion_r820912963
##
File path:
clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java
##
@@ -420,7 +420,7 @@ private String
jolshan commented on a change in pull request #11843:
URL: https://github.com/apache/kafka/pull/11843#discussion_r820912375
##
File path:
clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java
##
@@ -454,7 +454,7 @@ String
[
https://issues.apache.org/jira/browse/KAFKA-13687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergio Troiano updated KAFKA-13687:
---
Affects Version/s: 2.8.1
> Limit number of batches when using kafka-dump-log.sh
>
[
https://issues.apache.org/jira/browse/KAFKA-13687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergio Troiano updated KAFKA-13687:
---
Affects Version/s: (was: 2.8.1)
> Limit number of batches when using kafka-dump-log.sh
ijuma commented on pull request #11811:
URL: https://github.com/apache/kafka/pull/11811#issuecomment-1060727973
Just to double check, @kirktrue this are intended to be public API?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ijuma commented on a change in pull request #11833:
URL: https://github.com/apache/kafka/pull/11833#discussion_r820738378
##
File path: Jenkinsfile
##
@@ -178,6 +178,24 @@ pipeline {
echo 'Skipping Kafka Streams archetype test for ARM build'
}
[
https://issues.apache.org/jira/browse/KAFKA-9847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-9847:
-
Fix Version/s: 3.2.0
> Add config to set default store type
>
[
https://issues.apache.org/jira/browse/KAFKA-13587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-13587:
--
Fix Version/s: 3.2.0
> Implement unclean leader election in KIP-704
>
[
https://issues.apache.org/jira/browse/KAFKA-13217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-13217:
--
Fix Version/s: 3.2.0
> Reconsider skipping the LeaveGroup on close() or add an overload that
ableegoldman commented on a change in pull request #11857:
URL: https://github.com/apache/kafka/pull/11857#discussion_r820600321
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java
##
@@ -161,35 +161,47 @@ public void
ableegoldman commented on a change in pull request #11857:
URL: https://github.com/apache/kafka/pull/11857#discussion_r820598589
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java
##
@@ -161,35 +161,47 @@ public void
ableegoldman commented on a change in pull request #11857:
URL: https://github.com/apache/kafka/pull/11857#discussion_r820595967
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java
##
@@ -84,14 +84,14 @@
public
ableegoldman commented on a change in pull request #11857:
URL: https://github.com/apache/kafka/pull/11857#discussion_r820595568
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -1129,13 +1129,25 @@ public void
cadonna edited a comment on pull request #10802:
URL: https://github.com/apache/kafka/pull/10802#issuecomment-1060511060
@lkokhreidze Thank you for the ping! I will plan to look at your PR this
week. Let's try to get the whole feature merged before feature freeze for AK
3.2.0 which is
ableegoldman commented on a change in pull request #11857:
URL: https://github.com/apache/kafka/pull/11857#discussion_r820593601
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -881,17 +881,15 @@ private void
cadonna commented on pull request #10802:
URL: https://github.com/apache/kafka/pull/10802#issuecomment-1060511060
@lkokhreidze Thank you for the ping! I will plan to look at your PR this
week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
blcksrx commented on pull request #11838:
URL: https://github.com/apache/kafka/pull/11838#issuecomment-1060447839
@kirktrue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
mimaison commented on a change in pull request #11817:
URL: https://github.com/apache/kafka/pull/11817#discussion_r820531774
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerTest.java
##
@@ -1468,36 +1287,7 @@ private void
[
https://issues.apache.org/jira/browse/KAFKA-10759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison resolved KAFKA-10759.
Fix Version/s: 3.0.0
Resolution: Fixed
> ARM support for Kafka
>
[
https://issues.apache.org/jira/browse/KAFKA-10759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17502166#comment-17502166
]
Mickael Maison commented on KAFKA-10759:
The PR has been merged a while ago, so I'm closing this
[
https://issues.apache.org/jira/browse/KAFKA-13671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison resolved KAFKA-13671.
Fix Version/s: 3.2.0
Resolution: Fixed
> Power (ppc64le) support for kafka
>
mimaison merged pull request #11833:
URL: https://github.com/apache/kafka/pull/11833
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ableegoldman commented on pull request #11857:
URL: https://github.com/apache/kafka/pull/11857#issuecomment-1060371876
cc @wcarlson5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ableegoldman opened a new pull request #11857:
URL: https://github.com/apache/kafka/pull/11857
We used to call
`TopologyMetadata#maybeNotifyTopologyVersionWaitersAndUpdateThreadsTopologyVersion`
when a thread was being unregistered/shutting down, to check if any of the
futures listening
Lovzi opened a new pull request #11856:
URL: https://github.com/apache/kafka/pull/11856
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing
lkokhreidze commented on pull request #10802:
URL: https://github.com/apache/kafka/pull/10802#issuecomment-1060325078
Hi @cadonna @showuon
Sorry for the ping, but was wondering if it's possible to have a look at
this PR this week?
After this is merged, I'll have all the pieces to
85 matches
Mail list logo
