[GitHub] [kafka] showuon commented on a diff in pull request #12058: MINOR: Scala cleanups in core

showuon commented on code in PR #12058: URL: https://github.com/apache/kafka/pull/12058#discussion_r853770995 ## core/src/main/scala/kafka/server/PartitionMetadataFile.scala: ## @@ -44,8 +44,7 @@ object PartitionMetadataFile { } class PartitionMetadataReadBuffer[T](locat

[GitHub] [kafka] RivenSun2 opened a new pull request, #12070: KAFKA-13838: Improve the poll method of ConsumerNetworkClient

RivenSun2 opened a new pull request, #12070: URL: https://github.com/apache/kafka/pull/12070 Improve the poll method of ConsumerNetworkClient ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build sta

[jira] [Commented] (KAFKA-13838) Improve the poll method of ConsumerNetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-13838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524707#comment-17524707 ] RivenSun commented on KAFKA-13838: -- Hi [~guozhang]  [~hachikuji]  , [~showuon] Could yo

[jira] [Commented] (KAFKA-13838) Improve the poll method of ConsumerNetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-13838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524705#comment-17524705 ] RivenSun commented on KAFKA-13838: -- After looking at the code carefully, the comments o

[jira] [Commented] (KAFKA-13816) Downgrading Connect rebalancing protocol from incremental to eager causes duplicate task instances

[ https://issues.apache.org/jira/browse/KAFKA-13816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524701#comment-17524701 ] Sagar Rao commented on KAFKA-13816: --- hey [~ChrisEgerton] , thanks for the input! No wo

[jira] [Created] (KAFKA-13838) Improve the poll method of ConsumerNetworkClient

RivenSun created KAFKA-13838: Summary: Improve the poll method of ConsumerNetworkClient Key: KAFKA-13838 URL: https://issues.apache.org/jira/browse/KAFKA-13838 Project: Kafka Issue Type: Improvem

[GitHub] [kafka] showuon commented on a diff in pull request #12066: KAFKA-13834: fix drain batch starving issue

showuon commented on code in PR #12066: URL: https://github.com/apache/kafka/pull/12066#discussion_r853683790 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ## @@ -29,6 +29,7 @@ import java.util.Set; import java.util.concurrent.Con

[GitHub] [kafka] RivenSun2 commented on pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on PR #12010: URL: https://github.com/apache/kafka/pull/12010#issuecomment-1103427970 Hi @C0urante and @divijvaidya Thank you for your review. I just responded to your comment and resubmitted the code changes as well. If you have time, please help to review it ag

[jira] [Commented] (KAFKA-13834) batch drain for nodes might have starving issue

[ https://issues.apache.org/jira/browse/KAFKA-13834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524687#comment-17524687 ] shizhenzhen commented on KAFKA-13834: - [~guozhang] [~showuon]    Done! Thanks！ > ba

[jira] [Updated] (KAFKA-13834) batch drain for nodes might have starving issue

[ https://issues.apache.org/jira/browse/KAFKA-13834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shizhenzhen updated KAFKA-13834: Description: h3. 问题代码 problem code RecordAccumulator#drainBatchesForOneNode !https://img-blog.cs

[jira] [Updated] (KAFKA-13834) batch drain for nodes might have starving issue

[ https://issues.apache.org/jira/browse/KAFKA-13834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shizhenzhen updated KAFKA-13834: Summary: batch drain for nodes might have starving issue (was: Some problems with producers choos

[GitHub] [kafka] RivenSun2 commented on pull request #12069: MINOR: Improve postProcessAndValidateIdempotenceConfigs method

RivenSun2 commented on PR #12069: URL: https://github.com/apache/kafka/pull/12069#issuecomment-1103420473 Hi @showuon @guozhangwang could you help to review this PR? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853680081 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -393,10 +394,14 @@ public class ProducerConfig extends AbstractConfig {

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853680081 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -393,10 +394,14 @@ public class ProducerConfig extends AbstractConfig {

[GitHub] [kafka] RivenSun2 opened a new pull request, #12069: MINOR: Improve postProcessAndValidateIdempotenceConfigs method

RivenSun2 opened a new pull request, #12069: URL: https://github.com/apache/kafka/pull/12069 Improve postProcessAndValidateIdempotenceConfigs method ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI bu

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853664532 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -1324,9 +1324,9 @@ object KafkaConfig { .define(SslEngineFactoryClassProp, CLASS, null, LOW, SslEn

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853664320 ## clients/src/main/java/org/apache/kafka/common/config/SaslConfigs.java: ## @@ -202,7 +202,7 @@ public static void addClientSaslSupport(ConfigDef config) {

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853657790 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -393,10 +394,14 @@ public class ProducerConfig extends AbstractConfig {

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853652601 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -393,10 +394,14 @@ public class ProducerConfig extends AbstractConfig {

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853652462 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java: ## @@ -279,7 +281,7 @@ protected static ConfigDef baseConfigDef() {

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853652268 ## clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerConfigTest.java: ## @@ -108,4 +112,42 @@ public void testDefaultPartitionAssignor() { asser

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853651665 ## clients/src/main/java/org/apache/kafka/common/config/internals/BrokerSecurityConfigs.java: ## @@ -89,4 +91,31 @@ public class BrokerSecurityConfigs { +

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853651110 ## clients/src/main/java/org/apache/kafka/common/config/internals/BrokerSecurityConfigs.java: ## @@ -89,4 +91,31 @@ public class BrokerSecurityConfigs { +

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853650633 ## clients/src/main/java/org/apache/kafka/common/config/internals/BrokerSecurityConfigs.java: ## @@ -89,4 +91,31 @@ public class BrokerSecurityConfigs { +

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853650163 ## clients/src/main/java/org/apache/kafka/common/config/SslClientAuth.java: ## @@ -45,4 +45,9 @@ public static SslClientAuth forConfig(String key) { }

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853650023 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -1324,9 +1324,9 @@ object KafkaConfig { .define(SslEngineFactoryClassProp, CLASS, null, LOW, SslEn

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853646332 ## clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerConfigTest.java: ## @@ -108,4 +112,42 @@ public void testDefaultPartitionAssignor() { asser

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853645330 ## clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java: ## @@ -486,10 +488,14 @@ public class ConsumerConfig extends AbstractConfig {

[GitHub] [kafka] ruanliang-hualun commented on a diff in pull request #12066: KAFKA-13834: fix drain batch starving issue

ruanliang-hualun commented on code in PR #12066: URL: https://github.com/apache/kafka/pull/12066#discussion_r853641392 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/RecordAccumulatorTest.java: ## @@ -48,18 +48,11 @@ import org.mockito.Mockito; import j

[GitHub] [kafka] C0urante commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

C0urante commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853583209 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -1324,9 +1324,9 @@ object KafkaConfig { .define(SslEngineFactoryClassProp, CLASS, null, LOW, SslEng

[GitHub] [kafka] C0urante commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

C0urante commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853568629 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -393,10 +394,14 @@ public class ProducerConfig extends AbstractConfig {

[GitHub] [kafka] C0urante commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

C0urante commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853568629 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -393,10 +394,14 @@ public class ProducerConfig extends AbstractConfig {

[GitHub] [kafka] C0urante commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

C0urante commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853568629 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -393,10 +394,14 @@ public class ProducerConfig extends AbstractConfig {

[GitHub] [kafka] C0urante commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

C0urante commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853564467 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -393,10 +394,14 @@ public class ProducerConfig extends AbstractConfig {

[GitHub] [kafka] C0urante commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

C0urante commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853549366 ## clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerConfigTest.java: ## @@ -108,4 +112,42 @@ public void testDefaultPartitionAssignor() { assert

[GitHub] [kafka] C0urante commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

C0urante commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853542111 ## clients/src/main/java/org/apache/kafka/common/config/internals/BrokerSecurityConfigs.java: ## @@ -89,4 +91,31 @@ public class BrokerSecurityConfigs { +

[GitHub] [kafka] C0urante commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

C0urante commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853537865 ## clients/src/main/java/org/apache/kafka/common/config/internals/BrokerSecurityConfigs.java: ## @@ -89,4 +91,31 @@ public class BrokerSecurityConfigs { +

[GitHub] [kafka] C0urante commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

C0urante commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853538239 ## clients/src/main/java/org/apache/kafka/common/config/internals/BrokerSecurityConfigs.java: ## @@ -89,4 +91,31 @@ public class BrokerSecurityConfigs { +

[GitHub] [kafka] C0urante commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

C0urante commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853537865 ## clients/src/main/java/org/apache/kafka/common/config/internals/BrokerSecurityConfigs.java: ## @@ -89,4 +91,31 @@ public class BrokerSecurityConfigs { +

[GitHub] [kafka] C0urante commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

C0urante commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853536713 ## clients/src/main/java/org/apache/kafka/common/config/SaslConfigs.java: ## @@ -202,7 +202,7 @@ public static void addClientSaslSupport(ConfigDef config) {

[GitHub] [kafka] C0urante commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

C0urante commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853527225 ## clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java: ## @@ -486,10 +488,14 @@ public class ConsumerConfig extends AbstractConfig {

[jira] [Comment Edited] (KAFKA-13816) Downgrading Connect rebalancing protocol from incremental to eager causes duplicate task instances

[ https://issues.apache.org/jira/browse/KAFKA-13816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524601#comment-17524601 ] Chris Egerton edited comment on KAFKA-13816 at 4/19/22 9:53 PM: --

[jira] [Commented] (KAFKA-13816) Downgrading Connect rebalancing protocol from incremental to eager causes duplicate task instances

[ https://issues.apache.org/jira/browse/KAFKA-13816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524601#comment-17524601 ] Chris Egerton commented on KAFKA-13816: --- [~sagarrao] I think you're on the right t

[jira] [Created] (KAFKA-13837) Return error for Fetch requests from unrecognized followers

Jason Gustafson created KAFKA-13837: --- Summary: Return error for Fetch requests from unrecognized followers Key: KAFKA-13837 URL: https://issues.apache.org/jira/browse/KAFKA-13837 Project: Kafka

[GitHub] [kafka] philipnee commented on a diff in pull request #12064: KAFKA-12841: Remove an additional call of onAcknowledgement

philipnee commented on code in PR #12064: URL: https://github.com/apache/kafka/pull/12064#discussion_r853476454 ## clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java: ## @@ -1905,15 +1905,21 @@ public void testCallbackHandlesError() throws Exception

[GitHub] [kafka] junrao commented on a diff in pull request #12064: KAFKA-12841: Remove an additional call of onAcknowledgement

junrao commented on code in PR #12064: URL: https://github.com/apache/kafka/pull/12064#discussion_r853473066 ## clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java: ## @@ -1905,15 +1905,21 @@ public void testCallbackHandlesError() throws Exception {

[GitHub] [kafka] cmccabe merged pull request #12063: KAFKA-13835: Fix two bugs related to dynamic broker configs in KRaft

cmccabe merged PR #12063: URL: https://github.com/apache/kafka/pull/12063 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] cmccabe commented on pull request #12063: KAFKA-13835: Fix two bugs related to dynamic broker configs in KRaft

cmccabe commented on PR #12063: URL: https://github.com/apache/kafka/pull/12063#issuecomment-1103064630 Jenkins test failures were `ConnectorTopicsIntegrationTest` and `ConnectionQuotasTest`, which are not related and which pass locally. Committing. Thanks, all. -- This is an automated m

[jira] [Commented] (KAFKA-13827) Data Loss on moving to KRAFT mode from v3.1

[ https://issues.apache.org/jira/browse/KAFKA-13827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524498#comment-17524498 ] Ismael Juma commented on KAFKA-13827: - {quote}So if someone is to start using KRAFT

[jira] [Comment Edited] (KAFKA-13827) Data Loss on moving to KRAFT mode from v3.1

[ https://issues.apache.org/jira/browse/KAFKA-13827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524498#comment-17524498 ] Ismael Juma edited comment on KAFKA-13827 at 4/19/22 6:29 PM:

[GitHub] [kafka] cmccabe commented on a diff in pull request #12063: KAFKA-13835: Fix two bugs related to dynamic broker configs in KRaft

cmccabe commented on code in PR #12063: URL: https://github.com/apache/kafka/pull/12063#discussion_r853345314 ## core/src/main/scala/kafka/server/DynamicBrokerConfig.scala: ## @@ -948,18 +980,18 @@ class DynamicListenerConfig(server: KafkaBroker) extends BrokerReconfigurable wi

[GitHub] [kafka] hachikuji commented on a diff in pull request #12063: KAFKA-13835: Fix two bugs related to dynamic broker configs in KRaft

hachikuji commented on code in PR #12063: URL: https://github.com/apache/kafka/pull/12063#discussion_r853339103 ## core/src/main/scala/kafka/server/DynamicBrokerConfig.scala: ## @@ -948,18 +980,18 @@ class DynamicListenerConfig(server: KafkaBroker) extends BrokerReconfigurable

[GitHub] [kafka] junrao commented on a diff in pull request #12029: KAFKA-13815: Avoid reinitialization for a replica that is being deleted

junrao commented on code in PR #12029: URL: https://github.com/apache/kafka/pull/12029#discussion_r853335645 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -2703,6 +2711,26 @@ class ReplicaManagerTest { assertEquals(HostedPartition.None, replicaM

[GitHub] [kafka] philipnee commented on pull request #12064: KAFKA-12841: Remove an additional call of onAcknowledgement

philipnee commented on PR #12064: URL: https://github.com/apache/kafka/pull/12064#issuecomment-1102902016 Hey @junrao - Much thanks to look into this, I added some tests to the PR, let me know if you think the testing strategy is acceptable... -- This is an automated message from the Apac

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12004: KAFKA-10095: Add stricter assertion in LogCleanerManagerTest

divijvaidya commented on code in PR #12004: URL: https://github.com/apache/kafka/pull/12004#discussion_r853306673 ## core/src/test/scala/unit/kafka/log/LogCleanerManagerTest.scala: ## @@ -413,7 +413,7 @@ class LogCleanerManagerTest extends Logging { // updateCheckpoints s

[GitHub] [kafka] cmccabe commented on a diff in pull request #12063: KAFKA-13835: Fix two bugs related to dynamic broker configs in KRaft

cmccabe commented on code in PR #12063: URL: https://github.com/apache/kafka/pull/12063#discussion_r853303350 ## core/src/main/scala/kafka/server/DynamicBrokerConfig.scala: ## @@ -950,16 +963,17 @@ class DynamicListenerConfig(server: KafkaBroker) extends BrokerReconfigurable wi

[GitHub] [kafka] cmccabe commented on pull request #12063: KAFKA-13835: Fix two bugs related to dynamic broker configs in KRaft

cmccabe commented on PR #12063: URL: https://github.com/apache/kafka/pull/12063#issuecomment-1102884473 The only test failure I could find was the "heap space exhausted" thing which has nothing to do with this PR. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] cmccabe commented on a diff in pull request #12063: KAFKA-13835: Fix two bugs related to dynamic broker configs in KRaft

cmccabe commented on code in PR #12063: URL: https://github.com/apache/kafka/pull/12063#discussion_r853300475 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala: ## @@ -187,21 +189,26 @@ class BrokerMetadataPublisher(conf: KafkaConfig, to

[GitHub] [kafka] cmccabe commented on a diff in pull request #12063: KAFKA-13835: Fix two bugs related to dynamic broker configs in KRaft

cmccabe commented on code in PR #12063: URL: https://github.com/apache/kafka/pull/12063#discussion_r853299678 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala: ## @@ -248,6 +248,24 @@ class BrokerMetadataListener( } } + // This is used in test

[GitHub] [kafka] mimaison commented on a diff in pull request #12004: KAFKA-10095: Add stricter assertion in LogCleanerManagerTest

mimaison commented on code in PR #12004: URL: https://github.com/apache/kafka/pull/12004#discussion_r853285333 ## core/src/test/scala/unit/kafka/log/LogCleanerManagerTest.scala: ## @@ -413,7 +413,7 @@ class LogCleanerManagerTest extends Logging { // updateCheckpoints shou

[GitHub] [kafka] ijuma commented on pull request #12045: KAFKA-12319: Change calculation of window size used to calculate `Rate`

ijuma commented on PR #12045: URL: https://github.com/apache/kafka/pull/12045#issuecomment-1102838142 cc @apovzner @dajac -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [kafka] divijvaidya commented on pull request #12004: KAFKA-10095: Add stricter assertion in LogCleanerManagerTest

divijvaidya commented on PR #12004: URL: https://github.com/apache/kafka/pull/12004#issuecomment-1102809653 Requesting review from @abbccdda and @hachikuji since you folks were part of a previous PR for this JIRA. Please take a look when you get a chance 🙏 -- This is an automated m

[GitHub] [kafka] divijvaidya commented on pull request #12045: KAFKA-12319: Change calculation of window size used to calculate `Rate`

divijvaidya commented on PR #12045: URL: https://github.com/apache/kafka/pull/12045#issuecomment-1102806383 Requesting review from @mjsax since you commented on the associated JIRA: https://issues.apache.org/jira/browse/KAFKA-12319 Requesting review from @ijuma @jjkoshy since you fol

[jira] [Resolved] (KAFKA-13654) Extend KStream process with new Processor API

[ https://issues.apache.org/jira/browse/KAFKA-13654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler resolved KAFKA-13654. -- Fix Version/s: 3.3.0 Resolution: Fixed > Extend KStream process with new Processor API

[jira] [Assigned] (KAFKA-13654) Extend KStream process with new Processor API

[ https://issues.apache.org/jira/browse/KAFKA-13654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler reassigned KAFKA-13654: Assignee: Jorge Esteban Quilcate Otoya > Extend KStream process with new Processor API >

[GitHub] [kafka] vvcephei merged pull request #11993: KAFKA-13654: Extend KStream process with new Processor API

vvcephei merged PR #11993: URL: https://github.com/apache/kafka/pull/11993 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] mimaison commented on a diff in pull request #12058: MINOR: Scala cleanups in core

mimaison commented on code in PR #12058: URL: https://github.com/apache/kafka/pull/12058#discussion_r853202342 ## core/src/main/scala/kafka/server/DelegationTokenManager.scala: ## @@ -140,13 +140,13 @@ object DelegationTokenManager { val allow = //exclude tokens whic

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

divijvaidya commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853124702 ## clients/src/main/java/org/apache/kafka/common/config/SslClientAuth.java: ## @@ -45,4 +45,9 @@ public static SslClientAuth forConfig(String key) { }

[jira] [Assigned] (KAFKA-13836) Improve KRaft broker heartbeat logic

[ https://issues.apache.org/jira/browse/KAFKA-13836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dengziming reassigned KAFKA-13836: -- Assignee: dengziming > Improve KRaft broker heartbeat logic > ---

[GitHub] [kafka] dengziming commented on pull request #11951: KAFKA-13737: Fix flaky test in LeaderElectionCommandTest

dengziming commented on PR #11951: URL: https://github.com/apache/kafka/pull/11951#issuecomment-1102760776 Yeah @hachikuji , it's impossible to remove the gap but we can still minimize it by: 1. Don't advertise an offset to the controller until it has been published 2. Only unfence a b

[jira] [Created] (KAFKA-13836) Improve KRaft broker heartbeat logic

dengziming created KAFKA-13836: -- Summary: Improve KRaft broker heartbeat logic Key: KAFKA-13836 URL: https://issues.apache.org/jira/browse/KAFKA-13836 Project: Kafka Issue Type: Improvement

[GitHub] [kafka] mimaison opened a new pull request, #12068: MINOR: Fix warnings in Gradle 7

mimaison opened a new pull request, #12068: URL: https://github.com/apache/kafka/pull/12068 JavaExec.main and Report.destination have been deprecated and will be removd in Gradle 8. Use the new fields (mainClass and outputLocation) instead. ### Committer Checklist (excluded from c

[GitHub] [kafka] mimaison opened a new pull request, #12067: KAFKA-13780: Generate OpenAPI file for Connect REST API

mimaison opened a new pull request, #12067: URL: https://github.com/apache/kafka/pull/12067 New gradle task: connect:runtime:genConnectOpenAPIDocs that generates connect_rest.yaml under docs/generated This task is executed when siteDocsTar runs. ### Committer Checklist (excluded fr

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12066: KAFKA-13834: fix drain batch starving issue

RivenSun2 commented on code in PR #12066: URL: https://github.com/apache/kafka/pull/12066#discussion_r853013703 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/RecordAccumulatorTest.java: ## @@ -48,18 +48,11 @@ import org.mockito.Mockito; import java.nio

[GitHub] [kafka] RivenSun2 commented on pull request #12052: KAFKA-13799: Improve documentation for Kafka zero-copy

RivenSun2 commented on PR #12052: URL: https://github.com/apache/kafka/pull/12052#issuecomment-1102545521 Hi @divijvaidya Thanks for your review, just resubmitted the changes. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[jira] [Commented] (KAFKA-13834) Some problems with producers choosing batches of messages to send

[ https://issues.apache.org/jira/browse/KAFKA-13834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524270#comment-17524270 ] ruanliang commented on KAFKA-13834: --- [~showuon]  [~guozhang]   add the test case  [ht

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #11211: KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…

vamossagar12 commented on code in PR #11211: URL: https://github.com/apache/kafka/pull/11211#discussion_r852939284 ## streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractRocksDBSegmentedBytesStore.java: ## @@ -87,23 +90,35 @@ public KeyValueIterator backwardFe

[GitHub] [kafka] jeqo commented on a diff in pull request #11993: KAFKA-13654: Extend KStream process with new Processor API

jeqo commented on code in PR #11993: URL: https://github.com/apache/kafka/pull/11993#discussion_r852932074 ## streams/src/test/java/org/apache/kafka/test/MockProcessorNode.java: ## @@ -60,7 +61,7 @@ public void init(final InternalProcessorContext context) { @Override

[GitHub] [kafka] jeqo commented on a diff in pull request #11993: KAFKA-13654: Extend KStream process with new Processor API

jeqo commented on code in PR #11993: URL: https://github.com/apache/kafka/pull/11993#discussion_r852931420 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/ProcessorParameters.java: ## @@ -37,30 +43,67 @@ @SuppressWarnings("deprecation") // Old PAPI

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12058: MINOR: Scala cleanups in core

divijvaidya commented on code in PR #12058: URL: https://github.com/apache/kafka/pull/12058#discussion_r852885365 ## core/src/main/scala/kafka/server/DelegationTokenManager.scala: ## @@ -140,13 +140,13 @@ object DelegationTokenManager { val allow = //exclude tokens w

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12052: KAFKA-13799: Improve documentation for Kafka zero-copy

divijvaidya commented on code in PR #12052: URL: https://github.com/apache/kafka/pull/12052#discussion_r852846763 ## docs/design.html: ## @@ -124,6 +124,7 @@ and copied out to user-space every time it is read. This allows messages to be consumed at a rate that approaches

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12044: KAFKA-12738: implement exponential backoff for tasks

mdedetrich commented on code in PR #12044: URL: https://github.com/apache/kafka/pull/12044#discussion_r852823850 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskScheduler.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12063: KAFKA-13835: Fix two bugs related to dynamic broker configs in KRaft

mdedetrich commented on code in PR #12063: URL: https://github.com/apache/kafka/pull/12063#discussion_r852818277 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala: ## @@ -187,21 +189,26 @@ class BrokerMetadataPublisher(conf: KafkaConfig,

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12063: KAFKA-13835: Fix two bugs related to dynamic broker configs in KRaft

mdedetrich commented on code in PR #12063: URL: https://github.com/apache/kafka/pull/12063#discussion_r852818277 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala: ## @@ -187,21 +189,26 @@ class BrokerMetadataPublisher(conf: KafkaConfig,

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12063: KAFKA-13835: Fix two bugs related to dynamic broker configs in KRaft

mdedetrich commented on code in PR #12063: URL: https://github.com/apache/kafka/pull/12063#discussion_r852808807 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala: ## @@ -248,6 +248,24 @@ class BrokerMetadataListener( } } + // This is used in t

[GitHub] [kafka] ruanliang-hualun commented on a diff in pull request #12066: bugfix for KAFKA-13834

ruanliang-hualun commented on code in PR #12066: URL: https://github.com/apache/kafka/pull/12066#discussion_r852691675 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ## @@ -560,12 +561,14 @@ private List drainBatchesForOneNode(Clust

[GitHub] [kafka] dajac commented on a diff in pull request #12029: KAFKA-13815: Avoid reinitialization for a replica that is being deleted

dajac commented on code in PR #12029: URL: https://github.com/apache/kafka/pull/12029#discussion_r852680173 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -2703,6 +2711,26 @@ class ReplicaManagerTest { assertEquals(HostedPartition.None, replicaMa

[jira] [Resolved] (KAFKA-13832) Flaky test TopicCommandIntegrationTest.testAlterAssignment

[ https://issues.apache.org/jira/browse/KAFKA-13832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-13832. --- Fix Version/s: 3.3.0 Assignee: dengziming Resolution: Fixed > Flaky test TopicComman

[GitHub] [kafka] showuon merged pull request #12060: KAFKA-13832: Fix flaky testAlterAssignment

showuon merged PR #12060: URL: https://github.com/apache/kafka/pull/12060 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] showuon commented on a diff in pull request #12066: bugfix for KAFKA-13834

showuon commented on code in PR #12066: URL: https://github.com/apache/kafka/pull/12066#discussion_r852661339 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ## @@ -81,7 +82,7 @@ public class RecordAccumulator { private final Inc

[jira] [Commented] (KAFKA-13834) Some problems with producers choosing batches of messages to send

[ https://issues.apache.org/jira/browse/KAFKA-13834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524118#comment-17524118 ] Luke Chen commented on KAFKA-13834: --- And BTW, the Jira title might also need to update