[GitHub] [kafka] niket-goel commented on pull request #12206: KAFKA-13888: Addition of Information in DescribeQuorumResponse about Voter Lag

niket-goel commented on PR #12206: URL: https://github.com/apache/kafka/pull/12206#issuecomment-1136674585 Published another revision addressing @hachikuji's comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] hachikuji commented on a diff in pull request #12187: KAFKA-13858; Kraft should not shutdown metadata listener until controller shutdown is finished

hachikuji commented on code in PR #12187: URL: https://github.com/apache/kafka/pull/12187#discussion_r881165574 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -2118,36 +2124,39 @@ class ReplicaManager(val config: KafkaConfig, newImage: MetadataImage,

[GitHub] [kafka] hachikuji commented on a diff in pull request #12187: KAFKA-13858; Kraft should not shutdown metadata listener until controller shutdown is finished

hachikuji commented on code in PR #12187: URL: https://github.com/apache/kafka/pull/12187#discussion_r881158834 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -2134,20 +2141,22 @@ class ReplicaManager(val config: KafkaConfig,

[GitHub] [kafka] guozhangwang merged pull request #12200: KAFKA-10199: Implement adding standby tasks to the state updater

guozhangwang merged PR #12200: URL: https://github.com/apache/kafka/pull/12200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] guozhangwang commented on pull request #12200: KAFKA-10199: Implement adding standby tasks to the state updater

guozhangwang commented on PR #12200: URL: https://github.com/apache/kafka/pull/12200#issuecomment-113657 Merged to trunk, thanks @cadonna ! Really appreciate your improvement on the unit tests with the verification steps, that's great. -- This is an automated message from the Apache

[GitHub] [kafka] cmccabe opened a new pull request, #12207: MINOR: Several fixes and improvements for FeatureControlManager

cmccabe opened a new pull request, #12207: URL: https://github.com/apache/kafka/pull/12207 This PR fixes a bug where FeatureControlManager#replay(FeatureLevelRecord) was throwing an exception if not all controllers in the quorum supported the feature being applied. While we do want

[GitHub] [kafka] junrao commented on a diff in pull request #12005: KAFKA-13803: Refactor Leader API Access

junrao commented on code in PR #12005: URL: https://github.com/apache/kafka/pull/12005#discussion_r881046709 ## core/src/main/scala/kafka/server/LocalLeaderEndPoint.scala: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] kowshik commented on a diff in pull request #12005: KAFKA-13803: Refactor Leader API Access

kowshik commented on code in PR #12005: URL: https://github.com/apache/kafka/pull/12005#discussion_r881050248 ## core/src/main/scala/kafka/server/RemoteLeaderEndPoint.scala: ## @@ -0,0 +1,226 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] franz1981 commented on pull request #12163: KAFKA-13900 Support Java 9 direct ByteBuffer Checksum methods

franz1981 commented on PR #12163: URL: https://github.com/apache/kafka/pull/12163#issuecomment-1136516885 @ijuma I see some CI errors - there's anything here I can do to help? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] niket-goel commented on a diff in pull request #12206: KAFKA-13888: Addition of Information in DescribeQuorumResponse about Voter Lag

niket-goel commented on code in PR #12206: URL: https://github.com/apache/kafka/pull/12206#discussion_r881044944 ## raft/src/main/java/org/apache/kafka/raft/RaftConfig.java: ## @@ -256,6 +256,21 @@ public static List voterConnectionsToNodes(Map nodes) { Review Comment: It

[GitHub] [kafka] niket-goel commented on a diff in pull request #12206: KAFKA-13888: Addition of Information in DescribeQuorumResponse about Voter Lag

niket-goel commented on code in PR #12206: URL: https://github.com/apache/kafka/pull/12206#discussion_r881044720 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -318,6 +325,11 @@ public class KafkaAdminClient extends AdminClient {

[GitHub] [kafka] niket-goel commented on a diff in pull request #12206: KAFKA-13888: Addition of Information in DescribeQuorumResponse about Voter Lag

niket-goel commented on code in PR #12206: URL: https://github.com/apache/kafka/pull/12206#discussion_r881043900 ## clients/src/main/java/org/apache/kafka/common/utils/QuorumInfo.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] hachikuji commented on pull request #12206: KAFKA-13888: Addition of Information in DescribeQuorumResponse about Voter Lag

hachikuji commented on PR #12206: URL: https://github.com/apache/kafka/pull/12206#issuecomment-1136500940 cc @dengziming for reviews -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] hachikuji commented on a diff in pull request #12206: KAFKA-13888: Addition of Information in DescribeQuorumResponse about Voter Lag

hachikuji commented on code in PR #12206: URL: https://github.com/apache/kafka/pull/12206#discussion_r881020616 ## clients/src/main/java/org/apache/kafka/clients/admin/Admin.java: ## @@ -1382,6 +1382,23 @@ default DescribeFeaturesResult describeFeatures() { return

[GitHub] [kafka] hachikuji commented on a diff in pull request #12206: KAFKA-13888: Addition of Information in DescribeQuorumResponse about Voter Lag

hachikuji commented on code in PR #12206: URL: https://github.com/apache/kafka/pull/12206#discussion_r881002654 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -318,6 +325,11 @@ public class KafkaAdminClient extends AdminClient {

[GitHub] [kafka] hachikuji commented on a diff in pull request #12206: KAFKA-13888: Addition of Information in DescribeQuorumResponse about Voter Lag

hachikuji commented on code in PR #12206: URL: https://github.com/apache/kafka/pull/12206#discussion_r880984176 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -4181,6 +4193,61 @@ private static byte[] getSaltedPasword(ScramMechanism

[jira] [Commented] (KAFKA-5523) ReplayLogProducer not using the new Kafka consumer

[ https://issues.apache.org/jira/browse/KAFKA-5523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17541732#comment-17541732 ] David Chen commented on KAFKA-5523: --- Unfortunately, we don't have MirrorMaker 2 in our system yet but

[jira] [Comment Edited] (KAFKA-13888) KIP-836: Addition of Information in DescribeQuorumResponse about Voter Lag

[ https://issues.apache.org/jira/browse/KAFKA-13888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17541722#comment-17541722 ] Niket Goel edited comment on KAFKA-13888 at 5/24/22 10:10 PM: -- [~Jack-Lee]

[GitHub] [kafka] junrao commented on a diff in pull request #12136: KAFKA-13773: catch kafkaStorageException to avoid broker shutdown directly

junrao commented on code in PR #12136: URL: https://github.com/apache/kafka/pull/12136#discussion_r880990528 ## core/src/test/scala/unit/kafka/log/LogLoaderTest.scala: ## @@ -158,22 +192,37 @@ class LogLoaderTest { } locally { + val (logManager, runLoadLogs) =

[jira] [Commented] (KAFKA-13914) Implement kafka-metadata-quorum.sh

[ https://issues.apache.org/jira/browse/KAFKA-13914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17541723#comment-17541723 ] Niket Goel commented on KAFKA-13914: +1. Thanks [~dengziming] for identifying the hole and helping

[jira] [Commented] (KAFKA-13888) KIP-836: Addition of Information in DescribeQuorumResponse about Voter Lag

[ https://issues.apache.org/jira/browse/KAFKA-13888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17541722#comment-17541722 ] Niket Goel commented on KAFKA-13888: [~Jack-Lee] Apologies for missing your responses. I actually

[GitHub] [kafka] niket-goel opened a new pull request, #12206: KAFKA-13888: Addition of Information in DescribeQuorumResponse about Voter Lag

niket-goel opened a new pull request, #12206: URL: https://github.com/apache/kafka/pull/12206 This commit adds an Admin API handler for DescribeQuorum Request and also adds in two new fields LastFetchTimestamp and LastCaughtUpTimestamp to the DescribeQuorumResponse as described by

[jira] [Commented] (KAFKA-5523) ReplayLogProducer not using the new Kafka consumer

[ https://issues.apache.org/jira/browse/KAFKA-5523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17541719#comment-17541719 ] Ismael Juma commented on KAFKA-5523: Can you use MirrorMaker 2 for that? > ReplayLogProducer not

[jira] [Commented] (KAFKA-5523) ReplayLogProducer not using the new Kafka consumer

[ https://issues.apache.org/jira/browse/KAFKA-5523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17541716#comment-17541716 ] David Chen commented on KAFKA-5523: --- [~omkreddy]  [~ijuma]  Reasons we want to copy topics: * People

[jira] [Created] (KAFKA-13935) Factor out IBP from Partition and Log code

David Arthur created KAFKA-13935: Summary: Factor out IBP from Partition and Log code Key: KAFKA-13935 URL: https://issues.apache.org/jira/browse/KAFKA-13935 Project: Kafka Issue Type:

[GitHub] [kafka] jnh5y commented on a diff in pull request #12161: KAFKA-13873 Add ability to Pause / Resume KafkaStreams Topologies

jnh5y commented on code in PR #12161: URL: https://github.com/apache/kafka/pull/12161#discussion_r880934812 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskExecutionMetadataTest.java: ## @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cmccabe opened a new pull request, #12205: MINOR: Fix missing UNREGISTER_BROKER call in KafkaApis

cmccabe opened a new pull request, #12205: URL: https://github.com/apache/kafka/pull/12205 KafkaApis should forward UnregisterBroker to the KRaft controller. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] cmccabe commented on a diff in pull request #12195: MINOR: implement BrokerRegistrationChangeRecord

cmccabe commented on code in PR #12195: URL: https://github.com/apache/kafka/pull/12195#discussion_r880929826 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -1087,9 +,15 @@ void handleBrokerFenced(int brokerId, List records) {

[GitHub] [kafka] jnh5y commented on a diff in pull request #12161: KAFKA-13873 Add ability to Pause / Resume KafkaStreams Topologies

jnh5y commented on code in PR #12161: URL: https://github.com/apache/kafka/pull/12161#discussion_r880913977 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamThreadTest.java: ## @@ -1761,6 +1761,96 @@ public void shouldUpdateStandbyTask() throws

[GitHub] [kafka] jnh5y commented on a diff in pull request #12161: KAFKA-13873 Add ability to Pause / Resume KafkaStreams Topologies

jnh5y commented on code in PR #12161: URL: https://github.com/apache/kafka/pull/12161#discussion_r880907800 ## streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java: ## @@ -783,6 +822,28 @@ public void shouldThrowOnCleanupWhileRunning() throws

[GitHub] [kafka] jnh5y commented on a diff in pull request #12161: KAFKA-13873 Add ability to Pause / Resume KafkaStreams Topologies

jnh5y commented on code in PR #12161: URL: https://github.com/apache/kafka/pull/12161#discussion_r880905641 ## streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java: ## @@ -783,6 +822,28 @@ public void shouldThrowOnCleanupWhileRunning() throws

[GitHub] [kafka] jnh5y commented on a diff in pull request #12161: KAFKA-13873 Add ability to Pause / Resume KafkaStreams Topologies

jnh5y commented on code in PR #12161: URL: https://github.com/apache/kafka/pull/12161#discussion_r880904155 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java: ## @@ -415,68 +415,111 @@ public Set completedChangelogs() { public

[GitHub] [kafka] guozhangwang commented on pull request #12200: KAFKA-10199: Implement adding standby tasks to the state updater

guozhangwang commented on PR #12200: URL: https://github.com/apache/kafka/pull/12200#issuecomment-1136345721 Re-triggered build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12200: KAFKA-10199: Implement adding standby tasks to the state updater

guozhangwang commented on code in PR #12200: URL: https://github.com/apache/kafka/pull/12200#discussion_r880841005 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -206,30 +230,46 @@ private List getTasksAndActions() {

[GitHub] [kafka] mumrah commented on pull request #12062: KAFKA-13833: Remove the min_version_level from the finalized version written to ZooKeeper

mumrah commented on PR #12062: URL: https://github.com/apache/kafka/pull/12062#issuecomment-1136335570 I kicked off another build just to see about the timeout from the last run https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-12062/8/ -- This is an automated message from the

[GitHub] [kafka] lbradstreet commented on pull request #12202: MINOR: fix connect system test runs with JDK 10+

lbradstreet commented on PR #12202: URL: https://github.com/apache/kafka/pull/12202#issuecomment-1136283337 @kkonstantine there are no specific plans aside from running trunk, but it might still be worth backporting it to the last two major branches if it's low effort. -- This is an

[jira] [Created] (KAFKA-13934) Consider consolidating TimeWindow / SessionWindow / SlidingWindow

Guozhang Wang created KAFKA-13934: - Summary: Consider consolidating TimeWindow / SessionWindow / SlidingWindow Key: KAFKA-13934 URL: https://issues.apache.org/jira/browse/KAFKA-13934 Project: Kafka

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12204: [9/N WIP][Emit final] Emit final for session window aggregations

guozhangwang commented on code in PR #12204: URL: https://github.com/apache/kafka/pull/12204#discussion_r880778694 ## streams/src/main/java/org/apache/kafka/streams/state/SessionStore.java: ## @@ -39,6 +39,13 @@ */ public interface SessionStore extends StateStore,

[GitHub] [kafka] guozhangwang opened a new pull request, #12204: [9/N][Emit final] Emit final for session window aggregations

guozhangwang opened a new pull request, #12204: URL: https://github.com/apache/kafka/pull/12204 1. Add a new API for session windows to range query session window by end time (KIP related). 2. Augment session window aggregator with emit strategy. 3. Minor: consolidated some dup

[GitHub] [kafka] hachikuji commented on a diff in pull request #12181: KAFKA-13916; Fenced replicas should not be allowed to join the ISR in KRaft (KIP-841)

hachikuji commented on code in PR #12181: URL: https://github.com/apache/kafka/pull/12181#discussion_r880748010 ## metadata/src/main/java/org/apache/kafka/controller/BrokerHeartbeatManager.java: ## @@ -498,6 +498,23 @@ public UsableBroker next() { } } +/** +

[GitHub] [kafka] dajac commented on a diff in pull request #12181: KAFKA-13916; Fenced replicas should not be allowed to join the ISR in KRaft (KIP-841)

dajac commented on code in PR #12181: URL: https://github.com/apache/kafka/pull/12181#discussion_r880753092 ## metadata/src/main/java/org/apache/kafka/controller/BrokerHeartbeatManager.java: ## @@ -498,6 +498,23 @@ public UsableBroker next() { } } +/** +

[GitHub] [kafka] hachikuji commented on a diff in pull request #12181: KAFKA-13916; Fenced replicas should not be allowed to join the ISR in KRaft (KIP-841)

hachikuji commented on code in PR #12181: URL: https://github.com/apache/kafka/pull/12181#discussion_r880748010 ## metadata/src/main/java/org/apache/kafka/controller/BrokerHeartbeatManager.java: ## @@ -498,6 +498,23 @@ public UsableBroker next() { } } +/** +

[GitHub] [kafka] lbradstreet commented on pull request #12202: MINOR: fix connect system test runs with JDK 10+

lbradstreet commented on PR #12202: URL: https://github.com/apache/kafka/pull/12202#issuecomment-1136146341 @kkonstantine I don't have a link to a run, but I should have mentioned that I ran it locally with ducker and `adoptopenjdk/openjdk11:debian-slim` and it all worked. -- This is an

[GitHub] [kafka] dajac commented on pull request #12187: KAFKA-13858; Kraft should not shutdown metadata listener until controller shutdown is finished

dajac commented on PR #12187: URL: https://github.com/apache/kafka/pull/12187#issuecomment-1136124352 @hachikuji Thanks for your review. I have updated the PR to address your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12128: KAFKA-10199: Implement adding active tasks to the state updater

guozhangwang commented on code in PR #12128: URL: https://github.com/apache/kafka/pull/12128#discussion_r880691958 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -0,0 +1,373 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12128: KAFKA-10199: Implement adding active tasks to the state updater

guozhangwang commented on code in PR #12128: URL: https://github.com/apache/kafka/pull/12128#discussion_r880690572 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -0,0 +1,373 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lbradstreet opened a new pull request, #12202: MINOR: fix connect system test runs with JDK 10+

lbradstreet opened a new pull request, #12202: URL: https://github.com/apache/kafka/pull/12202 When running system tests with JDK 10+, we hit the following error because util.py attempts to check the version variable for non-Kafka service objects. ``` [INFO:2022-05-23

[GitHub] [kafka] cadonna commented on a diff in pull request #12161: KAFKA-13873 Add ability to Pause / Resume KafkaStreams Topologies

cadonna commented on code in PR #12161: URL: https://github.com/apache/kafka/pull/12161#discussion_r880526257 ## streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java: ## @@ -783,6 +822,28 @@ public void shouldThrowOnCleanupWhileRunning() throws

[GitHub] [kafka] tombentley commented on pull request #12179: [KAFKA-13848] Clients remain connected after SASL re-authentication f…

tombentley commented on PR #12179: URL: https://github.com/apache/kafka/pull/12179#issuecomment-1136007048 @rajinisivaram, @rondagostino please could you take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] nicolasguyomar opened a new pull request, #12201: MINOR : Change to classic quote

nicolasguyomar opened a new pull request, #12201: URL: https://github.com/apache/kafka/pull/12201 Minor change to use ' and not LEFT SINGLE QUOTATION MARK in that log, as it's the only place we are using such quote and it can break some ingestion pipeline *More detailed description

[GitHub] [kafka] dajac commented on a diff in pull request #12181: KAFKA-13916; Fenced replicas should not be allowed to join the ISR in KRaft (KIP-841)

dajac commented on code in PR #12181: URL: https://github.com/apache/kafka/pull/12181#discussion_r880481525 ## metadata/src/main/java/org/apache/kafka/controller/BrokerHeartbeatManager.java: ## @@ -498,6 +498,23 @@ public UsableBroker next() { } } +/** +

[GitHub] [kafka] C0urante commented on a diff in pull request #12191: KAFKA-12657: Increase timeouts in Connect integration tests

C0urante commented on code in PR #12191: URL: https://github.com/apache/kafka/pull/12191#discussion_r880460797 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java: ## @@ -78,8 +79,8 @@ public class BlockingConnectorTest {

[GitHub] [kafka] C0urante commented on a diff in pull request #12191: KAFKA-12657: Increase timeouts in Connect integration tests

C0urante commented on code in PR #12191: URL: https://github.com/apache/kafka/pull/12191#discussion_r880460302 ## connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedConnectClusterAssertions.java: ## @@ -44,9 +44,9 @@ public class

[GitHub] [kafka] cadonna commented on a diff in pull request #12191: KAFKA-12657: Increase timeouts in Connect integration tests

cadonna commented on code in PR #12191: URL: https://github.com/apache/kafka/pull/12191#discussion_r880435973 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java: ## @@ -78,8 +79,8 @@ public class BlockingConnectorTest { private

[GitHub] [kafka] cadonna closed pull request #12137: MINOR: Consolidate StreamsException and TaskCorruptedException

cadonna closed pull request #12137: MINOR: Consolidate StreamsException and TaskCorruptedException URL: https://github.com/apache/kafka/pull/12137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] cadonna commented on a diff in pull request #12200: KAFKA-10199: Implement adding standby tasks to the state updater

cadonna commented on code in PR #12200: URL: https://github.com/apache/kafka/pull/12200#discussion_r880396385 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -127,11 +141,20 @@ private void restoreTasks() throws

[GitHub] [kafka] cadonna commented on a diff in pull request #12200: KAFKA-10199: Implement adding standby tasks to the state updater

cadonna commented on code in PR #12200: URL: https://github.com/apache/kafka/pull/12200#discussion_r880396183 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -74,30 +76,44 @@ public Collection getAllUpdatingTasks() {

[GitHub] [kafka] cadonna commented on a diff in pull request #12200: KAFKA-10199: Implement adding standby tasks to the state updater

cadonna commented on code in PR #12200: URL: https://github.com/apache/kafka/pull/12200#discussion_r880392811 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -74,30 +76,44 @@ public Collection getAllUpdatingTasks() {

[GitHub] [kafka] cadonna opened a new pull request, #12200: KAFKA-10199: Implement adding standby tasks to the state updater

cadonna opened a new pull request, #12200: URL: https://github.com/apache/kafka/pull/12200 This PR adds adding of standby tasks to the default implementation of the state updater. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation -

[GitHub] [kafka] dengziming commented on a diff in pull request #12199: KAFKA-13609: Use INVALID_CONFIG when config value is null or broker config validation fails

dengziming commented on code in PR #12199: URL: https://github.com/apache/kafka/pull/12199#discussion_r880354039 ## core/src/main/scala/kafka/server/ConfigAdminManager.scala: ## @@ -200,11 +200,7 @@ class ConfigAdminManager(nodeId: Int, conf.dynamicConfig.validate(props,

[GitHub] [kafka] dengziming commented on a diff in pull request #12199: KAFKA-13609: Use INVALID_CONFIG when config value is null or broker config validation fails

dengziming commented on code in PR #12199: URL: https://github.com/apache/kafka/pull/12199#discussion_r880354039 ## core/src/main/scala/kafka/server/ConfigAdminManager.scala: ## @@ -200,11 +200,7 @@ class ConfigAdminManager(nodeId: Int, conf.dynamicConfig.validate(props,

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12199: KAFKA-13609: Use INVALID_CONFIG when config value is null or broker config validation fails

divijvaidya commented on code in PR #12199: URL: https://github.com/apache/kafka/pull/12199#discussion_r880303225 ## core/src/main/scala/kafka/server/ConfigAdminManager.scala: ## @@ -200,11 +200,7 @@ class ConfigAdminManager(nodeId: Int,

[GitHub] [kafka] cadonna commented on a diff in pull request #12128: KAFKA-10199: Implement adding active tasks to the state updater

cadonna commented on code in PR #12128: URL: https://github.com/apache/kafka/pull/12128#discussion_r880253871 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -0,0 +1,373 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] cadonna commented on a diff in pull request #12128: KAFKA-10199: Implement adding active tasks to the state updater

cadonna commented on code in PR #12128: URL: https://github.com/apache/kafka/pull/12128#discussion_r880245514 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -0,0 +1,373 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] cadonna commented on a diff in pull request #12128: KAFKA-10199: Implement adding active tasks to the state updater

cadonna commented on code in PR #12128: URL: https://github.com/apache/kafka/pull/12128#discussion_r880243502 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -0,0 +1,373 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] dajac commented on a diff in pull request #12181: KAFKA-13916; Fenced replicas should not be allowed to join the ISR in KRaft (KIP-841)

dajac commented on code in PR #12181: URL: https://github.com/apache/kafka/pull/12181#discussion_r880242635 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -1574,6 +1586,13 @@ class Partition(val topicPartition: TopicPartition, debug(s"Failed to alter

[GitHub] [kafka] dajac commented on a diff in pull request #12181: KAFKA-13916; Fenced replicas should not be allowed to join the ISR in KRaft (KIP-841)

dajac commented on code in PR #12181: URL: https://github.com/apache/kafka/pull/12181#discussion_r880242265 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -1574,6 +1586,13 @@ class Partition(val topicPartition: TopicPartition, debug(s"Failed to alter

[GitHub] [kafka] cadonna commented on a diff in pull request #12128: KAFKA-10199: Implement adding active tasks to the state updater

cadonna commented on code in PR #12128: URL: https://github.com/apache/kafka/pull/12128#discussion_r880242179 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -0,0 +1,373 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Updated] (KAFKA-13932) Replication data loss in some cases

[ https://issues.apache.org/jira/browse/KAFKA-13932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bale updated KAFKA-13932: - Description: *Kafka version: 2.8.0* *Replication flow: A -> B* *Topic: DL2 -> A.DL2*   I use mm2 to replicate

[GitHub] [kafka] cadonna commented on a diff in pull request #12128: KAFKA-10199: Implement adding active tasks to the state updater

cadonna commented on code in PR #12128: URL: https://github.com/apache/kafka/pull/12128#discussion_r880229964 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -0,0 +1,373 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] showuon commented on pull request #12136: KAFKA-13773: catch kafkaStorageException to avoid broker shutdown directly

showuon commented on PR #12136: URL: https://github.com/apache/kafka/pull/12136#issuecomment-1135580274 @junrao , I've updated the PR in this commit: https://github.com/apache/kafka/pull/12136/commits/ca8cb7df7b7fbd17d95e7a34525840b5578fe520. Please take a look again. Thanks. -- This is

[GitHub] [kafka] showuon commented on a diff in pull request #12136: KAFKA-13773: catch kafkaStorageException to avoid broker shutdown directly

showuon commented on code in PR #12136: URL: https://github.com/apache/kafka/pull/12136#discussion_r880228071 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -376,7 +381,9 @@ class LogManager(logDirs: Seq[File],

[jira] [Updated] (KAFKA-13932) Replication data loss in some cases

[ https://issues.apache.org/jira/browse/KAFKA-13932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bale updated KAFKA-13932: - Description: *Kafka version: 2.8.0* *Replication flow: A -> B* *Topic: DL2 -> A.DL2*   I use mm2 to replicate

[jira] [Assigned] (KAFKA-13933) Stuck SSL/TLS unit tests in case of authentication failure.

[ https://issues.apache.org/jira/browse/KAFKA-13933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri reassigned KAFKA-13933: --- Assignee: Federico Valeri > Stuck SSL/TLS unit tests in case of authentication

[GitHub] [kafka] dajac commented on a diff in pull request #12181: KAFKA-13916; Fenced replicas should not be allowed to join the ISR in KRaft (KIP-841)

dajac commented on code in PR #12181: URL: https://github.com/apache/kafka/pull/12181#discussion_r880220434 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -846,21 +846,33 @@ class Partition(val topicPartition: TopicPartition, } private def

[jira] [Updated] (KAFKA-13933) Stuck SSL/TLS unit tests in case of authentication failure.

[ https://issues.apache.org/jira/browse/KAFKA-13933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-13933: Summary: Stuck SSL/TLS unit tests in case of authentication failure. (was: Stuck SSL

[GitHub] [kafka] dengziming opened a new pull request, #12199: KAFKA-13609: Use INVALID_CONFIG when config value is null or broker config validation fails

dengziming opened a new pull request, #12199: URL: https://github.com/apache/kafka/pull/12199 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* 1. Use

[jira] [Updated] (KAFKA-13933) Stuck SSL unit tests in case of authentication failure.

[ https://issues.apache.org/jira/browse/KAFKA-13933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-13933: Summary: Stuck SSL unit tests in case of authentication failure. (was: Stuck SSL tests

[jira] [Updated] (KAFKA-13933) Stuck SSL tests in case of authentication failure.

[ https://issues.apache.org/jira/browse/KAFKA-13933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-13933: Priority: Minor (was: Major) > Stuck SSL tests in case of authentication failure. >

[jira] [Updated] (KAFKA-13933) Stuck SSL tests in case of authentication failure.

[ https://issues.apache.org/jira/browse/KAFKA-13933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-13933: Component/s: unit tests (was: network) > Stuck SSL tests in case of

[jira] [Created] (KAFKA-13933) Stuck SSL tests in case of authentication failure.

Federico Valeri created KAFKA-13933: --- Summary: Stuck SSL tests in case of authentication failure. Key: KAFKA-13933 URL: https://issues.apache.org/jira/browse/KAFKA-13933 Project: Kafka

[GitHub] [kafka] dajac commented on a diff in pull request #12181: KAFKA-13916; Fenced replicas should not be allowed to join the ISR in KRaft (KIP-841)

dajac commented on code in PR #12181: URL: https://github.com/apache/kafka/pull/12181#discussion_r880214925 ## metadata/src/main/java/org/apache/kafka/controller/BrokerHeartbeatManager.java: ## @@ -498,6 +498,23 @@ public UsableBroker next() { } } +/** +

[GitHub] [kafka] fvaleri commented on a diff in pull request #12159: MINOR: Fix stuck SSL tests in case of authentication failure

fvaleri commented on code in PR #12159: URL: https://github.com/apache/kafka/pull/12159#discussion_r880201978 ## clients/src/test/java/org/apache/kafka/common/network/NetworkTestUtils.java: ## @@ -87,6 +88,16 @@ public static void checkClientConnection(Selector selector,

[GitHub] [kafka] fvaleri commented on a diff in pull request #12159: MINOR: Fix stuck SSL tests in case of authentication failure

fvaleri commented on code in PR #12159: URL: https://github.com/apache/kafka/pull/12159#discussion_r880201691 ## clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java: ## @@ -603,23 +603,18 @@ private void verifyChannelExpiry(KafkaChannel channel) throws

[GitHub] [kafka] dajac commented on a diff in pull request #12187: KAFKA-13858; Kraft should not shutdown metadata listener until controller shutdown is finished

dajac commented on code in PR #12187: URL: https://github.com/apache/kafka/pull/12187#discussion_r880194784 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -2141,23 +2141,22 @@ class ReplicaManager(val config: KafkaConfig,

[GitHub] [kafka] dajac commented on a diff in pull request #12187: KAFKA-13858; Kraft should not shutdown metadata listener until controller shutdown is finished

dajac commented on code in PR #12187: URL: https://github.com/apache/kafka/pull/12187#discussion_r880193539 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -2134,20 +2141,22 @@ class ReplicaManager(val config: KafkaConfig,

[jira] [Updated] (KAFKA-13932) Replication data loss in some cases

[ https://issues.apache.org/jira/browse/KAFKA-13932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bale updated KAFKA-13932: - Description: Kafka version: 2.8.0 Replication flow: A -> B Topic: DL2 -> A.DL2   I use mm2 to replicate cluster

[jira] [Updated] (KAFKA-13932) Replication data loss in some cases

[ https://issues.apache.org/jira/browse/KAFKA-13932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bale updated KAFKA-13932: - Attachment: offset2.png offset3.png > Replication data loss in some cases >

[jira] [Updated] (KAFKA-13932) Replication data loss in some cases

[ https://issues.apache.org/jira/browse/KAFKA-13932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bale updated KAFKA-13932: - Attachment: offset1.png > Replication data loss in some cases > --- > >

[jira] [Updated] (KAFKA-13932) Replication data loss in some cases

[ https://issues.apache.org/jira/browse/KAFKA-13932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bale updated KAFKA-13932: - Attachment: connect-mirror-maker.properties > Replication data loss in some cases >

[jira] [Updated] (KAFKA-13932) Replication data loss in some cases

[ https://issues.apache.org/jira/browse/KAFKA-13932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bale updated KAFKA-13932: - Description: Kafka version: 2.8.0 Replication flow: A -> B Topic: DL2 -> A.DL2   I use mm2 to replicate cluster

[jira] [Updated] (KAFKA-13932) Replication data loss in some cases

[ https://issues.apache.org/jira/browse/KAFKA-13932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bale updated KAFKA-13932: - Priority: Minor (was: Major) > Replication data loss in some cases > --- > >

[jira] [Updated] (KAFKA-13932) Replication data loss in some cases

[ https://issues.apache.org/jira/browse/KAFKA-13932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bale updated KAFKA-13932: - Description: Kafka version: 2.8.0 Replication flow: A -> B Topic: DL2 -> A.DL2   I use mm2 to replicate cluster

[jira] [Created] (KAFKA-13932) Replication data loss in some cases

Bale created KAFKA-13932: Summary: Replication data loss in some cases Key: KAFKA-13932 URL: https://issues.apache.org/jira/browse/KAFKA-13932 Project: Kafka Issue Type: Bug Components:

[GitHub] [kafka] dajac commented on a diff in pull request #12187: KAFKA-13858; Kraft should not shutdown metadata listener until controller shutdown is finished

dajac commented on code in PR #12187: URL: https://github.com/apache/kafka/pull/12187#discussion_r880181278 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -2170,33 +2179,47 @@ class ReplicaManager(val config: KafkaConfig, } } -// Stopping the

[GitHub] [kafka] dajac commented on a diff in pull request #12187: KAFKA-13858; Kraft should not shutdown metadata listener until controller shutdown is finished

dajac commented on code in PR #12187: URL: https://github.com/apache/kafka/pull/12187#discussion_r880180144 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -2123,7 +2129,8 @@ class ReplicaManager(val config: KafkaConfig,

[GitHub] [kafka] dajac commented on a diff in pull request #12187: KAFKA-13858; Kraft should not shutdown metadata listener until controller shutdown is finished

dajac commented on code in PR #12187: URL: https://github.com/apache/kafka/pull/12187#discussion_r880176824 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -706,7 +706,7 @@ class Partition(val topicPartition: TopicPartition, s"and partition state

[GitHub] [kafka] dajac merged pull request #12173: MINOR: Add 3.0 to streams system tests (for 3.1 branch)

dajac merged PR #12173: URL: https://github.com/apache/kafka/pull/12173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-13848) Clients remain connected after SASL re-authentication fails

[ https://issues.apache.org/jira/browse/KAFKA-13848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17541293#comment-17541293 ] Luke Chen commented on KAFKA-13848: --- [~acsaki] , thanks for reporting the issue. The change makes

[jira] [Commented] (KAFKA-10659) Cogroup topology generation fails if input streams are repartitioned

[ https://issues.apache.org/jira/browse/KAFKA-10659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17541289#comment-17541289 ] Massimiliano Leone commented on KAFKA-10659: Hi to All, I also got same problem. Here my

  1   2   >