[
https://issues.apache.org/jira/browse/KAFKA-14000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xinyu Zou updated KAFKA-14000:
--
Description:
I'm using Kafka-connect distributed mode. There're two servers. One active and
one
[
https://issues.apache.org/jira/browse/KAFKA-14000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xinyu Zou updated KAFKA-14000:
--
Attachment: kafka-connect-trace.log
> Kafka-connect standby server shows empty tasks list
>
Xinyu Zou created KAFKA-14000:
-
Summary: Kafka-connect standby server shows empty tasks list
Key: KAFKA-14000
URL: https://issues.apache.org/jira/browse/KAFKA-14000
Project: Kafka
Issue Type:
[
https://issues.apache.org/jira/browse/KAFKA-12478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554884#comment-17554884
]
hudeqi commented on KAFKA-12478:
Hello, Guozhang. I have started a vote on KIP-842 for this issue. Does
C0urante commented on PR #11781:
URL: https://github.com/apache/kafka/pull/11781#issuecomment-1157162231
Hey guys--thanks for the reviews, really appreciate the rapid responses
here. I found a bug that's been a bit trickier to solve than expected and have
had little time to work on it this
bozhao12 commented on PR #12286:
URL: https://github.com/apache/kafka/pull/12286#issuecomment-1157064520
@divijvaidya Thanks for your review. I add a unit test based on your
suggestion. Due to the restart operation involved, I put this unit test in
Artem Livshits created KAFKA-13999:
--
Summary: Add ProducerCount metrics (KIP-847)
Key: KAFKA-13999
URL: https://issues.apache.org/jira/browse/KAFKA-13999
Project: Kafka
Issue Type:
mdedetrich commented on PR #12284:
URL: https://github.com/apache/kafka/pull/12284#issuecomment-1156984238
> Is there something you're looking for in 2.12.16?
So I already had a detailed look into this, it only occurs at compile time
(see
ijuma commented on PR #12284:
URL: https://github.com/apache/kafka/pull/12284#issuecomment-1156981130
I notice there's a regression:
> Scala 2.12.16 contains a https://github.com/scala/bug/issues/12605 that
was discovered after the artifacts were published. Only mixed compilation of
ijuma commented on code in PR #12241:
URL: https://github.com/apache/kafka/pull/12241#discussion_r898459208
##
docs/upgrade.html:
##
@@ -1265,7 +1265,7 @@ Notable changes in 1
on live log directories even if there are offline log directories. A
log directory may
ijuma closed pull request #12241: MINOR: Fix docs in upgrade.html
URL: https://github.com/apache/kafka/pull/12241
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
jnh5y opened a new pull request, #12299:
URL: https://github.com/apache/kafka/pull/12299
…ring rebalancing.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation
jnh5y commented on PR #12298:
URL: https://github.com/apache/kafka/pull/12298#issuecomment-1156967918
I tried to find a way to create a unit test for this change, but I wasn't
able to do so quickly. If someone has a suggestion for how to do that, I'm
happy to follow through with it.
--
jnh5y opened a new pull request, #12298:
URL: https://github.com/apache/kafka/pull/12298
This fix follows the pattern which is established in
`AbstractCoordinator.java` of setting the request reason with the method
`requestRejoin`.
### Committer Checklist (excluded from commit
bozhao12 commented on code in PR #12241:
URL: https://github.com/apache/kafka/pull/12241#discussion_r898448690
##
docs/upgrade.html:
##
@@ -1265,7 +1265,7 @@ Notable changes in 1
on live log directories even if there are offline log directories. A
log directory may
Jim Hughes created KAFKA-13998:
--
Summary: JoinGroupRequestData 'reason' can be too large
Key: KAFKA-13998
URL: https://issues.apache.org/jira/browse/KAFKA-13998
Project: Kafka
Issue Type: Bug
guozhangwang commented on PR #12121:
URL: https://github.com/apache/kafka/pull/12121#issuecomment-1156954295
> @guozhangwang , which file does this correspond to? that update the web
docs on 3.3 release new API changes
Here:
mjsax commented on code in PR #12204:
URL: https://github.com/apache/kafka/pull/12204#discussion_r898411852
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedSessionStore.java:
##
@@ -61,6 +65,18 @@ public QueryResult query(final Query query,
mjsax commented on code in PR #12204:
URL: https://github.com/apache/kafka/pull/12204#discussion_r898406030
##
streams/src/main/java/org/apache/kafka/streams/state/SessionStore.java:
##
@@ -39,6 +39,13 @@
*/
public interface SessionStore extends StateStore,
guozhangwang commented on code in PR #12204:
URL: https://github.com/apache/kafka/pull/12204#discussion_r880784817
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedSessionStore.java:
##
@@ -61,6 +65,18 @@ public QueryResult query(final Query
mjsax commented on code in PR #12204:
URL: https://github.com/apache/kafka/pull/12204#discussion_r898340071
##
streams/src/main/java/org/apache/kafka/streams/state/internals/InMemorySessionStore.java:
##
@@ -202,25 +205,43 @@ public void remove(final Windowed sessionKey) {
mjsax commented on code in PR #12204:
URL: https://github.com/apache/kafka/pull/12204#discussion_r898339592
##
streams/src/main/java/org/apache/kafka/streams/state/internals/InMemorySessionStore.java:
##
@@ -202,25 +205,43 @@ public void remove(final Windowed sessionKey) {
[
https://issues.apache.org/jira/browse/KAFKA-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554742#comment-17554742
]
Matthias J. Sax commented on KAFKA-13939:
-
Thanks for the PR. I added you to list of
[
https://issues.apache.org/jira/browse/KAFKA-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-13939:
---
Assignee: Jackson Newhouse
> Memory Leak When Logging Is Disabled In
[
https://issues.apache.org/jira/browse/KAFKA-13888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554738#comment-17554738
]
Niket Goel commented on KAFKA-13888:
The PR that adds the API to handler to the admin client
[
https://issues.apache.org/jira/browse/KAFKA-13888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554738#comment-17554738
]
Niket Goel edited comment on KAFKA-13888 at 6/15/22 5:59 PM:
-
The PR that
mjsax commented on code in PR #12293:
URL: https://github.com/apache/kafka/pull/12293#discussion_r898266334
##
streams/src/main/java/org/apache/kafka/streams/TopologyDescription.java:
##
@@ -30,6 +30,7 @@
* In contrast, two sub-topologies are not connected but can be linked
niket-goel commented on PR #12212:
URL: https://github.com/apache/kafka/pull/12212#issuecomment-1156768917
Hey @lqjack . Thanks for raising this PR. The PR
https://github.com/apache/kafka/pull/12206 has now been merged to trunk. Can
you please update your PR with the latest code so we can
vamossagar12 commented on PR #12121:
URL: https://github.com/apache/kafka/pull/12121#issuecomment-1156764298
@ijuma ., i updated the PR name. Also, created a follow up PR to address
some of the comments: https://github.com/apache/kafka/pull/12297
@guozhangwang , which file does this
philipnee commented on PR #12149:
URL: https://github.com/apache/kafka/pull/12149#issuecomment-1156747595
@ijuma - I think @hachikuji is reviewing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
clolov commented on PR #12285:
URL: https://github.com/apache/kafka/pull/12285#issuecomment-1156744613
Hello! Thank you to everyone who has left a comment and suggestions for
improvement. In the next few days I will aim to rework this pull request. In
summary:
* I will revert the import
divijvaidya commented on code in PR #12233:
URL: https://github.com/apache/kafka/pull/12233#discussion_r898241099
##
metadata/src/test/java/org/apache/kafka/controller/BootstrapMetadataTest.java:
##
@@ -31,9 +35,21 @@
import static org.junit.jupiter.api.Assertions.assertTrue;
mdedetrich commented on code in PR #12284:
URL: https://github.com/apache/kafka/pull/12284#discussion_r898217940
##
docs/upgrade.html:
##
@@ -59,6 +59,9 @@ Upgrading to
3.2.0 from any vers
(or to take advantage of exactly once semantics),
the newer Java
ijuma commented on PR #12149:
URL: https://github.com/apache/kafka/pull/12149#issuecomment-1156718718
@philipnee where are we with this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ijuma commented on PR #12148:
URL: https://github.com/apache/kafka/pull/12148#issuecomment-1156718290
@omkreddy maybe you can help review this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mdedetrich commented on code in PR #12284:
URL: https://github.com/apache/kafka/pull/12284#discussion_r898217940
##
docs/upgrade.html:
##
@@ -59,6 +59,9 @@ Upgrading to
3.2.0 from any vers
(or to take advantage of exactly once semantics),
the newer Java
ijuma closed pull request #12232: MINOR:rm deprecated method
URL: https://github.com/apache/kafka/pull/12232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
ijuma commented on PR #12232:
URL: https://github.com/apache/kafka/pull/12232#issuecomment-1156711344
Yes, we only remove deprecated methods during major releases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
ijuma commented on PR #12233:
URL: https://github.com/apache/kafka/pull/12233#issuecomment-1156710957
Thanks for the PR. It looks reasonable, just one nit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
ijuma commented on code in PR #12233:
URL: https://github.com/apache/kafka/pull/12233#discussion_r898209292
##
metadata/src/test/java/org/apache/kafka/controller/BootstrapMetadataTest.java:
##
@@ -31,9 +35,21 @@
import static org.junit.jupiter.api.Assertions.assertTrue;
ijuma commented on code in PR #12241:
URL: https://github.com/apache/kafka/pull/12241#discussion_r898207431
##
docs/upgrade.html:
##
@@ -1265,7 +1265,7 @@ Notable changes in 1
on live log directories even if there are offline log directories. A
log directory may
ijuma commented on PR #12278:
URL: https://github.com/apache/kafka/pull/12278#issuecomment-1156706455
Do we have a KIP for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
ijuma commented on PR #12290:
URL: https://github.com/apache/kafka/pull/12290#issuecomment-1156705915
@kkonstantine can you please review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ijuma commented on code in PR #12284:
URL: https://github.com/apache/kafka/pull/12284#discussion_r898205328
##
docs/upgrade.html:
##
@@ -59,6 +59,9 @@ Upgrading to
3.2.0 from any vers
(or to take advantage of exactly once semantics),
the newer Java clients
ijuma commented on PR #12285:
URL: https://github.com/apache/kafka/pull/12285#issuecomment-1156705224
> Worth putting in a separate PR, but have you tried enabling the Jupiter
parallel test runner? When I ran it on a work project, it improved build times
by an order of magnitude
We
[
https://issues.apache.org/jira/browse/KAFKA-13888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson reopened KAFKA-13888:
-
> KIP-836: Addition of Information in DescribeQuorumResponse about Voter Lag
>
hachikuji commented on PR #12212:
URL: https://github.com/apache/kafka/pull/12212#issuecomment-1156686396
@lqjack Can you merge with trunk please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/KAFKA-13888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-13888.
-
Fix Version/s: 3.3.0
Resolution: Fixed
> KIP-836: Addition of Information in
hachikuji merged PR #12206:
URL: https://github.com/apache/kafka/pull/12206
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dajac closed pull request #12292: MINOR: KRaft nodes not shutdown correctly
when using one controller in colocated mode
URL: https://github.com/apache/kafka/pull/12292
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
dajac commented on PR #12292:
URL: https://github.com/apache/kafka/pull/12292#issuecomment-1156567953
Already fixed by https://github.com/apache/kafka/pull/11238.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
dajac merged PR #11238:
URL: https://github.com/apache/kafka/pull/11238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tyamashi-oss opened a new pull request, #12296:
URL: https://github.com/apache/kafka/pull/12296
- Implementation:
- Add updateDesiredRatePerSec() on Throttler
- Call updateDesiredRatePerSec() of Throttler with new
log.cleaner.io.max.bytes.per.second value in reconfigure() of Log
Tomonari Yamashita created KAFKA-13996:
--
Summary: log.cleaner.io.max.bytes.per.second cannot be changed
dynamically
Key: KAFKA-13996
URL: https://issues.apache.org/jira/browse/KAFKA-13996
[
https://issues.apache.org/jira/browse/KAFKA-13997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Naveen P updated KAFKA-13997:
-
Description:
We have issue with one of our topic in kafka cluster, which is taking huge
space, while
Naveen P created KAFKA-13997:
Summary: one partition logs are not getting purged
Key: KAFKA-13997
URL: https://issues.apache.org/jira/browse/KAFKA-13997
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-13995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554577#comment-17554577
]
Devarshi Shah commented on KAFKA-13995:
---
A kind request to answer as soon as possible as it's
[
https://issues.apache.org/jira/browse/KAFKA-13995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Devarshi Shah updated KAFKA-13995:
--
Description: I've gone through the Apache Kafka Documentation. It does not
contain
Devarshi Shah created KAFKA-13995:
-
Summary: Does Kafka support Network File System (NFS)? Is it
recommended in Production?
Key: KAFKA-13995
URL: https://issues.apache.org/jira/browse/KAFKA-13995
divijvaidya commented on PR #12224:
URL: https://github.com/apache/kafka/pull/12224#issuecomment-1156428420
@jsancio please review when you get a chance. Currently multiple tests in
`QuorumControllerTest` are acting flaky because we are allowing to create a
snapshot with LONG_MAX value.
[
https://issues.apache.org/jira/browse/KAFKA-13943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya reassigned KAFKA-13943:
Assignee: Divij Vaidya
> Fix flaky test
divijvaidya commented on code in PR #12284:
URL: https://github.com/apache/kafka/pull/12284#discussion_r897932645
##
docs/upgrade.html:
##
@@ -59,6 +59,9 @@ Upgrading to
3.2.0 from any vers
(or to take advantage of exactly once semantics),
the newer Java
divijvaidya commented on PR #12284:
URL: https://github.com/apache/kafka/pull/12284#issuecomment-1156421242
cc: @ijuma (since you seem have performed scala upgrades in the past)
The test failures do not seem related to this code change to me.
--
This is an automated message from
divijvaidya commented on PR #12286:
URL: https://github.com/apache/kafka/pull/12286#issuecomment-1156415549
@bozhao12 can you please add a unit test in
`TopicBasedRemoteLogMetadataManagerTest` that fails before this change and
succeeds after this change.
--
This is an automated message
cadonna commented on PR #10881:
URL: https://github.com/apache/kafka/pull/10881#issuecomment-1156400720
@wycc Do you plan to still work on this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
cadonna commented on PR #10881:
URL: https://github.com/apache/kafka/pull/10881#issuecomment-1156398967
@clolov Thank you for your interest and help! Since this PR was not touched
more than half a year, I would be fine to close it and you can open a new one.
--
This is an automated
cadonna commented on PR #12285:
URL: https://github.com/apache/kafka/pull/12285#issuecomment-1156391414
@clolov Thank you for the PR!
I agree with @divijvaidya about doing the reformatting in a separate PR.
Could you also try to subdivide the PR into smaller PRs? Reviewing a 6500 line
jnh5y commented on PR #12161:
URL: https://github.com/apache/kafka/pull/12161#issuecomment-1156385644
>
> @jnh5y Thank you for the updates!
>
> LGTM!
>
> Had just one nit.
>
> Thank you for your patience!
@cadonna Thank you for pushing me and
jnh5y commented on code in PR #12161:
URL: https://github.com/apache/kafka/pull/12161#discussion_r897893883
##
streams/src/test/java/org/apache/kafka/streams/integration/PauseResumeIntegrationTest.java:
##
@@ -0,0 +1,422 @@
+/*
+ * Licensed to the Apache Software Foundation
cadonna commented on code in PR #12161:
URL: https://github.com/apache/kafka/pull/12161#discussion_r897887371
##
streams/src/test/java/org/apache/kafka/streams/integration/PauseResumeIntegrationTest.java:
##
@@ -0,0 +1,422 @@
+/*
+ * Licensed to the Apache Software Foundation
jnh5y commented on code in PR #12161:
URL: https://github.com/apache/kafka/pull/12161#discussion_r897869162
##
streams/src/test/java/org/apache/kafka/streams/integration/PauseResumeIntegrationTest.java:
##
@@ -335,7 +333,39 @@ public void pauseResumehouldWorkAcrossInstances()
jnh5y commented on code in PR #12161:
URL: https://github.com/apache/kafka/pull/12161#discussion_r897868472
##
streams/src/test/java/org/apache/kafka/streams/integration/PauseResumeIntegrationTest.java:
##
@@ -335,7 +333,39 @@ public void pauseResumehouldWorkAcrossInstances()
divijvaidya commented on PR #12230:
URL: https://github.com/apache/kafka/pull/12230#issuecomment-1156355538
@dengziming @showuon please review this small change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
divijvaidya commented on PR #12229:
URL: https://github.com/apache/kafka/pull/12229#issuecomment-1156352282
@mimaison perhaps you may want to look into this? This already has 2
approvals from non-committers.
--
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/KAFKA-13386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554526#comment-17554526
]
Kin Siu commented on KAFKA-13386:
-
[~guozhang], I am not sure if what I faced is same as [~sduran], but
divijvaidya commented on PR #12229:
URL: https://github.com/apache/kafka/pull/12229#issuecomment-1156349743
> Can this kind of problem be caught by spotbugs? manual checking is error
prone.
> Can this kind of problem be caught by spotbugs? manual checking is error
prone.
divijvaidya commented on PR #12229:
URL: https://github.com/apache/kafka/pull/12229#issuecomment-1156349744
> Can this kind of problem be caught by spotbugs? manual checking is error
prone.
> Can this kind of problem be caught by spotbugs? manual checking is error
prone.
divijvaidya commented on code in PR #12045:
URL: https://github.com/apache/kafka/pull/12045#discussion_r897838652
##
clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java:
##
@@ -34,35 +35,56 @@
*/
public abstract class SampledStat implements
Divij Vaidya created KAFKA-13994:
Summary: Incorrect quota calculation due to a bug
Key: KAFKA-13994
URL: https://issues.apache.org/jira/browse/KAFKA-13994
Project: Kafka
Issue Type: Bug
divijvaidya commented on PR #12184:
URL: https://github.com/apache/kafka/pull/12184#issuecomment-1156329800
@dajac @guozhangwang please review when you get a chance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
cadonna commented on code in PR #12161:
URL: https://github.com/apache/kafka/pull/12161#discussion_r897835619
##
streams/src/test/java/org/apache/kafka/streams/integration/PauseResumeIntegrationTest.java:
##
@@ -335,7 +333,39 @@ public void pauseResumehouldWorkAcrossInstances()
tombentley commented on code in PR #11781:
URL: https://github.com/apache/kafka/pull/11781#discussion_r897830233
##
connect/runtime/src/main/java/org/apache/kafka/connect/util/TopicAdmin.java:
##
@@ -274,18 +276,23 @@ public static NewTopicBuilder defineTopic(String
topicName)
cadonna commented on code in PR #12161:
URL: https://github.com/apache/kafka/pull/12161#discussion_r897818350
##
streams/src/test/java/org/apache/kafka/streams/integration/PauseResumeIntegrationTest.java:
##
@@ -335,7 +333,39 @@ public void pauseResumehouldWorkAcrossInstances()
[
https://issues.apache.org/jira/browse/KAFKA-13993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomohiro Hashidate updated KAFKA-13993:
---
Description:
LogCleaner builds a Cleaner instance in the following way.
tombentley commented on code in PR #11781:
URL: https://github.com/apache/kafka/pull/11781#discussion_r897812219
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java:
##
@@ -1327,30 +1334,39 @@ public WorkerTask doBuild(Task task,
[
https://issues.apache.org/jira/browse/KAFKA-13993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomohiro Hashidate updated KAFKA-13993:
---
Description:
LogCleaner builds a Cleaner instance in the following way.
Tomohiro Hashidate created KAFKA-13993:
--
Summary: Large log.cleaner.buffer.size config breaks Kafka Broker
Key: KAFKA-13993
URL: https://issues.apache.org/jira/browse/KAFKA-13993
Project: Kafka
cadonna commented on code in PR #12161:
URL: https://github.com/apache/kafka/pull/12161#discussion_r897789473
##
streams/src/test/java/org/apache/kafka/streams/integration/PauseResumeIntegrationTest.java:
##
@@ -335,7 +333,39 @@ public void pauseResumehouldWorkAcrossInstances()
mdedetrich commented on PR #12284:
URL: https://github.com/apache/kafka/pull/12284#issuecomment-1156251953
@divijvaidya Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
divijvaidya commented on PR #12284:
URL: https://github.com/apache/kafka/pull/12284#issuecomment-1156237309
@mdedetrich could you please re-run the tests (by pushing another commit or
by rebasing from trunk & force pushing). It would be ideal if we have a clean
test run (with known flaky
divijvaidya commented on code in PR #12045:
URL: https://github.com/apache/kafka/pull/12045#discussion_r897722547
##
clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java:
##
@@ -608,14 +609,14 @@ public void testRateWindowing() throws Exception {
divijvaidya commented on code in PR #12045:
URL: https://github.com/apache/kafka/pull/12045#discussion_r897733191
##
clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java:
##
@@ -34,35 +35,56 @@
*/
public abstract class SampledStat implements
divijvaidya commented on code in PR #12045:
URL: https://github.com/apache/kafka/pull/12045#discussion_r897733191
##
clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java:
##
@@ -34,35 +35,56 @@
*/
public abstract class SampledStat implements
divijvaidya commented on code in PR #12045:
URL: https://github.com/apache/kafka/pull/12045#discussion_r897724648
##
clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java:
##
@@ -84,13 +106,7 @@ public Sample current(long timeMs) {
public Sample
divijvaidya commented on code in PR #12045:
URL: https://github.com/apache/kafka/pull/12045#discussion_r897724922
##
clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.java:
##
@@ -68,24 +68,55 @@ public double measure(MetricConfig config, long now) {
}
divijvaidya commented on code in PR #12045:
URL: https://github.com/apache/kafka/pull/12045#discussion_r897721779
##
clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java:
##
@@ -149,13 +149,14 @@ private void verifyStats(Function
metricValueFunc) {
fred-ro commented on PR #12201:
URL: https://github.com/apache/kafka/pull/12201#issuecomment-1156048902
Is it possible to back ported it to branch 2.8 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
tkaszuba commented on code in PR #12293:
URL: https://github.com/apache/kafka/pull/12293#discussion_r897565836
##
streams/src/main/java/org/apache/kafka/streams/TopologyDescription.java:
##
@@ -30,6 +30,7 @@
* In contrast, two sub-topologies are not connected but can be
98 matches
Mail list logo
