guozhangwang commented on code in PR #12466:
URL: https://github.com/apache/kafka/pull/12466#discussion_r943076070
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -656,6 +657,71 @@ boolean tryToCompleteRestoration(final long now,
badaiaqrandista commented on code in PR #12416:
URL: https://github.com/apache/kafka/pull/12416#discussion_r943043296
##
core/src/test/scala/unit/kafka/network/SocketServerTest.scala:
##
@@ -1878,6 +1878,40 @@ class SocketServerTest {
}, false)
}
+ /**
+ * Test to
guozhangwang commented on PR #12466:
URL: https://github.com/apache/kafka/pull/12466#issuecomment-1211439884
> In Tasks on line 141 and line 163 why do we not verify that the task ID is
contained in map and throw an IllegalStateException if not as we do for
standbyTasksPerId? In the end
jolshan opened a new pull request, #12501:
URL: https://github.com/apache/kafka/pull/12501
Changes for
[KIP-854](https://cwiki.apache.org/confluence/display/KAFKA/KIP-854+Separate+configuration+for+producer+ID+expiry)
We add the producer id expiration configuration and a test.
[
https://issues.apache.org/jira/browse/KAFKA-14114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Niket Goel resolved KAFKA-14114.
Resolution: Fixed
ahuang98 commented on code in PR #12479:
URL: https://github.com/apache/kafka/pull/12479#discussion_r942970441
##
core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala:
##
@@ -187,264 +220,337 @@ class DeleteTopicTest extends QuorumTestHarness {
}.toSet
}
-
jsancio commented on code in PR #12498:
URL: https://github.com/apache/kafka/pull/12498#discussion_r942968751
##
core/src/main/scala/kafka/raft/RaftManager.scala:
##
@@ -181,12 +180,7 @@ class KafkaRaftManager[T](
val expirationTimer = new
hachikuji commented on code in PR #12498:
URL: https://github.com/apache/kafka/pull/12498#discussion_r942966254
##
core/src/main/scala/kafka/raft/RaftManager.scala:
##
@@ -181,12 +180,7 @@ class KafkaRaftManager[T](
val expirationTimer = new
jsancio commented on code in PR #12498:
URL: https://github.com/apache/kafka/pull/12498#discussion_r942961893
##
core/src/main/scala/kafka/raft/RaftManager.scala:
##
@@ -181,12 +180,7 @@ class KafkaRaftManager[T](
val expirationTimer = new
hachikuji commented on code in PR #12469:
URL: https://github.com/apache/kafka/pull/12469#discussion_r942910479
##
core/src/main/scala/kafka/admin/MetadataQuorumCommand.scala:
##
@@ -0,0 +1,109 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
hachikuji commented on PR #12499:
URL: https://github.com/apache/kafka/pull/12499#issuecomment-1211245795
> So we prevent sending the request if the epoch is lower? And is it the
case, that there is always a controller with an epoch at least as large? Or in
some cases would we need to
dplavcic commented on PR #11792:
URL: https://github.com/apache/kafka/pull/11792#issuecomment-1211235309
Hi @clolov, just an info, to avoid duplicate work..
I've started working on this one few days ago.
There is a Jira ticket: [Replace EasyMock and PowerMock with Mockito for
hachikuji commented on code in PR #12499:
URL: https://github.com/apache/kafka/pull/12499#discussion_r942874759
##
core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala:
##
@@ -317,21 +373,24 @@ class BrokerToControllerRequestThread(
override def
Mickael Maison created KAFKA-14160:
--
Summary: Streamline clusterId retrieval in Connect
Key: KAFKA-14160
URL: https://issues.apache.org/jira/browse/KAFKA-14160
Project: Kafka
Issue Type:
mdedetrich commented on PR #12475:
URL: https://github.com/apache/kafka/pull/12475#issuecomment-1211144083
@ijuma Thanks for the pickup.
I have investigated the root cause of the problem, basically when you
specify the scala version with `-PscalaVersion=2.12` it also happens to
splett2 commented on code in PR #12416:
URL: https://github.com/apache/kafka/pull/12416#discussion_r942768273
##
core/src/test/scala/unit/kafka/network/SocketServerTest.scala:
##
@@ -1878,6 +1878,40 @@ class SocketServerTest {
}, false)
}
+ /**
+ * Test to ensure
mnegodaev commented on code in PR #11442:
URL: https://github.com/apache/kafka/pull/11442#discussion_r94270
##
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/SetSchemaMetadata.java:
##
@@ -71,7 +78,7 @@ public R apply(R record) {
[
https://issues.apache.org/jira/browse/KAFKA-14130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17578081#comment-17578081
]
xiangde commented on KAFKA-14130:
-
Hi, I am new to Kafka and noticed that this issue is tagged as
mnegodaev commented on code in PR #11442:
URL: https://github.com/apache/kafka/pull/11442#discussion_r94270
##
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/SetSchemaMetadata.java:
##
@@ -71,7 +78,7 @@ public R apply(R record) {
mnegodaev commented on code in PR #11442:
URL: https://github.com/apache/kafka/pull/11442#discussion_r94270
##
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/SetSchemaMetadata.java:
##
@@ -71,7 +78,7 @@ public R apply(R record) {
mnegodaev commented on code in PR #11442:
URL: https://github.com/apache/kafka/pull/11442#discussion_r94270
##
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/SetSchemaMetadata.java:
##
@@ -71,7 +78,7 @@ public R apply(R record) {
mnegodaev commented on code in PR #11442:
URL: https://github.com/apache/kafka/pull/11442#discussion_r94270
##
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/SetSchemaMetadata.java:
##
@@ -71,7 +78,7 @@ public R apply(R record) {
C0urante commented on PR #12473:
URL: https://github.com/apache/kafka/pull/12473#issuecomment-1211000855
@ijuma @divijvaidya I'm pretty tied up this week and next, but can
definitely provide a first review by the end of the week after. Please feel
free to ping me if I still haven't left a
ijuma commented on PR #11792:
URL: https://github.com/apache/kafka/pull/11792#issuecomment-1210995024
Thanks @clolov !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
clolov commented on PR #11792:
URL: https://github.com/apache/kafka/pull/11792#issuecomment-1210983259
Hey @ijuma! Divij is taking some time off, but I can have a look in the
meantime and try to get it over the line.
--
This is an automated message from the Apache Git Service.
To respond
jolshan commented on PR #12499:
URL: https://github.com/apache/kafka/pull/12499#issuecomment-1210963384
> This patch fixes the problem by ensuring that AlterPartition is sent to a
controller with an epoch which is at least as large as that of the controller
which sent the LeaderAndIsr
[
https://issues.apache.org/jira/browse/KAFKA-13978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-13978:
Fix Version/s: (was: 3.3.0)
> Trigger UncaughtExceptionHandler for IllegalArgument and
[
https://issues.apache.org/jira/browse/KAFKA-12887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17578061#comment-17578061
]
Ismael Juma commented on KAFKA-12887:
-
Reopened the Jira since the PR was reverted.
> Do not
[
https://issues.apache.org/jira/browse/KAFKA-12887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma reopened KAFKA-12887:
-
> Do not trigger user-customized ExceptionalHandler for RTE
>
ijuma commented on PR #12352:
URL: https://github.com/apache/kafka/pull/12352#issuecomment-1210956343
Removing the 3.3 label given the comment from @vvcephei. If it is a blocker
for 3.3, please provide the rationale.
--
This is an automated message from the Apache Git Service.
To respond
jsancio commented on code in PR #12274:
URL: https://github.com/apache/kafka/pull/12274#discussion_r942583448
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -759,7 +759,7 @@ public void run() throws Exception {
int i = 1;
IvanVas commented on PR #11023:
URL: https://github.com/apache/kafka/pull/11023#issuecomment-1210903121
@jsancio Hi! Could you help?
How should I proceed with the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/KAFKA-13364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna resolved KAFKA-13364.
---
Resolution: Invalid
> SQL Processor Alerts Creation when Failed
>
[
https://issues.apache.org/jira/browse/KAFKA-13638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna resolved KAFKA-13638.
---
Resolution: Cannot Reproduce
> Slow KTable update when forwarding multiple values from
vvcephei commented on PR #12352:
URL: https://github.com/apache/kafka/pull/12352#issuecomment-1210796778
Hey @Smeb , I just checked trunk and 3.3, and I don't see the code that
you're removing in your PR. It seems like someone else may have fixed this
issue in the mean time. Can you
[
https://issues.apache.org/jira/browse/KAFKA-13978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17578023#comment-17578023
]
John Roesler commented on KAFKA-13978:
--
Hey [~bryves] , I just checked trunk and 3.3, and I don't
cadonna commented on code in PR #12466:
URL: https://github.com/apache/kafka/pull/12466#discussion_r942289824
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -298,13 +298,12 @@ public void handleAssignment(final Map> activeTasks,
ijuma commented on code in PR #12349:
URL: https://github.com/apache/kafka/pull/12349#discussion_r942511881
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java:
##
@@ -1299,17 +1300,79 @@ public void
ijuma opened a new pull request, #12500:
URL: https://github.com/apache/kafka/pull/12500
Follow up from here
https://github.com/apache/kafka/pull/12349#discussion_r925138410
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ]
ijuma commented on code in PR #12349:
URL: https://github.com/apache/kafka/pull/12349#discussion_r942511881
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java:
##
@@ -1299,17 +1300,79 @@ public void
ijuma commented on PR #12277:
URL: https://github.com/apache/kafka/pull/12277#issuecomment-1210721500
We should check if this code is used in a concurrent context. Will leave it
to @C0urante.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
ijuma commented on code in PR #12282:
URL: https://github.com/apache/kafka/pull/12282#discussion_r942492154
##
core/src/main/scala/kafka/utils/Logging.scala:
##
@@ -27,7 +27,10 @@ object Log4jControllerRegistration {
try {
val log4jController =
mimaison commented on code in PR #12046:
URL: https://github.com/apache/kafka/pull/12046#discussion_r942490893
##
server-common/src/main/java/org/apache/kafka/server/metrics/KafkaYammerMetrics.java:
##
@@ -53,16 +72,21 @@ public static MetricsRegistry defaultRegistry() {
}
ijuma commented on PR #11792:
URL: https://github.com/apache/kafka/pull/11792#issuecomment-1210715630
@divijvaidya This is another conversion PR that needs help if you have
cycles. It would also simplify #12295.
--
This is an automated message from the Apache Git Service.
To respond to
ijuma commented on PR #12290:
URL: https://github.com/apache/kafka/pull/12290#issuecomment-1210713174
@C0urante It's a bit difficult to review since there is no explanation on
what each latch does. If you add some explanatory comments to the code, I can
try to review it.
--
This is an
ijuma merged PR #12407:
URL: https://github.com/apache/kafka/pull/12407
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ijuma commented on PR #12410:
URL: https://github.com/apache/kafka/pull/12410#issuecomment-1210706884
Wouldn't we want to integrate this usage in more tests versus removing the
classes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
ijuma commented on PR #12475:
URL: https://github.com/apache/kafka/pull/12475#issuecomment-1210703856
The scala 2.12 build failed
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-12475/
--
This is an automated message from the Apache Git Service.
To respond to the message,
ijuma commented on PR #12473:
URL: https://github.com/apache/kafka/pull/12473#issuecomment-1210701003
@mimaison @C0urante Can one of you please review this and get it over the
line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
pjmagee commented on PR #11442:
URL: https://github.com/apache/kafka/pull/11442#issuecomment-1210700120
@mimaison Hey, It looks like @mnegodaev has followed all the right
procedures and we have the KIP. As someone with more experience on this repo,
what are our next steps?
--
This is
ijuma closed pull request #11137: KAFKA-13133 Replace EasyMock and PowerMock
with Mockito for AbstractHerderTest
URL: https://github.com/apache/kafka/pull/11137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
ijuma commented on PR #11137:
URL: https://github.com/apache/kafka/pull/11137#issuecomment-1210699622
Closing in favor of #12473.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
ijuma merged PR #12484:
URL: https://github.com/apache/kafka/pull/12484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ijuma commented on PR #10904:
URL: https://github.com/apache/kafka/pull/10904#issuecomment-1210693080
Closing this in favor of #12484.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ijuma closed pull request #10904: KAFKA-13060: Replace EasyMock and PowerMock
with Mockito in WorkerGroupMemberTest
URL: https://github.com/apache/kafka/pull/10904
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
ijuma commented on PR #12212:
URL: https://github.com/apache/kafka/pull/12212#issuecomment-1210675328
@lqjack Are you still planning to work on this? If we don't hear from you in
the next couple of days, then someone else may pick it up and drive it forward.
--
This is an automated
ijuma merged PR #12184:
URL: https://github.com/apache/kafka/pull/12184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ijuma merged PR #12495:
URL: https://github.com/apache/kafka/pull/12495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
urbandan commented on code in PR #12392:
URL: https://github.com/apache/kafka/pull/12392#discussion_r942423899
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -241,12 +246,40 @@ synchronized TransactionalRequestResult
showuon commented on code in PR #12392:
URL: https://github.com/apache/kafka/pull/12392#discussion_r942413117
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -241,12 +246,40 @@ synchronized TransactionalRequestResult
daehokimm commented on code in PR #11442:
URL: https://github.com/apache/kafka/pull/11442#discussion_r942369982
##
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/SetSchemaMetadata.java:
##
@@ -71,7 +78,7 @@ public R apply(R record) {
dengziming commented on code in PR #12469:
URL: https://github.com/apache/kafka/pull/12469#discussion_r942341166
##
core/src/main/scala/kafka/admin/MetadataQuorumCommand.scala:
##
@@ -0,0 +1,109 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
jianbin.chen created KAFKA-14159:
Summary: unlimited output: is no longer the Coordinator. Retrying
with new coordinator.
Key: KAFKA-14159
URL: https://issues.apache.org/jira/browse/KAFKA-14159
mimaison commented on code in PR #12046:
URL: https://github.com/apache/kafka/pull/12046#discussion_r942316745
##
server-common/src/main/java/org/apache/kafka/server/metrics/KafkaYammerMetrics.java:
##
@@ -53,16 +72,21 @@ public static MetricsRegistry defaultRegistry() {
}
mimaison commented on code in PR #12046:
URL: https://github.com/apache/kafka/pull/12046#discussion_r942300712
##
server-common/src/main/java/org/apache/kafka/server/metrics/KafkaYammerMetrics.java:
##
@@ -53,16 +72,21 @@ public static MetricsRegistry defaultRegistry() {
}
mimaison commented on code in PR #12046:
URL: https://github.com/apache/kafka/pull/12046#discussion_r942291817
##
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java:
##
@@ -98,6 +102,10 @@ public class CommonClientConfigs {
public static final String
Mickael Maison created KAFKA-14158:
--
Summary: KIP-830 cleanups for Kafka 4.0
Key: KAFKA-14158
URL: https://issues.apache.org/jira/browse/KAFKA-14158
Project: Kafka
Issue Type: Task
tombentley commented on code in PR #12046:
URL: https://github.com/apache/kafka/pull/12046#discussion_r942126401
##
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java:
##
@@ -98,6 +102,10 @@ public class CommonClientConfigs {
public static final
[
https://issues.apache.org/jira/browse/KAFKA-14155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17577880#comment-17577880
]
Bruno Cadonna commented on KAFKA-14155:
---
2.6.0 is quite an old version. You should at least
[
https://issues.apache.org/jira/browse/KAFKA-14155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-14155:
--
Component/s: streams
> Kafka Stream - State transition from RUNNING to ERROR
>
[
https://issues.apache.org/jira/browse/KAFKA-14155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-14155:
--
Affects Version/s: 2.6.0
> Kafka Stream - State transition from RUNNING to ERROR
>
[
https://issues.apache.org/jira/browse/KAFKA-14081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17577879#comment-17577879
]
Bruno Cadonna commented on KAFKA-14081:
---
[~janlooka] what [~RensGroothuijsen] writes sounds
[
https://issues.apache.org/jira/browse/KAFKA-14155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17577878#comment-17577878
]
Harsha Nadig commented on KAFKA-14155:
--
We are using kafka version - 2.6.0
Unable to identify the
[
https://issues.apache.org/jira/browse/KAFKA-14155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17577876#comment-17577876
]
Bruno Cadonna commented on KAFKA-14155:
---
Thank you for filing the bug report!
Could you please
Jorge created KAFKA-14157:
-
Summary: Include IQv2 Query support in the TopologyTestDriver
Key: KAFKA-14157
URL: https://issues.apache.org/jira/browse/KAFKA-14157
Project: Kafka
Issue Type:
[
https://issues.apache.org/jira/browse/KAFKA-14140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-14140.
-
Resolution: Fixed
> Ensure an offline or in-controlled-shutdown replica is not eligible to join
dajac commented on PR #12487:
URL: https://github.com/apache/kafka/pull/12487#issuecomment-1210342696
Merged to trunk and 3.3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dajac merged PR #12487:
URL: https://github.com/apache/kafka/pull/12487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dengziming commented on code in PR #12498:
URL: https://github.com/apache/kafka/pull/12498#discussion_r942092636
##
core/src/test/scala/unit/kafka/raft/RaftManagerTest.scala:
##
@@ -84,21 +84,21 @@ class RaftManagerTest {
@Test
def testSentinelNodeIdIfBrokerRoleOnly():
Artem Livshits created KAFKA-14156:
--
Summary: Built-in partitioner may create suboptimal batches with
large linger.ms
Key: KAFKA-14156
URL: https://issues.apache.org/jira/browse/KAFKA-14156
Project:
80 matches
Mail list logo