[GitHub] [kafka] guozhangwang commented on a diff in pull request #12466: KAFKA-10199: Handle task closure and recycling from state updater

2022-08-10 Thread GitBox
guozhangwang commented on code in PR #12466: URL: https://github.com/apache/kafka/pull/12466#discussion_r943076070 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -656,6 +657,71 @@ boolean tryToCompleteRestoration(final long now,

[GitHub] [kafka] badaiaqrandista commented on a diff in pull request #12416: KAFKA-13559: Fix issue where responses intermittently takes 300+ ms to respond, even when the server is idle.

2022-08-10 Thread GitBox
badaiaqrandista commented on code in PR #12416: URL: https://github.com/apache/kafka/pull/12416#discussion_r943043296 ## core/src/test/scala/unit/kafka/network/SocketServerTest.scala: ## @@ -1878,6 +1878,40 @@ class SocketServerTest { }, false) } + /** + * Test to

[GitHub] [kafka] guozhangwang commented on pull request #12466: [WIP] KAFKA-10199: Handle task closure and recycling from state updater

2022-08-10 Thread GitBox
guozhangwang commented on PR #12466: URL: https://github.com/apache/kafka/pull/12466#issuecomment-1211439884 > In Tasks on line 141 and line 163 why do we not verify that the task ID is contained in map and throw an IllegalStateException if not as we do for standbyTasksPerId? In the end

[GitHub] [kafka] jolshan opened a new pull request, #12501: KAFKA-14097: Separate configuration for producer ID expiry

2022-08-10 Thread GitBox
jolshan opened a new pull request, #12501: URL: https://github.com/apache/kafka/pull/12501 Changes for [KIP-854](https://cwiki.apache.org/confluence/display/KAFKA/KIP-854+Separate+configuration+for+producer+ID+expiry) We add the producer id expiration configuration and a test.

[jira] [Resolved] (KAFKA-14114) KIP-859: Add Metadata Log Processing Error Related Metrics

2022-08-10 Thread Niket Goel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niket Goel resolved KAFKA-14114. Resolution: Fixed

[GitHub] [kafka] ahuang98 commented on a diff in pull request #12479: MINOR; Convert some integration tests to run with the KRaft modes

2022-08-10 Thread GitBox
ahuang98 commented on code in PR #12479: URL: https://github.com/apache/kafka/pull/12479#discussion_r942970441 ## core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala: ## @@ -187,264 +220,337 @@ class DeleteTopicTest extends QuorumTestHarness { }.toSet } -

[GitHub] [kafka] jsancio commented on a diff in pull request #12498: KAFKA-13986; Brokers should include node.id in fetches to metadata quorum

2022-08-10 Thread GitBox
jsancio commented on code in PR #12498: URL: https://github.com/apache/kafka/pull/12498#discussion_r942968751 ## core/src/main/scala/kafka/raft/RaftManager.scala: ## @@ -181,12 +180,7 @@ class KafkaRaftManager[T]( val expirationTimer = new

[GitHub] [kafka] hachikuji commented on a diff in pull request #12498: KAFKA-13986; Brokers should include node.id in fetches to metadata quorum

2022-08-10 Thread GitBox
hachikuji commented on code in PR #12498: URL: https://github.com/apache/kafka/pull/12498#discussion_r942966254 ## core/src/main/scala/kafka/raft/RaftManager.scala: ## @@ -181,12 +180,7 @@ class KafkaRaftManager[T]( val expirationTimer = new

[GitHub] [kafka] jsancio commented on a diff in pull request #12498: KAFKA-13986; Brokers should include node.id in fetches to metadata quorum

2022-08-10 Thread GitBox
jsancio commented on code in PR #12498: URL: https://github.com/apache/kafka/pull/12498#discussion_r942961893 ## core/src/main/scala/kafka/raft/RaftManager.scala: ## @@ -181,12 +180,7 @@ class KafkaRaftManager[T]( val expirationTimer = new

[GitHub] [kafka] hachikuji commented on a diff in pull request #12469: KAFKA-13914: Add command line tool kafka-metadata-quorum.sh

2022-08-10 Thread GitBox
hachikuji commented on code in PR #12469: URL: https://github.com/apache/kafka/pull/12469#discussion_r942910479 ## core/src/main/scala/kafka/admin/MetadataQuorumCommand.scala: ## @@ -0,0 +1,109 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] hachikuji commented on pull request #12499: KAFKA-14154; Ensure AlterPartition not sent to stale controller

2022-08-10 Thread GitBox
hachikuji commented on PR #12499: URL: https://github.com/apache/kafka/pull/12499#issuecomment-1211245795 > So we prevent sending the request if the epoch is lower? And is it the case, that there is always a controller with an epoch at least as large? Or in some cases would we need to

[GitHub] [kafka] dplavcic commented on pull request #11792: Replace EasyMock/PowerMock with Mockito in DistributedHerderTest

2022-08-10 Thread GitBox
dplavcic commented on PR #11792: URL: https://github.com/apache/kafka/pull/11792#issuecomment-1211235309 Hi @clolov, just an info, to avoid duplicate work.. I've started working on this one few days ago. There is a Jira ticket: [Replace EasyMock and PowerMock with Mockito for

[GitHub] [kafka] hachikuji commented on a diff in pull request #12499: KAFKA-14154; Ensure AlterPartition not sent to stale controller

2022-08-10 Thread GitBox
hachikuji commented on code in PR #12499: URL: https://github.com/apache/kafka/pull/12499#discussion_r942874759 ## core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala: ## @@ -317,21 +373,24 @@ class BrokerToControllerRequestThread( override def

[jira] [Created] (KAFKA-14160) Streamline clusterId retrieval in Connect

2022-08-10 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-14160: -- Summary: Streamline clusterId retrieval in Connect Key: KAFKA-14160 URL: https://issues.apache.org/jira/browse/KAFKA-14160 Project: Kafka Issue Type:

[GitHub] [kafka] mdedetrich commented on pull request #12475: MINOR; Update scalafmt to latest version

2022-08-10 Thread GitBox
mdedetrich commented on PR #12475: URL: https://github.com/apache/kafka/pull/12475#issuecomment-1211144083 @ijuma Thanks for the pickup. I have investigated the root cause of the problem, basically when you specify the scala version with `-PscalaVersion=2.12` it also happens to

[GitHub] [kafka] splett2 commented on a diff in pull request #12416: KAFKA-13559: Fix issue where responses intermittently takes 300+ ms to respond, even when the server is idle.

2022-08-10 Thread GitBox
splett2 commented on code in PR #12416: URL: https://github.com/apache/kafka/pull/12416#discussion_r942768273 ## core/src/test/scala/unit/kafka/network/SocketServerTest.scala: ## @@ -1878,6 +1878,40 @@ class SocketServerTest { }, false) } + /** + * Test to ensure

[GitHub] [kafka] mnegodaev commented on a diff in pull request #11442: KAFKA-7883 add schema.namespace support to SetSchemaMetadata SMT in Kafka Connect

2022-08-10 Thread GitBox
mnegodaev commented on code in PR #11442: URL: https://github.com/apache/kafka/pull/11442#discussion_r94270 ## connect/transforms/src/main/java/org/apache/kafka/connect/transforms/SetSchemaMetadata.java: ## @@ -71,7 +78,7 @@ public R apply(R record) {

[jira] [Commented] (KAFKA-14130) Reduce RackAwarenessIntegrationTest to a unit test

2022-08-10 Thread xiangde (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17578081#comment-17578081 ] xiangde commented on KAFKA-14130: - Hi, I am new to Kafka and noticed that this issue is tagged as

[GitHub] [kafka] mnegodaev commented on a diff in pull request #11442: KAFKA-7883 add schema.namespace support to SetSchemaMetadata SMT in Kafka Connect

2022-08-10 Thread GitBox
mnegodaev commented on code in PR #11442: URL: https://github.com/apache/kafka/pull/11442#discussion_r94270 ## connect/transforms/src/main/java/org/apache/kafka/connect/transforms/SetSchemaMetadata.java: ## @@ -71,7 +78,7 @@ public R apply(R record) {

[GitHub] [kafka] mnegodaev commented on a diff in pull request #11442: KAFKA-7883 add schema.namespace support to SetSchemaMetadata SMT in Kafka Connect

2022-08-10 Thread GitBox
mnegodaev commented on code in PR #11442: URL: https://github.com/apache/kafka/pull/11442#discussion_r94270 ## connect/transforms/src/main/java/org/apache/kafka/connect/transforms/SetSchemaMetadata.java: ## @@ -71,7 +78,7 @@ public R apply(R record) {

[GitHub] [kafka] mnegodaev commented on a diff in pull request #11442: KAFKA-7883 add schema.namespace support to SetSchemaMetadata SMT in Kafka Connect

2022-08-10 Thread GitBox
mnegodaev commented on code in PR #11442: URL: https://github.com/apache/kafka/pull/11442#discussion_r94270 ## connect/transforms/src/main/java/org/apache/kafka/connect/transforms/SetSchemaMetadata.java: ## @@ -71,7 +78,7 @@ public R apply(R record) {

[GitHub] [kafka] mnegodaev commented on a diff in pull request #11442: KAFKA-7883 add schema.namespace support to SetSchemaMetadata SMT in Kafka Connect

2022-08-10 Thread GitBox
mnegodaev commented on code in PR #11442: URL: https://github.com/apache/kafka/pull/11442#discussion_r94270 ## connect/transforms/src/main/java/org/apache/kafka/connect/transforms/SetSchemaMetadata.java: ## @@ -71,7 +78,7 @@ public R apply(R record) {

[GitHub] [kafka] C0urante commented on pull request #12473: KAFKA-13133: Replace EasyMock and PowerMock with Mockito for AbstractHerderTest

2022-08-10 Thread GitBox
C0urante commented on PR #12473: URL: https://github.com/apache/kafka/pull/12473#issuecomment-1211000855 @ijuma @divijvaidya I'm pretty tied up this week and next, but can definitely provide a first review by the end of the week after. Please feel free to ping me if I still haven't left a

[GitHub] [kafka] ijuma commented on pull request #11792: Replace EasyMock/PowerMock with Mockito in DistributedHerderTest

2022-08-10 Thread GitBox
ijuma commented on PR #11792: URL: https://github.com/apache/kafka/pull/11792#issuecomment-1210995024 Thanks @clolov ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] clolov commented on pull request #11792: Replace EasyMock/PowerMock with Mockito in DistributedHerderTest

2022-08-10 Thread GitBox
clolov commented on PR #11792: URL: https://github.com/apache/kafka/pull/11792#issuecomment-1210983259 Hey @ijuma! Divij is taking some time off, but I can have a look in the meantime and try to get it over the line. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] jolshan commented on pull request #12499: KAFKA-14154; Ensure AlterPartition not sent to stale controller

2022-08-10 Thread GitBox
jolshan commented on PR #12499: URL: https://github.com/apache/kafka/pull/12499#issuecomment-1210963384 > This patch fixes the problem by ensuring that AlterPartition is sent to a controller with an epoch which is at least as large as that of the controller which sent the LeaderAndIsr

[jira] [Updated] (KAFKA-13978) Trigger UncaughtExceptionHandler for IllegalArgument and IllegalState exceptions

2022-08-10 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-13978: Fix Version/s: (was: 3.3.0) > Trigger UncaughtExceptionHandler for IllegalArgument and

[jira] [Commented] (KAFKA-12887) Do not trigger user-customized ExceptionalHandler for RTE

2022-08-10 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17578061#comment-17578061 ] Ismael Juma commented on KAFKA-12887: - Reopened the Jira since the PR was reverted. > Do not

[jira] [Reopened] (KAFKA-12887) Do not trigger user-customized ExceptionalHandler for RTE

2022-08-10 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma reopened KAFKA-12887: - > Do not trigger user-customized ExceptionalHandler for RTE >

[GitHub] [kafka] ijuma commented on pull request #12352: KAFKA-13978: Don't skip exceptions in Kafka streams custom handlers

2022-08-10 Thread GitBox
ijuma commented on PR #12352: URL: https://github.com/apache/kafka/pull/12352#issuecomment-1210956343 Removing the 3.3 label given the comment from @vvcephei. If it is a blocker for 3.3, please provide the rationale. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] jsancio commented on a diff in pull request #12274: KAFKA-13959: Controller should unfence Broker with busy metadata log

2022-08-10 Thread GitBox
jsancio commented on code in PR #12274: URL: https://github.com/apache/kafka/pull/12274#discussion_r942583448 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -759,7 +759,7 @@ public void run() throws Exception { int i = 1;

[GitHub] [kafka] IvanVas commented on pull request #11023: KAFKA-13115 Update doSend doc about possible blocking

2022-08-10 Thread GitBox
IvanVas commented on PR #11023: URL: https://github.com/apache/kafka/pull/11023#issuecomment-1210903121 @jsancio Hi! Could you help? How should I proceed with the PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Resolved] (KAFKA-13364) SQL Processor Alerts Creation when Failed

2022-08-10 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna resolved KAFKA-13364. --- Resolution: Invalid > SQL Processor Alerts Creation when Failed >

[jira] [Resolved] (KAFKA-13638) Slow KTable update when forwarding multiple values from transformer

2022-08-10 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna resolved KAFKA-13638. --- Resolution: Cannot Reproduce > Slow KTable update when forwarding multiple values from

[GitHub] [kafka] vvcephei commented on pull request #12352: KAFKA-13978: Don't skip exceptions in Kafka streams custom handlers

2022-08-10 Thread GitBox
vvcephei commented on PR #12352: URL: https://github.com/apache/kafka/pull/12352#issuecomment-1210796778 Hey @Smeb , I just checked trunk and 3.3, and I don't see the code that you're removing in your PR. It seems like someone else may have fixed this issue in the mean time. Can you

[jira] [Commented] (KAFKA-13978) Trigger UncaughtExceptionHandler for IllegalArgument and IllegalState exceptions

2022-08-10 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17578023#comment-17578023 ] John Roesler commented on KAFKA-13978: -- Hey [~bryves]  , I just checked trunk and 3.3, and I don't

[GitHub] [kafka] cadonna commented on a diff in pull request #12466: [WIP] KAFKA-10199: Handle task closure and recycling from state updater

2022-08-10 Thread GitBox
cadonna commented on code in PR #12466: URL: https://github.com/apache/kafka/pull/12466#discussion_r942289824 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -298,13 +298,12 @@ public void handleAssignment(final Map> activeTasks,

[GitHub] [kafka] ijuma commented on a diff in pull request #12349: KAFKA-14024: Consumer keeps Commit offset in onJoinPrepare in Cooperative rebalance

2022-08-10 Thread GitBox
ijuma commented on code in PR #12349: URL: https://github.com/apache/kafka/pull/12349#discussion_r942511881 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java: ## @@ -1299,17 +1300,79 @@ public void

[GitHub] [kafka] ijuma opened a new pull request, #12500: MINOR: Remove spurious sleep in ConsumerCoordinatorTest

2022-08-10 Thread GitBox
ijuma opened a new pull request, #12500: URL: https://github.com/apache/kafka/pull/12500 Follow up from here https://github.com/apache/kafka/pull/12349#discussion_r925138410 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ]

[GitHub] [kafka] ijuma commented on a diff in pull request #12349: KAFKA-14024: Consumer keeps Commit offset in onJoinPrepare in Cooperative rebalance

2022-08-10 Thread GitBox
ijuma commented on code in PR #12349: URL: https://github.com/apache/kafka/pull/12349#discussion_r942511881 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java: ## @@ -1299,17 +1300,79 @@ public void

[GitHub] [kafka] ijuma commented on pull request #12277: KAFKA-13971:Atomicity violations caused by improper usage of ConcurrentHashMap

2022-08-10 Thread GitBox
ijuma commented on PR #12277: URL: https://github.com/apache/kafka/pull/12277#issuecomment-1210721500 We should check if this code is used in a concurrent context. Will leave it to @C0urante. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] ijuma commented on a diff in pull request #12282: MINOR: Fail if Logging controller bean is not correctly registered

2022-08-10 Thread GitBox
ijuma commented on code in PR #12282: URL: https://github.com/apache/kafka/pull/12282#discussion_r942492154 ## core/src/main/scala/kafka/utils/Logging.scala: ## @@ -27,7 +27,10 @@ object Log4jControllerRegistration { try { val log4jController =

[GitHub] [kafka] mimaison commented on a diff in pull request #12046: KAFKA-10360: Allow disabling JMX Reporter (KIP-830)

2022-08-10 Thread GitBox
mimaison commented on code in PR #12046: URL: https://github.com/apache/kafka/pull/12046#discussion_r942490893 ## server-common/src/main/java/org/apache/kafka/server/metrics/KafkaYammerMetrics.java: ## @@ -53,16 +72,21 @@ public static MetricsRegistry defaultRegistry() { }

[GitHub] [kafka] ijuma commented on pull request #11792: Replace EasyMock/PowerMock with Mockito in DistributedHerderTest

2022-08-10 Thread GitBox
ijuma commented on PR #11792: URL: https://github.com/apache/kafka/pull/11792#issuecomment-1210715630 @divijvaidya This is another conversion PR that needs help if you have cycles. It would also simplify #12295. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] ijuma commented on pull request #12290: MINOR: Stop leaking threads in BlockingConnectorTest

2022-08-10 Thread GitBox
ijuma commented on PR #12290: URL: https://github.com/apache/kafka/pull/12290#issuecomment-1210713174 @C0urante It's a bit difficult to review since there is no explanation on what each latch does. If you add some explanatory comments to the code, I can try to review it. -- This is an

[GitHub] [kafka] ijuma merged pull request #12407: [BUG] Remove duplicate common.message.* from clients:test jar file

2022-08-10 Thread GitBox
ijuma merged PR #12407: URL: https://github.com/apache/kafka/pull/12407 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ijuma commented on pull request #12410: MINOR: Remove unused ShutdownableThread class and ineffective ThreadedTest classes

2022-08-10 Thread GitBox
ijuma commented on PR #12410: URL: https://github.com/apache/kafka/pull/12410#issuecomment-1210706884 Wouldn't we want to integrate this usage in more tests versus removing the classes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] ijuma commented on pull request #12475: MINOR; Update scalafmt to latest version

2022-08-10 Thread GitBox
ijuma commented on PR #12475: URL: https://github.com/apache/kafka/pull/12475#issuecomment-1210703856 The scala 2.12 build failed https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-12475/ -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] ijuma commented on pull request #12473: KAFKA-13133: Replace EasyMock and PowerMock with Mockito for AbstractHerderTest

2022-08-10 Thread GitBox
ijuma commented on PR #12473: URL: https://github.com/apache/kafka/pull/12473#issuecomment-1210701003 @mimaison @C0urante Can one of you please review this and get it over the line? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] pjmagee commented on pull request #11442: KAFKA-7883 add schema.namespace support to SetSchemaMetadata SMT in Kafka Connect

2022-08-10 Thread GitBox
pjmagee commented on PR #11442: URL: https://github.com/apache/kafka/pull/11442#issuecomment-1210700120 @mimaison Hey, It looks like @mnegodaev has followed all the right procedures and we have the KIP. As someone with more experience on this repo, what are our next steps? -- This is

[GitHub] [kafka] ijuma closed pull request #11137: KAFKA-13133 Replace EasyMock and PowerMock with Mockito for AbstractHerderTest

2022-08-10 Thread GitBox
ijuma closed pull request #11137: KAFKA-13133 Replace EasyMock and PowerMock with Mockito for AbstractHerderTest URL: https://github.com/apache/kafka/pull/11137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] ijuma commented on pull request #11137: KAFKA-13133 Replace EasyMock and PowerMock with Mockito for AbstractHerderTest

2022-08-10 Thread GitBox
ijuma commented on PR #11137: URL: https://github.com/apache/kafka/pull/11137#issuecomment-1210699622 Closing in favor of #12473. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] ijuma merged pull request #12484: KAFKA-13060: Replace EasyMock and PowerMock with Mockito in WorkerGroupMemberTest.java

2022-08-10 Thread GitBox
ijuma merged PR #12484: URL: https://github.com/apache/kafka/pull/12484 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ijuma commented on pull request #10904: KAFKA-13060: Replace EasyMock and PowerMock with Mockito in WorkerGroupMemberTest

2022-08-10 Thread GitBox
ijuma commented on PR #10904: URL: https://github.com/apache/kafka/pull/10904#issuecomment-1210693080 Closing this in favor of #12484. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ijuma closed pull request #10904: KAFKA-13060: Replace EasyMock and PowerMock with Mockito in WorkerGroupMemberTest

2022-08-10 Thread GitBox
ijuma closed pull request #10904: KAFKA-13060: Replace EasyMock and PowerMock with Mockito in WorkerGroupMemberTest URL: https://github.com/apache/kafka/pull/10904 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] ijuma commented on pull request #12212: Kafka 13888 new fields

2022-08-10 Thread GitBox
ijuma commented on PR #12212: URL: https://github.com/apache/kafka/pull/12212#issuecomment-1210675328 @lqjack Are you still planning to work on this? If we don't hear from you in the next couple of days, then someone else may pick it up and drive it forward. -- This is an automated

[GitHub] [kafka] ijuma merged pull request #12184: KAFKA-13911: Fix the rate window size calculation for edge cases

2022-08-10 Thread GitBox
ijuma merged PR #12184: URL: https://github.com/apache/kafka/pull/12184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ijuma merged pull request #12495: MINOR: Upgrade gradle to 7.5.1 and bump other build/test dependencies

2022-08-10 Thread GitBox
ijuma merged PR #12495: URL: https://github.com/apache/kafka/pull/12495 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] urbandan commented on a diff in pull request #12392: KAFKA-14053: Transactional producer should bump the epoch and skip ab…

2022-08-10 Thread GitBox
urbandan commented on code in PR #12392: URL: https://github.com/apache/kafka/pull/12392#discussion_r942423899 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -241,12 +246,40 @@ synchronized TransactionalRequestResult

[GitHub] [kafka] showuon commented on a diff in pull request #12392: KAFKA-14053: Transactional producer should bump the epoch and skip ab…

2022-08-10 Thread GitBox
showuon commented on code in PR #12392: URL: https://github.com/apache/kafka/pull/12392#discussion_r942413117 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -241,12 +246,40 @@ synchronized TransactionalRequestResult

[GitHub] [kafka] daehokimm commented on a diff in pull request #11442: KAFKA-7883 add schema.namespace support to SetSchemaMetadata SMT in Kafka Connect

2022-08-10 Thread GitBox
daehokimm commented on code in PR #11442: URL: https://github.com/apache/kafka/pull/11442#discussion_r942369982 ## connect/transforms/src/main/java/org/apache/kafka/connect/transforms/SetSchemaMetadata.java: ## @@ -71,7 +78,7 @@ public R apply(R record) {

[GitHub] [kafka] dengziming commented on a diff in pull request #12469: KAFKA-13914: Add command line tool kafka-metadata-quorum.sh

2022-08-10 Thread GitBox
dengziming commented on code in PR #12469: URL: https://github.com/apache/kafka/pull/12469#discussion_r942341166 ## core/src/main/scala/kafka/admin/MetadataQuorumCommand.scala: ## @@ -0,0 +1,109 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[jira] [Created] (KAFKA-14159) unlimited output: is no longer the Coordinator. Retrying with new coordinator.

2022-08-10 Thread jianbin.chen (Jira)
jianbin.chen created KAFKA-14159: Summary: unlimited output: is no longer the Coordinator. Retrying with new coordinator. Key: KAFKA-14159 URL: https://issues.apache.org/jira/browse/KAFKA-14159

[GitHub] [kafka] mimaison commented on a diff in pull request #12046: KAFKA-10360: Allow disabling JMX Reporter (KIP-830)

2022-08-10 Thread GitBox
mimaison commented on code in PR #12046: URL: https://github.com/apache/kafka/pull/12046#discussion_r942316745 ## server-common/src/main/java/org/apache/kafka/server/metrics/KafkaYammerMetrics.java: ## @@ -53,16 +72,21 @@ public static MetricsRegistry defaultRegistry() { }

[GitHub] [kafka] mimaison commented on a diff in pull request #12046: KAFKA-10360: Allow disabling JMX Reporter (KIP-830)

2022-08-10 Thread GitBox
mimaison commented on code in PR #12046: URL: https://github.com/apache/kafka/pull/12046#discussion_r942300712 ## server-common/src/main/java/org/apache/kafka/server/metrics/KafkaYammerMetrics.java: ## @@ -53,16 +72,21 @@ public static MetricsRegistry defaultRegistry() { }

[GitHub] [kafka] mimaison commented on a diff in pull request #12046: KAFKA-10360: Allow disabling JMX Reporter (KIP-830)

2022-08-10 Thread GitBox
mimaison commented on code in PR #12046: URL: https://github.com/apache/kafka/pull/12046#discussion_r942291817 ## clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java: ## @@ -98,6 +102,10 @@ public class CommonClientConfigs { public static final String

[jira] [Created] (KAFKA-14158) KIP-830 cleanups for Kafka 4.0

2022-08-10 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-14158: -- Summary: KIP-830 cleanups for Kafka 4.0 Key: KAFKA-14158 URL: https://issues.apache.org/jira/browse/KAFKA-14158 Project: Kafka Issue Type: Task

[GitHub] [kafka] tombentley commented on a diff in pull request #12046: KAFKA-10360: Allow disabling JMX Reporter (KIP-830)

2022-08-10 Thread GitBox
tombentley commented on code in PR #12046: URL: https://github.com/apache/kafka/pull/12046#discussion_r942126401 ## clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java: ## @@ -98,6 +102,10 @@ public class CommonClientConfigs { public static final

[jira] [Commented] (KAFKA-14155) Kafka Stream - State transition from RUNNING to ERROR

2022-08-10 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17577880#comment-17577880 ] Bruno Cadonna commented on KAFKA-14155: --- 2.6.0 is quite an old version. You should at least

[jira] [Updated] (KAFKA-14155) Kafka Stream - State transition from RUNNING to ERROR

2022-08-10 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-14155: -- Component/s: streams > Kafka Stream - State transition from RUNNING to ERROR >

[jira] [Updated] (KAFKA-14155) Kafka Stream - State transition from RUNNING to ERROR

2022-08-10 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-14155: -- Affects Version/s: 2.6.0 > Kafka Stream - State transition from RUNNING to ERROR >

[jira] [Commented] (KAFKA-14081) Cannot get my MetricsReporter implementation to receive meaningful metrics

2022-08-10 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17577879#comment-17577879 ] Bruno Cadonna commented on KAFKA-14081: --- [~janlooka] what [~RensGroothuijsen] writes sounds

[jira] [Commented] (KAFKA-14155) Kafka Stream - State transition from RUNNING to ERROR

2022-08-10 Thread Harsha Nadig (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17577878#comment-17577878 ] Harsha Nadig commented on KAFKA-14155: -- We are using kafka version - 2.6.0 Unable to identify the

[jira] [Commented] (KAFKA-14155) Kafka Stream - State transition from RUNNING to ERROR

2022-08-10 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17577876#comment-17577876 ] Bruno Cadonna commented on KAFKA-14155: --- Thank you for filing the bug report! Could you please

[jira] [Created] (KAFKA-14157) Include IQv2 Query support in the TopologyTestDriver

2022-08-10 Thread Jorge (Jira)
Jorge created KAFKA-14157: - Summary: Include IQv2 Query support in the TopologyTestDriver Key: KAFKA-14157 URL: https://issues.apache.org/jira/browse/KAFKA-14157 Project: Kafka Issue Type:

[jira] [Resolved] (KAFKA-14140) Ensure an offline or in-controlled-shutdown replica is not eligible to join ISR in ZK mode

2022-08-10 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-14140. - Resolution: Fixed > Ensure an offline or in-controlled-shutdown replica is not eligible to join

[GitHub] [kafka] dajac commented on pull request #12487: KAFKA-14140: Ensure an offline or in-controlled-shutdown replica is not eligible to join ISR in ZK mode

2022-08-10 Thread GitBox
dajac commented on PR #12487: URL: https://github.com/apache/kafka/pull/12487#issuecomment-1210342696 Merged to trunk and 3.3. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] dajac merged pull request #12487: KAFKA-14140: Ensure an offline or in-controlled-shutdown replica is not eligible to join ISR in ZK mode

2022-08-10 Thread GitBox
dajac merged PR #12487: URL: https://github.com/apache/kafka/pull/12487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] dengziming commented on a diff in pull request #12498: KAFKA-13986; Brokers should include node.id in fetches to metadata quorum

2022-08-10 Thread GitBox
dengziming commented on code in PR #12498: URL: https://github.com/apache/kafka/pull/12498#discussion_r942092636 ## core/src/test/scala/unit/kafka/raft/RaftManagerTest.scala: ## @@ -84,21 +84,21 @@ class RaftManagerTest { @Test def testSentinelNodeIdIfBrokerRoleOnly():

[jira] [Created] (KAFKA-14156) Built-in partitioner may create suboptimal batches with large linger.ms

2022-08-10 Thread Artem Livshits (Jira)
Artem Livshits created KAFKA-14156: -- Summary: Built-in partitioner may create suboptimal batches with large linger.ms Key: KAFKA-14156 URL: https://issues.apache.org/jira/browse/KAFKA-14156 Project: