[GitHub] [kafka] showuon commented on a diff in pull request #12668: MINOR: Mention deprecation of authorizer flags in security documentation

showuon commented on code in PR #12668: URL: https://github.com/apache/kafka/pull/12668#discussion_r975997743 ## docs/security.html: ## @@ -1364,6 +1352,18 @@ Convenience + +--authorizer +(DEPRECATED: not supported in

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #12561: KAFKA-12495: Exponential backoff retry to prevent rebalance storms when worker joins after revoking rebalance

vamossagar12 commented on code in PR #12561: URL: https://github.com/apache/kafka/pull/12561#discussion_r975980445 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorIncrementalTest.java: ## @@ -517,13 +517,13 @@ public void

[GitHub] [kafka] showuon commented on a diff in pull request #12667: KAFKA-10635: Improve logging with throwing OOOSE

showuon commented on code in PR #12667: URL: https://github.com/apache/kafka/pull/12667#discussion_r975975334 ## core/src/main/scala/kafka/log/ProducerStateManager.scala: ## @@ -233,10 +233,16 @@ private[log] class ProducerAppendInfo(val topicPartition: TopicPartition,

[GitHub] [kafka] showuon commented on pull request #12666: KAFKA-14244: Add guard against accidental calls to halt JVM during testing

showuon commented on PR #12666: URL: https://github.com/apache/kafka/pull/12666#issuecomment-1253120024 @C0urante , interesting solution. But I'm wondering how you test it and prove this can really catch `Exit` and report error? -- This is an automated message from the Apache Git

[GitHub] [kafka] showuon merged pull request #12665: MINOR: Fix typo in info message

showuon merged PR #12665: URL: https://github.com/apache/kafka/pull/12665 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12663: [Consumer Refactor] Define event handler interface and events

guozhangwang commented on code in PR #12663: URL: https://github.com/apache/kafka/pull/12663#discussion_r975965989 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/EventHandler.java: ## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] showuon commented on pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

showuon commented on PR #12590: URL: https://github.com/apache/kafka/pull/12590#issuecomment-1253101672 @divijvaidya , you're right, thanks for the update! Sorry, I only checked the broker side implementation that although we created `SessionlessFetchContext`, it still return the fetched

[GitHub] [kafka] hachikuji commented on a diff in pull request #12663: [Consumer Refactor] Define event handler interface and events

hachikuji commented on code in PR #12663: URL: https://github.com/apache/kafka/pull/12663#discussion_r975915821 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/EventHandler.java: ## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] philipnee commented on a diff in pull request #12663: [Consumer Refactor] Define event handler interface and events

philipnee commented on code in PR #12663: URL: https://github.com/apache/kafka/pull/12663#discussion_r975897905 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/EventHandler.java: ## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] hachikuji commented on a diff in pull request #12663: [Consumer Refactor] Define event handler interface and events

hachikuji commented on code in PR #12663: URL: https://github.com/apache/kafka/pull/12663#discussion_r975893945 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/EventHandler.java: ## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] philipnee commented on a diff in pull request #12663: [Consumer Refactor] Define event handler interface and events

philipnee commented on code in PR #12663: URL: https://github.com/apache/kafka/pull/12663#discussion_r975863614 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ConsumerRequestEvent.java: ## @@ -0,0 +1,20 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] philipnee commented on a diff in pull request #12663: [Consumer Refactor] Define event handler interface and events

philipnee commented on code in PR #12663: URL: https://github.com/apache/kafka/pull/12663#discussion_r975863343 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/EventHandler.java: ## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Resolved] (KAFKA-14243) Temporarily disable unsafe downgrade

[ https://issues.apache.org/jira/browse/KAFKA-14243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur resolved KAFKA-14243. -- Resolution: Fixed > Temporarily disable unsafe downgrade >

[jira] [Resolved] (KAFKA-14214) StandardAuthorizer may transiently process ACLs out of write order

[ https://issues.apache.org/jira/browse/KAFKA-14214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur resolved KAFKA-14214. -- Resolution: Fixed > StandardAuthorizer may transiently process ACLs out of write order >

[GitHub] [kafka] forlack commented on a diff in pull request #12642: KAFKA-14207; KRaft Operations documentation

forlack commented on code in PR #12642: URL: https://github.com/apache/kafka/pull/12642#discussion_r975807518 ## docs/ops.html: ## @@ -3180,6 +3180,119 @@ 6.10 KRaft + + Configuration + + Process Roles + + In KRaft mode each Kafka server can be configured as a controller, as

[GitHub] [kafka] forlack commented on a diff in pull request #12642: KAFKA-14207; KRaft Operations documentation

forlack commented on code in PR #12642: URL: https://github.com/apache/kafka/pull/12642#discussion_r972393499 ## docs/ops.html: ## @@ -3180,6 +3180,119 @@ 6.10 KRaft + + Configuration + + Process Roles + + In KRaft mode each Kafka server can be configured as a controller, as

[GitHub] [kafka] forlack commented on a diff in pull request #12642: KAFKA-14207; KRaft Operations documentation

forlack commented on code in PR #12642: URL: https://github.com/apache/kafka/pull/12642#discussion_r972377166 ## docs/ops.html: ## @@ -3180,6 +3180,119 @@ 6.10 KRaft + + Configuration + + Process Roles + + In KRaft mode each Kafka server can be configured as a controller, as

[GitHub] [kafka] mumrah merged pull request #12628: KAFKA-14214: Introduce read-write lock to StandardAuthorizer for consistent ACL reads.

mumrah merged PR #12628: URL: https://github.com/apache/kafka/pull/12628 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12663: [Consumer Refactor] Define event handler interface and events

guozhangwang commented on code in PR #12663: URL: https://github.com/apache/kafka/pull/12663#discussion_r975715686 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/EventHandler.java: ## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] mumrah merged pull request #12664: KAFKA-14243: Temporarily disable unsafe downgrade

mumrah merged PR #12664: URL: https://github.com/apache/kafka/pull/12664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12663: [Consumer Refactor] Define event handler interface and events

guozhangwang commented on code in PR #12663: URL: https://github.com/apache/kafka/pull/12663#discussion_r975715686 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/EventHandler.java: ## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] hachikuji opened a new pull request, #12668: MINOR: Mention deprecation of authorizer flags in security documentation

hachikuji opened a new pull request, #12668: URL: https://github.com/apache/kafka/pull/12668 The `--authorizer` and `--authorizer-properties` options are deprecated since 3.2. This patch updates the security documentation to mention the deprecation and changes examples to use

[GitHub] [kafka] kirktrue commented on pull request #12651: KAFKA-14212: Enhanced HttpAccessTokenRetriever to retrieve error mess…

kirktrue commented on PR #12651: URL: https://github.com/apache/kafka/pull/12651#issuecomment-1252765578 Nice work, @smjn! Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (KAFKA-14246) Refactor KafkaConsumer Threading Model

[ https://issues.apache.org/jira/browse/KAFKA-14246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-14246: --- Description: Hi community,   We are refactoring the current KafkaConsumer and making it more

[GitHub] [kafka] C0urante commented on a diff in pull request #12561: KAFKA-12495: Exponential backoff retry to prevent rebalance storms when worker joins after revoking rebalance

C0urante commented on code in PR #12561: URL: https://github.com/apache/kafka/pull/12561#discussion_r975672702 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorIncrementalTest.java: ## @@ -517,13 +517,13 @@ public void

[GitHub] [kafka] C0urante commented on a diff in pull request #12561: KAFKA-12495: Exponential backoff retry to prevent rebalance storms when worker joins after revoking rebalance

C0urante commented on code in PR #12561: URL: https://github.com/apache/kafka/pull/12561#discussion_r975671233 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorIncrementalTest.java: ## @@ -517,13 +517,13 @@ public void

[jira] [Created] (KAFKA-14247) Implement EventHandler interface and DefaultEventHandler

Philip Nee created KAFKA-14247: -- Summary: Implement EventHandler interface and DefaultEventHandler Key: KAFKA-14247 URL: https://issues.apache.org/jira/browse/KAFKA-14247 Project: Kafka Issue

[jira] [Created] (KAFKA-14246) Refactor KafkaConsumer Threading Model

Philip Nee created KAFKA-14246: -- Summary: Refactor KafkaConsumer Threading Model Key: KAFKA-14246 URL: https://issues.apache.org/jira/browse/KAFKA-14246 Project: Kafka Issue Type: Improvement

[jira] [Created] (KAFKA-14245) Topic deleted during reassignment

Junyang Liu created KAFKA-14245: --- Summary: Topic deleted during reassignment Key: KAFKA-14245 URL: https://issues.apache.org/jira/browse/KAFKA-14245 Project: Kafka Issue Type: Bug Affects

[GitHub] [kafka] C0urante merged pull request #12566: KAFKA-13927: Only clear origOffsets when clearing messageBatch

C0urante merged PR #12566: URL: https://github.com/apache/kafka/pull/12566 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] C0urante commented on a diff in pull request #12566: KAFKA-13927: Only clear origOffsets when clearing messageBatch

C0urante commented on code in PR #12566: URL: https://github.com/apache/kafka/pull/12566#discussion_r975650210 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.java: ## @@ -435,6 +453,13 @@ public void testPollRedelivery() throws Exception {

[GitHub] [kafka] philipnee commented on a diff in pull request #12663: [Consumer Refactor] Define event handler interface and events

philipnee commented on code in PR #12663: URL: https://github.com/apache/kafka/pull/12663#discussion_r975642128 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ConsumerRequestEvent.java: ## @@ -0,0 +1,20 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] philipnee commented on a diff in pull request #12663: [Consumer Refactor] Define event handler interface and events

philipnee commented on code in PR #12663: URL: https://github.com/apache/kafka/pull/12663#discussion_r975641608 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/EventHandler.java: ## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] philipnee commented on a diff in pull request #12663: [Consumer Refactor] Define event handler interface and events

philipnee commented on code in PR #12663: URL: https://github.com/apache/kafka/pull/12663#discussion_r975641032 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/EventHandler.java: ## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] hachikuji commented on a diff in pull request #12663: [Consumer Refactor] Define event handler interface and events

hachikuji commented on code in PR #12663: URL: https://github.com/apache/kafka/pull/12663#discussion_r975638603 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/EventHandler.java: ## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Comment Edited] (KAFKA-10635) Streams application fails with OutOfOrderSequenceException after rolling restarts of brokers

[ https://issues.apache.org/jira/browse/KAFKA-10635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17607329#comment-17607329 ] Guozhang Wang edited comment on KAFKA-10635 at 9/20/22 5:20 PM: Could

[jira] [Commented] (KAFKA-10635) Streams application fails with OutOfOrderSequenceException after rolling restarts of brokers

[ https://issues.apache.org/jira/browse/KAFKA-10635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17607329#comment-17607329 ] Guozhang Wang commented on KAFKA-10635: --- Could you try out this patch

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12667: MINOR: Improve logging with throwing OOOSE

guozhangwang commented on code in PR #12667: URL: https://github.com/apache/kafka/pull/12667#discussion_r975630163 ## core/src/main/scala/kafka/log/ProducerStateManager.scala: ## @@ -216,12 +216,12 @@ private[log] class ProducerAppendInfo(val topicPartition: TopicPartition,

[GitHub] [kafka] guozhangwang opened a new pull request, #12667: MINOR: Improve logging with throwing OOOSE

guozhangwang opened a new pull request, #12667: URL: https://github.com/apache/kafka/pull/12667 We need to have the full information on how the seq / epochs are inferred with logging. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation

[GitHub] [kafka] akhileshchg commented on a diff in pull request #12628: KAFKA-14214: Introduce read-write lock to StandardAuthorizer for consistent ACL reads.

akhileshchg commented on code in PR #12628: URL: https://github.com/apache/kafka/pull/12628#discussion_r975614289 ## metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizerData.java: ## @@ -193,15 +194,29 @@ StandardAuthorizerData

[jira] [Updated] (KAFKA-14243) Temporarily disable unsafe downgrade

[ https://issues.apache.org/jira/browse/KAFKA-14243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-14243: --- Fix Version/s: 3.3.0 > Temporarily disable unsafe downgrade >

[GitHub] [kafka] OmniaGM commented on pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

OmniaGM commented on PR #12577: URL: https://github.com/apache/kafka/pull/12577#issuecomment-1252621680 @mimaison, @tombentley can one of you please have a look into this PR? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] jolshan commented on a diff in pull request #12643: KAFKA-14097: make producer ID expiration a dynamic config

jolshan commented on code in PR #12643: URL: https://github.com/apache/kafka/pull/12643#discussion_r975586125 ## core/src/main/scala/kafka/log/ProducerStateManager.scala: ## @@ -939,3 +940,24 @@ object SnapshotFile { SnapshotFile(file, offset) } } + +class

[GitHub] [kafka] jolshan commented on a diff in pull request #12643: KAFKA-14097: make producer ID expiration a dynamic config

jolshan commented on code in PR #12643: URL: https://github.com/apache/kafka/pull/12643#discussion_r975585267 ## core/src/main/scala/kafka/log/ProducerStateManager.scala: ## @@ -939,3 +940,24 @@ object SnapshotFile { SnapshotFile(file, offset) } } + +class

[GitHub] [kafka] jeqo commented on a diff in pull request #12637: KAFKA-14226: [connect:transform] Introduce support for nested structures

jeqo commented on code in PR #12637: URL: https://github.com/apache/kafka/pull/12637#discussion_r975569257 ## connect/transforms/src/test/java/org/apache/kafka/connect/transforms/field/FieldPathTest.java: ## @@ -0,0 +1,183 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] dajac commented on pull request #12643: KAFKA-14097: make producer ID expiration a dynamic config

dajac commented on PR #12643: URL: https://github.com/apache/kafka/pull/12643#issuecomment-1252583284 @jolshan Left a small comment. Could you rebase it as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] dajac commented on a diff in pull request #12643: KAFKA-14097: make producer ID expiration a dynamic config

dajac commented on code in PR #12643: URL: https://github.com/apache/kafka/pull/12643#discussion_r975566769 ## core/src/main/scala/kafka/log/ProducerStateManager.scala: ## @@ -939,3 +940,24 @@ object SnapshotFile { SnapshotFile(file, offset) } } + +class

[GitHub] [kafka] C0urante commented on a diff in pull request #12666: KAFKA-14244: Add guard against accidental calls to halt JVM during testing

C0urante commented on code in PR #12666: URL: https://github.com/apache/kafka/pull/12666#discussion_r975538761 ## build.gradle: ## @@ -472,7 +475,7 @@ subprojects { useJUnitPlatform { includeTags "integration" includeTags

[GitHub] [kafka] C0urante commented on pull request #12639: KAFKA-14242: do not init managers twice to avoid resource leak

C0urante commented on PR #12639: URL: https://github.com/apache/kafka/pull/12639#issuecomment-1252547139 @showuon @ijuma I've taken a stab at a safeguard to prevent tests from accidentally terminating the JVM, and to accurately report where those calls for termination come from. If you're

[GitHub] [kafka] jeqo commented on a diff in pull request #12637: KAFKA-14226: [connect:transform] Introduce support for nested structures

jeqo commented on code in PR #12637: URL: https://github.com/apache/kafka/pull/12637#discussion_r975537150 ## connect/transforms/src/main/java/org/apache/kafka/connect/transforms/field/FieldPath.java: ## @@ -0,0 +1,377 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jeqo commented on a diff in pull request #12637: KAFKA-14226: [connect:transform] Introduce support for nested structures

jeqo commented on code in PR #12637: URL: https://github.com/apache/kafka/pull/12637#discussion_r975536673 ## connect/transforms/src/main/java/org/apache/kafka/connect/transforms/field/FieldPath.java: ## @@ -0,0 +1,377 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] C0urante opened a new pull request, #12666: KAFKA-14244: Add guard against accidental calls to halt JVM during testing

C0urante opened a new pull request, #12666: URL: https://github.com/apache/kafka/pull/12666 [Jira](https://issues.apache.org/jira/browse/KAFKA-14244) Uses an [automatically-registered JUnit 5

[GitHub] [kafka] der-eismann opened a new pull request, #12665: Fix typo in info message

der-eismann opened a new pull request, #12665: URL: https://github.com/apache/kafka/pull/12665 Minor change to a log line that had a typo in it ### Committer Checklist (excluded from commit message) - [x] Verify design and implementation - [x] Verify test coverage and CI build

[GitHub] [kafka] jeqo commented on a diff in pull request #12637: KAFKA-14226: [connect:transform] Introduce support for nested structures

jeqo commented on code in PR #12637: URL: https://github.com/apache/kafka/pull/12637#discussion_r975521554 ## connect/api/src/main/java/org/apache/kafka/connect/transforms/Transformation.java: ## @@ -24,20 +24,31 @@ /** * Single message transformation for Kafka Connect

[GitHub] [kafka] jeqo commented on a diff in pull request #12637: KAFKA-14226: [connect:transform] Introduce support for nested structures

jeqo commented on code in PR #12637: URL: https://github.com/apache/kafka/pull/12637#discussion_r975521064 ## connect/transforms/src/main/java/org/apache/kafka/connect/transforms/ExtractField.java: ## @@ -39,33 +41,35 @@ private static final String FIELD_CONFIG = "field";

[GitHub] [kafka] mumrah commented on a diff in pull request #12628: KAFKA-14214: Introduce read-write lock to StandardAuthorizer for consistent ACL reads.

mumrah commented on code in PR #12628: URL: https://github.com/apache/kafka/pull/12628#discussion_r975497294 ## metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizerData.java: ## @@ -530,54 +545,14 @@ static AuthorizationResult findResult(Action action,

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975464527 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java: ## @@ -313,36 +282,29 @@ public void shouldNotFlushAndThrowOnCloseDirty()

[GitHub] [kafka] mdedetrich commented on pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on PR #12524: URL: https://github.com/apache/kafka/pull/12524#issuecomment-1252484624 @cadonna I have addressed the comments which I could. I just noticed that I have gone back and forth between removing and adding the same stubs/verifications in various without

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975478357 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorStateManagerTest.java: ## @@ -310,48 +301,30 @@ public void

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975472755 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java: ## @@ -211,32 +205,22 @@ public void

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975469281 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java: ## @@ -313,36 +282,29 @@ public void shouldNotFlushAndThrowOnCloseDirty()

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975464527 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java: ## @@ -313,36 +282,29 @@ public void shouldNotFlushAndThrowOnCloseDirty()

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975464527 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java: ## @@ -313,36 +282,29 @@ public void shouldNotFlushAndThrowOnCloseDirty()

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975440743 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java: ## @@ -313,36 +282,29 @@ public void shouldNotFlushAndThrowOnCloseDirty()

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975440743 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java: ## @@ -313,36 +282,29 @@ public void shouldNotFlushAndThrowOnCloseDirty()

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975440743 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java: ## @@ -313,36 +282,29 @@ public void shouldNotFlushAndThrowOnCloseDirty()

[jira] [Created] (KAFKA-14244) Prevent unit/integration tests from terminating JVM

Chris Egerton created KAFKA-14244: - Summary: Prevent unit/integration tests from terminating JVM Key: KAFKA-14244 URL: https://issues.apache.org/jira/browse/KAFKA-14244 Project: Kafka Issue

[GitHub] [kafka] divijvaidya commented on pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

divijvaidya commented on PR #12590: URL: https://github.com/apache/kafka/pull/12590#issuecomment-1252416795 > does the fetch request to close the session fetches any records No, because the fetch request's field for topic partitions is set to empty at

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975415669 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java: ## @@ -313,36 +282,29 @@ public void shouldNotFlushAndThrowOnCloseDirty()

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975414772 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java: ## @@ -313,36 +282,29 @@ public void shouldNotFlushAndThrowOnCloseDirty()

[GitHub] [kafka] cadonna commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

cadonna commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975414658 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorStateManagerTest.java: ## @@ -310,48 +301,30 @@ public void

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975392538 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorStateManagerTest.java: ## @@ -310,48 +301,30 @@ public void

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975412340 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java: ## @@ -211,32 +205,22 @@ public void

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975397584 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorStateManagerTest.java: ## @@ -360,14 +333,8 @@ public void

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975392538 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorStateManagerTest.java: ## @@ -310,48 +301,30 @@ public void

[GitHub] [kafka] dajac merged pull request #12645: MINOR: Log controller id/epoch when LeaderAndIsr, StopReplica and UpdateMetadata requests are fenced

dajac merged PR #12645: URL: https://github.com/apache/kafka/pull/12645 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] akatona84 commented on pull request #11373: MINOR: Add shebang to gradlewAll

akatona84 commented on PR #11373: URL: https://github.com/apache/kafka/pull/11373#issuecomment-1252289779 @omkreddy , @ijuma could you take a look? pretty small change, pretty pls :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12465: KAFKA-12950: Replace EasyMock and PowerMock with Mockito for KafkaStreamsTest

divijvaidya commented on code in PR #12465: URL: https://github.com/apache/kafka/pull/12465#discussion_r975301980 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java: ## @@ -1146,6 +1146,10 @@ private long advanceNowAndComputeLatency() {

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12465: KAFKA-12950: Replace EasyMock and PowerMock with Mockito for KafkaStreamsTest

divijvaidya commented on code in PR #12465: URL: https://github.com/apache/kafka/pull/12465#discussion_r975301060 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -1096,7 +1096,7 @@ private Optional removeStreamThread(final long timeoutMs) throws

[GitHub] [kafka] mimaison commented on pull request #11748: KAFKA-12635: Don't emit checkpoints for partitions without any offset…

mimaison commented on PR #11748: URL: https://github.com/apache/kafka/pull/11748#issuecomment-1252285749 @ryan-burningham This fix will be included in the upcoming 3.3.0 release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] cadonna commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

cadonna commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975189051 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorStateManagerTest.java: ## @@ -310,48 +301,30 @@ public void

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12465: KAFKA-12950: Replace EasyMock and PowerMock with Mockito for KafkaStreamsTest

divijvaidya commented on code in PR #12465: URL: https://github.com/apache/kafka/pull/12465#discussion_r975246480 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java: ## @@ -252,10 +252,15 @@ State setState(final State newState) {

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12465: KAFKA-12950: Replace EasyMock and PowerMock with Mockito for KafkaStreamsTest

divijvaidya commented on code in PR #12465: URL: https://github.com/apache/kafka/pull/12465#discussion_r975245954 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -990,7 +990,12 @@ private StreamThread createAndAddStreamThread(final long

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12465: KAFKA-12950: Replace EasyMock and PowerMock with Mockito for KafkaStreamsTest

divijvaidya commented on code in PR #12465: URL: https://github.com/apache/kafka/pull/12465#discussion_r975245160 ## streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java: ## @@ -192,154 +209,141 @@ public void before() throws Exception {

[GitHub] [kafka] cadonna merged pull request #12648: MINOR: Fixes in release.py

cadonna merged PR #12648: URL: https://github.com/apache/kafka/pull/12648 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-10635) Streams application fails with OutOfOrderSequenceException after rolling restarts of brokers

[ https://issues.apache.org/jira/browse/KAFKA-10635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17607083#comment-17607083 ] Nicholas Telford commented on KAFKA-10635: -- [~guozhang] is there any more information I can

[GitHub] [kafka] mdedetrich commented on pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on PR #12524: URL: https://github.com/apache/kafka/pull/12524#issuecomment-1252139067 @cadonna Okay so I have just pushed and rebased the PR with these changes * As you have rightly pointed out there were a lot of things being stubbed/tested which made no sense

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975149899 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorStateManagerTest.java: ## @@ -308,29 +300,21 @@ public void

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975145693 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java: ## @@ -212,31 +212,29 @@ public void

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975142135 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java: ## @@ -212,31 +212,29 @@ public void

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975140126 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java: ## @@ -212,31 +212,29 @@ public void

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975129867 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java: ## @@ -177,10 +181,7 @@ public void

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975126734 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorStateManagerTest.java: ## @@ -360,12 +339,11 @@ public void

[GitHub] [kafka] showuon commented on pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

showuon commented on PR #12590: URL: https://github.com/apache/kafka/pull/12590#issuecomment-1252100858 > Perhaps a naive question but does the fetch request to close the session fetches any records? Or does it just close the session and return? @dajac , good question. When consumer

[GitHub] [kafka] yashmayya commented on a diff in pull request #12637: KAFKA-14226: [connect:transform] Introduce support for nested structures

yashmayya commented on code in PR #12637: URL: https://github.com/apache/kafka/pull/12637#discussion_r974127639 ## connect/api/src/main/java/org/apache/kafka/connect/transforms/Transformation.java: ## @@ -24,20 +24,31 @@ /** * Single message transformation for Kafka

[GitHub] [kafka] dajac commented on pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

dajac commented on PR #12590: URL: https://github.com/apache/kafka/pull/12590#issuecomment-1252020391 Perhaps a naive question but does the fetch request to close the session fetches any records? Or does it just close the session and return? -- This is an automated message from the

[jira] [Resolved] (KAFKA-14212) Fetch error response when hitting public OAuth/OIDC provider

[ https://issues.apache.org/jira/browse/KAFKA-14212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-14212. --- Fix Version/s: 3.4.0 Resolution: Fixed > Fetch error response when hitting public OAuth/OIDC

[GitHub] [kafka] omkreddy merged pull request #12651: KAFKA-14212: Enhanced HttpAccessTokenRetriever to retrieve error mess…

omkreddy merged PR #12651: URL: https://github.com/apache/kafka/pull/12651 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] omkreddy commented on pull request #12148: MINOR: Remove unnecessary log4j-appender dependency and tweak explicit log4j dependency

omkreddy commented on PR #12148: URL: https://github.com/apache/kafka/pull/12148#issuecomment-1251901651 @ijuma sorry missed this. Can you rebase the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] omkreddy commented on pull request #12039: KAFKA-13725: KIP-768 OAuth code mixes public and internal classes in same package

omkreddy commented on PR #12039: URL: https://github.com/apache/kafka/pull/12039#issuecomment-1251902166 @kirktrue Can you fix checkStyle errors -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

  1   2   >