[GitHub] [kafka] showuon commented on a diff in pull request #13327: MINOR: tweak the doc of "num.network.threads"

showuon commented on code in PR #13327: URL: https://github.com/apache/kafka/pull/13327#discussion_r1124118829 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -678,7 +678,7 @@ object KafkaConfig { "start from " + MaxReservedBrokerIdProp + " + 1." val

[jira] [Commented] (KAFKA-13421) Fix ConsumerBounceTest#testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup

[ https://issues.apache.org/jira/browse/KAFKA-13421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696010#comment-17696010 ] Philip Nee commented on KAFKA-13421: I think the original issue

[GitHub] [kafka] philipnee commented on pull request #12038: [WIP] KAFKA-13421

philipnee commented on PR #12038: URL: https://github.com/apache/kafka/pull/12038#issuecomment-1452987508 I wonder if it is because of the heartbeat interval. Here we are starting 5 consumers, each polling for 50ms = 250ms. The heartbeat interval is 1000ms. After bumping it to 10s, it

[GitHub] [kafka] philipnee opened a new pull request, #12038: [WIP] KAFKA-13421

philipnee opened a new pull request, #12038: URL: https://github.com/apache/kafka/pull/12038 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[GitHub] [kafka] ijuma commented on a diff in pull request #13304: KAFKA-14726 Move/rewrite of LogReadInfo, LogOffsetSnapshot, LogStartOffsetIncrementReason to storage module

ijuma commented on code in PR #13304: URL: https://github.com/apache/kafka/pull/13304#discussion_r1124016717 ## storage/src/main/java/org/apache/kafka/storage/internals/log/FetchDataInfo.java: ## @@ -44,6 +45,28 @@ public FetchDataInfo(LogOffsetMetadata fetchOffsetMetadata,

[jira] [Commented] (KAFKA-9234) Consider using @Nullable and @Nonnull annotations

[ https://issues.apache.org/jira/browse/KAFKA-9234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695999#comment-17695999 ] Ganesh Sahu commented on KAFKA-9234: Sure, Thank you. I just joined the community this week. I

[GitHub] [kafka] satishd commented on a diff in pull request #13304: KAFKA-14726 Move/rewrite of LogReadInfo, LogOffsetSnapshot, LogStartOffsetIncrementReason to storage module

satishd commented on code in PR #13304: URL: https://github.com/apache/kafka/pull/13304#discussion_r1124009466 ## storage/src/main/java/org/apache/kafka/storage/internals/log/FetchDataInfo.java: ## @@ -44,6 +45,28 @@ public FetchDataInfo(LogOffsetMetadata fetchOffsetMetadata,

[jira] [Comment Edited] (KAFKA-14768) proposal to reduce the first message's send time cost and max block time for safety

[ https://issues.apache.org/jira/browse/KAFKA-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695962#comment-17695962 ] fujian edited comment on KAFKA-14768 at 3/3/23 2:47 AM: Hi [~showuon]  I

[GitHub] [kafka] mjsax commented on a diff in pull request #13274: KAFKA-14491: [13/N] Add versioned store builder and materializer

mjsax commented on code in PR #13274: URL: https://github.com/apache/kafka/pull/13274#discussion_r1123970487 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KeyValueStoreMaterializer.java: ## @@ -48,20 +55,30 @@ public StoreBuilder> materialize() {

[GitHub] [kafka] mjsax commented on a diff in pull request #13274: KAFKA-14491: [13/N] Add versioned store builder and materializer

mjsax commented on code in PR #13274: URL: https://github.com/apache/kafka/pull/13274#discussion_r1123965019 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KeyValueStoreMaterializer.java: ## @@ -48,20 +55,30 @@ public StoreBuilder> materialize() {

[jira] [Commented] (KAFKA-14768) proposal to reduce the first message's send time cost and max block time for safety

[ https://issues.apache.org/jira/browse/KAFKA-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695962#comment-17695962 ] fujian commented on KAFKA-14768: Hi [~showuon]  I checked the KIP and related JIRA. I think the KIP is

[GitHub] [kafka] mjsax commented on a diff in pull request #13300: KAFKA-10199: Add task updater metrics, part 2

mjsax commented on code in PR #13300: URL: https://github.com/apache/kafka/pull/13300#discussion_r1123947731 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java: ## @@ -986,6 +987,11 @@ private void prepareChangelogs(final Set

[jira] [Commented] (KAFKA-14768) proposal to reduce the first message's send time cost and max block time for safety

[ https://issues.apache.org/jira/browse/KAFKA-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695956#comment-17695956 ] fujian commented on KAFKA-14768: Hi  [~showuon]  Thanks for your feedback.  For 1, send one "warm up"

[GitHub] [kafka] gharris1727 opened a new pull request, #13334: MINOR: Move plugin path parsing from DelegatingClassLoader to PluginUtils

gharris1727 opened a new pull request, #13334: URL: https://github.com/apache/kafka/pull/13334 The logic for decomposing a `plugin.path` list into the component single-plugin locations is nontrivial, and currently implemented by the DelegatingClassLoader. Decoupling this logic from the

[GitHub] [kafka] guozhangwang commented on pull request #13318: KAFKA-14533: Do not interrupt state-updater thread during shutdown

guozhangwang commented on PR #13318: URL: https://github.com/apache/kafka/pull/13318#issuecomment-1452793608 SmokeTestDriverIntegrationTest did not fail in https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13318/11, triggering again. If that run still did not fail

[GitHub] [kafka] kirktrue commented on pull request #13301: KAFKA-14758: Extract inner classes from Fetcher for reuse in refactoring

kirktrue commented on PR #13301: URL: https://github.com/apache/kafka/pull/13301#issuecomment-1452775886 @guozhangwang wrote: > A meta comment is that for the extracted classes, I think we should add unit test coverages for them (hopefully most of them are already in the

[GitHub] [kafka] gharris1727 opened a new pull request, #13333: MINOR: Cleanup TestPlugins and normalize TestPlugin enum

gharris1727 opened a new pull request, #1: URL: https://github.com/apache/kafka/pull/1 This class has a circular classloading dependency that causes an NPE if TestPlugins.TestPlugin is loaded before TestPlugins. This was introduced in #13182 but does not impact the build because

[jira] [Commented] (KAFKA-14748) Relax non-null FK left-join requirement

[ https://issues.apache.org/jira/browse/KAFKA-14748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695945#comment-17695945 ] Matthias J. Sax commented on KAFKA-14748: - {quote}But for table-table FK-joins, today the former

[GitHub] [kafka] kirktrue commented on a diff in pull request #12813: KAFKA-14317: ProduceRequest timeouts are logged as network exceptions

kirktrue commented on code in PR #12813: URL: https://github.com/apache/kafka/pull/12813#discussion_r1123911988 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -641,7 +643,7 @@ private void completeBatch(ProducerBatch batch,

[GitHub] [kafka] cmccabe opened a new pull request, #13332: KAFKA-14057: Support dynamic reconfiguration in KRaft remote controllers

cmccabe opened a new pull request, #13332: URL: https://github.com/apache/kafka/pull/13332 This PR allows us to dynamically reconfigure the KRaft controller by setting either a cluster configuration (that is, a configuration that applies to all resource of type BROKER), or by configuring a

[jira] [Assigned] (KAFKA-14057) Support dynamic reconfiguration in KRaft remote controllers

[ https://issues.apache.org/jira/browse/KAFKA-14057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe reassigned KAFKA-14057: Assignee: Colin McCabe > Support dynamic reconfiguration in KRaft remote controllers >

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13292: KAFKA-14491: [14/N] Set changelog topic configs for versioned stores

vcrfxia commented on code in PR #13292: URL: https://github.com/apache/kafka/pull/13292#discussion_r1116012004 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/UnwindowedChangelogTopicConfig.java: ## @@ -25,7 +25,7 @@ /** *

[GitHub] [kafka] mjsax merged pull request #13264: KAFKA-14491: [12/N] Relax requirement that KTable stores must be TimestampedKVStores

mjsax merged PR #13264: URL: https://github.com/apache/kafka/pull/13264 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1123774975 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java: ## @@ -1303,11 +1305,13 @@ public void

[GitHub] [kafka] cmccabe opened a new pull request, #13331: MINOR: fix fault handling in ControllerServer and KafkaServer

cmccabe opened a new pull request, #13331: URL: https://github.com/apache/kafka/pull/13331 This PR has two fixes for fault handling. One makes fault handling more strict on the controller; the other makes it a bit less strict on the (ZK-based) broker. In ControllerServer, invoke a

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1123767340 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -1328,7 +1328,7 @@ Priority priority() { @Override

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1123765294 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -118,11 +123,78 @@ public AddPartitionsToTxnRequestData data() {

[GitHub] [kafka] philipnee commented on a diff in pull request #13330: Prototyping Rebalance Protocol

philipnee commented on code in PR #13330: URL: https://github.com/apache/kafka/pull/13330#discussion_r1123760146 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ProtocolRequestManager.java: ## @@ -0,0 +1,96 @@ +package

[GitHub] [kafka] philipnee commented on a diff in pull request #13330: Prototyping Rebalance Protocol

philipnee commented on code in PR #13330: URL: https://github.com/apache/kafka/pull/13330#discussion_r1123759741 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ProtocolRequestManager.java: ## @@ -0,0 +1,96 @@ +package

[GitHub] [kafka] philipnee opened a new pull request, #13330: Prototyping Rebalance Protocol

philipnee opened a new pull request, #13330: URL: https://github.com/apache/kafka/pull/13330 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[GitHub] [kafka] guozhangwang commented on pull request #13318: KAFKA-14533: Do not interrupt state-updater thread during shutdown

guozhangwang commented on PR #13318: URL: https://github.com/apache/kafka/pull/13318#issuecomment-1452549269 `SmokeTestDriverIntegrationTest` did not fail in `https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13318/2`, triggering again. -- This is an automated message from the

[GitHub] [kafka] twmb commented on pull request #12990: KAFKA-14451: Rack-aware consumer partition assignment for RangeAssignor (KIP-881)

twmb commented on PR #12990: URL: https://github.com/apache/kafka/pull/12990#issuecomment-1452523214 :wave: hi, seeing this after it's merged! Is the intent to create a new PR for making the sticky assignor rack aware? I see in the original PR #12914 that both range and sticky were

[GitHub] [kafka] gharris1727 commented on pull request #13313: KAFKA-14760: Move ThroughputThrottler from tools to clients, remove tools dependency from connect-runtime

gharris1727 commented on PR #13313: URL: https://github.com/apache/kafka/pull/13313#issuecomment-1452503148 This refactor first landed in #432 and then the current dependency graph was set by #512 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] Hangleton commented on pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

Hangleton commented on PR #13240: URL: https://github.com/apache/kafka/pull/13240#issuecomment-1452495333 Thanks David for the review, have a few more tests to add but this should be eligible to another pass. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] C0urante merged pull request #13182: KAFKA-14649: Isolate failures during plugin path scanning to single plugin classes

C0urante merged PR #13182: URL: https://github.com/apache/kafka/pull/13182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-14533) Flaky Test SmokeTestDriverIntegrationTest.shouldWorkWithRebalance

[ https://issues.apache.org/jira/browse/KAFKA-14533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695888#comment-17695888 ] Guozhang Wang commented on KAFKA-14533: --- After some investigation I found the following: 1. In

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13318: [DO NOT MERGE] KAFKA-14533: Re-enable state-updater in SmokeTestDriverIntegrationTest

guozhangwang commented on code in PR #13318: URL: https://github.com/apache/kafka/pull/13318#discussion_r1123632054 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/ClientUtils.java: ## @@ -143,6 +145,33 @@ public static KafkaFuture> fetchEndOf

[GitHub] [kafka] dajac opened a new pull request, #13329: KAFKA-14462; [2/N] Add ConsumerGroupHeartbeart to GroupCoordinator interface

dajac opened a new pull request, #13329: URL: https://github.com/apache/kafka/pull/13329 This patch adds ConsumerGroupHeartbeat to the GroupCoordinator interface and implements the API in KafkaApis. ### Committer Checklist (excluded from commit message) - [ ] Verify design and

[GitHub] [kafka] dajac merged pull request #13322: KAFKA-14462; [1/N] Add new server configurations (KIP-848)

dajac merged PR #13322: URL: https://github.com/apache/kafka/pull/13322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] junrao commented on a diff in pull request #13304: KAFKA-14726 Move/rewrite of LogReadInfo, LogOffsetSnapshot, LogStartOffsetIncrementReason to storage module

junrao commented on code in PR #13304: URL: https://github.com/apache/kafka/pull/13304#discussion_r1123584048 ## storage/src/main/java/org/apache/kafka/storage/internals/log/FetchDataInfo.java: ## @@ -44,6 +45,28 @@ public FetchDataInfo(LogOffsetMetadata fetchOffsetMetadata,

[jira] [Comment Edited] (KAFKA-14773) Make MirrorMaker startup synchronous

[ https://issues.apache.org/jira/browse/KAFKA-14773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695862#comment-17695862 ] Chris Egerton edited comment on KAFKA-14773 at 3/2/23 6:49 PM: --- The

[jira] [Commented] (KAFKA-14773) Make MirrorMaker startup synchronous

[ https://issues.apache.org/jira/browse/KAFKA-14773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695862#comment-17695862 ] Chris Egerton commented on KAFKA-14773: --- The shell script encompasses the entire lifetime of MM2;

[GitHub] [kafka] C0urante commented on a diff in pull request #13284: KAFKA-14718: Fix flaky DedicatedMirrorIntegrationTest

C0urante commented on code in PR #13284: URL: https://github.com/apache/kafka/pull/13284#discussion_r1123546376 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMaker.java: ## @@ -322,6 +324,29 @@ public void run() { } } +/** + *

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13301: KAFKA-14758: Extract inner classes from Fetcher for reuse in refactoring

guozhangwang commented on code in PR #13301: URL: https://github.com/apache/kafka/pull/13301#discussion_r1123543033 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchManagerMetrics.java: ## @@ -0,0 +1,212 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

dajac commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1123529173 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -118,11 +123,78 @@ public AddPartitionsToTxnRequestData data() {

[GitHub] [kafka] dajac commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

dajac commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1123527995 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -1328,7 +1328,7 @@ Priority priority() { @Override

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1123526676 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -118,11 +123,78 @@ public AddPartitionsToTxnRequestData data() {

[jira] [Commented] (KAFKA-14746) Throwing in Connector.taskConfigs generates a lot of logs

[ https://issues.apache.org/jira/browse/KAFKA-14746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695852#comment-17695852 ] Mickael Maison commented on KAFKA-14746: https://issues.apache.org/jira/browse/KAFKA-14732

[GitHub] [kafka] dajac commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

dajac commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1123517021 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java: ## @@ -1303,11 +1305,13 @@ public void

[GitHub] [kafka] C0urante commented on pull request #10566: KAFKA-12694 Avoid schema mismatch DataException when validating default values

C0urante commented on PR #10566: URL: https://github.com/apache/kafka/pull/10566#issuecomment-1452296446 @urbandan I've given the "tweak" fix (i.e., altering `ConnectSchema::equals` to use interface methods and accept any `Schema` instance during equality checking) a shot locally and,

[GitHub] [kafka] dajac commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

dajac commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1123514453 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -118,11 +123,78 @@ public AddPartitionsToTxnRequestData data() {

[GitHub] [kafka] jolshan commented on a diff in pull request #13322: KAFKA-14462; [1/N] Add new server configurations (KIP-848)

jolshan commented on code in PR #13322: URL: https://github.com/apache/kafka/pull/13322#discussion_r1123513945 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -1267,6 +1314,24 @@ object KafkaConfig { .define(GroupInitialRebalanceDelayMsProp, INT,

[jira] [Commented] (KAFKA-14747) FK join should record discarded subscription responses

[ https://issues.apache.org/jira/browse/KAFKA-14747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695848#comment-17695848 ] Matthias J. Sax commented on KAFKA-14747: - You would create a branch from `trunk` – for more

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1123508496 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -1328,7 +1328,7 @@ Priority priority() { @Override

[jira] [Commented] (KAFKA-9234) Consider using @Nullable and @Nonnull annotations

[ https://issues.apache.org/jira/browse/KAFKA-9234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695846#comment-17695846 ] Matthias J. Sax commented on KAFKA-9234:  [~rndgstn] did look into the PRs - maybe he knows best?

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1123503881 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -118,11 +123,78 @@ public AddPartitionsToTxnRequestData data() {

[GitHub] [kafka] dajac commented on pull request #13323: KAFKA-14617; Add ReplicaState to FetchRequest.

dajac commented on PR #13323: URL: https://github.com/apache/kafka/pull/13323#issuecomment-1452269739 @CalvinConfluent Thanks for the explanation. I agree that we have two options on the table: 1) pass the api version or even the header object; or 2) rely on the default sentinel value to

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1123501064 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java: ## @@ -1303,11 +1305,13 @@ public void

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1123499195 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2384,68 +2385,116 @@ class KafkaApis(val requestChannel: RequestChannel, if

[GitHub] [kafka] CalvinConfluent commented on pull request #13323: KAFKA-14617; Add ReplicaState to FetchRequest.

CalvinConfluent commented on PR #13323: URL: https://github.com/apache/kafka/pull/13323#issuecomment-1452256725 @dajac I think the major question is how can the KafkaRaftClient can correctly consume the FetchRequest. The current PR makes quite some efforts to get the FetchRequest

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617; Add ReplicaState to FetchRequest.

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1123476762 ## clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java: ## @@ -337,8 +362,27 @@ public AbstractResponse getErrorResponse(int

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617; Add ReplicaState to FetchRequest.

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1123475771 ## clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java: ## @@ -302,6 +315,18 @@ public String toString() { } } +public

[GitHub] [kafka] mimaison opened a new pull request, #13328: KAFKA-14745: Cache the ReplicationPolicy instance in MirrorConnectorC…

mimaison opened a new pull request, #13328: URL: https://github.com/apache/kafka/pull/13328 …onfig Otherwise calls to `checkpointsTopic()`, whcih happen relatively frequently, keep creating new ReplicationPolicy instances. ### Committer Checklist (excluded from commit

[GitHub] [kafka] satishd commented on pull request #13275: KAFKA-14522 Rewrite/Move of RemoteIndexCache to storage module.

satishd commented on PR #13275: URL: https://github.com/apache/kafka/pull/13275#issuecomment-1452242033 Thanks @junrao for your review. Addressed your comments inline and/or updated with the latest commit. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617; Add ReplicaState to FetchRequest.

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1123469847 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -936,13 +937,13 @@ private CompletableFuture handleFetchRequest(

[GitHub] [kafka] C0urante commented on a diff in pull request #13185: KAFKA-14670: (part 1) Wrap Connectors in IsolatedConnector objects

C0urante commented on code in PR #13185: URL: https://github.com/apache/kafka/pull/13185#discussion_r1123470094 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java: ## @@ -243,7 +248,11 @@ public synchronized void

[GitHub] [kafka] C0urante commented on a diff in pull request #13185: KAFKA-14670: (part 1) Wrap Connectors in IsolatedConnector objects

C0urante commented on code in PR #13185: URL: https://github.com/apache/kafka/pull/13185#discussion_r1123467255 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java: ## @@ -243,7 +248,11 @@ public synchronized void

[GitHub] [kafka] C0urante commented on a diff in pull request #13185: KAFKA-14670: (part 1) Wrap Connectors in IsolatedConnector objects

C0urante commented on code in PR #13185: URL: https://github.com/apache/kafka/pull/13185#discussion_r1120754565 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java: ## @@ -243,7 +248,11 @@ public synchronized void

[jira] [Commented] (KAFKA-14747) FK join should record discarded subscription responses

[ https://issues.apache.org/jira/browse/KAFKA-14747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695817#comment-17695817 ] Koma Zhang commented on KAFKA-14747: Thank u guys, so for me as the developer, which branch i can

[GitHub] [kafka] chia7712 opened a new pull request, #13327: MINOR: tweak the doc of "num.network.threads"

chia7712 opened a new pull request, #13327: URL: https://github.com/apache/kafka/pull/13327 send readers a reminder: the total number of network threads is `listeners * num.network.threads` ### Committer Checklist (excluded from commit message) - [ ] Verify design and

[GitHub] [kafka] satishd commented on a diff in pull request #13275: KAFKA-14522 Rewrite/Move of RemoteIndexCache to storage module.

satishd commented on code in PR #13275: URL: https://github.com/apache/kafka/pull/13275#discussion_r1123369985 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ## @@ -0,0 +1,407 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] satishd commented on a diff in pull request #13275: KAFKA-14522 Rewrite/Move of RemoteIndexCache to storage module.

satishd commented on code in PR #13275: URL: https://github.com/apache/kafka/pull/13275#discussion_r1123045997 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ## @@ -0,0 +1,407 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] urbandan commented on pull request #10566: KAFKA-12694 Avoid schema mismatch DataException when validating default values

urbandan commented on PR #10566: URL: https://github.com/apache/kafka/pull/10566#issuecomment-1452111290 @C0urante I'm also hesitant to change the API, but I think this part of the API is broken. If we tweak ConnectSchema::equals to use the Schema interface methods, then setting the

[GitHub] [kafka] C0urante commented on a diff in pull request #13185: KAFKA-14670: (part 1) Wrap Connectors in IsolatedConnector objects

C0urante commented on code in PR #13185: URL: https://github.com/apache/kafka/pull/13185#discussion_r1120754565 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java: ## @@ -243,7 +248,11 @@ public synchronized void

[jira] [Assigned] (KAFKA-12550) Introduce RESTORING state to the KafkaStreams FSM

[ https://issues.apache.org/jira/browse/KAFKA-12550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao reassigned KAFKA-12550: - Assignee: (was: Sagar Rao) > Introduce RESTORING state to the KafkaStreams FSM >

[jira] [Assigned] (KAFKA-13501) Avoid state restore via rebalance if standbys are enabled

[ https://issues.apache.org/jira/browse/KAFKA-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao reassigned KAFKA-13501: - Assignee: (was: Sagar Rao) > Avoid state restore via rebalance if standbys are enabled >

[jira] [Assigned] (KAFKA-13499) Avoid restoring outdated records

[ https://issues.apache.org/jira/browse/KAFKA-13499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao reassigned KAFKA-13499: - Assignee: (was: Sagar Rao) > Avoid restoring outdated records >

[jira] [Assigned] (KAFKA-12957) Refactor Streams Logical Plan Generation

[ https://issues.apache.org/jira/browse/KAFKA-12957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao reassigned KAFKA-12957: - Assignee: (was: Sagar Rao) > Refactor Streams Logical Plan Generation >

[jira] [Assigned] (KAFKA-13336) Migrate StreamsBuilder/Topology class to interfaces and move Topology parameter from KafkaStreams constructor to #start

[ https://issues.apache.org/jira/browse/KAFKA-13336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao reassigned KAFKA-13336: - Assignee: (was: Sagar Rao) > Migrate StreamsBuilder/Topology class to interfaces and move

[jira] [Assigned] (KAFKA-13349) Allow Iterator.remove on KeyValueIterator

[ https://issues.apache.org/jira/browse/KAFKA-13349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao reassigned KAFKA-13349: - Assignee: (was: Sagar Rao) > Allow Iterator.remove on KeyValueIterator >

[jira] [Assigned] (KAFKA-13555) Consider number if input topic partitions for task assignment

[ https://issues.apache.org/jira/browse/KAFKA-13555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao reassigned KAFKA-13555: - Assignee: (was: Sagar Rao) > Consider number if input topic partitions for task assignment

[GitHub] [kafka] C0urante commented on a diff in pull request #13185: KAFKA-14670: (part 1) Wrap Connectors in IsolatedConnector objects

C0urante commented on code in PR #13185: URL: https://github.com/apache/kafka/pull/13185#discussion_r1123318824 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/IsolatedPlugin.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software

[jira] [Assigned] (KAFKA-14585) Move StorageTool to tools

[ https://issues.apache.org/jira/browse/KAFKA-14585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao reassigned KAFKA-14585: - Assignee: (was: Sagar Rao) > Move StorageTool to tools > - > >

[jira] [Assigned] (KAFKA-14487) Move LogManager to storage module

[ https://issues.apache.org/jira/browse/KAFKA-14487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao reassigned KAFKA-14487: - Assignee: (was: Sagar Rao) > Move LogManager to storage module >

[GitHub] [kafka] mimaison commented on a diff in pull request #13215: KAFKA-14578: Move ConsumerPerformance to tools

mimaison commented on code in PR #13215: URL: https://github.com/apache/kafka/pull/13215#discussion_r1123250142 ## tools/src/main/java/org/apache/kafka/tools/ConsumerPerformance.java: ## @@ -0,0 +1,397 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] C0urante commented on a diff in pull request #13182: KAFKA-14649: Isolate failures during plugin path scanning to single plugin classes

C0urante commented on code in PR #13182: URL: https://github.com/apache/kafka/pull/13182#discussion_r1123292638 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java: ## @@ -419,7 +423,14 @@ private Collection>

[GitHub] [kafka] C0urante commented on a diff in pull request #13182: KAFKA-14649: Isolate failures during plugin path scanning to single plugin classes

C0urante commented on code in PR #13182: URL: https://github.com/apache/kafka/pull/13182#discussion_r1123292197 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/TestPlugins.java: ## @@ -111,20 +115,62 @@ public enum TestPlugin { /**

[GitHub] [kafka] chia7712 opened a new pull request, #13326: KAFKA-14774 the removed listeners should not be reconfigurable

chia7712 opened a new pull request, #13326: URL: https://github.com/apache/kafka/pull/13326 Users can alter broker configuration to remove specify listeners. However, the removed listeners are NOT removed from `reconfigurables` list. It can result in the idle processors if users increases

[jira] [Updated] (KAFKA-13702) Connect RestClient overrides response status code on request failure

[ https://issues.apache.org/jira/browse/KAFKA-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-13702: -- Fix Version/s: 3.3.3 > Connect RestClient overrides response status code on request failure >

[jira] [Created] (KAFKA-14774) the removed listeners should not be reconfigurable

Chia-Ping Tsai created KAFKA-14774: -- Summary: the removed listeners should not be reconfigurable Key: KAFKA-14774 URL: https://issues.apache.org/jira/browse/KAFKA-14774 Project: Kafka Issue

[GitHub] [kafka] C0urante merged pull request #13287: MINOR: Refactor task change logic to AbstractHerder, reuse for standalone mode.

C0urante merged PR #13287: URL: https://github.com/apache/kafka/pull/13287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (KAFKA-14771) Include current thread ids in ConcurrentModificationException message

[ https://issues.apache.org/jira/browse/KAFKA-14771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierangelo Di Pilato updated KAFKA-14771: - Fix Version/s: (was: 3.3) > Include current thread ids in

[jira] [Updated] (KAFKA-14771) Include current thread ids in ConcurrentModificationException message

[ https://issues.apache.org/jira/browse/KAFKA-14771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierangelo Di Pilato updated KAFKA-14771: - Fix Version/s: 3.3 > Include current thread ids in

[jira] [Assigned] (KAFKA-14771) Include current thread ids in ConcurrentModificationException message

[ https://issues.apache.org/jira/browse/KAFKA-14771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierangelo Di Pilato reassigned KAFKA-14771: Assignee: Pierangelo Di Pilato > Include current thread ids in

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13285: KAFKA-13874 Avoid synchronization in SocketServer metrics

divijvaidya commented on code in PR #13285: URL: https://github.com/apache/kafka/pull/13285#discussion_r1123127295 ## core/src/main/scala/kafka/network/SocketServer.scala: ## @@ -115,22 +115,15 @@ class SocketServer(val config: KafkaConfig, private var stopped = false

[GitHub] [kafka] dajac commented on a diff in pull request #12813: KAFKA-14317: ProduceRequest timeouts are logged as network exceptions

dajac commented on code in PR #12813: URL: https://github.com/apache/kafka/pull/12813#discussion_r1123117911 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -641,7 +643,7 @@ private void completeBatch(ProducerBatch batch,

[GitHub] [kafka] chia7712 commented on a diff in pull request #13285: KAFKA-13874 Avoid synchronization in SocketServer metrics

chia7712 commented on code in PR #13285: URL: https://github.com/apache/kafka/pull/13285#discussion_r1123116645 ## core/src/main/scala/kafka/network/SocketServer.scala: ## @@ -115,22 +115,23 @@ class SocketServer(val config: KafkaConfig, private var stopped = false //

[GitHub] [kafka] dajac commented on a diff in pull request #13323: KAFKA-14617; Add ReplicaState to FetchRequest.

dajac commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1123094538 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -936,13 +937,13 @@ private CompletableFuture handleFetchRequest( RaftRequest.Inbound

[GitHub] [kafka] pierDipi commented on pull request #13325: KAFKA-14771: Include threads info in ConcurrentModificationException message

pierDipi commented on PR #13325: URL: https://github.com/apache/kafka/pull/13325#issuecomment-1451869239 cc for review @hachikuji @showuon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] chia7712 commented on a diff in pull request #13285: KAFKA-13874 Avoid synchronization in SocketServer metrics

chia7712 commented on code in PR #13285: URL: https://github.com/apache/kafka/pull/13285#discussion_r1123098018 ## core/src/main/scala/kafka/network/SocketServer.scala: ## @@ -141,8 +142,8 @@ class SocketServer(val config: KafkaConfig, } newGauge("MemoryPoolAvailable", ()

  1   2   >