[GitHub] [kafka] chia7712 commented on pull request #13421: KAFKA-14824:ReplicaAlterLogDirsThread may cause serious disk usage in…

2023-03-21 Thread via GitHub
chia7712 commented on PR #13421: URL: https://github.com/apache/kafka/pull/13421#issuecomment-1477362379 > potential exceptions here (although I haven't found it yet, it may be potential) Could you share more information with me? The unexpected disk growing is a critical bug so it wo

[GitHub] [kafka] hudeqi commented on pull request #13421: KAFKA-14824:ReplicaAlterLogDirsThread may cause serious disk usage in…

2023-03-21 Thread via GitHub
hudeqi commented on PR #13421: URL: https://github.com/apache/kafka/pull/13421#issuecomment-1477368341 > > potential exceptions here (although I haven't found it yet, it may be potential) > > Could you share more information with me? The unexpected disk growing is a critical bug so i

[GitHub] [kafka] mukkachaitanya opened a new pull request, #13426: KAFKA-14814: Skip target state updates when the configs store has sam…

2023-03-21 Thread via GitHub
mukkachaitanya opened a new pull request, #13426: URL: https://github.com/apache/kafka/pull/13426 …e state *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.*

[jira] [Commented] (KAFKA-14814) Skip restart of connectors when redundant resume request is made

2023-03-21 Thread Chaitanya Mukka (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703073#comment-17703073 ] Chaitanya Mukka commented on KAFKA-14814: - Hi [~yash.mayya]! If you haven't star

[GitHub] [kafka] chia7712 commented on pull request #13398: KAFKA-6891: send.buffer.bytes should be allowed to set -1 in KafkaConnect

2023-03-21 Thread via GitHub
chia7712 commented on PR #13398: URL: https://github.com/apache/kafka/pull/13398#issuecomment-1477443749 ``` [2023-03-20T05:31:14.475Z] BUILD SUCCESSFUL in 1h 44m 21s [2023-03-20T05:31:14.475Z] 224 actionable tasks: 120 executed, 104 up-to-date ``` the tests pass. will merge i

[GitHub] [kafka] chia7712 merged pull request #13398: KAFKA-6891: send.buffer.bytes should be allowed to set -1 in KafkaConnect

2023-03-21 Thread via GitHub
chia7712 merged PR #13398: URL: https://github.com/apache/kafka/pull/13398 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] chia7712 commented on pull request #13398: KAFKA-6891: send.buffer.bytes should be allowed to set -1 in KafkaConnect

2023-03-21 Thread via GitHub
chia7712 commented on PR #13398: URL: https://github.com/apache/kafka/pull/13398#issuecomment-1477456249 @garyparrot thanks for this contribution -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Resolved] (KAFKA-6891) send.buffer.bytes should be allowed to set -1 in KafkaConnect

2023-03-21 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-6891. --- Fix Version/s: 3.5.0 Resolution: Fixed > send.buffer.bytes should be allowed to set -1

[GitHub] [kafka] chia7712 commented on pull request #13404: KAFKA-14812: ProducerPerformance still counting successful sending in …

2023-03-21 Thread via GitHub
chia7712 commented on PR #13404: URL: https://github.com/apache/kafka/pull/13404#issuecomment-1477457628 ``` [2023-03-17T04:47:45.614Z] BUILD SUCCESSFUL in 1h 56m 35s [2023-03-17T04:47:45.614Z] 224 actionable tasks: 120 executed, 104 up-to-date ``` tests pass. will merge it later

[jira] [Assigned] (KAFKA-14814) Skip restart of connectors when redundant resume request is made

2023-03-21 Thread Yash Mayya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yash Mayya reassigned KAFKA-14814: -- Assignee: Chaitanya Mukka (was: Yash Mayya) > Skip restart of connectors when redundant resu

[GitHub] [kafka] chia7712 merged pull request #13404: KAFKA-14812: ProducerPerformance still counting successful sending in …

2023-03-21 Thread via GitHub
chia7712 merged PR #13404: URL: https://github.com/apache/kafka/pull/13404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Commented] (KAFKA-14814) Skip restart of connectors when redundant resume request is made

2023-03-21 Thread Yash Mayya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703107#comment-17703107 ] Yash Mayya commented on KAFKA-14814: Hi [~cmukka20], I've re-assigned the ticket to

[jira] [Assigned] (KAFKA-14812) ProducerPerformance still counting successful sending in console when sending failed

2023-03-21 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-14812: -- Assignee: hudeqi > ProducerPerformance still counting successful sending in console w

[GitHub] [kafka] mimaison merged pull request #13422: MINOR: Cleanups in clients common.config

2023-03-21 Thread via GitHub
mimaison merged PR #13422: URL: https://github.com/apache/kafka/pull/13422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] hudeqi closed pull request #13412: MINOR: Fix low bound in AdminClientConfig and DistributedConfig

2023-03-21 Thread via GitHub
hudeqi closed pull request #13412: MINOR: Fix low bound in AdminClientConfig and DistributedConfig URL: https://github.com/apache/kafka/pull/13412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (KAFKA-14597) [Streams] record-e2e-latency-max is not reporting correct metrics

2023-03-21 Thread Atul Jain (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atul Jain updated KAFKA-14597: -- Attachment: image-2023-03-21-15-06-47-836.png > [Streams] record-e2e-latency-max is not reporting corr

[jira] [Updated] (KAFKA-14597) [Streams] record-e2e-latency-max is not reporting correct metrics

2023-03-21 Thread Atul Jain (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atul Jain updated KAFKA-14597: -- Attachment: image-2023-03-21-15-07-24-352.png > [Streams] record-e2e-latency-max is not reporting corr

[jira] [Updated] (KAFKA-14597) [Streams] record-e2e-latency-max is not reporting correct metrics

2023-03-21 Thread Atul Jain (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atul Jain updated KAFKA-14597: -- Attachment: (was: image-2023-03-21-15-06-47-836.png) > [Streams] record-e2e-latency-max is not rep

[jira] [Commented] (KAFKA-14597) [Streams] record-e2e-latency-max is not reporting correct metrics

2023-03-21 Thread Atul Jain (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703118#comment-17703118 ] Atul Jain commented on KAFKA-14597: --- Hi [~cadonna] ,  {quote}Could you run your Stream

[GitHub] [kafka] hudeqi closed pull request #13377: MINOR: Fix typos in JaasContext

2023-03-21 Thread via GitHub
hudeqi closed pull request #13377: MINOR: Fix typos in JaasContext URL: https://github.com/apache/kafka/pull/13377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [kafka] tinaselenge commented on pull request #13373: Kafka-14420 Use incrementalAlterConfigs API for syncing topic configurations (KIP-894)

2023-03-21 Thread via GitHub
tinaselenge commented on PR #13373: URL: https://github.com/apache/kafka/pull/13373#issuecomment-1477564128 @mimaison @C0urante Thank you so much for reviewing the PR. I think I have addressed all the review comments, please let me know if I have missed anything or you have any further comm

[GitHub] [kafka] hudeqi commented on pull request #13427: MINOR:Incorrect/canonical use of constants in AdminClientConfig and StreamsConfigTest

2023-03-21 Thread via GitHub
hudeqi commented on PR #13427: URL: https://github.com/apache/kafka/pull/13427#issuecomment-1477565223 Hello, please help to review. @guozhangwang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] tinaselenge commented on a diff in pull request #13373: Kafka-14420 Use incrementalAlterConfigs API for syncing topic configurations (KIP-894)

2023-03-21 Thread via GitHub
tinaselenge commented on code in PR #13373: URL: https://github.com/apache/kafka/pull/13373#discussion_r1143144850 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java: ## @@ -514,6 +540,37 @@ private void updateTopicConfigs(Map topicConfig

[jira] [Commented] (KAFKA-14597) [Streams] record-e2e-latency-max is not reporting correct metrics

2023-03-21 Thread Tales Tonini (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703129#comment-17703129 ] Tales Tonini commented on KAFKA-14597: -- Hi [~atuljainiitk] , may I ask what Kafka S

[GitHub] [kafka] tinaselenge commented on a diff in pull request #13373: Kafka-14420 Use incrementalAlterConfigs API for syncing topic configurations (KIP-894)

2023-03-21 Thread via GitHub
tinaselenge commented on code in PR #13373: URL: https://github.com/apache/kafka/pull/13373#discussion_r1143154814 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java: ## @@ -514,6 +540,37 @@ private void updateTopicConfigs(Map topicConfig

[GitHub] [kafka] tinaselenge commented on a diff in pull request #13373: Kafka-14420 Use incrementalAlterConfigs API for syncing topic configurations (KIP-894)

2023-03-21 Thread via GitHub
tinaselenge commented on code in PR #13373: URL: https://github.com/apache/kafka/pull/13373#discussion_r1143154814 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java: ## @@ -514,6 +540,37 @@ private void updateTopicConfigs(Map topicConfig

[GitHub] [kafka] lucasbru commented on a diff in pull request #13382: KAFKA-14722: Make BooleanSerde public

2023-03-21 Thread via GitHub
lucasbru commented on code in PR #13382: URL: https://github.com/apache/kafka/pull/13382#discussion_r1143171856 ## clients/src/main/java/org/apache/kafka/common/serialization/Serdes.java: ## @@ -274,6 +282,13 @@ static public Serde UUID() { return new UUIDSerde();

[GitHub] [kafka] muralibasani commented on pull request #13417: KAFKA-14585: Moving StorageTool from core to tools module

2023-03-21 Thread via GitHub
muralibasani commented on PR #13417: URL: https://github.com/apache/kafka/pull/13417#issuecomment-1477601010 @mimaison PR is ready to review. - Had to modify build.gradle to avoid circular dependency. As formatCommand is being used in other classes in core module. - There is an unrela

[jira] [Commented] (KAFKA-14597) [Streams] record-e2e-latency-max is not reporting correct metrics

2023-03-21 Thread Atul Jain (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703143#comment-17703143 ] Atul Jain commented on KAFKA-14597: --- I currently have 2.6.0 version > [Streams] recor

[GitHub] [kafka] lucasbru commented on pull request #13097: [Draft] KAFKA-10532: close clean for EOS when it's RUNNING standby or RESTORING active

2023-03-21 Thread via GitHub
lucasbru commented on PR #13097: URL: https://github.com/apache/kafka/pull/13097#issuecomment-1477637108 > 2. streams exception: translated from kafka exception from restore consumer's other calls, as well as the restore callback) `InvalidOffsetException` is rethrown as `StreamsExcept

[GitHub] [kafka] lucasbru commented on a diff in pull request #13369: KAFKA-14172: Should clear cache when active recycled from standby

2023-03-21 Thread via GitHub
lucasbru commented on code in PR #13369: URL: https://github.com/apache/kafka/pull/13369#discussion_r1143208858 ## streams/src/test/java/org/apache/kafka/streams/integration/StandbyTaskEOSMultiRebalanceIntegrationTest.java: ## @@ -0,0 +1,304 @@ +/* + * Licensed to the Apache Sof

[GitHub] [kafka] chia7712 commented on pull request #13326: KAFKA-14774 the removed listeners should not be reconfigurable

2023-03-21 Thread via GitHub
chia7712 commented on PR #13326: URL: https://github.com/apache/kafka/pull/13326#issuecomment-1477661271 @showuon @mumrah Could you take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] C0urante commented on pull request #13425: KAFKA-14365: Extract common logic from Fetcher

2023-03-21 Thread via GitHub
C0urante commented on PR #13425: URL: https://github.com/apache/kafka/pull/13425#issuecomment-1477800891 ![fetch](https://user-images.githubusercontent.com/8636148/226614066-a13bd150-9bf5-4c1e-b578-8b6f1bf51c55.gif) -- This is an automated message from the Apache Git Service. To respo

[GitHub] [kafka] C0urante merged pull request #13367: KAFKA-14797: Emit offset sync when offset translation lag would exceed max.offset.lag

2023-03-21 Thread via GitHub
C0urante merged PR #13367: URL: https://github.com/apache/kafka/pull/13367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Updated] (KAFKA-14597) [Streams] record-e2e-latency-max is not reporting correct metrics

2023-03-21 Thread Atul Jain (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atul Jain updated KAFKA-14597: -- Attachment: image-2023-03-21-19-01-54-713.png > [Streams] record-e2e-latency-max is not reporting corr

[jira] [Updated] (KAFKA-14597) [Streams] record-e2e-latency-max is not reporting correct metrics

2023-03-21 Thread Atul Jain (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atul Jain updated KAFKA-14597: -- Attachment: image-2023-03-21-19-03-07-525.png > [Streams] record-e2e-latency-max is not reporting corr

[jira] [Updated] (KAFKA-14597) [Streams] record-e2e-latency-max is not reporting correct metrics

2023-03-21 Thread Atul Jain (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atul Jain updated KAFKA-14597: -- Attachment: image-2023-03-21-19-03-28-625.png > [Streams] record-e2e-latency-max is not reporting corr

[jira] [Commented] (KAFKA-14597) [Streams] record-e2e-latency-max is not reporting correct metrics

2023-03-21 Thread Atul Jain (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703204#comment-17703204 ] Atul Jain commented on KAFKA-14597: --- [~talestonini] I have another issue with process-

[GitHub] [kafka] C0urante commented on pull request #13367: KAFKA-14797: Emit offset sync when offset translation lag would exceed max.offset.lag

2023-03-21 Thread via GitHub
C0urante commented on PR #13367: URL: https://github.com/apache/kafka/pull/13367#issuecomment-1477875999 Merged and backported to 3.3 and 3.4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[jira] [Resolved] (KAFKA-14797) MM2 does not emit offset syncs when conservative translation logic exceeds positive max.offset.lag

2023-03-21 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-14797. --- Resolution: Fixed > MM2 does not emit offset syncs when conservative translation logic excee

[GitHub] [kafka] C0urante commented on pull request #13420: KAFKA-14740: Add source tag to MirrorSourceMetrics - KIP-911

2023-03-21 Thread via GitHub
C0urante commented on PR #13420: URL: https://github.com/apache/kafka/pull/13420#issuecomment-1477881989 (I did not notice that the KIP voting thread has not closed yet. This should probably only be merged after that happens 😄) -- This is an automated message from the Apache Git Service.

[GitHub] [kafka] C0urante commented on a diff in pull request #13373: Kafka-14420 Use incrementalAlterConfigs API for syncing topic configurations (KIP-894)

2023-03-21 Thread via GitHub
C0urante commented on code in PR #13373: URL: https://github.com/apache/kafka/pull/13373#discussion_r1143623680 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java: ## @@ -514,6 +540,37 @@ private void updateTopicConfigs(Map topicConfigs)

[GitHub] [kafka] mimaison commented on a diff in pull request #13424: KAFKA-14783 (KIP-875): New STOPPED state for connectors

2023-03-21 Thread via GitHub
mimaison commented on code in PR #13424: URL: https://github.com/apache/kafka/pull/13424#discussion_r1143576130 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/MonitorableSourceConnector.java: ## @@ -103,6 +103,9 @@ public List> taskConfigs(int maxTasks) {

[GitHub] [kafka] wcarlson5 commented on a diff in pull request #13382: KAFKA-14722: Make BooleanSerde public

2023-03-21 Thread via GitHub
wcarlson5 commented on code in PR #13382: URL: https://github.com/apache/kafka/pull/13382#discussion_r1143691894 ## streams/src/main/java/org/apache/kafka/streams/state/internals/NullableValueAndTimestampSerde.java: ## @@ -48,42 +45,4 @@ public NullableValueAndTimestampSerde(fin

[GitHub] [kafka] gharris1727 opened a new pull request, #13428: MINOR: Refactor Mirror integration tests to reduce duplication

2023-03-21 Thread via GitHub
gharris1727 opened a new pull request, #13428: URL: https://github.com/apache/kafka/pull/13428 The IdentityReplicationIntegrationTest nontrivially overrides two tests from the Base test. Most of the implementation is copied, but modifications to the copy change assertions that have to do wi

[GitHub] [kafka] mimaison commented on pull request #13419: KAFKA-8713: Allow using null for field in JsonConverter (KIP-581)

2023-03-21 Thread via GitHub
mimaison commented on PR #13419: URL: https://github.com/apache/kafka/pull/13419#issuecomment-1478251287 Thanks for the review @C0urante ! I've now closed the voting thread. Even though they are not available here, tests have [run](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/view

[GitHub] [kafka] mukkachaitanya commented on pull request #13426: KAFKA-14814: Skip target state updates when the configs store has sam…

2023-03-21 Thread via GitHub
mukkachaitanya commented on PR #13426: URL: https://github.com/apache/kafka/pull/13426#issuecomment-1478255352 Hi, @yashmayya / @C0urante let me know if you folks can take a stab at reviewing the PR. Thanks! -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [kafka] mimaison merged pull request #13419: KAFKA-8713: Allow using null for field in JsonConverter (KIP-581)

2023-03-21 Thread via GitHub
mimaison merged PR #13419: URL: https://github.com/apache/kafka/pull/13419 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-8713) [Connect] JsonConverter NULL Values are replaced by default values even in NULLABLE fields

2023-03-21 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-8713. --- Fix Version/s: 3.5.0 Assignee: Mickael Maison Resolution: Fixed > [Connect] J

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

2023-03-21 Thread via GitHub
philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1143738304 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -207,6 +226,232 @@ public NetworkClientDelegate.UnsentRequest t

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

2023-03-21 Thread via GitHub
philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1143739168 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -207,6 +226,232 @@ public NetworkClientDelegate.UnsentRequest t

[jira] [Commented] (KAFKA-14585) Move StorageTool to tools

2023-03-21 Thread Muralidhar Basani (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703309#comment-17703309 ] Muralidhar Basani commented on KAFKA-14585: --- [~mimaison] I think am done with

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13340: KAFKA-14491: [15/N] Add integration tests for versioned stores

2023-03-21 Thread via GitHub
vcrfxia commented on code in PR #13340: URL: https://github.com/apache/kafka/pull/13340#discussion_r1143766313 ## streams/src/test/java/org/apache/kafka/streams/integration/VersionedKeyValueStoreIntegrationTest.java: ## @@ -302,7 +319,54 @@ public void shouldAllowCustomIQv2ForC

[GitHub] [kafka] C0urante commented on a diff in pull request #13426: KAFKA-14814: Skip target state updates when the configs store has sam…

2023-03-21 Thread via GitHub
C0urante commented on code in PR #13426: URL: https://github.com/apache/kafka/pull/13426#discussion_r1143794237 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaConfigBackingStoreTest.java: ## @@ -889,6 +890,51 @@ public void testBackgroundUpdateTargetState

[GitHub] [kafka] C0urante commented on a diff in pull request #13373: Kafka-14420 Use incrementalAlterConfigs API for syncing topic configurations (KIP-894)

2023-03-21 Thread via GitHub
C0urante commented on code in PR #13373: URL: https://github.com/apache/kafka/pull/13373#discussion_r1143650777 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorSourceConnectorTest.java: ## @@ -261,6 +326,78 @@ public void testNewTopicConfigs() throws Except

[GitHub] [kafka] mimaison commented on pull request #13420: KAFKA-14740: Add source tag to MirrorSourceMetrics - KIP-911

2023-03-21 Thread via GitHub
mimaison commented on PR #13420: URL: https://github.com/apache/kafka/pull/13420#issuecomment-1478373825 I've now closed the voting thread. [Test failures](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/view/change-requests/job/PR-13420/1/testReport/) are not related, merging to trunk.

[GitHub] [kafka] mimaison merged pull request #13420: KAFKA-14740: Add source tag to MirrorSourceMetrics - KIP-911

2023-03-21 Thread via GitHub
mimaison merged PR #13420: URL: https://github.com/apache/kafka/pull/13420 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-14740) Missing source tag on MirrorSource metrics

2023-03-21 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-14740. Fix Version/s: 3.5.0 Resolution: Fixed > Missing source tag on MirrorSource metrics

[GitHub] [kafka] C0urante commented on pull request #13426: KAFKA-14814: Skip target state updates when the configs store has sam…

2023-03-21 Thread via GitHub
C0urante commented on PR #13426: URL: https://github.com/apache/kafka/pull/13426#issuecomment-1478385471 @yashmayya that's my bad, it does appear that you're correct and that the `Connector` won't be restarted, but a request for new task configs will take place. IMO this change still

[GitHub] [kafka] jsancio opened a new pull request, #13430: MINOR; Increase log level of some rare events

2023-03-21 Thread via GitHub
jsancio opened a new pull request, #13430: URL: https://github.com/apache/kafka/pull/13430 To help debug KRaft's behavior this change increases the log level of some rare messages to INFO level. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implemen

[GitHub] [kafka] hachikuji commented on pull request #13430: MINOR; Increase log level of some rare events

2023-03-21 Thread via GitHub
hachikuji commented on PR #13430: URL: https://github.com/apache/kafka/pull/13430#issuecomment-1478403979 Upgrading the error messages is probably fair, but do we really need the backoff messages at INFO level? Seems like they have potential to be noisy. -- This is an automated message fr

[GitHub] [kafka] jsancio commented on pull request #13430: MINOR; Increase log level of some rare events

2023-03-21 Thread via GitHub
jsancio commented on PR #13430: URL: https://github.com/apache/kafka/pull/13430#issuecomment-1478413634 > Upgrading the error messages is probably fair, but do we really need the backoff messages at INFO level? Seems like they have potential to be noisy. Okay. I'll revert the change t

[GitHub] [kafka] vcrfxia opened a new pull request, #13431: KAFKA-14491: [19/N] Combine versioned store RocksDB instances into one

2023-03-21 Thread via GitHub
vcrfxia opened a new pull request, #13431: URL: https://github.com/apache/kafka/pull/13431 The RocksDB-based versioned store implementation introduced in https://github.com/apache/kafka/pull/13188 currently uses two physical RocksDB instances per store instance: one for the "latest value st

[GitHub] [kafka] hachikuji commented on pull request #13430: MINOR; Increase log level of some rare events

2023-03-21 Thread via GitHub
hachikuji commented on PR #13430: URL: https://github.com/apache/kafka/pull/13430#issuecomment-1478422374 > Okay. I'll revert the change to the send request backoff but I think we should keep the candidate backoff as that is "rare" and would help us debug election delays. What do you think?

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13431: KAFKA-14491: [19/N] Combine versioned store RocksDB instances into one

2023-03-21 Thread via GitHub
vcrfxia commented on code in PR #13431: URL: https://github.com/apache/kafka/pull/13431#discussion_r1143859781 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java: ## @@ -821,4 +823,20 @@ public Options getOptions() { public Position getPosit

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

2023-03-21 Thread via GitHub
philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1143865476 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -113,15 +112,45 @@ private void maybeAutoCommit(final long curre

[jira] [Assigned] (KAFKA-14666) MM2 should translate consumer group offsets behind replication flow

2023-03-21 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris reassigned KAFKA-14666: --- Assignee: Greg Harris > MM2 should translate consumer group offsets behind replication flow

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

2023-03-21 Thread via GitHub
philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1143865476 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -113,15 +112,45 @@ private void maybeAutoCommit(final long curre

[GitHub] [kafka] C0urante commented on a diff in pull request #13375: KAFKA-14569: Migrate Connect's integration test EmbeddedKafkaCluster from ZK to KRaft mode

2023-03-21 Thread via GitHub
C0urante commented on code in PR #13375: URL: https://github.com/apache/kafka/pull/13375#discussion_r1143840978 ## connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedConnectCluster.java: ## @@ -152,11 +154,6 @@ public void stop() { connectClust

[jira] [Commented] (KAFKA-14666) MM2 should translate consumer group offsets behind replication flow

2023-03-21 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703339#comment-17703339 ] Greg Harris commented on KAFKA-14666: - I proposed a tactical fix for this in [https

[jira] [Comment Edited] (KAFKA-14666) MM2 should translate consumer group offsets behind replication flow

2023-03-21 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703339#comment-17703339 ] Greg Harris edited comment on KAFKA-14666 at 3/21/23 7:08 PM:

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

2023-03-21 Thread via GitHub
philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1143881070 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -207,6 +226,232 @@ public NetworkClientDelegate.UnsentRequest t

[jira] [Comment Edited] (KAFKA-14666) MM2 should translate consumer group offsets behind replication flow

2023-03-21 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703339#comment-17703339 ] Greg Harris edited comment on KAFKA-14666 at 3/21/23 7:13 PM:

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

2023-03-21 Thread via GitHub
philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1143888783 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -207,6 +226,232 @@ public NetworkClientDelegate.UnsentRequest t

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

2023-03-21 Thread via GitHub
philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1143891018 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -137,31 +166,21 @@ CompletableFuture sendAutoCommit(final Map t

[jira] [Created] (KAFKA-14830) Illegal state error in transactional producer

2023-03-21 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-14830: --- Summary: Illegal state error in transactional producer Key: KAFKA-14830 URL: https://issues.apache.org/jira/browse/KAFKA-14830 Project: Kafka Issue Typ

[jira] [Created] (KAFKA-14831) Illegal state errors should be fatal in transactional producer

2023-03-21 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-14831: --- Summary: Illegal state errors should be fatal in transactional producer Key: KAFKA-14831 URL: https://issues.apache.org/jira/browse/KAFKA-14831 Project: Kafka

[GitHub] [kafka] C0urante commented on a diff in pull request #13383: KAFKA-14059 Replace PowerMock with Mockito in WorkerSourceTaskTest

2023-03-21 Thread via GitHub
C0urante commented on code in PR #13383: URL: https://github.com/apache/kafka/pull/13383#discussion_r1143902556 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSourceTaskTest.java: ## @@ -315,33 +305,28 @@ public void testPause() throws Exception {

[GitHub] [kafka] dimitarndimitrov opened a new pull request, #13432: KAFKA-14821 Implement the listOffsets API with AdminApiDriver

2023-03-21 Thread via GitHub
dimitarndimitrov opened a new pull request, #13432: URL: https://github.com/apache/kafka/pull/13432 Aside from consistency with the implementation of newer APIs this also provides more resilient retries (e.g. in case of TimeoutExceptions) and simplifies the code to some extent. One n

[GitHub] [kafka] C0urante opened a new pull request, #13433: KAFKA-12694, KAFKA-3910: Add cyclic schema support, fix default struct values

2023-03-21 Thread via GitHub
C0urante opened a new pull request, #13433: URL: https://github.com/apache/kafka/pull/13433 - [Jira (cyclic schema support)](https://issues.apache.org/jira/browse/KAFKA-3910) - [Jira (default value for struct schemas)](https://issues.apache.org/jira/browse/KAFKA-12694) Implemented

[GitHub] [kafka] C0urante commented on pull request #13433: KAFKA-12694, KAFKA-3910: Add cyclic schema support, fix default struct values

2023-03-21 Thread via GitHub
C0urante commented on PR #13433: URL: https://github.com/apache/kafka/pull/13433#issuecomment-1478577830 cc @urbandan; I've tweaked this a bit (stopped tracking equivalent schemas while comparing default values since that was actually doing nothing and AFAICT is unnecessary, and copied the

[GitHub] [kafka] C0urante commented on pull request #10566: KAFKA-12694 Avoid schema mismatch DataException when validating default values

2023-03-21 Thread via GitHub
C0urante commented on PR #10566: URL: https://github.com/apache/kafka/pull/10566#issuecomment-1478578470 Opened https://github.com/apache/kafka/pull/13433 to address this (and cyclic schema support) -- This is an automated message from the Apache Git Service. To respond to the message, pl

[jira] [Assigned] (KAFKA-3910) Cyclic schema support in ConnectSchema and SchemaBuilder

2023-03-21 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-3910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton reassigned KAFKA-3910: Assignee: Chris Egerton (was: Shikhar Bhushan) > Cyclic schema support in ConnectSchema a

[jira] [Assigned] (KAFKA-12694) Specifying a struct-based defaultValue on a SchemaBuilder causes a DataException

2023-03-21 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton reassigned KAFKA-12694: - Assignee: Chris Egerton > Specifying a struct-based defaultValue on a SchemaBuilder cau

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

2023-03-21 Thread via GitHub
philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1143999124 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -137,31 +166,21 @@ CompletableFuture sendAutoCommit(final Map t

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

2023-03-21 Thread via GitHub
philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1144002857 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -207,6 +226,232 @@ public NetworkClientDelegate.UnsentRequest t

[GitHub] [kafka] SpacRocket commented on a diff in pull request #13382: KAFKA-14722: Make BooleanSerde public

2023-03-21 Thread via GitHub
SpacRocket commented on code in PR #13382: URL: https://github.com/apache/kafka/pull/13382#discussion_r1144052014 ## streams/src/main/java/org/apache/kafka/streams/state/internals/NullableValueAndTimestampSerde.java: ## @@ -48,42 +45,4 @@ public NullableValueAndTimestampSerde(fi

[jira] [Updated] (KAFKA-13295) Long restoration times for new tasks can lead to transaction timeouts

2023-03-21 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-13295: -- Fix Version/s: (was: 4.0.0) > Long restoration times for new tasks can lead to transaction

[jira] [Commented] (KAFKA-13295) Long restoration times for new tasks can lead to transaction timeouts

2023-03-21 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703404#comment-17703404 ] Guozhang Wang commented on KAFKA-13295: --- [~sagarrao] I had a chat with others driv

[GitHub] [kafka] jsancio merged pull request #13430: MINOR; Increase log level of some rare events

2023-03-21 Thread via GitHub
jsancio merged PR #13430: URL: https://github.com/apache/kafka/pull/13430 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] mjsax merged pull request #13292: KAFKA-14491: [14/N] Set changelog topic configs for versioned stores

2023-03-21 Thread via GitHub
mjsax merged PR #13292: URL: https://github.com/apache/kafka/pull/13292 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] mjsax merged pull request #13409: KAFKA-14491: [18/N] Update versioned store to check latest value on timestamped get

2023-03-21 Thread via GitHub
mjsax merged PR #13409: URL: https://github.com/apache/kafka/pull/13409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Comment Edited] (KAFKA-14666) MM2 should translate consumer group offsets behind replication flow

2023-03-21 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703339#comment-17703339 ] Greg Harris edited comment on KAFKA-14666 at 3/22/23 12:12 AM: ---

[GitHub] [kafka] kirktrue commented on pull request #13425: KAFKA-14365: Extract common logic from Fetcher

2023-03-21 Thread via GitHub
kirktrue commented on PR #13425: URL: https://github.com/apache/kafka/pull/13425#issuecomment-1478805465 @guozhangwang @hachikuji @rajinisivaram @philipnee This is ready for a review from whomever has the time. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (KAFKA-14824) ReplicaAlterLogDirsThread may cause serious disk usage in case of unknown exception

2023-03-21 Thread hudeqi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703449#comment-17703449 ] hudeqi commented on KAFKA-14824: For "potential exceptions may be throw", I did such an

[jira] [Updated] (KAFKA-14824) ReplicaAlterLogDirsThread may cause serious disk usage in case of unknown exception

2023-03-21 Thread hudeqi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hudeqi updated KAFKA-14824: --- Attachment: 1.png 2.png 3.png 4.png > ReplicaAlterLogDirsThr

[jira] [Comment Edited] (KAFKA-14824) ReplicaAlterLogDirsThread may cause serious disk usage in case of unknown exception

2023-03-21 Thread hudeqi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703449#comment-17703449 ] hudeqi edited comment on KAFKA-14824 at 3/22/23 2:35 AM: - For "p

[GitHub] [kafka] hudeqi commented on pull request #13421: KAFKA-14824:ReplicaAlterLogDirsThread may cause serious disk usage in…

2023-03-21 Thread via GitHub
hudeqi commented on PR #13421: URL: https://github.com/apache/kafka/pull/13421#issuecomment-1478842301 Hello, for "potential exceptions", I did an experiment to simulate a disk failure, which eventually lead to the unexpected disk growing. For details, please refer to the corresponding comm

[jira] [Updated] (KAFKA-14824) ReplicaAlterLogDirsThread may cause serious disk growing in case of unknown exception

2023-03-21 Thread hudeqi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hudeqi updated KAFKA-14824: --- Summary: ReplicaAlterLogDirsThread may cause serious disk growing in case of unknown exception (was: Replic

[jira] [Assigned] (KAFKA-14824) ReplicaAlterLogDirsThread may cause serious disk growing in case of potential exception

2023-03-21 Thread hudeqi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hudeqi reassigned KAFKA-14824: -- Assignee: hudeqi > ReplicaAlterLogDirsThread may cause serious disk growing in case of potential > e

  1   2   >