showuon commented on PR #13944:
URL: https://github.com/apache/kafka/pull/13944#issuecomment-1615552181
@abhijeetk88 , please let me know when PR is ready for review. Thanks for
the work on weekend! :)
--
This is an automated message from the Apache Git Service.
To respond to the message,
abhijeetk88 opened a new pull request, #13944:
URL: https://github.com/apache/kafka/pull/13944
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of tes
abhijeetk88 commented on PR #13943:
URL: https://github.com/apache/kafka/pull/13943#issuecomment-1615504449
Will raise a new one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
abhijeetk88 closed pull request #13943: [DRAFT] KAFKA-14953 - Added metrics
related to tiered storage.
URL: https://github.com/apache/kafka/pull/13943
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
abhijeetk88 opened a new pull request, #13943:
URL: https://github.com/apache/kafka/pull/13943
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
github-actions[bot] commented on PR #12844:
URL: https://github.com/apache/kafka/pull/12844#issuecomment-1615427934
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
github-actions[bot] commented on PR #12849:
URL: https://github.com/apache/kafka/pull/12849#issuecomment-1615427881
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
wcarlson5 opened a new pull request, #13942:
URL: https://github.com/apache/kafka/pull/13942
Check the history retention of the ktable of the grace period join.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test cover
[
https://issues.apache.org/jira/browse/KAFKA-15138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe DiPol updated KAFKA-15138:
--
Description:
If you look at
[https://repo1.maven.org/maven2/org/apache/kafka/kafka-clients/3.4.0/kafk
Joe DiPol created KAFKA-15138:
-
Summary: Java kafka-clients compression dependencies should be
optional
Key: KAFKA-15138
URL: https://issues.apache.org/jira/browse/KAFKA-15138
Project: Kafka
Iss
[
https://issues.apache.org/jira/browse/KAFKA-14335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-14335:
--
Labels: needs-kip (was: )
> Admin.listConsumerGroups should allow filtering, pagination
> ---
riedelmax opened a new pull request, #13941:
URL: https://github.com/apache/kafka/pull/13941
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade not
jolshan commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1248282166
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java:
##
@@ -568,5 +568,20 @@ public void testMetadataRefreshDeadline()
dajac commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1248223476
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java:
##
@@ -568,5 +568,20 @@ public void testMetadataRefreshDeadline() {
divijvaidya commented on PR #13935:
URL: https://github.com/apache/kafka/pull/13935#issuecomment-1615046002
Unrelated test failures
```
[Build / JDK 8 and Scala 2.12 /
org.apache.kafka.connect.mirror.integration.MirrorConnectorsWithCustomForwardingAdminIntegrationTest.testReplicationWi
divijvaidya commented on code in PR #13284:
URL: https://github.com/apache/kafka/pull/13284#discussion_r1248166033
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/DedicatedMirrorIntegrationTest.java:
##
@@ -40,16 +47,16 @@
import java.util.concurrent
divijvaidya commented on code in PR #13284:
URL: https://github.com/apache/kafka/pull/13284#discussion_r1248164637
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/DedicatedMirrorIntegrationTest.java:
##
@@ -273,6 +288,30 @@ private void writeToTopic(E
divijvaidya commented on code in PR #13284:
URL: https://github.com/apache/kafka/pull/13284#discussion_r1248164007
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/DedicatedMirrorIntegrationTest.java:
##
@@ -288,4 +327,28 @@ private void awaitTopicCont
divijvaidya commented on code in PR #13284:
URL: https://github.com/apache/kafka/pull/13284#discussion_r1248163268
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/DedicatedMirrorIntegrationTest.java:
##
@@ -288,4 +327,28 @@ private void awaitTopicCont
divijvaidya commented on PR #13284:
URL: https://github.com/apache/kafka/pull/13284#issuecomment-1615032737
I had to rebase with trunk to resolve merge conflicts. Changes in latest
revision.
1\ Moved `awaitMirrorMakerStart` into the test cases.
2\ Only check for one mirror maker n
[
https://issues.apache.org/jira/browse/KAFKA-15091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739196#comment-17739196
]
Chris Egerton commented on KAFKA-15091:
---
I think that was also discussed with KAFK
jolshan commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1248148380
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java:
##
@@ -568,5 +568,20 @@ public void testMetadataRefreshDeadline()
dajac commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1248133399
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java:
##
@@ -568,5 +568,20 @@ public void testMetadataRefreshDeadline() {
jolshan commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1248102033
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java:
##
@@ -568,5 +568,20 @@ public void testMetadataRefreshDeadline()
jolshan commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1248100591
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java:
##
@@ -825,4 +828,60 @@ public void testClose() throws Except
dajac commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1248097012
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -1932,6 +1961,435 @@ public void
testPartitionAssignorExceptio
dajac commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1248096864
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java:
##
@@ -568,5 +568,20 @@ public void testMetadataRefreshDeadline() {
dajac commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1248095763
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java:
##
@@ -564,9 +564,9 @@ public void testMetadataRefreshDeadline() {
dajac commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1248095382
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java:
##
@@ -564,9 +564,9 @@ public void testMetadataRefreshDeadline() {
jolshan commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1248094484
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java:
##
@@ -564,9 +564,9 @@ public void testMetadataRefreshDeadline()
jolshan commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1248092632
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java:
##
@@ -568,5 +568,20 @@ public void testMetadataRefreshDeadline()
lucasbru commented on PR #13876:
URL: https://github.com/apache/kafka/pull/13876#issuecomment-1614928567
@jolshan This makes sense. It seems to me that I need to go through the
whole KIP and have an end-to-end solution before addressing these kinds of
consistency problems. At least for the
dajac commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1248086301
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java:
##
@@ -825,4 +828,60 @@ public void testClose() throws Exceptio
jolshan commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1248092025
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -1932,6 +1961,435 @@ public void
testPartitionAssignorExcept
dajac commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1248091492
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java:
##
@@ -568,5 +568,20 @@ public void testMetadataRefreshDeadline() {
dajac commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1248088555
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java:
##
@@ -825,4 +828,60 @@ public void testClose() throws Exceptio
dajac commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1248087985
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -1932,6 +1961,435 @@ public void
testPartitionAssignorExceptio
dajac commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1248087394
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -1932,6 +1961,435 @@ public void
testPartitionAssignorExceptio
dajac commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1248086803
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java:
##
@@ -568,5 +568,20 @@ public void testMetadataRefreshDeadline() {
dajac commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1248086301
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java:
##
@@ -825,4 +828,60 @@ public void testClose() throws Exceptio
jolshan commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1248086692
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -1932,6 +1961,435 @@ public void
testPartitionAssignorExcept
C0urante merged PR #13939:
URL: https://github.com/apache/kafka/pull/13939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
jolshan commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1248071005
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -1932,6 +1961,435 @@ public void
testPartitionAssignorExcept
divijvaidya commented on code in PR #13837:
URL: https://github.com/apache/kafka/pull/13837#discussion_r1247912475
##
storage/src/test/java/org/apache/kafka/server/log/remote/storage/RemoteTopicPartitionDirectory.java:
##
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software
vamossagar12 commented on PR #13158:
URL: https://github.com/apache/kafka/pull/13158#issuecomment-1614890801
Thanks @fvaleri . Hmm I see 101 test failures. 92 existing and 9 new.
Atleast the new ones look unrelated..
--
This is an automated message from the Apache Git Service.
To respond
jolshan commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1248060783
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java:
##
@@ -568,5 +568,20 @@ public void testMetadataRefreshDeadline()
vamossagar12 commented on code in PR #13939:
URL: https://github.com/apache/kafka/pull/13939#discussion_r1248058129
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java:
##
@@ -1657,13 +1657,13 @@ private boolean handleRebalanceCom
jolshan commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1248058020
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java:
##
@@ -825,4 +828,60 @@ public void testClose() throws Except
fvaleri commented on PR #13158:
URL: https://github.com/apache/kafka/pull/13158#issuecomment-1614872160
@vamossagar12 LGTM. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
[
https://issues.apache.org/jira/browse/KAFKA-15102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739146#comment-17739146
]
Chris Egerton commented on KAFKA-15102:
---
[~omnia_h_ibrahim] Good call 👍 we should
C0urante commented on code in PR #13913:
URL: https://github.com/apache/kafka/pull/13913#discussion_r1248004857
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java:
##
@@ -582,12 +583,20 @@ void incrementalAlterConfigs(Map
topicConfigs) {
David Arthur created KAFKA-15137:
Summary: Don't log the entire request in
KRaftControllerChannelManager
Key: KAFKA-15137
URL: https://issues.apache.org/jira/browse/KAFKA-15137
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-13988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-13988:
--
Component/s: (was: KafkaConnect)
> Mirrormaker 2 auto.offset.reset=latest not working
> --
[
https://issues.apache.org/jira/browse/KAFKA-13988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-13988:
--
Fix Version/s: (was: 3.2.0)
> Mirrormaker 2 auto.offset.reset=latest not working
> ---
C0urante commented on code in PR #13905:
URL: https://github.com/apache/kafka/pull/13905#discussion_r1247963748
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceTask.java:
##
@@ -53,6 +53,7 @@ public class MirrorSourceTask extends SourceTask {
pri
C0urante commented on code in PR #13905:
URL: https://github.com/apache/kafka/pull/13905#discussion_r1247968250
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorSourceTaskTest.java:
##
@@ -31,25 +31,36 @@
import org.apache.kafka.connect.mirror.MirrorSourceT
hudeqi commented on PR #13926:
URL: https://github.com/apache/kafka/pull/13926#issuecomment-1614799513
And this please @divijvaidya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
hudeqi commented on PR #13929:
URL: https://github.com/apache/kafka/pull/13929#issuecomment-1614790587
And please help to review this @divijvaidya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
hudeqi commented on PR #13926:
URL: https://github.com/apache/kafka/pull/13926#issuecomment-1614782255
Combined with the explanation of
https://github.com/apache/kafka/pull/3506#discussion_r128589927 and the results
of my actual test, I think this is the case: All unit tests in
`GroupMetad
dajac commented on PR #13926:
URL: https://github.com/apache/kafka/pull/13926#issuecomment-1614765471
Yeah, that seems to be a general issue with Yammer based metrics. It is not
about individual unit tests. It is about integration tests that create multiple
KafkaServers. In this case, the m
clolov commented on PR #13926:
URL: https://github.com/apache/kafka/pull/13926#issuecomment-1614755545
Hudeqi mentioned this comment as well, but I still do not understand how
this could happen - is it that we keep the same metric registry between
individual unit tests? If this is the case,
hudeqi commented on code in PR #13924:
URL: https://github.com/apache/kafka/pull/13924#discussion_r1247947969
##
core/src/test/scala/unit/kafka/log/LogCleanerTest.scala:
##
@@ -83,11 +84,19 @@ class LogCleanerTest {
val numMetricsRegistered = LogCleaner.MetricNames.size
hudeqi commented on code in PR #13924:
URL: https://github.com/apache/kafka/pull/13924#discussion_r1247947464
##
core/src/main/scala/kafka/log/LogCleanerManager.scala:
##
@@ -88,17 +88,21 @@ private[log] class LogCleanerManager(val logDirs: Seq[File],
/* for coordinating the
divijvaidya commented on code in PR #13924:
URL: https://github.com/apache/kafka/pull/13924#discussion_r1247921648
##
core/src/test/scala/unit/kafka/log/LogCleanerTest.scala:
##
@@ -83,11 +84,19 @@ class LogCleanerTest {
val numMetricsRegistered = LogCleaner.MetricNames.s
C0urante commented on code in PR #13939:
URL: https://github.com/apache/kafka/pull/13939#discussion_r1247916426
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java:
##
@@ -1657,13 +1657,13 @@ private boolean handleRebalanceComplet
hudeqi commented on code in PR #13924:
URL: https://github.com/apache/kafka/pull/13924#discussion_r1247914999
##
core/src/test/scala/unit/kafka/log/LogCleanerTest.scala:
##
@@ -83,11 +84,19 @@ class LogCleanerTest {
val numMetricsRegistered = LogCleaner.MetricNames.size
divijvaidya commented on code in PR #13924:
URL: https://github.com/apache/kafka/pull/13924#discussion_r1247907443
##
core/src/test/scala/unit/kafka/log/LogCleanerTest.scala:
##
@@ -83,11 +84,19 @@ class LogCleanerTest {
val numMetricsRegistered = LogCleaner.MetricNames.s
dajac commented on PR #13926:
URL: https://github.com/apache/kafka/pull/13926#issuecomment-1614681662
Found this: https://github.com/apache/kafka/pull/3506#discussion_r128589927.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
[
https://issues.apache.org/jira/browse/KAFKA-15127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739095#comment-17739095
]
Chris Egerton commented on KAFKA-15127:
---
In that case, perhaps we can leave it una
clolov commented on PR #13926:
URL: https://github.com/apache/kafka/pull/13926#issuecomment-1614673915
But if this is the case won't we run into the same problem for at least one
other subset of metrics? Also if this is the case, that would mean that if we
remove the method the tests runnin
clolov commented on code in PR #13924:
URL: https://github.com/apache/kafka/pull/13924#discussion_r1247880517
##
core/src/test/scala/unit/kafka/log/LogCleanerTest.scala:
##
@@ -83,11 +84,19 @@ class LogCleanerTest {
val numMetricsRegistered = LogCleaner.MetricNames.size
dajac commented on PR #13926:
URL: https://github.com/apache/kafka/pull/13926#issuecomment-1614670671
I was wondering if it is because we run multiple brokers in the same JVM in
tests but I am not sure.
--
This is an automated message from the Apache Git Service.
To respond to the message
jeqo commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1247799637
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -152,19 +156,23 @@ public class RemoteLogManager implements Closeable {
* @param time Time i
clolov commented on PR #13926:
URL: https://github.com/apache/kafka/pull/13926#issuecomment-1614665719
Okay, that makes sense @dajac, do you happen to know (or are able to deduce)
the answer to the other question about why we needed the recreateGauge method
in the first place and is it safe
divijvaidya commented on code in PR #13924:
URL: https://github.com/apache/kafka/pull/13924#discussion_r1247863305
##
core/src/test/scala/unit/kafka/log/LogCleanerTest.scala:
##
@@ -83,11 +84,19 @@ class LogCleanerTest {
val numMetricsRegistered = LogCleaner.MetricNames.s
dajac commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1247814090
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -266,9 +295,21 @@ public CompletableFuture joinGroup(
dajac commented on PR #13926:
URL: https://github.com/apache/kafka/pull/13926#issuecomment-1614635663
@clolov Constants (in the companion object) in Scala start with a capital
letter in our code base.
--
This is an automated message from the Apache Git Service.
To respond to the message,
clolov commented on PR #13926:
URL: https://github.com/apache/kafka/pull/13926#issuecomment-1614621247
In theory this change makes sense to me. As with the [1/N] one I would
prefer if variable names start with a lowercase unless there is a good reason
for them not to. I have reached out to
kriscfoster commented on PR #13865:
URL: https://github.com/apache/kafka/pull/13865#issuecomment-1614606533
Great, thank you @jlprat!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
jlprat commented on PR #13865:
URL: https://github.com/apache/kafka/pull/13865#issuecomment-1614604961
Hi @kriscfoster
Currently `3.5.1` and `3.6.0` are the only releases in the making (`3.6.0`
is expected to be released during September) that I'm aware of.
I think the version that
divijvaidya merged PR #13923:
URL: https://github.com/apache/kafka/pull/13923
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apa
kriscfoster commented on PR #13865:
URL: https://github.com/apache/kafka/pull/13865#issuecomment-1614589914
@jlprat do you know when the next release will be on 3.4 branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
showuon commented on code in PR #13837:
URL: https://github.com/apache/kafka/pull/13837#discussion_r1247809160
##
storage/src/test/java/org/apache/kafka/server/log/remote/storage/LocalTieredStorageEvent.java:
##
@@ -0,0 +1,187 @@
+/*
+ * Licensed to the Apache Software Foundatio
dajac commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1247805182
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -172,19 +186,21 @@ public List build(TopicsImage topicsImage) {
dajac commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1247803617
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java:
##
@@ -825,4 +828,60 @@ public void testClose() throws Exceptio
hudeqi commented on code in PR #13924:
URL: https://github.com/apache/kafka/pull/13924#discussion_r1247795935
##
core/src/main/scala/kafka/log/LogCleanerManager.scala:
##
@@ -555,6 +568,17 @@ private case class OffsetsToClean(firstDirtyOffset: Long,
}
private[log] object Log
hudeqi commented on code in PR #13924:
URL: https://github.com/apache/kafka/pull/13924#discussion_r1247795935
##
core/src/main/scala/kafka/log/LogCleanerManager.scala:
##
@@ -555,6 +568,17 @@ private case class OffsetsToClean(firstDirtyOffset: Long,
}
private[log] object Log
clolov commented on code in PR #13924:
URL: https://github.com/apache/kafka/pull/13924#discussion_r1247788765
##
core/src/main/scala/kafka/log/LogCleanerManager.scala:
##
@@ -555,6 +568,17 @@ private case class OffsetsToClean(firstDirtyOffset: Long,
}
private[log] object Log
jeqo commented on code in PR #13938:
URL: https://github.com/apache/kafka/pull/13938#discussion_r1247786162
##
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##
@@ -220,8 +220,8 @@ void testRemoteLogMetadataManagerWithEndpointConfig() {
ArgumentCaptor>
vamossagar12 commented on PR #13158:
URL: https://github.com/apache/kafka/pull/13158#issuecomment-1614540440
@ruslankrivoshein , I have fixed the checkstyle issues. Also, I believe that
the other comment
[here](https://github.com/apache/kafka/pull/13158#issuecomment-1422555044) has
been ad
vamossagar12 opened a new pull request, #13939:
URL: https://github.com/apache/kafka/pull/13939
Minor improvements to comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
vamossagar12 closed pull request #12874: Reproducing callbacks added even when
workthread is terminated
URL: https://github.com/apache/kafka/pull/12874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
vamossagar12 commented on PR #12874:
URL: https://github.com/apache/kafka/pull/12874#issuecomment-1614498011
Closing as the main purpose of this was to do a POC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
showuon commented on code in PR #13938:
URL: https://github.com/apache/kafka/pull/13938#discussion_r1247736125
##
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##
@@ -220,8 +220,8 @@ void testRemoteLogMetadataManagerWithEndpointConfig() {
ArgumentCapt
satishd commented on code in PR #13923:
URL: https://github.com/apache/kafka/pull/13923#discussion_r1247690846
##
storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteStorageManager.java:
##
@@ -75,6 +75,9 @@ enum IndexType {
*
* Invoker of thi
[
https://issues.apache.org/jira/browse/KAFKA-15136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiaobing Fang updated KAFKA-15136:
--
Priority: Major (was: Minor)
> The inspection of field allowAutoTopicCreation field in Metada
[
https://issues.apache.org/jira/browse/KAFKA-15136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiaobing Fang updated KAFKA-15136:
--
Description:
{code:java}
if (!data.allowAutoTopicCreation() && version < 4)
throw new Un
Xiaobing Fang created KAFKA-15136:
-
Summary: The inspection of field allowAutoTopicCreation field in
MetadataRequest is unreasonable
Key: KAFKA-15136
URL: https://issues.apache.org/jira/browse/KAFKA-15136
jeqo commented on PR #13828:
URL: https://github.com/apache/kafka/pull/13828#issuecomment-1614448203
Sure!, created this: https://github.com/apache/kafka/pull/13938
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
jeqo opened a new pull request, #13938:
URL: https://github.com/apache/kafka/pull/13938
Pass endpoint properties from RLM to TBRLMM and validate those are not
ignored.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify te
1 - 100 of 118 matches
Mail list logo
