[GitHub] [kafka] kamalcph commented on a diff in pull request #13947: KAFKA-15130: Delete remote segments when delete a topic

2023-08-10 Thread via GitHub
kamalcph commented on code in PR #13947: URL: https://github.com/apache/kafka/pull/13947#discussion_r1290329055 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -558,17 +574,38 @@ class ReplicaManager(val config: KafkaConfig, } partitionsToDelete

[jira] [Commented] (KAFKA-15334) DescribeQuorum should not be seen as cluster action

2023-08-10 Thread Deng Ziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17753070#comment-17753070 ] Deng Ziming commented on KAFKA-15334: - We are treating DescribeQuorum as cluster act

[jira] [Created] (KAFKA-15334) DescribeQuorum should not be seen as cluster action

2023-08-10 Thread Deng Ziming (Jira)
Deng Ziming created KAFKA-15334: --- Summary: DescribeQuorum should not be seen as cluster action Key: KAFKA-15334 URL: https://issues.apache.org/jira/browse/KAFKA-15334 Project: Kafka Issue Type

[GitHub] [kafka] mehbey commented on a diff in pull request #14135: KAFKA-14991: Implementation of KIP-937 which improves message timesta…

2023-08-10 Thread via GitHub
mehbey commented on code in PR #14135: URL: https://github.com/apache/kafka/pull/14135#discussion_r1290912365 ## core/src/test/scala/integration/kafka/api/PlaintextProducerSendTest.scala: ## @@ -120,17 +121,17 @@ class PlaintextProducerSendTest extends BaseProducerSendTest {

[GitHub] [kafka] mehbey commented on a diff in pull request #14135: KAFKA-14991: Implementation of KIP-937 which improves message timesta…

2023-08-10 Thread via GitHub
mehbey commented on code in PR #14135: URL: https://github.com/apache/kafka/pull/14135#discussion_r1290912365 ## core/src/test/scala/integration/kafka/api/PlaintextProducerSendTest.scala: ## @@ -120,17 +121,17 @@ class PlaintextProducerSendTest extends BaseProducerSendTest {

[GitHub] [kafka] mehbey commented on pull request #14135: KAFKA-14991: Implementation of KIP-937 which improves message timesta…

2023-08-10 Thread via GitHub
mehbey commented on PR #14135: URL: https://github.com/apache/kafka/pull/14135#issuecomment-1674232688 > Whenever we are making customer facing changes (adding new config in this scenario), we usually mention it in upgrade notes at > > https://github.com/apache/kafka/blob/ddeb89f4a9f

[jira] [Comment Edited] (KAFKA-10875) offsetsForTimes returns null for some partitions when it shouldn't?

2023-08-10 Thread Kong Yin Lai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17753049#comment-17753049 ] Kong Yin Lai edited comment on KAFKA-10875 at 8/11/23 5:14 AM: ---

[jira] [Commented] (KAFKA-10875) offsetsForTimes returns null for some partitions when it shouldn't?

2023-08-10 Thread Kong Yin Lai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17753049#comment-17753049 ] Kong Yin Lai commented on KAFKA-10875: -- We are also seeing something that looks a l

[GitHub] [kafka] bachmanity1 commented on pull request #14190: KAFKA-7438: Replace Easymock & Powermock with Mockito in RocksDBMetricsRecorderGa…

2023-08-10 Thread via GitHub
bachmanity1 commented on PR #14190: URL: https://github.com/apache/kafka/pull/14190#issuecomment-1674220529 @cadonna @divijvaidya can you please review this? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] bachmanity1 opened a new pull request, #14190: KAFKA-7438: Replace Easymock & Powermock with Mockito in RocksDBMetricsRecorderGa…

2023-08-10 Thread via GitHub
bachmanity1 opened a new pull request, #14190: URL: https://github.com/apache/kafka/pull/14190 Replace Easymock & Powermock with Mockito in RocksDBMetricsRecorderGaugesTest. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Veri

[GitHub] [kafka] bachmanity1 commented on pull request #14189: KAFKA-7438: Replace Easymock & Powermock with Mockito in TableSourceNodeTest

2023-08-10 Thread via GitHub
bachmanity1 commented on PR #14189: URL: https://github.com/apache/kafka/pull/14189#issuecomment-1674210277 @cadonna @mjsax @C0urante can you please review this PR? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] bachmanity1 opened a new pull request, #14189: KAFKA-7438: Replace Easymock & Powermock with Mockito in TableSourceNodeTest

2023-08-10 Thread via GitHub
bachmanity1 opened a new pull request, #14189: URL: https://github.com/apache/kafka/pull/14189 Replace Easymock & Powermock with Mockito in TableSourceNodeTest ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverag

[GitHub] [kafka] C0urante commented on pull request #14177: MINOR: Fix SynchronizationTest Classloaders sometimes not being parallel capable

2023-08-10 Thread via GitHub
C0urante commented on PR #14177: URL: https://github.com/apache/kafka/pull/14177#issuecomment-1674205775 Changes seems fine, but CI results are a little worrying. Nothing directly tied to this PR on the surface, but I've kicked off another build just to be safe. -- This is an automated m

[GitHub] [kafka] C0urante commented on pull request #14186: KAFKA-14682: Report Mockito unused stubbings during Jenkins build

2023-08-10 Thread via GitHub
C0urante commented on PR #14186: URL: https://github.com/apache/kafka/pull/14186#issuecomment-1674202980 @divijvaidya given that this touches on the strict stubbing feature that you've helped introduce to our tests, would you be interested in reviewing? @mumrah @ijuma based on discuss

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-10 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1290880628 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignor.java: ## @@ -0,0 +1,396 @@ +/* + * Licensed to the Apache Soft

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-10 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1290880471 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignor.java: ## @@ -0,0 +1,396 @@ +/* + * Licensed to the Apache Soft

[GitHub] [kafka] C0urante commented on pull request #14186: KAFKA-14682: Report Mockito unused stubbings during Jenkins build

2023-08-10 Thread via GitHub
C0urante commented on PR #14186: URL: https://github.com/apache/kafka/pull/14186#issuecomment-1674193833 As we can see with the [CI results for the first build](https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14186/1/tests), unused stubbings were successfu

[jira] [Updated] (KAFKA-15083) Passing "remote.log.metadata.*" configs into RLMM

2023-08-10 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-15083: -- Description: Based on the [KIP-405|https://cwiki.apache.org/confluence/display/KAFKA/KIP-405%3A+Kafka

[GitHub] [kafka] showuon merged pull request #14151: KAFKA-15083: add config with "remote.log.metadata" prefix

2023-08-10 Thread via GitHub
showuon merged PR #14151: URL: https://github.com/apache/kafka/pull/14151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Updated] (KAFKA-15083) Passing "remote.log.metadata.*" configs into RLMM

2023-08-10 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-15083: -- Description: Based on the [KIP-405|https://cwiki.apache.org/confluence/display/KAFKA/KIP-405%3A+Kafka

[GitHub] [kafka] showuon commented on pull request #14151: KAFKA-15083: add config with "remote.log.metadata" prefix

2023-08-10 Thread via GitHub
showuon commented on PR #14151: URL: https://github.com/apache/kafka/pull/14151#issuecomment-1674147451 Failed tests are unrelated: ``` Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationBaseTest.testOneWayReplicationWithAutoOffse

[GitHub] [kafka] showuon merged pull request #14121: MINOR: Add comment to onPartitionsLost override

2023-08-10 Thread via GitHub
showuon merged PR #14121: URL: https://github.com/apache/kafka/pull/14121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] showuon commented on pull request #14121: MINOR: Add comment to onPartitionsLost override

2023-08-10 Thread via GitHub
showuon commented on PR #14121: URL: https://github.com/apache/kafka/pull/14121#issuecomment-1674146055 Failed tests are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[jira] [Updated] (KAFKA-15289) Support KRaft mode in RequestQuotaTest

2023-08-10 Thread Deng Ziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deng Ziming updated KAFKA-15289: Description: we are calling `zkBrokerApis` in , we should ensure kraft broker apis are also suppor

[jira] [Updated] (KAFKA-15289) Support KRaft mode in RequestQuotaTest

2023-08-10 Thread Deng Ziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deng Ziming updated KAFKA-15289: Description: we are calling `zkBrokerApis` in RequestQuotaTest, we should ensure kraft broker apis

[jira] [Updated] (KAFKA-15289) Support KRaft mode in RequestQuotaTest

2023-08-10 Thread Deng Ziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deng Ziming updated KAFKA-15289: Summary: Support KRaft mode in RequestQuotaTest (was: Use zkBrokerApis.clientApis instead of ApiK

[jira] [Resolved] (KAFKA-15287) Change NodeApiVersions.create() to contains both apis of zk and kraft broker

2023-08-10 Thread Deng Ziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deng Ziming resolved KAFKA-15287. - Resolution: Fixed > Change NodeApiVersions.create() to contains both apis of zk and kraft broker

[GitHub] [kafka] dengziming merged pull request #14185: KAFKA-15287: Change NodeApiVersions.create() to support kraft

2023-08-10 Thread via GitHub
dengziming merged PR #14185: URL: https://github.com/apache/kafka/pull/14185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apac

[jira] [Updated] (KAFKA-14132) Remaining PowerMock to Mockito tests

2023-08-10 Thread Nelson Bighetti (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nelson Bighetti updated KAFKA-14132: Description: {color:#de350b}Some of the tests below use EasyMock as well. For those migrat

[jira] [Updated] (KAFKA-14132) Remaining PowerMock to Mockito tests

2023-08-10 Thread Nelson Bighetti (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nelson Bighetti updated KAFKA-14132: Description: {color:#de350b}Some of the tests below use EasyMock as well. For those migrat

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-10 Thread via GitHub
jeffkbkim commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1290813753 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignor.java: ## @@ -0,0 +1,396 @@ +/* + * Licensed to the Apache Soft

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-10 Thread via GitHub
jeffkbkim commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1290813322 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignor.java: ## @@ -0,0 +1,396 @@ +/* + * Licensed to the Apache Soft

[GitHub] [kafka] gharris1727 merged pull request #14188: KAFKA-15239: Fix ThroughputThrottler import-control

2023-08-10 Thread via GitHub
gharris1727 merged PR #14188: URL: https://github.com/apache/kafka/pull/14188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

[GitHub] [kafka] gharris1727 opened a new pull request, #14188: KAFKA-15239: Fix ThroughputThrottler import-control

2023-08-10 Thread via GitHub
gharris1727 opened a new pull request, #14188: URL: https://github.com/apache/kafka/pull/14188 #14092 broke checkstyle due to the package name changing. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and C

[jira] [Reopened] (KAFKA-14598) Fix flaky ConnectRestApiTest

2023-08-10 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris reopened KAFKA-14598: - Assignee: (was: Ashwin Pankaj) > Fix flaky ConnectRestApiTest > --

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-10 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1290766391 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignor.java: ## @@ -0,0 +1,396 @@ +/* + * Licensed to the Apache Soft

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-10 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1290765488 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignor.java: ## @@ -0,0 +1,396 @@ +/* + * Licensed to the Apache Soft

[GitHub] [kafka] junrao commented on a diff in pull request #14111: KAFKA-9800: Exponential backoff for Kafka clients - KIP-580

2023-08-10 Thread via GitHub
junrao commented on code in PR #14111: URL: https://github.com/apache/kafka/pull/14111#discussion_r1290474356 ## clients/src/main/java/org/apache/kafka/clients/Metadata.java: ## @@ -140,17 +167,30 @@ public long metadataExpireMs() { } /** - * Request an update of

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-10 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1290764909 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignor.java: ## @@ -0,0 +1,396 @@ +/* + * Licensed to the Apache Soft

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-10 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1290763624 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignor.java: ## @@ -0,0 +1,396 @@ +/* + * Licensed to the Apache Soft

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-10 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1290763071 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignor.java: ## @@ -0,0 +1,396 @@ +/* + * Licensed to the Apache Soft

[GitHub] [kafka] philipnee commented on pull request #14179: MINOR: CommitRequestManager should only poll when the coordinator node is known

2023-08-10 Thread via GitHub
philipnee commented on PR #14179: URL: https://github.com/apache/kafka/pull/14179#issuecomment-1674034799 @junrao - This minor PR fixes a small bug in the commit request manager. Would you be able to review it? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] philipnee commented on pull request #14179: MINOR: CommitRequestManager should only poll when the coordinator node is known

2023-08-10 Thread via GitHub
philipnee commented on PR #14179: URL: https://github.com/apache/kafka/pull/14179#issuecomment-1674034179 Here are the failing flaky tests. ``` Build / JDK 17 and Scala 2.13 / testOffsetTranslationBehindReplicationFlow() – org.apache.kafka.connect.mirror.integration.MirrorConnectorsIn

[GitHub] [kafka] mjsax commented on a diff in pull request #14187: KAFKA-13197: fix GlobalKTable join/left-join semantics documentation.

2023-08-10 Thread via GitHub
mjsax commented on code in PR #14187: URL: https://github.com/apache/kafka/pull/14187#discussion_r1290758646 ## streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java: ## @@ -2805,7 +2805,7 @@ KStream leftJoin(final KTable table, * For each {@code KStream} r

[jira] [Updated] (KAFKA-13197) KStream-GlobalKTable join semantics don't match documentation

2023-08-10 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-13197: Component/s: documentation streams > KStream-GlobalKTable join semantics

[GitHub] [kafka] gharris1727 commented on pull request #14092: KAFKA-15239: Fix system tests using producer performance service

2023-08-10 Thread via GitHub
gharris1727 commented on PR #14092: URL: https://github.com/apache/kafka/pull/14092#issuecomment-1673942664 Thank you @fvaleri for diagnosing this test regression and promptly fixing it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Resolved] (KAFKA-15239) producerPerformance system test for old client failed after v3.5.0

2023-08-10 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris resolved KAFKA-15239. - Fix Version/s: 3.6.0 Reviewer: Greg Harris Resolution: Fixed > producerPerforman

[GitHub] [kafka] gharris1727 merged pull request #14092: KAFKA-15239: Fix system tests using producer performance service

2023-08-10 Thread via GitHub
gharris1727 merged PR #14092: URL: https://github.com/apache/kafka/pull/14092 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

[jira] [Updated] (KAFKA-15202) MM2 OffsetSyncStore clears too many syncs when sync spacing is variable

2023-08-10 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-15202: Affects Version/s: 3.5.1 (was: 3.3.3) > MM2 OffsetSyncStore clears too

[jira] [Updated] (KAFKA-15202) MM2 OffsetSyncStore clears too many syncs when sync spacing is variable

2023-08-10 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-15202: Fix Version/s: 3.3.3 3.4.2 3.5.2 > MM2 OffsetSyncStore clear

[jira] [Resolved] (KAFKA-13187) Replace EasyMock and PowerMock with Mockito for DistributedHerderTest

2023-08-10 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-13187. --- Fix Version/s: 3.6.0 Resolution: Done > Replace EasyMock and PowerMock with Mockito f

[GitHub] [kafka] C0urante merged pull request #14102: KAFKA-13187: Replace EasyMock / PowerMock with Mockito in DistributedHerderTest

2023-08-10 Thread via GitHub
C0urante merged PR #14102: URL: https://github.com/apache/kafka/pull/14102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] C0urante commented on pull request #14102: KAFKA-13187: Replace EasyMock / PowerMock with Mockito in DistributedHerderTest

2023-08-10 Thread via GitHub
C0urante commented on PR #14102: URL: https://github.com/apache/kafka/pull/14102#issuecomment-1673896029 I should note that because this test makes heavy use of Mockito's strict stubbing feature, I've opened https://github.com/apache/kafka/pull/14186 to enable reporting of unused stubbings

[GitHub] [kafka] C0urante commented on a diff in pull request #14102: KAFKA-13187: Replace EasyMock / PowerMock with Mockito in DistributedHerderTest

2023-08-10 Thread via GitHub
C0urante commented on code in PR #14102: URL: https://github.com/apache/kafka/pull/14102#discussion_r1290658873 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java: ## @@ -3872,7 +2952,7 @@ public void testVerifyTaskGeneration

[GitHub] [kafka] C0urante commented on a diff in pull request #14102: KAFKA-13187: Replace EasyMock / PowerMock with Mockito in DistributedHerderTest

2023-08-10 Thread via GitHub
C0urante commented on code in PR #14102: URL: https://github.com/apache/kafka/pull/14102#discussion_r1290659476 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java: ## @@ -3929,543 +3008,636 @@ public void testPollDurationOnS

[GitHub] [kafka] rittikaadhikari commented on pull request #13503: MINOR: Refactor TierStateMachine related tests into a separate test file

2023-08-10 Thread via GitHub
rittikaadhikari commented on PR #13503: URL: https://github.com/apache/kafka/pull/13503#issuecomment-1673867152 @junrao Thanks for the review! I have addressed the comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] gharris1727 merged pull request #14156: KAFKA-15202: Fix MM2 offset translation when syncs are variably spaced

2023-08-10 Thread via GitHub
gharris1727 merged PR #14156: URL: https://github.com/apache/kafka/pull/14156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

[GitHub] [kafka] gharris1727 commented on pull request #14156: KAFKA-15202: Fix MM2 offset translation when syncs are variably spaced

2023-08-10 Thread via GitHub
gharris1727 commented on PR #14156: URL: https://github.com/apache/kafka/pull/14156#issuecomment-1673861990 The latest CI run has some unrelated flakiness, and tests pass locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [kafka] C0urante commented on a diff in pull request #14082: KAFKA-15102: Mirror Maker 2 - KIP690 backward compatibility

2023-08-10 Thread via GitHub
C0urante commented on code in PR #14082: URL: https://github.com/apache/kafka/pull/14082#discussion_r1290641476 ## connect/mirror-client/src/main/java/org/apache/kafka/connect/mirror/DefaultReplicationPolicy.java: ## @@ -43,6 +47,11 @@ public void configure(Map props) {

[GitHub] [kafka] gharris1727 commented on pull request #14156: KAFKA-15202: Fix MM2 offset translation when syncs are variably spaced

2023-08-10 Thread via GitHub
gharris1727 commented on PR #14156: URL: https://github.com/apache/kafka/pull/14156#issuecomment-1673859231 I saw one of the CI builds with testOffsetTranslationBehindReplicationFlow failing, so I think there is still another source of flakiness somewhere. I'll close the fix JIRA but leave

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-10 Thread via GitHub
jeffkbkim commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1290585581 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignor.java: ## @@ -0,0 +1,396 @@ +/* + * Licensed to the Apache Soft

[GitHub] [kafka] C0urante commented on a diff in pull request #14068: KAFKA-15233: Add documentation for plugin.discovery and connect-plugin-path (KIP-898)

2023-08-10 Thread via GitHub
C0urante commented on code in PR #14068: URL: https://github.com/apache/kafka/pull/14068#discussion_r1290629836 ## docs/connect.html: ## @@ -543,6 +543,67 @@ ACL requirements +Plugin Discovery + +Plugin discovery is the name for the strategy which the

[GitHub] [kafka] C0urante commented on a diff in pull request #14068: KAFKA-15233: Add documentation for plugin.discovery and connect-plugin-path (KIP-898)

2023-08-10 Thread via GitHub
C0urante commented on code in PR #14068: URL: https://github.com/apache/kafka/pull/14068#discussion_r1290627899 ## docs/connect.html: ## @@ -543,6 +543,67 @@ ACL requirements +Plugin Discovery + +Plugin discovery is the name for the strategy which the

[GitHub] [kafka] C0urante commented on a diff in pull request #14068: KAFKA-15233: Add documentation for plugin.discovery and connect-plugin-path (KIP-898)

2023-08-10 Thread via GitHub
C0urante commented on code in PR #14068: URL: https://github.com/apache/kafka/pull/14068#discussion_r1290624547 ## docs/connect.html: ## @@ -543,6 +543,67 @@ ACL requirements +Plugin Discovery + +Plugin discovery is the name for the strategy which the

[GitHub] [kafka] gharris1727 commented on a diff in pull request #14064: KAFKA-15030: Add connect-plugin-path command-line tool.

2023-08-10 Thread via GitHub
gharris1727 commented on code in PR #14064: URL: https://github.com/apache/kafka/pull/14064#discussion_r1290624348 ## tools/src/main/java/org/apache/kafka/tools/ConnectPluginPath.java: ## @@ -0,0 +1,559 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

[GitHub] [kafka] gharris1727 commented on pull request #14064: KAFKA-15030: Add connect-plugin-path command-line tool.

2023-08-10 Thread via GitHub
gharris1727 commented on PR #14064: URL: https://github.com/apache/kafka/pull/14064#issuecomment-1673833354 > We may choose to report broken plugin locations (i.e., any that has one or more unloadable plugins), but IMO it's better to leave this info out entirely. We have room to maneuver in

[GitHub] [kafka] C0urante commented on a diff in pull request #14068: KAFKA-15233: Add documentation for plugin.discovery and connect-plugin-path (KIP-898)

2023-08-10 Thread via GitHub
C0urante commented on code in PR #14068: URL: https://github.com/apache/kafka/pull/14068#discussion_r1290620328 ## docs/connect.html: ## @@ -543,6 +543,67 @@ ACL requirements +Plugin Discovery + +Plugin discovery is the name for the strategy which the

[GitHub] [kafka] florin-akermann opened a new pull request, #14187: KAFKA-13197: fix GlobalKTable join/left-join semantics documentation.

2023-08-10 Thread via GitHub
florin-akermann opened a new pull request, #14187: URL: https://github.com/apache/kafka/pull/14187 The documentation for join/left-join Kstream-GlobalKtable is out dated: The left hand side key may be null. Note that the second statement mentioned in the Jira https://issues.apache.or

[GitHub] [kafka] mjsax commented on a diff in pull request #14103: HOTIFX: fix Kafka Streams upgrade path from 3.4 to 3.5

2023-08-10 Thread via GitHub
mjsax commented on code in PR #14103: URL: https://github.com/apache/kafka/pull/14103#discussion_r1290589930 ## clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java: ## @@ -947,9 +947,15 @@ public String toString() { } public static class ValidString i

[GitHub] [kafka] kirktrue commented on pull request #14156: KAFKA-15202: Fix MM2 offset translation when syncs are variably spaced

2023-08-10 Thread via GitHub
kirktrue commented on PR #14156: URL: https://github.com/apache/kafka/pull/14156#issuecomment-1673817790 @gharris1727 Thanks for your work on this! Hopefully it will help KAFKA-15197 too! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] kirktrue commented on pull request #13908: KAFKA-15052 Fix the flaky testBalancePartitionLeaders - part II

2023-08-10 Thread via GitHub
kirktrue commented on PR #13908: URL: https://github.com/apache/kafka/pull/13908#issuecomment-1673815636 @divijvaidya Can you review this with an eye to merging it? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] gharris1727 commented on pull request #14092: KAFKA-15239: Fix system tests using producer performance service

2023-08-10 Thread via GitHub
gharris1727 commented on PR #14092: URL: https://github.com/apache/kafka/pull/14092#issuecomment-1673813076 System test failures appear to be due to reasons other than classloading/dependency issues. The producer performance tests appear to work normally. ``` tests/kafkatest/tests/co

[GitHub] [kafka] C0urante commented on a diff in pull request #14064: KAFKA-15030: Add connect-plugin-path command-line tool.

2023-08-10 Thread via GitHub
C0urante commented on code in PR #14064: URL: https://github.com/apache/kafka/pull/14064#discussion_r1290570863 ## tools/src/main/java/org/apache/kafka/tools/ConnectPluginPath.java: ## @@ -0,0 +1,559 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] mjsax commented on a diff in pull request #14103: HOTIFX: fix Kafka Streams upgrade path from 3.4 to 3.5

2023-08-10 Thread via GitHub
mjsax commented on code in PR #14103: URL: https://github.com/apache/kafka/pull/14103#discussion_r1290575646 ## clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java: ## @@ -947,9 +947,15 @@ public String toString() { } public static class ValidString i

[GitHub] [kafka] mjsax commented on a diff in pull request #14103: HOTIFX: fix Kafka Streams upgrade path from 3.4 to 3.5

2023-08-10 Thread via GitHub
mjsax commented on code in PR #14103: URL: https://github.com/apache/kafka/pull/14103#discussion_r1290575646 ## clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java: ## @@ -947,9 +947,15 @@ public String toString() { } public static class ValidString i

[GitHub] [kafka] mjsax commented on a diff in pull request #14103: HOTIFX: fix Kafka Streams upgrade path from 3.4 to 3.5

2023-08-10 Thread via GitHub
mjsax commented on code in PR #14103: URL: https://github.com/apache/kafka/pull/14103#discussion_r1290575646 ## clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java: ## @@ -947,9 +947,15 @@ public String toString() { } public static class ValidString i

[GitHub] [kafka] mjsax commented on a diff in pull request #14103: HOTIFX: fix Kafka Streams upgrade path from 3.4 to 3.5

2023-08-10 Thread via GitHub
mjsax commented on code in PR #14103: URL: https://github.com/apache/kafka/pull/14103#discussion_r1290575646 ## clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java: ## @@ -947,9 +947,15 @@ public String toString() { } public static class ValidString i

[GitHub] [kafka] mjsax commented on a diff in pull request #14103: HOTIFX: fix Kafka Streams upgrade path from 3.4 to 3.5

2023-08-10 Thread via GitHub
mjsax commented on code in PR #14103: URL: https://github.com/apache/kafka/pull/14103#discussion_r1290555860 ## clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java: ## @@ -947,9 +947,15 @@ public String toString() { } public static class ValidString i

[GitHub] [kafka] mjsax commented on a diff in pull request #14103: HOTIFX: fix Kafka Streams upgrade path from 3.4 to 3.5

2023-08-10 Thread via GitHub
mjsax commented on code in PR #14103: URL: https://github.com/apache/kafka/pull/14103#discussion_r1290555860 ## clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java: ## @@ -947,9 +947,15 @@ public String toString() { } public static class ValidString i

[GitHub] [kafka] mjsax commented on a diff in pull request #14103: HOTIFX: fix Kafka Streams upgrade path from 3.4 to 3.5

2023-08-10 Thread via GitHub
mjsax commented on code in PR #14103: URL: https://github.com/apache/kafka/pull/14103#discussion_r1290555860 ## clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java: ## @@ -947,9 +947,15 @@ public String toString() { } public static class ValidString i

[jira] [Created] (KAFKA-15333) Flaky build failure throwing Connect Exception: Could not connect to server....

2023-08-10 Thread Philip Nee (Jira)
Philip Nee created KAFKA-15333: -- Summary: Flaky build failure throwing Connect Exception: Could not connect to server Key: KAFKA-15333 URL: https://issues.apache.org/jira/browse/KAFKA-15333 Project:

[GitHub] [kafka] jolshan commented on a diff in pull request #14138: Fix a race when query isUnderMinIsr

2023-08-10 Thread via GitHub
jolshan commented on code in PR #14138: URL: https://github.com/apache/kafka/pull/14138#discussion_r1290546194 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -798,6 +803,12 @@ class Partition(val topicPartition: TopicPartition, // to maintain the decision mak

[GitHub] [kafka] C0urante commented on pull request #14186: KAFKA-14682: Report Mockito unused stubbings during Jenkins build

2023-08-10 Thread via GitHub
C0urante commented on PR #14186: URL: https://github.com/apache/kafka/pull/14186#issuecomment-1673671924 I've opened this as a draft request to demonstrate that unused stubbings will be successfully reported with the proposed change to the Jenkinsfile. Once the build fails successfully (🙃),

[GitHub] [kafka] mjsax commented on a diff in pull request #14181: KAFKA-15022: [10/N] docs for rack aware assignor

2023-08-10 Thread via GitHub
mjsax commented on code in PR #14181: URL: https://github.com/apache/kafka/pull/14181#discussion_r1290483692 ## docs/streams/developer-guide/config-streams.html: ## @@ -685,6 +688,45 @@ default.windowed.value.serde.innerThis is discussed in more detail in Data types and serializ

[GitHub] [kafka] cmccabe merged pull request #14050: KAFKA-15220: Do not returned fenced brokers from getAliveBrokerNode

2023-08-10 Thread via GitHub
cmccabe merged PR #14050: URL: https://github.com/apache/kafka/pull/14050 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] mjsax commented on a diff in pull request #14181: KAFKA-15022: [10/N] docs for rack aware assignor

2023-08-10 Thread via GitHub
mjsax commented on code in PR #14181: URL: https://github.com/apache/kafka/pull/14181#discussion_r1290482358 ## docs/streams/developer-guide/config-streams.html: ## @@ -685,6 +688,45 @@ default.windowed.value.serde.innerThis is discussed in more detail in Data types and serializ

[GitHub] [kafka] C0urante opened a new pull request, #14186: KAFKA-14682: Report Mockito unused stubbings during Jenkins build

2023-08-10 Thread via GitHub
C0urante opened a new pull request, #14186: URL: https://github.com/apache/kafka/pull/14186 [Jira](https://issues.apache.org/jira/browse/KAFKA-14682) Our Jenkinsfile is currently configured to do testing with the `unitTest` and `integrationTest` tasks, instead of the `test` task. Thes

[jira] [Created] (KAFKA-15332) Eligible Leader Replicas

2023-08-10 Thread Calvin Liu (Jira)
Calvin Liu created KAFKA-15332: -- Summary: Eligible Leader Replicas Key: KAFKA-15332 URL: https://issues.apache.org/jira/browse/KAFKA-15332 Project: Kafka Issue Type: New Feature Repo

[GitHub] [kafka] mjsax commented on a diff in pull request #14181: KAFKA-15022: [10/N] docs for rack aware assignor

2023-08-10 Thread via GitHub
mjsax commented on code in PR #14181: URL: https://github.com/apache/kafka/pull/14181#discussion_r1290485321 ## docs/streams/developer-guide/config-streams.html: ## @@ -685,6 +688,45 @@ default.windowed.value.serde.innerThis is discussed in more detail in Data types and serializ

[GitHub] [kafka] mjsax commented on a diff in pull request #14181: KAFKA-15022: [10/N] docs for rack aware assignor

2023-08-10 Thread via GitHub
mjsax commented on code in PR #14181: URL: https://github.com/apache/kafka/pull/14181#discussion_r1290489521 ## docs/streams/developer-guide/config-streams.html: ## @@ -718,6 +760,24 @@ rack.aware.assignment.tags +rack.aware.assignment.traffic_cost + +

[GitHub] [kafka] mjsax commented on a diff in pull request #14181: KAFKA-15022: [10/N] docs for rack aware assignor

2023-08-10 Thread via GitHub
mjsax commented on code in PR #14181: URL: https://github.com/apache/kafka/pull/14181#discussion_r1290483313 ## docs/streams/developer-guide/config-streams.html: ## @@ -685,6 +688,45 @@ default.windowed.value.serde.innerThis is discussed in more detail in Data types and serializ

[GitHub] [kafka] mjsax commented on a diff in pull request #14181: KAFKA-15022: [10/N] docs for rack aware assignor

2023-08-10 Thread via GitHub
mjsax commented on code in PR #14181: URL: https://github.com/apache/kafka/pull/14181#discussion_r1290445751 ## docs/streams/architecture.html: ## @@ -167,6 +167,14 @@ Kafka Streams Developer Guide section. + +There is also a client side config client.rack whi

[GitHub] [kafka] mjsax commented on a diff in pull request #14181: KAFKA-15022: [10/N] docs for rack aware assignor

2023-08-10 Thread via GitHub
mjsax commented on code in PR #14181: URL: https://github.com/apache/kafka/pull/14181#discussion_r1290489338 ## docs/streams/developer-guide/config-streams.html: ## @@ -718,6 +760,24 @@ rack.aware.assignment.tags +rack.aware.assignment.traffic_cost + +

[GitHub] [kafka] mjsax commented on a diff in pull request #14181: KAFKA-15022: [10/N] docs for rack aware assignor

2023-08-10 Thread via GitHub
mjsax commented on code in PR #14181: URL: https://github.com/apache/kafka/pull/14181#discussion_r1290445388 ## docs/streams/architecture.html: ## @@ -167,6 +167,14 @@ Kafka Streams Developer Guide section. + +There is also a client side config client.rack whi

[GitHub] [kafka] mjsax commented on a diff in pull request #14181: KAFKA-15022: [10/N] docs for rack aware assignor

2023-08-10 Thread via GitHub
mjsax commented on code in PR #14181: URL: https://github.com/apache/kafka/pull/14181#discussion_r1290486200 ## docs/streams/developer-guide/config-streams.html: ## @@ -685,6 +688,45 @@ default.windowed.value.serde.innerThis is discussed in more detail in Data types and serializ

[GitHub] [kafka] gharris1727 merged pull request #14159: Kafka 15291 connect plugins implement versioned

2023-08-10 Thread via GitHub
gharris1727 merged PR #14159: URL: https://github.com/apache/kafka/pull/14159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

[jira] [Resolved] (KAFKA-15291) Implement Versioned interfaces in common Connect plugins

2023-08-10 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris resolved KAFKA-15291. - Resolution: Fixed > Implement Versioned interfaces in common Connect plugins > -

[GitHub] [kafka] gharris1727 commented on pull request #14159: Kafka 15291 connect plugins implement versioned

2023-08-10 Thread via GitHub
gharris1727 commented on PR #14159: URL: https://github.com/apache/kafka/pull/14159#issuecomment-1673635408 Flaky test failures appear unrelated, and tests pass locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] mimaison commented on a diff in pull request #13204: KAFKA-14593: Move LeaderElectionCommand to tools

2023-08-10 Thread via GitHub
mimaison commented on code in PR #13204: URL: https://github.com/apache/kafka/pull/13204#discussion_r1290277580 ## tools/src/test/java/org/apache/kafka/tools/LeaderElectionCommandTest.java: ## @@ -0,0 +1,329 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [kafka] kamalcph commented on a diff in pull request #13947: KAFKA-15130: Delete remote segments when delete a topic

2023-08-10 Thread via GitHub
kamalcph commented on code in PR #13947: URL: https://github.com/apache/kafka/pull/13947#discussion_r1290377829 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -343,21 +345,78 @@ public void onLeadershipChange(Set partitionsBecomeLeader, /** * Del

  1   2   >