[jira] [Assigned] (KAFKA-15946) AsyncKafkaConsumer should retry commits on the application thread instead of autoretry

2023-11-29 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee reassigned KAFKA-15946: -- Assignee: Kirk True > AsyncKafkaConsumer should retry commits on the application thread

[jira] [Updated] (KAFKA-15946) AsyncKafkaConsumer should retry commits on the application thread instead of autoretry

2023-11-29 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-15946: --- Parent: KAFKA-14246 Issue Type: Sub-task (was: Bug) > AsyncKafkaConsumer should retry

[jira] [Updated] (KAFKA-15946) AsyncKafkaConsumer should retry commits on the application thread instead of autoretry

2023-11-29 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-15946: --- Description: The original design was that the network thread always completes the future whether

[jira] [Created] (KAFKA-15946) AsyncKafkaConsumer should retry commits on the application thread instead of autoretry

2023-11-29 Thread Philip Nee (Jira)
Philip Nee created KAFKA-15946: -- Summary: AsyncKafkaConsumer should retry commits on the application thread instead of autoretry Key: KAFKA-15946 URL: https://issues.apache.org/jira/browse/KAFKA-15946

Re: [PR] KAFKA-15901: Client changes for registering telemetry and API calls (KIP-714) [kafka]

2023-11-29 Thread via GitHub
apoorvmittal10 commented on code in PR #14843: URL: https://github.com/apache/kafka/pull/14843#discussion_r1409735687 ## clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java: ## @@ -294,4 +296,14 @@ public static List metricsReporters(Map clientI }

Re: [PR] KAFKA-15764: Missing Tests for Transactions [kafka]

2023-11-29 Thread via GitHub
hachikuji commented on code in PR #14702: URL: https://github.com/apache/kafka/pull/14702#discussion_r1409733930 ## core/src/test/scala/integration/kafka/api/TransactionsTest.scala: ## @@ -820,6 +823,37 @@ class TransactionsTest extends IntegrationTestHarness {

Re: [PR] KAFKA-15901: Client changes for registering telemetry and API calls (KIP-714) [kafka]

2023-11-29 Thread via GitHub
apoorvmittal10 commented on code in PR #14843: URL: https://github.com/apache/kafka/pull/14843#discussion_r1409734047 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryUtils.java: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-15022: introduce interface to control graph constructor [kafka]

2023-11-29 Thread via GitHub
lihaosky commented on code in PR #14714: URL: https://github.com/apache/kafka/pull/14714#discussion_r1409723863 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/BalanceSubtopologyGraphConstructor.java: ## @@ -0,0 +1,186 @@ +package

Re: [PR] KAFKA-15663, KAFKA-15794: Telemetry reporter and request handling (KIP-714) [kafka]

2023-11-29 Thread via GitHub
apoorvmittal10 commented on PR #14724: URL: https://github.com/apache/kafka/pull/14724#issuecomment-1832489526 Hi @mjsax, thanks a lot for the review. I have addressed the feedback, please let me know if I need to further address anything. I have updated the PR with other merges and

Re: [PR] KAFKA-15663, KAFKA-15794: Telemetry reporter and request handling (KIP-714) [kafka]

2023-11-29 Thread via GitHub
apoorvmittal10 commented on code in PR #14724: URL: https://github.com/apache/kafka/pull/14724#discussion_r1409714105 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java: ## @@ -550,6 +576,41 @@ public void close() { } } +

Re: [PR] KAFKA-15663, KAFKA-15794: Telemetry reporter and request handling (KIP-714) [kafka]

2023-11-29 Thread via GitHub
apoorvmittal10 commented on code in PR #14724: URL: https://github.com/apache/kafka/pull/14724#discussion_r1409712629 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java: ## @@ -0,0 +1,914 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] KAFKA-15663, KAFKA-15794: Telemetry reporter and request handling (KIP-714) [kafka]

2023-11-29 Thread via GitHub
apoorvmittal10 commented on code in PR #14724: URL: https://github.com/apache/kafka/pull/14724#discussion_r1409710911 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryProvider.java: ## @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Resolved] (KAFKA-5046) Support file rotation in FileStreamSource Connector

2023-11-29 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis resolved KAFKA-5046. --- Resolution: Won't Fix > Support file rotation in FileStreamSource Connector

Re: [PR] KAFKA-15865: Remove autocommit completion event [kafka]

2023-11-29 Thread via GitHub
lucasbru merged PR #14831: URL: https://github.com/apache/kafka/pull/14831 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15865: Remove autocommit completion event [kafka]

2023-11-29 Thread via GitHub
lucasbru commented on PR #14831: URL: https://github.com/apache/kafka/pull/14831#issuecomment-1832440394 There is already a ticket for this. [KAFKA-15900](https://issues.apache.org/jira/browse/KAFKA-15900) -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] KAFKA-14438: Throw error when consumer configured with empty/whitespace-only group.id for AsyncKafkaConsumer [kafka]

2023-11-29 Thread via GitHub
kirktrue commented on PR #14768: URL: https://github.com/apache/kafka/pull/14768#issuecomment-1832435606 @cadonna, can you take a look at this change? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Resolved] (KAFKA-15046) Produce performance issue under high disk load

2023-11-29 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-15046. - Fix Version/s: 3.7.0 Resolution: Fixed merged the PR to trunk. > Produce performance issue

Re: [PR] KAFKA-15046: Get rid of unnecessary fsyncs inside UnifiedLog.lock to stabilize performance [kafka]

2023-11-29 Thread via GitHub
junrao merged PR #14242: URL: https://github.com/apache/kafka/pull/14242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15831: KIP-1000 protocol and admin client [kafka]

2023-11-29 Thread via GitHub
AndrewJSchofield closed pull request #14811: KAFKA-15831: KIP-1000 protocol and admin client URL: https://github.com/apache/kafka/pull/14811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-15831: KIP-1000 protocol and admin client [kafka]

2023-11-29 Thread via GitHub
junrao commented on PR #14811: URL: https://github.com/apache/kafka/pull/14811#issuecomment-1832388672 Thanks for the analysis, @AndrewJSchofield. Does the following mean that some of the tests didn't run? Should we rerun the tests? ``` Build / JDK 21 and Scala 2.13 / Gradle Test

[jira] [Created] (KAFKA-15945) Flaky test - testSyncTopicConfigs() – org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationBaseTest

2023-11-29 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-15945: Summary: Flaky test - testSyncTopicConfigs() – org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationBaseTest Key: KAFKA-15945 URL:

[jira] [Created] (KAFKA-15944) Flaky test - verifyStore[cache=false, log=true, supplier=ROCKS_KV, kind=DSL] – org.apache.kafka.streams.integration.PositionRestartIntegrationTest

2023-11-29 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-15944: Summary: Flaky test - verifyStore[cache=false, log=true, supplier=ROCKS_KV, kind=DSL] – org.apache.kafka.streams.integration.PositionRestartIntegrationTest Key: KAFKA-15944

Re: [PR] KAFKA-15778 & KAFKA-15779: Implement metrics manager (KIP-714) [kafka]

2023-11-29 Thread via GitHub
junrao merged PR #14699: URL: https://github.com/apache/kafka/pull/14699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (KAFKA-15943) Flaky test - testHighWaterMarkAfterPartitionReassignment(String).quorum=kraft – org.apache.kafka.tools.reassign.ReassignPartitionsIntegrationTest

2023-11-29 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-15943: Summary: Flaky test - testHighWaterMarkAfterPartitionReassignment(String).quorum=kraft – org.apache.kafka.tools.reassign.ReassignPartitionsIntegrationTest Key: KAFKA-15943

[jira] [Updated] (KAFKA-15942) Implement ConsumerInterceptor

2023-11-29 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-15942: --- Parent: KAFKA-14246 Issue Type: Sub-task (was: Improvement) > Implement

[jira] [Updated] (KAFKA-15942) Implement ConsumerInterceptor

2023-11-29 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-15942: --- Labels: consumer-threading-refactor (was: ) > Implement ConsumerInterceptor >

Re: [PR] KAFKA-15831: KIP-1000 protocol and admin client [kafka]

2023-11-29 Thread via GitHub
AndrewJSchofield commented on PR #14811: URL: https://github.com/apache/kafka/pull/14811#issuecomment-1832366763 @junrao The failing tests are not related. Here's a summary: * Kafka Streams EOS integration tests * KRaft controller tests * Consumer coordinator failover test *

[jira] [Created] (KAFKA-15942) Implement ConsumerInterceptor

2023-11-29 Thread Philip Nee (Jira)
Philip Nee created KAFKA-15942: -- Summary: Implement ConsumerInterceptor Key: KAFKA-15942 URL: https://issues.apache.org/jira/browse/KAFKA-15942 Project: Kafka Issue Type: Improvement

Re: [PR] KAFKA-15574; [2/N]: Client state machine updates [kafka]

2023-11-29 Thread via GitHub
lianetm commented on PR #14857: URL: https://github.com/apache/kafka/pull/14857#issuecomment-1832346888 Hey @dajac , thanks for the comments, all addressed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-15574; [2/N]: Client state machine updates [kafka]

2023-11-29 Thread via GitHub
lianetm commented on code in PR #14857: URL: https://github.com/apache/kafka/pull/14857#discussion_r1409611754 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java: ## @@ -223,8 +232,65 @@ public void

Re: [PR] KAFKA-15778 & KAFKA-15779: Implement metrics manager (KIP-714) [kafka]

2023-11-29 Thread via GitHub
apoorvmittal10 commented on PR #14699: URL: https://github.com/apache/kafka/pull/14699#issuecomment-1832344298 @junrao The tests failures are not related to the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] KAFKA-14588 Move DynamicConfig to server-commons [kafka]

2023-11-29 Thread via GitHub
nizhikov opened a new pull request, #14871: URL: https://github.com/apache/kafka/pull/14871 This PR move `DynamicConfig` class to "server-commons" module. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage

Re: [PR] MINOR: DirectoryId.MIGRATING should be all zeros [kafka]

2023-11-29 Thread via GitHub
rondagostino commented on code in PR #14858: URL: https://github.com/apache/kafka/pull/14858#discussion_r1409602400 ## server-common/src/main/java/org/apache/kafka/common/DirectoryId.java: ## @@ -23,25 +23,24 @@ import java.util.Map; public class DirectoryId { - /** -

Re: [PR] KAFKA-14505; [1/N] Add support for transactional writes to CoordinatorRuntime [kafka]

2023-11-29 Thread via GitHub
jolshan merged PR #14844: URL: https://github.com/apache/kafka/pull/14844 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] KAFKA-14987 [2/2]; customize retry backoff for group/offsets expiration [kafka]

2023-11-29 Thread via GitHub
jeffkbkim opened a new pull request, #14870: URL: https://github.com/apache/kafka/pull/14870 The group expiration log becomes noisy when we encounter a retry-able error as the retry backoff is fixed to 500 ms. Allow customizable retry backoff so that even in the case of failure we have a

Re: [PR] KAFKA-15574; [2/N]: Client state machine updates [kafka]

2023-11-29 Thread via GitHub
lianetm commented on code in PR #14857: URL: https://github.com/apache/kafka/pull/14857#discussion_r1409556953 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -365,6 +366,11 @@ private void

Re: [PR] KAFKA-15574; [2/N]: Client state machine updates [kafka]

2023-11-29 Thread via GitHub
lianetm commented on code in PR #14857: URL: https://github.com/apache/kafka/pull/14857#discussion_r1409556622 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -531,7 +537,13 @@ private CompletableFuture

Re: [PR] KAFKA-15574; [2/N]: Client state machine updates [kafka]

2023-11-29 Thread via GitHub
lianetm commented on code in PR #14857: URL: https://github.com/apache/kafka/pull/14857#discussion_r1409555977 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java: ## @@ -223,8 +232,65 @@ public void

Re: [PR] KAFKA-15663, KAFKA-15794: Telemetry reporter and request handling (KIP-714) [kafka]

2023-11-29 Thread via GitHub
apoorvmittal10 commented on code in PR #14724: URL: https://github.com/apache/kafka/pull/14724#discussion_r1409545155 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java: ## @@ -0,0 +1,937 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[PR] KAFKA-15690: Fix restoring task handling on partition loss, flaky Eos… [kafka]

2023-11-29 Thread via GitHub
lucasbru opened a new pull request, #14869: URL: https://github.com/apache/kafka/pull/14869 …IntegrationTest The following race can happen in the state updater code path - Task is restoring, owned by state updater - We fall out of the consumer group, lose all partitions

Re: [PR] KAFKA-15831: KIP-1000 protocol and admin client [kafka]

2023-11-29 Thread via GitHub
junrao commented on PR #14811: URL: https://github.com/apache/kafka/pull/14811#issuecomment-1832192692 @AndrewJSchofield : Are the 40 failed tests related? Could you file jiras for failed tests not being tracked yet? -- This is an automated message from the Apache Git Service. To respond

[jira] [Assigned] (KAFKA-15690) EosIntegrationTest is flaky.

2023-11-29 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy reassigned KAFKA-15690: -- Assignee: Lucas Brutschy > EosIntegrationTest is flaky. >

Re: [PR] KAFKA-15663, KAFKA-15794: Telemetry reporter and request handling (KIP-714) [kafka]

2023-11-29 Thread via GitHub
apoorvmittal10 commented on code in PR #14724: URL: https://github.com/apache/kafka/pull/14724#discussion_r1409482323 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryProvider.java: ## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Commented] (KAFKA-15931) Cached transaction index gets closed if tiered storage read is interrupted

2023-11-29 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791140#comment-17791140 ] Kamal Chandraprakash commented on KAFKA-15931: -- [~ivanyu]  Thanks for filing this issue!

Re: [PR] KAFKA-15778 & KAFKA-15779: Implement metrics manager (KIP-714) [kafka]

2023-11-29 Thread via GitHub
apoorvmittal10 commented on PR #14699: URL: https://github.com/apache/kafka/pull/14699#issuecomment-1832108927 Hi @junrao, I have triaged the test cases as per the latest run. `Existing`: Build / JDK 17 and Scala 2.13 / testMultiWorkerRestartOnlyConnector –

[jira] [Created] (KAFKA-15941) Flaky test: shouldRestoreNullRecord() – org.apache.kafka.streams.integration.RestoreIntegrationTest

2023-11-29 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-15941: - Summary: Flaky test: shouldRestoreNullRecord() – org.apache.kafka.streams.integration.RestoreIntegrationTest Key: KAFKA-15941 URL:

[jira] [Created] (KAFKA-15940) Flaky test: testLogCleanerConfig(String).quorum=kraft – kafka.server.DynamicBrokerReconfigurationTest

2023-11-29 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-15940: - Summary: Flaky test: testLogCleanerConfig(String).quorum=kraft – kafka.server.DynamicBrokerReconfigurationTest Key: KAFKA-15940 URL:

[jira] [Commented] (KAFKA-15932) Flaky test - PlaintextConsumerTest.testSeek("kraft+kip-848","consumer")

2023-11-29 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791137#comment-17791137 ] Andrew Schofield commented on KAFKA-15932: -- I have confirmed that the test is doing its job and

[jira] [Created] (KAFKA-15939) Flaky test: testInvalidAlterConfigs(String).quorum=kraft – kafka.api.AdminClientWithPoliciesIntegrationTest

2023-11-29 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-15939: - Summary: Flaky test: testInvalidAlterConfigs(String).quorum=kraft – kafka.api.AdminClientWithPoliciesIntegrationTest Key: KAFKA-15939 URL:

[jira] [Created] (KAFKA-15938) Flaky test: testCreateRemoteTopicWithValidRetentionTime(String).quorum=kraft – kafka.admin.RemoteTopicCrudTest

2023-11-29 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-15938: - Summary: Flaky test: testCreateRemoteTopicWithValidRetentionTime(String).quorum=kraft – kafka.admin.RemoteTopicCrudTest Key: KAFKA-15938 URL:

Re: [PR] KAFKA-15890: Consumer.poll with long timeout unaware of assigned partitions [kafka]

2023-11-29 Thread via GitHub
AndrewJSchofield closed pull request #14835: KAFKA-15890: Consumer.poll with long timeout unaware of assigned partitions URL: https://github.com/apache/kafka/pull/14835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Created] (KAFKA-15937) Flaky test: testTopicDeletion(String).quorum=kraft – kafka.admin.RemoteTopicCrudTest

2023-11-29 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-15937: - Summary: Flaky test: testTopicDeletion(String).quorum=kraft – kafka.admin.RemoteTopicCrudTest Key: KAFKA-15937 URL: https://issues.apache.org/jira/browse/KAFKA-15937

[jira] [Created] (KAFKA-15936) Flaky tests for class: ConnectorTopicsIntegrationTest

2023-11-29 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-15936: - Summary: Flaky tests for class: ConnectorTopicsIntegrationTest Key: KAFKA-15936 URL: https://issues.apache.org/jira/browse/KAFKA-15936 Project: Kafka

[jira] [Created] (KAFKA-15935) Flaky test: testRestartReplication() – org.apache.kafka.connect.mirror.integration.IdentityReplicationIntegrationTest

2023-11-29 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-15935: - Summary: Flaky test: testRestartReplication() – org.apache.kafka.connect.mirror.integration.IdentityReplicationIntegrationTest Key: KAFKA-15935 URL:

[jira] [Created] (KAFKA-15934) Flaky test: testMultiConsumerStickyAssignor(String, String).quorum=kraft+kip848.groupProtocol=generic – kafka.api.PlaintextConsumerTest

2023-11-29 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-15934: - Summary: Flaky test: testMultiConsumerStickyAssignor(String, String).quorum=kraft+kip848.groupProtocol=generic – kafka.api.PlaintextConsumerTest Key: KAFKA-15934 URL:

[jira] [Created] (KAFKA-15933) Flaky test: testRestartReplication() – org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationTransactionsTest

2023-11-29 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-15933: - Summary: Flaky test: testRestartReplication() – org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationTransactionsTest Key: KAFKA-15933 URL:

[jira] [Comment Edited] (KAFKA-15095) Flaky test EosV2UpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosV2[true]

2023-11-29 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791123#comment-17791123 ] Apoorv Mittal edited comment on KAFKA-15095 at 11/29/23 2:49 PM: - Build:

[jira] [Commented] (KAFKA-15095) Flaky test EosV2UpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosV2[true]

2023-11-29 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791123#comment-17791123 ] Apoorv Mittal commented on KAFKA-15095: --- Build:

[jira] [Reopened] (KAFKA-14089) Flaky ExactlyOnceSourceIntegrationTest.testSeparateOffsetsTopic

2023-11-29 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal reopened KAFKA-14089: --- Assignee: (was: Chris Egerton) Failure occurred on PR build:

Re: [PR] KAFKA-15842: Correct handling of KafkaConsumer.committed for new consumer [kafka]

2023-11-29 Thread via GitHub
AndrewJSchofield commented on PR #14859: URL: https://github.com/apache/kafka/pull/14859#issuecomment-1831950136 https://issues.apache.org/jira/browse/KAFKA-15932 opened for flaky test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] KAFKA-15910: New group coordinator needs to generate snapshots while loading [kafka]

2023-11-29 Thread via GitHub
dajac commented on code in PR #14849: URL: https://github.com/apache/kafka/pull/14849#discussion_r1409265390 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -1315,7 +1329,10 @@ public void scheduleLoadOperation(

[PR] KAFKA-14588 ConfigEntityName move to server-common [kafka]

2023-11-29 Thread via GitHub
nizhikov opened a new pull request, #14868: URL: https://github.com/apache/kafka/pull/14868 This PR is part of "[KAFKA-14588](https://issues.apache.org/jira/browse/KAFKA-14588) Move ConfigCommand to tools". ConfigCommand depends on ConfigType class. This PR moves ConfigType to

Re: [PR] KAFKA-15910: New group coordinator needs to generate snapshots while loading [kafka]

2023-11-29 Thread via GitHub
dajac commented on code in PR #14849: URL: https://github.com/apache/kafka/pull/14849#discussion_r1409239039 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorShard.java: ## @@ -47,4 +47,11 @@ default void onNewMetadataImage(MetadataImage

Re: [PR] KAFKA-15910: New group coordinator needs to generate snapshots while loading [kafka]

2023-11-29 Thread via GitHub
dajac commented on code in PR #14849: URL: https://github.com/apache/kafka/pull/14849#discussion_r1409237609 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorPlayback.java: ## @@ -33,4 +33,18 @@ public interface CoordinatorPlayback {

[jira] [Updated] (KAFKA-15931) Cached transaction index gets closed if tiered storage read is interrupted

2023-11-29 Thread Ivan Yurchenko (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Yurchenko updated KAFKA-15931: --- Description: This reproduces when reading from remote storage with the default

[jira] [Commented] (KAFKA-15931) Cached transaction index gets closed if tiered storage read is interrupted

2023-11-29 Thread Ivan Yurchenko (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791067#comment-17791067 ] Ivan Yurchenko commented on KAFKA-15931: [~satishd] how do you feel: should this be included in

[jira] [Created] (KAFKA-15932) Flaky test - PlaintextConsumerTest.testSeek("kraft+kip-848","consumer")

2023-11-29 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-15932: Summary: Flaky test - PlaintextConsumerTest.testSeek("kraft+kip-848","consumer") Key: KAFKA-15932 URL: https://issues.apache.org/jira/browse/KAFKA-15932

Re: [PR] KAFKA-15910: New group coordinator needs to generate snapshots while loading [kafka]

2023-11-29 Thread via GitHub
dajac commented on code in PR #14849: URL: https://github.com/apache/kafka/pull/14849#discussion_r1409232801 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -528,8 +528,8 @@ private void transitionTo(

Re: [PR] KAFKA-15910: New group coordinator needs to generate snapshots while loading [kafka]

2023-11-29 Thread via GitHub
dajac commented on code in PR #14849: URL: https://github.com/apache/kafka/pull/14849#discussion_r1409230711 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -458,9 +458,9 @@ private CoordinatorContext(

Re: [PR] KAFKA-15910: New group coordinator needs to generate snapshots while loading [kafka]

2023-11-29 Thread via GitHub
dajac commented on code in PR #14849: URL: https://github.com/apache/kafka/pull/14849#discussion_r1409228279 ## core/src/main/scala/kafka/coordinator/group/CoordinatorLoaderImpl.scala: ## @@ -148,6 +156,16 @@ class CoordinatorLoaderImpl[T]( } }

[jira] [Updated] (KAFKA-15931) Cached transaction index gets closed if tiered storage read is interrupted

2023-11-29 Thread Ivan Yurchenko (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Yurchenko updated KAFKA-15931: --- Description: This reproduces when reading from remote storage with the default

Re: [PR] KAFKA-14588 ConfigType moved to server-common [kafka]

2023-11-29 Thread via GitHub
nizhikov commented on PR #14867: URL: https://github.com/apache/kafka/pull/14867#issuecomment-1831822997 Hello @showuon Can, you, please, take a look at this changes? This PR simply move ConfigType class from "core" to "server-commons". -- This is an automated message from the

Re: [PR] MINOR: No need for response callback when applying controller mutation throttle [kafka]

2023-11-29 Thread via GitHub
dajac commented on code in PR #14861: URL: https://github.com/apache/kafka/pull/14861#discussion_r1409213733 ## core/src/main/scala/kafka/server/ControllerApis.scala: ## @@ -802,16 +798,13 @@ class ControllerApis( createPartitionsRequest.data(),

[jira] [Updated] (KAFKA-15931) Cached transaction index gets closed if tiered storage read is interrupted

2023-11-29 Thread Ivan Yurchenko (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Yurchenko updated KAFKA-15931: --- Description: This reproduces when reading from remote storage with the default

Re: [PR] KAFKA-14588 ConfigType moved to server-common [kafka]

2023-11-29 Thread via GitHub
nizhikov commented on PR #14867: URL: https://github.com/apache/kafka/pull/14867#issuecomment-1831797095 Hello @mimaison , @jolshan Can, you, please, take a look at this changes? This PR simply move `ConfigType` class from "core" to "server-commons". -- This is an automated

[jira] [Created] (KAFKA-15931) Cached transaction index gets closed if tiered storage read is interrupted

2023-11-29 Thread Ivan Yurchenko (Jira)
Ivan Yurchenko created KAFKA-15931: -- Summary: Cached transaction index gets closed if tiered storage read is interrupted Key: KAFKA-15931 URL: https://issues.apache.org/jira/browse/KAFKA-15931

Re: [PR] KAFKA-15662: Add support for clientInstanceIds in Kafka Stream [kafka]

2023-11-29 Thread via GitHub
AndrewJSchofield commented on code in PR #14864: URL: https://github.com/apache/kafka/pull/14864#discussion_r1409185585 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -1791,6 +1794,52 @@ protected int processStreamThread(final Consumer consumer) {

[PR] KAFKA-14588 ConfigType moved to server-common [kafka]

2023-11-29 Thread via GitHub
nizhikov opened a new pull request, #14867: URL: https://github.com/apache/kafka/pull/14867 This PR is part of "KAFKA-14588 Move ConfigCommand to tools". `ConfigCommand` depends on `ConfigType` class. This PR moves `ConfigType` to "server-commons" module. Changes are relatively

Re: [PR] KAFKA-15448: Streams Standby Update Listener (KIP-988) [kafka]

2023-11-29 Thread via GitHub
eduwercamacaro commented on code in PR #14735: URL: https://github.com/apache/kafka/pull/14735#discussion_r1409188652 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -701,7 +706,15 @@ private StandbyTask convertActiveToStandby(final

Re: [PR] KAFKA-15448: Streams Standby Update Listener (KIP-988) [kafka]

2023-11-29 Thread via GitHub
eduwercamacaro commented on code in PR #14735: URL: https://github.com/apache/kafka/pull/14735#discussion_r1409158503 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -701,7 +706,15 @@ private StandbyTask convertActiveToStandby(final

Re: [PR] KAFKA-15448: Streams Standby Update Listener (KIP-988) [kafka]

2023-11-29 Thread via GitHub
eduwercamacaro commented on code in PR #14735: URL: https://github.com/apache/kafka/pull/14735#discussion_r1409158503 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -701,7 +706,15 @@ private StandbyTask convertActiveToStandby(final

Re: [PR] KAFKA-15448: Streams Standby Update Listener (KIP-988) [kafka]

2023-11-29 Thread via GitHub
eduwercamacaro commented on code in PR #14735: URL: https://github.com/apache/kafka/pull/14735#discussion_r1409158503 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -701,7 +706,15 @@ private StandbyTask convertActiveToStandby(final

Re: [PR] KAFKA-15448: Streams Standby Update Listener (KIP-988) [kafka]

2023-11-29 Thread via GitHub
eduwercamacaro commented on code in PR #14735: URL: https://github.com/apache/kafka/pull/14735#discussion_r1409143192 ## streams/src/main/java/org/apache/kafka/streams/processor/StandbyUpdateListener.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KAFKA-15865: Remove autocommit completion event [kafka]

2023-11-29 Thread via GitHub
cadonna commented on PR #14831: URL: https://github.com/apache/kafka/pull/14831#issuecomment-1831690844 Yeah, the test was flaky before in PR builds but not on trunk [1]. Could you at least create a ticket for it? [1]

Re: [PR] KAFKA-14133: Migrate ProcessorStateManagerTest and StreamThreadTest to Mockito [kafka]

2023-11-29 Thread via GitHub
cadonna commented on code in PR #13932: URL: https://github.com/apache/kafka/pull/13932#discussion_r1409103748 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamThreadTest.java: ## @@ -3494,32 +3323,27 @@ private StreamThread setUpThread(final

Re: [PR] KAFKA-15886: Always specify directories for new partition registrations [kafka]

2023-11-29 Thread via GitHub
soarez commented on code in PR #14820: URL: https://github.com/apache/kafka/pull/14820#discussion_r1409089057 ## metadata/src/test/java/org/apache/kafka/metadata/util/MetadataFeatureUtil.java: ## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-14588 ConfigType moved to server-common [kafka]

2023-11-29 Thread via GitHub
nizhikov closed pull request #14866: KAFKA-14588 ConfigType moved to server-common URL: https://github.com/apache/kafka/pull/14866 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] KAFKA-14588 ConfigType moved to server-common [kafka]

2023-11-29 Thread via GitHub
nizhikov opened a new pull request, #14866: URL: https://github.com/apache/kafka/pull/14866 This is independent part of KAFKA-14588 Move ConfigCommand to tools. `ConfigCommand` depends on `ConfigType` class from `core` module. This PR moves `ConfigType` from `core` to

Re: [PR] Update NOTICE-binary with latest additions [kafka]

2023-11-29 Thread via GitHub
jlprat commented on PR #14865: URL: https://github.com/apache/kafka/pull/14865#issuecomment-1831610330 Merged this without the test run as this touched no source file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Update NOTICE-binary with latest additions [kafka]

2023-11-29 Thread via GitHub
jlprat merged PR #14865: URL: https://github.com/apache/kafka/pull/14865 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15887: Ensure FindCoordinatorRequest is sent before closing [kafka]

2023-11-29 Thread via GitHub
lucasbru merged PR #14842: URL: https://github.com/apache/kafka/pull/14842 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (KAFKA-15887) Autocommit during close consistently fails with exception in background thread

2023-11-29 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy resolved KAFKA-15887. Resolution: Fixed > Autocommit during close consistently fails with exception in

Re: [PR] MINOR: Update LICENSE-binary for 3.7.0 [kafka]

2023-11-29 Thread via GitHub
jlprat commented on PR #14833: URL: https://github.com/apache/kafka/pull/14833#issuecomment-1831603163 Created https://github.com/apache/kafka/pull/14865 for the `NOTICE-binary`. In the end, of the new dependencies, only `commons-io` had a `NOTICE`. -- This is an automated message from

Re: [PR] KAFKA-15887: Ensure FindCoordinatorRequest is sent before closing [kafka]

2023-11-29 Thread via GitHub
lucasbru commented on PR #14842: URL: https://github.com/apache/kafka/pull/14842#issuecomment-1831602145 Test failures unrelated and mapped to existing/new flaky test issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Update NOTICE-binary with latest additions [kafka]

2023-11-29 Thread via GitHub
jlprat commented on PR #14865: URL: https://github.com/apache/kafka/pull/14865#issuecomment-1831601617 ping @mimaison -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] Update NOTICE-binary with latest additions [kafka]

2023-11-29 Thread via GitHub
jlprat opened a new pull request, #14865: URL: https://github.com/apache/kafka/pull/14865 This change mirrors the updates in `LICENSE-binary` and updates the newly added dependencies' notice messages when available. - commons-io-2.11.0 (NOTICE available) -

[jira] [Created] (KAFKA-15930) Flaky test - testWithGroupId - TransactionsBounceTest

2023-11-29 Thread Lucas Brutschy (Jira)
Lucas Brutschy created KAFKA-15930: -- Summary: Flaky test - testWithGroupId - TransactionsBounceTest Key: KAFKA-15930 URL: https://issues.apache.org/jira/browse/KAFKA-15930 Project: Kafka

[jira] [Created] (KAFKA-15929) Flaky test - testDescribeUnderReplicatedPartitionsWhenReassignmentIsInProgress - TopicCommandIntegrationTest

2023-11-29 Thread Lucas Brutschy (Jira)
Lucas Brutschy created KAFKA-15929: -- Summary: Flaky test - testDescribeUnderReplicatedPartitionsWhenReassignmentIsInProgress - TopicCommandIntegrationTest Key: KAFKA-15929 URL:

[jira] [Created] (KAFKA-15928) Flaky test - testBalancePartitionLeaders - QuorumControllerTest

2023-11-29 Thread Lucas Brutschy (Jira)
Lucas Brutschy created KAFKA-15928: -- Summary: Flaky test - testBalancePartitionLeaders - QuorumControllerTest Key: KAFKA-15928 URL: https://issues.apache.org/jira/browse/KAFKA-15928 Project: Kafka

Re: [PR] MINOR: Update LICENSE-binary for 3.7.0 [kafka]

2023-11-29 Thread via GitHub
mimaison commented on PR #14833: URL: https://github.com/apache/kafka/pull/14833#issuecomment-1831577997 > We would need to update the NOTICE-binary as well (as there are a couple of new binaries). I'll get to it Ok, thanks! -- This is an automated message from the Apache Git Service.

<    1   2   3   >