dajac merged PR #15348:
URL: https://github.com/apache/kafka/pull/15348
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
joobisb commented on PR #13862:
URL: https://github.com/apache/kafka/pull/13862#issuecomment-1943171155
> @joobisb when I said
>
> > It works fine for me with `\`, using
both FF and a chrome-based browser.
>
> I meant that I still don't think we need the changes which add the
James created KAFKA-16252:
-
Summary: Maligned Metrics formatting
Key: KAFKA-16252
URL: https://issues.apache.org/jira/browse/KAFKA-16252
Project: Kafka
Issue Type: Bug
Components: documenta
github-actions[bot] commented on PR #14731:
URL: https://github.com/apache/kafka/pull/14731#issuecomment-1943032470
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
github-actions[bot] commented on PR #14765:
URL: https://github.com/apache/kafka/pull/14765#issuecomment-1943032448
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
mdedetrich commented on PR #15341:
URL: https://github.com/apache/kafka/pull/15341#issuecomment-1942974036
Thanks for the comments! I just realized that the PR can use additional
improvements, i.e. I can get rid of `KafkaEmbedded` since with KRaft you can
set up the entire Kafka cluster (i.
appchemist commented on PR #15245:
URL: https://github.com/apache/kafka/pull/15245#issuecomment-1942951119
Would you mind reviewing this? Alternatively, who would be the best person
to review this issue?
--
This is an automated message from the Apache Git Service.
To respond to the messag
jolshan commented on code in PR #15359:
URL: https://github.com/apache/kafka/pull/15359#discussion_r1488779741
##
metadata/src/main/java/org/apache/kafka/controller/PartitionReassignmentReplicas.java:
##
@@ -120,9 +120,7 @@ Optional
maybeCompleteReassignment(List targetIs
CalvinConfluent commented on code in PR #15359:
URL: https://github.com/apache/kafka/pull/15359#discussion_r1488779105
##
metadata/src/main/java/org/apache/kafka/controller/PartitionReassignmentReplicas.java:
##
@@ -120,9 +120,7 @@ Optional
maybeCompleteReassignment(List target
gharris1727 opened a new pull request, #15367:
URL: https://github.com/apache/kafka/pull/15367
The connect suppressions are more permissive than necessary, because
suppressions were added to the file and then not later removed. Most notably:
* #10299 removed the WithTopicCreation test
jolshan commented on code in PR #15359:
URL: https://github.com/apache/kafka/pull/15359#discussion_r1488762961
##
metadata/src/main/java/org/apache/kafka/controller/PartitionReassignmentReplicas.java:
##
@@ -120,9 +120,7 @@ Optional
maybeCompleteReassignment(List targetIs
jolshan commented on code in PR #15359:
URL: https://github.com/apache/kafka/pull/15359#discussion_r1488762961
##
metadata/src/main/java/org/apache/kafka/controller/PartitionReassignmentReplicas.java:
##
@@ -120,9 +120,7 @@ Optional
maybeCompleteReassignment(List targetIs
CalvinConfluent commented on code in PR #15359:
URL: https://github.com/apache/kafka/pull/15359#discussion_r1488746986
##
metadata/src/main/java/org/apache/kafka/controller/PartitionReassignmentReplicas.java:
##
@@ -120,9 +120,7 @@ Optional
maybeCompleteReassignment(List target
jolshan commented on code in PR #15359:
URL: https://github.com/apache/kafka/pull/15359#discussion_r1488713079
##
metadata/src/main/java/org/apache/kafka/controller/PartitionReassignmentReplicas.java:
##
@@ -120,9 +120,7 @@ Optional
maybeCompleteReassignment(List targetIs
jolshan merged PR #15354:
URL: https://github.com/apache/kafka/pull/15354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
jolshan commented on PR #15354:
URL: https://github.com/apache/kafka/pull/15354#issuecomment-1942725048
I will keep the JIRA open as we try to figure out the fix of the other
errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/KAFKA-16251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-16251:
---
Labels: client-transitions-issues kip-848-client-support (was:
kip-848-client-support)
> F
Lianet Magrans created KAFKA-16251:
--
Summary: Fenced member should not send heartbeats while waiting
for onPartitionsLost to complete
Key: KAFKA-16251
URL: https://issues.apache.org/jira/browse/KAFKA-16251
Calvin Liu created KAFKA-16250:
--
Summary: Consumer group coordinator should perform sanity check on
the offset commits.
Key: KAFKA-16250
URL: https://issues.apache.org/jira/browse/KAFKA-16250
Project: Ka
ahuang98 commented on PR #14206:
URL: https://github.com/apache/kafka/pull/14206#issuecomment-1942168244
@mimaison tagging you again just in case you have time to take a look
@mumrah I've added the logging change in the meantime - are we okay merging
in the next week if we don't get a res
[
https://issues.apache.org/jira/browse/KAFKA-14576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison resolved KAFKA-14576.
Fix Version/s: 3.8.0
Resolution: Fixed
> Move ConsoleConsumer to tools
> --
mimaison merged PR #15274:
URL: https://github.com/apache/kafka/pull/15274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
nizhikov commented on PR #14471:
URL: https://github.com/apache/kafka/pull/14471#issuecomment-1942139254
Hello @mimaison @jolshan @showuon
I open two PR's to move the rest of `ConsoleGroupCommand` tests to tools.
#15365 - pretty small (+200, -100)
#15363 - relatively big, bu
lucasbru merged PR #15362:
URL: https://github.com/apache/kafka/pull/15362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
ijuma commented on code in PR #15324:
URL: https://github.com/apache/kafka/pull/15324#discussion_r1488353336
##
storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java:
##
@@ -177,7 +177,7 @@ private void addProducerId(long producerId,
ProducerSta
nizhikov opened a new pull request, #15365:
URL: https://github.com/apache/kafka/pull/15365
This PR is part of https://github.com/apache/kafka/pull/14471
Is contains some of ConsoleGroupCommand tests rewritten in java.
Intention of separate PR is to reduce changes and simplify review.
jolshan commented on PR #15354:
URL: https://github.com/apache/kafka/pull/15354#issuecomment-1942115848
Ok -- I think in order to reduce the build failures we should merge this
change. My understanding is that this doesn't introduce new failures.
I also agree that it seems ok to make
mimaison commented on PR #15274:
URL: https://github.com/apache/kafka/pull/15274#issuecomment-1942090513
None of the test failures seem related, merging to trunk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/KAFKA-14822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison resolved KAFKA-14822.
Fix Version/s: 3.8.0
Assignee: Gantigmaa Selenge (was: Mickael Maison)
Res
[
https://issues.apache.org/jira/browse/KAFKA-14822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817089#comment-17817089
]
Mickael Maison commented on KAFKA-14822:
KIP-993:
https://cwiki.apache.org/conf
OmniaGM commented on PR #15354:
URL: https://github.com/apache/kafka/pull/15354#issuecomment-1942060678
> Is this reducing our test coverage of the default metadata.log.dir
configuration?
If we want to limited to `LogDirFailureTest` test only that's okay it will
properly have some duplic
mimaison merged PR #14995:
URL: https://github.com/apache/kafka/pull/14995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
mimaison commented on PR #14995:
URL: https://github.com/apache/kafka/pull/14995#issuecomment-1942058460
None of the test failures seem related, merging to trunk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
jolshan commented on code in PR #15324:
URL: https://github.com/apache/kafka/pull/15324#discussion_r1488290251
##
storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java:
##
@@ -177,7 +177,7 @@ private void addProducerId(long producerId,
ProducerS
hachikuji commented on code in PR #15323:
URL: https://github.com/apache/kafka/pull/15323#discussion_r1488286776
##
clients/src/main/java/org/apache/kafka/clients/Metadata.java:
##
@@ -124,14 +124,14 @@ public Metadata(long refreshBackoffMs,
* Get the current cluster info
gharris1727 commented on PR #15354:
URL: https://github.com/apache/kafka/pull/15354#issuecomment-1942030926
Does this make sense to change across every test suite, not just
LogDirFailureTest?
Is this reducing our test coverage of the default metadata.log.dir
configuration?
Is a separa
ijuma commented on code in PR #15324:
URL: https://github.com/apache/kafka/pull/15324#discussion_r1488125293
##
storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java:
##
@@ -177,7 +177,7 @@ private void addProducerId(long producerId,
ProducerSta
ijuma commented on code in PR #15324:
URL: https://github.com/apache/kafka/pull/15324#discussion_r1488125293
##
storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java:
##
@@ -177,7 +177,7 @@ private void addProducerId(long producerId,
ProducerSta
dajac closed pull request #14673: KAFKA-15763; Group Coordinator should not
deliver new assignment before previous one is acknowledged
URL: https://github.com/apache/kafka/pull/14673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
dajac opened a new pull request, #15364:
URL: https://github.com/apache/kafka/pull/15364
TODO
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upg
David Jacot created KAFKA-16249:
---
Summary: Improve reconciliation state machine
Key: KAFKA-16249
URL: https://issues.apache.org/jira/browse/KAFKA-16249
Project: Kafka
Issue Type: Sub-task
nizhikov opened a new pull request, #15363:
URL: https://github.com/apache/kafka/pull/15363
This PR is part of #14471
Is contains some of `ConsoleGroupCommand` tests rewritten in java.
Intention of separate PR is to reduce changes and simplify review.
### Committer Checklist (ex
OmniaGM commented on PR #15354:
URL: https://github.com/apache/kafka/pull/15354#issuecomment-1941616164
What I noticed locally that `testIOExceptionDuringCheckpoint` still flaky
because the test try to offline log dir before
`highWatermarkCheckPointThreadStarted` create the high watermark
OmniaGM commented on PR #15354:
URL: https://github.com/apache/kafka/pull/15354#issuecomment-1941610996
> I still see one LogDirFailureTest failure:
>
> ```
> org.apache.kafka.server.fault.FaultHandlerException:
quorumTestHarnessFaultHandler: Error applying topics delta in Metadata
[
https://issues.apache.org/jira/browse/KAFKA-16246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison updated KAFKA-16246:
---
Priority: Minor (was: Major)
> Cleanups in ConsoleConsumer
> ---
>
[
https://issues.apache.org/jira/browse/KAFKA-16247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817015#comment-17817015
]
Mickael Maison commented on KAFKA-16247:
[~mumrah] Any idea what could be happen
[
https://issues.apache.org/jira/browse/KAFKA-16247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817013#comment-17817013
]
Mickael Maison commented on KAFKA-16247:
I attached the full broker and controll
[
https://issues.apache.org/jira/browse/KAFKA-16247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison updated KAFKA-16247:
---
Attachment: KAFKA-16247.zip
> replica keep out-of-sync after migrating broker to KRaft
> ---
lucasbru commented on PR #15362:
URL: https://github.com/apache/kafka/pull/15362#issuecomment-1941558692
> Thanks @lucasbru. I wonder if we could add a unit test for it. Is it
possible?
@dajac I added a little unit tests that fails without the fix
--
This is an automated message fr
mimaison commented on PR #15293:
URL: https://github.com/apache/kafka/pull/15293#issuecomment-1941526722
Can we close https://issues.apache.org/jira/browse/KAFKA-16180 now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
[
https://issues.apache.org/jira/browse/KAFKA-16247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison updated KAFKA-16247:
---
Affects Version/s: 3.7.0
> replica keep out-of-sync after migrating broker to KRaft
> --
dajac commented on PR #15362:
URL: https://github.com/apache/kafka/pull/15362#issuecomment-1941515998
Thanks @lucasbru. I wonder if we could add a unit test for it. Is it
possible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
[
https://issues.apache.org/jira/browse/KAFKA-16248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy updated KAFKA-16248:
---
Priority: Critical (was: Major)
> Kafka consumer should cache leader offset ranges
> --
[
https://issues.apache.org/jira/browse/KAFKA-16248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy updated KAFKA-16248:
---
Description:
We noticed a streams application received an OFFSET_OUT_OF_RANGE error
followi
[
https://issues.apache.org/jira/browse/KAFKA-15344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy updated KAFKA-15344:
---
Description:
We noticed an application received an OFFSET_OUT_OF_RANGE error following a
ne
Lucas Brutschy created KAFKA-16248:
--
Summary: Kafka consumer should cache leader offset ranges
Key: KAFKA-16248
URL: https://issues.apache.org/jira/browse/KAFKA-16248
Project: Kafka
Issue Ty
Luke Chen created KAFKA-16247:
-
Summary: 1 replica keep out-of-sync after migrating broker to KRaft
Key: KAFKA-16247
URL: https://issues.apache.org/jira/browse/KAFKA-16247
Project: Kafka
Issue Ty
[
https://issues.apache.org/jira/browse/KAFKA-16247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-16247:
--
Summary: replica keep out-of-sync after migrating broker to KRaft (was: 1
replica keep out-of-sync af
lucasbru opened a new pull request, #15362:
URL: https://github.com/apache/kafka/pull/15362
When the consumer enters state LEAVING, it sets the epoch to the leave
epoch, such as -1. When the timing is right, we may get a heartbeat response
after entering the state LEAVING, which resets the
mimaison commented on PR #15274:
URL: https://github.com/apache/kafka/pull/15274#issuecomment-1941396381
Thanks @OmniaGM !
I created https://issues.apache.org/jira/browse/KAFKA-16246 to track the
follow up refactoring work.
--
This is an automated message from the Apache Git Service.
T
Mickael Maison created KAFKA-16246:
--
Summary: Cleanups in ConsoleConsumer
Key: KAFKA-16246
URL: https://issues.apache.org/jira/browse/KAFKA-16246
Project: Kafka
Issue Type: Improvement
msn-tldr commented on code in PR #15323:
URL: https://github.com/apache/kafka/pull/15323#discussion_r1487739946
##
clients/src/test/java/org/apache/kafka/test/TestUtils.java:
##
@@ -123,6 +126,34 @@ public static Cluster clusterWith(final int nodes, final
String topic, final in
msn-tldr commented on code in PR #15323:
URL: https://github.com/apache/kafka/pull/15323#discussion_r1487728160
##
clients/src/main/java/org/apache/kafka/clients/MetadataCache.java:
##
@@ -39,8 +39,9 @@
import java.util.stream.Collectors;
/**
- * An internal mutable cache of
mimaison commented on PR #15274:
URL: https://github.com/apache/kafka/pull/15274#issuecomment-1941348640
@OmniaGM do you want to take another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Phuc-Hong-Tran commented on PR #15188:
URL: https://github.com/apache/kafka/pull/15188#issuecomment-1941295224
> > @cadonna @lianetm, since we're supporting for both subscribe method
using java.util.regex.Pattern and SubscriptionPattern, I think we should throw
a illegal heartbeat exeption
nizhikov commented on PR #14320:
URL: https://github.com/apache/kafka/pull/14320#issuecomment-1941286538
Hello @showuon
I struggle with `SslAdminIntegrationTest` failures.
This test count socket threads and fails on unexpected count:
I fixed `DeleteTopicTest` that don't invo
Phuc-Hong-Tran commented on PR #15188:
URL: https://github.com/apache/kafka/pull/15188#issuecomment-1941284769
@cadonna, sorry for the delay. I'll push the changes tomorrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Phuc-Hong-Tran commented on PR #15188:
URL: https://github.com/apache/kafka/pull/15188#issuecomment-1941283018
@lianetm thanks for the reply. I was more wondering about the testing
strategy of the new subscribe(SubscriptionPattern) method when it comes to
receiving the assignment, since tha
mimaison commented on code in PR #15274:
URL: https://github.com/apache/kafka/pull/15274#discussion_r1487675184
##
tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumerOptions.java:
##
@@ -238,7 +237,8 @@ private Set checkConsumerGroup(Properties
consumerPropsFrom
showuon commented on PR #14320:
URL: https://github.com/apache/kafka/pull/14320#issuecomment-1941279651
@jolshan , I think this has been fixed thanks to @nizhikov in this PR:
https://github.com/apache/kafka/pull/15256
latest trunk build:
https://ci-builds.apache.org/job/Kafka/job/kaf
cadonna commented on PR #15188:
URL: https://github.com/apache/kafka/pull/15188#issuecomment-1941278766
@Phuc-Hong-Tran Could you please implement the changes that I requested so
that we can move on?
--
This is an automated message from the Apache Git Service.
To respond to the message, p
jlprat commented on code in PR #15274:
URL: https://github.com/apache/kafka/pull/15274#discussion_r1487661551
##
tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumerOptions.java:
##
@@ -238,7 +237,8 @@ private Set checkConsumerGroup(Properties
consumerPropsFromFi
cadonna commented on PR #15188:
URL: https://github.com/apache/kafka/pull/15188#issuecomment-1941264974
> I could be missing something, but I would say we don't need any changes
for the part where the client receives the assignment from the broker after
subscribing to a regex. It should be
cadonna commented on PR #15188:
URL: https://github.com/apache/kafka/pull/15188#issuecomment-1941258118
> @cadonna @lianetm, since we're supporting for both subscribe method using
java.util.regex.Pattern and SubscriptionPattern, I think we should throw a
illegal heartbeat exeption when user
nicktelford commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1487649620
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -1836,6 +1842,36 @@ public void
maybeThrowTaskExceptionsFromProcessin
divijvaidya commented on PR #15353:
URL: https://github.com/apache/kafka/pull/15353#issuecomment-1941239771
I have verified that the test modified is passing in CI -
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15353/1/testReport/kafka.server/FetchFromFollowerIntegrationTest/
divijvaidya merged PR #15353:
URL: https://github.com/apache/kafka/pull/15353
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apa
mimaison commented on PR #15274:
URL: https://github.com/apache/kafka/pull/15274#issuecomment-1941235786
I rebased on trunk to resolve conflicts. It seems my last fix has resolved
the issues with the system tests so it is ready to review again.
--
This is an automated message from the Apa
AyoubOm opened a new pull request, #15361:
URL: https://github.com/apache/kafka/pull/15361
Global state stores are currently flushed at each commit, which may impact
performance, especially for EOS (commit each 200ms).
The goal of this improvement is to flush global state stores only when
cadonna commented on code in PR #15334:
URL: https://github.com/apache/kafka/pull/15334#discussion_r1487471412
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -1378,6 +1377,14 @@ class PlaintextConsumerTest extends BaseConsumerTest {
// after
chirag-wadhwa5 closed pull request #15360: Akcore 10: Add unit tests for
KafkaAdminClient.listShareGroups
URL: https://github.com/apache/kafka/pull/15360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
chirag-wadhwa5 opened a new pull request, #15360:
URL: https://github.com/apache/kafka/pull/15360
About -
This PR adds the following 3 unit tests for KafkaAdminClient.listShareGroups
-
- testListShareGroups
- testListShareGroupsMetadataFailure
- testListShareGroupsWithStates
nizhikov commented on PR #15216:
URL: https://github.com/apache/kafka/pull/15216#issuecomment-1940771761
@lucasbru No worries. I wanted to make it clear that class removed by
mistake and didn't broke something.
Will return it in the next PR regarding `Console Group Command`.
--
This is
lucasbru commented on PR #15216:
URL: https://github.com/apache/kafka/pull/15216#issuecomment-1940762063
@nizhikov Sorry, during review I thought @philipnee removed a left-over
class from an earlier PR also called `GroupState`.
https://github.com/apache/kafka/blob/6e164bb9ace3ea7a1a9542904d
84 matches
Mail list logo
