Re: [PR] KAFKA-15206: Fix the flaky RemoteIndexCacheTest.testClose test [kafka]

2024-03-13 Thread via GitHub
kamalcph commented on PR #15523: URL: https://github.com/apache/kafka/pull/15523#issuecomment-1996675858 Thanks for the review! > If the cleaner thread wasn't even started, are our really testing correct behaviour? For example, when we validate that cleaner shouldn't have deleted som

Re: [PR] KAFKA-16352: Txn may get get stuck in PrepareCommit or PrepareAbort s… [kafka]

2024-03-13 Thread via GitHub
artemlivshits commented on code in PR #15524: URL: https://github.com/apache/kafka/pull/15524#discussion_r1524022035 ## core/src/main/scala/kafka/coordinator/transaction/TransactionMarkerChannelManager.scala: ## @@ -109,23 +109,30 @@ object TransactionMarkerChannelManager { }

Re: [PR] MINOR: Kafka Streams docs fixes [kafka]

2024-03-13 Thread via GitHub
mjsax merged PR #15517: URL: https://github.com/apache/kafka/pull/15517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] MINOR: simplify consumer logic [kafka]

2024-03-13 Thread via GitHub
mjsax merged PR #15519: URL: https://github.com/apache/kafka/pull/15519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-15302: Stale value returned when using store.all() with key deletion [docs] [kafka]

2024-03-13 Thread via GitHub
mjsax commented on code in PR #15495: URL: https://github.com/apache/kafka/pull/15495#discussion_r1524038413 ## docs/streams/developer-guide/memory-mgmt.html: ## @@ -151,6 +151,10 @@ Serdes.Long()) .withCachingEnabled(); Record caches are not supported for version

Re: [PR] MINOR: Fix descriptions of raft-metrics in docs/ops.html [kafka]

2024-03-13 Thread via GitHub
github-actions[bot] commented on PR #14973: URL: https://github.com/apache/kafka/pull/14973#issuecomment-1996325738 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

Re: [PR] Fix so that a partition is retained, if the another parititon on same… [kafka]

2024-03-13 Thread via GitHub
github-actions[bot] commented on PR #15019: URL: https://github.com/apache/kafka/pull/15019#issuecomment-1996325711 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

Re: [PR] MINOR: Cleanup BoundedList to Make Constructors More Safe [kafka]

2024-03-13 Thread via GitHub
ChrisAHolland commented on code in PR #15507: URL: https://github.com/apache/kafka/pull/15507#discussion_r1524147955 ## server-common/src/main/java/org/apache/kafka/server/mutable/BoundedList.java: ## @@ -35,24 +35,12 @@ public class BoundedList implements List { private fi

Re: [PR] MINOR: Cleanup BoundedList to Make Constructors More Safe [kafka]

2024-03-13 Thread via GitHub
ChrisAHolland commented on code in PR #15507: URL: https://github.com/apache/kafka/pull/15507#discussion_r1524143322 ## server-common/src/main/java/org/apache/kafka/server/mutable/BoundedList.java: ## @@ -35,24 +35,12 @@ public class BoundedList implements List { private fi

Re: [PR] MINOR: Cleanup BoundedList to Make Constructors More Safe [kafka]

2024-03-13 Thread via GitHub
chia7712 commented on code in PR #15507: URL: https://github.com/apache/kafka/pull/15507#discussion_r1524140865 ## server-common/src/main/java/org/apache/kafka/server/mutable/BoundedList.java: ## @@ -35,24 +35,12 @@ public class BoundedList implements List { private final i

Re: [PR] MINOR: Cleanup BoundedList to Make Constructors More Safe [kafka]

2024-03-13 Thread via GitHub
ChrisAHolland commented on PR #15507: URL: https://github.com/apache/kafka/pull/15507#issuecomment-1996246082 @chia7712 @jolshan Pushed an update based on discussion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] MINOR: Cleanup BoundedList to Make Constructors More Safe [kafka]

2024-03-13 Thread via GitHub
ChrisAHolland commented on code in PR #15507: URL: https://github.com/apache/kafka/pull/15507#discussion_r1524100301 ## server-common/src/main/java/org/apache/kafka/server/mutable/BoundedList.java: ## @@ -35,24 +35,12 @@ public class BoundedList implements List { private fi

Re: [PR] MINOR: Cleanup BoundedList to Make Constructors More Safe [kafka]

2024-03-13 Thread via GitHub
chia7712 commented on code in PR #15507: URL: https://github.com/apache/kafka/pull/15507#discussion_r1524078277 ## server-common/src/main/java/org/apache/kafka/server/mutable/BoundedList.java: ## @@ -35,24 +35,12 @@ public class BoundedList implements List { private final i

Re: [PR] MINOR: Cleanup BoundedList to Make Constructors More Safe [kafka]

2024-03-13 Thread via GitHub
ChrisAHolland commented on code in PR #15507: URL: https://github.com/apache/kafka/pull/15507#discussion_r1524075123 ## server-common/src/main/java/org/apache/kafka/server/mutable/BoundedList.java: ## @@ -35,24 +35,12 @@ public class BoundedList implements List { private fi

Re: [PR] MINOR: Cleanup BoundedList to Make Constructors More Safe [kafka]

2024-03-13 Thread via GitHub
ChrisAHolland commented on code in PR #15507: URL: https://github.com/apache/kafka/pull/15507#discussion_r1524073993 ## server-common/src/main/java/org/apache/kafka/server/mutable/BoundedList.java: ## @@ -35,24 +35,12 @@ public class BoundedList implements List { private fi

Re: [PR] MINOR: Cleanup BoundedList to Make Constructors More Safe [kafka]

2024-03-13 Thread via GitHub
jolshan commented on code in PR #15507: URL: https://github.com/apache/kafka/pull/15507#discussion_r1524070820 ## server-common/src/main/java/org/apache/kafka/server/mutable/BoundedList.java: ## @@ -35,24 +35,12 @@ public class BoundedList implements List { private final in

Re: [PR] MINOR: Cleanup BoundedList to Make Constructors More Safe [kafka]

2024-03-13 Thread via GitHub
jolshan commented on code in PR #15507: URL: https://github.com/apache/kafka/pull/15507#discussion_r1524069898 ## server-common/src/main/java/org/apache/kafka/server/mutable/BoundedList.java: ## @@ -35,24 +35,12 @@ public class BoundedList implements List { private final in

Re: [PR] KAFKA-16342: fix getOffsetByMaxTimestamp for compressed records [kafka]

2024-03-13 Thread via GitHub
showuon commented on code in PR #15474: URL: https://github.com/apache/kafka/pull/15474#discussion_r1524067155 ## core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala: ## @@ -19,82 +19,236 @@ package kafka.admin import kafka.integration.KafkaServerTest

Re: [PR] KAFKA-16342: fix getOffsetByMaxTimestamp for compressed records [kafka]

2024-03-13 Thread via GitHub
showuon commented on code in PR #15474: URL: https://github.com/apache/kafka/pull/15474#discussion_r1524067155 ## core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala: ## @@ -19,82 +19,236 @@ package kafka.admin import kafka.integration.KafkaServerTest

Re: [PR] MINOR: Cleanup BoundedList to Make Constructors More Safe [kafka]

2024-03-13 Thread via GitHub
chia7712 commented on code in PR #15507: URL: https://github.com/apache/kafka/pull/15507#discussion_r1524061026 ## server-common/src/main/java/org/apache/kafka/server/mutable/BoundedList.java: ## @@ -35,24 +35,12 @@ public class BoundedList implements List { private final i

Re: [PR] MINOR: Cleanup BoundedList to Make Constructors More Safe [kafka]

2024-03-13 Thread via GitHub
chia7712 commented on code in PR #15507: URL: https://github.com/apache/kafka/pull/15507#discussion_r1524056640 ## server-common/src/main/java/org/apache/kafka/server/mutable/BoundedList.java: ## @@ -35,24 +35,12 @@ public class BoundedList implements List { private final i

Re: [PR] KAFKA-16123: KStreamKStreamJoinProcessor does not drop late records. [kafka]

2024-03-13 Thread via GitHub
mjsax commented on code in PR #15189: URL: https://github.com/apache/kafka/pull/15189#discussion_r1524044954 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamWindowCloseTest.java: ## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] MINOR; Missing minISR config should log a debug message [kafka]

2024-03-13 Thread via GitHub
CalvinConfluent commented on code in PR #15529: URL: https://github.com/apache/kafka/pull/15529#discussion_r1523997343 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -2189,7 +2189,7 @@ int getTopicEffectiveMinIsr(String topicName) {

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

2024-03-13 Thread via GitHub
artemlivshits commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1523996339 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2185,9 +2179,144 @@ void handleFailure(Throwable throwable) {

[jira] [Commented] (KAFKA-16359) kafka-clients-3.7.0.jar published to Maven Central is defective

2024-03-13 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17826885#comment-17826885 ] Apoorv Mittal commented on KAFKA-16359: --- [~ijuma] here is the fix [https://github.

[PR] KAFKA-16359: Corrected manifest file for kafka-clients [kafka]

2024-03-13 Thread via GitHub
apoorvmittal10 opened a new pull request, #15532: URL: https://github.com/apache/kafka/pull/15532 The issue [KAFKA-16359](https://issues.apache.org/jira/browse/KAFKA-16359) reported inclusion of `kafka-clients` runtime dependencies in MANIFEST.MF `Class-Path`. The root cause is the i

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

2024-03-13 Thread via GitHub
CalvinConfluent commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1523971792 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2184,9 +2178,139 @@ void handleFailure(Throwable throwable) {

Re: [PR] MINOR; Log reason for deleting a kraft snapshot [kafka]

2024-03-13 Thread via GitHub
jsancio commented on code in PR #15478: URL: https://github.com/apache/kafka/pull/15478#discussion_r1523954492 ## core/src/main/scala/kafka/raft/KafkaMetadataLog.scala: ## @@ -348,14 +357,15 @@ final class KafkaMetadataLog private ( snapshotId.offset <= latestSnapshot

Re: [PR] MINOR; Log reason for deleting a kraft snapshot [kafka]

2024-03-13 Thread via GitHub
jsancio commented on code in PR #15478: URL: https://github.com/apache/kafka/pull/15478#discussion_r1523951275 ## core/src/main/scala/kafka/raft/KafkaMetadataLog.scala: ## @@ -404,21 +414,33 @@ final class KafkaMetadataLog private ( * all cases. * * For the given pre

Re: [PR] MINOR; Make string from array [kafka]

2024-03-13 Thread via GitHub
jsancio merged PR #15526: URL: https://github.com/apache/kafka/pull/15526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-16352: Txn may get get stuck in PrepareCommit or PrepareAbort s… [kafka]

2024-03-13 Thread via GitHub
jolshan commented on code in PR #15524: URL: https://github.com/apache/kafka/pull/15524#discussion_r1523937621 ## core/src/main/scala/kafka/coordinator/transaction/TransactionStateManager.scala: ## @@ -557,6 +557,7 @@ class TransactionStateManager(brokerId: Int, loadi

Re: [PR] KAFKA-16352: Txn may get get stuck in PrepareCommit or PrepareAbort s… [kafka]

2024-03-13 Thread via GitHub
jolshan commented on code in PR #15524: URL: https://github.com/apache/kafka/pull/15524#discussion_r1523936892 ## core/src/main/scala/kafka/coordinator/transaction/TransactionMarkerRequestCompletionHandler.scala: ## @@ -90,9 +90,10 @@ class TransactionMarkerRequestCompletionHand

Re: [PR] KAFKA-16352: Txn may get get stuck in PrepareCommit or PrepareAbort s… [kafka]

2024-03-13 Thread via GitHub
jolshan commented on code in PR #15524: URL: https://github.com/apache/kafka/pull/15524#discussion_r1523931941 ## core/src/main/scala/kafka/coordinator/transaction/TransactionMarkerRequestCompletionHandler.scala: ## @@ -39,22 +39,23 @@ class TransactionMarkerRequestCompletionHan

Re: [PR] KAFKA-16312, KAFKA-16185: Local epochs in reconciliation [kafka]

2024-03-13 Thread via GitHub
lianetm commented on PR #15511: URL: https://github.com/apache/kafka/pull/15511#issuecomment-1995835817 hey @lucasbru, I took another full pass, left a few comments. Thanks for the changes! -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] KAFKA-16352: Txn may get get stuck in PrepareCommit or PrepareAbort s… [kafka]

2024-03-13 Thread via GitHub
jolshan commented on code in PR #15524: URL: https://github.com/apache/kafka/pull/15524#discussion_r1523916766 ## core/src/main/scala/kafka/coordinator/transaction/TransactionMarkerChannelManager.scala: ## @@ -419,25 +432,34 @@ class TransactionMarkerChannelManager( def rem

Re: [PR] KAFKA-16312, KAFKA-16185: Local epochs in reconciliation [kafka]

2024-03-13 Thread via GitHub
lianetm commented on code in PR #15511: URL: https://github.com/apache/kafka/pull/15511#discussion_r1523858796 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -889,43 +914,36 @@ private void transitionToStale() { */

Re: [PR] MINOR: Cleanup BoundedList to Make Constructors More Safe [kafka]

2024-03-13 Thread via GitHub
ChrisAHolland commented on code in PR #15507: URL: https://github.com/apache/kafka/pull/15507#discussion_r1523909237 ## server-common/src/main/java/org/apache/kafka/server/mutable/BoundedList.java: ## @@ -35,24 +35,12 @@ public class BoundedList implements List { private fi

Re: [PR] MINOR: Cleanup BoundedList to Make Constructors More Safe [kafka]

2024-03-13 Thread via GitHub
ChrisAHolland commented on code in PR #15507: URL: https://github.com/apache/kafka/pull/15507#discussion_r1523907637 ## server-common/src/main/java/org/apache/kafka/server/mutable/BoundedList.java: ## @@ -35,24 +35,12 @@ public class BoundedList implements List { private fi

Re: [PR] KAFKA-16352: Txn may get get stuck in PrepareCommit or PrepareAbort s… [kafka]

2024-03-13 Thread via GitHub
jolshan commented on code in PR #15524: URL: https://github.com/apache/kafka/pull/15524#discussion_r1523907297 ## core/src/main/scala/kafka/coordinator/transaction/TransactionMarkerChannelManager.scala: ## @@ -109,23 +109,30 @@ object TransactionMarkerChannelManager { } -cl

Re: [PR] KAFKA-16312, KAFKA-16185: Local epochs in reconciliation [kafka]

2024-03-13 Thread via GitHub
lianetm commented on code in PR #15511: URL: https://github.com/apache/kafka/pull/15511#discussion_r1523903844 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java: ## @@ -1952,19 +1942,22 @@ private void assertStaleMemberLeavesGro

Re: [PR] KAFKA-16312, KAFKA-16185: Local epochs in reconciliation [kafka]

2024-03-13 Thread via GitHub
lianetm commented on code in PR #15511: URL: https://github.com/apache/kafka/pull/15511#discussion_r1523885245 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -529,25 +530,18 @@ public ConsumerGroupHeartbeatRequestData bu

Re: [PR] KAFKA-16312, KAFKA-16185: Local epochs in reconciliation [kafka]

2024-03-13 Thread via GitHub
lianetm commented on code in PR #15511: URL: https://github.com/apache/kafka/pull/15511#discussion_r1523863939 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java: ## @@ -683,7 +681,10 @@ public void testDelayedMetadataUsedToComple

Re: [PR] KAFKA-16312, KAFKA-16185: Local epochs in reconciliation [kafka]

2024-03-13 Thread via GitHub
lianetm commented on code in PR #15511: URL: https://github.com/apache/kafka/pull/15511#discussion_r1523880045 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -508,9 +508,30 @@ private void processAssignmentReceived(Consume

Re: [PR] KAFKA-16312, KAFKA-16185: Local epochs in reconciliation [kafka]

2024-03-13 Thread via GitHub
lianetm commented on code in PR #15511: URL: https://github.com/apache/kafka/pull/15511#discussion_r1523863939 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java: ## @@ -683,7 +681,10 @@ public void testDelayedMetadataUsedToComple

Re: [PR] KAFKA-16312, KAFKA-16185: Local epochs in reconciliation [kafka]

2024-03-13 Thread via GitHub
lianetm commented on code in PR #15511: URL: https://github.com/apache/kafka/pull/15511#discussion_r1523858796 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -889,43 +914,36 @@ private void transitionToStale() { */

[PR] MINOR: Change link to deprecated class to substitute class [kafka]

2024-03-13 Thread via GitHub
cadonna opened a new pull request, #15531: URL: https://github.com/apache/kafka/pull/15531 The docs for Interactive Queries contain a link to deprecated class StreamsMetadata in package org.apache.kafka.streams.state [1]. This commit changed that link to class StreamsMetadata in packa

Re: [PR] KAFKA-14683 Cleanup WorkerSinkTaskTest [kafka]

2024-03-13 Thread via GitHub
OmniaGM commented on code in PR #15506: URL: https://github.com/apache/kafka/pull/15506#discussion_r1523840166 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.java: ## @@ -1215,17 +1195,13 @@ public void testSuppressCloseErrors() {

[jira] [Commented] (KAFKA-15538) Client support for java regex based subscription

2024-03-13 Thread Phuc Hong Tran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17826844#comment-17826844 ] Phuc Hong Tran commented on KAFKA-15538: [~lianetm] Sorry for the delay, I’ll tr

Re: [PR] KAFKA-15417 Sloppy bug: moved the outerJounBreak-flags out of the loop [kafka]

2024-03-13 Thread via GitHub
mjsax commented on code in PR #15510: URL: https://github.com/apache/kafka/pull/15510#discussion_r1523802443 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java: ## @@ -223,9 +223,9 @@ private void emitNonJoinedOuterRecords( t

Re: [PR] MINOR: Kafka Streams docs fixes [kafka]

2024-03-13 Thread via GitHub
mjsax commented on code in PR #15517: URL: https://github.com/apache/kafka/pull/15517#discussion_r1523775722 ## docs/streams/developer-guide/config-streams.html: ## @@ -97,6 +97,7 @@ Naming Default Values + Default Values

Re: [PR] KAFKA-16242: Mark slowest and most flaky tests as integration tests [kafka]

2024-03-13 Thread via GitHub
gharris1727 commented on PR #15349: URL: https://github.com/apache/kafka/pull/15349#issuecomment-1995368843 @ijuma @mumrah @dajac @C0urante I'm still interested in having this change implemented, independent of hooking it into the CI build. PTAL, Thanks! -- This is an automated message fr

[jira] [Commented] (KAFKA-16369) Broker may not shut down when SocketServer fails to bind as Address already in use

2024-03-13 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17826827#comment-17826827 ] Edoardo Comar commented on KAFKA-16369: --- KafkaServer (ZKMode) needs to wait on the

Re: [PR] MINOR: Resolve SslContextFactory method deprecations [kafka]

2024-03-13 Thread via GitHub
gharris1727 merged PR #15468: URL: https://github.com/apache/kafka/pull/15468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

[PR] KAFKA-16369: Broker may not shut down when SocketServer fails to bind as Address already in use [kafka]

2024-03-13 Thread via GitHub
edoardocomar opened a new pull request, #15530: URL: https://github.com/apache/kafka/pull/15530 Add a Wait for all the SocketServer ports to be open, and the Acceptors to be started The BrokerServer (KRaft mode) had such a wait, which was missing from the KafkaServer (ZK mode). --

Re: [PR] MINOR: Resolve SslContextFactory method deprecations [kafka]

2024-03-13 Thread via GitHub
gharris1727 commented on PR #15468: URL: https://github.com/apache/kafka/pull/15468#issuecomment-1995349571 Test failures appear unrelated, and the connect tests pass for me locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] KAFKA-16312, KAFKA-16185: Local epochs in reconciliation [kafka]

2024-03-13 Thread via GitHub
lianetm commented on code in PR #15511: URL: https://github.com/apache/kafka/pull/15511#discussion_r1523734711 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1497,4 +1502,93 @@ public PollResult poll(final long currentTime

Re: [PR] KAFKA-16352: Txn may get get stuck in PrepareCommit or PrepareAbort s… [kafka]

2024-03-13 Thread via GitHub
jolshan commented on code in PR #15524: URL: https://github.com/apache/kafka/pull/15524#discussion_r1523732734 ## core/src/main/scala/kafka/coordinator/transaction/TransactionMarkerChannelManager.scala: ## @@ -109,23 +109,30 @@ object TransactionMarkerChannelManager { } -cl

Re: [PR] KAFKA-16314: Introducing the AbortableTransactionException [kafka]

2024-03-13 Thread via GitHub
jolshan commented on code in PR #15486: URL: https://github.com/apache/kafka/pull/15486#discussion_r1523717757 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -1504,6 +1507,8 @@ public void handleResponse(AbstractResponse respo

Re: [PR] KAFKA-16314: Introducing the AbortableTransactionException [kafka]

2024-03-13 Thread via GitHub
jolshan commented on code in PR #15486: URL: https://github.com/apache/kafka/pull/15486#discussion_r1523717757 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -1504,6 +1507,8 @@ public void handleResponse(AbstractResponse respo

Re: [PR] KAFKA-16314: Introducing the AbortableTransactionException [kafka]

2024-03-13 Thread via GitHub
CalvinConfluent commented on code in PR #15486: URL: https://github.com/apache/kafka/pull/15486#discussion_r1523705762 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -1504,6 +1507,8 @@ public void handleResponse(AbstractRespon

Re: [PR] KAFKA-16312, KAFKA-16185: Local epochs in reconciliation [kafka]

2024-03-13 Thread via GitHub
lianetm commented on code in PR #15511: URL: https://github.com/apache/kafka/pull/15511#discussion_r1523709384 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -530,19 +530,12 @@ public ConsumerGroupHeartbeatRequestData bu

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

2024-03-13 Thread via GitHub
artemlivshits commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1523702932 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2184,9 +2178,139 @@ void handleFailure(Throwable throwable) {

[jira] [Assigned] (KAFKA-16369) Broker may not shut down when SocketServer fails to bind as Address already in use

2024-03-13 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edoardo Comar reassigned KAFKA-16369: - Assignee: Edoardo Comar > Broker may not shut down when SocketServer fails to bind as A

[jira] [Updated] (KAFKA-16369) Broker may not shut down when SocketServer fails to bind as Address already in use

2024-03-13 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edoardo Comar updated KAFKA-16369: -- Attachment: server.log kraft-server.log > Broker may not shut down when Socket

[jira] [Commented] (KAFKA-16369) Broker may not shut down when SocketServer fails to bind as Address already in use

2024-03-13 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17826811#comment-17826811 ] Edoardo Comar commented on KAFKA-16369: --- server logs as broker only (zk mode) and

[jira] [Comment Edited] (KAFKA-16369) Broker may not shut down when SocketServer fails to bind as Address already in use

2024-03-13 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17826811#comment-17826811 ] Edoardo Comar edited comment on KAFKA-16369 at 3/13/24 5:50 PM: --

[jira] [Created] (KAFKA-16369) Broker may not shut down when SocketServer fails to bind as Address already in use

2024-03-13 Thread Edoardo Comar (Jira)
Edoardo Comar created KAFKA-16369: - Summary: Broker may not shut down when SocketServer fails to bind as Address already in use Key: KAFKA-16369 URL: https://issues.apache.org/jira/browse/KAFKA-16369

Re: [PR] KAFKA-16341: fix the LogValidator for non-compressed type [kafka]

2024-03-13 Thread via GitHub
junrao commented on code in PR #15476: URL: https://github.com/apache/kafka/pull/15476#discussion_r1523677272 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogValidator.java: ## @@ -293,11 +293,11 @@ public ValidationResult assignOffsetsNonCompressed(LongRef o

Re: [PR] KAFKA-14683 Cleanup WorkerSinkTaskTest [kafka]

2024-03-13 Thread via GitHub
chia7712 commented on code in PR #15506: URL: https://github.com/apache/kafka/pull/15506#discussion_r1523669497 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.java: ## @@ -1215,17 +1195,13 @@ public void testSuppressCloseErrors() {

Re: [PR] MINOR: Cleanup BoundedList to Make Constructors More Safe [kafka]

2024-03-13 Thread via GitHub
chia7712 commented on code in PR #15507: URL: https://github.com/apache/kafka/pull/15507#discussion_r1523656781 ## server-common/src/main/java/org/apache/kafka/server/mutable/BoundedList.java: ## @@ -35,24 +35,12 @@ public class BoundedList implements List { private final i

Re: [PR] Minor: downgrade the minISR warning to debug [kafka]

2024-03-13 Thread via GitHub
jsancio commented on code in PR #15529: URL: https://github.com/apache/kafka/pull/15529#discussion_r1523660494 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -2189,7 +2189,7 @@ int getTopicEffectiveMinIsr(String topicName) {

Re: [PR] KAFKA-16342: fix getOffsetByMaxTimestamp for compressed records [kafka]

2024-03-13 Thread via GitHub
junrao commented on code in PR #15474: URL: https://github.com/apache/kafka/pull/15474#discussion_r1523649729 ## core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala: ## @@ -19,82 +19,236 @@ package kafka.admin import kafka.integration.KafkaServerTestH

Re: [PR] KAFKA-16226; Reduce synchronization between producer threads (#15323) [kafka]

2024-03-13 Thread via GitHub
msn-tldr commented on PR #15498: URL: https://github.com/apache/kafka/pull/15498#issuecomment-1995048622 The tests failing on jenkins are unrelated, flaky tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] MINOR; Log reason for deleting a kraft snapshot [kafka]

2024-03-13 Thread via GitHub
mumrah commented on code in PR #15478: URL: https://github.com/apache/kafka/pull/15478#discussion_r1523630806 ## core/src/main/scala/kafka/raft/KafkaMetadataLog.scala: ## @@ -404,21 +414,33 @@ final class KafkaMetadataLog private ( * all cases. * * For the given pred

Re: [PR] KAFKA-16314: Introducing the AbortableTransactionException [kafka]

2024-03-13 Thread via GitHub
jolshan commented on code in PR #15486: URL: https://github.com/apache/kafka/pull/15486#discussion_r1523608929 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -42,14 +42,26 @@ object AddPartitionsToTxnManager { val VerificationTimeMsMetricName = "Ve

Re: [PR] KAFKA-16314: Introducing the AbortableTransactionException [kafka]

2024-03-13 Thread via GitHub
jolshan commented on code in PR #15486: URL: https://github.com/apache/kafka/pull/15486#discussion_r1523603267 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -42,14 +42,26 @@ object AddPartitionsToTxnManager { val VerificationTimeMsMetricName = "Ve

Re: [PR] KAFKA-16314: Introducing the AbortableTransactionException [kafka]

2024-03-13 Thread via GitHub
jolshan commented on code in PR #15486: URL: https://github.com/apache/kafka/pull/15486#discussion_r1523597267 ## clients/src/main/java/org/apache/kafka/common/errors/AbortableTransactionException.java: ## @@ -0,0 +1,23 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[PR] Minor: downgrade the minISR warning to debug [kafka]

2024-03-13 Thread via GitHub
CalvinConfluent opened a new pull request, #15529: URL: https://github.com/apache/kafka/pull/15529 Downgrade the log level to avoid spamming the log -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Updated] (KAFKA-16226) Java client: Performance regression in Trogdor benchmark with high partition counts

2024-03-13 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar updated KAFKA-16226: -- Fix Version/s: 3.6.2 (was: 3.6.3) > Java client: Performance regression in Trog

Re: [PR] MINOR: Cleanup BoundedList to Make Constructors More Safe [kafka]

2024-03-13 Thread via GitHub
ChrisAHolland commented on PR #15507: URL: https://github.com/apache/kafka/pull/15507#issuecomment-1994913616 @showuon @jolshan Would appreciate if you could take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-16314: Introducing the AbortableTransactionException [kafka]

2024-03-13 Thread via GitHub
jolshan commented on code in PR #15486: URL: https://github.com/apache/kafka/pull/15486#discussion_r1523586414 ## clients/src/main/java/org/apache/kafka/common/protocol/Errors.java: ## @@ -392,7 +393,8 @@ public enum Errors { UNKNOWN_CONTROLLER_ID(116, "This controller ID i

Re: [PR] MINOR: Only enable replay methods to modify timeline data structure [kafka]

2024-03-13 Thread via GitHub
dongnuo123 commented on code in PR #15528: URL: https://github.com/apache/kafka/pull/15528#discussion_r1523584782 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -593,7 +595,8 @@ public List describeGroups( */ Co

Re: [PR] MINOR: Only enable replay methods to modify timeline data structure [kafka]

2024-03-13 Thread via GitHub
dajac commented on code in PR #15528: URL: https://github.com/apache/kafka/pull/15528#discussion_r1523579678 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -593,7 +595,8 @@ public List describeGroups( */ Consume

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

2024-03-13 Thread via GitHub
dajac commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1523572950 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1211,13 +1192,99 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-14683 Cleanup WorkerSinkTaskTest [kafka]

2024-03-13 Thread via GitHub
OmniaGM commented on code in PR #15506: URL: https://github.com/apache/kafka/pull/15506#discussion_r1523571839 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.java: ## @@ -1215,17 +1195,13 @@ public void testSuppressCloseErrors() {

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

2024-03-13 Thread via GitHub
jolshan commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1523564661 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1211,13 +1192,99 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-14683 Cleanup WorkerSinkTaskTest [kafka]

2024-03-13 Thread via GitHub
gharris1727 commented on code in PR #15506: URL: https://github.com/apache/kafka/pull/15506#discussion_r1523535566 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.java: ## @@ -1215,17 +1195,13 @@ public void testSuppressCloseErrors() {

[jira] [Updated] (KAFKA-16217) Transactional producer stuck in IllegalStateException during close

2024-03-13 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar updated KAFKA-16217: -- Fix Version/s: 3.8.0 3.6.3 (was: 3.6.2) > Transactional prod

[jira] [Updated] (KAFKA-16226) Java client: Performance regression in Trogdor benchmark with high partition counts

2024-03-13 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar updated KAFKA-16226: -- Fix Version/s: 3.6.3 (was: 3.6.2) > Java client: Performance regression in Trog

Re: [PR] KAFKA-16312, KAFKA-16185: Local epochs in reconciliation [kafka]

2024-03-13 Thread via GitHub
lucasbru commented on code in PR #15511: URL: https://github.com/apache/kafka/pull/15511#discussion_r1523523053 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -566,18 +567,18 @@ public ConsumerGroupHeartbeatRequestData b

[jira] [Updated] (KAFKA-16120) Fix partition reassignment during ZK migration

2024-03-13 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-16120: - Fix Version/s: 3.6.2 > Fix partition reassignment during ZK migration >

[jira] [Updated] (KAFKA-16120) Fix partition reassignment during ZK migration

2024-03-13 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-16120: - Affects Version/s: 3.6.1 3.6.0 > Fix partition reassignment during ZK mig

Re: [PR] KAFKA-16312, KAFKA-16185: Local epochs in reconciliation [kafka]

2024-03-13 Thread via GitHub
lucasbru commented on code in PR #15511: URL: https://github.com/apache/kafka/pull/15511#discussion_r1523522542 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -538,16 +539,16 @@ public ConsumerGroupHeartbeatRequestData b

Re: [PR] KAFKA-16312, KAFKA-16185: Local epochs in reconciliation [kafka]

2024-03-13 Thread via GitHub
lucasbru commented on code in PR #15511: URL: https://github.com/apache/kafka/pull/15511#discussion_r1523522030 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -210,12 +213,12 @@ public class MembershipManagerImpl implements

[jira] [Updated] (KAFKA-15689) KRaftMigrationDriver not logging the skipped event when expected state is wrong

2024-03-13 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-15689: - Fix Version/s: 3.6.2 > KRaftMigrationDriver not logging the skipped event when expected state is

Re: [PR] KAFKA-16312, KAFKA-16185: Local epochs in reconciliation [kafka]

2024-03-13 Thread via GitHub
lucasbru commented on code in PR #15511: URL: https://github.com/apache/kafka/pull/15511#discussion_r1523520659 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -530,19 +530,12 @@ public ConsumerGroupHeartbeatRequestData b

[jira] [Resolved] (KAFKA-16171) Controller failover during ZK migration can prevent metadata updates to ZK brokers

2024-03-13 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur resolved KAFKA-16171. -- Resolution: Fixed > Controller failover during ZK migration can prevent metadata updates to ZK

[jira] [Updated] (KAFKA-16139) StreamsUpgradeTest fails consistently in 3.7.0

2024-03-13 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar updated KAFKA-16139: -- Fix Version/s: 3.6.2 (was: 3.6.1) > StreamsUpgradeTest fails consistently in 3.

[jira] [Updated] (KAFKA-15817) Avoid reconnecting to the same IP address if multiple addresses are available

2024-03-13 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar updated KAFKA-15817: -- Fix Version/s: 3.6.2 > Avoid reconnecting to the same IP address if multiple addresses are available >

[jira] [Updated] (KAFKA-16171) Controller failover during ZK migration can prevent metadata updates to ZK brokers

2024-03-13 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-16171: - Fix Version/s: 3.6.2 > Controller failover during ZK migration can prevent metadata updates to Z

  1   2   >