[jira] [Updated] (KAFKA-16411) Correctly migrate default client quota entities in KRaft migration

2024-03-26 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar updated KAFKA-16411: -- Fix Version/s: 3.8.0 3.7.1 > Correctly migrate default client quota entities in KRa

[jira] [Updated] (KAFKA-16428) Fix bug where config change notification znode may not get created during migration

2024-03-26 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar updated KAFKA-16428: -- Fix Version/s: 3.6.2 3.8.0 3.7.1 > Fix bug where config change n

Re: [PR] KAFKA-14588 ZK configuration moved to ZkConfig [kafka]

2024-03-26 Thread via GitHub
chia7712 commented on PR #15075: URL: https://github.com/apache/kafka/pull/15075#issuecomment-2022073236 @nizhikov Could you please rebase it again? Sorry for late review :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (KAFKA-16414) Inconsistent active segment expiration behavior between retention.ms and retention.bytes

2024-03-26 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831186#comment-17831186 ] Chia-Ping Tsai commented on KAFKA-16414: [~ckamal] Thanks for nice sharing. As y

[jira] [Commented] (KAFKA-16429) Enhance all configs which can trigger rolling of new segment

2024-03-26 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831182#comment-17831182 ] Chia-Ping Tsai commented on KAFKA-16429: [~brandboat] Please feel free to un-ass

[jira] [Updated] (KAFKA-16429) Enhance all configs which can trigger rolling of new segment

2024-03-26 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-16429: --- Parent: KAFKA-16385 Issue Type: Sub-task (was: Improvement) > Enhance all configs w

[jira] [Assigned] (KAFKA-16429) Enhance all configs which can trigger rolling of new segment

2024-03-26 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-16429: -- Assignee: Kuan Po Tseng > Enhance all configs which can trigger rolling of new segmen

[jira] [Created] (KAFKA-16429) Enhance all configs which can trigger rolling of new segment

2024-03-26 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-16429: -- Summary: Enhance all configs which can trigger rolling of new segment Key: KAFKA-16429 URL: https://issues.apache.org/jira/browse/KAFKA-16429 Project: Kafka

[jira] [Commented] (KAFKA-16414) Inconsistent active segment expiration behavior between retention.ms and retention.bytes

2024-03-26 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831161#comment-17831161 ] Kamal Chandraprakash commented on KAFKA-16414: -- I noticed the behavior chan

Re: [PR] Kafka-15444: Native docker image for Apache Kafka(KIP-974) [kafka]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #14969: URL: https://github.com/apache/kafka/pull/14969#issuecomment-2021860655 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

Re: [PR] KAFKA-16232: kafka hangs forever in the starting process if the authorizer future is not returned [kafka]

2024-03-26 Thread via GitHub
brandboat commented on code in PR #15549: URL: https://github.com/apache/kafka/pull/15549#discussion_r1540406767 ## core/src/main/scala/kafka/server/KafkaServer.scala: ## @@ -632,6 +634,7 @@ class KafkaServer( case t: Throwable => throw new RuntimeException("Received

Re: [PR] KAFKA-16232: kafka hangs forever in the starting process if the authorizer future is not returned [kafka]

2024-03-26 Thread via GitHub
showuon commented on code in PR #15549: URL: https://github.com/apache/kafka/pull/15549#discussion_r1540405566 ## core/src/main/scala/kafka/server/KafkaServer.scala: ## @@ -632,6 +634,7 @@ class KafkaServer( case t: Throwable => throw new RuntimeException("Received a

[jira] [Resolved] (KAFKA-16391) Cleanup .lock file after server is down

2024-03-26 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-16391. --- Fix Version/s: 3.8.0 Resolution: Fixed > Cleanup .lock file after server is down > --

Re: [PR] KAFKA-16391: Cleanup .lock file after server is down [kafka]

2024-03-26 Thread via GitHub
showuon merged PR #15568: URL: https://github.com/apache/kafka/pull/15568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-16391: Cleanup .lock file after server is down [kafka]

2024-03-26 Thread via GitHub
showuon commented on code in PR #15568: URL: https://github.com/apache/kafka/pull/15568#discussion_r1540402117 ## core/src/test/scala/unit/kafka/raft/RaftManagerTest.scala: ## @@ -178,7 +178,7 @@ class RaftManagerTest { } private def fileLocked(path: Path): Boolean = { -

Re: [PR] MINOR: add docker usage documentation link in README.md [kafka]

2024-03-26 Thread via GitHub
showuon merged PR #15600: URL: https://github.com/apache/kafka/pull/15600 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-16385: Enhance documentation for retention.ms and retention.bytes configurations [kafka]

2024-03-26 Thread via GitHub
showuon commented on PR #15588: URL: https://github.com/apache/kafka/pull/15588#issuecomment-2021842695 Sorry for being late for the review. But do you think we should also add some notes for these related configs? server configs: 1. log.retention.bytes 2. log.retention.hours

Re: [PR] MINOR: add docker usage documentation link in README.md [kafka]

2024-03-26 Thread via GitHub
KevinZTW commented on code in PR #15600: URL: https://github.com/apache/kafka/pull/15600#discussion_r1540391571 ## README.md: ## @@ -87,15 +87,25 @@ fail due to code changes. You can just run: ### Running a Kafka broker in KRaft mode +Using compiled files: + KAFKA_CLUS

Re: [PR] MINOR: add docker usage documentation link in README.md [kafka]

2024-03-26 Thread via GitHub
KevinZTW commented on code in PR #15600: URL: https://github.com/apache/kafka/pull/15600#discussion_r1540387857 ## README.md: ## @@ -285,6 +295,7 @@ See [tests/README.md](tests/README.md). See [vagrant/README.md](vagrant/README.md). + Review Comment: thanks -- This

Re: [PR] MINOR: add docker usage documentation link in README.md [kafka]

2024-03-26 Thread via GitHub
KevinZTW commented on code in PR #15600: URL: https://github.com/apache/kafka/pull/15600#discussion_r1540387857 ## README.md: ## @@ -285,6 +295,7 @@ See [tests/README.md](tests/README.md). See [vagrant/README.md](vagrant/README.md). + Review Comment: thanks... -- Th

[jira] [Assigned] (KAFKA-15715) KRaft support in UpdateFeaturesTest

2024-03-26 Thread johndoe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] johndoe reassigned KAFKA-15715: --- Assignee: johndoe > KRaft support in UpdateFeaturesTest > --- > >

[jira] [Commented] (KAFKA-15713) KRaft support in SaslClientsWithInvalidCredentialsTest

2024-03-26 Thread johndoe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831140#comment-17831140 ] johndoe commented on KAFKA-15713: - Sorry, [~pasharik] , I both searched for Pavel Pozdee

Re: [PR] KAFKA-16397 - Use ByteBufferOutputStream to avoid array copy [kafka]

2024-03-26 Thread via GitHub
chia7712 commented on PR #15589: URL: https://github.com/apache/kafka/pull/15589#issuecomment-2021800318 @apoorvmittal10 Could you please take a look this PR if ur queue is not full :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Resolved] (KAFKA-16385) Segment is rolled before segment.ms or segment.bytes breached

2024-03-26 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16385. Fix Version/s: 3.8.0 Resolution: Fixed > Segment is rolled before segment.ms or seg

Re: [PR] KAFKA-16385: Enhance documentation for retention.ms and retention.bytes configurations [kafka]

2024-03-26 Thread via GitHub
chia7712 merged PR #15588: URL: https://github.com/apache/kafka/pull/15588 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16385: Enhance documentation for retention.ms and retention.bytes configurations [kafka]

2024-03-26 Thread via GitHub
chia7712 commented on PR #15588: URL: https://github.com/apache/kafka/pull/15588#issuecomment-2021795623 ```sh ./gradlew cleanTest :streams:test --tests TaskMetadataIntegrationTest.shouldReportCorrectEndOffsetInformation :storage:test --tests TransactionsWithTieredStoreTest.testBumpTran

[jira] [Updated] (KAFKA-16428) Fix bug where config change notification znode may not get created during migration

2024-03-26 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-16428: --- Affects Version/s: 3.6.1 3.7.0 > Fix bug where config change notifica

Re: [PR] MINOR: add docker usage documentation link in README.md [kafka]

2024-03-26 Thread via GitHub
showuon commented on code in PR #15600: URL: https://github.com/apache/kafka/pull/15600#discussion_r1540361241 ## README.md: ## @@ -87,15 +87,25 @@ fail due to code changes. You can just run: ### Running a Kafka broker in KRaft mode +Using compiled files: + KAFKA_CLUST

Re: [PR] MINOR: add docker usage documentation link in README.md [kafka]

2024-03-26 Thread via GitHub
showuon commented on code in PR #15600: URL: https://github.com/apache/kafka/pull/15600#discussion_r1540318413 ## README.md: ## @@ -285,6 +295,7 @@ See [tests/README.md](tests/README.md). See [vagrant/README.md](vagrant/README.md). + Review Comment: additional empty lin

[jira] [Commented] (KAFKA-16389) consumer_test.py’s test_valid_assignment fails with new consumer

2024-03-26 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831122#comment-17831122 ] Chia-Ping Tsai commented on KAFKA-16389: {quote} Our goal is to bring the async

[jira] [Created] (KAFKA-16428) Fix bug where config change notification znode may not get created during migration

2024-03-26 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-16428: Summary: Fix bug where config change notification znode may not get created during migration Key: KAFKA-16428 URL: https://issues.apache.org/jira/browse/KAFKA-16428 P

Re: [PR] KAFKA-16411: Correctly migrate default client quota entities [kafka]

2024-03-26 Thread via GitHub
cmccabe merged PR #15584: URL: https://github.com/apache/kafka/pull/15584 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Comment Edited] (KAFKA-16200) Enforce that RequestManager implementations respect user-provided timeout

2024-03-26 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831107#comment-17831107 ] Kirk True edited comment on KAFKA-16200 at 3/26/24 11:45 PM: -

[jira] [Commented] (KAFKA-16200) Enforce that RequestManager implementations respect user-provided timeout

2024-03-26 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831107#comment-17831107 ] Kirk True commented on KAFKA-16200: --- Making progress, need to do the following tasks:

Re: [PR] MINOR: AbstractConfig cleanup [kafka]

2024-03-26 Thread via GitHub
C0urante commented on code in PR #15597: URL: https://github.com/apache/kafka/pull/15597#discussion_r1540232126 ## clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java: ## @@ -547,6 +552,17 @@ private Map extractPotentialVariables(Map configMap) { r

Re: [PR] KAFKA-7663: Reprocessing on user added global stores restore [kafka]

2024-03-26 Thread via GitHub
mjsax commented on PR #15414: URL: https://github.com/apache/kafka/pull/15414#issuecomment-2021597301 Jenkins needs a re-run... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] KAFKA-7663: Reprocessing on user added global stores restore [kafka]

2024-03-26 Thread via GitHub
mjsax commented on code in PR #15414: URL: https://github.com/apache/kafka/pull/15414#discussion_r1540190176 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java: ## @@ -252,6 +252,11 @@ private List topicPartitionsForStore(final Sta

Re: [PR] MINOR: AbstractConfig cleanup [kafka]

2024-03-26 Thread via GitHub
gharris1727 commented on code in PR #15597: URL: https://github.com/apache/kafka/pull/15597#discussion_r1540169589 ## clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java: ## @@ -547,6 +552,17 @@ private Map extractPotentialVariables(Map configMap) {

Re: [PR] MINOR: AbstractConfig cleanup [kafka]

2024-03-26 Thread via GitHub
gharris1727 commented on code in PR #15597: URL: https://github.com/apache/kafka/pull/15597#discussion_r1540167974 ## clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java: ## @@ -547,6 +552,17 @@ private Map extractPotentialVariables(Map configMap) {

Re: [PR] KAFKA-15538: Client support for java regex based subscription [kafka]

2024-03-26 Thread via GitHub
Phuc-Hong-Tran commented on PR #15585: URL: https://github.com/apache/kafka/pull/15585#issuecomment-2021544620 Thanks for the comments @lianetm @kirktrue, I'll try to address those asap -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-15538: Client support for java regex based subscription [kafka]

2024-03-26 Thread via GitHub
Phuc-Hong-Tran commented on code in PR #15585: URL: https://github.com/apache/kafka/pull/15585#discussion_r1540153302 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1750,8 +1753,14 @@ private void subscribeInternal(Pattern pa

Re: [PR] KAFKA-15538: Client support for java regex based subscription [kafka]

2024-03-26 Thread via GitHub
Phuc-Hong-Tran commented on code in PR #15585: URL: https://github.com/apache/kafka/pull/15585#discussion_r1540156766 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1750,8 +1753,14 @@ private void subscribeInternal(Pattern pa

Re: [PR] MINOR: AbstractConfig cleanup [kafka]

2024-03-26 Thread via GitHub
C0urante commented on code in PR #15597: URL: https://github.com/apache/kafka/pull/15597#discussion_r1540093517 ## clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java: ## @@ -461,6 +497,25 @@ public void testAutoConfigResolutionWithInvalidConfigProvider

Re: [PR] KAFKA-15538: Client support for java regex based subscription [kafka]

2024-03-26 Thread via GitHub
Phuc-Hong-Tran commented on code in PR #15585: URL: https://github.com/apache/kafka/pull/15585#discussion_r1540153302 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1750,8 +1753,14 @@ private void subscribeInternal(Pattern pa

Re: [PR] KAFKA-16362 Fix type-unsafety in KStreamKStreamJoin caused by isLeftSide [kafka]

2024-03-26 Thread via GitHub
gharris1727 commented on code in PR #15601: URL: https://github.com/apache/kafka/pull/15601#discussion_r1540138631 ## streams/src/main/java/org/apache/kafka/streams/state/internals/LeftOrRightValue.java: ## @@ -39,45 +39,6 @@ private LeftOrRightValue(final V1 leftValue, final V2

Re: [PR] KAFKA-15538: Client support for java regex based subscription [kafka]

2024-03-26 Thread via GitHub
Phuc-Hong-Tran commented on code in PR #15585: URL: https://github.com/apache/kafka/pull/15585#discussion_r1540149023 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1750,8 +1753,14 @@ private void subscribeInternal(Pattern pa

Re: [PR] KAFKA-15538: Client support for java regex based subscription [kafka]

2024-03-26 Thread via GitHub
Phuc-Hong-Tran commented on code in PR #15585: URL: https://github.com/apache/kafka/pull/15585#discussion_r1540147833 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1667,6 +1667,9 @@ private void updateLastSeenEpochIfNewer(To

Re: [PR] KAFKA-15538: Client support for java regex based subscription [kafka]

2024-03-26 Thread via GitHub
Phuc-Hong-Tran commented on PR #15585: URL: https://github.com/apache/kafka/pull/15585#issuecomment-2021526537 @kirktrue, regarding https://github.com/apache/kafka/pull/15585#discussion_r1539447102, there is a race condition bug where the metadata is not updated but the heartbeat request i

Re: [PR] KAFKA-15538: Client support for java regex based subscription [kafka]

2024-03-26 Thread via GitHub
Phuc-Hong-Tran commented on PR #15585: URL: https://github.com/apache/kafka/pull/15585#issuecomment-2021522732 @kirktrue, regarding comment https://github.com/apache/kafka/pull/15585#discussion_r1539447785, I decided to call `metadata.requestUpdateForNewTopics` since there is a quite delay

Re: [PR] KAFKA-15556: Remove NetworkClientDelegate methods isUnavailable, maybeThrowAuthFailure, and tryConnect [kafka]

2024-03-26 Thread via GitHub
Phuc-Hong-Tran commented on PR #15020: URL: https://github.com/apache/kafka/pull/15020#issuecomment-2021513019 @kirktrue, it's ready for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-15867: Should ConsumerNetworkThread wrap the exception and notify the polling thread? [kafka]

2024-03-26 Thread via GitHub
Phuc-Hong-Tran commented on PR #15312: URL: https://github.com/apache/kafka/pull/15312#issuecomment-2021512097 @kirktrue, I will -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] KAFKA-16362 Fix type-unsafety in KStreamKStreamJoin caused by isLeftSide [kafka]

2024-03-26 Thread via GitHub
gharris1727 commented on code in PR #15601: URL: https://github.com/apache/kafka/pull/15601#discussion_r1540136195 ## streams/src/main/java/org/apache/kafka/streams/state/internals/LeftOrRightValue.java: ## Review Comment: I assumed that this would be necessary. I think eit

Re: [PR] KAFKA-16084: Simplify and deduplicate standalone herder test mocking [kafka]

2024-03-26 Thread via GitHub
gharris1727 merged PR #15389: URL: https://github.com/apache/kafka/pull/15389 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

Re: [PR] KAFKA-16084: Simplify and deduplicate standalone herder test mocking [kafka]

2024-03-26 Thread via GitHub
gharris1727 commented on PR #15389: URL: https://github.com/apache/kafka/pull/15389#issuecomment-2021497976 Test failures appear unrelated, and the connect:runtime tests pass for me locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] KAFKA-16200: Enforce that RequestManager implementations respect user-provided timeout [kafka]

2024-03-26 Thread via GitHub
kirktrue closed pull request #15599: KAFKA-16200: Enforce that RequestManager implementations respect user-provided timeout URL: https://github.com/apache/kafka/pull/15599 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[jira] [Assigned] (KAFKA-16427) KafkaConsumer#position() does not respect timeout when group protocol is CONSUMER

2024-03-26 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16427: - Assignee: Kirk True > KafkaConsumer#position() does not respect timeout when group protocol is

[jira] [Updated] (KAFKA-16427) KafkaConsumer#position() does not respect timeout when group protocol is CONSUMER

2024-03-26 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16427: -- Component/s: clients consumer > KafkaConsumer#position() does not respect timeout whe

[jira] [Updated] (KAFKA-16427) KafkaConsumer#position() does not respect timeout when group protocol is CONSUMER

2024-03-26 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16427: -- Fix Version/s: 3.8.0 > KafkaConsumer#position() does not respect timeout when group protocol is > CON

[jira] [Updated] (KAFKA-16427) KafkaConsumer#position() does not respect timeout when group protocol is CONSUMER

2024-03-26 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16427: -- Labels: consumer-threading-refactor timeout (was: ) > KafkaConsumer#position() does not respect timeo

Re: [PR] KAFKA-16156: beginningOrEndOffsets does not need to build an OffsetAndTimestamps object upon completion [kafka]

2024-03-26 Thread via GitHub
philipnee commented on code in PR #15525: URL: https://github.com/apache/kafka/pull/15525#discussion_r1540114887 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ListOffsetsEvent.java: ## @@ -25,22 +25,15 @@ import java.util.Map; /** - * Event for

Re: [PR] MINOR: AbstractConfig cleanup [kafka]

2024-03-26 Thread via GitHub
gharris1727 commented on code in PR #15597: URL: https://github.com/apache/kafka/pull/15597#discussion_r1540111732 ## clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java: ## @@ -58,6 +61,8 @@ public class AbstractConfig { private final ConfigDef defin

[jira] [Assigned] (KAFKA-16407) ForeignKey INNER join ignores FK change when its previous value is null

2024-03-26 Thread Ayoub Omari (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayoub Omari reassigned KAFKA-16407: --- Assignee: Ayoub Omari > ForeignKey INNER join ignores FK change when its previous value is

[PR] KAFKA-16394: Fix null propagation in foreign key join result [kafka]

2024-03-26 Thread via GitHub
AyoubOm opened a new pull request, #15607: URL: https://github.com/apache/kafka/pull/15607 This fixes the two issues reported in KAFKA-16394, which are: - Null should not be propagated to the join result when changing a foreign key - Null should not be propagated twice in the join

Re: [PR] AKCORE-49-2: Changed the logic of handle share fetch to allow proper authorization of topics [kafka]

2024-03-26 Thread via GitHub
chirag-wadhwa5 closed pull request #15606: AKCORE-49-2: Changed the logic of handle share fetch to allow proper authorization of topics URL: https://github.com/apache/kafka/pull/15606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[PR] AKCORE-49-2: Changed the logic of handle share fetch to allow proper authorization of topics [kafka]

2024-03-26 Thread via GitHub
chirag-wadhwa5 opened a new pull request, #15606: URL: https://github.com/apache/kafka/pull/15606 This PR contains minor changed in handleShareFetchRequest to allow proper authorization -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] KAFKA-15538: Client support for java regex based subscription [kafka]

2024-03-26 Thread via GitHub
lianetm commented on code in PR #15585: URL: https://github.com/apache/kafka/pull/15585#discussion_r1539955531 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -550,6 +550,11 @@ public ConsumerGroupHeartbeatRequestData bui

Re: [PR] KAFKA-15538: Client support for java regex based subscription [kafka]

2024-03-26 Thread via GitHub
lianetm commented on code in PR #15585: URL: https://github.com/apache/kafka/pull/15585#discussion_r1539955531 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -550,6 +550,11 @@ public ConsumerGroupHeartbeatRequestData bui

[jira] [Commented] (KAFKA-15538) Client support for java regex based subscription

2024-03-26 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831050#comment-17831050 ] Lianet Magrans commented on KAFKA-15538: Hey [~kirktrue], I noticed this stayed

Re: [PR] KAFKA-12359: Update Jetty to 11 [kafka]

2024-03-26 Thread via GitHub
cshannon commented on PR #10176: URL: https://github.com/apache/kafka/pull/10176#issuecomment-2021244915 I started a new [thread](https://lists.apache.org/thread/p4qbqh8r77h4khn3yoof2b0gbq3wbc5q) on the dev list about this. I think it's very important to upgrade for Kafka 4.0 as many libra

Re: [PR] KAFKA-16156: beginningOrEndOffsets does not need to build an OffsetAndTimestamps object upon completion [kafka]

2024-03-26 Thread via GitHub
lianetm commented on code in PR #15525: URL: https://github.com/apache/kafka/pull/15525#discussion_r1539933946 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ListOffsetsEvent.java: ## @@ -25,22 +25,15 @@ import java.util.Map; /** - * Event for re

[jira] [Commented] (KAFKA-15538) Client support for java regex based subscription

2024-03-26 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831034#comment-17831034 ] Kirk True commented on KAFKA-15538: --- [~phuctran]—The {{ConsumerCoordinator}} has code

Re: [PR] KAFKA-15867: Should ConsumerNetworkThread wrap the exception and notify the polling thread? [kafka]

2024-03-26 Thread via GitHub
jeffkbkim commented on code in PR #15312: URL: https://github.com/apache/kafka/pull/15312#discussion_r1539875541 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java: ## @@ -87,8 +92,8 @@ public void run() { try {

[jira] [Commented] (KAFKA-15558) Determine if Timer should be used elsewhere in PrototypeAsyncConsumer.updateFetchPositions()

2024-03-26 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831031#comment-17831031 ] Kirk True commented on KAFKA-15558: --- [~schofielaj]—can you follow up on [~phuctran]’s

[jira] [Commented] (KAFKA-16022) AsyncKafkaConsumer sometimes complains “No current assignment for partition {}”

2024-03-26 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831030#comment-17831030 ] Kirk True commented on KAFKA-16022: --- [~pnee]—can you follow up on [~phuctran]'s questi

Re: [PR] KAFKA-15556: Remove NetworkClientDelegate methods isUnavailable, maybeThrowAuthFailure, and tryConnect [kafka]

2024-03-26 Thread via GitHub
kirktrue commented on PR #15020: URL: https://github.com/apache/kafka/pull/15020#issuecomment-2021167612 @Phuc-Hong-Tran—is this PR ready for review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Created] (KAFKA-16427) KafkaConsumer#position() does not respect timeout when group protocol is CONSUMER

2024-03-26 Thread Alyssa Huang (Jira)
Alyssa Huang created KAFKA-16427: Summary: KafkaConsumer#position() does not respect timeout when group protocol is CONSUMER Key: KAFKA-16427 URL: https://issues.apache.org/jira/browse/KAFKA-16427 Pro

[jira] [Commented] (KAFKA-15713) KRaft support in SaslClientsWithInvalidCredentialsTest

2024-03-26 Thread Pavel Pozdeev (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831025#comment-17831025 ] Pavel Pozdeev commented on KAFKA-15713: --- [~johndoe] no problem :) Would you mind

Re: [PR] KAFKA-16272: Update connect_distributed_test.py to support KIP-848’s group protocol config [kafka]

2024-03-26 Thread via GitHub
philipnee commented on PR #15576: URL: https://github.com/apache/kafka/pull/15576#issuecomment-2021140028 @lucasbru @kirktrue - Sorry for the oversight. I pushed out the changes to address Kirk's comment. -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] KAFKA-16148: Implement GroupMetadataManager#onUnloaded [kafka]

2024-03-26 Thread via GitHub
jeffkbkim commented on code in PR #15446: URL: https://github.com/apache/kafka/pull/15446#discussion_r1539809862 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1920,6 +1921,49 @@ public void onLoaded() { });

Re: [PR] Image test improvements [kafka]

2024-03-26 Thread via GitHub
mimaison commented on code in PR #15373: URL: https://github.com/apache/kafka/pull/15373#discussion_r1539799687 ## metadata/src/test/java/org/apache/kafka/image/ClusterImageTest.java: ## @@ -186,6 +264,19 @@ public void testImage2RoundTrip() { testToImage(IMAGE2);

[jira] [Comment Edited] (KAFKA-16389) consumer_test.py’s test_valid_assignment fails with new consumer

2024-03-26 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831016#comment-17831016 ] Philip Nee edited comment on KAFKA-16389 at 3/26/24 5:27 PM: -

[jira] [Commented] (KAFKA-16389) consumer_test.py’s test_valid_assignment fails with new consumer

2024-03-26 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831016#comment-17831016 ] Philip Nee commented on KAFKA-16389: Hey [~chia7712] - We are currently setting up t

Re: [PR] MINOR: AbstractConfig cleanup [kafka]

2024-03-26 Thread via GitHub
mimaison commented on code in PR #15597: URL: https://github.com/apache/kafka/pull/15597#discussion_r1539776305 ## clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java: ## @@ -58,6 +61,8 @@ public class AbstractConfig { private final ConfigDef definiti

[jira] [Assigned] (KAFKA-16389) consumer_test.py’s test_valid_assignment fails with new consumer

2024-03-26 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee reassigned KAFKA-16389: -- Assignee: Philip Nee > consumer_test.py’s test_valid_assignment fails with new consumer > ---

[jira] [Resolved] (KAFKA-16416) Use NetworkClientTest to replace RequestResponseTest to be the example of log4j output

2024-03-26 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16416. Fix Version/s: 3.8.0 Resolution: Fixed > Use NetworkClientTest to replace RequestRe

Re: [PR] KAFKA-16416: Use NetworkClientTest to replace RequestResponseTest to be the example of log4j output [kafka]

2024-03-26 Thread via GitHub
chia7712 merged PR #15596: URL: https://github.com/apache/kafka/pull/15596 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16156: beginningOrEndOffsets does not need to build an OffsetAndTimestamps object upon completion [kafka]

2024-03-26 Thread via GitHub
philipnee commented on PR #15525: URL: https://github.com/apache/kafka/pull/15525#issuecomment-2020963772 @lucasbru - Thanks again for reviewing the PR. Sorry about the misinterpretation on short circuting logic so here I updated the beginningOrEndOffsets API. It seems like the right thin

[jira] [Updated] (KAFKA-7663) Custom Processor supplied on addGlobalStore is not used when restoring state from topic

2024-03-26 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson updated KAFKA-7663: -- Fix Version/s: 3.8.0 > Custom Processor supplied on addGlobalStore is not used when restoring s

[PR] MINOR: Flaky ProducerIdManagerTest error injection fix [kafka]

2024-03-26 Thread via GitHub
akatona84 opened a new pull request, #15605: URL: https://github.com/apache/kafka/pull/15605 testUnrecoverableErrors was flaky as the wanted error either affected the next block request (prefecthing) or just missed that. ### Committer Checklist (excluded from commit message) - [ ]

Re: [PR] KAFKA-16156: beginningOrEndOffsets does not need to build an OffsetAndTimestamps object upon completion [kafka]

2024-03-26 Thread via GitHub
philipnee commented on code in PR #15525: URL: https://github.com/apache/kafka/pull/15525#discussion_r1539524047 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1141,21 +1141,27 @@ private Map beginningOrEndOffset(Collection

Re: [PR] KAFKA-16353: Offline protocol migration integration tests [kafka]

2024-03-26 Thread via GitHub
dongnuo123 commented on code in PR #15492: URL: https://github.com/apache/kafka/pull/15492#discussion_r1539521510 ## core/src/test/scala/unit/kafka/server/GroupCoordinatorBaseRequestTest.scala: ## @@ -82,7 +83,7 @@ class GroupCoordinatorBaseRequestTest(cluster: ClusterInstance)

Re: [PR] KAFKA-14588 ZK configuration moved to ZkConfig [kafka]

2024-03-26 Thread via GitHub
nizhikov commented on PR #15075: URL: https://github.com/apache/kafka/pull/15075#issuecomment-2020778443 @chia7712 All your comments resolved. Please, take a look one more time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] KAFKA-14588 ZK configuration moved to ZkConfig [kafka]

2024-03-26 Thread via GitHub
nizhikov commented on code in PR #15075: URL: https://github.com/apache/kafka/pull/15075#discussion_r1539513879 ## server/src/main/java/org/apache/kafka/server/config/ZkConfig.java: ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] KAFKA-14588 ZK configuration moved to ZkConfig [kafka]

2024-03-26 Thread via GitHub
nizhikov commented on code in PR #15075: URL: https://github.com/apache/kafka/pull/15075#discussion_r1539504855 ## checkstyle/import-control-server.xml: ## @@ -82,6 +82,9 @@ + + Review Comment: Done. ## checkstyle/import-control-jmh

Re: [PR] KAFKA-16353: Offline protocol migration integration tests [kafka]

2024-03-26 Thread via GitHub
dongnuo123 commented on code in PR #15492: URL: https://github.com/apache/kafka/pull/15492#discussion_r1539503171 ## core/src/test/scala/unit/kafka/server/GroupCoordinatorBaseRequestTest.scala: ## @@ -73,6 +74,17 @@ class GroupCoordinatorBaseRequestTest(cluster: ClusterInstance

Re: [PR] KAFKA-14588 ZK configuration moved to ZkConfig [kafka]

2024-03-26 Thread via GitHub
nizhikov commented on code in PR #15075: URL: https://github.com/apache/kafka/pull/15075#discussion_r1539504425 ## server/src/main/java/org/apache/kafka/server/config/ZkConfig.java: ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] KAFKA-16353: Offline protocol migration integration tests [kafka]

2024-03-26 Thread via GitHub
dajac commented on code in PR #15492: URL: https://github.com/apache/kafka/pull/15492#discussion_r1539500107 ## core/src/test/scala/unit/kafka/server/GroupCoordinatorBaseRequestTest.scala: ## @@ -82,7 +83,7 @@ class GroupCoordinatorBaseRequestTest(cluster: ClusterInstance) {

Re: [PR] KAFKA-16353: Offline protocol migration integration tests [kafka]

2024-03-26 Thread via GitHub
dajac commented on code in PR #15492: URL: https://github.com/apache/kafka/pull/15492#discussion_r1539495661 ## core/src/test/scala/unit/kafka/server/GroupCoordinatorBaseRequestTest.scala: ## @@ -82,7 +83,7 @@ class GroupCoordinatorBaseRequestTest(cluster: ClusterInstance) {

Re: [PR] KAFKA-16353: Offline protocol migration integration tests [kafka]

2024-03-26 Thread via GitHub
dajac commented on code in PR #15492: URL: https://github.com/apache/kafka/pull/15492#discussion_r1539493833 ## core/src/test/scala/unit/kafka/server/GroupCoordinatorBaseRequestTest.scala: ## @@ -73,6 +74,17 @@ class GroupCoordinatorBaseRequestTest(cluster: ClusterInstance) {

Re: [PR] KAFKA-16353: Offline protocol migration integration tests [kafka]

2024-03-26 Thread via GitHub
dongnuo123 commented on code in PR #15492: URL: https://github.com/apache/kafka/pull/15492#discussion_r1539484746 ## core/src/test/scala/unit/kafka/server/GroupCoordinatorBaseRequestTest.scala: ## @@ -73,6 +74,17 @@ class GroupCoordinatorBaseRequestTest(cluster: ClusterInstance

  1   2   >