Re: [PR] KAFKA-16076: Interrupting the currentThread fix [kafka]

2024-04-06 Thread via GitHub
github-actions[bot] commented on PR #15110: URL: https://github.com/apache/kafka/pull/15110#issuecomment-2041295728 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] MINOR; Missing minISR config should log a debug message [kafka]

2024-04-06 Thread via GitHub
jsancio merged PR #15529: URL: https://github.com/apache/kafka/pull/15529 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16477: Detect thread leaked client-metrics-reaper in tests [kafka]

2024-04-06 Thread via GitHub
chia7712 commented on code in PR #15668: URL: https://github.com/apache/kafka/pull/15668#discussion_r1554647591 ## server-common/src/main/java/org/apache/kafka/server/util/timer/SystemTimerReaper.java: ## @@ -76,4 +76,17 @@ public void run() {} reaper.awaitShutdown();

Re: [PR] KAFKA-16477: Detect thread leaked client-metrics-reaper in tests [kafka]

2024-04-06 Thread via GitHub
brandboat commented on code in PR #15668: URL: https://github.com/apache/kafka/pull/15668#discussion_r1554644159 ## server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java: ## @@ -112,7 +113,7 @@ public ClientMetricsManager(ClientMetricsReceiverPlugin

[jira] [Assigned] (KAFKA-16481) Fix flaky kafka.server.ReplicaManagerTest#testRemoteLogReaderMetrics

2024-04-06 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao reassigned KAFKA-16481: - Assignee: Sagar Rao > Fix flaky kafka.server.ReplicaManagerTest#testRemoteLogReaderMetrics >

Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-04-06 Thread via GitHub
chia7712 commented on PR #15489: URL: https://github.com/apache/kafka/pull/15489#issuecomment-2041136463 rebase to trigger QA again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-16310 ListOffsets doesn't report the offset with maxTimestamp a… [kafka]

2024-04-06 Thread via GitHub
chia7712 commented on code in PR #15621: URL: https://github.com/apache/kafka/pull/15621#discussion_r1554638802 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1337,13 +1337,15 @@ class UnifiedLog(@volatile var logStartOffset: Long, } else if (targetTimestamp

Re: [PR] KAFKA-16294: Add group protocol migration enabling config [kafka]

2024-04-06 Thread via GitHub
dongnuo123 commented on code in PR #15411: URL: https://github.com/apache/kafka/pull/15411#discussion_r1554638676 ## core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala: ## @@ -1831,6 +1832,22 @@ class KafkaConfigTest {

[jira] [Assigned] (KAFKA-16478) Links for Kafka 3.5.2 release are broken

2024-04-06 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison reassigned KAFKA-16478: -- Assignee: Mickael Maison > Links for Kafka 3.5.2 release are broken >

[jira] [Commented] (KAFKA-16478) Links for Kafka 3.5.2 release are broken

2024-04-06 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834534#comment-17834534 ] Mickael Maison commented on KAFKA-16478: I moved 3.5.2 to the archives when we released 3.7 but

Re: [PR] KAFKA-16310 ListOffsets doesn't report the offset with maxTimestamp a… [kafka]

2024-04-06 Thread via GitHub
junrao commented on code in PR #15621: URL: https://github.com/apache/kafka/pull/15621#discussion_r1554155328 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1337,13 +1337,15 @@ class UnifiedLog(@volatile var logStartOffset: Long, } else if (targetTimestamp ==

Re: [PR] KAFKA-16310 ListOffsets doesn't report the offset with maxTimestamp a… [kafka]

2024-04-06 Thread via GitHub
chia7712 commented on PR #15621: URL: https://github.com/apache/kafka/pull/15621#issuecomment-2041118676 ``` Build / JDK 21 and Scala 2.13 / testReplicateSourceDefault() – org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationBaseTest ```

Re: [PR] MINOR: Improvements to release.py [kafka]

2024-04-06 Thread via GitHub
omkreddy merged PR #15651: URL: https://github.com/apache/kafka/pull/15651 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (KAFKA-16481) Fix flaky kafka.server.ReplicaManagerTest#testRemoteLogReaderMetrics

2024-04-06 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-16481: -- Summary: Fix flaky kafka.server.ReplicaManagerTest#testRemoteLogReaderMetrics Key: KAFKA-16481 URL: https://issues.apache.org/jira/browse/KAFKA-16481 Project:

Re: [PR] KAFKA-16477: Detect thread leaked client-metrics-reaper in tests [kafka]

2024-04-06 Thread via GitHub
chia7712 commented on code in PR #15668: URL: https://github.com/apache/kafka/pull/15668#discussion_r1554626964 ## server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java: ## @@ -112,7 +113,7 @@ public ClientMetricsManager(ClientMetricsReceiverPlugin

Re: [PR] MINOR: Default test name added to tools [kafka]

2024-04-06 Thread via GitHub
nizhikov commented on PR #15666: URL: https://github.com/apache/kafka/pull/15666#issuecomment-2041051125 @chia7712 latest trunk merged. Please, take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] MINOR: Default test name added to tools [kafka]

2024-04-06 Thread via GitHub
nizhikov commented on PR #15666: URL: https://github.com/apache/kafka/pull/15666#issuecomment-2041051035 Trunk test names: ![Снимок экрана 2024-04-06 в 14 12 12](https://github.com/apache/kafka/assets/880793/3886034f-de2c-4a73-9ef6-4afa55fde594) PR test names: ![Снимок

Re: [PR] KAFKA-16293: Test log directory failure in Kraft [kafka]

2024-04-06 Thread via GitHub
showuon merged PR #15409: URL: https://github.com/apache/kafka/pull/15409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16293: Test log directory failure in Kraft [kafka]

2024-04-06 Thread via GitHub
showuon commented on PR #15409: URL: https://github.com/apache/kafka/pull/15409#issuecomment-2041009723 Confirmed all tests passed after https://github.com/apache/kafka/pull/15335 merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] KAFKA-13907: Fix hanging ServerShutdownTest.testCleanShutdownWithKRaftControllerUnavailable [kafka]

2024-04-06 Thread via GitHub
soarez commented on code in PR #12174: URL: https://github.com/apache/kafka/pull/12174#discussion_r1554541084 ## core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala: ## @@ -260,9 +274,12 @@ abstract class KafkaServerTestHarness extends QuorumTestHarness {

Re: [PR] KAFKA-16455: Check partition exists before send reassignments to server in ReassignPartitionsCommand [kafka]

2024-04-06 Thread via GitHub
brandboat commented on code in PR #15659: URL: https://github.com/apache/kafka/pull/15659#discussion_r1554537353 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java: ## @@ -300,6 +300,12 @@ public void testGetReplicaAssignments() throws

Re: [PR] KAFKA-16472: Fix integration tests in Java with parameter name [kafka]

2024-04-06 Thread via GitHub
showuon commented on PR #15663: URL: https://github.com/apache/kafka/pull/15663#issuecomment-2040993296 LGTM! Thanks @FrankYang0529 ! Really nice catch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-16455: Check partition exists before send reassignments to server in ReassignPartitionsCommand [kafka]

2024-04-06 Thread via GitHub
showuon commented on code in PR #15659: URL: https://github.com/apache/kafka/pull/15659#discussion_r1554536274 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java: ## @@ -300,6 +300,12 @@ public void testGetReplicaAssignments() throws

[jira] [Resolved] (KAFKA-16234) Log directory failure re-creates partitions in another logdir automatically

2024-04-06 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-16234. --- Resolution: Fixed > Log directory failure re-creates partitions in another logdir automatically >

Re: [PR] KAFKA-16234: Log directory failure re-creates partitions in another logdir automatically [kafka]

2024-04-06 Thread via GitHub
showuon merged PR #15335: URL: https://github.com/apache/kafka/pull/15335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16234: Log directory failure re-creates partitions in another logdir automatically [kafka]

2024-04-06 Thread via GitHub
showuon commented on PR #15335: URL: https://github.com/apache/kafka/pull/15335#issuecomment-2040991135 Failed tests are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] MINOR: Cleanup in MetadataShell [kafka]

2024-04-06 Thread via GitHub
wernerdv commented on PR #15672: URL: https://github.com/apache/kafka/pull/15672#issuecomment-2040983038 @cmccabe @chia7712 Hello, PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] KAFKA-16480: Bump ListOffsets version, IBP version and mark last version of ListOffsets as unstable [kafka]

2024-04-06 Thread via GitHub
clolov opened a new pull request, #15673: URL: https://github.com/apache/kafka/pull/15673 ### Summary This is a follow-up of https://github.com/apache/kafka/pull/15213 where I missed updating the API version and the IBP version. I chose to mark the latest version of the ListOffsets

[jira] [Created] (KAFKA-16480) ListOffsets change should have an associated API/IBP version update

2024-04-06 Thread Christo Lolov (Jira)
Christo Lolov created KAFKA-16480: - Summary: ListOffsets change should have an associated API/IBP version update Key: KAFKA-16480 URL: https://issues.apache.org/jira/browse/KAFKA-16480 Project: Kafka

Re: [PR] MINOR: Improvements to release.py [kafka]

2024-04-06 Thread via GitHub
omkreddy commented on code in PR #15651: URL: https://github.com/apache/kafka/pull/15651#discussion_r1554531283 ## release.py: ## @@ -348,6 +348,9 @@ def command_release_announcement_email(): +An overview of the release and its notable changes can be found in the +release

[PR] MINOR: Cleanup in MetadataShell [kafka]

2024-04-06 Thread via GitHub
wernerdv opened a new pull request, #15672: URL: https://github.com/apache/kafka/pull/15672 Removed unnecessary exceptions from the throw list. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build